From nobody Tue Dec 16 23:59:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07869C7EE2C for ; Thu, 24 Aug 2023 18:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242103AbjHXSkn (ORCPT ); Thu, 24 Aug 2023 14:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240927AbjHXSkY (ORCPT ); Thu, 24 Aug 2023 14:40:24 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5183DE50 for ; Thu, 24 Aug 2023 11:40:22 -0700 (PDT) Received: from fabians-envy.localnet ([84.177.92.38]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mk178-1ptHjU2ibI-00kOg3; Thu, 24 Aug 2023 20:40:08 +0200 From: Fabian Vogt To: SungHwan Jung , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, perex@perex.cz Subject: [PATCH v2] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx Date: Thu, 24 Aug 2023 20:39:48 +0200 Message-ID: <2693091.mvXUDI8C0e@fabians-envy> In-Reply-To: <87r0ns8hej.wl-tiwai@suse.de> References: <4504056.LvFx2qVVIh@fabians-envy> <20230824173718.7992-1-onenowy@gmail.com> <87r0ns8hej.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:W7blxS3c6dpEQm6rYd4+kSQFGJle9djrEhphObjfCnhDatm1j4j 02Ie9OO9hnZGp/mXZ4FN106ydEqaAa9z80N74EuL/9xUtM9q6TTcWCa3YcleUP2tkBupi+R VI3qLKrseMXEgcjaw8vyY1Ibb/l1j5hqoS6W0tDok3P2CDVG9SmV+vLn8PkKxDLoxEQ6qeC sbRXy5YBgFu2fkZZjVgCA== UI-OutboundReport: notjunk:1;M01:P0:pQ3ElwUF68g=;ru8XSV0NIDe7i6IoljC8Y27GxyW EwOaJXwlumBXcqL5Tf11L9IsGjnjR398xIHuBGh+UDVh2iBKTgHzLgZeCzdNhpb42asOU867s neRpnSPL2kgp3PYIqbQPulGBdx6eNpkkcs95to2mTKa/s0YPXgaFm+amD52j2jCqmL3y3vT/d oOt2PY9E4ec1fWEMbBqdvUGtwfEf5YSiUYCjNaOU3y9FI3NKGYVB1FfzJ7GXDGJHPkJ04ypEI F7aXNU0e28L6bY6zpasOMAUnPn3Fb5ZD+IO+aAwqNXCCsMN2YPVXqoPQ5AlGwNquk9iKbLCw8 yHC4k81H0WixkBU//w91bE9AdP5VGFmf+zGvtbmuf7KnOh4JCWd7hixQuytjr72Fhmpi8pn3j Hq3zM0V7BpxB5++M0k2qNH72+PpzDHjSUUnh+zUKRsZFCHo0HWC7eo74mV8gd0IVAPymeKtK5 MWRmiiVnwQpxK8TWDL/9bLL6LJy2VFWGP+Gd2/o1Yn2HmfOad2RAdQakqJ7aea6TBkliew/pj rp8Vgkxb5dXlBWLB4Z7zKcLRxzbmKRkUnBbN2/AYpzhxfYvowuKmTwarfYIp3KGVJsLODzwds cEzLz9SRkQz7/NSY20Fvl+D8Y/q2BVH/Gmfs7unsdONmnPk4CV6GhylNBew6PmVzXBTsHUbYZ fjkM/CXzcS53wvN6EAKecI21zDXZhVcweeFExf03uC9bf1YZwewgS28YKTPBy2pqLeoPB3KQy iQx3u0kG8iJS9qJfDnRiQeV0nSwozxbB33wV4Rg1SL1rBddBXMaNRFYCSR21pnaiGzw2yHTKs xPiL1BFyuzbctK68EJ1Y2BU9u1tF3qk5Kb2zqvzNuxJVDMGhlK1ofE/1QbWIXmO4MERlcEio2 vH9NW/8Fb6b/daw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The LED for the mic mute button is controlled by GPIO2. The mute button LED is slightly more complex, it's controlled by two bits in coeff 0x0b. Signed-off-by: Fabian Vogt --- Changes since v1: Rebased on 03b0563c2f35. I've got this laptop for almost two years now and two days ago decided to dig into the issue with mute LEDs. What amazing tim= ing that someone else made the exact same fixup for a different model just hours before I submit... Renamed quirk to ..._LEDS to distinguish it from the similar quirk which handles only one of the mute LEDs. sound/pci/hda/patch_realtek.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index afc63d367fd5..a07df6f92960 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7318,6 +7318,7 @@ enum { ALC287_FIXUP_CS35L41_I2C_2_THINKPAD_ACPI, ALC287_FIXUP_TAS2781_I2C, ALC245_FIXUP_HP_MUTE_LED_COEFBIT, + ALC245_FIXUP_HP_X360_MUTE_LEDS, }; =20 /* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -9406,6 +9407,12 @@ static const struct hda_fixup alc269_fixups[] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc245_fixup_hp_mute_led_coefbit, }, + [ALC245_FIXUP_HP_X360_MUTE_LEDS] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc245_fixup_hp_mute_led_coefbit, + .chained =3D true, + .chain_id =3D ALC245_FIXUP_HP_GPIO_LED + }, }; =20 static const struct snd_pci_quirk alc269_fixup_tbl[] =3D { @@ -9648,6 +9655,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = =3D { SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstat= ion PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workst= ation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x887a, "HP Laptop 15s-eq2xxx", ALC236_FIXUP_HP_MUT= E_LED_COEFBIT2), + SND_PCI_QUIRK(0x103c, 0x888a, "HP ENVY x360 Convertible 15-eu0xxx", ALC24= 5_FIXUP_HP_X360_MUTE_LEDS), SND_PCI_QUIRK(0x103c, 0x888d, "HP ZBook Power 15.6 inch G8 Mobile Worksta= tion PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_F= IXUP_HP_SPEAKERS_MICMUTE_LED), SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_F= IXUP_HP_MUTE_LED), --=20 2.41.0