From nobody Fri Dec 19 17:21:49 2025 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9044C7EF1C for ; Mon, 29 Apr 2024 14:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.227.64.183 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714402259; cv=none; b=W2vQuuUgYmv1IwuDTXczFpWDBXCfnYl9U4V3MR6sWNKgLooCZCvFYFLu16R0/9GNAju+LqIVGYZWShQhAsQFEqOnAydh6eaNEHk50rndvZO1PuqlAS1+EHek8/tWo3QSQ0yC1+7jtw+axlspVvC71ppafmZGDWt/FXfgcVywN0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714402259; c=relaxed/simple; bh=ta4hw3RJe3RLJyhrYAahLj+IfUyV8pprABjjd5hupD0=; h=Date:Message-Id:In-Reply-To:References:Subject:MIME-Version: Content-Type:From:To:Cc; b=GABZahlPAEaa3vmEKbZtTUovMqD6IkAAg/Pcgc3JzUgT6CkvF587c2sbp3Ktw+rsX00MA4Wb2blT7H9+ag1p1/96cb+o8fcS0Ykw5iQRzFa6qHxvmh+Vx/jI0f1GWeeEHHc3XC/cEtVZV/v2Z8g6qyeHhc49xzVZJtV3RdTroNA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=rere.qmqm.pl; spf=pass smtp.mailfrom=rere.qmqm.pl; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b=R/pc/Wc+; arc=none smtp.client-ip=91.227.64.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=rere.qmqm.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rere.qmqm.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="R/pc/Wc+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1714401927; bh=ta4hw3RJe3RLJyhrYAahLj+IfUyV8pprABjjd5hupD0=; h=Date:In-Reply-To:References:Subject:From:To:Cc:From; b=R/pc/Wc+3xgD24HE1IGkzNHeLQarLD6Dsr3hEkxHFYqDW0dM7fd29VYL3Xk0IfEVq u8XdiNBTA9LNRyymrwKSZyRqlGMGKcbARbrTK3kv7tda+NKtoixGcVBQ8IFIbq5+Ev nmuyOBTf0RtDfIvmbj3tIC7YyCRPrUOmeUu9HIyGhP0U0W4sFyKGyNiz13VGTg/54H O23z1nsQ6zTkGuTTA4wJmJbwTVjMk0tkFu1fjNOf/bxuHSdR8v0hhWy1AgAbhQc/Fo DH32ieTI2bMg20Fsv7oUyMDx323yUmA/ehB11iBhIwjjtOOhr92k7NKcYqFhioVXYB wv2jIrtEb36Mg== Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4VSmMq5ftlz8k; Mon, 29 Apr 2024 16:45:27 +0200 (CEST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 1.0.5 at mail Date: Mon, 29 Apr 2024 16:45:27 +0200 Message-Id: <2680c3b712b36a3ddc279b7efcd87dbf2f24ccaf.1714399603.git.mirq-linux@rere.qmqm.pl> In-Reply-To: References: Subject: [PATCH v2 01/12] regulator/core: _regulator_get: simplify error returns Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org Remove unnecessary stores to `regulator`. Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/regulator/core.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index dabac9772741..62dd3ac19e6d 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2222,15 +2222,13 @@ struct regulator *_regulator_get(struct device *dev= , const char *id, } =20 if (rdev->exclusive) { - regulator =3D ERR_PTR(-EPERM); put_device(&rdev->dev); - return regulator; + return ERR_PTR(-EPERM); } =20 if (get_type =3D=3D EXCLUSIVE_GET && rdev->open_count) { - regulator =3D ERR_PTR(-EBUSY); put_device(&rdev->dev); - return regulator; + return ERR_PTR(-EBUSY); } =20 mutex_lock(®ulator_list_mutex); @@ -2238,32 +2236,28 @@ struct regulator *_regulator_get(struct device *dev= , const char *id, mutex_unlock(®ulator_list_mutex); =20 if (ret !=3D 0) { - regulator =3D ERR_PTR(-EPROBE_DEFER); put_device(&rdev->dev); - return regulator; + return ERR_PTR(-EPROBE_DEFER); } =20 ret =3D regulator_resolve_supply(rdev); if (ret < 0) { - regulator =3D ERR_PTR(ret); put_device(&rdev->dev); - return regulator; + return ERR_PTR(ret); } =20 if (!try_module_get(rdev->owner)) { - regulator =3D ERR_PTR(-EPROBE_DEFER); put_device(&rdev->dev); - return regulator; + return ERR_PTR(-EPROBE_DEFER); } =20 regulator_lock(rdev); regulator =3D create_regulator(rdev, dev, id); regulator_unlock(rdev); if (regulator =3D=3D NULL) { - regulator =3D ERR_PTR(-ENOMEM); module_put(rdev->owner); put_device(&rdev->dev); - return regulator; + return ERR_PTR(-ENOMEM); } =20 rdev->open_count++; --=20 2.39.2