From nobody Fri Nov 29 12:38:11 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF56194C61 for ; Thu, 19 Sep 2024 10:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726742462; cv=none; b=jk+JeGXdEf6QS8skh6SpAZm1RrXpLYijiMP33/VUFdaTCwrf2bOeOW2C9mcDLhTyBYSuKXGWpgzeY5pEaie/yO7sLNjlSGYcOKTJmvC8OPHGRLpEPAvIGasevVPll7onGrHPjuWfFbs11ojrS82ubskyFrLj0dUA7k4ws6y+LwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726742462; c=relaxed/simple; bh=iSdB96//uOYNetxOBLT39OE78EZTh4JQ1vmKYkFcepo=; h=From:To:cc:Subject:MIME-Version:Content-Type:Date:Message-ID; b=CmUXwxjczFy+sYpuW2mi9jH/oIQtZ7apXaeamRFflU7a3zWCIBCeRxd2dmW3uXIUP1v/K9aeg9mwOtFYQNh4KVRZR6GdMLTAja10VSk/tkg4o5srwzHoiNBGIbpR5Qpio1NkmZzj3B3osKu90k/X/XhXYJtuk1kmLXVb0EvGEqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LcPrI6NB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LcPrI6NB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726742459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=VcvHdf5Pmtgf7/MQNxfdvUPCsOw52+fwh9xXqYx7hPg=; b=LcPrI6NBkh53jbD4oGOHLinRmeJZF2+6CQatQb2HIy7FNwOSJVJEBYFF6XLQaMcD8NNSkr Y3kfVdEubV59JTFywqHfwf8qvuKendV78Q+JSN7dsjuGhYqjJD/bizvl6fYWkYnCQH5Tju V376RdITzJJUGLIf2IN0izBwAFPAWTs= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-Wj0fOkpxPSa41HX4PpiQXg-1; Thu, 19 Sep 2024 06:40:56 -0400 X-MC-Unique: Wj0fOkpxPSa41HX4PpiQXg-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CC0291935852; Thu, 19 Sep 2024 10:40:54 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.14]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 79398196CAD2; Thu, 19 Sep 2024 10:40:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: Marc Dionne cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] afs: Fix setting of the server responding flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-ID: <2614632.1726742450.1@warthog.procyon.org.uk> Date: Thu, 19 Sep 2024 11:40:50 +0100 Message-ID: <2614633.1726742450@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In afs_wait_for_operation(), we set transcribe the call responded flag to the server record that we used after doing the fileserver iteration loop - but it's possible to exit the loop having had a response from the server that we've discarded (e.g. it returned an abort or we started receiving data, but the call didn't complete). This means that op->server might be NULL, but we don't check that before attempting to set the server flag. Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org Fixes: 98f9fda2057b ("afs: Fold the afs_addr_cursor struct in") --- fs/afs/fs_operation.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/afs/fs_operation.c b/fs/afs/fs_operation.c index 3546b087e791..f9602c9a3257 100644 --- a/fs/afs/fs_operation.c +++ b/fs/afs/fs_operation.c @@ -197,13 +197,12 @@ void afs_wait_for_operation(struct afs_operation *op) op->call_abort_code =3D op->call->abort_code; op->call_error =3D op->call->error; op->call_responded =3D op->call->responded; + if (op->call_responded) + set_bit(AFS_SERVER_FL_RESPONDING, &op->server->flags); afs_put_call(op->call); } } =20 - if (op->call_responded) - set_bit(AFS_SERVER_FL_RESPONDING, &op->server->flags); - if (!afs_op_error(op)) { _debug("success"); op->ops->success(op);