From nobody Tue Dec 2 01:42:45 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7960C299AAC for ; Sun, 23 Nov 2025 22:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763938323; cv=none; b=T8tAqJGdRkUxbtuMc6ALP9ftD/SwmpgNYz4543Zvja3OoUAJUhrEyPNN+B+a/UbXgAU8BK1UBoAvudijxRMH1ePy64c0qfRwIjvlREXCNkWLBFbDGOh7V7XpH67WkRgX2LjdN0S7efr8gFZqqDrmVxF4RebP8hzJJ2XtbrK4HaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763938323; c=relaxed/simple; bh=mm+6YwU1gOqG0s75Ml2JJlbE3SsFVnXZaGl2Nl7+2l0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DOok8cw/fvq8+BbnBgMS0hnzamOWMh2fA0PNPG77zoybv972bUThSsC8gmgP90mIbfFEQtuMBWCtKeZfsAmrHPr/Qj+E+wLOddd3gGZ3GMe5cW7yQ43E+3oqwIkuKaLClsaJd/4OWI1aF3FsyQErYGTuvRRvhMpp5KiFfnxygf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IzQjW9LC; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzQjW9LC" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b2dc17965so3606999f8f.3 for ; Sun, 23 Nov 2025 14:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763938318; x=1764543118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cr1T3mHouFLI2INVVeu1NU8Ohycgb7ruAKm6sUveqNE=; b=IzQjW9LCSDhXQJlfox4jXG+GkY63YhHN88jNMB+XzG+H1qhx1pSDgvIoTqUNrGk6QM 8nRVgqSC9uSjklve7fATB/SRCTvXE0VD4XnfHEXLjzKh9H0ZVDv3xZ+Fa6F5sIo3P7Sz SdXUEmnHXi/QPiFgx0GBEvP2+wr6f8feICOmVCu91WYN/Q5XCXY8zU7BoOjQpyw+bx75 21wjbMcEO90dLjAqAsOVW/N0G25gmPPFzZ+e6xSa/Jf+zhKETP2AQsE2s0+nlGIWCA3n YSlOk8K8Y8ga28F/HnQExNZgqD+B9JI09Yg1bSNfcjaW6wk77bxzjUrsAhSEp1/DcYT+ COug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763938318; x=1764543118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Cr1T3mHouFLI2INVVeu1NU8Ohycgb7ruAKm6sUveqNE=; b=abE9PebTHCrU38RF4Ud8RyD7DdDpKzOZqs814Pv5vKClOH97SHDG6xfz3J8JLaDRAy /2hkWb4utmUGPrx/U7OkV8x4wDaIwXZ9Vh6yxzczobqGWlvKp9tzqWB/4XV7jr+uzMQw yz0IEjI1eJ7y9VR7ZxClUeBMKQgt7y0HM9e3sZlpQznXH9/b0hTbeZbaZVn/TuZ1NrmV RaoRp6xo62OAUTnz0y/04fGgoeRcmVx/qsFm4yNxUV1Hr6jHPzwsdoPECrMdhoD1j9po oiihIXlRuHWhdgmFSjQu5nLdwxf8HuP0R7qb8bhF1Oh/eI2zsBZ36Lm0zmzJL+ORSPNR 5MeA== X-Forwarded-Encrypted: i=1; AJvYcCXtLpCPs0z6lUnG6M3MQxfL2Wh9xFn99Qx9fO17sFA7BdtWHyCzZwgwg5+tq2ViD2JLaNlCaIXpt2Nrv6w=@vger.kernel.org X-Gm-Message-State: AOJu0YwD//xmQnxV0lwLQAOJ3FqEfHBVx/Nj84M/Tl+oFeQFdaFacbCt ixmC/6eC2wY9PGS+qe40D+3hN5k5RTlQeIRWNsZW9Czu4UuFx28BvH8P X-Gm-Gg: ASbGnct57mTbIHAzmg98KBI74con6QH2EdMxjM1RGS/antObqQxSdHtR0U6ZAMdEuJW jWm/eTf8JlG2L1e377dXRRm8/aZmUMBNGUNOMHbVYC8pPv82XC3SAphyg+kZhMeSHE/Jxk006is IQkNj/OFBql+e8fXTcemRq6APvlVRA7w7d/40CHf78RhuLKWxpsy9a1uCAwpsuT3dAcUKVu9zFR Y8ClkpLyI5GHU0GxG6EMP7YzFUmT7+/RwwQyIHUYqUUPj2EwSamOpfLNqWpdNsfrDvpQHMcSGuK IElWvCHzvhuqVmnGWCP0ZO1MxiGABxqvj+0AxjC7LU8S5hD8jq7My7tsjGLhMLCX2OTbnmFAzwJ yObKoHtrlCAqt/rfo3yJSBABGroJLrZpJiPnXfmpTp6I5RySDGxxHPrZaBG5OK8oY8ELabAcGv8 sK3dfyRDoagf2ong== X-Google-Smtp-Source: AGHT+IFWQMi7JjnPU4iNqrFrw/2a7As2OTjK90JEPF3SEC3P6oOl1QIY7pfuaXnoytjEpQNeSrnvkg== X-Received: by 2002:a05:6000:200c:b0:42b:4139:579e with SMTP id ffacd0b85a97d-42cc1d1983fmr10129976f8f.43.1763938317609; Sun, 23 Nov 2025 14:51:57 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb9190sm24849064f8f.33.2025.11.23.14.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 14:51:56 -0800 (PST) From: Pavel Begunkov To: linux-block@vger.kernel.org, io-uring@vger.kernel.org Cc: Vishal Verma , tushar.gohad@intel.com, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Pavel Begunkov , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: [RFC v2 08/11] io_uring/rsrc: add imu flags Date: Sun, 23 Nov 2025 22:51:28 +0000 Message-ID: <25a416c7f2673d39ae31bfe8bddcfc7eef710e71.1763725388.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace is_kbuf with a flags field in io_mapped_ubuf. There will be new flags shortly, and bit fields are often not as convenient to work with. Signed-off-by: Pavel Begunkov --- io_uring/rsrc.c | 12 ++++++------ io_uring/rsrc.h | 6 +++++- io_uring/rw.c | 3 ++- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c index 3765a50329a8..21548942e80d 100644 --- a/io_uring/rsrc.c +++ b/io_uring/rsrc.c @@ -828,7 +828,7 @@ static struct io_rsrc_node *io_sqe_buffer_register(stru= ct io_ring_ctx *ctx, imu->folio_shift =3D PAGE_SHIFT; imu->release =3D io_release_ubuf; imu->priv =3D imu; - imu->is_kbuf =3D false; + imu->flags =3D 0; imu->dir =3D IO_IMU_DEST | IO_IMU_SOURCE; if (coalesced) imu->folio_shift =3D data.folio_shift; @@ -985,7 +985,7 @@ int io_buffer_register_bvec(struct io_uring_cmd *cmd, s= truct request *rq, refcount_set(&imu->refs, 1); imu->release =3D release; imu->priv =3D rq; - imu->is_kbuf =3D true; + imu->flags =3D IO_IMU_F_KBUF; imu->dir =3D 1 << rq_data_dir(rq); =20 rq_for_each_bvec(bv, rq, rq_iter) @@ -1020,7 +1020,7 @@ int io_buffer_unregister_bvec(struct io_uring_cmd *cm= d, unsigned int index, ret =3D -EINVAL; goto unlock; } - if (!node->buf->is_kbuf) { + if (!(node->buf->flags & IO_IMU_F_KBUF)) { ret =3D -EBUSY; goto unlock; } @@ -1086,7 +1086,7 @@ static int io_import_fixed(int ddir, struct iov_iter = *iter, =20 offset =3D buf_addr - imu->ubuf; =20 - if (imu->is_kbuf) + if (imu->flags & IO_IMU_F_KBUF) return io_import_kbuf(ddir, iter, imu, len, offset); =20 /* @@ -1511,7 +1511,7 @@ int io_import_reg_vec(int ddir, struct iov_iter *iter, iovec_off =3D vec->nr - nr_iovs; iov =3D vec->iovec + iovec_off; =20 - if (imu->is_kbuf) { + if (imu->flags & IO_IMU_F_KBUF) { int ret =3D io_kern_bvec_size(iov, nr_iovs, imu, &nr_segs); =20 if (unlikely(ret)) @@ -1549,7 +1549,7 @@ int io_import_reg_vec(int ddir, struct iov_iter *iter, req->flags |=3D REQ_F_NEED_CLEANUP; } =20 - if (imu->is_kbuf) + if (imu->flags & IO_IMU_F_KBUF) return io_vec_fill_kern_bvec(ddir, iter, imu, iov, nr_iovs, vec); =20 return io_vec_fill_bvec(ddir, iter, imu, iov, nr_iovs, vec); diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h index d603f6a47f5e..7c1128a856ec 100644 --- a/io_uring/rsrc.h +++ b/io_uring/rsrc.h @@ -28,6 +28,10 @@ enum { IO_IMU_SOURCE =3D 1 << ITER_SOURCE, }; =20 +enum { + IO_IMU_F_KBUF =3D 1, +}; + struct io_mapped_ubuf { u64 ubuf; unsigned int len; @@ -37,7 +41,7 @@ struct io_mapped_ubuf { unsigned long acct_pages; void (*release)(void *); void *priv; - bool is_kbuf; + u8 flags; u8 dir; struct bio_vec bvec[] __counted_by(nr_bvecs); }; diff --git a/io_uring/rw.c b/io_uring/rw.c index a7b568c3dfe8..a3eb4e7bf992 100644 --- a/io_uring/rw.c +++ b/io_uring/rw.c @@ -706,7 +706,8 @@ static ssize_t loop_rw_iter(int ddir, struct io_rw *rw,= struct iov_iter *iter) if ((kiocb->ki_flags & IOCB_NOWAIT) && !(kiocb->ki_filp->f_flags & O_NONBLOCK)) return -EAGAIN; - if ((req->flags & REQ_F_BUF_NODE) && req->buf_node->buf->is_kbuf) + if ((req->flags & REQ_F_BUF_NODE) && + (req->buf_node->buf->flags & IO_IMU_F_KBUF)) return -EFAULT; =20 ppos =3D io_kiocb_ppos(kiocb); --=20 2.52.0