From nobody Fri Apr 10 00:56:56 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1DC83D75C5; Wed, 4 Mar 2026 18:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772649996; cv=none; b=W/zWA1eTlc2fB3Thr+Hw6elQ7inSDGH8NKn3bCYCr+aOyyQ1ZnwJFZJHQrRnsKY/6wKz7QD8c7y79uqg8224W/q8/7SscVHBqlLxoKO7UUyyGScWQcDD6XoxrMMEeHiv080QQsQvHiWZP+4Z5F8jO8TK9cFOqWmnUdyYMF033iY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772649996; c=relaxed/simple; bh=Zzg0bOZHWxlJWNWw5GOGW2tm/fvqitcMJCaOKp1J/44=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lfi2R4YsEpKC7oLTPYaZZzX2WMW8JQRsW7afpiKMKTQaglvPizv0YNtmkC6Yjz04nuehREdU2hFbDzT0xzJlA6FzAEtjeziBcaiBzSmDTnXbHHPf9JKzJWCWmq6anoAm+KQp5LJG36C/4ITnhbF5BEwkCe/VszpHpKJAeaRDSNk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vL6sVOwx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vL6sVOwx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AEF0C2BC9E; Wed, 4 Mar 2026 18:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772649996; bh=Zzg0bOZHWxlJWNWw5GOGW2tm/fvqitcMJCaOKp1J/44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vL6sVOwxXg3I4ohjCPGYP6qpI6DUXRkLIjrpV8rorJdzt0Ed2ea4g/MPZhe7cqQGD PNa3I+DGQ9F6oC4Y7bA3u9IxAC7x31ya0fzGexmxLYpNTm1HzswhQhtrL4DDu+eRsE HjuEkJRcSk7rJJlc/pBgHYPSKMA+ds3I+D21E78BF7SGIF7KSa8hHdvLjbkwj/NO+f 03iG4oB9Z1z2ACrsdwWjSfCUehlQr54dvQ+pOiwcDjSe1ob/3few5v6CVKdpNVfRC6 xwpQQCej6Cro7I4cUPDCNDfOv8bZGAu+Sj7i0kYZBEyUU6pb/WRN2+wD28rn6+PXQp YHInbzUynKSAQ== From: "Rafael J. Wysocki" To: chrome-platform@lists.linux.dev Cc: LKML , Linux ACPI , Benson Leung , Tzung-Bi Shih , Enric Balletbo i Serra , Ravi Chandra Sadineni Subject: [PATCH v1 3/6] platform/chrome: chromeos_tbmc: Register ACPI notify handler Date: Wed, 04 Mar 2026 19:43:44 +0100 Message-ID: <2277362.Icojqenx9y@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <2274474.Mh6RI2rZIc@rafael.j.wysocki> References: <2274474.Mh6RI2rZIc@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Rafael J. Wysocki" To facilitate subsequent conversion of the driver to a platform one, make it install an ACPI notify handler directly instead of using a .notify() callback in struct acpi_driver. No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/platform/chrome/chromeos_tbmc.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/chromeos_tbmc.c b/drivers/platform/chr= ome/chromeos_tbmc.c index e248567c0a18..9c988e697d09 100644 --- a/drivers/platform/chrome/chromeos_tbmc.c +++ b/drivers/platform/chrome/chromeos_tbmc.c @@ -45,8 +45,10 @@ static __maybe_unused int chromeos_tbmc_resume(struct de= vice *dev) return chromeos_tbmc_query_switch(adev, adev->driver_data); } =20 -static void chromeos_tbmc_notify(struct acpi_device *adev, u32 event) +static void chromeos_tbmc_notify(acpi_handle handle, u32 event, void *data) { + struct acpi_device *adev =3D data; + acpi_pm_wakeup_event(&adev->dev); switch (event) { case 0x80: @@ -92,11 +94,22 @@ static int chromeos_tbmc_add(struct acpi_device *adev) return ret; } device_init_wakeup(dev, true); + + ret =3D acpi_dev_install_notify_handler(adev, ACPI_DEVICE_NOTIFY, + chromeos_tbmc_notify, adev); + if (ret) { + dev_err(dev, "cannot install ACPI notify handler\n"); + device_init_wakeup(dev, false); + return ret; + } + return 0; } =20 static void chromeos_tbmc_remove(struct acpi_device *adev) { + acpi_dev_remove_notify_handler(adev, ACPI_DEVICE_NOTIFY, + chromeos_tbmc_notify); device_init_wakeup(&adev->dev, false); } =20 @@ -116,7 +129,6 @@ static struct acpi_driver chromeos_tbmc_driver =3D { .ops =3D { .add =3D chromeos_tbmc_add, .remove =3D chromeos_tbmc_remove, - .notify =3D chromeos_tbmc_notify, }, .drv.pm =3D &chromeos_tbmc_pm_ops, }; --=20 2.51.0