From nobody Thu Oct 2 06:16:46 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930CA26D4C0; Fri, 19 Sep 2025 16:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758300046; cv=none; b=c7dir0k946aQpaHu3xtl+/2u/8jClDTZYEGdKRf0H6BJ2dXq+cpW3dhyQbWte68rP6RFhVwf9urzIxbrJ9iKu94lZX1vyxt0qJSyZq2nQTwfBQgD3jge+DjTpOHyJXn59SbFTG7oL5CSTQsB46+kVArjbPCG37sM0hJsTQ4XP2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758300046; c=relaxed/simple; bh=Lk0O1L7hjdO97zvfG/KEfg0A1cK285Y7YOABL3BKAts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dSazh9+73VciOWNvWhl3DRIUAj0lMV6jYa4imQBCkmLH3QIrjIdr2DJzaF3orBq7XAXXs9uimVawhliI8r4sOStriv8u+zXEoUfpo06AYXtU8yiqHp4KoPO1M5MBpzCFdZf4sLXLAkGzy8/jCeyvzM447fnGfHA1qAcgA08zbSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FsDBoMQ3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FsDBoMQ3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88FF7C4CEF9; Fri, 19 Sep 2025 16:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758300046; bh=Lk0O1L7hjdO97zvfG/KEfg0A1cK285Y7YOABL3BKAts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FsDBoMQ3eM/YDaPQ27O5WLI7O0LIXCmMiXB8Nki5+P6wVSFI/10BrVTIlsuqamfuJ 5yvvEf/UhkZYWumrwChVo1rAP8Zgmmf/fGugR2bZrshIJ+lOsOKD/L8xedW1IQRX92 UD4UgqpGYjDOs8yz/as20CodJmDkKI7QMADYPVIWZDKoOl8KSyEbxvm30zDHig4dFP fBX+dbfTUxcMNYpP4ROgtPNbNIZ/mZ7rJvGWfJ4eGyP4wl7NOIJBXZByyXMQaJBAom 8ZkuXcp8+rIz/sgnK3vapLn+Cf+c9/nrXbnxBxwOJKnaZsEEpkGP0SrrCGBnRXlPh8 ZaQVhVxfId1lw== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Linux PCI , Alex Williamson , Bjorn Helgaas , Takashi Iwai , Zhang Qilong , Ulf Hansson Subject: [PATCH v1 2/3] PCI/sysfs: Use PM runtime class macro for auto cleanup in reset_method_store() Date: Fri, 19 Sep 2025 18:38:42 +0200 Message-ID: <2245131.irdbgypaU6@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <5049058.31r3eYUQgx@rafael.j.wysocki> References: <5049058.31r3eYUQgx@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Takashi Iwai The newly introduced class macro can simplify the code. Also, add the proper error handling for the PM runtime get. Signed-off-by: Takashi Iwai [ rjw: Adjust subject and error handling ] Signed-off-by: Rafael J. Wysocki --- drivers/pci/pci-sysfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -1475,8 +1475,9 @@ static ssize_t reset_method_store(struct return count; } =20 - pm_runtime_get_sync(dev); - struct device *pmdev __free(pm_runtime_put) =3D dev; + CLASS(pm_runtime_resume_and_get, pmdev)(dev); + if (IS_ERR(pmdev)) + return -ENXIO; =20 if (sysfs_streq(buf, "default")) { pci_init_reset_methods(pdev);