From nobody Sun May 5 15:46:34 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5879C47088 for ; Fri, 2 Dec 2022 21:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234036AbiLBVNr (ORCPT ); Fri, 2 Dec 2022 16:13:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234097AbiLBVNn (ORCPT ); Fri, 2 Dec 2022 16:13:43 -0500 Received: from smtp.smtpout.orange.fr (smtp-12.smtpout.orange.fr [80.12.242.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD34DB1E9 for ; Fri, 2 Dec 2022 13:13:41 -0800 (PST) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id 1DLlpPcSnM75k1DLlp2pVY; Fri, 02 Dec 2022 22:13:39 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 02 Dec 2022 22:13:39 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: Jason@zx2c4.com, kuba@kernel.org, tytso@mit.edu, elver@google.com, yury.norov@gmail.com, linux@dominikbrodowski.net, gregkh@linuxfoundation.org, pmladek@suse.com, keescook@chromium.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] random: Include in the right header Date: Fri, 2 Dec 2022 22:13:36 +0100 Message-Id: <212adb212cb0234a7d395daf31b2578b9409d492.1670015476.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" uses DO_ONCE(). So it should include directly. On the contrary, doesn't use functionalities from , so it should be removed. All this is true since commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") Move the #include in the right file. Signed-off-by: Christophe JAILLET Reviewed-by: Kees Cook --- Let see if build-bots agree with me! --- include/linux/prandom.h | 1 + include/linux/random.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/prandom.h b/include/linux/prandom.h index 1f4a0de7b019..c94c02ba065c 100644 --- a/include/linux/prandom.h +++ b/include/linux/prandom.h @@ -9,6 +9,7 @@ #define _LINUX_PRANDOM_H =20 #include +#include #include #include =20 diff --git a/include/linux/random.h b/include/linux/random.h index b1a34181eed6..4a2a1de423cd 100644 --- a/include/linux/random.h +++ b/include/linux/random.h @@ -6,7 +6,6 @@ #include #include #include -#include =20 #include =20 --=20 2.34.1