From nobody Mon Apr 6 18:22:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E6C33C51D for ; Wed, 18 Mar 2026 20:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773866407; cv=none; b=fbJdINdZPJO0w/VBrLJKKy38k+Xx8F9iaIpMgZgwrRidJqAGDThZYzL/mMbmCqAEEESGCxARbqnRW1mE+21Q5Pw/cjxzYENSTrb32lNP+N0x/kwAUm04V25Tf5OYKgI+5vvBn7D3tlnTVuHC5RGa08jVMKocR2iScQGFLQG0/ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773866407; c=relaxed/simple; bh=7Zih2Kv0Dm+TrjDetzDdmQ+LGnrh29EyXLjilJ0KrRI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rAph4D8A06SFZVlDEXOB1pwjtdMuTZF7pJpp5Hf4ci9o94JKziPwGld0D4xBphIno7rphwB0g5T/1FucaRfsTSpT6jXOdgBitJ+SF7oKf4o3nQTgPBdx0yXoSmpEvQshv5gQKCjROg4e5aRVXz/P35UBqHBxyB5lhA9Lz0om9Ms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zu1L7gfj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zu1L7gfj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAE49C19424; Wed, 18 Mar 2026 20:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773866407; bh=7Zih2Kv0Dm+TrjDetzDdmQ+LGnrh29EyXLjilJ0KrRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zu1L7gfjbQFmjKt1J6VBjQ1d7W1ZUN6DCgHduL35Q1r56dv5jtqd2SVAdmtF8MenG UHmbv21UlczDU7YSEwXY4glnWufkHg3qNjRue1ZXCNLeMm7XBHznw+zHQQ+7e2OBUM SEhwFoK1SsEFnsbV9g+f7RD9tfkblSAKHKEEYETGWUfAm85p+PSEpWo6jkad3xNWnD CI/LqRjVQuWEND/quhDHS5654NtqaL6cO+mLZkLZy52stB7CD9IWO+/y9XsJNKKFA0 9yHinYu2OigIAOOyta9aZaOCrL19O2Bo57nsBfsD1SkX2mZS8F5njyknLQ/9vmy9wP FIgyWXKZuhfcA== From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] mm/huge_memory: have zap_huge_pmd return a boolean, add kdoc Date: Wed, 18 Mar 2026 20:39:25 +0000 Message-ID: <20e00d784adf1540c32b46024a709dfe1be93019.1773865827.git.ljs@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There's no need to use the ancient approach of returning an integer here, just return a boolean. Also update flush_needed to be a boolean, similarly. Also add a kdoc comment describing the function. Signed-off-by: Lorenzo Stoakes (Oracle) Acked-by: Qi Zheng Reviewed-by: Baolin Wang --- include/linux/huge_mm.h | 4 ++-- mm/huge_memory.c | 23 ++++++++++++++++------- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 61fda1672b29..2949e5acff35 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -27,8 +27,8 @@ static inline void huge_pud_set_accessed(struct vm_fault = *vmf, pud_t orig_pud) vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf); bool madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *= vma, pmd_t *pmd, unsigned long addr, unsigned long next); -int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t= *pmd, - unsigned long addr); +bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_= t *pmd, + unsigned long addr); int zap_huge_pud(struct mmu_gather *tlb, struct vm_area_struct *vma, pud_t= *pud, unsigned long addr); bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 4ebe1f19341e..bba1ba1f6b67 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2418,11 +2418,20 @@ static inline void zap_deposited_table(struct mm_st= ruct *mm, pmd_t *pmd) mm_dec_nr_ptes(mm); } =20 -int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, +/** + * zap_huge_pmd - Zap a huge THP which is of PMD size. + * @tlb: The MMU gather TLB state associated with the operation. + * @vma: The VMA containing the range to zap. + * @pmd: A pointer to the leaf PMD entry. + * @addr: The virtual address for the range to zap. + * + * Returns: %true on success, %false otherwise. + */ +bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr) { struct folio *folio =3D NULL; - int flush_needed =3D 1; + bool flush_needed =3D true; spinlock_t *ptl; pmd_t orig_pmd; =20 @@ -2430,7 +2439,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_ar= ea_struct *vma, =20 ptl =3D __pmd_trans_huge_lock(pmd, vma); if (!ptl) - return 0; + return false; /* * For architectures like ppc64 we look at deposited pgtable * when calling pmdp_huge_get_and_clear. So do the @@ -2445,13 +2454,13 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_= area_struct *vma, if (arch_needs_pgtable_deposit()) zap_deposited_table(tlb->mm, pmd); spin_unlock(ptl); - return 1; + return true; } if (is_huge_zero_pmd(orig_pmd)) { if (!vma_is_dax(vma) || arch_needs_pgtable_deposit()) zap_deposited_table(tlb->mm, pmd); spin_unlock(ptl); - return 1; + return true; } =20 if (pmd_present(orig_pmd)) { @@ -2465,7 +2474,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_ar= ea_struct *vma, const softleaf_t entry =3D softleaf_from_pmd(orig_pmd); =20 folio =3D softleaf_to_folio(entry); - flush_needed =3D 0; + flush_needed =3D false; =20 if (!thp_migration_supported()) WARN_ONCE(1, "Non present huge pmd without pmd migration enabled!"); @@ -2499,7 +2508,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_ar= ea_struct *vma, if (flush_needed) tlb_remove_page_size(tlb, &folio->page, HPAGE_PMD_SIZE); =20 - return 1; + return true; } =20 #ifndef pmd_move_must_withdraw --=20 2.53.0