From nobody Fri Dec 19 04:54:16 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC41418F2F8 for ; Wed, 4 Dec 2024 07:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733298153; cv=none; b=Cg7Kxm61g+YzwsPV9kY+n+ckN2UovoYtT5CrBfaKoAPstMHjxqsQLtxBmWXIi7JBSml0XVVZElNE+TKo9A94P7bS2vvpddnwFrwuyYScye70KFtBLvf1aX3joKaapElnaTsUT1ik7SJoC4+nY7fhVWMBZ9wOngb0hMZlKWDMha4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733298153; c=relaxed/simple; bh=pgakqgvEh0nG6+NLZ9+IaRjALlaeiQhSzDCOXxqHdyA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fS6Ihd3ptIZKlVQdIfeScrAmCMiW+Sjz1fUKOy4MPR88ETAz2X+LB6wJRDnAW4cMFJJC0rUjFgnd9U4wXz2UFe5VbDaqhRLgzoRREHz0q7pXAKoZCqH3+BGEofqmkUSMKM92F82xTbxXxLe2RsoimjGx/y4yt6xrnPcA+Llbhz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NI7gUJKP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NI7gUJKP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39013C4CEEF; Wed, 4 Dec 2024 07:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733298153; bh=pgakqgvEh0nG6+NLZ9+IaRjALlaeiQhSzDCOXxqHdyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NI7gUJKPsRPpMsxDugV6NmZXSCIVr4orRroz+wuhp8FifidE2Wua3d8m5fn7dgcQY pYwpk2tKKp7DoXBIdY1xr0lMINbUnim7ftPoE087PgIuizo25pJvjBzOQdFd9v1ezG Q36YPuJPWRp+QOD4EZDY3fFqrekZM3QwooHnvBEbAsvTlkxOLs6grjtsmi2wFxUzXx IKnAoChm25AVV5Dmb/UVAb4tRLXehvvu0rkJEScBtZV8ISvOUAFWhlmjhBdQ5L9Jcr ElX2iZq/Zsw9LGMJn92MYAIZ9TqAG1u1VAj+8uIphmdudSldXyf1oEGxYyaRrq07g5 XXvmSvLIh2VJw== Received: from mchehab by mail.kernel.org with local (Exim 4.98) (envelope-from ) id 1tIk1n-00000004KjU-19ki; Wed, 04 Dec 2024 08:42:31 +0100 From: Mauro Carvalho Chehab To: Igor Mammedov Cc: Jonathan Cameron , Shiju Jose , Mauro Carvalho Chehab , "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , linux-kernel@vger.kernel.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v5 13/16] acpi/ghes: better name the offset of the hardware error firmware Date: Wed, 4 Dec 2024 08:41:21 +0100 Message-ID: <20b003136d8c008fd54e8d40c806f13867336e13.1733297707.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab Content-Type: text/plain; charset="utf-8" The hardware error firmware is where HEST error structures are stored. Those can be GHESv2, but they can also be other types. Better name the location of the hardware error. No functional changes. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov --- hw/acpi/generic_event_device.c | 4 ++-- hw/acpi/ghes.c | 4 ++-- include/hw/acpi/ghes.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c index 663d9cb09380..17baf36132a8 100644 --- a/hw/acpi/generic_event_device.c +++ b/hw/acpi/generic_event_device.c @@ -364,7 +364,7 @@ static const VMStateDescription vmstate_ghes =3D { .version_id =3D 1, .minimum_version_id =3D 1, .fields =3D (const VMStateField[]) { - VMSTATE_UINT64(ghes_addr_le, AcpiGhesState), + VMSTATE_UINT64(hw_error_le, AcpiGhesState), VMSTATE_END_OF_LIST() }, }; @@ -372,7 +372,7 @@ static const VMStateDescription vmstate_ghes =3D { static bool ghes_needed(void *opaque) { AcpiGedState *s =3D opaque; - return s->ghes_state.ghes_addr_le; + return s->ghes_state.hw_error_le; } =20 static const VMStateDescription vmstate_ghes_state =3D { diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 52c2b69d3664..90d76b9c2d8c 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -359,7 +359,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgStat= e *s, =20 /* Create a read-write fw_cfg file for Address */ fw_cfg_add_file_callback(s, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, NULL, NULL, - NULL, &(ags->ghes_addr_le), sizeof(ags->ghes_addr_le), false); + NULL, &(ags->hw_error_le), sizeof(ags->hw_error_le), false); =20 ags->present =3D true; } @@ -385,7 +385,7 @@ void ghes_record_cper_errors(const void *cper, size_t l= en, } ags =3D &acpi_ged_state->ghes_state; =20 - start_addr =3D le64_to_cpu(ags->ghes_addr_le); + start_addr =3D le64_to_cpu(ags->hw_error_le); =20 start_addr +=3D source_id * sizeof(uint64_t); =20 diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h index 21666a4bcc8b..39619a2457cb 100644 --- a/include/hw/acpi/ghes.h +++ b/include/hw/acpi/ghes.h @@ -65,7 +65,7 @@ enum { }; =20 typedef struct AcpiGhesState { - uint64_t ghes_addr_le; + uint64_t hw_error_le; bool present; /* True if GHES is present at all on this board */ } AcpiGhesState; =20 --=20 2.47.1