From nobody Sun Jun 21 04:20:35 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2E663B38AF; Tue, 7 Apr 2026 14:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571042; cv=none; b=jH0XrDPMCcW2YC9NF/xt0JHXd3w0LNHgcnVn77mIfFkmaGjR72xLRrcR66okJTlcC8WKrPdidtZf0OR5IjpxuWQib+RyCiBTYN4VqZ4ijDA21PMKwJjoW9UJnJHjaLgNjmuA3RdlximPKQJqtVx1XGarAU3gMZZGJr3BftdYVRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571042; c=relaxed/simple; bh=dQmJSBhhE846Zl7fb0Ou9WeICRvwD7Od8vw4OWLhUjE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YMeFHeQiAavfMXwOqlu+jj7NKVjOkdYJD6mHgNmxzC9lrYp3hJwd+/0GDJLbjNm9DK/VgM96vUFOYf1epsoq1g/iWHbObtmNpdpdJtQtZGFjL/oFJd6otPIz5YpD6yDZjauOIu0gIDf9EST9R7XG2UQZNibN3OmKsXZZKPeDkBw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PXWPmM9Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PXWPmM9Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6B21C116C6; Tue, 7 Apr 2026 14:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775571042; bh=dQmJSBhhE846Zl7fb0Ou9WeICRvwD7Od8vw4OWLhUjE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PXWPmM9Q0nd+SgJrB7k3YOJfZu7ntdIvoROkswAnEsTJp8OafD+xWR/8DOjzQecGX V4UldNcXMpSgPK54NoQcx44CZAzGVAB1aW8hkjSAUlp4K3GlvAUnYqHe+niCKy+u3y WMMi3mAy8XFV/j3WN/ODAaxhm4m99xizwuK4zV2ohmUvAtHnQtmTAGQzLdXuiKMmb9 PLCGJEk6eKGDHy0Cdf3eJb1gGxk4QtKVNDF89E7UwsOJl42aSnPm3rtydiKUgfw7I8 BX198Xmq8hT6jPcLMhJ7O0KKtJd7uUGMIdkbiitP4XtE9kSYB25L2Hz5SYUdCKkNF+ 8kWycxg266+kw== From: "Rafael J. Wysocki" To: Linux PM Cc: Daniel Lezcano , LKML , Lukasz Luba , Armin Wolf Subject: [PATCH v4 6/6] thermal: core: Suspend thermal zones later and resume them earlier Date: Tue, 07 Apr 2026 16:09:21 +0200 Message-ID: <2036875.PYKUYFuaPT@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <12871778.O9o76ZdvQC@rafael.j.wysocki> References: <12871778.O9o76ZdvQC@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Rafael J. Wysocki To avoid some undesirable interactions between thermal zone suspend and resume with user space that is running when those operations are carried out, move them closer to the suspend and resume of devices, respectively, by updating dpm_prepare() to carry out thermal zone suspend and dpm_complete() to start thermal zone resume (that will continue asynchronously). This also makes the code easier to follow by removing one, arguably redundant, level of indirection represented by the thermal PM notifier. Signed-off-by: Rafael J. Wysocki Reviewed-by: Armin Wolf --- v3 -> v4: * Add R-by from Armin v2 -> v3: * Rebase on top of the v3 of the previous patch v1 -> v2: * Reorder with respect to the previous patch * Use thermal_class_unavailable() to avoid running code that should not run without the thermal class * Suspend thermal zones after disabling device probing and resume them before enabling device probing for better synchronization --- drivers/base/power/main.c | 5 +++ drivers/thermal/thermal_core.c | 60 ++++++++++++------------------------= ----- include/linux/thermal.h | 6 ++++ 3 files changed, 29 insertions(+), 42 deletions(-) --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include =20 @@ -1282,6 +1283,8 @@ void dpm_complete(pm_message_t state) list_splice(&list, &dpm_list); mutex_unlock(&dpm_list_mtx); =20 + /* Start resuming thermal control */ + thermal_pm_complete(); /* Allow device probing and trigger re-probing of deferred devices */ device_unblock_probing(); trace_suspend_resume(TPS("dpm_complete"), state.event, false); @@ -2225,6 +2228,8 @@ int dpm_prepare(pm_message_t state) * instead. The normal behavior will be restored in dpm_complete(). */ device_block_probing(); + /* Suspend thermal control. */ + thermal_pm_prepare(); =20 mutex_lock(&dpm_list_mtx); while (!list_empty(&dpm_list) && !error) { --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1837,7 +1837,7 @@ static void thermal_zone_pm_prepare(stru cancel_delayed_work(&tz->poll_queue); } =20 -static void thermal_pm_notify_prepare(void) +static void __thermal_pm_prepare(void) { struct thermal_zone_device *tz; =20 @@ -1849,6 +1849,19 @@ static void thermal_pm_notify_prepare(vo thermal_zone_pm_prepare(tz); } =20 +void thermal_pm_prepare(void) +{ + if (thermal_class_unavailable) + return; + + __thermal_pm_prepare(); + /* + * Allow any leftover thermal work items already on the worqueue to + * complete so they don't get in the way later. + */ + flush_workqueue(thermal_wq); +} + static void thermal_zone_pm_complete(struct thermal_zone_device *tz) { guard(thermal_zone)(tz); @@ -1865,10 +1878,13 @@ static void thermal_zone_pm_complete(str mod_delayed_work(thermal_wq, &tz->poll_queue, 0); } =20 -static void thermal_pm_notify_complete(void) +void thermal_pm_complete(void) { struct thermal_zone_device *tz; =20 + if (thermal_class_unavailable) + return; + guard(mutex)(&thermal_list_lock); =20 thermal_pm_suspended =3D false; @@ -1877,41 +1893,6 @@ static void thermal_pm_notify_complete(v thermal_zone_pm_complete(tz); } =20 -static int thermal_pm_notify(struct notifier_block *nb, - unsigned long mode, void *_unused) -{ - switch (mode) { - case PM_HIBERNATION_PREPARE: - case PM_RESTORE_PREPARE: - case PM_SUSPEND_PREPARE: - thermal_pm_notify_prepare(); - /* - * Allow any leftover thermal work items already on the - * worqueue to complete so they don't get in the way later. - */ - flush_workqueue(thermal_wq); - break; - case PM_POST_HIBERNATION: - case PM_POST_RESTORE: - case PM_POST_SUSPEND: - thermal_pm_notify_complete(); - break; - default: - break; - } - return 0; -} - -static struct notifier_block thermal_pm_nb =3D { - .notifier_call =3D thermal_pm_notify, - /* - * Run at the lowest priority to avoid interference between the thermal - * zone resume work items spawned by thermal_pm_notify() and the other - * PM notifiers. - */ - .priority =3D INT_MIN, -}; - static int __init thermal_init(void) { int result; @@ -1938,11 +1919,6 @@ static int __init thermal_init(void) =20 thermal_class_unavailable =3D false; =20 - result =3D register_pm_notifier(&thermal_pm_nb); - if (result) - pr_warn("Thermal: Can not register suspend notifier, return %d\n", - result); - return 0; =20 unregister_governors: --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -273,6 +273,9 @@ bool thermal_trip_is_bound_to_cdev(struc int thermal_zone_device_enable(struct thermal_zone_device *tz); int thermal_zone_device_disable(struct thermal_zone_device *tz); void thermal_zone_device_critical(struct thermal_zone_device *tz); + +void thermal_pm_prepare(void); +void thermal_pm_complete(void); #else static inline struct thermal_zone_device *thermal_zone_device_register_wit= h_trips( const char *type, @@ -350,6 +353,9 @@ static inline int thermal_zone_device_en =20 static inline int thermal_zone_device_disable(struct thermal_zone_device *= tz) { return -ENODEV; } + +static inline void thermal_pm_prepare(void) {} +static inline void thermal_pm_complete(void) {} #endif /* CONFIG_THERMAL */ =20 #endif /* __THERMAL_H__ */