From nobody Mon Jun 15 00:22:09 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D0553939C8; Tue, 7 Apr 2026 07:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775546834; cv=none; b=UPx03HQ8eCaADxXa8b7FXxNvoiCJYUPlIS69maN36SNO3DEMSMQCFBq5b/S2aKSmdGeIGXjTodcBIA7gKiQTdDKZLbRrR4eN2kO4F0+oPhEghwzbH8rf3tGD362Cps+Zv1LXEW7ATrvICl/WDQFTreaaHnteBkJ6G6Qgv/Ifbjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775546834; c=relaxed/simple; bh=zM+idbGQ3gtU10W8LfYvzJOIaRuXj9x2UvCIs5je5D0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gFi+Ap4P1fbTs/nhlceP1MykAGMktz8SiLpyU7cEBeFWQNX2iSYs5rjEpk19xOnsU2AeGtXgak1P3LqC9kDBbPW9GinN5p4vysXt1DGNd3lkVtFeiR2JhiO9m5YrD40ArFNyfgjMXRwenj3MCwdY00EO4tpJpklZ0t/JfquezcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 2cea3824325311f1aa26b74ffac11d73-20260407 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:89bc7613-b92a-44ba-bd44-f4baee65e200,IP:0,U RL:0,TC:0,Content:-25,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:965edecb4007e0332f95446e105f3848,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:5 ,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV :0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 2cea3824325311f1aa26b74ffac11d73-20260407 X-User: xiaopei01@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1129026814; Tue, 07 Apr 2026 15:27:04 +0800 From: Pei Xiao To: broonie@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Pei Xiao Subject: [PATCH V2] spi: mtk-snfi: unregister ECC engine on probe failure and remove() callback Date: Tue, 7 Apr 2026 15:26:59 +0800 Message-Id: <20263f885f1a9c9d559f95275298cd6de4b11ed5.1775546401.git.xiaopei01@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mtk_snand_probe() registers the on-host NAND ECC engine, but teardown was missing from both probe unwind and remove-time cleanup. Add a devm cleanup action after successful registration so nand_ecc_unregister_on_host_hw_engine() runs automatically on probe failures and during device removal. Fixes: 764f1b748164 ("spi: add driver for MTK SPI NAND Flash Interface") Signed-off-by: Pei Xiao --- changlog in v2: dev_err changes to dev_err_probe --- drivers/spi/spi-mtk-snfi.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c index 437edbd658aa..73fa84475f0e 100644 --- a/drivers/spi/spi-mtk-snfi.c +++ b/drivers/spi/spi-mtk-snfi.c @@ -1303,6 +1303,13 @@ static const struct spi_controller_mem_caps mtk_snan= d_mem_caps =3D { .ecc =3D true, }; =20 +static void mtk_unregister_ecc_engine(void *data) +{ + struct nand_ecc_engine *eng =3D data; + + nand_ecc_unregister_on_host_hw_engine(eng); +} + static irqreturn_t mtk_snand_irq(int irq, void *id) { struct mtk_snand *snf =3D id; @@ -1443,6 +1450,13 @@ static int mtk_snand_probe(struct platform_device *p= dev) goto release_ecc; } =20 + ret =3D devm_add_action_or_reset(&pdev->dev, mtk_unregister_ecc_engine, + &ms->ecc_eng); + if (ret) { + dev_err_probe(&pdev->dev, ret, "failed to add ECC unregister action\n"); + goto release_ecc; + } + ctlr->num_chipselect =3D 1; ctlr->mem_ops =3D &mtk_snand_mem_ops; ctlr->mem_caps =3D &mtk_snand_mem_caps; --=20 2.25.1