From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827392; b=oTwrQ05HScw7lo2ay3oYQRnlattxeIxR4KUNkV6VGP9Z0XS4+IiNzHaCz2eNlmwrEps9 XWsgX1U4MFwgjaLOASZx+YwVKtb+khi9JZOCYLKkThPITWo+msNyE6FptS43EGSSiu5e/ pyL0fDGf4GAzkgFEcpCt3FCUalbLWAGF2EZiFP6XT63XK1yufmDoNoE6o40hpZIg3PXrY uRaAD6TaugK8fRZPLnqM6iJfxX9UnkrcYuVx12hz3SkcGJxqFQdL8T+7ct0hnzqgru2qq ISbtM9yjtyNPNrzunruCKqt4hCWCgC4djN9/zWDeeb7NPeJbNg7bgORe8yQXBAo/agw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827392; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=bWZrsX7aWlMbwvlLKJqbJrwnBhxG4JV+WqMba30KTxI=; b=aTWdsz5/yY56WrFizkb+RgyBc5eCTbp6dSyLubYTC+yS5LxpioSikVt3f4+yLXe3f/N4 UoqpuSUcbRUNL4/cvuvvCgQbgT92rpEU6tT/kv/xvVu7TNWUQ67kW7cDdBk9GxmIuLnZO Y1a8CjVx3cdB0VdGp6ICUXVPnoJhbZVdBJYd1P8mOVrGqgdb04ZhvYzFvhMFOTOzOF9eH jzoXkFDOYy9GqSJiJhHnDm0AmcQhYr6y85zqy1KDKOoil9PsOXHtCCdlbSZqaaFMoPUee L3CU4RJeMvy5yB6FrI30jpVHeLvB2UhhslmCVVrk25nFQS/khqdb3KLEtZ7SMDpSoAQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mzZVjiAC; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77131607BDAE; Mon, 16 Nov 2026 11:09:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 77131607BDAE Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mzZVjiAC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827393; x=1826363393; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9lxGVvT3vxsJLouzD6uoqq/ubjW0JxIDBomkq69iZzc=; b=mzZVjiACHdTMTQcvX6vauMQdSHfQta7JSvbovbjzwJq8C5NtX6ydIGQd tECxFPicdQwixdUACmSDTXpLRFwhvBWN9J8hnyixXtCT5NsAREG/O2Aga eXyYo6/r9C7hmSssSfogeozZ+iGq4lAni/0FHDjMNBbIQw6dU6j0sBl8Y n+a2qPlz4Dru1pIA7lGR4NqAUkStiu4u3e93vAtQoapoDyurnyiXAt6yL joYsnaQwPeojAwCY2W6wY9OhZfuoN2KwsbRosUJAY3tmrPEvp0dUI29JK lwGI0JHMhfN6dJn0ypn5wcIbHabkxVcSfbVXSdl/1z+Uw7PxcJE9Pr8oN g==; X-CSE-ConnectionGUID: DMfKerVgQwOqKa2EISIpBQ== X-CSE-MsgGUID: iOczUZUFRva+74eqBJdgvw== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429600" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429600" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:52 -0800 X-CSE-ConnectionGUID: GnjyuEbnSVKCTGS2ir7Ulg== X-CSE-MsgGUID: WWcnUJP/SLqjthyP2XC2og== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848119" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:52 -0800 From: Chao Gao To: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau Subject: [RFC PATCH 1/7] coco/tdx-host: Create metadata for an SPDM session Date: Mon, 16 Nov 2026 03:10:19 -0800 Message-ID: <20261116111037.3478844-2-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TDX module talks to the device over a Security Protocol and Data Model (SPDM) session. It needs host memory for each session's metadata, and reports the number of pages required in its global metadata. When setting up an SPDM session, allocate the memory and hand it to the TDX module with TDH.SPDM.CREATE. Keep the returned session ID for later SEAMCALLs. When tearing the session down, reclaim the memory with TDH.SPDM.DELETE. If that fails, leak the memory, as the TDX module may still be using it. Based on work by Yilun and Zhenzhong. Signed-off-by: Chao Gao --- arch/x86/include/asm/tdx_global_metadata.h | 1 + arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 6 ++ drivers/virt/coco/tdx-host/main.c | 104 +++++++++++++++++++- 3 files changed, 109 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/tdx_global_metadata.h b/arch/x86/include/= asm/tdx_global_metadata.h index e5e54159ad36..537e872eeb0e 100644 --- a/arch/x86/include/asm/tdx_global_metadata.h +++ b/arch/x86/include/asm/tdx_global_metadata.h @@ -52,6 +52,7 @@ struct tdx_sys_info_ext { }; =20 struct tdx_sys_info_connect { + u16 spdm_mt_page_count; u16 iommu_mt_page_count; }; =20 diff --git a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c b/arch/x86/virt/vm= x/tdx/tdx_global_metadata.c index 9b46f34cb469..f20e029f240b 100644 --- a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c +++ b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c @@ -144,6 +144,12 @@ static __init int get_tdx_sys_info_connect(struct tdx_= sys_info_connect *sysinfo_ int ret; u64 val; =20 + ret =3D read_sys_metadata_field(0x3000000100000002, &val); + if (ret) + return ret; + + sysinfo_connect->spdm_mt_page_count =3D val; + ret =3D read_sys_metadata_field(0x3000000100000003, &val); if (ret) return ret; diff --git a/drivers/virt/coco/tdx-host/main.c b/drivers/virt/coco/tdx-host= /main.c index a815dbe5127a..919e77ae2326 100644 --- a/drivers/virt/coco/tdx-host/main.c +++ b/drivers/virt/coco/tdx-host/main.c @@ -5,6 +5,7 @@ * Copyright (C) 2025 Intel Corporation */ =20 +#include #include #include #include @@ -26,8 +27,30 @@ static const struct x86_cpu_id tdx_host_ids[] =3D { }; MODULE_DEVICE_TABLE(x86cpu, tdx_host_ids); =20 +#define TDISP_FUNC_ID GENMASK(15, 0) +#define TDISP_FUNC_ID_SEGMENT GENMASK(23, 16) +#define TDISP_FUNC_ID_SEG_VALID BIT(24) + +static inline u32 tdisp_func_id(struct pci_dev *pdev) +{ + u32 func_id; + + func_id =3D FIELD_PREP(TDISP_FUNC_ID_SEGMENT, pci_domain_nr(pdev->bus)); + if (func_id) + func_id |=3D TDISP_FUNC_ID_SEG_VALID; + func_id |=3D FIELD_PREP(TDISP_FUNC_ID, + PCI_DEVID(pdev->bus->number, pdev->devfn)); + + return func_id; +} + struct tdx_tsm_link { struct pci_tsm_pf0 pci; + u32 func_id; + + u64 spdm_id; + unsigned int spdm_mt_nr_pages; + void *spdm_mt; }; =20 static struct tdx_tsm_link *to_tdx_tsm_link(struct pci_tsm *tsm) @@ -35,21 +58,97 @@ static struct tdx_tsm_link *to_tdx_tsm_link(struct pci_= tsm *tsm) return container_of(tsm, struct tdx_tsm_link, pci.base_tsm); } =20 +static int tdx_spdm_create(struct tdx_tsm_link *tlink) +{ + const struct tdx_sys_info *tdx_sysinfo =3D tdx_get_sysinfo(); + struct tdx_hpa_list_info info; + unsigned int nr_pages; + u64 spdm_id, sret; + void *spdm_mt; + int ret; + + if (!tdx_sysinfo) + return -ENXIO; + + nr_pages =3D tdx_sysinfo->tdx_connect.spdm_mt_page_count; + + spdm_mt =3D alloc_pages_exact(nr_pages * PAGE_SIZE, + GFP_KERNEL | __GFP_ZERO); + if (!spdm_mt) + return -ENOMEM; + + ret =3D tdx_hpa_list_info_setup(&info, spdm_mt, nr_pages); + if (ret) + goto out_free_spdm_mt; + + sret =3D tdh_spdm_create(tlink->func_id, &info, &spdm_id); + + tdx_hpa_list_info_free(&info); + + if (sret) { + ret =3D -EIO; + goto out_free_spdm_mt; + } + + tlink->spdm_id =3D spdm_id; + tlink->spdm_mt =3D spdm_mt; + tlink->spdm_mt_nr_pages =3D nr_pages; + return 0; + +out_free_spdm_mt: + free_pages_exact(spdm_mt, nr_pages * PAGE_SIZE); + return ret; +} + +static void tdx_spdm_delete(struct tdx_tsm_link *tlink) +{ + struct pci_dev *pdev =3D tlink->pci.base_tsm.pdev; + u64 sret; + + sret =3D tdh_spdm_delete(tlink->spdm_id); + if (sret) { + /* leak the metadata pages */ + pci_err(pdev, "fail to delete spdm 0x%llx\n", sret); + return; + } + + free_pages_exact(tlink->spdm_mt, tlink->spdm_mt_nr_pages * PAGE_SIZE); +} + +static int tdx_spdm_session_setup(struct tdx_tsm_link *tlink) +{ + return tdx_spdm_create(tlink); +} + +static void tdx_spdm_session_teardown(struct tdx_tsm_link *tlink) +{ + tdx_spdm_delete(tlink); +} + static int tdx_tsm_link_connect(struct pci_dev *pdev) { + struct tdx_tsm_link *tlink =3D to_tdx_tsm_link(pdev->tsm); int ret; =20 ret =3D tdx_iommu_get(pdev); if (ret) return ret; =20 - /* TDISP connect is not implemented yet. */ + ret =3D tdx_spdm_session_setup(tlink); + if (ret) + goto out_iommu_put; + return 0; + +out_iommu_put: tdx_iommu_put(pdev); - return -ENXIO; + return ret; } =20 static void tdx_tsm_link_disconnect(struct pci_dev *pdev) { + struct tdx_tsm_link *tlink =3D to_tdx_tsm_link(pdev->tsm); + + tdx_spdm_session_teardown(tlink); tdx_iommu_put(pdev); } =20 @@ -66,6 +165,7 @@ static struct pci_tsm *tdx_tsm_link_pf0_probe(struct tsm= _dev *tsm_dev, if (rc) return NULL; =20 + tlink->func_id =3D tdisp_func_id(pdev); return &no_free_ptr(tlink)->pci.base_tsm; } =20 --=20 2.52.0 From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827393; b=B2LmCcGszSkgjamfZ5g9Z2824pwBq9OK+450Lsfe6oWtlD36AeTTcqtBkYrxqYzX65ki fS3NzWLhIxOjMVqXEIp47n13ZWFFFiGkp7uM6BaPfZe6+PrRSQBGu14pResyyp8MyEkoK uGq8BJGNAlaTE8lvTD8SChqquRf633bPyQ1URdKVAbAeUTcAWCBoAh1Bv5nDbULcB83+r OuWIdzTTr2mw7XgxQSyjAxUWx9BVaGarfjKV+R7qchMYREs03usi0L+UHJGv7Mxxt40MB n5au8vyhMFcmlrZTNMRoBF5RHX6Sv9pvv/ogNLLC9CzHMKccdxFlW1DRt6oGNI2ohKw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827393; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=P3cJOvgm1t/vUBV/SgDsnTWVy5reKbszdOnvyiXGN6k=; b=MUN0rMj4A8Er84gQX6yLQ0VtHuqqe7NCpoYOONWH/BVATnLkigC7vMhkDCyslynMX0Ut HU9XAIiYCgRlA/YqYPOqgEJ65En+TQU2d5l1G+JfBclSwYcJCBybGrSDuel0HJuZ76cV+ KuszOWUk8lOy39JgDzonM84UZslakw8TcHh53flz8H2BAIwdiolfCdu6LlhS0wMW7/9cO t0zYS7O4ezztbHiGC8ughgyv5DSCngRK+eVUQPQx40zdxgmkdMNq43Hxx30FBXcfzgL7C h1Yc32X3Dtg4ryXci5+LJptuDGpUe6bbinoMhw8AD3LDN6wlyrpDUVK5tjfHi1s8knQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bG7IqJZ+; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 283D7606FA41; Mon, 16 Nov 2026 11:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 283D7606FA41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bG7IqJZ+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827393; x=1826363393; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WX4WJPA0q/4AFwvPGb2TbFrG51YgUZPK8MybkUla+48=; b=bG7IqJZ+sU7/jjrSA1ynssz5J+nEbRyAa0iyN/RuvAlod0F6o349W1jS stpJzQD7fAW18kH7A2Z4lPTN7rczUtBeJQxxXt2++k4VrwKSkj4nvtCaB 2R4tLWXXzCxZJWqyW8jwzriXXVoJULcs2xzDeWf1gEHUUfPJYCw8HaaEq O2+IX5YlvPsCY8bBr6NEbORs49giykfqybE66oYrh3/zCe+ze059+5trR FnM7TekArBheA8xnO8O1b2gkaZHLd7scDagU6yqALCZiLFdX2MfsMpdon O6hOnMUKpOSuOsQFjv/y0MbsPnbjxe9PcOKrRPr9j7F59SSAFqMLbwQxK w==; X-CSE-ConnectionGUID: ippKBDKZQVG0q2ekmOwYaw== X-CSE-MsgGUID: ZkJrmc+2SMa+DVvoburY6A== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429606" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429606" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:53 -0800 X-CSE-ConnectionGUID: 3YCKRXbhSay3EmMiCPSV/A== X-CSE-MsgGUID: fl6FsRpvRGaeCKZWG1igZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848122" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:53 -0800 From: Chao Gao To: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau Subject: [RFC PATCH 2/7] coco/tdx-host: Establish an SPDM session with the device Date: Mon, 16 Nov 2026 03:10:20 -0800 Message-ID: <20261116111037.3478844-3-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Setting up PCIe link encryption requires a secure channel to the device to exchange keys. This channel is an SPDM session over the device's PCI DOE mailbox. The TDX module cannot access the DOE mailbox but needs to exchange SPDM messages with the device, so the host relays SPDM messages between the two. TDH.SPDM.CONNECT establishes the session and TDH.SPDM.DISCONNECT tears it down. Both may need several message exchanges with the device. Whenever the TDX module has a message for the device, the SEAMCALL returns with a dedicated status code. The host sends the message to the device and calls the SEAMCALL again with the device's response, until the SEAMCALL completes. Call both SEAMCALLs in such a loop. The DOE transfer itself is a stub for now. Pass the messages through two pages per device, one for each direction. One pair is enough because PCI/TSM serializes operations on a device. The TDX module limits how many TDH.SPDM.CONNECT and TDH.SPDM.DISCONNECT calls can run at the same time. The limit is implementation-specific, and a call over the limit fails with TDX_OPERAND_BUSY. For simplicity, serialize them across all devices with a mutex. Based on work by Yilun. Signed-off-by: Chao Gao --- arch/x86/include/asm/shared/tdx_errno.h | 1 + drivers/virt/coco/tdx-host/main.c | 131 +++++++++++++++++++++++- 2 files changed, 130 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/shared/tdx_errno.h b/arch/x86/include/asm= /shared/tdx_errno.h index ee411b360e20..6581cec7e097 100644 --- a/arch/x86/include/asm/shared/tdx_errno.h +++ b/arch/x86/include/asm/shared/tdx_errno.h @@ -27,6 +27,7 @@ #define TDX_EPT_WALK_FAILED 0xC0000B0000000000ULL #define TDX_EPT_ENTRY_STATE_INCORRECT 0xC0000B0D00000000ULL #define TDX_METADATA_FIELD_NOT_READABLE 0xC0000C0200000000ULL +#define TDX_SPDM_REQUEST 0x00000F5700000000ULL =20 /* * TDX module operand ID, appears in 31:0 part of error code as diff --git a/drivers/virt/coco/tdx-host/main.c b/drivers/virt/coco/tdx-host= /main.c index 919e77ae2326..32755d70dac5 100644 --- a/drivers/virt/coco/tdx-host/main.c +++ b/drivers/virt/coco/tdx-host/main.c @@ -44,11 +44,26 @@ static inline u32 tdisp_func_id(struct pci_dev *pdev) return func_id; } =20 +#define SPDM_CAP_HBEAT BIT(13) +#define SPDM_CAP_KEY_UPD BIT(14) + +struct spdm_config_info_t { + u32 vmm_spdm_cap; + u8 spdm_session_policy; + u8 certificate_slot_mask; + u8 raw_bitstream_requested; + u8 reserved[4089]; +} __packed; + +static_assert(sizeof(struct spdm_config_info_t) =3D=3D 4096); + struct tdx_tsm_link { struct pci_tsm_pf0 pci; u32 func_id; =20 u64 spdm_id; + struct page *in_msg; + struct page *out_msg; unsigned int spdm_mt_nr_pages; void *spdm_mt; }; @@ -58,9 +73,89 @@ static struct tdx_tsm_link *to_tdx_tsm_link(struct pci_t= sm *tsm) return container_of(tsm, struct tdx_tsm_link, pci.base_tsm); } =20 +static int tdx_spdm_msg_exchange(struct tdx_tsm_link *tlink) +{ + /* TODO: implement the PCI DOE transfer */ + return 0; +} + +/* + * When serving SEAMCALLs, the TDX module extensions work like service thr= ead + * pools. The number of service threads is limited per service type (or + * "per extension" in terms of TDX). When the host issues a request via + * SEAMCALL but the TDX module can't find an available thread, it returns + * TDX_OPERAND_BUSY. Currently the thread number limit for the TDISP exten= sion + * is 1. So a mutex could work to prevent SEAMCALL busy returns. + */ +static DEFINE_MUTEX(tdx_spdm_lock); + +static int tdx_spdm_xfer_handler(struct tdx_tsm_link *tlink, u64 sret, + u64 out_msg_sz) +{ + int ret; + + if (sret =3D=3D TDX_SPDM_REQUEST) { + ret =3D tdx_spdm_msg_exchange(tlink); + if (ret < 0) + return ret; + + return -EAGAIN; + } + + if (sret =3D=3D TDX_SUCCESS) + return 0; + + return -EIO; +} + +static int tdx_spdm_session_connect(struct tdx_tsm_link *tlink) +{ + struct spdm_config_info_t *spdm_conf; + u64 sret, out_msg_sz; + int ret; + + /* create & fill SPDM configuration buffer - a single page */ + spdm_conf =3D kzalloc_obj(*spdm_conf); + if (!spdm_conf) + return -ENOMEM; + + spdm_conf->certificate_slot_mask =3D 0xff; + + do { + mutex_lock(&tdx_spdm_lock); + sret =3D tdh_spdm_connect(tlink->spdm_id, + virt_to_page(spdm_conf), + tlink->in_msg, tlink->out_msg, + NULL, &out_msg_sz); + mutex_unlock(&tdx_spdm_lock); + ret =3D tdx_spdm_xfer_handler(tlink, sret, out_msg_sz); + } while (ret =3D=3D -EAGAIN); + + kfree(spdm_conf); + + return ret; +} + +static void tdx_spdm_session_disconnect(struct tdx_tsm_link *tlink) +{ + u64 sret, out_msg_sz; + int ret; + + do { + mutex_lock(&tdx_spdm_lock); + sret =3D tdh_spdm_disconnect(tlink->spdm_id, tlink->in_msg, + tlink->out_msg, &out_msg_sz); + mutex_unlock(&tdx_spdm_lock); + ret =3D tdx_spdm_xfer_handler(tlink, sret, out_msg_sz); + } while (ret =3D=3D -EAGAIN); + + WARN_ON(ret); +} + static int tdx_spdm_create(struct tdx_tsm_link *tlink) { const struct tdx_sys_info *tdx_sysinfo =3D tdx_get_sysinfo(); + struct page *in_msg_page, *out_msg_page; struct tdx_hpa_list_info info; unsigned int nr_pages; u64 spdm_id, sret; @@ -70,12 +165,21 @@ static int tdx_spdm_create(struct tdx_tsm_link *tlink) if (!tdx_sysinfo) return -ENXIO; =20 + ret =3D -ENOMEM; + in_msg_page =3D alloc_page(GFP_KERNEL | __GFP_ZERO); + if (!in_msg_page) + return ret; + + out_msg_page =3D alloc_page(GFP_KERNEL | __GFP_ZERO); + if (!out_msg_page) + goto out_free_in_msg; + nr_pages =3D tdx_sysinfo->tdx_connect.spdm_mt_page_count; =20 spdm_mt =3D alloc_pages_exact(nr_pages * PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); if (!spdm_mt) - return -ENOMEM; + goto out_free_out_msg; =20 ret =3D tdx_hpa_list_info_setup(&info, spdm_mt, nr_pages); if (ret) @@ -92,11 +196,17 @@ static int tdx_spdm_create(struct tdx_tsm_link *tlink) =20 tlink->spdm_id =3D spdm_id; tlink->spdm_mt =3D spdm_mt; + tlink->in_msg =3D in_msg_page; + tlink->out_msg =3D out_msg_page; tlink->spdm_mt_nr_pages =3D nr_pages; return 0; =20 out_free_spdm_mt: free_pages_exact(spdm_mt, nr_pages * PAGE_SIZE); +out_free_out_msg: + __free_page(out_msg_page); +out_free_in_msg: + __free_page(in_msg_page); return ret; } =20 @@ -112,16 +222,33 @@ static void tdx_spdm_delete(struct tdx_tsm_link *tlin= k) return; } =20 + __free_page(tlink->in_msg); + __free_page(tlink->out_msg); free_pages_exact(tlink->spdm_mt, tlink->spdm_mt_nr_pages * PAGE_SIZE); } =20 static int tdx_spdm_session_setup(struct tdx_tsm_link *tlink) { - return tdx_spdm_create(tlink); + int ret; + + ret =3D tdx_spdm_create(tlink); + if (ret) + return ret; + + ret =3D tdx_spdm_session_connect(tlink); + if (ret) + goto out_spdm_delete; + + return 0; + +out_spdm_delete: + tdx_spdm_delete(tlink); + return ret; } =20 static void tdx_spdm_session_teardown(struct tdx_tsm_link *tlink) { + tdx_spdm_session_disconnect(tlink); tdx_spdm_delete(tlink); } =20 --=20 2.52.0 From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827394; b=YCovBzb+zpl8h5AH3OpUq+OzlAb0TnHRk/4n25MqvApYWCi8h74rIgB46D8iIBgIW7wq XykODduOSk7LenkvLh7/5ONfh5n9OB1DJPm30mrtDXPKzfdv75+ZlpVQQrB2TyjSIBaZs 77Pqkji3KnXWaQPS/aFe7YYesSivnGWF38GP8F/IDrRIn6PwbLY33erCz09sbAske4SqQ mAAGyw0KOGIZqwwPjxp7xUlmJNUL0OQklPzMsezlV1/n2xZoeC6HSWv5MFj/mEzQektnR Q70qe9CK571D43CPGJo/Q6tI1B/uT5tTc6GcwLJ3/5miScTUTGbQa3tvZ6I81FmUxgg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827394; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=I50HoopRxa3buonCeeRPTdblT7XpCyHv/F3JuXs3y4U=; b=b8K9DJvON9GFyemySSAvyjNTbDXQisex/ZWEZVJpcV1+WgkCiy1bXVJBIAVBKr0OV/+Q aL/ED/qmv206geyZZ9Oxd5FQyoVcBLn55DvOGHZKiGUcqoVgj4wCDV6eAz1Es7e4lVcMh XFxmcR/tQySMfRxVZumAcaVdQOTOVuF8qOUMvgsB84/n94dswF0GyVd0h8spo3BcL0/xJ U7Eg5wbmBKoVOLyX+5idD1vxYPpeatpC5VETOZwEWOYT0JysP5gkLtJ/1GjbM48P2dA2m /xytx8yddW7kGVwK8eZo8+EsgW6hr4TmUeuL5JJg60s44LHIJGnenXUmrwvvqB6bSrQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=M0VUsFTw; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A93606FA40; Mon, 16 Nov 2026 11:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C1A93606FA40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=M0VUsFTw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827394; x=1826363394; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2AXhRaZ6LXJexE1z27G0MrbSL970RhGYxsDjZz3cj9k=; b=M0VUsFTwwHP5kQHQ/YYosnK0amSREq17X24OLpsrCIEJE6/DmxBJJmks GOrXCmciyLuuKi/AnRFvDACC8djU0eXxJX9kqv3NreeUewc2xRB7LjZaR GvfgxyoWF1mnrRwEl2IB0WRSv9UxjKMOI3Z5hI4S4IQBOmwHYxJoTHvZF 06vdnw+RhEr3yJCDyOwNwL+5qycS/kivrRydPlLjwZBYk4dpasK4XlCEM 9mSLc4G242GOHxXnCbmqVNu40q9sHScVu2yRQF8Zmsv9VcD0Z7kJVBscC Z13J6nqywKRIqEEsa5wMUoKEN7TVF5BVWqcTYTMhEmZEFL0Wc8tNqRUjR w==; X-CSE-ConnectionGUID: sBee3eOpQjCh1bZC9jz7YA== X-CSE-MsgGUID: 8ZIdOXiwRemWb86HzIewDw== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429612" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429612" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:54 -0800 X-CSE-ConnectionGUID: HHCspzSSRB+PBfABOgJyRw== X-CSE-MsgGUID: qwSVI+qUS+u3QjTNG73DAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848125" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:53 -0800 From: Chao Gao To: x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Kiryl Shutsemau , Dave Hansen Subject: [RFC PATCH 3/7] coco/tdx-host: Exchange SPDM messages through DOE Date: Mon, 16 Nov 2026 03:10:21 -0800 Message-ID: <20261116111037.3478844-4-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TDX module cannot access a device's DOE mailbox, so the kernel relays SPDM messages between the TDX module and the device. The TDX module produces and consumes whole DOE data objects, header included, but pci_tsm_doe_transfer() takes only the payload and builds the header itself. Define struct pci_doe_header and struct pci_doe_msg to describe a DOE data object. Strip the header from each request before passing the payload to pci_tsm_doe_transfer(), and rebuild the header around the device's response before handing it back to the TDX module. An alternative is to add a PCI DOE API that takes whole data objects. This would avoid the conversion, but the TDX-TSM driver would be its only user. Based on work by Yilun. AI suggested defining the DOE header and object structures in place of the bit operations, and dropping the endian conversions. Signed-off-by: Chao Gao --- drivers/virt/coco/tdx-host/main.c | 49 ++++++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers/virt/coco/tdx-host/main.c b/drivers/virt/coco/tdx-host= /main.c index 32755d70dac5..86299658ae45 100644 --- a/drivers/virt/coco/tdx-host/main.c +++ b/drivers/virt/coco/tdx-host/main.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include =20 @@ -73,9 +74,55 @@ static struct tdx_tsm_link *to_tdx_tsm_link(struct pci_t= sm *tsm) return container_of(tsm, struct tdx_tsm_link, pci.base_tsm); } =20 +struct pci_doe_header { + u16 vendor; + u8 type; + u8 rsvd0; + u32 length: 18; /* in DWORDs */ + u32 rsvd1: 14; +} __packed; + +struct pci_doe_msg { + struct pci_doe_header header; + u8 payload[]; +} __packed; + +/* + * The TDX module produces and consumes complete DOE data objects, but + * pci_doe() takes only the payload and builds the header itself. Strip + * the header from the request and rebuild it for the response. + */ static int tdx_spdm_msg_exchange(struct tdx_tsm_link *tlink) { - /* TODO: implement the PCI DOE transfer */ + struct pci_dev *pdev =3D tlink->pci.base_tsm.pdev; + struct pci_doe_msg *req =3D page_address(tlink->out_msg); + struct pci_doe_msg *resp =3D page_address(tlink->in_msg); + + size_t req_sz =3D req->header.length * sizeof(u32); + size_t resp_sz =3D PAGE_SIZE; + + size_t req_payload_sz =3D req_sz - sizeof(struct pci_doe_header); + size_t resp_payload_sz =3D resp_sz - sizeof(struct pci_doe_header); + + void *resp_payload_addr =3D resp->payload; + void *req_payload_addr =3D req->payload; + + u8 type =3D req->header.type; + + int ret; + + ret =3D pci_tsm_doe_transfer(pdev, type, + req_payload_addr, req_payload_sz, + resp_payload_addr, resp_payload_sz); + if (ret < 0) { + pci_err(pdev, "spdm msg exchange fail %d\n", ret); + return ret; + } + + resp->header.vendor =3D PCI_VENDOR_ID_PCI_SIG; + resp->header.type =3D type; + resp->header.length =3D (ret + sizeof(struct pci_doe_header)) / sizeof(u3= 2); + return 0; } =20 --=20 2.52.0 From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827395; b=ojQKK3xpXFQkeC+v7MfxsHJkGPEe1JoGac0PnMxgetFt0+/INGckQBfuaFe1CTQaje8h R9CGRUp/0CMQHbEQIN29CYJliAMO2NCw395p65B+tPxMwKfXb7pJXIdE8vJPHm5jYd6Dk Dmz2mMWpJRQr44Q8cuhmk8CYedLIYnrgXE6wcHs3cvMRaTSsLhcEnGuNnDkAnDtiE8N4F GgI9ijgULlxiojnQdyZUuz7mNApLIIqGPBlRBY4I98aCyd+lbA9EzpvX8aORNcfOG5V+r HKfKq6p7GMdzbv9fJopkNx/ZR028WXe6w3uae64gOMHZxHD+1AUiMG6oAtKtF8bt/bA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827395; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=ea9lwwZqx0Fhut6tkttK1ey1EZJvZdhuW5q9l8B81uM=; b=lB2/PQibKL/Tj6D8FoOYpf1KowBU7az0HkMXnyLGovqrbd4lvsMyvDa2f26BhGjDlzno k1yzzhFiDExFAS6DKhUIiu+iXrLpg8ml/oH/0VfV9IzITeBB+aF5P0lMa9sTIrakZVpCN JH9dvHchIJZ0AoPBwZ4jVV7AprUAaHusRVcYaBMTLKnDE0EuynzgPwLhfyWecL0i6HqsP 3576Moe33yLs+pQ/CaW7Fxza8xwdCR0E+iOakvu/3R8ZOrKAN39kTfgSiCEmxaci1rixj HLNmf1Mkwl0NoAaLGiviHpvwciKENS+LSUpb6M9wW+4abdjOMxrtt7bgGq3kLFEQP1Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=TVeRa0E4; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23C4C607D204; Mon, 16 Nov 2026 11:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 23C4C607D204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=TVeRa0E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827395; x=1826363395; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LXi3lqi7mwnIt0PeIoIaisI/1PD78k2CSvLXt+UxR2Q=; b=TVeRa0E4LcA4UQqrWMMx/cPLQ/HuD174A3QzF6nxw27jddLZHxLeks0Z aMk+EOSlAkBv/bOpl63BIKqjYAa2kfOKrBn3PTDuYzznpQJtRYtlTocIu p64vkwaI8DQBLY0Q7sFdWa7BAiiPkL3N71DXqg/lChQ9YKX69XDs1BAx6 /oMe6FA9vU+VTUUNaoTQq2/ZtA0Q1ldt0l64gJjSkEXmIpC3Ob1rZ5zxZ /y89NCd1BeDZhOw6czB2/+HoqFtfSRZA9n3T7F59re35KnC75XJoDia6M ERnzscqavd5ot16wOFpVDFN2O3kT63GNGt0zN3u+N3ffpHYi/WB+82eaZ g==; X-CSE-ConnectionGUID: aatFxhjQT3CfJlCQA9adsA== X-CSE-MsgGUID: spPApCFkQ+O38pQUedNIOA== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429616" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429616" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:55 -0800 X-CSE-ConnectionGUID: K0wFedccTxSIlfX62SeNWQ== X-CSE-MsgGUID: ZCBMM4UmSA6znCuN2PxlWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848128" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:54 -0800 From: Chao Gao To: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau Subject: [RFC PATCH 4/7] coco/tdx-host: Pass a device info buffer to tdh_spdm_connect() Date: Mon, 16 Nov 2026 03:10:22 -0800 Message-ID: <20261116111037.3478844-5-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" TDH.SPDM.CONNECT requires a host-provided buffer, into which the TDX module writes information about the device. TDs will use the information to attest the device, which is not supported yet. The kernel doesn't use it for now, so treat it as opaque data. Take the buffer size from the TDX global metadata, and keep the buffer for the lifetime of the SPDM session. Based on work by Yilun. [This patch will be reworked when the series moves to the CTLV attestation flow.] Signed-off-by: Chao Gao --- arch/x86/include/asm/tdx_global_metadata.h | 1 + arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 6 +++++ drivers/virt/coco/tdx-host/main.c | 27 +++++++++++++++++++-- 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/tdx_global_metadata.h b/arch/x86/include/= asm/tdx_global_metadata.h index 537e872eeb0e..30f3ca006e88 100644 --- a/arch/x86/include/asm/tdx_global_metadata.h +++ b/arch/x86/include/asm/tdx_global_metadata.h @@ -54,6 +54,7 @@ struct tdx_sys_info_ext { struct tdx_sys_info_connect { u16 spdm_mt_page_count; u16 iommu_mt_page_count; + u16 spdm_max_dev_info_pages; }; =20 struct tdx_sys_info { diff --git a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c b/arch/x86/virt/vm= x/tdx/tdx_global_metadata.c index f20e029f240b..cf747b0dc945 100644 --- a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c +++ b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c @@ -156,6 +156,12 @@ static __init int get_tdx_sys_info_connect(struct tdx_= sys_info_connect *sysinfo_ =20 sysinfo_connect->iommu_mt_page_count =3D val; =20 + ret =3D read_sys_metadata_field(0x3000000100000007, &val); + if (ret) + return ret; + + sysinfo_connect->spdm_max_dev_info_pages =3D val; + return 0; } =20 diff --git a/drivers/virt/coco/tdx-host/main.c b/drivers/virt/coco/tdx-host= /main.c index 86299658ae45..da56178eac2e 100644 --- a/drivers/virt/coco/tdx-host/main.c +++ b/drivers/virt/coco/tdx-host/main.c @@ -67,6 +67,8 @@ struct tdx_tsm_link { struct page *out_msg; unsigned int spdm_mt_nr_pages; void *spdm_mt; + unsigned int dev_info_nr_pages; + void *dev_info; }; =20 static struct tdx_tsm_link *to_tdx_tsm_link(struct pci_tsm *tsm) @@ -158,6 +160,7 @@ static int tdx_spdm_xfer_handler(struct tdx_tsm_link *t= link, u64 sret, static int tdx_spdm_session_connect(struct tdx_tsm_link *tlink) { struct spdm_config_info_t *spdm_conf; + struct tdx_hpa_list_info info; u64 sret, out_msg_sz; int ret; =20 @@ -168,16 +171,23 @@ static int tdx_spdm_session_connect(struct tdx_tsm_li= nk *tlink) =20 spdm_conf->certificate_slot_mask =3D 0xff; =20 + ret =3D tdx_hpa_list_info_setup(&info, tlink->dev_info, tlink->dev_info_n= r_pages); + if (ret) + goto out_free_spdm_conf; + do { mutex_lock(&tdx_spdm_lock); sret =3D tdh_spdm_connect(tlink->spdm_id, virt_to_page(spdm_conf), tlink->in_msg, tlink->out_msg, - NULL, &out_msg_sz); + &info, &out_msg_sz); mutex_unlock(&tdx_spdm_lock); ret =3D tdx_spdm_xfer_handler(tlink, sret, out_msg_sz); } while (ret =3D=3D -EAGAIN); =20 + tdx_hpa_list_info_free(&info); + +out_free_spdm_conf: kfree(spdm_conf); =20 return ret; @@ -203,9 +213,11 @@ static int tdx_spdm_create(struct tdx_tsm_link *tlink) { const struct tdx_sys_info *tdx_sysinfo =3D tdx_get_sysinfo(); struct page *in_msg_page, *out_msg_page; + unsigned int dev_info_nr_pages; struct tdx_hpa_list_info info; unsigned int nr_pages; u64 spdm_id, sret; + void *dev_info; void *spdm_mt; int ret; =20 @@ -222,11 +234,17 @@ static int tdx_spdm_create(struct tdx_tsm_link *tlink) goto out_free_in_msg; =20 nr_pages =3D tdx_sysinfo->tdx_connect.spdm_mt_page_count; + dev_info_nr_pages =3D tdx_sysinfo->tdx_connect.spdm_max_dev_info_pages; + + dev_info =3D alloc_pages_exact(dev_info_nr_pages * PAGE_SIZE, + GFP_KERNEL | __GFP_ZERO); + if (!dev_info) + goto out_free_out_msg; =20 spdm_mt =3D alloc_pages_exact(nr_pages * PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); if (!spdm_mt) - goto out_free_out_msg; + goto out_free_dev_info; =20 ret =3D tdx_hpa_list_info_setup(&info, spdm_mt, nr_pages); if (ret) @@ -246,10 +264,14 @@ static int tdx_spdm_create(struct tdx_tsm_link *tlink) tlink->in_msg =3D in_msg_page; tlink->out_msg =3D out_msg_page; tlink->spdm_mt_nr_pages =3D nr_pages; + tlink->dev_info =3D dev_info; + tlink->dev_info_nr_pages =3D dev_info_nr_pages; return 0; =20 out_free_spdm_mt: free_pages_exact(spdm_mt, nr_pages * PAGE_SIZE); +out_free_dev_info: + free_pages_exact(dev_info, dev_info_nr_pages * PAGE_SIZE); out_free_out_msg: __free_page(out_msg_page); out_free_in_msg: @@ -272,6 +294,7 @@ static void tdx_spdm_delete(struct tdx_tsm_link *tlink) __free_page(tlink->in_msg); __free_page(tlink->out_msg); free_pages_exact(tlink->spdm_mt, tlink->spdm_mt_nr_pages * PAGE_SIZE); + free_pages_exact(tlink->dev_info, tlink->dev_info_nr_pages * PAGE_SIZE); } =20 static int tdx_spdm_session_setup(struct tdx_tsm_link *tlink) --=20 2.52.0 From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827396; b=ChsmzuEUaO9wNulQxSEFjcSADt+haDWQyGRKd/V8WlpUsY+q61h/+HYNv/gpLLF8sUey GrpQG+ZyytC3ZEb9OdasaANeA2Z0IzwTdLGLqzFW6ibL0rNpHFZYg1XwYtkDnjGgXJL7f 28uaimdNOtNmGlNOTCd7UkUz2VGAlyVoQA3EuvjF79FDFPH3HLxf9aXBBYu3PyTnomiZS E6B2lirLGLBRmjKlbEOaMUba6XJXT1MPtxaWokT2RbN7foQJVAN1+FnIzX1gaHO9NE7FM /Ox3GsUvwjRV1uoUZ4ya3mr3i7CAd082ldljTwC1uzABw3q6Dg2EX9WdLWktEfp6OoA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827396; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=UVQjDz8uMptXUwHX1U614DZ5+kjG9ZysdKmrZrKVxts=; b=L/dxy0QobtfNezIoNV9iFnFo0zErIUYaMG+FbR7vpWVhU5Alms1SI7KLaEmYI8EXnyOb SSS/bVOzp1QHzzus9KHupebs0cwmDSFLfGjuk1pJQnvn8xp3KdOdlvhZ2bE2s/L6DyQor 1ec0e4y428BiqEIQCx6/Zka+/awpOh5tPElHlZNWA4YaWAIlhe+9qI97AX1VuY/K+ibzS 8wBwWP7SizjO98KWuSLgmID8ePk+RJDer1Nc/tvQ5zW4URlty5UvesJ7WSRTo49k8JuCV cnn9KqnEZQiXhwW5xUIS2+DE4LLGuiiNrbSyLi8DhiLnyzJf9j8cbwkAUOLis9H73Aw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Khzg2r20; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B55607D21F; Mon, 16 Nov 2026 11:09:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 03B55607D21F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Khzg2r20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827396; x=1826363396; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iewts0mO2t3Cm42DkCHvOuE8t5QeVKh5uRkwmUG+hUU=; b=Khzg2r201hP56RnQy9fOrBfzSM/elh1GodYZ5/77TkVDt/EB3IGTSKi1 Qh8fA3qXJIrK1Pg7Il97cz3UzWMXAFwvAcHmeg1hDN5zfzoyjNSzyWwJ+ QOqTlV0rGlBxrjUEhim0D40VncSTJ2QZPMviyT/bQNqeY3ywUyUbJb0II SzvbcstZV4s2BSNL1DNv9TYVfpPSxSzIZxxNJije3EvqmB9PZ9kpF001q U+9wOz4d8V7233+zyWxMq+vTXdY2/DJSHEFgfY6dI3FfYpRV7lge1DjpI SyKKZMYkMusHINkut+WbWN5TulLsik6HFAR5uAXDaDDeokzdUlPj9qF72 w==; X-CSE-ConnectionGUID: ZiY18YfSSDyl23vSOAHqzQ== X-CSE-MsgGUID: ZnJ/uVN7TWu8vT586PdIeA== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429625" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429625" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:56 -0800 X-CSE-ConnectionGUID: qyDTE+XTSEO+27ziRCwcPg== X-CSE-MsgGUID: yJ8iFOn+TNeDp+JGkAwToA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848131" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:55 -0800 From: Chao Gao To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Bjorn Helgaas , Kiryl Shutsemau , Dave Hansen Subject: [RFC PATCH 5/7] coco/tdx-host: Configure an IDE stream Date: Mon, 16 Nov 2026 03:10:23 -0800 Message-ID: <20261116111037.3478844-6-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Establishing a PCIe Integrity and Data Encryption (IDE) stream has two parts. The stream is first provisioned in the config space of both Partner Ports (the root port and the device), and the keys are then programmed via IDE Key Management (IDE_KM). Commit 1e4d2ff3ae45 ("PCI/IDE: Add IDE establishment helpers") added the pci_ide_stream_*() helpers for provisioning. They split it into fine-grained allocate, register and setup steps to accommodate differences between SEV-TIO and TDX Connect, such as who programs the root port and who allocates the stream ID. Provision the stream with these helpers. IDE_KM and enabling the stream are left to later changes. The TDX module owns the root port's IDE registers and provides TDH.IDE.STREAM.CREATE for the host to program them. Configure the root port with the SEAMCALL, passing the register values as parameters, and write only the device's IDE registers from the host. An IDE stream can be associated with address ranges, so that traffic to different ranges, such as those of different devices, goes through different streams with different keys. A stream can be associated with multiple ranges, but TDX supports only one. Keep the prefetchable range and drop the non-prefetchable one. Export pci_ide_stream_to_regs() to generate the root port's register values from the adjusted settings. TDH.IDE.STREAM.CREATE also returns the stream ID that the TDX module assigns. Configure the device with the same ID. Based on work by Yilun. Signed-off-by: Chao Gao --- drivers/pci/ide.c | 5 +- drivers/virt/coco/tdx-host/main.c | 147 ++++++++++++++++++++++++++++++ include/linux/pci-ide.h | 2 + 3 files changed, 152 insertions(+), 2 deletions(-) diff --git a/drivers/pci/ide.c b/drivers/pci/ide.c index beb67b8fb5c5..aced5ef923a9 100644 --- a/drivers/pci/ide.c +++ b/drivers/pci/ide.c @@ -550,8 +550,8 @@ static void mem_assoc_to_regs(struct pci_bus_region *re= gion, * @ide: registered IDE settings descriptor * @regs: output register values */ -static void pci_ide_stream_to_regs(struct pci_dev *pdev, struct pci_ide *i= de, - struct pci_ide_regs *regs) +void pci_ide_stream_to_regs(struct pci_dev *pdev, struct pci_ide *ide, + struct pci_ide_regs *regs) { struct pci_ide_partner *settings =3D pci_ide_to_settings(pdev, ide); int assoc_idx =3D 0; @@ -580,6 +580,7 @@ static void pci_ide_stream_to_regs(struct pci_dev *pdev= , struct pci_ide *ide, =20 regs->nr_addr =3D assoc_idx; } +EXPORT_SYMBOL_GPL(pci_ide_stream_to_regs); =20 /** * pci_ide_stream_setup() - program settings to Selective IDE Stream regis= ters diff --git a/drivers/virt/coco/tdx-host/main.c b/drivers/virt/coco/tdx-host= /main.c index da56178eac2e..63209a712c28 100644 --- a/drivers/virt/coco/tdx-host/main.c +++ b/drivers/virt/coco/tdx-host/main.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include =20 @@ -69,6 +70,10 @@ struct tdx_tsm_link { void *spdm_mt; unsigned int dev_info_nr_pages; void *dev_info; + + struct pci_ide *ide; + struct page *stream_mt; + unsigned int stream_id; }; =20 static struct tdx_tsm_link *to_tdx_tsm_link(struct pci_tsm *tsm) @@ -322,6 +327,140 @@ static void tdx_spdm_session_teardown(struct tdx_tsm_= link *tlink) tdx_spdm_delete(tlink); } =20 +static void sel_stream_block_regs(struct pci_dev *pdev, struct pci_ide *id= e, + struct pci_ide_regs *regs) +{ + struct pci_dev *rp =3D pcie_find_root_port(pdev); + struct pci_ide_partner *setting =3D pci_ide_to_settings(rp, ide); + + /* only support address association for prefetchable memory */ + setting->mem_assoc =3D (struct pci_bus_region) { 0, -1 }; + pci_ide_stream_to_regs(rp, ide, regs); +} + +#define STREAM_INFO_RP_DEVFN GENMASK_ULL(7, 0) +#define STREAM_INFO_TYPE BIT_ULL(8) +#define STREAM_INFO_TYPE_LINK 0 +#define STREAM_INFO_TYPE_SEL 1 + +static int tdx_ide_stream_create(struct tdx_tsm_link *tlink, + struct pci_ide *ide) +{ + u64 stream_info, stream_ctrl, stream_id; + struct pci_dev *pdev =3D tlink->pci.base_tsm.pdev; + struct pci_dev *rp =3D pcie_find_root_port(pdev); + struct pci_ide_regs regs; + struct page *stream_mt; + u64 sret; + int ret; + + stream_mt =3D alloc_page(GFP_KERNEL | __GFP_ZERO); + if (!stream_mt) + return -ENOMEM; + + stream_info =3D FIELD_PREP(STREAM_INFO_RP_DEVFN, rp->devfn); + stream_info |=3D FIELD_PREP(STREAM_INFO_TYPE, STREAM_INFO_TYPE_SEL); + /* Keep optional stream features disabled for now. */ + stream_ctrl =3D 0; + + sel_stream_block_regs(pdev, ide, ®s); + if (regs.nr_addr !=3D 1) { + ret =3D -EFAULT; + goto out_free_stream_mt; + } + + sret =3D tdh_ide_stream_create(stream_info, tlink->spdm_id, + stream_mt, stream_ctrl, + regs.rid1, regs.rid2, regs.addr[0].assoc1, + regs.addr[0].assoc2, regs.addr[0].assoc3, + &stream_id); + if (sret) { + ret =3D -EIO; + goto out_free_stream_mt; + } + + tlink->stream_id =3D stream_id; + tlink->stream_mt =3D stream_mt; + + return 0; + +out_free_stream_mt: + __free_page(stream_mt); + + return ret; +} + +static void tdx_ide_stream_delete(struct tdx_tsm_link *tlink) +{ + struct pci_dev *pdev =3D tlink->pci.base_tsm.pdev; + u64 sret; + + sret =3D tdh_ide_stream_block(tlink->spdm_id, tlink->stream_id); + if (sret) { + /* leak the metadata pages */ + pci_err(pdev, "ide stream block fail 0x%llx\n", sret); + return; + } + + sret =3D tdh_ide_stream_delete(tlink->spdm_id, tlink->stream_id); + if (sret) { + pci_err(pdev, "ide stream delete fail 0x%llx\n", sret); + return; + } + + __free_page(tlink->stream_mt); +} + +static int tdx_ide_stream_setup(struct tdx_tsm_link *tlink) +{ + struct pci_dev *pdev =3D tlink->pci.base_tsm.pdev; + struct pci_ide *ide; + int ret; + + ide =3D pci_ide_stream_alloc(pdev); + if (!ide) + return -ENOMEM; + + /* Configure IDE capability for RP & get stream_id */ + ret =3D tdx_ide_stream_create(tlink, ide); + if (ret) + goto out_pci_ide_stream_free; + + ide->stream_id =3D tlink->stream_id; + ret =3D pci_ide_stream_register(ide); + if (ret) + goto out_tdx_ide_stream_delete; + + /* + * Configure stream settings for the device. TDISP requires one + * stream to be the default stream, and the PCI core does not set + * one, so make the only stream the default. + */ + ide->partner[PCI_IDE_EP].default_stream =3D 1; + pci_ide_stream_setup(pdev, ide); + + tlink->ide =3D ide; + + return 0; + +out_tdx_ide_stream_delete: + tdx_ide_stream_delete(tlink); +out_pci_ide_stream_free: + pci_ide_stream_free(ide); + + return ret; +} + +static void tdx_ide_stream_teardown(struct tdx_tsm_link *tlink) +{ + struct pci_ide *ide =3D tlink->ide; + + pci_ide_stream_teardown(ide->pdev, ide); + pci_ide_stream_unregister(ide); + tdx_ide_stream_delete(tlink); + pci_ide_stream_free(ide); +} + static int tdx_tsm_link_connect(struct pci_dev *pdev) { struct tdx_tsm_link *tlink =3D to_tdx_tsm_link(pdev->tsm); @@ -334,8 +473,15 @@ static int tdx_tsm_link_connect(struct pci_dev *pdev) ret =3D tdx_spdm_session_setup(tlink); if (ret) goto out_iommu_put; + + ret =3D tdx_ide_stream_setup(tlink); + if (ret) + goto out_spdm_teardown; + return 0; =20 +out_spdm_teardown: + tdx_spdm_session_teardown(tlink); out_iommu_put: tdx_iommu_put(pdev); return ret; @@ -345,6 +491,7 @@ static void tdx_tsm_link_disconnect(struct pci_dev *pde= v) { struct tdx_tsm_link *tlink =3D to_tdx_tsm_link(pdev->tsm); =20 + tdx_ide_stream_teardown(tlink); tdx_spdm_session_teardown(tlink); tdx_iommu_put(pdev); } diff --git a/include/linux/pci-ide.h b/include/linux/pci-ide.h index ae07d9f699c0..f8074865d2cd 100644 --- a/include/linux/pci-ide.h +++ b/include/linux/pci-ide.h @@ -104,6 +104,8 @@ struct pci_ide { void pci_ide_set_nr_streams(struct pci_host_bridge *hb, u16 nr); struct pci_ide_partner *pci_ide_to_settings(struct pci_dev *pdev, struct pci_ide *ide); +void pci_ide_stream_to_regs(struct pci_dev *pdev, struct pci_ide *ide, + struct pci_ide_regs *regs); struct pci_ide *pci_ide_stream_alloc(struct pci_dev *pdev); void pci_ide_stream_free(struct pci_ide *ide); int pci_ide_stream_register(struct pci_ide *ide); --=20 2.52.0 From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827397; b=eC6ncxQ8MmbBi23cGSYlrAAQ2wGS8PNoodRm74++sQbFapLDgAiVhZZx2x0IWh7LW/Qb 2SOCKPYJD+rWc7IaF8NDaVkct/Di+UzsO+F78yGjK1Ay+4lPIEPcEN5MWM0wncxFLYxAQ lbhDmUv9qQuBJjl3gNZ1bb+0BYKg0wlMUJF6fAJyATTal2zdDcnWANxkdZ1upzbYp4KY1 ys0p56OVbtLYPliJIf7yVt06SGqPYhCNg4JqHRp+A+Rym4gFXCAN1eccG1e2w5ZMPCWel vHIzK1Ex8N7Mpl4yMagfZpUxoSMq64DBy1PltsTf7JYdLYsxRMu9Uq56xh4ZlR4xx+A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827397; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=0hCtBUAYJKReef9NOWa2Bacr9JNdBEvcySxmI8OhtpE=; b=VdWIyG4aTkdFNZCmchDaU5pYyQkcfNdqrdgzDuEyMvZG1YtNOEk9XiJW0zFCU66ibd9a xI87R4OsDY7AY/hKFsrGHtg3TM4x8pQbgUsLU6xiyUH4rTmHaxugAZdPyCxSRMSKksJ1R Qen8NPUixhmn/uZfTr7VVfPP5DBxavWT9VcFSyoym4If73qZkQt4Ofhu4PGayCSKfIyms HH80IKhfn3ZPg5YXfTthveTMJ6aqPxs2WwoLKgHELYpFTGdYXRPgLqcfBsMZO2hg0lIme PnNeHe4ABhO3/HnyaBH5ae1rRTXX35IKpMwL0GZGM9hFaKCgvPLBcA/rDofiSzSH/3A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RDclvfoj; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF53607D233; Mon, 16 Nov 2026 11:09:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8BF53607D233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RDclvfoj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827397; x=1826363397; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OVIxJIE/I5SIUnCjJ5JkStY9lwhM2SXS9zZd3XbxvyA=; b=RDclvfojM1Evh4/y6coErW7xo/F/KwD6WOdXkwJbKKXKkK1ldMnDvqjL 6p7y2ygxlQMVkbRae26RIpjuvdvF93X79Kvk1wJDY9NaUx5n0XX3Egp9b E7NcZeGCx4mG0dc+pZLC/mug4+S6zxHmT96EfE4lYPMPHA4hDHGUJy+ht +cpXlNCaLie9dFeSklioUoCW6jPrRtQwt9oUYGdXoxjs+7v2MTlkzX7gC Ki7tAEDLOhtzGAi5pCEq7LEneW2uRg/wKF2Gnzjw1o68ySYsc4d603NCL 0LJYWZkrRw54DT8Gr7ZCgeuyQ3S1riEGSwTFanGFcs/i6rAuQOKpvIbOG g==; X-CSE-ConnectionGUID: nbU7P/TlTm2nSUuHtYxiEA== X-CSE-MsgGUID: 7hLwnl51R/6X4qlXGhtUyQ== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429628" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429628" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:57 -0800 X-CSE-ConnectionGUID: nriNDE8OQpeJ1fY3idGMMw== X-CSE-MsgGUID: bC8d151OS9aiAFX1v1ZT4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848134" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:56 -0800 From: Chao Gao To: x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Kiryl Shutsemau , Dave Hansen Subject: [RFC PATCH 6/7] coco/tdx-host: Program IDE keys and enable the IDE stream Date: Mon, 16 Nov 2026 03:10:24 -0800 Message-ID: <20261116111037.3478844-7-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With the IDE stream provisioned on root ports and the device, the stream keys are next programmed via IDE_KM, and then the stream is enabled. The trusted firmware (TSM) programs the keys into the root port, and sends them to the device as IDE_KM messages over the SPDM session. On TDX, TDH.IDE.STREAM.KM does both, and also enables the stream on the root port. Like TDH.SPDM.CONNECT, it returns to the host whenever it has an IDE_KM message for the device. Call it in the same loop that relays the messages through the DOE mailbox. Unlike TDH.SPDM.CONNECT, TDH.IDE.STREAM.KM is not subject to the TDX module's concurrency limit, so don't serialize it with the mutex. After the stream gets enabled on the root port, enable the stream on the device from the host. Teardown reverses these steps. Based on work by Yilun. Signed-off-by: Chao Gao --- drivers/virt/coco/tdx-host/main.c | 48 +++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/drivers/virt/coco/tdx-host/main.c b/drivers/virt/coco/tdx-host= /main.c index 63209a712c28..040ceea45f8d 100644 --- a/drivers/virt/coco/tdx-host/main.c +++ b/drivers/virt/coco/tdx-host/main.c @@ -327,6 +327,37 @@ static void tdx_spdm_session_teardown(struct tdx_tsm_l= ink *tlink) tdx_spdm_delete(tlink); } =20 +enum tdx_ide_stream_km_op { + TDX_IDE_STREAM_KM_SETUP =3D 0, + TDX_IDE_STREAM_KM_STOP =3D 2, +}; + +static int tdx_ide_stream_km(struct tdx_tsm_link *tlink, + enum tdx_ide_stream_km_op op) +{ + u64 sret, out_msg_sz; + int ret; + + do { + sret =3D tdh_ide_stream_km(tlink->spdm_id, tlink->stream_id, op, + tlink->in_msg, tlink->out_msg, + &out_msg_sz); + ret =3D tdx_spdm_xfer_handler(tlink, sret, out_msg_sz); + } while (ret =3D=3D -EAGAIN); + + return ret; +} + +static int tdx_ide_stream_key_program(struct tdx_tsm_link *tlink) +{ + return tdx_ide_stream_km(tlink, TDX_IDE_STREAM_KM_SETUP); +} + +static void tdx_ide_stream_key_stop(struct tdx_tsm_link *tlink) +{ + tdx_ide_stream_km(tlink, TDX_IDE_STREAM_KM_STOP); +} + static void sel_stream_block_regs(struct pci_dev *pdev, struct pci_ide *id= e, struct pci_ide_regs *regs) { @@ -439,10 +470,25 @@ static int tdx_ide_stream_setup(struct tdx_tsm_link *= tlink) ide->partner[PCI_IDE_EP].default_stream =3D 1; pci_ide_stream_setup(pdev, ide); =20 + /* Key Programming for RP & target device, enable IDE stream for RP */ + ret =3D tdx_ide_stream_key_program(tlink); + if (ret) + goto out_pci_ide_stream_teardown; + + /* Enable IDE stream for target device */ + ret =3D pci_ide_stream_enable(pdev, ide); + if (ret) + goto out_tdx_ide_stream_key_stop; + tlink->ide =3D ide; =20 return 0; =20 +out_tdx_ide_stream_key_stop: + tdx_ide_stream_key_stop(tlink); +out_pci_ide_stream_teardown: + pci_ide_stream_teardown(pdev, ide); + pci_ide_stream_unregister(ide); out_tdx_ide_stream_delete: tdx_ide_stream_delete(tlink); out_pci_ide_stream_free: @@ -455,6 +501,8 @@ static void tdx_ide_stream_teardown(struct tdx_tsm_link= *tlink) { struct pci_ide *ide =3D tlink->ide; =20 + pci_ide_stream_disable(ide->pdev, ide); + tdx_ide_stream_key_stop(tlink); pci_ide_stream_teardown(ide->pdev, ide); pci_ide_stream_unregister(ide); tdx_ide_stream_delete(tlink); --=20 2.52.0 From nobody Tue Nov 17 11:09:44 2026 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827397; b=4h79SUOGcYf7pjeC7XzB1g5bVR8jYR4CGQUkdQj0dvr0sAOzkyBCqkqTrDGlllc6cyEs gozuScq4p9R407/1oFMjMU7Aer3ZCG2BGMCLZT++bzmwDyNTK5KLq1IWiXKPGeFNqG9pN eg+b8aD2JM2agP+xuoLDOAIFnZuqpQXZYPxWonP1D7Oepv39q3dGPrNrhKBUA5vJmixso i4KwuKyM7QgRLKzKUPqHUTpdvGfsdaRaBG8n/cqJD2MMiSCvQr07nR+trUhltzzzTxvU4 Y7UqDxBg86INa3he+Bl3L56znUqXZlFEnk796fAEnieBe8Xb3B/Wv6XC3S8VgOBWN+A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827397; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=uQiaosrZq/6cfVUoy8hqdiQwradIgh/yOR1oHMgTR+I=; b=idFEczwDn+T4BlOSs7TJweADMwH6rNnhRb8I27EJuBH1Qw0L2XtihE/FSlGNm8whyoXl c0Eci/rV7uHDgNEVb4djsn/l7rokNi9C92PKIuErALWHWV8PWKdnNNBmxo3vAxgKxTMq1 DJciXop4Itut54drxsQjtu4v9Iy8OZAV58Y+0OkYWO9ENz05gcc0aVT3iQRsFZ+UogMZ4 12vK3uvQUnJ8LwgZwr+jTlVrzlAgVeKXYuZxI450Ju6hlMN7eGKD6vFFdJXtIjoj5WPu6 lVWc8h7p9K0h4V6rOlQCi0dJzGRk0YTmug/pmgSLEWvp4BUMNlVtI+te96tDK6BjKcg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=a3fthGMX; arc=none smtp.remote-ip=198.175.65.12 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73477606FD88; Mon, 16 Nov 2026 11:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 73477606FD88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=a3fthGMX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794827398; x=1826363398; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WhpSgKz06/UoA0SUzG7bcB2Js0yT2iQrvfmwQ8dZ9ws=; b=a3fthGMXBAqMBRKWAAu1xrCgIt3OUQUMagQQbGHdoZCMRUTtuz3DCBId WrKan/asDNOumU6mCqgJyzisZAtg67BIHeVSgj09qrgyf7z6t+VqJbZkK YZajq9F813QKmC+CQnSIWeuVecXyMNgIYoBcxkKl0B85geaRNdPo9SBNR jj7iokmODp6yh8nytlDkAYKbS5eOrxNV2wNn9OKdSo9DeFQKzB0JlrqWP hBaVw7aCVufYxb/Fw6vna12+pCnHZ34xyAM90ktKovYJh7Kis2l1YK99l Fx4XMxr8QCOpxhSShFbHtxUabZsYZ7zizuORykNENQ4n4MMvrhgDlTSlm A==; X-CSE-ConnectionGUID: AHrnMMwiS3OeNFn1iUvklA== X-CSE-MsgGUID: NVbwIDhiTbC+SPYDcuxUrg== X-IronPort-AV: E=McAfee;i="6800,10657,11967"; a="3429632" X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="3429632" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:57 -0800 X-CSE-ConnectionGUID: Mb1/qUX8TCimH2SqS0E8xw== X-CSE-MsgGUID: wKuz7SU7S6aEXHOAGtX76g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,216,1787036400"; d="scan'208";a="9848138" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2026 03:09:57 -0800 From: Chao Gao To: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org Cc: rick.p.edgecombe@intel.com, kevin.tian@intel.com, yilun.xu@intel.com, chao.p.peng@intel.com, baolu.lu@linux.intel.com, chao.gao@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau Subject: [RFC PATCH 7/7] x86/virt/tdx: Enable PCIe link encryption Date: Mon, 16 Nov 2026 03:10:25 -0800 Message-ID: <20261116111037.3478844-8-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261116111037.3478844-1-chao.gao@intel.com> References: <20261116111037.3478844-1-chao.gao@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The basic SPDM session and IDE functionalities are all implemented, configure the TDX Module to enable the TDISP feature and in turn enable PCIe link encryption. Based on work by Yilun. Signed-off-by: Chao Gao --- arch/x86/include/asm/tdx.h | 2 +- arch/x86/virt/vmx/tdx/tdx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h index add83e7b9c36..c051f2ae82e6 100644 --- a/arch/x86/include/asm/tdx.h +++ b/arch/x86/include/asm/tdx.h @@ -147,7 +147,7 @@ static inline bool tdx_supports_tdisp(const struct tdx_= sys_info *sysinfo) if (!(sysinfo->features.tdx_features0 & TDX_FEATURES0_TDXCONNECT)) return false; =20 - return false; /* To be enabled when kernel is ready */ + return true; } =20 int tdx_guest_keyid_alloc(void); diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index d661de8230cf..9e87484283b8 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -1043,7 +1043,7 @@ struct tdmr_info_pa_array { }; =20 /* List all kernel-supported add-on features0 bits here */ -#define TDX_KERNEL_SUPPORTED_ADDON_FEATURES0 (0) +#define TDX_KERNEL_SUPPORTED_ADDON_FEATURES0 (TDX_FEATURES0_TDXCONNECT) =20 static __init u64 get_tdx_usable_addon_features0(void) { --=20 2.52.0