From nobody Thu Sep 24 20:03:24 2026 Received: from mail-pz2-f43.google.com (mail-pz2-f43.google.com [74.125.228.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20DB848124E for ; Thu, 24 Sep 2026 14:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790261045; cv=none; b=hdOsmwVgDJHr/ZViEFpv+HxEMR2ABKEQVOu7RSRjiulLkmC1CbUbr9kIStDYwpqCisLa5E4fcq453piXCO9YDFr2MS6p4KQx+RvhSPigyIH1VacY/3iwGCqtOfqE33vyUkGcLas6FPpZgJDjU+/IcRKieaLfZCbc6xk8CqsFyVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790261045; c=relaxed/simple; bh=sLJrYImmpj7cDJOuqV/tBWAPnB7FJaQ0Atb+mCiWXi0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VvoL0Mh8FBpH8rkUXg4KTI1pkDkPo0cCpUYOsW20BKcbCD1cOhs/Jlue41zGefJtjP10uC5Wv2jbtTIA/omViP12WQxFXQJWnrIw72VtKJx2NO6fPfL2yeSnZQiq/whtucU2Yn2xNtT0I0S3Yp53uax/rB5k060iYXN7cQc9Aq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WRTmxSRw; arc=none smtp.client-ip=74.125.228.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WRTmxSRw" Received: by mail-pz2-f43.google.com with SMTP id 41be03b00d2f7-cc4c3304833so985653a12.3 for ; Thu, 24 Sep 2026 07:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790261043; x=1790865843; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=BDZWmJgca/oRmUPYb8QTvKV4Z0J2CBYz2565yw2xf3w=; b=WRTmxSRwis/UanTHeTpTr3J+xKDuEswXPLqM85GQUpLA/nrg53JCYR29/+Rq85XDsh GfeQlM4/pYrOn8QYFuDdi3iu0UTvYYr89E+ZAOo0fX1HEs82+VZrRcEyBNU1wnnz15K+ 0NC/hz5ICDbY1phbxfEyx/1K2pSUiI3prBXr/+y56ywh82o3hYrtMznrSol+vFdjpyLs Cmc4GUgBeTxJ24sT1H5cqdiLfQ0/VA1UHy+rXbSLJfFuQ/+rQXjnOETlrIF7Z+pmkSIs q3B2bfKa0BajiMbDL10nb4jaHYXFJMM3uZu1qBDBD30JEy4Z+i1d7vHwUP1t4B+vyNw4 ZQjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790261043; x=1790865843; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BDZWmJgca/oRmUPYb8QTvKV4Z0J2CBYz2565yw2xf3w=; b=eFeojI7HvgL+h7nCX8ICGeO7YiHf+TBGdV3iNvn6fqRxxE1xx/ivZhSzcZCq35Q8dN VWFseB3/+zT/GoCUMhUlGJ7E2iBgOVwUkKhTt/3ibQmXpSVLJOu0JaUJBWfFNzKJU8Q2 S69B4KI723e7iCplOoXHWMJ3rfoAA3a6SL4qpKBDifAXz3FOewvvOguh77ByPVQBd58P U1e3y8/GAsorF6J4UeRR64QLEnBiiepjJfksp/8j9wFED1Z7zMXG0+Aie/99R2CCLNhP c3WUeidWEJzGnq8rQQmjTt/KSTHkBvxs3nEv0Y6gIdmwPq4Szza5XDQfOqluHBOftghN 6+Ew== X-Forwarded-Encrypted: i=1; AKwUvBzxumOOKk6lRYr3hfLiCl2kCN7H3UYFvkFQZjJgnE0Vgj8NDpzKJQSxLk7hLhLLH7E+DmrkA56arLl92a4=@vger.kernel.org X-Gm-Message-State: AFuF++kwaTjqXYQDP2QMRsQRv66ui03JOisfIo8ni/IrBMzIEfyKLQQw KljYYG5EJBRlhzNEu/L42FNrAWhJL8+mWwFxgudT53tB2Plmw4m/GtiK X-Gm-Gg: AYBFou0sa0aZy5FXKjg/JkIINuPHGCJ0bdKp08qXwmFUKQAVIxRRKbDtPbuEEqgUNRq e2cMcEuR2UyL4YUqUWqBrsFWoh0OMX64Q948HJQ9NcQEK+c87Zs+bo/u+Qh1QhvBOh8NBFydmA/ 8eKw6xaZL1zEN0oyyaEvbNEqGZT9VGnW0yT4GilF1HoAE5Tld0nY1i7QvLidZGx9+NKOfqG+syb XlH+uyMfGWpEpF2o+9wdcySRr9ZEbdTZn0v8YyjiBJ1iyDKj2FXk9c0JQ+w2HmcF5vStsvxdOb8 nHsJaWgS2xWP7pxRuW19gdWxlcPJVge9gYT/MkM05gO1mxXAU4bnLdI2alNfk4wcrtXoUIdY7VW cEr/cIxLr0jgCKcduUrPpO3W1Uifpqkh3S4YzJH8S0Xl/JSPSb6P312ZWjtXZ4TX/WSTe3XCrwp MEXFYZppTaVqYgg+qeWoru9PK0O5YNK1Tb5kFi7T7ifqhfCLDnrDfVwLxvIWauNQ== X-Received: by 2002:a05:6a20:9149:b0:3d3:ae40:51e7 with SMTP id adf61e73a8af0-3de0e762e07mr2709521637.27.1790261043213; Thu, 24 Sep 2026 07:44:03 -0700 (PDT) Received: from lgs.. ([47.82.103.134]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc75f3f2d0esm2982721a12.22.2026.09.24.07.43.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 07:44:02 -0700 (PDT) From: Guangshuo Li To: Linus Walleij , Lee Jones , Mattias Wallin , Ludovic Barre , Samuel Ortiz , Julien Delacou , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, mfd@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] mfd: ab8500: fix child device leaks on probe failure Date: Thu, 24 Sep 2026 22:43:55 +0800 Message-ID: <20260924144355.1604369-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ab8500_probe() registers MFD child devices before completing the remaining device initialization. If a later MFD registration or sysfs group creation fails, previously registered child devices are not removed. Use devm_mfd_add_devices() so registered MFD child devices are removed when probe fails. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: cca69b67b3ba ("mfd: Export ab8500 chip id to sysfs") Fixes: 9c717cf3fa16 ("mfd: ab8500-core: Add device for new RTC version for = AB8540 cut2") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - Use devm_mfd_add_devices() for all MFD child registrations, as suggested by Lee Jones. drivers/mfd/ab8500-core.c | 44 ++++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index f0bc0b5a6f4a..55dd9ad285ae 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -1194,39 +1194,41 @@ static int ab8500_probe(struct platform_device *pde= v) return ret; =20 if (is_ab9540(ab8500)) - ret =3D mfd_add_devices(ab8500->dev, 0, ab9540_devs, - ARRAY_SIZE(ab9540_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, ab9540_devs, + ARRAY_SIZE(ab9540_devs), NULL, + 0, ab8500->domain); else if (is_ab8540(ab8500)) { - ret =3D mfd_add_devices(ab8500->dev, 0, ab8540_devs, - ARRAY_SIZE(ab8540_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, ab8540_devs, + ARRAY_SIZE(ab8540_devs), NULL, + 0, ab8500->domain); if (ret) return ret; =20 if (is_ab8540_1p2_or_earlier(ab8500)) - ret =3D mfd_add_devices(ab8500->dev, 0, ab8540_cut1_devs, - ARRAY_SIZE(ab8540_cut1_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, + ab8540_cut1_devs, + ARRAY_SIZE(ab8540_cut1_devs), + NULL, 0, ab8500->domain); else /* ab8540 >=3D cut2 */ - ret =3D mfd_add_devices(ab8500->dev, 0, ab8540_cut2_devs, - ARRAY_SIZE(ab8540_cut2_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, + ab8540_cut2_devs, + ARRAY_SIZE(ab8540_cut2_devs), + NULL, 0, ab8500->domain); } else if (is_ab8505(ab8500)) - ret =3D mfd_add_devices(ab8500->dev, 0, ab8505_devs, - ARRAY_SIZE(ab8505_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, ab8505_devs, + ARRAY_SIZE(ab8505_devs), NULL, + 0, ab8500->domain); else - ret =3D mfd_add_devices(ab8500->dev, 0, ab8500_devs, - ARRAY_SIZE(ab8500_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, ab8500_devs, + ARRAY_SIZE(ab8500_devs), NULL, + 0, ab8500->domain); if (ret) return ret; =20 /* Add battery management devices */ - ret =3D mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs, - ARRAY_SIZE(ab8500_bm_devs), NULL, - 0, ab8500->domain); + ret =3D devm_mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs, + ARRAY_SIZE(ab8500_bm_devs), NULL, + 0, ab8500->domain); if (ret) dev_err(ab8500->dev, "error adding bm devices\n"); =20 --=20 2.43.0