From nobody Thu Sep 24 12:53:42 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BC114749FC; Thu, 24 Sep 2026 11:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790247986; cv=none; b=XdDdAaveZ+cryZPOuCGKhA6WncSTDtqjo1TLUASCWtZRn+K4VpMFsJQELFo67+L826gIaea7UXzn3hXKAiBAQYAhiJwkIiX9bFQU6q4nUarq/5OLryYkMI1fKX6/WO/gFWNu34kS894FTBKe5rS8oXmWXbmLUiyMkZpZEp0ZUo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790247986; c=relaxed/simple; bh=5gW3H/1yVOxL00jh4JY44hYMcfiOVXML9SuZIS61MNk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jalExCKmMRVLijMU5+BAdwvFHMaFZ7afJx7Epx9opZSx+vxsKloeRjQKgkIM/+2UWW9SJkHf4DVV0fsnRvOu6IHW2khiSJl8rlMSsZpryVJ/iz2BaJpWCo2HR4j7stCJG1MSAOph+Vi3Ny6JyustqJ7oKK8hJQ1/ubUb/yTL5Rg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=FA5Gz0CO; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="FA5Gz0CO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=2C SflERWiIEUtHIYwYt7AZ8Vjsf1CeCsPdvuomIllHU=; b=FA5Gz0COAgBSrDFqeE mx557yHlDT1xWLSeptLBqgN/xZFdKtdpGk1RluFFHFZsKcEWzyzz+iGxblajghdN WUw994pKSmYfNsrPNc9J6l/ObxUS6snYHSY5R1I9rTq4kWavMgI5XhHtoU4N4XUM VuetSygpUmpbKzp2FAVBfQYI8= Received: from pc.localdomain (unknown []) by gzga-smtp-mtada-g0-2 (Coremail) with SMTP id _____wD3N3wNBLVqE0AmAg--.64280S3; Thu, 24 Sep 2026 19:05:52 +0800 (CST) From: Jiale Yao To: Namjae Jeon , Sungjong Seo , Yuezhang Mo , Jan Kara , Hyunchul Lee , "Ritesh Harjani (IBM)" , "Darrick J. Wong" , exfat@lists.linux.dev, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs@lists.linux.dev Cc: Jiale Yao Subject: [PATCH 1/3] ext2: drain in-flight DIO before buffered write fallback Date: Thu, 24 Sep 2026 19:05:42 +0800 Message-Id: <20260924110544.601390-2-yaojiale02@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260924110544.601390-1-yaojiale02@163.com> References: <20260924110544.601390-1-yaojiale02@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3N3wNBLVqE0AmAg--.64280S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7tFyUuryxtFyDXr47tF1DJrb_yoW8Zrykpr Z093W5JryqyrZ7Wwn7Wa18ur1fK398ArW3XrWvv3WDCry5Gws0gF4ktr1jvF1fGFsrJw4Y qan29r97u3W0yaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pMOJYwUUUUU= X-CM-SenderInfo: x1dryxhdohiji6rwjhhfrp/xtbCzRENR2q1BBFIDgAA3a Content-Type: text/plain; charset="utf-8" An asynchronous direct write can remain in flight after the inode lock is released. If another direct write falls back to buffered I/O while the first write is still pending, generic_perform_write() can dirty pages before the first write completes its post-I/O page cache invalidation. The invalidation then finds dirty pages, reports a page cache invalidation failure, and records -EIO in the mapping error sequence. A later fsync() therefore returns -EIO. Commit 15cdefd0c0522f9d5e12d947fa04f4c11649b699 ("ext4: drain in-flight DIO before buffered write fallback") fixed the same race in ext4. Ext2 has an equivalent fallback after iomap_dio_rw() returns -ENOTBLK or a short write, but does not drain other in-flight DIO before dirtying the page cache. Wait for in-flight DIO before calling generic_perform_write() in the fallback path. A reproducer using concurrent AIO direct writes and buffered fallback triggered the following warning and made a subsequent fsync() return -EIO: Page cache invalidation failure on direct I/O. Possible data corruption due to collision with buffered I/O! Fixes: fb5de4358e1a ("ext2: Move direct-io to use iomap") Link: https://lore.kernel.org/r/20260629113827.4074335-3-libaokun@linux.ali= baba.com Signed-off-by: Jiale Yao --- fs/ext2/file.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/ext2/file.c b/fs/ext2/file.c index b9020df7d89e..67fe423c3828 100644 --- a/fs/ext2/file.c +++ b/fs/ext2/file.c @@ -135,6 +135,13 @@ static ssize_t ext2_dio_write_iter(struct kiocb *iocb,= struct iov_iter *from) int ret2; =20 iocb->ki_flags &=3D ~IOCB_DIRECT; + + /* + * Prevent concurrent direct I/O and buffered I/O to the same file + * range. Wait for in-flight DIO to finish before dirtying pages. + */ + inode_dio_wait(inode); + pos =3D iocb->ki_pos; status =3D generic_perform_write(iocb, from); if (unlikely(status < 0)) { --=20 2.34.1 From nobody Thu Sep 24 12:53:42 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA004756D8; Thu, 24 Sep 2026 11:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790247991; cv=none; b=KTmx/Io7ZgUkugNgXLwhVi7y3NKiZE5zac01SxuBOgEr+9TlfKBnzpn3wbDVSI3lXlNrI9/MQu+tqodaMi/TKRvB8du2T8puVB2RwPsiUChU/sTUIgbi+Ni9N1T9a9rn8kU1kdC+PPM6Qfg8t3CWhOlOotWHsKYW9+2XAruJXuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790247991; c=relaxed/simple; bh=udv3pN6JGLOROzjpDV16RH4kQg/3UFq0mNydJmYnm4g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uTJIjfTPFE4YsSmf3yeV4ufVSRzVVXwJgRTglB4lkqysZ8/TfiF+VjHXAqK9eu1EjX9Opr2pXlUWaxOxI3DVlK3R9qMsEL7PYmAXpfstq7JQ1OTH+tJedCWhvikIXxDwZAhJ0G1tgbgn7oG2y3HrMzsaHV7qurKRiW7fAXGVH6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=VaT7byJs; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="VaT7byJs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Au 27lUNj1GK7J3KD7BF4roguS87dAGZ5tWOs9x7uxlk=; b=VaT7byJsvGmBeMt92c b18gIjzE/i9nrOm4LZqh7sl+vPg/gnvwvmfhvlyH4KzLU3OCJ9Ao6uleMUBbqzs1 9eize13t2Rxi15IMg2S2ehl1GW0wJ+9HaETjJFg2xqCjOs7wuuVfSKzb21pzFimd nUogL29U1CjjYZopb3FGuDhOM= Received: from pc.localdomain (unknown []) by gzga-smtp-mtada-g0-2 (Coremail) with SMTP id _____wD3N3wNBLVqE0AmAg--.64280S4; Thu, 24 Sep 2026 19:05:54 +0800 (CST) From: Jiale Yao To: Namjae Jeon , Sungjong Seo , Yuezhang Mo , Jan Kara , Hyunchul Lee , "Ritesh Harjani (IBM)" , "Darrick J. Wong" , exfat@lists.linux.dev, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs@lists.linux.dev Cc: Jiale Yao Subject: [PATCH 2/3] ntfs: drain in-flight DIO before buffered write fallback Date: Thu, 24 Sep 2026 19:05:43 +0800 Message-Id: <20260924110544.601390-3-yaojiale02@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260924110544.601390-1-yaojiale02@163.com> References: <20260924110544.601390-1-yaojiale02@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3N3wNBLVqE0AmAg--.64280S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF4kGFy5AFykKF47tr1rXrb_yoW8Zw1Upr ZIkFy5Gr9rtr4xXwn7CF4rW3WFkrZ8X3y3ZrWkWw1kCrW8Gw4vga18tF1jvryrJFZrJr42 qa109rWkZryUZaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zK9akLUUUUU= X-CM-SenderInfo: x1dryxhdohiji6rwjhhfrp/xtbC8BINR2q1BBJZFwAA3v Content-Type: text/plain; charset="utf-8" An asynchronous direct write can remain in flight after the inode lock is released. If another direct write falls back to buffered I/O while the first write is still pending, iomap_file_buffered_write() can dirty pages before the first write completes its post-I/O page cache invalidation. The invalidation then finds dirty pages, reports a page cache invalidation failure, and records -EIO in the mapping error sequence. A later fsync() therefore returns -EIO. Commit 15cdefd0c0522f9d5e12d947fa04f4c11649b699 ("ext4: drain in-flight DIO before buffered write fallback") fixed the same race in ext4. NTFS has an equivalent fallback after iomap_dio_rw() returns -ENOTBLK or a short write, but does not drain other in-flight DIO before dirtying the page cache. Wait for in-flight DIO before calling iomap_file_buffered_write() in the fallback path. A reproducer using concurrent AIO direct writes and buffered fallback triggered the following warning and made a subsequent fsync() return -EIO: Page cache invalidation failure on direct I/O. Possible data corruption due to collision with buffered I/O! Fixes: 9c87959601e8 ("ntfs: update file operations") Link: https://lore.kernel.org/r/20260629113827.4074335-3-libaokun@linux.ali= baba.com Signed-off-by: Jiale Yao --- fs/ntfs/file.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 007d1614b9ac..2fc2ffde3846 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c @@ -527,6 +527,13 @@ static ssize_t ntfs_dio_write_iter(struct kiocb *iocb,= struct iov_iter *from) =20 offset =3D iocb->ki_pos; iocb->ki_flags &=3D ~IOCB_DIRECT; + + /* + * Prevent concurrent direct I/O and buffered I/O to the same file + * range. Wait for in-flight DIO to finish before dirtying pages. + */ + inode_dio_wait(file_inode(iocb->ki_filp)); + written =3D iomap_file_buffered_write(iocb, from, &ntfs_write_iomap_ops, &ntfs_iomap_folio_ops, NULL); --=20 2.34.1 From nobody Thu Sep 24 12:53:42 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D85476CDC; Thu, 24 Sep 2026 11:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790247997; cv=none; b=T4kUdYtgkMJGpGalEFtnH6WeS5DJ8Q9KRKRM7UT2J+SqQbfUo3wQ7Y6Sk44Hsk8KXv5VpKx533bLw92S3Hr3P9hh+nEsyqXz32Q+YXxDqRkZW2RnhQ7woZm7o2SRpHqxeEIKOWOcZYq5zDLW8+l0cHXb2pu8tYwb8IwgyfmB7/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790247997; c=relaxed/simple; bh=VCOUBmSvA08OLSZZ0QUtRpBpXc4RIeX5lNww1zeNj+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tTZTER6ITCHLoRhsn2RuW7dNqAEcbMT8+BdUfPPNhY4LRGPHH/8RUwLvzGY8KTUUC+Czqvxu0+AZPXWycizqi3PsZAWBoAvu13SQHNQSoioi7ufeYyxx5WKh1rFXFEJ9/8VyjzRTWXZr7riQdPvZfd0vac47SOs/xOvmxHdB7j4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ZWKFbg3W; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ZWKFbg3W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Gb iQVEWtVb+Jbk8/U09Tj0Cxmmbe6xVeYJInM/aCluU=; b=ZWKFbg3WI+2uRabZyb xLrcHeF30uZ1HravdqT0LHmBtf7HH0omtCkWZq+EvQMIMYYUxgmjwiLZw3iFh48n I1ye0PvgRdVMyWGMKkHzHEgUlgVtH7oaZpXBNzW4eKMQIAVUvo4MbeAhI+xkjXz1 ry+pEQZ3r8jd+GvNWukxD4XxA= Received: from pc.localdomain (unknown []) by gzga-smtp-mtada-g0-2 (Coremail) with SMTP id _____wD3N3wNBLVqE0AmAg--.64280S5; Thu, 24 Sep 2026 19:05:56 +0800 (CST) From: Jiale Yao To: Namjae Jeon , Sungjong Seo , Yuezhang Mo , Jan Kara , Hyunchul Lee , "Ritesh Harjani (IBM)" , "Darrick J. Wong" , exfat@lists.linux.dev, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs@lists.linux.dev Cc: Jiale Yao Subject: [PATCH 3/3] exfat: drain in-flight DIO before buffered write fallback Date: Thu, 24 Sep 2026 19:05:44 +0800 Message-Id: <20260924110544.601390-4-yaojiale02@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260924110544.601390-1-yaojiale02@163.com> References: <20260924110544.601390-1-yaojiale02@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3N3wNBLVqE0AmAg--.64280S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF4kGFy5AFykKF47tr1rXrb_yoW8ZF43pr Z0ga45JryDt397XwnruF48W3WFk395A3y3ZrWvv3WDCrWUWr4vga1ktr1YvF43JanrGr4j qa109rykAr1DCaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRorW7UUUUU= X-CM-SenderInfo: x1dryxhdohiji6rwjhhfrp/xtbC8BQOSGq1BBRZSAAA38 Content-Type: text/plain; charset="utf-8" An asynchronous direct write can remain in flight after the inode lock is released. If another direct write falls back to buffered I/O while the first write is still pending, iomap_file_buffered_write() can dirty pages before the first write completes its post-I/O page cache invalidation. The invalidation then finds dirty pages, reports a page cache invalidation failure, and records -EIO in the mapping error sequence. A later fsync() therefore returns -EIO. Commit 15cdefd0c0522f9d5e12d947fa04f4c11649b699 ("ext4: drain in-flight DIO before buffered write fallback") fixed the same race in ext4. ExFAT has an equivalent fallback after iomap_dio_rw() returns -ENOTBLK or a short write, but does not drain other in-flight DIO before dirtying the page cache. Wait for in-flight DIO before calling iomap_file_buffered_write() in the fallback path. A reproducer using concurrent AIO direct writes and buffered fallback triggered the following warning and made a subsequent fsync() return -EIO: Page cache invalidation failure on direct I/O. Possible data corruption due to collision with buffered I/O! Fixes: 867b9c96dc83 ("exfat: add iomap direct I/O support") Link: https://lore.kernel.org/r/20260629113827.4074335-3-libaokun@linux.ali= baba.com Signed-off-by: Jiale Yao --- fs/exfat/file.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/exfat/file.c b/fs/exfat/file.c index a2a9ee1a2004..cf5ccbd54823 100644 --- a/fs/exfat/file.c +++ b/fs/exfat/file.c @@ -807,6 +807,12 @@ static ssize_t exfat_fallback_buffered_write(struct ki= ocb *iocb, =20 iocb->ki_flags &=3D ~IOCB_DIRECT; =20 + /* + * Prevent concurrent direct I/O and buffered I/O to the same file + * range. Wait for in-flight DIO to finish before dirtying pages. + */ + inode_dio_wait(file_inode(iocb->ki_filp)); + written =3D iomap_file_buffered_write(iocb, from, &exfat_write_iomap_ops, NULL, NULL); if (written < 0) --=20 2.34.1