From nobody Thu Sep 24 12:02:47 2026 Received: from mail-ej2-f43.google.com (mail-ej2-f43.google.com [74.125.228.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD30D3EDE63 for ; Thu, 24 Sep 2026 10:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790244037; cv=none; b=Epa0RcT54qAB7P2Nd9iz7k7UOVNW5fS0W3yg337/OhKyUYTwiIY5D199Lil91fj3I7QWdIebe1bYVxLZiKyQXCmKPPn5zWqSeUARpngG6af3ODSpV0tKqjRF8tQDtZ3gP0Dx4us4iUuFw2u2CdPzahCmVfYLRIMAy5eMpjkNzMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790244037; c=relaxed/simple; bh=nwaYkLbsXfKCJjGkeRjXJQ6s3GI3fNcy0etbBPov7F4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rPI3GtJ/oLfl1incwvHHztbSJt24mbG+dVKu+IHV2KdhDrthDRiPna4tAvrseG9EpiFHU3HSDQWWzThLlfRbz46rm+HSrBkQzKbsycXyKTryBTl5lEXlzOJ8k3E1rYLPWxM8xP55DMgNvzqsESASK1o0HkkwfVLlvCfa60hscic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nnV06heG; arc=none smtp.client-ip=74.125.228.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nnV06heG" Received: by mail-ej2-f43.google.com with SMTP id a640c23a62f3a-c2a4fbc5586so274305966b.2 for ; Thu, 24 Sep 2026 03:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790244029; x=1790848829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=U6oEIghWvcJ4GRb1a00MSWjde3NQ7RviSDO9ePyO6Z0=; b=nnV06heG/ot2k7wc4CyHxJ9gviveiXqs9gQ/UUcL4UdxKHteC2ZMTmLuCeyW+M1Vkw 5S+uVnCykbcKSUB+z26n6+gyh6w/cbnAYcAS+Qu1Tj0IHIlMZfzBbsGP/KZbim97QLBR ts7kxzl1hOJF8fqOP3q8mTpJ76qhIUUPWir754aSU5q22a/ozyAtFWhbiU0SDnhc44I3 NMVqcJjQH59KKVGiKKf0IhAm4eu1HSk774hnvWKhE0S2mSAUxprBiypADVZ661BpD6xb UKyqH8tXRmpFh29iailXQbcUExrCpNxe83iXyN7gitmHtIRXUfw98gnx+dBYo3XkiCVP FoYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790244029; x=1790848829; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U6oEIghWvcJ4GRb1a00MSWjde3NQ7RviSDO9ePyO6Z0=; b=T9jEQremAc0ZkZS222K5s7aYbT3mz3tV/LaJqthAd3EMfOliG7YGR9O7TnD0SVbny4 ZX8jp7FNf7hRjcejBkh0JQQQHBfmGPKvSkq+VW4V0oHeArJHs95T8vZd8O9n49a8I02v QCndOp2i0oioYE2QKHwsbXE9eZBjOS7H/+UP8N0Lm4IndiER+QnYEvg/reoqBLj4MpTQ j/qjgaIua88qA1UITxLVQwl6ce7XdocaxlGpXoim/CKHVseTNGZ6rJBbXomxIIbDwZ8i kTXQUcS2cBqSzIds8aorjokL1zTgz2+7p0IZ1vd2g4tRYGG/DquhOFuwyVU/L116HyE4 hRqA== X-Forwarded-Encrypted: i=1; AKwUvByprnihmn1C5Kc6I9+Hd4EXMB6Jzo69mqpatZ7A1RqxANJbzbsZ/ZPzag7CT7pmykzKNqq9DAER4whknSk=@vger.kernel.org X-Gm-Message-State: AFuF++nIHesx/ugCqNGdzQu992duQjC3Q+InVUTL65j7upMZmatRmmrI 1KVwAN3CRlfMAG8bbWEekK2fFLgQaxAmNi9a2zXg43rwSwHLQYUuUJmW X-Gm-Gg: AYBFou226yZLijs9qTElo/3JSNIuLNQyfPkfMROPOwnsRiK+gpcAF+7KVG9u2R4Anfh +K6fLG0qp2AKOoKj9jkKmhF8kTcwG93NLuPfZruNOCcBGqnYb5KRw80+3iTV/c8XGxNZKQwfXEn Z/M4VsIo4BzbSeVsR1Lmy79iqDMhM8tViH5/3iArsaxKDN/wQvvPQGoQa1g3uazfhoWmPaL5dzZ XpZq9qPJpvak4QXfmMvASX4LIkG4LpGrr86qDFVmhGTgqu+DTPydBYismYKcMUNBrai14fr6DeX F8SVydjc/CUC2CL7mvajBVtwiSNSpKs1JNAViHmCWBV6FYd6AePMPhQ45rMt9Mi7QnVgjRvOw3d n+fvuJm/JPmF0mlZf4+ypQslLShAA0/FN4iT1aoJdKKZMnKZw1qp05MY03R6vcm5FOXIywkfbte gmgT9scm3cKTNg44mrIOBraQIlyJEE1R9ErMpvARes67EWvs8BSfK0dSa+NoMNu0RxYOZDQRTfx OCYIQvkdDT7y8q4 X-Received: by 2002:a17:907:9407:b0:c29:f0ec:1c15 with SMTP id a640c23a62f3a-c2ac20ab89cmr165652766b.6.1790244029398; Thu, 24 Sep 2026 03:00:29 -0700 (PDT) Received: from localhost.localdomain ([94.240.182.136]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2aae6682d3sm260123766b.40.2026.09.24.03.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 03:00:28 -0700 (PDT) From: Svyatoslav Nikolenko To: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Svyatoslav Nikolenko , syzbot+ca1ef9e2e234b8d3599b@syzkaller.appspotmail.com, stable@vger.kernel.org, Aleksandr Loktionov Subject: [PATCH net v4] net: e1000: fix warning in iounmap on probe failure Date: Thu, 24 Sep 2026 12:59:55 +0300 Message-ID: <20260924095955.3471-1-nsvatoslav515@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When e1000_probe() fails, the shared error handling ladder attempts to iounmap() the hw->ce4100_gbe_mdio_base_virt pointer. If the hardware is not a CE4100, this pointer remains uninitialized (NULL). On architectures like x86, passing a NULL pointer to iounmap() triggers a WARN_ON_ONCE, which is fatal under panic_on_warn. Fix this by conditionally unmapping the CE4100 MDIO base only if the mac_type is e1000_ce4100, matching the exact logic used in e1000_remove(). The hw->hw_addr iounmap() remains unconditional since it is guaranteed to be valid for all error paths reaching the err_sw_init label. Reported-by: syzbot+ca1ef9e2e234b8d3599b@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Dca1ef9e2e234b8d3599b Fixes: 13acde8fffc0af ("e1000: Fix the CE4100 bus type for the MDIO/PHY reg= isters") Cc: stable@vger.kernel.org Reviewed-by: Aleksandr Loktionov Signed-off-by: Svyatoslav Nikolenko --- v4: - Actually include the code changes (v3 was sent un-staged by mistake) v3: - Switched from pointer null-checks to checking hw->mac_type =3D=3D e1000= _ce4100 - Removed redundant check for hw->hw_addr since it cannot be NULL here - Added missing Cc: stable tag and Closes tag v2: - Expanded commit message to answer reviewer questions (reproduction deta= ils) - Added appropriate Fixes tags - Added Reviewed-by tag from Aleksandr Loktionov drivers/net/ethernet/intel/e1000/e1000_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/et= hernet/intel/e1000/e1000_main.c index d7f5c6f16142..d7e279b739b8 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -1227,7 +1227,8 @@ static int e1000_probe(struct pci_dev *pdev, const st= ruct pci_device_id *ent) kfree(adapter->rx_ring); err_dma: err_sw_init: - iounmap(hw->ce4100_gbe_mdio_base_virt); + if (hw->ce4100_gbe_mdio_base_virt) + iounmap(hw->ce4100_gbe_mdio_base_virt); iounmap(hw->hw_addr); err_ioremap: disable_dev =3D !test_and_set_bit(__E1000_DISABLED, &adapter->flags); --=20 2.47.3