From nobody Thu Sep 24 12:53:21 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011028.outbound.protection.outlook.com [40.107.130.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F04C2349CD6; Thu, 24 Sep 2026 08:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790239023; cv=fail; b=B1nmOehBs9o7CGo8jZERe7O/rbBWaTnzm74fAu4LpDQvxaOw3SOdn3J2bS+QH42Cs5zcG64wmv9PoRm1FK2yi4VJt/jCfetObDIKAl4LSOrnzWOXbtyXyHBFco2u7Eym5DRtgt4W0N0Mxgy4Uq9nP+BDwqkBLxQLH3jCjAzZ9S8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790239023; c=relaxed/simple; bh=NZyu8SNsY93wtWBaQIwuHoZJfsei0FYnev3Jda6qMOo=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=ca+P0HB3CJ0gw+GVQJG3vWB7xFChS2ZVXewJcpT4+j4HB3EFbPI5s48uITJudGlnNaah7GK26cSdYqiyaqHNPoXQJ+VLnulqVAFeQa84XJmu9aL+GvO6OcdWy718BRGb0KGBO+Luumh0sFsKQrr8aFILKvGdyRnQoU5cepko2hk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=m45AY3lg; arc=fail smtp.client-ip=40.107.130.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="m45AY3lg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P15TEeEXA1hj3kZnjzdEWjCZHG4rzghpEVzTGY3mTVVbK2ONto1f6xtQT1pZhtbwsPQT7SM1NDv+v7MQSx7h0t025SHzbNsZTJUUvLiaS/WivyqPREiPoM33ZI3mSZUMXMTwzkwWKP9Tg6Fr6wSFlspisXwedZPYN+GXe4DM7sOP9BrRmCk0k1iias7C1g65dqMUqAVHLbV2mSQgkkq9BEIk3WyV4Jp5Aw73tsnAesmdva9RGZ0KKMX5hGLvsQF3eZ0mmg3mPtPt8Nw5zlmATh7I72nmncUWxtVeva3slXBnFLgvkUM3P9+yieDmHsjjKMjA7/dgprAHVQHvjkh9UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02HH54Jxdo6SkdM8L/jhPn3pO4rb1Ubx2oZIP7unn84=; b=pkccV1BcriNNonGc4B1nAbEWYy3MTI664eBlr1WapgINgdDQLy9xL5ZVS6bgfRwtapKH/gnAVbJDvZfRSTnDi6rfTxkNm8l+ho87qymzLVf5xH1k+IdLi/OAoC2uEOZfQnPnaZC4gP9ujOdk/xrC62GbAzuXYNXryrbjY175lEfO87o7HloXZ3AVMY+J23fREymKgpuCg84WEVkevStK/eAsjKfx/DmJY39V3VsXbyirDzxejd/Ve4O1sdEcC/wCthd29MI3/1CL0nLA9HPghcfe9JJSUEVXVYCulG8kzsp0tT6uSGW3n0RJY7/1mzvwuYVHDHW5MnceyxvHIdCBhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02HH54Jxdo6SkdM8L/jhPn3pO4rb1Ubx2oZIP7unn84=; b=m45AY3lgi513c2+qOgFAtKZR+OEGdLyTQkKapt+KymeCW9SoEf3zzQjoO+dH/AwXZ2lvpA0wOVYrihgDVVbWRs1j/1Z7mlRxKEwVpjsrf0z3cI92b/bcIuUqnETp/TPNvNN75bUfeiPQBe7Unk6Z2lVeEpuLnv9SPUEHhAbNQGd+o70CTR1tNyN8BXMpIbBi2kMeCYjIkpkYRenUfTA70ynDdJlLQUjwnmQ0JCIcRuyugUG34aOvxaRLc0D43pJQQ2y4/6n2a7twrQqwTfB+M6XfyHm4GTR2s6dw/Ug19ls0979Dk7Wp2lIm+CNJ8fl5AuIXJUf1zlvBgEY+mDbQ8w== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM8PR04MB7874.eurprd04.prod.outlook.com (2603:10a6:20b:24d::9) by DU4PR04MB11339.eurprd04.prod.outlook.com (2603:10a6:10:5ef::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Thu, 24 Sep 2026 08:36:58 +0000 Received: from AM8PR04MB7874.eurprd04.prod.outlook.com ([fe80::ac38:1699:6f18:c5d9]) by AM8PR04MB7874.eurprd04.prod.outlook.com ([fe80::ac38:1699:6f18:c5d9%6]) with mapi id 15.21.0451.014; Thu, 24 Sep 2026 08:36:58 +0000 From: "Peng Fan (OSS)" To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, Peng Fan , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: [PATCH] PCI: dwc: imx6: use regmap_assign_bits() for conditional set/clear Date: Thu, 24 Sep 2026 16:34:28 +0800 Message-ID: <20260924083429.461746-1-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.51.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:1f7::9) To AM8PR04MB7874.eurprd04.prod.outlook.com (2603:10a6:20b:24d::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM8PR04MB7874:EE_|DU4PR04MB11339:EE_ X-MS-Office365-Filtering-Correlation-Id: 10ac0b56-9314-431e-8138-08df1a16ff5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|23010399003|19092799006|10067099003|56012099006|11063799006|18002099003|921020; X-Microsoft-Antispam-Message-Info: oMTBOJXNsjASu3xZMDVmBeaaNagxMk/ffsLOquNKgRlALGoaf/xXWMXiOzPYBHQ7BMXlLpzIEZsMgSLsmS2H5cEQC9mkqDmurqNg5AmMkO3/3IQiq/n/P/IHtCG0frjBhzNx6OCaiPUtH8huDnpI8IXyxFHm24aO0YRItBdgGAheLOffo9STO566qWBheF2MIBBasy3jiPzd6qjn7TQgtZrruXZe5i8sFzoTsSwHxX5xEJG7955MbOoHlW/FtXa6Uid6oji4QhYhe+OK3dG4No4kNBU4wX+xMF/PF9aoCNhIeC1JRG1h+i6CMoXCz91OK6weTp07Btb7xLG70zsRm3KAOUy7SuqtRK6PXN8OlB2Whr7bTB1xv7vikdiPOPu0tqcp/ZO1rRq/6DMoMpUFptx+M9lKAfGeyzevHudI5sWABU5D1bMSPwQfbKlBS3MkihbRAA3AJRWZUaud78M+q+tQ5TnHKMbLhT7p5hKrHWKEKRS6oNyite+UpUhMvCcOryzwL6pD/BDFLx23rN1rQ+BP/ghs+Pufj65OmdmjArX8Aa69a5ReE6AetPAXN0cOCZopbVR0lo/0N2IIZOMwLUqRTimJkbcS2Yb29tRPlxKvj6L32ukcqK564bdc75gZcZ5kCiI1y3qDo1QAY4jXeWN66PVIaKLPsKJ5YoZdxixG/onhu1V9i5+ssTcBmipuOIS55X8AA/nVm1NlflMB1A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR04MB7874.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(23010399003)(19092799006)(10067099003)(56012099006)(11063799006)(18002099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F0byQGaIQJAWNmiEd5rkItje7aBVDrV8UunoZkF/t2QEPVHpF6pUyw4f1R29?= =?us-ascii?Q?T7880g7uv7Y7mcZG6dJ0XYaK+SVn7cAuk8IPriN7BJSzDiyNEJKR2alG6MzZ?= =?us-ascii?Q?iEG/2KHbnPLZ4D5M6UlocTEKm1b1dScpVwtELuUGpUHE7NFV8cHlgAtut/8O?= =?us-ascii?Q?fuXEj7QHRdV+FoQnFgcbltw55h4OfOMARP/przJfeJ4ePcq1OPwMCGsGtQSG?= =?us-ascii?Q?ws39z/IQFUvYM5tPEUfLpQXWsLAgNq/ju8LjL0wIeOqbtpbb1WIaz+YcqyKm?= =?us-ascii?Q?mhBtRI1DtgI89c4IZeVNbFQFbcABufzZI/gRgpSQxzGL88veqIQyB6Z1On/y?= =?us-ascii?Q?yXTJb26oeI06it6VcZmlBR03Na80EA5/AIU0IhbDf0WVcGPphkpT5MD23iCq?= =?us-ascii?Q?u03SsGNI7mimu9QFJ4vnT7kejudE0eZHP1JAiTLo6xpn6oXQHNa/Kljift9+?= =?us-ascii?Q?HbKuqV8NFFa8XZUDsl4JZq5UBPS1jZJVdiamqXrqVpK3NK0zNy5p+k9q9Wpr?= =?us-ascii?Q?AXC3WEfRuPnY/AiXe8jVznyIQ2pZdq4dWOL9080aIuzAz4eTn/P8gvpMbdsJ?= =?us-ascii?Q?Dtt4Tgw0pNpkF3WsMKzE6our8Yk4cIVBUblmmVGGW/BmwpPqQZiqZTeIRB4C?= =?us-ascii?Q?T7OHarzgvFjGU4g5pXIISpOneoG5zR5UZVih7i8Io2gr9qQ5ddWLpiPhwkay?= =?us-ascii?Q?F34sQ6UjKnPMSnln/DL/SXX7JnRukSD+Z4DSyqnmHcJTa/Yr7do4EqMPbnsE?= =?us-ascii?Q?mjbnWHWd0/FqdRFDbqCveR1J+JSLkoBFcBrEBJlue5mstsqT5q6tX4UJZIFH?= =?us-ascii?Q?3j5cG/lfexM2i/pvg/FdCBd7/vb41FFs/3JaV5ck2azb6JhBX1K2CmczLnql?= =?us-ascii?Q?Tw5GK9hfQNYQZUnZO0t87Ylc00qbPIaS14cUdgVTTX1jXWkhTY/PzcAcTjDG?= =?us-ascii?Q?TDFHPunU9kAr78Q0JdSOP84qi18+u3Czmg1loQ0JWTqmSuE1AcaoOC+InuVJ?= =?us-ascii?Q?xUkf65YNRyuQaQZ3GiSmFgSB8/0h1Qvr11yHgv50/74BC7V1SAyZ00+VH7gU?= =?us-ascii?Q?IBez5MDewOw8k13oFgueqi7kARKr656SGRzS8ytVFQ9Qu0oEFFEfNzhcst0+?= =?us-ascii?Q?SSpOQ0WhcJfMle0iinPgY9Xj0+F2zyWFwXV4J034pw1dn/vrT5s7hiwgb2x3?= =?us-ascii?Q?TFbex1M5i94Adql7Vzkf6NS1pITB0myMFjOnuuVRJgwUSCiJ6NdmVr5yzyjM?= =?us-ascii?Q?DryWQXToY7rLAzkfJq+xYvfHO2yfXEnKfBBb/Svcei3dL3Vn3HittXxYEuRg?= =?us-ascii?Q?nIoVkVxzGv2kyH49mQKl6UybherYA5M22IyrzHG2D0ZI0LTIvJVprYdJbHUR?= =?us-ascii?Q?kFi5VeKtqbuV5lQsyihNCun54XfaAeeLIUBgw4vaLYu+IoYx2Re7vfDSptQA?= =?us-ascii?Q?btaDAZnisPw5D2arrhoHbS0kF/rbEOlZtxxk5B+zTMzt82/bucV1seK47+ec?= =?us-ascii?Q?5CzzOEnmjT4o2skcBkI9nFRlue33Is4+1YkZUcwiu8BLJk1EZNYGI3QM92pt?= =?us-ascii?Q?+ROM+JeODKlYRpTCWIm11rh140ifgu2+4yyVLE0bSC7A6x1JEFS3+PFDgId/?= =?us-ascii?Q?DyvZ1vSMEUrxiLvdIlW/60jRDqM3sFEFIIHCvXqGNxLVyrglg/CyLMKU6jtW?= =?us-ascii?Q?GtKipvCpPeLlGD+vNtVjPHB79A2EhLpK4+1TgtNogOy8u8H7/NtAk1ktdDos?= =?us-ascii?Q?XJf1zpoIC8wjsX/sbqAkN0m7Q+3FeY/VlyLhudlmUELI+hxWsP07?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10ac0b56-9314-431e-8138-08df1a16ff5f X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7874.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2026 08:36:58.8486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QrfepesmHZGWlwwTcTTpqy6M1lJRyCgZBYGRAeT6pnkVm0w5F+9RSnY1bUzTfvUhh4F5JR8HynAWuVkT+i7786eDxypI26hXdvG+mwZFszuOtTySrb9St8CIIf/pgk5j X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB11339 Content-Type: text/plain; charset="utf-8" From: Peng Fan Replace multiple if/else blocks using regmap_set_bits()/regmap_clear_bits() with the simpler regmap_assign_bits() calls. Signed-off-by: Peng Fan --- drivers/pci/controller/dwc/pci-imx6.c | 32 +++++++-------------------- 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 28fed010b503f..e2e55a88e0132 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -747,12 +747,8 @@ static int imx_pcie_attach_pd(struct device *dev) =20 static int imx6q_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enabl= e) { - if (enable) - regmap_set_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, - IMX6Q_GPR1_PCIE_REF_CLK_EN); - else - regmap_clear_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, - IMX6Q_GPR1_PCIE_REF_CLK_EN); + regmap_assign_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, + IMX6Q_GPR1_PCIE_REF_CLK_EN, enable); =20 return 0; } @@ -868,12 +864,8 @@ static void imx_pcie_clk_disable(struct imx_pcie *imx_= pcie) =20 static int imx6sx_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) { - if (assert) - regmap_set_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, - IMX6SX_GPR12_PCIE_TEST_POWERDOWN); - else - regmap_clear_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, - IMX6SX_GPR12_PCIE_TEST_POWERDOWN); + regmap_assign_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, + IMX6SX_GPR12_PCIE_TEST_POWERDOWN, assert); =20 /* Force PCIe PHY reset */ regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR5, IMX6SX_GPR5_PCIE_BT= NRST_RESET, @@ -883,12 +875,8 @@ static int imx6sx_pcie_core_reset(struct imx_pcie *imx= _pcie, bool assert) =20 static int imx6qp_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) { - if (assert) - regmap_set_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, - IMX6Q_GPR1_PCIE_TEST_PD); - else - regmap_clear_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, - IMX6Q_GPR1_PCIE_TEST_PD); + regmap_assign_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, + IMX6Q_GPR1_PCIE_TEST_PD, assert); =20 regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, IMX6Q_GPR1_PCIE_SW_= RST, assert ? IMX6Q_GPR1_PCIE_SW_RST : 0); @@ -901,12 +889,8 @@ static int imx6qp_pcie_core_reset(struct imx_pcie *imx= _pcie, bool assert) =20 static int imx6q_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) { - if (assert) - regmap_set_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, - IMX6Q_GPR1_PCIE_TEST_PD); - else - regmap_clear_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, - IMX6Q_GPR1_PCIE_TEST_PD); + regmap_assign_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, + IMX6Q_GPR1_PCIE_TEST_PD, assert); =20 if (!assert) usleep_range(200, 500); --=20 2.50.1