From nobody Thu Sep 24 12:53:01 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0403B4028F2 for ; Thu, 24 Sep 2026 06:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230969; cv=none; b=Jzo1Yj0CxH/GoJLOHJkFWCV5GpHlwHjCzAS5vzM6FZLedVmRiiQAodJt2CYKFBRS2rO6d//MWKA9fywkBpSj7DnU1NwyaJgYUbCrsIdiON3te51ExW/ALoUzrw59R4ArAvbSLak+0MZexS2yIa1x+rgJfIGrhqrQUQWaz2q0p5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230969; c=relaxed/simple; bh=aJVsoy5Trk1oVXSy6lO13HBYy2aSxZSVKLzYy8qqiKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pIe8/aE5Z2nmTq7XCxfwSwIPCjFSCN86SJ71KaVAT3vAC321Z33kU6ZnQ2YZhscJZEqBWTs0fLreQy+p7TdTCah+mFYcmavl1wXfhJcylTCv3EnyIyNjNH/95Ppgs7EW7gO45WagyncCHs3wwmquIXmrdye7BcprniB9JtvkSxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kL2+PYHS; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kL2+PYHS" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-398a147688bso1248268a91.1 for ; Wed, 23 Sep 2026 23:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790230967; x=1790835767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CtXRhGuw2qVKHIOiXDCs7JborWUyDWhbjStFj79j+rc=; b=kL2+PYHSbvVod/8YTeyijkwoOjc4szvjElPnDw3KcXq17Iz3Au+Z6EV0c6daCRyMNy LcAvI3+HcWdQ8NBE/9Ugbo/aQLsNW2nT9wJbPy1pUtvt0ppsMJeYhizAGQG3syW7OM5k 6pATeqj8FAnUoxsGaV7UPanYs6CM6fILOsgb6LGyaayuykczBj/seSyeIdTZ37eKH7EF RHT2h2PIfEM6Fd5jY/U9W0sedX9RyokubTLnRD6uX1fIbG9A1qeUU210ZHZLOSqTlDs/ 174w3IZF9ypI3TYha9wTyKBLVyEzwlpxj469EVYtvWKVeidDFS/fzRReuJ1hHRp2X9hp viKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790230967; x=1790835767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CtXRhGuw2qVKHIOiXDCs7JborWUyDWhbjStFj79j+rc=; b=JBF0AUvfRWAKa8tIArtkOE5CghJWQgammuE/rp/fxHEyT1VgCYE27guthHgDZxx2HT 4eNo0SavWd1oUE0JUY+Y4fcJIde/S3yOvyesZskfpQgG9YSs47m9sOGtO0c04xf3wT2G Nj0Ot5BtTdcCRPoOKKt3uphW/FELyE0IRmZOHuvmIOYsg1PEriY8kuTdu4frz6iDlWXK qakW854B1eIeDptaF6WnZC+Pcf4DBrE8gCaBXGt/NZxY6quAeCRr1T9QLzLjeC+/D4y/ IzLUEXYtu9dWoy1NcpwvthkstVCdOsVsAl74BOMuh5KQlwraHa0Vwls0bHpf6iFwsdWn 0t3g== X-Forwarded-Encrypted: i=1; AKwUvBycK7Yx9dy34d4+64ykXMOLCKg2zQDpXvBH/tEVnx/McOiSHQq2ejWNlxB3i/hSsBiX9SQr/R3ZGeHQpdk=@vger.kernel.org X-Gm-Message-State: AFuF++krT0BIyCZa9rUmUcCjyCGhgZB7pD0+CMtEzMU9ilQUezzaq+d6 gURMfL82Yh++C6gKOu0Lt1iKoa73gSkaMcsRzM+EDSxGkZhOueAcihi6 X-Gm-Gg: AYBFou2W9MEnDzmoD3erJ1lYCcx53p4wkmh/+FRvj8e0aAfL6jm8yBlwjjEOoawZKMC Y5034AOG8GQXVZ12jtYvh80VKE38kXPX0H5YEKU9n4o6Y5jQXyoQeYZVrSZ+czcA+bco6CSdBXa +XM3oUqHj02lV5Zr0xcDSdYSqdG7Yimftei+6cWHEY2hEFERYHzq8gsWevIU7AMkYZOFB4xpmzW S21RGyor4JHpqgZgL7nY7MBT+gV3WJ2z03C3aWLkM2TOiaMid2C9Wpz4P316TgzxAHKgrjRYmgO 9YsNvBcIl7SNk0n/Ej6BeELsCoO8XqOwvyO/OHM2wYiiyiRagzKvRHMorMjPGWqIQtMARvquYW9 e4RO8Ylqyu10CBGo52Gbq8T9IhNFF840cZWKduEH8byQAbWiYh5eMrq4jIjDbRMMz/w4EQPyyIX 16NdsVmZN5kqDZDtLmBjEh7KtTpB8ffAmm6yHANJzanCTRuTl8bOiHlWMMVu2iTIp5xgfjGbApZ Ec2X8/3K22N9uLG8g9gQ3mUCn2aX/FGPdvdBTcJAiQ5jF3GvJyePZSmZ2R19qSLF+Zmoev/BJze QDJEdWzGiTgxA61ViD05 X-Received: by 2002:a17:90a:d446:b0:39e:6c69:9b8d with SMTP id 98e67ed59e1d1-3a099230f6amr1282682a91.50.1790230967061; Wed, 23 Sep 2026 23:22:47 -0700 (PDT) Received: from phui-2.c.googlers.com.com (67.51.127.34.bc.googleusercontent.com. [34.127.51.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df6a5d7a48sm21220615ad.48.2026.09.23.23.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 23:22:46 -0700 (PDT) From: Hui Peng To: h.morris@cascoda.com, alex.aring@gmail.com, miquel.raynal@bootlin.com, stefan@datenfreihafen.org Cc: david.laight.linux@gmail.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH net v3 1/3] ieee802154: ca8210: prevent stack buffer overflow in ca8210_rx_done() Date: Thu, 24 Sep 2026 06:22:42 +0000 Message-ID: <20260924062244.2444225-2-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.310.g51773c2048-goog In-Reply-To: <20260924062244.2444225-1-benquike@gmail.com> References: <20260924062244.2444225-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ca8210_spi_transfer(), each SPI transfer reads sizeof(struct mac_message) bytes into cas_ctl->tx_in_buf: cas_ctl->transfer.len =3D sizeof(struct mac_message); However, ca8210_rx_done() only checks the received packet length len =3D buf[1] + 2 against CA8210_SPI_BUF_SIZE (256). When buf[0] & SPI_SYN is set and priv->sync_command_response is non-NULL, memcpy() copies up to 256 bytes into priv->sync_command_response, which points to a struct mac_message object on the synchronous caller's stack, overflowing the stack buffer: BUG: KASAN: stack-out-of-bounds in ca8210_rx_done+0x117/0x6c0 Write of size 256 at addr ffff8881009e7c40 by task swapper/0/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 ca8210_rx_done+0x117/0x6c0 ... This frame has 1 object: [32, 182) 'response' Check len > sizeof(struct mac_message) instead of len > CA8210_SPI_BUF_SIZE in ca8210_rx_done() so that any packet exceeding sizeof(struct mac_message) is logged as erroneously long via dev_crit() and dropped before copying into priv->sync_command_response or passing it to ca8210_net_rx(). Tested in QEMU with KASAN enabled by passing a 256-byte SPI_SYN response into ca8210_rx_done(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - Check len > sizeof(struct mac_message) at the top of ca8210_rx_done() where dev_crit() logs the error and drops the packet instead of silently truncating memcpy() with min_t(), addressing David Laight's feedback. Changes in v2: - Split the ca8210 fixes into three single-issue patches (1/3..3/3). drivers/net/ieee802154/ca8210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index 01af4f9..a990a0f 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -686,7 +686,7 @@ static void ca8210_rx_done(struct cas_control *cas_ctl) =20 buf =3D cas_ctl->tx_in_buf; len =3D buf[1] + 2; - if (len > CA8210_SPI_BUF_SIZE) { + if (len > sizeof(struct mac_message)) { dev_crit( &priv->spi->dev, "Received packet len (%u) erroneously long\n", --=20 2.49.0 From nobody Thu Sep 24 12:53:01 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD8D39CCF6 for ; Thu, 24 Sep 2026 06:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230970; cv=none; b=pN9ahiufrkzlfsdc/Nfv/WvxEqnhUcGfoYZZ87SvRSYZIubz1KxdpgNUEsgjMQvKzYc4JnF8nbGZUzvtQqZQ8nJcO/RN/03czi2y4qhGVNMRYRDlSnlrF/EwIY1205trSVtBIZGqOuA2ylnz9x7bpWb+ZaNg86KVGWBBQitu8q4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230970; c=relaxed/simple; bh=8n4IhzxLjYl7HTSiJyo9dgWou+NdEFWkn0ApdKjkeKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CJtD2J0670pN3+ok1G7O72WYJmFBIF0JtgCMm/vwSc5yhdMK3ObwNYHM5jknfYjly+i4n26T4tbot4iYujpRQzvAAo8qk5BZO/moTmTbX9sRyoIke6A25I1m+nRukqe1KgV6mWtMlGLP+d+X3QuvauHT6RqAa/oQHy7H4pSVzC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lTV4gtJO; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lTV4gtJO" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2dd58e1e2c7so8869025ad.0 for ; Wed, 23 Sep 2026 23:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790230968; x=1790835768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QpjVkotq4ymVbBexed9Q2u7FUNUeANInboIGD5bfseA=; b=lTV4gtJOVWKrmpfnbtgtYYjIubmYOEsQJvgXMOslXjBk1nXXq6Hn3BAYfJ0peSvYlH N7HZeHtqZDcVOLMzlSB1lgu682wO3Fqm7ArRCo7Oc4gq5yZ3PrxxoCGhp7OmzG9nX+xN vXUENyEZYQHbmFxssp/rGbcjgc3W5WbLBsk933C7wfzo2ErY5Lw6MV9oOsTpXyJHbfbF ykLHFtQ2tBr5TQI5IH9jxgGwkzsJbLBUYm20G0CXZXYshwbI7uFrf/jwVfukOtuH4Vg2 kgipRE+hFxXxwuakEyXHRemDc6wxjL1/kLC7vewSOfb8HIPPlD6Y9M+T4BHG7yJIH4w+ ovlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790230968; x=1790835768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QpjVkotq4ymVbBexed9Q2u7FUNUeANInboIGD5bfseA=; b=HOvstIC2oQYYYrQB2c5HVLtuQBYjqbRTb10BO4uCzk9CfhLZbE8q/vKXVFXQFLaNQR xyhMU3lCN86XAdYDCoiiBLeUpr1goOzkzrFeNzL8GKItic+vfKwRIu+xwQsVXABNPvvr 5hQ/dXzqippawwGeUiCyJjtNNGCFJta40BjvGsfCMpwjQGIQtm0qHmJQPIlrmRHHYaFF c+ODqsBSHduv9J974RF65kZHfgjE49UFrk4nK3ifrsdYAofwU2uGXqoeKhqsHn/qgv5i FOVnTailh4XsLlzC/UeL+0EUvk7sFEj/9W5wyJ2W2Nl0kBa6t7VdNxyowQdamx4nU3dP SUAA== X-Forwarded-Encrypted: i=1; AKwUvBzwGb4P2bYv84+57edEMhSSn4K/rsPBxLkC2NbRDDAquh9SmdYckYTnAyZUR+jSMJZwUrMRxHmFdosSBSo=@vger.kernel.org X-Gm-Message-State: AFuF++lod24rIUACbeeAeiHel6B87lRo/Xvno/VY3UEjNwqz69tjtRqq aANO6l2J4AHyQbFAG6UIOMHZer9K4XL+7EjWy2+R17s+WTax/9Pc9oRD X-Gm-Gg: AYBFou23hwtBD7lPY3GDUk873/G4hizPXS1hAN9mRYgHC5HexrnH0FlQ1mAo+7pSqZd bmakdwkn0Jd0QLeBwkXcYURc/asoMYFxoIZeOGam0PJp9w7AY+wxMltXqddpkDhuU9NorWZgrJp mNwavCBXqytp7vgAQplvv1HLuJsaXCu4MObLsjY+lJoawlXundApAQpAeGTXAh8gD8JJAo9iBVS 265H2mGqzLB/wG58VYyocAeKQu04qRWYJi36Qn7a0EU+KNQHdgzEYBEH2b30E3ETMJqPMTGkUk/ xg4srJsab3tn6qmT5UgDqba8Rwvfcw150TULHGXbjyPs1JP8+dbTMWv9xWnaS/tslutPWfiQ/XG 6PE/JYIQGyrf2Ale4vXYPd81jn6GYs/xwa7kzULpB72PRiZhm7pyllqaXvB52Pb5ZNYq7StuHrZ UiZE9S1qV/TjyYJsO4YZDS3ad75h9x2F76GAtpDmNfIE9giC3qyxb1rpEAuQ55jtHldarf0ZH0n 7mxdbp8r8tlEjqpIJym7f9sq2G6Nikh8RLlFaNewOU0QlY5VzSyy1sLeiFD0RKk/KfjHYPACPB3 ZjGv6dhpUo0= X-Received: by 2002:a17:903:1a0d:b0:2dd:76b1:34f0 with SMTP id d9443c01a7336-2df7da428eamr14725105ad.11.1790230967939; Wed, 23 Sep 2026 23:22:47 -0700 (PDT) Received: from phui-2.c.googlers.com.com (67.51.127.34.bc.googleusercontent.com. [34.127.51.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df6a5d7a48sm21220615ad.48.2026.09.23.23.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 23:22:47 -0700 (PDT) From: Hui Peng To: h.morris@cascoda.com, alex.aring@gmail.com, miquel.raynal@bootlin.com, stefan@datenfreihafen.org Cc: david.laight.linux@gmail.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH net v3 2/3] ieee802154: ca8210: prevent stack buffer overflow in hwme_get_request_sync() Date: Thu, 24 Sep 2026 06:22:43 +0000 Message-ID: <20260924062244.2444225-3-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.310.g51773c2048-goog In-Reply-To: <20260924062244.2444225-1-benquike@gmail.com> References: <20260924062244.2444225-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ca8210_get_ed(), an uninitialized u8 lenvar and a pointer to a 1-byte stack buffer (u8 *level) are passed to hwme_get_request_sync(), which unconditionally copies response.pdata.hwme_get_cnf.hw_attribute_length bytes into hw_attribute_value without checking the caller's destination buffer capacity, overflowing level on the stack when hw_attribute_length exceeds 1: BUG: KASAN: stack-out-of-bounds in hwme_get_request_sync.constprop.0.isra= .0+0xf3/0x170 Write of size 16 at addr ffff888001907780 by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 hwme_get_request_sync.constprop.0.isra.0+0xf3/0x170 ca8210_get_ed+0x9c/0xf0 ... The buggy address belongs to stack of task init/1 and is located at offset 48 in frame: ca8210_get_ed+0x0/0xf0 This frame has 2 objects: [48, 49) 'level' [64, 65) 'lenvar' Initialize lenvar =3D 1 in ca8210_get_ed() and return IEEE802154_SYSTEM_ERROR in hwme_get_request_sync() if response.pdata.hwme_get_cnf.hw_attribute_length exceeds *hw_attribute_length. Tested in QEMU with KASAN enabled by passing an oversized hw_attribute_length response into ca8210_get_ed(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 2/3. - Replaced the temporary stack buffer in ca8210_get_ed() with lenvar =3D 1 and an upper-bound check against *hw_attribute_length in hwme_get_request_sync() as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index a990a0f..8aa7ffe 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1677,6 +1677,9 @@ static u8 hwme_get_request_sync( return IEEE802154_SYSTEM_ERROR; =20 if (response.pdata.hwme_get_cnf.status =3D=3D IEEE802154_SUCCESS) { + if (response.pdata.hwme_get_cnf.hw_attribute_length > + *hw_attribute_length) + return IEEE802154_SYSTEM_ERROR; *hw_attribute_length =3D response.pdata.hwme_get_cnf.hw_attribute_length; memcpy( @@ -2027,7 +2030,7 @@ static int ca8210_xmit_async(struct ieee802154_hw *hw= , struct sk_buff *skb) */ static int ca8210_get_ed(struct ieee802154_hw *hw, u8 *level) { - u8 lenvar; + u8 lenvar =3D 1; struct ca8210_priv *priv =3D hw->priv; =20 return link_to_linux_err( From nobody Thu Sep 24 12:53:01 2026 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489B140B110 for ; Thu, 24 Sep 2026 06:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230971; cv=none; b=Hg1Md9Ppd0Tl751DgA0+xfEQZ6YXwhPuEcvyWppIrL/gOaXvuR6ApE79HXrTdgpqMFqR4XC5Kb+k8QB0BJ0QVY8kgS033Nhf4U2LUkUTqlIx2vlliFMUzwgx96j3iqQH/3q05zUR0s35lyyUlnJQ4/Wok/DPAyJWN3iEs0ikLyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230971; c=relaxed/simple; bh=Mk3fSgu7F2inklm698FGg8xtY/UC1g+hSJQWE9hH+Ug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KRcEnia3x25Hq9CzkxL0Q2nuQG+mce8N0qJCn0aEEy/MjhuPLYkCoWgvBjBXunQm0XFrJSEcAwC/5GryfMbS03OyIZlWkZICxjECJV/5kZA4jGzcyopP+UEBTfgigzFVZwdH4y9baOGJJesekCUIHBzQg8nVaOcERSc89XxOTFE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RXLUwcyY; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RXLUwcyY" Received: by mail-pj2-f43.google.com with SMTP id d9443c01a7336-2d93ff61046so9780235ad.3 for ; Wed, 23 Sep 2026 23:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790230968; x=1790835768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WltmE4hNoTkSsXOgrdp6cz7c6fyzqTtuC0otv1UOPu0=; b=RXLUwcyY11ngfU6rR6/2T7DlRzxh+9CrigcCDJRWkT3YvLgZ5p841K+AzGkJZJsni0 ELpVot0+3i38FyUJe5WHt31yJblyEpAG2v4n8/BZRm5UNZ012pKFT8VrzOxgST0eCf07 6WmhzmAJr1J71un8VZTSNYc6CE9h2LFhOdTmy3G1dgCwD68QSMD/iAGjzWzFaM4Q+0su ho/R0xJ0jeMdKGIkXUmuUIrJjYAnFwIaxtg7hXChgDtZL1ScD4SlspnV2xp3CWoZmJyz txYzjvPltzW7oAYYhzB24tLh/qc2NvGwKy0v+ycEX2+nbhPRcv7HpNDKOJSAlN3E5IOb kYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790230968; x=1790835768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WltmE4hNoTkSsXOgrdp6cz7c6fyzqTtuC0otv1UOPu0=; b=OTF7CSxyPXNUDv5q/JNzCkXyY02jgHdCqZiuNPl8aAr3Z3KDyv9S4XF/EmjeT1G9n+ 1hGO71fjMWvvae13wGFQuwYyoYoc0JU3epTsvMxyKTYlQQfGA4+wthyZZcwaBohuBg/L WloE0CPt3RRn79U10dZM0uBekdnv+jtJJ/rubBEW7zXi7OyZgrJu23VqchXrSE1soJHW HhkbmbDFPc+lTotgUxf0GBbvo440+yo+ILFkqnFKXNj/JWvAN0Cel4h+iQ7BucZPa5hp zHWVEKZxPMn97tMyDeO0/emmTZ6kCUxWqxlMbJmgt+3TL7QM56Y0kWfWZ7FvotsebwlO gQrA== X-Forwarded-Encrypted: i=1; AKwUvBxQORQuplO24W5LQ6/JSnyyf1TLoYjHZaKlGwpuaGvmoGAJwECaOJgYsLELkUZqJ1WhQh2GlRlUKyqSvgE=@vger.kernel.org X-Gm-Message-State: AFuF++kfwECz7uUuHYCxichujXHjxoQ9EzoC3NpzDFHV27nAvM2Ze99G 1IoFIS7HwUkVVnzCBFcK2u3rgrGhQQk61luhksZ2BwJoZvPKG9Ii2aaE X-Gm-Gg: AYBFou2e50LCn7U3fkYnWc+GX1g3XQyJMRhp0NosqK2UkCm7bF4NQwyC8xCtohpONKp 86kFJ2Z6hZ5+3PzwKf17UZdpj3i14twhJKl+3NZhdvhxBuZ9XaPmlOH3znq4Vza+DUEDkY+SxDw TtBl1DafsvvODDQnb1V8wA48X9dSHhXTJhU4LJmvTQjNJoMMNJZodg7pBc6oMDPpJMVg8lnFzsC 9nU3ozRwMTiyjgbKF38vewthY2CUPjBbxzXS8j7mbNeURkxOKyvy6VGE+dqWBgnKc0EwItyduq0 hfqMJnm9a5K0o2FpmT1fLHT4ulH/1NDWqFr67/EOuBIR0E25ruG5EQMudrHC0LGpx1WYwzFUZ4y jzZ3urnZE5YtuuAzU+a0CBQKQnspcoww10ge1JeQNWRM0JITFQGt5tDSjGKBiXjLW5Zdl4ZnLMV HzluOji4zB3tjQ1q8l84CG+6vh+ecOceSOulPyxy9RtdLErtP8hFigMjPQaf495od8DHOjVNKPI YGZIM2aSkr5dKuSrL5+T3dWlqEOb4KY1zPL6nLgzj1IH6HLtjE5/BsfO3cER93Fh26eNdi1zCZZ MvaQ2OgjUg== X-Received: by 2002:a17:902:e946:b0:2dd:c100:313d with SMTP id d9443c01a7336-2df7e2530ebmr11495365ad.57.1790230968400; Wed, 23 Sep 2026 23:22:48 -0700 (PDT) Received: from phui-2.c.googlers.com.com (67.51.127.34.bc.googleusercontent.com. [34.127.51.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df6a5d7a48sm21220615ad.48.2026.09.23.23.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 23:22:48 -0700 (PDT) From: Hui Peng To: h.morris@cascoda.com, alex.aring@gmail.com, miquel.raynal@bootlin.com, stefan@datenfreihafen.org Cc: david.laight.linux@gmail.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH net v3 3/3] ieee802154: ca8210: validate data_ind length upfront in ca8210_skb_rx() Date: Thu, 24 Sep 2026 06:22:44 +0000 Message-ID: <20260924062244.2444225-4-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.310.g51773c2048-goog In-Reply-To: <20260924062244.2444225-1-benquike@gmail.com> References: <20260924062244.2444225-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ca8210_skb_rx(), data_ind is read at offsets 22 (msdulen), 23 (mpdulinkquality), 29 + msdulen (hdr.sec.level), 30..39 + msdulen (security header), and 29 .. 29 + msdulen (payload) without verifying that the received SPI frame length len covers those offsets, causing an out-of-bounds read when msdulen exceeds len - 30: BUG: KASAN: slab-out-of-bounds in ca8210_skb_rx.constprop.0.isra.0+0x137/= 0x160 Read of size 64 at addr ffff888006453ddd by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x23/0x60 ca8210_skb_rx.constprop.0.isra.0+0x137/0x160 ca8210_net_rx+0x96/0xc0 ... The buggy address belongs to the object at ffff888006453dc0 which belongs to the cache kmalloc-32 of size 32 The buggy address is located 29 bytes inside of allocated 32-byte region [ffff888006453dc0, ffff888006453de0) Consolidate all length and msdulen validations into a single upfront check at the beginning of ca8210_skb_rx() before allocating the skb. Tested in QEMU with KASAN enabled by passing a short data_ind buffer with msdulen =3D 64 and len =3D 30 into ca8210_skb_rx(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 3/3. - Consolidated all length checks in ca8210_skb_rx() into a single place at the beginning of the function before dev_alloc_skb() and dropped the unrelated hdr.seq assignment as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index 8aa7ffe..ab245ad 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1758,19 +1758,15 @@ static int ca8210_skb_rx( u8 *data_ind ) { - struct ieee802154_hdr hdr; + struct ieee802154_hdr hdr =3D { }; int msdulen; int hlen; - u8 mpdulinkquality =3D data_ind[23]; + u8 mpdulinkquality; struct sk_buff *skb; struct ca8210_priv *priv =3D hw->priv; =20 - /* Allocate mtu size buffer for every rx packet */ - skb =3D dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); - if (!skb) - return -ENOMEM; - - skb_reserve(skb, sizeof(hdr)); + if (len < 30) + return -EMSGSIZE; =20 msdulen =3D data_ind[22]; /* msdu_length */ if (msdulen > IEEE802154_MTU) { @@ -1778,9 +1774,25 @@ static int ca8210_skb_rx( &priv->spi->dev, "received erroneously large msdu length!\n" ); - kfree_skb(skb); return -EMSGSIZE; } + + if (len < 30 + msdulen || + (!priv->promiscuous && data_ind[29 + msdulen] > 0 && + len < 29 + msdulen + sizeof(struct secspec))) { + dev_err(&priv->spi->dev, + "received truncated data indication!\n"); + return -EMSGSIZE; + } + + mpdulinkquality =3D data_ind[23]; + + /* Allocate mtu size buffer for every rx packet */ + skb =3D dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); + if (!skb) + return -ENOMEM; + + skb_reserve(skb, sizeof(hdr)); dev_dbg(&priv->spi->dev, "skb buffer length =3D %d\n", msdulen); =20 if (priv->promiscuous)