From nobody Thu Sep 24 12:09:33 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D18641169B; Thu, 24 Sep 2026 09:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790243323; cv=none; b=sDYngwmlySCJCSBOyLeTqN+J5nRLYBAMefX2Wyu3BbOYWVBayMtT6YmbobDTAIGDS2namziq7GtsfxF69T7umrtSTY3sTsarip8LjtMHGUepxD6G+07vku0c9RD7EIi9e86wDnJCibAUA7aTqUUoTUkbe1jC2xEqDg3WP/7F+R8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790243323; c=relaxed/simple; bh=S7oFeT+YUdKkug5ypub7txpMfPfFwCVaLOl/7hcvY6w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OwGlQhmumxy1HAHtkM3eFgsTPAXZhREjRPXyCcBgCI487+XimocUDAAftEcU2pk1QIOWOg8a0+LaQDGMUieqhaPSxxDrV3h68OsMrxTiA8RB/hSSjs9ncwvHrTHG2Xo4jqDbWeVWd1iwwsFhzNTCnxiSLO1C/18cv5a0rRuqL/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marmottus.net; spf=pass smtp.mailfrom=marmottus.net; dkim=pass (2048-bit key) header.d=marmottus.net header.i=@marmottus.net header.b=ArscTyP/; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marmottus.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marmottus.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marmottus.net header.i=@marmottus.net header.b="ArscTyP/" Received: by mail.gandi.net (Postfix) with ESMTPSA id 74CA23EBD5; Thu, 24 Sep 2026 09:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marmottus.net; s=gm1; t=1790243305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ncwg9ho5lG/UbOhbZIbh2sgQ6cGDbkfpndg6EYig4o4=; b=ArscTyP/JmGx5gmQ8BHaGdZmJq59xwGh1cWOLA4Pr1L/T8LNXQF+6mz6lJpmguExKRCdiZ 8Bkf3kuNWl6ns5Dr/vRvpiexsA7dJGAmysguudvlH5mZ+b7okM2y+ZsTfgyfYS2C1Xds1h nd9csNAVLR0X5KcVQuE7L5kxFSx1V0cd0xEeHdSkjGNMh+rZL6gtdreANrjJmVQhqK6uln OnfkpgZSG28ef69xvz8BWvsd7nsZDSLnqCLFnN9dtea6VUqUEsouPJIi13I3HrOhdLFLf0 QhrK0nAzkTcUqPjTK/YLVX5Pq2u1uCD9gnK9Cud1TDl7IaKRNmJMWnRFPOj4mA== From: Arthur Crepin Leblond Date: Thu, 24 Sep 2026 11:48:11 +0200 Subject: [PATCH net-next v11 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-wiznet-link-gpio-v11-1-42a332517b30@marmottus.net> References: <20260924-wiznet-link-gpio-v11-0-42a332517b30@marmottus.net> In-Reply-To: <20260924-wiznet-link-gpio-v11-0-42a332517b30@marmottus.net> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Arnd Bergmann , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Arthur Crepin Leblond , Krzysztof Kozlowski X-Mailer: b4 0.15.2 X-GND-Sasl: arthur@marmottus.net X-GND-State: clean X-GND-Score: -100 X-GND-Cause: dmFkZTFhyvBWwSdlAprHnmharjSBeSvU3LFLSd1AHsenPfaek+TmvMr1VWRdnZitSYAXqGtk3f6nbIt+JNQEAVoFPl+F4887JkdxJxPFq0WMNHrEhI6qtv2aqmTgFF26ousMuHCdaTPHu8o06bseeX8ScEsX4OpVViOaeRoOp93JPCLEOIrBbi7o1zpAOJnmQnDM1GaZopYGkm9fVMvH8c2Mf03v4WyPZcZgyEVJxGd57wKE5LsECf1MpcrcJERyp2iUKsE4mvATJF9BihIgI1ogW3qNTPBhm25vRvdDueveiL7MeuoN1gk4uE+lLIN1NHkX1XweizpSNv7wq8LIvJ/MWZFWF00JpC9sm28Mq0rD+RXW5TLAD/AzzfigqqZ7cExnKr3yeoYMZs4AVLKTtX99eJTgD7Y+4v2RKr275SuXRnJU2vuvx+RNRNke31gxgFydewby0IHStJZSwkXhoy+TgW+Dfe32SNo2GMyiAdWZQRXZ2anWUL9z0+C8W/C6XEii1PZf+dg3kQldipkkZmZ6lRX1za/jVUM0GWPyEfX/iygtycamCbPDyt2COCtDQa4WiSNkbV52xyif/4tZ6Y7LT+eH49KmW8+7xZDbmeFeyj1O6HjHo1Eiv/DjT/2SqNn0qAIgecctUjY+gO1lUvsbhCYmpX9Le10qrrda+v+AtfgLFw Convert the Wiznet w5x00 SPI Ethernet controller binding from plain text to DT schema. Change the trigger type from edge-falling to low to match the driver implementation. Add wiznet,w5100.yaml entry in MAINTAINERS. Signed-off-by: Arthur Crepin Leblond Reviewed-by: Krzysztof Kozlowski --- v11: - Add a line about MAINTAINERS changes in commit message - Describe the entry in MAINTAINERS as BINDINGS - Reorder example properties to pass dt-check-style in strict mode v10: - No changes v9: - Add edge-falling->low in commit message v8: - Add a myself in MAINTAINERS - Address Sashiko reviews - Change edge-falling to level-low - Clarify the spi max frequency for all devices - Add main interrupt description v7: - No changes v6: - Put back the reviewed by tag from Krzysztof Kozlowski from v4 v5: - Remove gpio/gpio.h include from DT example - Fix DT bindings errors v4: - Update interrupts in DT bindings v3: - Fix DT binding errors v2: - Convert device tree binding to YAML --- .../devicetree/bindings/net/wiznet,w5100.yaml | 68 ++++++++++++++++++= ++++ .../devicetree/bindings/net/wiznet,w5x00.txt | 50 ---------------- MAINTAINERS | 6 ++ 3 files changed, 74 insertions(+), 50 deletions(-) diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Docu= mentation/devicetree/bindings/net/wiznet,w5100.yaml new file mode 100644 index 000000000000..df83f90b3919 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wiznet,w5100.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Wiznet w5100/w5200/w5500 SPI Ethernet Controller + +maintainers: + - Arthur Crepin Leblond + +description: | + This is a standalone 10/100 MBit Ethernet controller with SPI interface. + +allOf: + - $ref: /schemas/net/ethernet-controller.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - wiznet,w5100 + - wiznet,w5200 + - wiznet,w5500 + + interrupts: + maxItems: 1 + description: Main interrupt (INT pin on the device). + + reg: + maxItems: 1 + + spi-max-frequency: + description: + According to the datasheets, w5500 and w5200 allow a maximum of 80 M= Hz + while w5100 is reported by users to allow a maximum of 14 MHz. Howev= er, + board designs may need to limit this value. + maximum: 80000000 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + /* Example (for Raspberry Pi with pin control stuff for GPIO irq) */ + + #include + + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + ethernet@0 { + compatible =3D "wiznet,w5500"; + reg =3D <0>; + interrupt-parent =3D <&gpio>; + interrupts =3D <25 IRQ_TYPE_LEVEL_LOW>; + local-mac-address =3D [ a0 b0 c0 d0 e0 f0 ]; + pinctrl-0 =3D <ð1_pins>; + pinctrl-names =3D "default"; + spi-max-frequency =3D <30000000>; + }; + }; +... diff --git a/Documentation/devicetree/bindings/net/wiznet,w5x00.txt b/Docum= entation/devicetree/bindings/net/wiznet,w5x00.txt deleted file mode 100644 index e9665798c4be..000000000000 --- a/Documentation/devicetree/bindings/net/wiznet,w5x00.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Wiznet w5x00 - -This is a standalone 10/100 MBit Ethernet controller with SPI interface. - -For each device connected to a SPI bus, define a child node within -the SPI master node. - -Required properties: -- compatible: Should be one of the following strings: - "wiznet,w5100" - "wiznet,w5200" - "wiznet,w5500" -- reg: Specify the SPI chip select the chip is wired to. -- interrupts: Specify the interrupt index within the interrupt controller = (referred - to above in interrupt-parent) and interrupt type. w5x00 nati= vely - generates falling edge interrupts, however, additional board= logic - might invert the signal. -- pinctrl-names: List of assigned state names, see pinctrl binding documen= tation. -- pinctrl-0: List of phandles to configure the GPIO pin used as interrupt = line, - see also generic and your platform specific pinctrl binding - documentation. - -Optional properties: -- spi-max-frequency: Maximum frequency of the SPI bus when accessing the w= 5500. - According to the w5500 datasheet, the chip allows a maximum of 80 MHz, h= owever, - board designs may need to limit this value. -- local-mac-address: See ethernet.txt in the same directory. - - -Example (for Raspberry Pi with pin control stuff for GPIO irq): - -&spi { - ethernet@0: w5500@0 { - compatible =3D "wiznet,w5500"; - reg =3D <0>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <ð1_pins>; - interrupt-parent =3D <&gpio>; - interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>; - spi-max-frequency =3D <30000000>; - }; -}; - -&gpio { - eth1_pins: eth1_pins { - brcm,pins =3D <25>; - brcm,function =3D <0>; /* in */ - brcm,pull =3D <0>; /* none */ - }; -}; diff --git a/MAINTAINERS b/MAINTAINERS index e3ce77c839b0..42acc7bb7bfd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -29451,6 +29451,12 @@ M: Miloslav Trmac S: Maintained F: drivers/input/misc/wistron_btns.c =20 +WIZNET W5100 ETHERNET BINDINGS +M: Arthur Crepin Leblond +L: netdev@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/net/wiznet,w5100.yaml + WMI BINARY MOF DRIVER M: Armin Wolf R: Thomas Wei=C3=9Fschuh --=20 2.55.0 From nobody Thu Sep 24 12:09:33 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2958640BCD8; Thu, 24 Sep 2026 09:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790243324; cv=none; b=YRgHYWqurcng3ohRgoSe3wDB8CFLRrnA2OVOu0H8zB8OGMo2TMn0kDm7uydV1mbTpGxV1/n/Q6r9Wife+4c/YsypcFFmCcglCyZ1J4AOydcs7qtvTutYi8UhvE7qQU6ppqp7Egn/qJe/4yrrWa4anb9nFLBpy3gomUlu7jM7lVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790243324; c=relaxed/simple; bh=HGWHw0+YsN2VQstzvhMpaUDdm5nfsbF4QCXSXxbvO7E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lxTgyP8e1bcF/VmGWpmK2M7uUoEA2P681O0spCqt2ALlKdw8OwrSlNKi0nzy3rw/gHr/iQAIYocwG4p6EOkRDbQAjPX0rToUvupM0RRuqD3vA4a2EDIQis+simuvmnYa3sRfm212bHzy4ZGUqkogkIPNlxh9PQ3jrHFCX8DwSAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marmottus.net; spf=pass smtp.mailfrom=marmottus.net; dkim=pass (2048-bit key) header.d=marmottus.net header.i=@marmottus.net header.b=F1Lkf6lA; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marmottus.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marmottus.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marmottus.net header.i=@marmottus.net header.b="F1Lkf6lA" Received: by mail.gandi.net (Postfix) with ESMTPSA id 7C6453EBCA; Thu, 24 Sep 2026 09:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marmottus.net; s=gm1; t=1790243307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7G/mzknT0LdlsJFiO3EI1X6z4fxbyYMkEyPcMVpFzw=; b=F1Lkf6lAuYcBw8M9acyDJhqD8jg6X/veXpz9i6Dq279RxzU1iPRhIzJ8VHEm3gkpKmlJw3 DObIoRO4/SjHQaPxWhuSPIZoIaVZ/nHWg6Mj7Edgy5qDF8wL++zt1ThAfkQ4cI/xseZXtY NV3TnWns8bp2sRT56YOabJp+4G6GsMKhea15bP4KDVZYDLCGic2m8XRMcrL2ZmNi79KXMO bOvzrM6tRw6sE5C+kOlJt3GYAw/32vtg1X8jnch8VGXCn4//BnIIm+KecMQr0AylMYVqBj Yc28c/qMhcCUhiaGwQGrp4XLNXGzhwLymlzxBxTswE6dtWjJDmrJHmACYem1XQ== From: Arthur Crepin Leblond Date: Thu, 24 Sep 2026 11:48:12 +0200 Subject: [PATCH net-next v11 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-wiznet-link-gpio-v11-2-42a332517b30@marmottus.net> References: <20260924-wiznet-link-gpio-v11-0-42a332517b30@marmottus.net> In-Reply-To: <20260924-wiznet-link-gpio-v11-0-42a332517b30@marmottus.net> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Arnd Bergmann , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Arthur Crepin Leblond X-Mailer: b4 0.15.2 X-GND-Sasl: arthur@marmottus.net X-GND-State: clean X-GND-Score: -100 X-GND-Cause: dmFkZTEjLBf4y4Siu2iwbVH18d6vixFRfFlkBwnrNIfLoSiA6THOUXuxHkCV+kQPJfUtihY6IS07ihrBNpGO3LGviKc8LNOMkRXeypMNfcSrxd/tEVy/2UL7m3p76A2/5L7PXQmchic95PSAdePrNfeZCpoZnndGEQuruoUHGybRCkhO8TFtPAyVI7xG6aVoCvCniKf8YFsF70iaOmF+TacJLIPSipNytlQp6WYWen187J93xlN5AIu6PGrrGVNaOcHto+MJMr/Xgm+ad7VVrUquD2gf85seYuuN0CIVVemdURze1E4QBKtVu8L3+cXcVAAuOhiRsdSlPRqxcMUKOEpSGF/UdNDXuICNMdVUULFtNf/9kEHWirb99j+WFxeFhZ87zmS/YUWMYMdpAs/lfwPQIx3h8yYRFtFKNgz3cojHZuXUx4PERoqJzwSA07Mskgw8TdQ79V5oxwJZ2XXp1KPcViNo3vmiwGIx3aQzD2rGIYT5crMnnxORvQSm/+orhVC0VRzKCQ0nMK0oIHI/ZUIXRA5dIRIJ3qhodDDso+/MxWZkKdkVdUa/KUifrvRF/7rA7XRYijHWbKPKNouh0u5DZy4ASs9VzA1r5qNFcOrw1zy96nW4hCHfJuhAJRJHTkVAbPhbZ/ADP/P/CvMpFb38TJxdz0AeCJGUJmjrz/qDsp3Bwg Add an optional link status interrupt which can be connected to the LINKLED pin on the device to detect link status changes. This second interrupt is only supported on wiznet,w5500. Signed-off-by: Arthur Crepin Leblond --- v9: - Simplify the interrupts description: - Describe the 2 interrupts in the top-level properties - Limit the maximum number to 1 on non-w5500 with a condition - Somehow only adding minItems in the top-level and then describing 2 items in the if block led to dt checks errors. v8: - Remove Krzysztof Kozlowski reviewed-by tag after Sashiko review changes - Make the interrupts property conditional v7: - No changes v6: - Fix DT error: use minItems - Remove conditional properties v5: - Make the DT interrupts property dynamic from the compatible one - Fix DT bindings errors v4: - Update interrupts in DT bindings v3: - Fix DT binding errors v2: - Convert device tree binding to YAML --- .../devicetree/bindings/net/wiznet,w5100.yaml | 34 +++++++++++++++++-= ---- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Docu= mentation/devicetree/bindings/net/wiznet,w5100.yaml index df83f90b3919..b0d1e1d699dc 100644 --- a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml @@ -12,10 +12,6 @@ maintainers: description: | This is a standalone 10/100 MBit Ethernet controller with SPI interface. =20 -allOf: - - $ref: /schemas/net/ethernet-controller.yaml# - - $ref: /schemas/spi/spi-peripheral-props.yaml# - properties: compatible: enum: @@ -24,8 +20,16 @@ properties: - wiznet,w5500 =20 interrupts: - maxItems: 1 - description: Main interrupt (INT pin on the device). + minItems: 1 + description: + The main interrupt (INT pin) is mandatory on all devices. The w5500 + additionally supports an optional second interrupt for link status c= hanges + (LINKLED pin). If it is not specified, link state changes will not be + reported. + items: + - description: Main interrupt (INT pin on the device). + - description: + Optional interrupt for link status changes (LINKLED pin on w5500= ). =20 reg: maxItems: 1 @@ -42,6 +46,21 @@ required: - reg - interrupts =20 +allOf: + - $ref: /schemas/net/ethernet-controller.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + - if: + not: + properties: + compatible: + contains: + enum: + - wiznet,w5500 + then: + properties: + interrupts: + maxItems: 1 + unevaluatedProperties: false =20 examples: @@ -58,7 +77,8 @@ examples: compatible =3D "wiznet,w5500"; reg =3D <0>; interrupt-parent =3D <&gpio>; - interrupts =3D <25 IRQ_TYPE_LEVEL_LOW>; + interrupts =3D <25 IRQ_TYPE_LEVEL_LOW>, + <24 IRQ_TYPE_EDGE_BOTH>; local-mac-address =3D [ a0 b0 c0 d0 e0 f0 ]; pinctrl-0 =3D <ð1_pins>; pinctrl-names =3D "default"; --=20 2.55.0 From nobody Thu Sep 24 12:09:33 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2B03C9EE8; Thu, 24 Sep 2026 09:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790243325; cv=none; b=LQi6Rq1mO9enJ3Xqw67cO/tv7r2R8EvIrWygAd4BUyBGGf89FiEza6nNkXfd+nkt49H/ipypkPpEvfIJ3/D2um3pejWudtNxeZNkriB3TAUltgWspxk4iPxg3VgM5+mriuMu6cfL1m4dqE8dpGeZgdBEIdVP2mNezaaHw3JPVu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790243325; c=relaxed/simple; bh=ABycP1boVD5JnjPirc0mSCFrb1byah1MF5E4GGcraDc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F6w2sjakdJO2U2JrIC3WLOPrq/6EtPOI6Qy7XeFJy3tU1HkmI/vk/9LKGgMV/AhGj64Jq4PMZN/Gr+3rL9a4ef1HeqAmQF7NkOveToh5vnFr6xrJHueonSQ9gbqvy4GjLQi6sRu3UZ+ocMNPfmpfH+BHTmPKXDU+I2aNzMVLOXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marmottus.net; spf=pass smtp.mailfrom=marmottus.net; dkim=pass (2048-bit key) header.d=marmottus.net header.i=@marmottus.net header.b=o32hKqjp; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marmottus.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marmottus.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marmottus.net header.i=@marmottus.net header.b="o32hKqjp" Received: by mail.gandi.net (Postfix) with ESMTPSA id 467663EDFA; Thu, 24 Sep 2026 09:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marmottus.net; s=gm1; t=1790243308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qyvqSEiVR9E2Ts4gxha7eZ8S2YO8UQ5qjLW+fh5J7gw=; b=o32hKqjpF9iXOEv0+YmLIqYzCiGxovv1BuiMtvS5r1NZQDdUA5CLh+7EvlnH+hL3mMQCh8 4WE5Lj3DCnSsrQ2w2q9xRDn+NGSuuSClRyipbdVoQmtPpovVizWHSNe49zFvKhd+58Kx46 NxSJPmb1/ZVCudIcxR2XrPHnqo0G9E9FQ4eBTD454CaVU4pkY8tzFS4oo3rdwE20ZB3IL+ nHiW6REgn72OdFT0/plIRyieQIJeC5QrsLK5/BfZB2bNAXxo1YTRuE7v44u/N0a3yniSkk SLPbt6Isy1mAga/Vrh6hCdieItPAT9Tr7uRf2/sJX1D1UXHFd05ud/oNojjCPg== From: Arthur Crepin Leblond Date: Thu, 24 Sep 2026 11:48:13 +0200 Subject: [PATCH net-next v11 3/3] w5100: detect carrier state using link status bit and optional interrupt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-wiznet-link-gpio-v11-3-42a332517b30@marmottus.net> References: <20260924-wiznet-link-gpio-v11-0-42a332517b30@marmottus.net> In-Reply-To: <20260924-wiznet-link-gpio-v11-0-42a332517b30@marmottus.net> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Arnd Bergmann , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Arthur Crepin Leblond X-Mailer: b4 0.15.2 X-GND-Sasl: arthur@marmottus.net X-GND-State: clean X-GND-Score: -100 X-GND-Cause: dmFkZTEjLBf4y4Siu2iwbVH18d6vixFRfFlkBwnrNIfLoSiA6THOUXuxHkCV+kQPJfUtihY6IS07ihrBNpGO3LGviKc8LNOMkRXeypMNfcSrxd/tEVy/2UL7m3p76A2/5L7PXQmchic95PSAdePrNfeZCpoZnndGEQuruoUHGybRCkhO8TFtPAyVI7xG6aVoCvCniKf8YFsF70iaOmF+TacJLIPSipNytlQp6WYWen187J93xlN5AIu6PGrrGVNaOcHto+MJMr/Xgm+ad7VVrUquD2gf85seYuuN0CIVVemdURze1E4QBKtVu8L3+cXcVAAuOhiRsdSlPRqxcMUKOEpSGF/Ur8QLhHo48pgri6tJD7PBe/ndd/gS87oUqq0vY1jlF0fLm+9lea4GW2U7OmWo4rMA1cRxxyIdV38oxUNlGjtIOH5MJmTD1PJpgAkWq9ZDovNo+Y7vtT7iKs9oRwqsffhrRlE1GNVHXBoDDz4C9gp/ATViXa1aG0/WFVSfGwBzabMRT0zGUVLszTDHN/CPCcIVgSOnIT+XS4pRlFdcmnwbFTgFukLztyWcKaY8nOfiMqCtO37iRyOi7SjrCJhQO4Ec57OBtwh1tK/cdr4SNiTdOIaCi+jAnptHE/nFrnXQHDVo/1RC6us9Z78Z3u5hUjvpD35evrXv39Ao8Y7D5H5rNQ Detect the carrier state on the w5500 Ethernet controller using the Link Status bit from the PHY Configuration register (PHYCFGR). On w5100/w5200, which lack this register, get_link() is not implemented and the carrier state is not reported (netif_carrier_(on|off) is not called). For the w5500, add an optional interrupt, wired to the LINKLED pin of the device, to detect link status changes with a read of the PHYCFGR register and update of the carrier state with netif_carrier_(on|off). If this interrupt is not set in the DT binding, get_link() is not implemented and the carrier state is not reported (netif_carrier_(on|off) is not called). The interrupt handler and the PHYCFGR register readings are synchronized using a mutex. A few changes are also brought for the bring-up/teardown synchronization: - The net device is registered last in the probe() function so no operation can be performed before the probing is finished - The net device is unregistered first in remove() - dev_name is now used instead of netdev_name - w5100_stop() calls cancel_work_sync() and flush_work() to make sure there is no race condition or unfinished work - w5100_suspend() calls w5100_stop() - w5100_resume() calls w5100_open() - The main irq is not automatically enabled in w5100_probe() but in w5100_open() and disabled in w5100_stop() Commit dacf281771a9 ("w5100: remove unused gpio link detection") dropped the link_gpio/link_irq handling on the grounds that no devicetree user passed a "link" gpio at the time and that it used the old gpio interface. This isn't a plain revert of that removal: link detection is now done using a second interrupt rather than a gpio with a documented DT binding. Set the WIZNET entry as DRIVER and add drivers/net/ethernet/wiznet in MAINTAINERS file. Signed-off-by: Arthur Crepin Leblond --- v11: - Fix line over 80 columns - Update commit message - Enable the link irq after reporting the carrier state - Call w5100_hw_close() earlier before cancelling/flushing the queues in w5100_stop() - Call w5100_stop() in w5100_suspend() - Call w5100_open() in w5100_resume() - Issue a reset w5100_open() - Call netif_stop_queue() earlier in w5100_stop() to avoid race condition - Prevent w5100_rx_work() from re-enabling the interrupt - Add a retry mechanism when reading PHYCFGR - Protect netif_device_attach|detach behind a mutex v10: - Address Sashiko review - Always schedule the restart work to avoid atomic context - Move netif_device_detach before disabling irq in w5100_suspend - Flush rx/tx queues in w5100_remove v9: - Address Sashiko review - Rework commit message - Disable the link irq first in w5100_stop() - Call w5100_hw_close earlier in w5100_stop() - Flush rx/tx work and cancel restart in w5100_stop() - Call cancel_work_sync() after unregister_netdev in w5100_remove() - Call cancel_work_sync before netif_carrier_off in w5100_suspend() - Enable/Disable main irq in open()/stop() and suspend()/resume() - Check the number of irqs defined in DT - Ignore fwnode_irq_get errors other than EPROBE_DEFER v8: - Add myself in the MAINTAINERS file - Address Sashiko reviews from online bot and locally run - Add a mutex to synchronize the link state read and interrupt - Return last known carrier state (netif_carrier_ok()) in w5500_get_link on SPI error or if the device is not present - Only set ops .get_link on w5500 - Check the netif state, disable/enable the irq and re-check the carrier state in w5100_restart - Cancel the restart work on stop/suspend - Only set carrier state to off in w5100_stop/suspend when a link irq is present - Warn on fwnode_irq_get errors for the link irq - Free the main irq and flush queues before resetting the hardware in w5100_remove v7: - Address Sashiko reviews - Propagate spi read error to the caller - Do not change the state of the carrier on SPI read error - Enable the link IRQ before reading the PHYCFGR bit - Call unregister_netdev before reset - Update commit message v6: - Revert to the reviewed v4 version by Arnd Bergmann with a few changes based on Sashiko's review - Address Sashiko reviews - call netif_carrier_off in open if there is no link_irq or get_link returns false - call register_netdev at the very end of probe - call unregister_netdev before destroying work queue - handle link irq probe defer error - call netif_device_attach in resume before re enabling the link irq - disable the link irq first in suspend - log netif_err when PHYCFGR cannot be read - enable link irq in open - disable link irq in stop - free irq and invalidate it in remove v5: - Address Sashiko review - Read the link status register only on w5500 instead of checking link_irq - call netif_carrier_off on w5500 link status off in open - enable/disable the link irq in open/stop - enable/disable the link irq in resume/suspend - handle link irq probe defer error - register the netdev last v4: - Use directly an interrupt line instead of gpio -> irq - Address Sashiko reviews - drop devm_ on request_threaded_irq to avoid use after free - disable/enable the link_irq in the suspend/resume - only call netif_carrier_on|off if the link interrupt is present v3: - Use the Link Status bit of the PHY Configuration Register - Use the LINKLED gpio binding for change detection only v2: - Use devm_request_threaded_irq instead of request_any_context_irq - Use devm_gpiod_get_optional instead of gpiod_get_optional - Call dev_err_probe on gpiod_to_irq failure - Remove link_irq from priv - Use a fixed string for the IRQ name - Remove empty new lines --- MAINTAINERS | 3 +- drivers/net/ethernet/wiznet/w5100.c | 234 +++++++++++++++++++++++++++++++-= ---- 2 files changed, 206 insertions(+), 31 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 42acc7bb7bfd..e6028e8e564c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -29451,11 +29451,12 @@ M: Miloslav Trmac S: Maintained F: drivers/input/misc/wistron_btns.c =20 -WIZNET W5100 ETHERNET BINDINGS +WIZNET W5100 ETHERNET DRIVER M: Arthur Crepin Leblond L: netdev@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/net/wiznet,w5100.yaml +F: drivers/net/ethernet/wiznet/ =20 WMI BINARY MOF DRIVER M: Armin Wolf diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiz= net/w5100.c index 53d8dc642fbd..dff39ba8103c 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -18,9 +18,11 @@ #include #include #include +#include #include #include #include +#include #include =20 #include "w5100.h" @@ -124,6 +126,8 @@ MODULE_LICENSE("GPL"); */ #define W5500_SIMR 0x0018 /* Socket Interrupt Mask Register */ #define W5500_RTR 0x0019 /* Retry Time-value Register */ +#define W5500_PHYCFGR 0x002e /* PHY Configuration Register */ +#define PHYCFGR_LNK 0x01 /* Link status */ =20 #define W5500_S0_REGS 0x10000 =20 @@ -154,6 +158,9 @@ struct w5100_priv { u16 s0_rx_buf_size; =20 int irq; + int link_irq; + /* Protects link state and carrier updates */ + struct mutex link_lock; =20 struct napi_struct napi; struct net_device *ndev; @@ -345,6 +352,82 @@ static void w5500_memory_configure(struct w5100_priv *= priv) } } =20 +static int w5500_get_phycfgr_lnk(struct net_device *ndev) +{ + struct w5100_priv *priv =3D netdev_priv(ndev); + int retries =3D 3; + int ret; + + do { + ret =3D w5100_read(priv, W5500_PHYCFGR); + if (ret < 0) + netif_err(priv, link, ndev, + "failed to read link status: %d\n", ret); + } while (ret < 0 && --retries); + + if (ret < 0) + return ret; + + return ret & PHYCFGR_LNK; +} + +static void w5500_report_carrier_state(struct net_device *ndev) +{ + struct w5100_priv *priv =3D netdev_priv(ndev); + int state; + + mutex_lock(&priv->link_lock); + + state =3D w5500_get_phycfgr_lnk(ndev); + if (state > 0) { + netif_info(priv, link, ndev, "link is up\n"); + netif_carrier_on(ndev); + } else if (state =3D=3D 0) { + netif_info(priv, link, ndev, "link is down\n"); + netif_carrier_off(ndev); + } + + mutex_unlock(&priv->link_lock); +} + +static irqreturn_t w5500_detect_link_interrupt(int irq, void *ndev_instanc= e) +{ + struct net_device *ndev =3D ndev_instance; + + if (netif_running(ndev)) + w5500_report_carrier_state(ndev); + + return IRQ_HANDLED; +} + +static u32 w5500_get_link(struct net_device *ndev) +{ + struct w5100_priv *priv =3D netdev_priv(ndev); + int state; + bool link; + + mutex_lock(&priv->link_lock); + + if (!netif_device_present(ndev)) { + link =3D netif_carrier_ok(ndev); + goto out; + } + + state =3D w5500_get_phycfgr_lnk(ndev); + + if (state < 0) { + link =3D netif_carrier_ok(ndev); + goto out; + } + + link =3D state > 0; + +out: + mutex_unlock(&priv->link_lock); + + return link; +} + static int w5100_hw_reset(struct w5100_priv *priv) { u32 rtr; @@ -448,12 +531,28 @@ static void w5100_restart(struct net_device *ndev) { struct w5100_priv *priv =3D netdev_priv(ndev); =20 + if (!netif_running(ndev) || !netif_device_present(ndev)) + return; + + disable_irq(priv->irq); + if (priv->link_irq > 0) + disable_irq(priv->link_irq); + netif_stop_queue(ndev); + w5100_hw_close(priv); + flush_work(&priv->rx_work); + flush_work(&priv->tx_work); w5100_hw_reset(priv); + enable_irq(priv->irq); w5100_hw_start(priv); ndev->stats.tx_errors++; netif_trans_update(ndev); netif_wake_queue(ndev); + + if (priv->link_irq > 0) { + enable_irq(priv->link_irq); + w5500_report_carrier_state(ndev); + } } =20 static void w5100_restart_work(struct work_struct *work) @@ -468,10 +567,7 @@ static void w5100_tx_timeout(struct net_device *ndev, = unsigned int txqueue) { struct w5100_priv *priv =3D netdev_priv(ndev); =20 - if (priv->ops->may_sleep) - schedule_work(&priv->restart_work); - else - w5100_restart(ndev); + schedule_work(&priv->restart_work); } =20 static void w5100_tx_skb(struct net_device *ndev, struct sk_buff *skb) @@ -564,7 +660,8 @@ static void w5100_rx_work(struct work_struct *work) while ((skb =3D w5100_rx_skb(priv->ndev))) netif_rx(skb); =20 - w5100_enable_intr(priv); + if (netif_running(priv->ndev)) + w5100_enable_intr(priv); } =20 static int w5100_napi_poll(struct napi_struct *napi, int budget) @@ -656,9 +753,17 @@ static int w5100_open(struct net_device *ndev) struct w5100_priv *priv =3D netdev_priv(ndev); =20 netif_info(priv, ifup, ndev, "enabling\n"); + w5100_hw_reset(priv); + enable_irq(priv->irq); w5100_hw_start(priv); napi_enable(&priv->napi); netif_start_queue(ndev); + + if (priv->link_irq > 0) { + enable_irq(priv->link_irq); + w5500_report_carrier_state(ndev); + } + return 0; } =20 @@ -667,13 +772,40 @@ static int w5100_stop(struct net_device *ndev) struct w5100_priv *priv =3D netdev_priv(ndev); =20 netif_info(priv, ifdown, ndev, "shutting down\n"); - w5100_hw_close(priv); - netif_carrier_off(ndev); + + disable_irq(priv->irq); + if (priv->link_irq > 0) + disable_irq(priv->link_irq); + netif_stop_queue(ndev); napi_disable(&priv->napi); + + cancel_work_sync(&priv->restart_work); + cancel_work_sync(&priv->setrx_work); + + w5100_hw_close(priv); + + flush_work(&priv->rx_work); + flush_work(&priv->tx_work); + + if (priv->link_irq > 0) { + mutex_lock(&priv->link_lock); + netif_carrier_off(ndev); + mutex_unlock(&priv->link_lock); + } + return 0; } =20 +static const struct ethtool_ops w5500_ethtool_ops =3D { + .get_drvinfo =3D w5100_get_drvinfo, + .get_msglevel =3D w5100_get_msglevel, + .set_msglevel =3D w5100_set_msglevel, + .get_link =3D w5500_get_link, + .get_regs_len =3D w5100_get_regs_len, + .get_regs =3D w5100_get_regs, +}; + static const struct ethtool_ops w5100_ethtool_ops =3D { .get_drvinfo =3D w5100_get_drvinfo, .get_msglevel =3D w5100_get_msglevel, @@ -721,6 +853,8 @@ int w5100_probe(struct device *dev, const struct w5100_= ops *ops, dev_set_drvdata(dev, ndev); priv =3D netdev_priv(ndev); =20 + mutex_init(&priv->link_lock); + switch (ops->chip_id) { case W5100: priv->s0_regs =3D W5100_S0_REGS; @@ -745,15 +879,27 @@ int w5100_probe(struct device *dev, const struct w510= 0_ops *ops, break; default: err =3D -EINVAL; - goto err_register; + goto err_mutex; } =20 priv->ndev =3D ndev; priv->ops =3D ops; priv->irq =3D irq; =20 + priv->link_irq =3D -EINVAL; + if (ops->chip_id =3D=3D W5500) { + priv->link_irq =3D fwnode_irq_get(dev_fwnode(dev), 1); + if (priv->link_irq =3D=3D -EPROBE_DEFER) { + err =3D dev_err_probe(dev, priv->link_irq, + "failed to get link irq\n"); + goto err_mutex; + } + } + ndev->netdev_ops =3D &w5100_netdev_ops; - ndev->ethtool_ops =3D &w5100_ethtool_ops; + ndev->ethtool_ops =3D priv->link_irq > 0 ? &w5500_ethtool_ops : + &w5100_ethtool_ops; + netif_napi_add_weight(ndev, &priv->napi, w5100_napi_poll, 16); =20 /* This chip doesn't support VLAN packets with normal MTU, @@ -761,15 +907,11 @@ int w5100_probe(struct device *dev, const struct w510= 0_ops *ops, */ ndev->features |=3D NETIF_F_VLAN_CHALLENGED; =20 - err =3D register_netdev(ndev); - if (err < 0) - goto err_register; - priv->xfer_wq =3D alloc_workqueue("%s", WQ_MEM_RECLAIM | WQ_PERCPU, 0, - netdev_name(ndev)); + dev_name(dev)); if (!priv->xfer_wq) { err =3D -ENOMEM; - goto err_wq; + goto err_mutex; } =20 INIT_WORK(&priv->rx_work, w5100_rx_work); @@ -794,22 +936,45 @@ int w5100_probe(struct device *dev, const struct w510= 0_ops *ops, =20 if (ops->may_sleep) { err =3D request_threaded_irq(priv->irq, NULL, w5100_interrupt, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - netdev_name(ndev), ndev); + IRQF_TRIGGER_LOW | IRQF_ONESHOT | + IRQF_NO_AUTOEN, + dev_name(dev), ndev); } else { err =3D request_irq(priv->irq, w5100_interrupt, - IRQF_TRIGGER_LOW, netdev_name(ndev), ndev); + IRQF_TRIGGER_LOW | IRQF_NO_AUTOEN, + dev_name(dev), ndev); } if (err) goto err_hw; =20 + if (priv->link_irq > 0) { + err =3D request_threaded_irq(priv->link_irq, NULL, + w5500_detect_link_interrupt, + IRQF_TRIGGER_RISING | + IRQF_TRIGGER_FALLING | + IRQF_ONESHOT | IRQF_NO_AUTOEN, + "w5100-link", ndev); + if (err < 0) + goto err_irq; + + netif_carrier_off(ndev); + } + + err =3D register_netdev(ndev); + if (err < 0) + goto err_link_irq; + return 0; =20 +err_link_irq: + if (priv->link_irq > 0) + free_irq(priv->link_irq, ndev); +err_irq: + free_irq(priv->irq, ndev); err_hw: destroy_workqueue(priv->xfer_wq); -err_wq: - unregister_netdev(ndev); -err_register: +err_mutex: + mutex_destroy(&priv->link_lock); free_netdev(ndev); return err; } @@ -820,14 +985,21 @@ void w5100_remove(struct device *dev) struct net_device *ndev =3D dev_get_drvdata(dev); struct w5100_priv *priv =3D netdev_priv(ndev); =20 - w5100_hw_reset(priv); + unregister_netdev(ndev); + + if (priv->link_irq > 0) + free_irq(priv->link_irq, ndev); free_irq(priv->irq, ndev); =20 - flush_work(&priv->setrx_work); - flush_work(&priv->restart_work); - destroy_workqueue(priv->xfer_wq); + cancel_work_sync(&priv->setrx_work); + cancel_work_sync(&priv->restart_work); + flush_work(&priv->rx_work); + flush_work(&priv->tx_work); =20 - unregister_netdev(ndev); + w5100_hw_reset(priv); + + destroy_workqueue(priv->xfer_wq); + mutex_destroy(&priv->link_lock); free_netdev(ndev); } EXPORT_SYMBOL_GPL(w5100_remove); @@ -839,10 +1011,11 @@ static int w5100_suspend(struct device *dev) struct w5100_priv *priv =3D netdev_priv(ndev); =20 if (netif_running(ndev)) { - netif_carrier_off(ndev); + mutex_lock(&priv->link_lock); netif_device_detach(ndev); + mutex_unlock(&priv->link_lock); =20 - w5100_hw_close(priv); + w5100_stop(ndev); } return 0; } @@ -853,10 +1026,11 @@ static int w5100_resume(struct device *dev) struct w5100_priv *priv =3D netdev_priv(ndev); =20 if (netif_running(ndev)) { - w5100_hw_reset(priv); - w5100_hw_start(priv); + w5100_open(ndev); =20 + mutex_lock(&priv->link_lock); netif_device_attach(ndev); + mutex_unlock(&priv->link_lock); } return 0; } --=20 2.55.0