From nobody Fri Sep 25 05:31:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C320547ECDF for ; Thu, 24 Sep 2026 12:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251642; cv=none; b=ktQZ4Ry/4I0CYmEz1ej+M2qkhP7Og6wc+fhL2d9GvjzRtJLVJg6HfT3D099D1CqFwITTcwvigqPCBCAnim0jkg3K9AT1GyvyZyPdmbXUcPmMtURHKkYmaaC+gY1IkxpR6CBud/Y9Nuul8GcYzngPccBPQKeb4CHY5vqZ4s9IUpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251642; c=relaxed/simple; bh=0fSXr4b+Ztfd2K7iKjW4OpK/vjCYRtqxTfuIJpfY0OE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AywhbAHJEmry4Uu7AHkRLVmbhCTICuA8vYcdFk3yPLIlyNvpEDN/hlBTxDaamPO1Lp16tB0iIa7k9pDEhjjBph/DlEm2PXtiTLR+lrMaKluwTiJCoqYRdjldHvq4c3UHkluTN554t58gDvXt0cGxdJp6nREBaBaVs5OP7dhgUj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bMWlN5vL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f0IGeC7N; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bMWlN5vL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f0IGeC7N" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4Y8f2285544 for ; Thu, 24 Sep 2026 12:07:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A0CH1y/lEg3Q4tkwCwEHIOcuTPB+bNVxl7V4JRcNayM=; b=bMWlN5vLbXMG2MWF awa5PZ4kgqgh7l+y9Ie5R7WnA5DQ+K10w8A56927cH80XzkSp5eUY3L7L4D5AZfD UyIc47jMrTgMm7m+zlNuczRNCaGv+fr8hEgoz4AkOFAvl70jZWH4fiwMPAjSBArr FnFOpO+UIbyA7DwFH+jCbnqDcrxn2zXa7hu5Joe9GkichTwOOtfQS2TsyMSj1rB1 SZ1mFcqGeNoUtL3ynuiPM2fdroG4oTIDEuPsDhMTWTDZXzrXtaLyXWTjtY5Z8/FI gAEAjdfT6LkqAt79wuEv3eTTWeDc1FQFRAWCKd+4Qu+o77g6GFxBdEYr5kSm0+u7 TLq4ww== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvx8ahgj0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:18 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-79013d05471so555962137.1 for ; Thu, 24 Sep 2026 05:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251638; x=1790856438; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A0CH1y/lEg3Q4tkwCwEHIOcuTPB+bNVxl7V4JRcNayM=; b=f0IGeC7NF+jalAWScnXRw42euq6f0mkg4eBrIAbaTvJ2IjLIPNmurZe5s8PGiPM8J5 4r8lcPCaBluU/KxWuFcGIQwPgkuNNi10tAy29eeaogsr1BtQw9x018ZIS7hGC9DV0baZ zCuvbNU0UccPCN2AjzQbi3yAsxsVqPteJWv/O8fmFoF4SbcqXAo87EiSNW9oEFGaYq0K 4niR+VODFr7ervEL6ngKEj6nw7ca4GLbkGxaDumnPcTdgwbcR2TPWQ7ssxrKpNk0Hf7c kxx+lMh6n9eACNBtDlvsZnBE440Txc0VBMv3nuff4cw7X+UfOl8htyozUI2B3FUIs4GX yHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251638; x=1790856438; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A0CH1y/lEg3Q4tkwCwEHIOcuTPB+bNVxl7V4JRcNayM=; b=qEu/O+MKW4l4dSY4da4csUlAHcqhL1k4atuBSuifACDtx0vcrGdJQededp/z3aMPN7 f0zxq4CVMqKtruYPcxQ1kzJDNtgsZ8eDx/7eX7gMba2A6cAqIqeUV/Arj4s+HPFsnK/0 C5c6dtjsHAlzic0ewtHR/+CyO9fQCy42fIO5umA5C4lNGy8xe0zDzWhp59nW0ZkDg3b/ qpd+tFLUrlcWs1GZpxynPzI0976Xf+JJGSbh6myHc48WBN4xaf/xT7M511TRPlRwF8LU jnyf7LSc7JkRrWqan+FXWFncpO3YGUdv/u+vef1xw39zLctmG5Nfh6zo5DQCMi2BrmaU /rWA== X-Forwarded-Encrypted: i=1; AKwUvBwBoa5FKqXCUcvhK1dsMMDORpojDS88t6afwQFMyeWJPkKaTV2J4x+Bd9AVRAYPoxjEscNEvHpd+xGfyhA=@vger.kernel.org X-Gm-Message-State: AFuF++lgZ80HNGUWzqDN8tz/FDFYfXqWfHZx+c/B3+srSAunadMgIvnj 1D5GjimAGeGWSfd9hwi5XikdGSGeTCaLDcX3D1F8xnbAJ50UXqiTd4FlIO9rlmk5cooTBScBzTw HyCWnSRJzf/xeOz0hVOBXbFxZmynYX3lAQiBcon6lNls2l8CagLCFaWGs5r/Qb69OyGg= X-Gm-Gg: AYBFou20s+0fZN4xEsSG5cuWpytQUbnKG8Pqyt9S0aYHbXsXo7fNo3kvQlHhzgHaNYO paclT7P4cntJEHbgpfMH6gFD+CnPdFQPJ0JaZWkxco/WdFjLpa1Vy0Hac4mC/gQHLhjTUK4aqfJ C3YvQN2zIocXGmcPoqlHtpxJEUpDRp9j3E1DngXKlLuxinWftT8k3JHVNjKgxJEMq5hujczKwrn ae/2pQGAgYEfsAoVVQEkvErB8iRyGvHw1z/59SJAkj9+XyEEqcCsc8kE0yh+3r2KDMxfMUgnCun hw7nGAw87Gpv8LQ+6nmxXu4A//yew+P0zus1hHV13dzQGYK8fHSvd1+1QjjhnfFn1x5FKNnjIzh jJchBETKW X-Received: by 2002:a05:6102:5344:b0:7a1:f7d2:e831 with SMTP id ada2fe7eead31-7af1d4bbe21mr907583137.17.1790251637817; Thu, 24 Sep 2026 05:07:17 -0700 (PDT) X-Received: by 2002:a05:6102:5344:b0:7a1:f7d2:e831 with SMTP id ada2fe7eead31-7af1d4bbe21mr907565137.17.1790251637177; Thu, 24 Sep 2026 05:07:17 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:15 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:13 +0300 Subject: [PATCH v2 01/48] clk: qcom: camcc-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-1-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3088; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=0fSXr4b+Ztfd2K7iKjW4OpK/vjCYRtqxTfuIJpfY0OE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJCRYr3Wwy4NAWEYeTIzSiE8cz7r00/8LUhz zslueJPu0+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSQgAKCRAbX0TJAJUV Vv3pD/kBnr+PrtFVwupmgHnQww9oqbZzTSjENLc0rv27gSdLYVL3XWPYGwqvugGozZiIg8cOZJc OFTqLhjYXDU17iUVFjBScc9AID1YKmoPpVsude2GKHZQxXojjqlFOZQ271ISfYLvsjQmM37ceiq lwp7EgQgN/G0pofYC3F3EcMI7wKSGCYHk3ySvpfFrkE/jr0hQn0OH/cXASoojXuPDEVlwtd3RxK 32EunynxPvrrvboAZrCK3okFTDCcpGnIUkOEnqIHypDlg2lpR03AY9w+L26yeSKtWbkwt8XpRjG 10XISCiPaewT+W0mTaVwxzY5enyL1XGK41rpa15b/E/1zV80Qx46+H7GIpRYMyIbXkvz/5oCkUA w8UMaFsCO6TuFRDedN27izQ0WhqmS20B/H7FytvEt14WvHOSyiAoL7qvMZLq0HG3BKJ9qJWhpAV CUmUWSBxAVC7Ubqqma2mkPwRcPbIku1jtYyDYb4V0jUWmYJszfjlpk41bLIc3dv+NbwH+pYLpjR ByBydIisnnZPRcj66kNr448M/XEaTO/GtBimRxNc4Rt9GWqZUo5DorPp5vrOSQgDI/u3IbFPbLA 9Qces79dZLSkCyUKGSXJ5Ghxs1Tm6F8wQuhQstNdSFFRVL82ymZHD+z+kAEcvEaukozaEIPRPHZ BtDvzyRRViSbq0w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX9SDWWMFOuAfC zGWUWMOEFJsVDraN2AKxKf/u33x/HHyCRq18YJmvCWmKY2C4Zmvi5/T8UseXoq9aLc8ZOeQTWT8 K9NpReMVIR7y0afMoZIcgyDHcUAo9Zw= X-Proofpoint-ORIG-GUID: 5p0Q_Jl1C9r8TYGsby_66mRQjEazxxNd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXyrDSI7Ee9zxL bfIUMkVpSYk3obsh5sLEJNxujSWsViy0EpS6WUuiyLhX/xab/J9tZ6JhRPCssulI68pGySV32WG ExdPTzt+Qt1WplxlzZbyr4BwO6EvNPXQy3IZrhWo799fMHtGl6tM2bjkgNX8H4ef4uPljymCrS1 97thLiK+pEFxDyuDjn9YfIt3WExEmz1xFeVezYKxTqCdfVEgfllSpXIqKTW9fHraK3gCoUcvj2z v4exuBNbs/T58oZe4ASvJVi6eCDgdn6oLd4sw08webYteepEq0ARiOW8Aq/Dnw9TglPtOYo2LIh 6qWDUcosmlfyyswoX+3yiHgMxuCmT9u3DhmDxtkECYHtMPNJHvCiPVF/9YD7bUnhEnudtArpwUh 6cdwBFU2rD7nRCHUQXG9lEi/P3whFLKnI46FXiH+KI0lxiXGL9g05bwasspt9YRadfUNfKnRrsD anDIninbmeueJpwz7QQ== X-Authority-Analysis: v=2.4 cv=a6SlZkSF c=1 sm=1 tr=0 ts=6ab51276 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=8Nt88UfW2CkDv28g5HoA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-GUID: 5p0Q_Jl1C9r8TYGsby_66mRQjEazxxNd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Keep separate CBCR arrays for SA8775P and QCS8300 to preserve their different CAMNOC XO, GDSC and sleep clock register offsets. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/camcc-sa8775p.c | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/clk/qcom/camcc-sa8775p.c b/drivers/clk/qcom/camcc-sa87= 75p.c index 914478139e97..b0a8f0077dd8 100644 --- a/drivers/clk/qcom/camcc-sa8775p.c +++ b/drivers/clk/qcom/camcc-sa8775p.c @@ -1818,7 +1818,30 @@ static const struct regmap_config cam_cc_sa8775p_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 cam_cc_sa8775p_critical_cbcrs[] =3D { + 0x13194, /* CAM_CC_CAMNOC_XO_CLK */ + 0x131ec, /* CAM_CC_GDSC_CLK */ + 0x13208, /* CAM_CC_SLEEP_CLK */ +}; + +static const u32 cam_cc_qcs8300_critical_cbcrs[] =3D { + 0x13178, /* CAM_CC_CAMNOC_XO_CLK */ + 0x131d0, /* CAM_CC_GDSC_CLK */ + 0x131ec, /* CAM_CC_SLEEP_CLK */ +}; + +static const struct qcom_cc_driver_data cam_cc_sa8775p_driver_data =3D { + .clk_cbcrs =3D cam_cc_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(cam_cc_sa8775p_critical_cbcrs), +}; + +static const struct qcom_cc_driver_data cam_cc_qcs8300_driver_data =3D { + .clk_cbcrs =3D cam_cc_qcs8300_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(cam_cc_qcs8300_critical_cbcrs), +}; + static const struct qcom_cc_desc cam_cc_sa8775p_desc =3D { + .driver_data =3D &cam_cc_sa8775p_driver_data, .config =3D &cam_cc_sa8775p_regmap_config, .clks =3D cam_cc_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(cam_cc_sa8775p_clocks), @@ -1837,6 +1860,7 @@ MODULE_DEVICE_TABLE(of, cam_cc_sa8775p_match_table); =20 static int cam_cc_sa8775p_probe(struct platform_device *pdev) { + struct qcom_cc_desc desc =3D cam_cc_sa8775p_desc; struct regmap *regmap; int ret; =20 @@ -1927,18 +1951,10 @@ static int cam_cc_sa8775p_probe(struct platform_dev= ice *pdev) cam_cc_sa8775p_clocks[CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK] =3D &cam_cc_titan_top_accu_shift_clk.clkr; =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x13178); /* CAM_CC_CAMNOC_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x131d0); /* CAM_CC_GDSC_CLK */ - qcom_branch_set_clk_en(regmap, 0x131ec); /* CAM_CC_SLEEP_CLK */ - } else { - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x13194); /* CAM_CC_CAMNOC_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x131ec); /* CAM_CC_GDSC_CLK */ - qcom_branch_set_clk_en(regmap, 0x13208); /* CAM_CC_SLEEP_CLK */ + desc.driver_data =3D &cam_cc_qcs8300_driver_data; } =20 - ret =3D qcom_cc_really_probe(&pdev->dev, &cam_cc_sa8775p_desc, regmap); + ret =3D qcom_cc_really_probe(&pdev->dev, &desc, regmap); =20 pm_runtime_put(&pdev->dev); =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 537F147F77C for ; Thu, 24 Sep 2026 12:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251645; cv=none; b=a3HboT6S5gMskRk0Jhlu8cBctORJ1GrQjZkKkg0m71x6vIpdEprEWNxlv0niwba4MYMZCwoeS4gJQqOzALZeJV62cQWA7rbFTkGwFvWbDh6t8YHS5SR4FSsPS1aiVZctEdw37/hrFfiIoboyEtUPwV++g/XdsTGIxBw1Jqh9/Ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251645; c=relaxed/simple; bh=NpFkNyaRbbIy280UOhuPcTN0madFk6MFT8lDT1uMuJU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AEeLm0DneFmOJhTMvf+x8ByVNRcXPyi7gUSz4lzrXvYgrFrr4erVlnsoySdx5kHQrgXtufbCh+yeBxp1tt1Q2nsvwzShRF4qyIOussw46/wkBWRsSgPzV2PEG+ZcgijHsB+3ombPMMmlNnXCHJs2W+MZFNZYLG16/JRmY1MrRE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OsGKGps0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KkL4hDqV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OsGKGps0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KkL4hDqV" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4nor2002260 for ; Thu, 24 Sep 2026 12:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s3xokX7bYOscGmP2T43FyhKVF0zRdoQlxD+Kd+fGdic=; b=OsGKGps0ryiTRV/y +x3hPmAABB/TDjHkYngV+f+EjSfTYybHvqNsvRGmVU2hxFaO4QbM+cOGMBRY/0fn koKYISoQt7Xqq4YU/qN22eU9C1j/5zA2zuIeeImNbFs44ShSmN+7KEH4HKEdLS67 cFzFCnfL5Wk0dVz4k5RgDrbg0w7re/mT+VsP2Ld5R4/6IZjF+VwCOkHYCh4oVEkY ZnNB6sqxX0DqTVNmcM/aeszxzt8li/qimcyfBJeTt2y7GQFTtFvjGZvr0fwXg/+Y +XqINF3nEIUTyWHfgHeLPhiHivMgIuHncLzxlZ0bC6ckBAVaJdEgVct/0ulyPud8 TKMiJQ== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvmrrbebu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:21 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5c683ca769dso782795e0c.2 for ; Thu, 24 Sep 2026 05:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251640; x=1790856440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s3xokX7bYOscGmP2T43FyhKVF0zRdoQlxD+Kd+fGdic=; b=KkL4hDqVFBoD4giB81HoXsRnpNxfoDp5JF6El/h1nziandtOH78AGrOTxjcfAGWOym CnF+f9reHdVlxK7HFqUtg1xHVymQIx8WXO4FiM8wCNdeCCQlzGGBSL2+9Oika+AsUjIx s9+xyeaOuS5b5TETFPJsre/Q1hJqQ1K6XVmMeoJjkoXLouZR3alIthnWA9nJRrkFWHUV /0Jz2ycnwQc3nq0Vqf3dz6xmBm83TlbUN4A+9dyo5qfkzJYFpcsQCLEsg+tELT/qu6/7 U4L5ZDcq+Fqjx4Hvct+5J5oWMhKx/Dbqr1TknSRt1bZn5JWK/Z9ifyu9Sd2KLkUjOsi2 h2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251640; x=1790856440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s3xokX7bYOscGmP2T43FyhKVF0zRdoQlxD+Kd+fGdic=; b=D+3DcxIKqpngxmrJmvN5bXZgY7lHsvBWgczHqO1UZC959432aclv2dukYms0M+Ysmd fP83E4Dir5gr7bRIr2MhjIYNR59Qps9BAHrqB9lhV9wZ+mtKsE93Y7RvLcN5DSGi3+v1 ++lf8MrQNf3PfjGeRrdY17K1ReeaDQbhBj05klNtdwCh3MNjitpvWEnrc+oyZoN4fYnp IlaCN9jSYe/q2kM+K21ub2OVb+3inbfF+ZtKRfNuIvKIqgZmzRwNbYZyydzCFUV4REkK iVf0QCSK3ta1cPvowo87EGvznMux4rS+2wAVyU05rM8J/wB+KK2uZaD4ABPm2VhCTurE ZT4A== X-Forwarded-Encrypted: i=1; AKwUvBwE1wmtro2zfVoDHOug/ISlA/HwEEHN790tydPAbAIeL58MBa5Z8wzp7Jr3cBfWddMNvZziluUQsWnVUX8=@vger.kernel.org X-Gm-Message-State: AFuF++k0Vn5+Uj918sS2k++zEFbiHvf72ShtpJi6rCwvbbYIRQ7m2w/s G5i+Cia7m+oFU5FqH3ODN0M/U/e9xtC4GvfQtOcF9oLoZusIpqmxOG+E06G3/pa+rhYspH+2V0D AKxhyCZGDx0O/lr8J7hq78oMJEkUx5XuPxPRcX6ylrRrEl1UCltrI/1gWTKbRWX3nVZ8= X-Gm-Gg: AYBFou1TchWLQJVJ6WA1/7bTQQkGhQvYVIc+IygqwMx1d+RzwkgSxoCHCz/JxVGB4NZ /vvLgqTmNLSgD4Km1xcJ8LFdm8CEITi5M3BeAMUnL/5C0wiO9el+eLQqKD3CPih5QxhBFjRB4j3 /n4VMnKCaNIoVrj+8aUaLYKYgRfsq9QgLcVSM1oD3/OegFl4fpOiv0GE+uIlh4FEBBlytpU9EXg YqWvkiQj9rueZWH3tIHhnnPAbPLG6MBmZoR57V4K8DfAvvYRaLDPEweLPuOuvW/hNX+iWrnjn4O POVMQ/STnQ7nKSVXWSDRb+W6mQpVVJySm+K5jUVVjakt4Y2/LM7lFmW29O9Z1dY6Vfoem+aHQhl mgbfMcbhD X-Received: by 2002:a05:6102:809c:b0:785:d308:cc0a with SMTP id ada2fe7eead31-7af1cb95fe7mr988525137.9.1790251640015; Thu, 24 Sep 2026 05:07:20 -0700 (PDT) X-Received: by 2002:a05:6102:809c:b0:785:d308:cc0a with SMTP id ada2fe7eead31-7af1cb95fe7mr988503137.9.1790251639207; Thu, 24 Sep 2026 05:07:19 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:18 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:14 +0300 Subject: [PATCH v2 02/48] clk: qcom: camcc-sc8280xp: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-2-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1762; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=NpFkNyaRbbIy280UOhuPcTN0madFk6MFT8lDT1uMuJU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJDviHCd8d2Wl0zsmJ43z1grFM1K0ReEkSLE R4Oa2tfICWJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSQwAKCRAbX0TJAJUV VqYND/91zMoxaVm+CApRhC6UXiZR2fhnE4v1zlw5NDL/AjCH5pMLBgd2PPvqA7C+ozlwOefiCxm JQpYGRhz33qBUUQgyNwDNfJJUxKl2Vsps69fjUDvkmLt7kKT6/91kCNDE0+yCwMl7tS5aLPQUu7 npOsNdxwddyEzRHKlw9akX3MPXHa8OOcoRawSF5s9SwiRiS23RDAlhY1J277KYhlCI1VaLrI7Hm ftzymt6jbJ45Haa6O8gY0AQVXLKIp/PdEN675zNVyfLhI8ejEXMm+u4E8ZD2b7dvEQrQIDHl/Jv m2Pfwd4QNnvnZAG/dCoDECHrF9RTlyCPoaEu5ZwICYE+nDBy/KPTxTFNDqlKXbyJ9P45hSUoRMU LzdvIvYHFsyIZjm3KcN/fZtDK7d1yZcDCUPfZ0ib2JDQtn/gk5OouYmprBbl1rhUr90Bp8RHHtN Im3AW59LcbIu3A7UIEIb675dhdxqxHZpFrgZZiXs1+y7xq5EKKBRlbGww0+LilO0rwh7azF9nnD n2T65iub2EMwmj+R7q+Bvpom8L5WBQpfCJO/13yUqJWxV1xnxFFPCSlx9opNi8xVHjFCtX+6++z wOr2QtQvhe/QU54DJjDen2pOK0ov/8sOHgVk7UhFE886RM+PLuor8yO1EXdwFQUlIUY4D+nFmVU hr7UVhaCZmgMJ+A== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXzx7ris0QLx0C 0O63GgadVPhnkdSm1dDJbp7ePODlsXqzcynVRdkqGQS4vWOhG5L+qVCR5GGR130Eo6txETKCdtn 8jAfeeYS8wcC2Nc412FMPZbxjtK3QpUVJt7qH6XSUH4dvWQUJo8V2FbU/+yvnvoTbKVjxA6vWgV Sd74batMMpBYb3YtHG1BgwaIOmv2tM6tF+PXlNBGGI5I0VI8OlZwlGGCUlit8qZsHQgbab+09St 3dvRgY1rrjRxrW40LzqYFWaquNZMlXaclJ2QqiMGbdYhIxASZyvfQevTLuFVixO8UJR00wfrFYp bf39VlbzhTrGeFi7gR3/WSS2aRc887aq7ogRUC6EwU5nNWUGxXlxjlWJ1VdGyjSGHG9O8VUEXMa CRT4wlsTEQLzUWOqJVI6maawJgk3ydhSXykB8gYI2rk073YBkp7+fNuDzuPDeOZvZaGP2sSG4a4 WuGJK06agtbeyO93zPQ== X-Authority-Analysis: v=2.4 cv=TYwDJhQh c=1 sm=1 tr=0 ts=6ab51279 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=rrqsg2U6P9VQxLjfjP8A:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX1Y9WwoVTeyuh WkYQhU3gYGa8mJzA6+F5GVrS62PClsHu/tiXbdxcVmp+o3v0ZGEv7iofQxcHPVFjDo3JGrEbkD4 +qvlamfqk3stECfmGQfOLNNM4OFgBfE= X-Proofpoint-GUID: sNngBZvQVvNf4O9NC_y4Xu3Fjmi3GISB X-Proofpoint-ORIG-GUID: sNngBZvQVvNf4O9NC_y4Xu3Fjmi3GISB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/camcc-sc8280xp.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8= 280xp.c index 660d8655d391..b0f1d40d1df5 100644 --- a/drivers/clk/qcom/camcc-sc8280xp.c +++ b/drivers/clk/qcom/camcc-sc8280xp.c @@ -2967,7 +2967,17 @@ static const struct regmap_config camcc_sc8280xp_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 camcc_sc8280xp_critical_cbcrs[] =3D { + 0xc1e4, /* CAMCC_GDSC_CLK */ +}; + +static const struct qcom_cc_driver_data camcc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D camcc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(camcc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc camcc_sc8280xp_desc =3D { + .driver_data =3D &camcc_sc8280xp_driver_data, .config =3D &camcc_sc8280xp_regmap_config, .clks =3D camcc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(camcc_sc8280xp_clocks), @@ -3011,9 +3021,6 @@ static int camcc_sc8280xp_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&camcc_pll6, regmap, &camcc_pll6_config); clk_lucid_pll_configure(&camcc_pll7, regmap, &camcc_pll7_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xc1e4); /* CAMCC_GDSC_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &camcc_sc8280xp_desc, regmap); if (ret) goto err_disable; --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E754D47F2E0 for ; Thu, 24 Sep 2026 12:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251646; cv=none; b=VpUyWQX+ecoCo2Z5z2HZ2z0TE4DallBrWxTtxaXoq0CVdMV1KIr7Or7mDhdvt684nREt9M/nAYZPR+SYB+oyNJLX7BpA9LQEIWJgyol0Rka0ZAvh+sEzXo2OHObXUwnu1U6e1VUPKlkrT4Oo5Whr0TPkvcliyxp/bzTM+whbRpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251646; c=relaxed/simple; bh=v1pGxf9FSj6EcY/jRQeCq2h/np56qNWjuwxxawoik1g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ry/UHvSphdAeoQTJyhMSiTdcByHG0/V6jephQJLvV8D7uGyvV+PI3+tFH2iGyfALpHKl22Qs9ty0B858qfq11odWasorqIah9Z64hbGHov8aNV0xqE9ub9maamLXeZVrNRZpT+AQGpt69Fuy8kQeDiXs/htu5K1+QJB6k7A9Ej4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MFmjiHMO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d7yyC1oN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MFmjiHMO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d7yyC1oN" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4fjh1437115 for ; Thu, 24 Sep 2026 12:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yzvOQFBfkoc1WRuxGRe2PsRk56gNER9w//BYPCZKxjM=; b=MFmjiHMOQbiA+HmK 11l+93LsV+6DokzVIrrMGp6/40Qn3Ub67Zp5hDGNsy88GRBwf4ABq9SjRfYYh9NN UCeTFuIQ4mZ8g9m1bfCRHns2R3B0YPACAqYIO2K7MqKZg7OY9tw6SBu6bMOuMtgl UxG+4Zt17E508AvKGu4q6fiymW9TEH9lIpfIJvbtPQgBP1NR64GzF+c/ev5hPmXj 1nh5FEkT2Cz1eHqxlvhSX3Ndt+GXXHJd9dOD1v/bePtnmiUmHgifRcWd9s9M1aAP nfFAKha5vUkdo7uWN6nWZ7jbTYLS1azF6HsPVzWkTCQAABJazp+xD7YiWDEhBk2m f+9uyg== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1t7remx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:22 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-78a58df134aso566072137.2 for ; Thu, 24 Sep 2026 05:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251642; x=1790856442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yzvOQFBfkoc1WRuxGRe2PsRk56gNER9w//BYPCZKxjM=; b=d7yyC1oNQw9yu7Aai1iZ3vUuabJBF+DyWDoBSjr3ecss8phKZ3OGfhgW1+BeIMFfcT Bz5rsCAoibWuJ+QdYsgqep8apPqY4LBljVBxH/iqwHNc7WJCWk6t1/MwYSwMiOMDraw4 kVaoaixV3ieD6F8KcyAH6UIoMcEssEDPN6EH79Ss0HaEHqsQlTHutDpOEcvgD1dCUT6j 7VFfDfHsaTl0cDbQKqFovKk2YxhhMtf3KyhWLYgiRqjS9M4VHyVBUmmkf+Tvv8hPF13C Nu1LqYUlLrMquEkr7/lsF6KKvyHFSBaC+MQdXTNegfyVAmMmgwWfANHE/YJb3Ao01AE1 w0/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251642; x=1790856442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yzvOQFBfkoc1WRuxGRe2PsRk56gNER9w//BYPCZKxjM=; b=lgotK/hx16eUtb8nrzA/X60umsqZzq5/4CaPm4BQOCNuWr+/GKzWhZSlNF5+3gTlWA muozM2fmWl/BJGLx8LSlUqppKDs3xJNcgN/9yvWjXXTeBx04O6VCxxJvMxxT7WgBllY7 Pev5+DJvvexzWyQiu2nbBOFGgIwGNu75sFyQ98WllSl39R2aNopUhK3Chv3VnM+siBkR JEtmD1NSYPmm2MhlC4i+OsxmnqsZZE1uLgwPvtpISPSnsNVdSz9KAt72GIqMzxvOfTHg /y7jRdmv1/jiFw23fcPwU9zp6M67eaBJPk7olAQI9Abz84S2il28rqVRMDg6ACDkF4Nz W5TQ== X-Forwarded-Encrypted: i=1; AKwUvBxloIT2oKJCopsNfEz1V4zKraHTPuEyeGs6nPbnnNy7vMyehOS1tVuAXc8dI9wj6ur3UFQ7eDY5u0C4rFA=@vger.kernel.org X-Gm-Message-State: AFuF++koJ9TGeNtv4MPJ0SYg0dUt7bcDl+SrRYoK/NRSlINwbu7UoqB3 oklfB09+FoBL3yqFfqS4XZxDgsYAyBMyi8cn2vIE21DxJ6L+SWFm3JdFKZKpd1qsk6q/T456i8v BoJqX7dCGN+FSKtvRvcFdk+bEREE7jd8GFTixwQp94yvykxAfR4zhL2u1/HpW5Z/dT10= X-Gm-Gg: AYBFou0VMYZk/efqrSK8zJWpPdGfetlIBtRcFAiJvHz3FkpROivnzsR6PKHFYX7QOnD UmF2RnBYHSvkgSX6/kNyTeVrbvD5Sqv0g2OkZt6mxJ8DQRn5ZIa3TXgF914m8lmtRa3EBbkuPz9 jqNVS0iL8rdydda63MHkX+PjQXGHlJhBGLjDVywynPLJs+nqoNYxoE2z++Dr4Y+aMrJDeOM7K/+ yZwi9+koTRadgWbG+sl3Iz9BBuTQrrLNHjPks7ON9v3hNWHPTr8CLGS0DMZdNsf/0GcKS0F4sb6 E4YZoP6/U7sTz4tJnIMASfwZHYzdUie7uclJwDe534PDfn5eDSUEuxtthDpYndZ15WkZ9+PDmaw FZW53lbf3 X-Received: by 2002:a05:6102:f12:b0:7a5:d652:2e3c with SMTP id ada2fe7eead31-7af1cfa48e8mr1047091137.9.1790251641568; Thu, 24 Sep 2026 05:07:21 -0700 (PDT) X-Received: by 2002:a05:6102:f12:b0:7a5:d652:2e3c with SMTP id ada2fe7eead31-7af1cfa48e8mr1047069137.9.1790251640865; Thu, 24 Sep 2026 05:07:20 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:20 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:15 +0300 Subject: [PATCH v2 03/48] clk: qcom: camcc-sm7150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-3-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1702; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=v1pGxf9FSj6EcY/jRQeCq2h/np56qNWjuwxxawoik1g=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJEaVe6/7hOSCN1YJ4e1OfX2rd56m1w9OCcS b8lV3ZLgoCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSRAAKCRAbX0TJAJUV VhVMEACDqSy2pN3912CK9dxGARu2jVvFxiS5zUiHHm3+bNiE7O9O+qs1XtGdZEKSnGRjaZvO3sk uKEhJj8ifq0mw5SknT+TV8mgZRIO+dYXIPFIa9NJpa3oW7iCobMram64QowCfiwN9DN6HxzEPgV 4lY1wxYOp0IkPlVV05n3LnQHLEutSQ6JBlb0/UcLXFQlwhWI5FSOVjw+1Vpwri3C6bzK2RCKff8 IBvR9bchD5bX/+BepMEopeZFfXIhs7R4yBc1ZDE8Oh8/Q3jRYVPOgPewhoSlL2cnxVd5KFgyrdq XkT7nxbtTbTT1C2i8S2apJCKQANlE02w0uaK7NM+edD1GEkh/8xnXO11ZliK4W3rAJRTMVwk2kQ /F+RIKU2jw/pDhAUUQxlhTIY+SiOFnjZVYn6S8211yBWaVXcputtofI+VEKmmtbai+fjFty277E 57K9lfcnLrhIrNLeKYXYHZSwhVsMThGBa2Fhaep2QVnr/tZoeHZlpmWQbw7Ql+Pu5bvJi/6MJQj j3f9kFtK4+3WXwlv2Z8HUkR0nOqJo7rDAwf+zDOrnQO3ibtbJzdznz43Pp2lPLG0+kIS/AAp/Q5 1YPgNvZojack6ZxvCKYnzYwHOMBu+ugozkkt7hwfEN4QNu6/RE/xydXGwq4nsxzvCz+DHMiLMKK 9foGfDrabuw0c6A== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: Qs9oWOj-9cE5b74eemYuhocGzyUz93kS X-Authority-Analysis: v=2.4 cv=U/MHnuru c=1 sm=1 tr=0 ts=6ab5127a cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=bQTroZZgG8CJslzDRBIA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX6uH6FZODM+Jr yNl0BVNe0tD6+rwgp1TzNlcBqsYaoxZ0yCJ7z7unOcUT3J0FaVR0l+fm2X2PuIZ1mT74KY01R9j N8G1PVnq/LpO7sroMZd34cNiAqUspEUMEC8WALcKpvNnjiGurvjINcddfld/FQJK+Ipf2dSYW4d 6vnMJFZU8RYQIaOPTER6aGAr1/63dkgVeYFkUqgG4aaY3WMZyjo+QZAC5qLellyk/6jmdnwPjQB hYGA4/YKMYg2ib4FQs6dbZL+RXHL9KhrKyeFarKKVcw5bBCKXKLxSobQ6K8YKHHxMv9sMbBzdNy HKRODqRpO8RPkZMkJaQnTfzjCe5BD8SySCPHFFNY/9zeYnH+fyjlhmfWGNOqJ7+JN0VvyS6OHOz 3G1ekxyY+CR6ipByiIecKKNDQfWKMREUMpm5DmxDOwZImJ3441RvbwVjngIHOY7KeixujfSJgaH vjtYocMP1lvn91VvLkw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7t8wLar86hw4 g+QvTo1fyvAfKpLp5byZcpb+7a4+RkBz7pI2GZK1gXQU3oG8z+JqCWv0UjhGlBP4VkPJlvhmMjZ t/a+tZ2P/+dVliuNEiOGJjYehq3m9yE= X-Proofpoint-ORIG-GUID: Qs9oWOj-9cE5b74eemYuhocGzyUz93kS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/camcc-sm7150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/camcc-sm7150.c b/drivers/clk/qcom/camcc-sm715= 0.c index 6f75689e9847..d06258327ba7 100644 --- a/drivers/clk/qcom/camcc-sm7150.c +++ b/drivers/clk/qcom/camcc-sm7150.c @@ -2008,7 +2008,17 @@ static const struct regmap_config camcc_sm7150_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 camcc_sm7150_critical_cbcrs[] =3D { + 0xc1a0, /* CAMCC_GDSC_CLK */ +}; + +static const struct qcom_cc_driver_data camcc_sm7150_driver_data =3D { + .clk_cbcrs =3D camcc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(camcc_sm7150_critical_cbcrs), +}; + static const struct qcom_cc_desc camcc_sm7150_desc =3D { + .driver_data =3D &camcc_sm7150_driver_data, .config =3D &camcc_sm7150_regmap_config, .clk_hws =3D camcc_sm7150_hws, .num_clk_hws =3D ARRAY_SIZE(camcc_sm7150_hws), @@ -2038,9 +2048,6 @@ static int camcc_sm7150_probe(struct platform_device = *pdev) clk_fabia_pll_configure(&camcc_pll3, regmap, &camcc_pll3_config); clk_fabia_pll_configure(&camcc_pll4, regmap, &camcc_pll3_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xc1a0); /* CAMCC_GDSC_CLK */ - return qcom_cc_really_probe(&pdev->dev, &camcc_sm7150_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 498FA47FB0E for ; Thu, 24 Sep 2026 12:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251648; cv=none; b=Ye8NzLa3Ntkb7f80tXVGoVBqsOd5WLIqbS+2Zxp0jrxEVME05UewdRRKqyQdErK6BQxyrppGLJYcBVwL9yXXJLU4f+GE9/TLCHI4F3nj8MNSXCtc5hN5BHXIGoN1lJwB9xR+i8MG8C1f/aX/T24lp6tyz1o5dqKqJEuRDdAeKos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251648; c=relaxed/simple; bh=1aJTQR0dA/sog7qGkyQAgO7NJrtOYUMQUHZCG6mJu70=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uNmt5bT6lbERP02PCJio8WOeYnGz62moOk519ka/J7S6zMUvmc3B6yGML/RQh51rBosltVXA88cTUvcNFMk44GS0g5zP+9uEQFxmlalP5ZGnBdg7yvVsuMDzOdeLjFC60tGWD64/rZKfsdB1oKHJ3V7fm5ZECNOfnlI6TgKG2uc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bcWt3mEM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WNdchNGm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bcWt3mEM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WNdchNGm" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4kjq2385712 for ; Thu, 24 Sep 2026 12:07:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gyh5akvvyyTi7Yve0fYdrjayBHbVCsrQbVTODnYGB5o=; b=bcWt3mEM36QoZyH4 h2WTHRQlBDaiDWbRAUpngPfZl8MsoOnfQgKft1WTHQYfaJwSTOW6o6H8Qst7mwAm e3VbFoBqQsnm/yY4hl6oXdGMkseqyGol+0dj0yz2R3bYq5RShu5ITxRMK4nKDZ6x b9vtikJHwuZxaQkO9Fil/Gtsai81bOW10GpTlMCMfSSbI7Q3Y59EpHBmdGqfz2N/ 3akWvrMWnao5ofrYLacjspOOwc1ugGdJRr0V6KfVKha6FLYvYtIgJBhx9w8WNkGB qFrsybytfXUErJw5Jjh5nE1mExRBkw76hDLRada2DprKMVLneOJHsHWqMLSkER5t vyVkyg== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvsfgtcjd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:24 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-97c7e1d8bbeso338932241.1 for ; Thu, 24 Sep 2026 05:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251643; x=1790856443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gyh5akvvyyTi7Yve0fYdrjayBHbVCsrQbVTODnYGB5o=; b=WNdchNGmZWTaEI1wSK6dzaajBM0JgPxdrZC0sU5hoPsLYc2pAEnjKk/d/xK9kebj7n suyMCVdApE5WGVFEcxPROlDwq9oHWfwkxKyRQhsRJ/5LjFOAWRcpbr2A744rYQ4KX/y7 q5/5diVb6M9Y/G7XWtL94My6kogiKiOSozmgyDJi27SniWKnlQZaNS36lKemKdMvPT1B jbuwe/N8gJ3w+j37JnXlWfTV8dnSqGHxFgMKo1FvVFT8MLEdWumTovlRYDz2E115CBuq OJQ0FQpzUDwVzL+Vz9ACh5WmcDaMQQKFMzvSwFWIHPoFyWPo8cREgacmKhwEbcGOG9on kugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251643; x=1790856443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gyh5akvvyyTi7Yve0fYdrjayBHbVCsrQbVTODnYGB5o=; b=V7odgP926ob1ox3lFcwIgxENQx5+7kkUOdOydzSBXksVIoKloWbIOCcwIJv4sMS4yt isqDupN8YyKyljoQ+MjCaNKGLxUPqxeqhg97WjvjzVEqanA5zL7APAxjnrWlJZOQmOU8 x8q5o9Hikio8td192bbKdpIc09pU8uaMtv0MY0LLlQkuZeKceljrIcM22zQBdGyIkfQI PL3si4qcYOC4MhdZyLhqwOGgo8HXJKOPOJr5MkUzIeFU+sXYb3rULcIyikcCVz6vCube 3BzDUH5KHqi/wTYyhZ4O5sKNjSr3akJqMpcBE4vNTvXubI/Zf0gC8C/C2nOQ6YTDManr mBFg== X-Forwarded-Encrypted: i=1; AKwUvByybJj5SnQY5CF+kmKAV+HCreS4Z2m4x0f9DSxYFv8PpNNzsatzBKx0Nw5QsnYtmFBa0O4p3z8n2xOX9vM=@vger.kernel.org X-Gm-Message-State: AFuF++mkcY4FfphZhwmbWbNZUJ+0mm4DwuO9yJw+NKA+nMElN4gsQ49R iGuGTc5h4uIRzLtHy7gA3eMr06sBLhSbRkjp3hjukZNz4RcRfGXpNKTbmiK3w1ge6U+Ma2+XUkj H2wcvqmrchBgPLdVqCKZpfShPV5a3TFG7kV6PiscOD18ewIGCNYMYl9naVn3t3kiNKrQ= X-Gm-Gg: AYBFou2G4zfep2PDKB1eHhbZulSAvJD7AC/6K1xIsUegMqPausY/qs1y3EQLNHiOVTk xw8bXZ5ngW3tZvpQJO3dkHqQB7WZr7v9AVB1GVdPOU5mf64yW7tgVESq7EbZodseN+wge/3jJoV gIpHAEKYPRSjZcpUIZ0sPtp8TjsLbvl6PtdK4RU0rk2l4tvKqsc+h0+nUQXgnWeLznV4U5lSUOd xV9alOcRnO8294sK0tTXexzph8/Nd7Zabpp9s9t25t9Kk18KcCeCQheZsArATCcjfnSEb2BpPIU S/KXywsP8+/u80l37LpLzahoAOv7wkTxdrXQVYxaJEoxtPc9WXurTShH/oXdXRtmv1Wi6tEq8TF 4J5MqsdRE X-Received: by 2002:a05:6102:6448:b0:7a1:fa0f:1106 with SMTP id ada2fe7eead31-7af1e1e6986mr864929137.36.1790251643316; Thu, 24 Sep 2026 05:07:23 -0700 (PDT) X-Received: by 2002:a05:6102:6448:b0:7a1:fa0f:1106 with SMTP id ada2fe7eead31-7af1e1e6986mr864913137.36.1790251642656; Thu, 24 Sep 2026 05:07:22 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:21 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:16 +0300 Subject: [PATCH v2 04/48] clk: qcom: camcc-sm8150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-4-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1753; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=1aJTQR0dA/sog7qGkyQAgO7NJrtOYUMQUHZCG6mJu70=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJFb4HQenFLnJxdJ/q7QI4+Y4zfD7JGYTQRe 62F+epUN2eJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSRQAKCRAbX0TJAJUV VqnwD/0etOKnxCGD+us360qFyiorQNjy5DIMBJvWAEKyTKVYIy3hnY/dQI5FJ/OsoMozZXywoOq lLoJSH141B4xE1B6YaqCW49KE0zp2EQuTxBfmGChABfQwnsYMJUrbnXq2QhrxjIcmtp2izM24qo aJPyPf7pjzhEMPadbxQvoiJ8rDMjqnk4F+5jSONEvyySpkn4bTyONJCe4RCvtu4nNBosyJUsI13 6dnIBN+bclS4BSTuxSjf2Gvnfnc7v3K2vAN8DvC4f7lWlbqJAO+xYqXJQX+lv9jJdA1fG7Cp7Qc tk6JyXzLu+YN/Z2QGyy+SXoxBmrf+dX7YNzTNh9fDL3vLbjj0vw1HQ2hE2zrENwbyKZ34nJXpzr 5Z8B7/rhi85tNufBojyftt5u8eQLRpYXChHfthwyhCdUe5dMG4otiHACs6CvIWJob/REbJ9iWYP HbEPHi8IlnZIjQEY5+9YRwIWmezEi1DntEKNeaaHVSBbxUQ8P7z+h1bMtEpMkHjN3B2MY/yTdZ4 +kFTH7ovunHS42aecASCHKC+EV9buCDfAFvrT7FhfTsqTlNY14tVcbe/blHxL+4gxujCA64MbP9 u1ClBPADqZEJfz6a+G+H/pSgnzZrGUz1G34rIIEfX6W8MlOnfdc96O5DBhyH1S3K+xbuGyhjfuE KGYi5CXQuxz3Kdw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=YfoodARf c=1 sm=1 tr=0 ts=6ab5127c cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=HACHd5sh_oZ471OAbCoA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-ORIG-GUID: Wf2fk_VpoAg7ZPXlkeLMoJE4Lj526iyj X-Proofpoint-GUID: Wf2fk_VpoAg7ZPXlkeLMoJE4Lj526iyj X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX5sGhY7dynz3P dSjKepCc2KkQmbnxUBgoebGidTyjg6V7TvH34sFWkUr+BLX++Val6gOn9yVWL0q/oYGgNe5alMW ULWLAjQbZDLQ5NOmk3uztesguSoA9fo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX6UYJ1468SbPW wvfAwnfa0rI+w0PXIZSR2jXNNx9ykZbVtyhAC1wABXDgSe29d4x0mR9wk2IUxXlV9WLsojp52Dz rc3QO2ZeOcxxkQyByM/jwMv7H8cCL/P13vZGJH/oLuiG8l9OTITUtUFRJDDc6d/UmeXFRXypUCF Nfq49YZYS6Ok27mf/OcFJnqPLEgwK4SLzZMZZcGuIoLyXmytF/ZKXiOZvU3gPO3iCa9Z0SU84+3 EH0eKeKVwMMmqjKspjKueaSaJu+LW2NGZQmORGZMQSW/xc+yl2Zffk81ganQrmTvIm+VSeHCx/E HTKwEags5SowB47SL4fHUywOf0qw4/C1g+aT64z0JalPg5DvazauMS5gjfq17XyfR+OBNox+p7i yaJkk63NuTwvRo1r2Ln0gI8+wt0TdLmQ7kVedOSv+Fby91utCt/9Gc0w5FM6C5qJWtMkG0A+1zt YzL6tExWSm3M1nZfb3Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/camcc-sm8150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/camcc-sm8150.c b/drivers/clk/qcom/camcc-sm815= 0.c index fcbaff55fc27..27a51abddce2 100644 --- a/drivers/clk/qcom/camcc-sm8150.c +++ b/drivers/clk/qcom/camcc-sm8150.c @@ -2093,7 +2093,17 @@ static const struct regmap_config cam_cc_sm8150_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 cam_cc_sm8150_critical_cbcrs[] =3D { + 0xc1e4, /* CAM_CC_GDSC_CLK */ +}; + +static const struct qcom_cc_driver_data cam_cc_sm8150_driver_data =3D { + .clk_cbcrs =3D cam_cc_sm8150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(cam_cc_sm8150_critical_cbcrs), +}; + static const struct qcom_cc_desc cam_cc_sm8150_desc =3D { + .driver_data =3D &cam_cc_sm8150_driver_data, .config =3D &cam_cc_sm8150_regmap_config, .clks =3D cam_cc_sm8150_clocks, .num_clks =3D ARRAY_SIZE(cam_cc_sm8150_clocks), @@ -2134,9 +2144,6 @@ static int cam_cc_sm8150_probe(struct platform_device= *pdev) clk_trion_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config); clk_trion_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config); =20 - /* Keep the critical clock always-on */ - qcom_branch_set_clk_en(regmap, 0xc1e4); /* cam_cc_gdsc_clk */ - ret =3D qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8150_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D681947DD4B for ; Thu, 24 Sep 2026 12:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251652; cv=none; b=QdTGL9uSuU8cMkdPx1XdrVf9ao0kPG56ii3YUFUSIyBz+/ZHH1z1RGwBeh3GEVXjCroyriVpA17mTZm4FwX53U0f9htIohvcFOLSaZfuZarZmGJ4jZqMpr94gTH4x5KUfwpiBihQFIou5Za43Hcux5jD/zwqfzbb4Khv3/vgLYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251652; c=relaxed/simple; bh=oN1TEWUlkxXbOjoSBCVEilHRn5/gUdwPPWOMmwDlcl0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UqXSIVRha3TkxUJr7pdf9Gxi5LruwAnPel60x2dzTdKhzC21fpefrbMvYdVosMH08zbipt+3vyrGHeawn+4WkM6P+lK5DN3iI3SbotH/Rd+j4eKiBXGnOsqJ/7Gbmp+TIvhTHYEIj+f4drAZV11J/d4lbdorSZWiH+jRIoooP3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q95vRvOC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qj/AHjar; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q95vRvOC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qj/AHjar" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4pPl2134221 for ; Thu, 24 Sep 2026 12:07:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nfOwQAIiaWlN1G+RcHnEmmVPXDYSSGIGeQG3AtWObVU=; b=Q95vRvOC4xxtHncx 9+ikRBz3NOY4SFwrQrgLm6iMKv7peQz4e49n8IbbKtw+hB8jGh8IvQXqf/cpvUcr jaxtsEPmGudFJ9GFGb3ChhSXBGL/+/Bdo2N5n/yGLErLeWApk8K6Gib0S5j7VsmN 6I8ZM6hASBSMIBQuJH1jiVpGixb5G+/NHWTYOt8mixj/bTKJR3avbSxC1LwBlbnK W5n//ToU5V8fvgJ+vNW6GuRfe2uyQs1mDji8aQHC6wn69iWViDi6kjkKS0e++bbR TAYMrmdeixp2DQaFVl4d4GAqwQmfTLcaOa6W8PfwMxeumWedsO63UxX47IB/Ao9p hYqBWA== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvhsb4bt6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:25 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-78a6d5cc851so549469137.0 for ; Thu, 24 Sep 2026 05:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251645; x=1790856445; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nfOwQAIiaWlN1G+RcHnEmmVPXDYSSGIGeQG3AtWObVU=; b=Qj/AHjar0anwV7qr1PggtFG1dTN6obX7lEzMgfvlTief2ifdHnCizwUcfrUHG8i/mt PHK9tRxPQpCUBAJojyzMh3ci6SQ8U8wpZqxMBluZGxqXIfurmCo2I90zkn/66BjBFabb 4KSE32PfNkjX7xGsJfJa3bOtQvqyIc7z1hQJXRaU69MfDdvU9N84HqQbZWxt4VzEuQhd mrEF2CuykLy0lGveC7ggNOmGHaX6Rn24xQtKZkSdEGhAaKMOoKzsg2SLNaQT6Zf3jCqd a3B63a1YevUHRAjJmjF1y0Tbzn2W7JZobiqCvkhGvbzhJwSArnbv6VXEFLjHpnn1F9LQ t8fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251645; x=1790856445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nfOwQAIiaWlN1G+RcHnEmmVPXDYSSGIGeQG3AtWObVU=; b=RGex7K/i/oadxMXxyPCqiKi91hbE9pDocAQf29MgXQb5Px+Ge8uXrMd0SrGcQTOFmV FfxnnOkZFj1xltdBR9+HwqUJAIkULf4SvBfR5jj9tNayagamzlZZ4k8WIK1MD0K1AGYV /402LuDkS8SffA2nle847SpL0TLFGb5d642/a9RhDX4xuJ+7RfELR9yatcDXN4xKns4s lAO1C3OBsH0gy73q7g35qKwX0Zcu3NFAH1AAai7dDRrjAYUfR47hMApkdN1NbnrByq2n nMT2s6QIg0e+p8Rl9w8WVIZSrr3M26JcFh4VeXfXaZQNCHN1nWP/IqmIt8E9MLu5a4oL d9Yw== X-Forwarded-Encrypted: i=1; AKwUvBxAovlGwlKTmNZijWjhG17YSfnxYjKtptJUiNobUDFLpcgY//nqsMOHpk+FNASY0xatdXp8G6nIIClC5ZQ=@vger.kernel.org X-Gm-Message-State: AFuF++knXV1kCYgW1x2EXhMG9QY8wZzkFP7LW4tHuC95PqU3uLaKTvM8 lAGfo0dSwtLf1m8AEgxlpAVVaC047d8hxZRRi7hWunomv18GnRQjUNHir11iCwRAjGngZCfYucw QD337PRX2EWADEpROiweku1b3DCgf5izkp/aJfr2HNWHrwT7LXYlan7xdIvUjSeP9+3U= X-Gm-Gg: AYBFou212aEtDzb4a0G2xZTTSncARGfkrLc1upUCSJxw5FQ0On4G0SW9FWiARXYgLmN MnZ+n1lYQXYfYaDOXAINojyiT25h+CUtjCuA3Fp8a6pWXa61nGTLYZvaIjkUvnRhnKvnGs2swqX ue0mR55nvmlh0asmDB4lzbSWJcU2GF2xMJYISVXvxqRyMlKlNKUQGn1RBeu34dGeLpyP2D5FpVR 6QamelIpC/R6cI7NkP9wIYTL0913agkD2aXKVyXAKuF7urLWQyQyZZ00GFyVllUAw6Wkm/y23l2 MMIGrV7G8s7pYR0VWLD88PkaQtwvm3DLogsNsqczphryEyI0bNH8D63GIGguXH3lC+Ux9KeSk6M 0EndWfrPP X-Received: by 2002:a05:6102:6d5:b0:7a7:195a:1b23 with SMTP id ada2fe7eead31-7af1f0ffd2emr976965137.29.1790251644989; Thu, 24 Sep 2026 05:07:24 -0700 (PDT) X-Received: by 2002:a05:6102:6d5:b0:7a7:195a:1b23 with SMTP id ada2fe7eead31-7af1f0ffd2emr976945137.29.1790251644339; Thu, 24 Sep 2026 05:07:24 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:23 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:17 +0300 Subject: [PATCH v2 05/48] clk: qcom: dispcc-sc7280: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-5-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1665; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=oN1TEWUlkxXbOjoSBCVEilHRn5/gUdwPPWOMmwDlcl0=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJGhL+xS/pRxBYZZHc0SVqIwdlQYuym6C6D5 YAo3yyLyqyJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSRgAKCRAbX0TJAJUV Vv7ZD/wOpN64SgwPm/cFM5R19DAMIfTAUSCLjQULHdtjH/pdCVAtutpFxRd5AbXIbnk0TMCxRtE Wm78a5Je1SJY+2mn5+REMpeK/si66vSHYtDBrN3xtFmiPmFU6BehEAspFVQtyhBAmrc2Stw60d1 agn5SNiBM3vAgQ49YovQJ7eBcdaf5SLZPkda9iU0vnefKlVhnvHJ4GivZnTFGHjTCEj/XyvncCd BSq4YPnaqKGemA+681gXMsm6TvLOL0aRFSH/WZgzpsVg2tpz+JLNxCiIqCDbLIBUIIORCDZgS1n vpDMmcysn8eDCqTJBrCHF+B17NPV91LvmFtl6CILXE8RrV8YPKHA+ay9wdaAYlF66e/yoi6mgxf feqjPB6R4RBerllW7Pae7Q/s71Hv/VzXWB/vHs556mdzk8kSRxMxMafftCWMVQqyMRe21H8kNwt +o3m/3rrSMlmySJ36C60Gg/um8w44tg3xB3vpvj1l+WSZV1frp6BQ5RbmMQ7CLPWGzKIrTodXmC yMdJjNDBwmjYRCFsKUfy38sBjoxGi4PYVIzquIITBWK3i55F/4hCBdxax4/XM8RgJzFjENJ9mt3 +5+gObi9uoNDLZMt6hTA2IqVA9XfeHolDPG5MPR78h+1awEPyWa7whhdbps9c4TRjsTE0vt8eV7 +Y6jRQrwX9iHEtw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: apGKWSaB1njaPdnialDy2qBsurngKFz6 X-Proofpoint-ORIG-GUID: apGKWSaB1njaPdnialDy2qBsurngKFz6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/wXaFbhOxhjo 6M1G8oPaV6nc8mWZI3vhSFBftSVYkZZD9FcG+P+YITtQK4o2y9RlfBNSqIB0bsDONua9BzuYQ+S DpUqHzq6TAaW8yLpb8q9aE6i8waiIMXQl6VOv83I94nfQcRpPs4PIlaGU+QhdDzpSUBle6Nzz/Q Z4ugDMht89V1f+OmLGetOdzb9TULnC0sadoRAqzfeUV6LnZvtONp3sDQjG1QP+DHh936l1KtneD Yn7wQ0/U7gywgvuNMPrxt7if1oTg1CDFQQHtFigxF85aLofl3H4s+Ebyp6uktRVYyYjSsHPVam9 kWN/0HIsmqRoe7R/vOFXJJ4Kz4h12TABodX/rhMU6/E2MdM+5rPbDMN1LL2QgxBkRT2bqSjPkDg XnKU0VxGu6kr832MNxV7Ys/gw8TCXN1/xwBeLVjSIZ/CUeMqe7bT6xQ9e9W6R6QMQzLPfuBRFSZ tiqudgtnc0Ku3K2r8Tw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX9NLo052O59hy y/g5pj2Jc67+7aQUOKwR1cZ9U4SJDuVkh9DI3CxnoQbvB2ozHc4dU77AfcRo9boqGG60oMkWLfF dwUSH733xb/oeWs/gk4zuEpz6FDvTQU= X-Authority-Analysis: v=2.4 cv=f7vdl+yM c=1 sm=1 tr=0 ts=6ab5127d cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=_TElPO2WjJGltpybzhUA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sc7280.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sc7280.c b/drivers/clk/qcom/dispcc-sc7= 280.c index d11265debaf9..24a65cbb1ecf 100644 --- a/drivers/clk/qcom/dispcc-sc7280.c +++ b/drivers/clk/qcom/dispcc-sc7280.c @@ -860,7 +860,17 @@ static const struct regmap_config disp_cc_sc7280_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sc7280_critical_cbcrs[] =3D { + 0x5008, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sc7280_driver_data =3D { + .clk_cbcrs =3D disp_cc_sc7280_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sc7280_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sc7280_desc =3D { + .driver_data =3D &disp_cc_sc7280_driver_data, .config =3D &disp_cc_sc7280_regmap_config, .clks =3D disp_cc_sc7280_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sc7280_clocks), @@ -886,9 +896,6 @@ static int disp_cc_sc7280_probe(struct platform_device = *pdev) =20 clk_lucid_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x5008); /* DISP_CC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &disp_cc_sc7280_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD149481657 for ; Thu, 24 Sep 2026 12:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251653; cv=none; b=Kt1GHQuwtpviiowbP+lbWxMWWBzONH8aAVH5+3Osb0iXRk8q4umgWNXMH75hd4EaLo/MvpEDuhxn8K6t3W6T3bNFj9lUKyWWBx4ygBa1B+FfZNuRimrO+Mxi9NYyYXWYyGcMeN6fX+H0Sou0JeIzkrQKqx9KRDOsCZOl8D2JVDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251653; c=relaxed/simple; bh=Xg8yZ9bCiuy7/hKy2GSjfWfNlvm/K4g4ya5dCO9sfGc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kMI33AN69hVpjxZUP41RWkqlmccozWUYEgJPJkMFSu2WwBXvpD6CjD1bWQ2hQSQYK+gmlRIKTORRlfR0nPN1BZPotw8tmYCmtNr3Qw4Q2om7u/7udbJFA3rmwkbkRhFvCwLEdU89NNxOXylKmo1LlFt8Mw0VGoyAMcxlGJ9/YlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UDFTaJ7s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Sl2f26mw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UDFTaJ7s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Sl2f26mw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4vqt1430110 for ; Thu, 24 Sep 2026 12:07:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nJIvvwuuwJUhqRsuC3nyaRQQk7di0D0zk/kBIt8wCTU=; b=UDFTaJ7sghrdSPsY l4Z8w2tEKwOAoob9mRZstTGRzO63msnhnsxZh/zuhmS5NbAupBO3I8eeQdXJ3PHA 9S5uCP7RXTYybQop9RAxqvQ35o/PxuyMgn5iYj5YqkxHQp5XTSLqKHCnfxREQ9I/ IClWIWPMzKWKMsVV/XnjIQ0Vynp4lMDo37BpmO4gy3abQY5AQdsWxSTVe42K8nw9 CI88SIu1srKjltr22kQ+AXSxTYbo6rSV8hW9ZTpEd4pVSB9tNGASCm040YsArsJ8 Q3imcvj2kxj5TNpxjYx/NSIEy7J5A8+oZaZfdW5hLc7Iq1z9c+OD0H1IFo8zbtb+ 9kyx6g== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvvgh9ve9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:27 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-78fbc5a4cf8so868875137.0 for ; Thu, 24 Sep 2026 05:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251647; x=1790856447; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nJIvvwuuwJUhqRsuC3nyaRQQk7di0D0zk/kBIt8wCTU=; b=Sl2f26mwGmX7pJqDabiBZWh+rwY0SerrkRwkHa5zscL8dH1d9GfnhhQHXciH4EuXcL kZ96q0TYtqQpw4PI48/MSkfWw+nHbodrsnxsz1WuNhtTAYVSz1Y0peReSM/Haqv3ubOg E6v43m2OgeW8mOywMn7iskmL5hlN2pO21ycYLV4qsLiw0M8KD9QIekJM4wfI92IWXAE3 rpndk38AdEC08MYjjB0zCYvlkBMRhbQp5NXZ+fjh7gGmHIJe3f+thfFlISp2PE6uK+54 xL1BksM2RVyHLIjn0sWSAjBkH8FgTiDqVLI9q73+RQAQXsEU6DK4LZjGrvm7FMw5J4IE rQcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251647; x=1790856447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nJIvvwuuwJUhqRsuC3nyaRQQk7di0D0zk/kBIt8wCTU=; b=HXGhjVcaawCCpt/bsyidLjnOnvfhSpBVvS4sx77PuewpBFCRVY3tjzaebtMYuY61k7 3tJO8/pVoW9grLD3xcQdVVWYTeXwu3U2wE0uqk/4MoqbWMhwSyf8V8UpEaHZcU+nrNdZ ApXNk9Nw/nUwE5jTJta5t/jG0Kiyj35jC/3VTi4F9bl5E8AQetPWglB+6Ucraf5gjbQd fPU/Mjqu8jGJCU4EX//rLQAr688ZL8uBpGvh9zQgoE6J7D11oZHfwaqjJGfAd1K2efDd 2w87VRzlAMg1SXOGJvtKJ3IFVjKAHdbwlbsjJeZGCt+89h+xkUi83KpsKOfQYMZkd+Zu ZoqQ== X-Forwarded-Encrypted: i=1; AKwUvBzOtBg2QXUX7dcsiTxUMTvTKjRYNmnTgd2XOoN2Vc2m1G8NJKC1DkA/dmzBadPYmr29WYuH1f+Ne0td5MI=@vger.kernel.org X-Gm-Message-State: AFuF++m5z/W8b4s5CNlDaZBmX+xrlN3TNkwyhAs+ROYi9V05pqCngsCh 74VHGggPBtT+KA0PlXWinE/eTYdgjwrwAd0dQi4+NWanM/aQYRvGRvpjHkWsHz8+9DY5ZQs3EOy Rdlrj2NHcoZxlYUOlLNi2jiG/HqPhblrn7Tj6TVzeCxpiLNDeEJSA/Ap5E5+Qu9fQ0Uo= X-Gm-Gg: AYBFou362lLjmSsU+93otzK2CYsG5/6uiJCpJvkvwNxuBVAcMzqV+IvdE9HWie99zcg cguXOHMYh/3hPk0RyLEtsz5vtFXoZojT+BxWMfi5gW6oez5xsGevARstAwMKyOnYXWJeFf2uplM hujy3FR07ZjzOXvSFUGrozw91CsGZk7Bc4lWfr3JZ097ISJI9tDxVNwCZ69tx6x/+NKx+Wvypdy RwgYHu4uWzqODEXDF7kLN2pbncTo6PImDtqdHWugUskvUQIJTjcSqtUhaCDY0FC/IFHYtz+RUze kRcoUslCPxzVBNoUOZbGW/A3/q3c9pnBd2wcEjnrirQFEjvezc1j8C1Kfsv7w/ZJfOVfB/yJaIx 9VT8mIhqL X-Received: by 2002:a67:ea0e:0:b0:7aa:b962:a4e7 with SMTP id ada2fe7eead31-7af1f617c94mr662201137.36.1790251646609; Thu, 24 Sep 2026 05:07:26 -0700 (PDT) X-Received: by 2002:a67:ea0e:0:b0:7aa:b962:a4e7 with SMTP id ada2fe7eead31-7af1f617c94mr662191137.36.1790251645988; Thu, 24 Sep 2026 05:07:25 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:25 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:18 +0300 Subject: [PATCH v2 06/48] clk: qcom: dispcc-sc8280xp: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-6-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2398; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=Xg8yZ9bCiuy7/hKy2GSjfWfNlvm/K4g4ya5dCO9sfGc=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJHe9D/k6B6U1f7PGu7o8OdohElxcEes2Y11 Ne6n8dhUlGJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSRwAKCRAbX0TJAJUV VlU/D/4zZHPfTsvmsA0NiyofHRP73lkYmvGuCSEJRSxd7o0khdehDfcHltdZ3a0mXkbCKBB4Sbz mXvn2PSZDdWyBRcoSI2xG3uZo0XaNjD2RyHEM2jz211//t02D78BpuUoXHJC5zED2JiGhTX7Lll 0tDgGlgJb1q1Sim9bhzhqsUg+AiqmxBr4wIcQCaBFrbXd4rgufo6dWwrVySRfWGWPRN6UxqrWi7 aPP4RwiUiyKGV/yefEInWFVV6ASdkm/WnjQixLNf0ICN2R6bgEO4KPTeqoi7JrHFkFxuoJmnduS 2i2tJsQY2tkhuHILhihWayuzERlZfuiAnmh4BcxuNe1NQfgxcEKOxfB0M19jQ6aeTfuqBSDT8cz QqWoTBPlbB5HV4FhWo4FVoway1l8mwmjKHiTCudsIMe/XEvR7Avu6lIMA+SRp0XId1hYJJs0CJa EdsAPYgmUTwgUBOc7cIoe9NMuf/BopP/r19t7bDN9b3Ax+HPNmY99QYKQL+OxUnD4UaRpz9okpY pK4jCYzUTiiQJ/iQc/QgT2sr0v20T4LMPotmzWYm9JfCzByYn3/gzT4irdfjKXUTxzjPwym9Ygs g5qqio0an9Bji44uAP0S1P1d2JKRv3V5xVqFWYJ8m/fwZWndWgypbiCkwnNTYf8IO1U1W1Pm/yq PJyODDzHYaBTzAw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=KYhHIgYD c=1 sm=1 tr=0 ts=6ab5127f cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=JaSVaRig_KI77aDXWKAA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-GUID: jKAE50RNfBQHMtKa-QNFvvA-qU8Hu4pw X-Proofpoint-ORIG-GUID: jKAE50RNfBQHMtKa-QNFvvA-qU8Hu4pw X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX1JYaiCoEPU5v PIFY8Ra2n0pRPwe60Rh2NxHL89UFr7XmaavgVO66yaY5SwS39AUw29uCdEYV6IVY/w85AWmDo4/ rnMN90Igr3lNRapbsXRyzB5MeB5Z+y4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX34fqlIXxg8bn DDIRP3BkGkFH3R6pulK3D2nkFTTyqeVHlaWFQVruU1fW5MnATnJU3Tdm7+QUB4KY14P1wqcUp87 6JmxKwO1UU1OgxLiAywagHIi66AhpJbgwgOaTv8TetXxY/oEhb9z0Vg2HC7F4CasB5bBRHVrIDV B4CY6tCHJcPqAQEDszeDUWbQ6Ew7j5lsBRIeZbnW+qSoD4Qj5ttj6VgTSLPkPApemhFvT9G8xwC Aye8GtfgEgmrKUQGmGAtF53Z6TB6BQRnNa+kdwpCv3d+Nwv99XsNbjfu/w4SZ0+GScqgGjYWb4y K1Xre442+WRyEcGScCYOhatiN21xRxAYM2N1TaC+IcRbLebXT1pNn3RBQmJIR48pk+bqQdVYTTr G9ypMsa+lzL5/f4BkGEEYCYJ3I0pBfOzDhMUaPC2QrmcVmGzb5OE9zucwBYhqMbYTSqBict53Cf XUhdayi7PI44/I0GOLw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Share the CBCR data between the two display controller descriptors. The XO branch is now enabled by the common probe before clock registration. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sc8280xp.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-s= c8280xp.c index 96609bd5233f..96b3e5505279 100644 --- a/drivers/clk/qcom/dispcc-sc8280xp.c +++ b/drivers/clk/qcom/dispcc-sc8280xp.c @@ -3108,7 +3108,17 @@ static const struct regmap_config disp_cc_sc8280xp_r= egmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sc8280xp_critical_cbcrs[] =3D { + 0x605c, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D disp_cc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc disp0_cc_sc8280xp_desc =3D { + .driver_data =3D &disp_cc_sc8280xp_driver_data, .config =3D &disp_cc_sc8280xp_regmap_config, .clks =3D disp0_cc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(disp0_cc_sc8280xp_clocks), @@ -3119,6 +3129,7 @@ static const struct qcom_cc_desc disp0_cc_sc8280xp_de= sc =3D { }; =20 static const struct qcom_cc_desc disp1_cc_sc8280xp_desc =3D { + .driver_data =3D &disp_cc_sc8280xp_driver_data, .config =3D &disp_cc_sc8280xp_regmap_config, .clks =3D disp1_cc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(disp1_cc_sc8280xp_clocks), @@ -3167,13 +3178,8 @@ static int disp_cc_sc8280xp_probe(struct platform_de= vice *pdev) clk_lucid_pll_configure(clkr_to_alpha_clk_pll(desc->clks[DISP_CC_PLL2]), = regmap, &disp_cc_pll2_config); =20 ret =3D qcom_cc_really_probe(&pdev->dev, desc, regmap); - if (ret) { + if (ret) dev_err(&pdev->dev, "Failed to register display clock controller\n"); - goto out_pm_runtime_put; - } - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x605c); /* DISP_CC_XO_CLK */ =20 out_pm_runtime_put: pm_runtime_put_sync(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A58934027B for ; Thu, 24 Sep 2026 12:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251655; cv=none; b=McOwSSFWhMVo+S1DzIV3MM6MWC/W1xf5iCb7bIDT2mhKNSD0n8xcwmOtpGyszhbhKcfVm61wCYXmJzYOQWuPZLFau0yVrmc9pSWYvDDxy3oz3gr+I7yPajfAaE6aVSBaSzEm5JJJuTpce0cdh+gaZAU7VJ6RjFt1mTJdN27yosc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251655; c=relaxed/simple; bh=V8qHf+A6jAVexqEBPB/LCPSO1r5T/Alk9AJu7MgXWrY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OzVsgmY/jGOIr7q81AI3UJq3mCwNz+ZdjNmpKVQOceeEte/NaIpMqSbXKpbcx7zOZI/y7OnApgLYwx2PPnaDbNFbXse7EH37Rb0cIbnFQonL7hA9ilEm+cFtEMNMGZ5nq0jpFgUBqBtrGSvySqyV7v4ZPajEDGa8+KqSLw6X2oQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=clSWSh2t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RGnX/YIU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="clSWSh2t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RGnX/YIU" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4eAM1437096 for ; Thu, 24 Sep 2026 12:07:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5NxUdiXrzLkzQ8+8Nc4BBkViGk+ztBOR5ekhjyNIZl8=; b=clSWSh2tNJp/Kgyw FCN5QC5mMAISPoS9nnxXgdOlO0cDy8x+ckPlf4rHXXSvYjRHLP1kMiv/lTKDI67M AXqOrKFQxwl8gXb4XaK4raEdCTl2xq2Xm/sFiMYYOCFZEhCDKZKDOB9TI/pxbw3r Hw0fvE9hK72prEvPNjksYQFSiXgT1Dz5WGeqPUQjJ62DQNGfsjBk9wBxs5dcJPBJ B2N+fRyCAnXCJt/a/tFiKpZeym6t3M9fDdI4XKE6Dphm2qgGda2Q3ZzAyzWNGeP8 Yr8cOGY3w1bVKgRJLvfGKCOmiL6yrrTItjwd8599qs23ktppsymA21bj9LHuI/dv P5PZSQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1t7rena-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:30 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-78fbc5a4cf8so868905137.0 for ; Thu, 24 Sep 2026 05:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251649; x=1790856449; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5NxUdiXrzLkzQ8+8Nc4BBkViGk+ztBOR5ekhjyNIZl8=; b=RGnX/YIUjjHMJyBJPE7borpJs6gCHFcxrTURB4LDPbsbuBAaXDnO/64uxWIu15/KLA oVMN8xii8arTlaLr8lSTBI0qfQzxTgsRofSPZRNOfO+2meA61G7RFafIes87sAEmAO6B XkcsZMbc5kIxVoLYfLXeGnTlNq10Sim+YfEbpQfUYF+XjcODMn41osKxJhNr2Y0O62xo cI7OxPcvqpsmIEaR2EF2EXbNpl6lWFgOiHStll/ux4pgF4QmZNXjWWWdm3bboII2q6JD cWhdb8Dl5f+r8boZ2cXdRUOCWalljITlnjTI7MdHY0+eGLuv/g3GW3xMj7qcqAW26t7m IPzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251649; x=1790856449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5NxUdiXrzLkzQ8+8Nc4BBkViGk+ztBOR5ekhjyNIZl8=; b=tgx5rof6VVx5Ut/twX+b9bptexlOY4YludzuxE5qCFzbIatxu0WkUEzyBF0HUETzjG zF1hEUDOjhpldx9esmWOlo1Oc0TQP4/AGASVS9yPHyWGh2fweUL0z/wH5GQxtlSlcTxZ B1bZ6mtV5lLQFMSGxG3TFb8fsdb9BnwXSLIPqa3Y1UODBftsdxEzg0Bq7HIe9P1KdHhA AoCXc1j2SREJSpo5IbYpiPAOx5eHnDypNvcuz/EzS1GRzvsVgqNS9HGlUuwfcwxAld3p q4IUpxNCMi3iif+TzDdHB+whLmfUV6MF6AXHE8UTXBO32NpILFeFrcZ0OpiKrPtkaQoi /xMQ== X-Forwarded-Encrypted: i=1; AKwUvBykZ5s7ULd2ozcT9eqtA4R3+IVrhg8hcCUWo39fmi0Bht0pRa7hURgrBVRK/Pifng0EZ8il4/gFTUDEtyk=@vger.kernel.org X-Gm-Message-State: AFuF++lVtMiGZdH9oblHxk+u2HKFz+oI5HqeyPvxpJN5F7z4NHjc6xMg ta7YrDZ0I+nnIcmRyArfRolRBcWaGPDE0s039Nhh9DYp18UbcoTu8QCnsl7QC8OmDzM7CHD3q6s y5/lNLYYKgb7Qse8sy6vfGurpqm5XBbIWrkIo8zSUhDktknFZVpSccOlGT6mPLDX+soQ= X-Gm-Gg: AYBFou2Sc4IXqftbHS+h+6G2FH75/LFG+wAk4p0EgxJSPlVqfiwkbyHBS82vgIaiGdg CtazUVkYbEEe2CFSWm6ETAghkq59Mq9EV9Np8YLKKpEuqcQQrn5m8Wm+kFCh3xKIjGAxv8FZKRk gCf3DklTF/gMqq+wuI1QmYE+YhX3LRGzNWcXcWbokqpEmZUhPyauL0ep3Sdw3IYIG5BIx/S8kLx KiI/6RJf7wpHRG97i6bPCa73HHL5TjtDUMvqw1VwXbwQd1uGpj5dNKRF3TeHlxKSlDYO5GWfciu k9tah1sECfy/qgDYbWScSAjJ+csW5zceDJW80/r6Lr+vazgNQERyLQNhCFUa04AxdpII57HFwDD sN1IuHTwk X-Received: by 2002:a05:6102:83ce:10b0:7a1:f2b5:6465 with SMTP id ada2fe7eead31-7af1f40bbddmr770451137.34.1790251649178; Thu, 24 Sep 2026 05:07:29 -0700 (PDT) X-Received: by 2002:a05:6102:83ce:10b0:7a1:f2b5:6465 with SMTP id ada2fe7eead31-7af1f40bbddmr770427137.34.1790251648550; Thu, 24 Sep 2026 05:07:28 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:27 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:19 +0300 Subject: [PATCH v2 07/48] clk: qcom: dispcc-sm4450: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-7-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1853; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=V8qHf+A6jAVexqEBPB/LCPSO1r5T/Alk9AJu7MgXWrY=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJIkSYSO84FCpTJp+KZw2eg5gIWdCDYX1U8I drbqYi+vWiJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSSAAKCRAbX0TJAJUV VvQvEACWsnJ5sKFIrJqFPVOci5oKKfk6gwF2M52OQlagnvIRVtfFtWn+tqnsM7JfHpkbIxfLMPi F7gh/SRxzI4QPGz970RJQZTZjgq63M8hAnQrfNLOcZWsxfiaIofOV57MxEjVhlMH0KBu4iFHvyc l6F3wg5y5A/PTRhFc28jPPrWQ5k+1fSOYjKXvs3tBtNHvCm94O/XChF+S5AhCWfW1sNdlD/OcFu vdwzZl02pgSYezd294zskC70zuyTTQ5ejel/IA0iqrd1YGELRPOEteElEh8MqfFUuyl+oD8JVC6 tnM24DjE1K8T8vduOfHyJXE/PEPz8JEHzuMi735EbzbTxiwBA367z/zK5yjD64eMl7tYhkxOznW dwsuopmiDz3Nxo8GOm11PcMuvvwDlAQFSEXPyKOFa/cKSZP/S3+TWjBy/MaIvgjX120nKv1wEk5 puifuJkOraTavhy1uob5L+sC0v2sgWqc+EE+CPszFqId+s9Qb8bzkNdYfnpnwwCTgagw9HLmwS4 uixOoovYA/IBcFPSo6F960SUNswK1aIMAsSM8h0rrCc5XCRW/Lr5dOODTFYrz+hkn3xCLKLfToN HX9nZm58HcfwemMGFdgv+oNa5N3P9f4VSYF0qectLF8Q6wTj79wmVsCA3an+M6j4CW22zOMcAHK TuguDwcn22fPe0g== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: ujGdOO4ayZpsZEjd-eiT167iSvpeZZlv X-Authority-Analysis: v=2.4 cv=U/MHnuru c=1 sm=1 tr=0 ts=6ab51282 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=Mkos_PfpLiWYs3bmBbQA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX8RjRY0nMd0Qe 0rCGOdBafBAQK6cKvzrYP1gDsJsGhneSaqoJvWZSxy201TFE8f2+bq58qaKb1HEbsA1cc2/HSX7 M6EGGgXFetQK9ZliCATWdR13GxOdBYo2S+KtFPagAvMAL4ZIfq+85zLGYRC4fv+MQU+5aoTb6/Q lopQJAwN1Bqv/0Sbr2OohK78NXi8PNM+YLB7JXKb7hVj1Tzk0LQ1XxmYZEDEJYijZQmHf25putH alp8Euh93JHW91bU7TBQYUlvD2IMfbfgltuUwYvcmoKNcrUgH7ZGLZoXtR0lauEtzCrlHCmw7tz vu/2ZL4X2JZ0Ve1Cyqm/5QJtH6JJeWmJzMT2Kr9IkbUeAKMVHK2cuMJfZbSNANUwToVXhIyoWCO VFF4U6rhEk2Hp2dw5XagBHwwwB66U5UXVC3fD2XgpCHefP5kyOffdbSKxuQ73HAAMEpXwvXsOxL bQTJit1Eq3aDeQ8rV9g== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/xj/9OgIgR1C Ga3JxzG2kdrl4AnaiDJGuXLC/F9hualrUNs+vZOcJfDLSL93Yeu9ZduOdbo4SNais4/gb22xO/0 coJbRHDFj8Oh8xvEOY2sVsolQggqx5w= X-Proofpoint-ORIG-GUID: ujGdOO4ayZpsZEjd-eiT167iSvpeZZlv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sm4450.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm4450.c b/drivers/clk/qcom/dispcc-sm4= 450.c index 4a4811db55dd..f39afa067cc6 100644 --- a/drivers/clk/qcom/dispcc-sm4450.c +++ b/drivers/clk/qcom/dispcc-sm4450.c @@ -719,7 +719,18 @@ static const struct regmap_config disp_cc_sm4450_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm4450_critical_cbcrs[] =3D { + 0xe070, /* DISP_CC_SLEEP_CLK */ + 0xe054, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm4450_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm4450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm4450_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm4450_desc =3D { + .driver_data =3D &disp_cc_sm4450_driver_data, .config =3D &disp_cc_sm4450_regmap_config, .clks =3D disp_cc_sm4450_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm4450_clocks), @@ -746,10 +757,6 @@ static int disp_cc_sm4450_probe(struct platform_device= *pdev) clk_lucid_evo_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); clk_lucid_evo_pll_configure(&disp_cc_pll1, regmap, &disp_cc_pll0_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xe070); /* DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &disp_cc_sm4450_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84CB8481FA0 for ; Thu, 24 Sep 2026 12:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251662; cv=none; b=XVfSrJtTOPk+Uv8sPeuGcTu/xDuve2etiAq64A33WqVHuCQQk+Dqn2dVcesEJ4wfVcVWJliZOakldIU69GplwXyHioDQrNLNN7d/tUD/MdwvnJx/T+N8UJQv2aF4LU327aI3IDFHPE3HxIFgaGPKtPIxYH0adbvHY9N8wV3dfJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251662; c=relaxed/simple; bh=UdtBhyBneBr/MOKYYLbb8D1/sWQ60iekzTd+9v7FbFA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k+rdGrOGzHpaYHQFiLzF4hzitanzD3+r0IOg3iXfiu+5Tu+lNkKdXaya8cryxyXRB3fpXDOUGFToLLi3XH7daxcVgCTOmIjo8XOgGKJmia3W2JmF0GPoHmQstp+obAnqOviqOGwE8G0Fnv62D43nrAubtCFiKiP1+7UMmfVPrgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m5Wm2Bse; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eLdiaArn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m5Wm2Bse"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eLdiaArn" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4blN2133914 for ; Thu, 24 Sep 2026 12:07:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h40ZxiQTUvyvswbhdN5FpRTz11Cxy0kBEZ+g/P7iQCI=; b=m5Wm2BseN3jQA8Ws lt9+Zart7R3L6zYx2MH4NJguFYqCEcl7xNNsyovi3kto8W96HUmPn/cRDWAx6wcN eP5STNcIcOTG7p74MdWSuPR4lTzOxA56v0Q+mwNBpPrftCo91WKXgJJKddgS9fJ8 66QcL3Qnx0O8qbYsace89hxZX9bDzuYy4/BZUdmDP1TqHxNO+zJRjbJFifPfwIUK Qh84hC6omvTDcErowB0VUtE5PrkFhaNn+WYtlOFvIcK/X6j4ArltXKW71nbIR4Qf +vgXQEL3xMVHOi2YNp9hyqAIg+VbcMUQcPLqpsLPJlnVYXmGxi2hZhP7NA8riU0/ UWpaJQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvhsb4btk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:36 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-7866c4ed349so1636364137.0 for ; Thu, 24 Sep 2026 05:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251656; x=1790856456; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h40ZxiQTUvyvswbhdN5FpRTz11Cxy0kBEZ+g/P7iQCI=; b=eLdiaArn54RZ7/lhtcSqGSxxX9EciAUjPnmZKTgGqq/noNKg4YFgtWSqEBIE1PfYcz EJ9pIfeZl60MEpFjQOp9UHFAs8Vxy//RUOYR6WK3DVEVKBE3aBeor60+7Mes2Bl8+id+ 6JdCa7jvLa2HSdzCy62vnWP6QuUu/pBTF7wOi34s2FhvFoUQkmRcYQtmuhV32hUJgpnx XAVWr+LR00I/FCYunAPpyManKAuhsZ+G8Mj2vnrs5xl5ho/xHd2i1Wf0Tx25YTdpxP1I q13aybt/asQT+x7Whb2Ve7yWoLM7kWZRqWqE0UJXduDB/0tuHGy+sM2R0P3NrBJnIzyv PQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251656; x=1790856456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=h40ZxiQTUvyvswbhdN5FpRTz11Cxy0kBEZ+g/P7iQCI=; b=BwugcHz9GClD0bJw1O6IO5JxfoydBBSZi4fX92bmd8Styqy6ktB7KTEfwO5O6Rg6d0 DksjiQm5At84JDfDyiARy+cgwMGNPW3CHkfDJQiPE6+cw7RoGcCjDqmG1Gu0La4rVMDB 4QOzQYS/A5NqVhg1y24SQeL6nEVWavSmvpKgCxQ4opP4yczmQ843mOxbC8BLuCIgMG7W Cr5yxbylHpETV+H6ohOM0eijC88BQnssH55JJcPG/FmbzqS262ep4NfVC7orMZ/BwVsT gsfZUfG5CjZZVTjU7JvUjITPAxbUEBFe/6R/Ewl2snTpLiffBg9MFRBKyOwnzFLfB7jO uQzg== X-Forwarded-Encrypted: i=1; AKwUvBzks+JhY7pKA6QI9oKpVgv8nvLnaWERBvwkoN3wffIvjp8ODN8DqaIxdKnem34Z4UKjIzX34aqUY3nXM9M=@vger.kernel.org X-Gm-Message-State: AFuF++nk/GzFKMcJSKJ2TvJyyiuIe3KkPRReLj52OVdIYqp/wDeeY552 +SYlsa0WHA2Yrk/zjVjVKqiZaeKsVU2qOWYrDQO3OGO2OaSc+LNGWKpqxW+0L028n7Jz4RGyyl7 OXAke8clcH40XTpSrCOVEvIf2HsCzFZ+fJwpv+rhnn8nfS6j1buLBskKX3ATX0MKO2YE= X-Gm-Gg: AYBFou2POVYAzT0qLcf+e46RMXyZprEoeP55j1vT1UeIBiU6L31MdYITjOxGebBvudr HZdBNY52WWhaGJ94ecAsDDFpb6iMOZ/301zcAnnoK4KSyPHheE9xLGozbRS2PHUzyB5XHVIucEf TKZQ8L5StOegGTfoNMolTXxgkVOYQvyjrixplONylZfNGaoSH2xT3IK3Mk8mICla7g8q0yo7Uxq lnBopnr7IzgtpKqP7Y9WbA6UNmEJyFpBJeZse5SsKIH+KRs68VLSsibpdsW4TlRJNk8uopPZbvl WfG39XsuilEKBEJY/yehW/7l9vYfC80izh8MyKpRPiuOm4Uh20ermHwoCPKmRxq0HseevhY/rnm 2n/68T3C4 X-Received: by 2002:a05:6102:5707:b0:7a1:f951:664f with SMTP id ada2fe7eead31-7af1e4f2ae5mr1178714137.22.1790251656324; Thu, 24 Sep 2026 05:07:36 -0700 (PDT) X-Received: by 2002:a05:6102:5707:b0:7a1:f951:664f with SMTP id ada2fe7eead31-7af1e4f2ae5mr1178695137.22.1790251655724; Thu, 24 Sep 2026 05:07:35 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:29 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:20 +0300 Subject: [PATCH v2 08/48] clk: qcom: dispcc-sm6115: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-8-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=UdtBhyBneBr/MOKYYLbb8D1/sWQ60iekzTd+9v7FbFA=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJJh5F+5q555tffDippoLKfeTD9qcLFZEQBV 746V028rSSJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSSQAKCRAbX0TJAJUV VqmZD/9VhYoR+igOJ7LL/cJEuGJeftMry8xdDa/wQxZLYX/D1QsJ8zz7c32e/Osos7f8Sod7w1/ lGWcotpdQf6qF0ktMzhlvFnbb0sofPuduoewJham3zoYooWnWpsjC3MgRcmwIaLfUGSyldgaK/2 HBdsukCMIXGBqmc6fNMYJnEEBiUxCRCxGSJQXli0fEvrbVjP1CIqHxY4rtqLC+L0zFcdGsq/FJ3 DwiAKiIngJdevIhdXUyHPg6zgbRFYSaP0xDn+Pow0JgGFroGd4xWZ2JPzvzhIZ57obau5YGAXUn Uq7HygoIRjeD/MGJHFesu1OcXbMJBS/o3Hqfu+0xqpeq0xnu9zC4hNyQZlF+UX4Bs8mpaLiqeyY 1tvFc6nIbWYG4+yI7Hp7MC3ha6AoUhBYdve/x2foMr4t/Zombb7zdL0ncBlPfBYr//Uk5B+ADuB PsmXYk/Cdyu/FBFTFJZP52Dnoy3hfiUt4rkH9ebSvS57QzB4t9CyDnPwEGvPili9ar6TXzu/xuH DOajoxxbF9uQbx2MCVYrLoDSrYdK8AY8EqyyRQKc0pc1Z4h9ag/VUSidtJIjuDYyCkoC5T4OvmJ rll0MfD9SI9DAN+fWTWD4VKm+lSK1gD+f9vOX67rv1VsJFrOQ2oPEycNNZAo/Ih1yjL8TSRvZNd 46x26+p0tkMukCw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: sTjHay7VQzxgW_gOEOzDs6720z9j_XkR X-Proofpoint-ORIG-GUID: sTjHay7VQzxgW_gOEOzDs6720z9j_XkR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX2TMRjkZNL8li f/7ZUj2qradrYoSZnU8X3oC3wLNiJM05eZZTkIUxyVcmKYKnsOiyBao96eV1jEr92VzKCQ+83a0 QTd44ntzm53zuBlloNFeIZwiKPCin/p2oUZjPHqv6JXZnJbqFG52kREMwmgo/JCZtMclGuy9O0z V+5eU4snzPZLW2ponSrlE4kCxurouPKV4FGfMk/91lYU+lCpr3xC52cdwkn/fPgR0y4k4SwGPF+ e8uaOXuFKWRqvVuv+FxZ/ZkNU3nq6PLAtVXH6yRgH2I6POaEtu36kg46m/riIPO3PY9Dg2SEygw 2hOC3+r3oiBsbNL9E3mXSHNRs0qUmWmPV2a4e3p2PzR3n27Eop/dEG0CO3HZJRaxYbMdFDsMYEk oGYJFkYPz12xkVfl+H2fIMhi0OUgMPYoTkdurzG08mlBibOycUYmqBHPRAmOhhtn5djceZ6w4PD O/4d2FLazclWpZnL+Jg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX4gAKOh6JzuH/ TmFeBSaxUCjoRrsQB3AJYzhczEug+s45TQTELfBRrvppRaxp1MgC3FuyVwqCoeBph6M3X8NTJLd aRHwSRpj3UljTQe+LXelkXiZcplTiOU= X-Authority-Analysis: v=2.4 cv=f7vdl+yM c=1 sm=1 tr=0 ts=6ab51289 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=zyovT9EyBzSEY6lazxoA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sm6115.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm6115.c b/drivers/clk/qcom/dispcc-sm6= 115.c index 9a7b8ad646ed..f6f5edf07f03 100644 --- a/drivers/clk/qcom/dispcc-sm6115.c +++ b/drivers/clk/qcom/dispcc-sm6115.c @@ -561,7 +561,17 @@ static const struct regmap_config disp_cc_sm6115_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm6115_critical_cbcrs[] =3D { + 0x604c, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm6115_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm6115_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm6115_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm6115_desc =3D { + .driver_data =3D &disp_cc_sm6115_driver_data, .config =3D &disp_cc_sm6115_regmap_config, .clks =3D disp_cc_sm6115_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm6115_clocks), @@ -588,9 +598,6 @@ static int disp_cc_sm6115_probe(struct platform_device = *pdev) =20 clk_alpha_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x604c); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm6115_desc, regmap); if (ret) { dev_err(&pdev->dev, "Failed to register DISP CC clocks\n"); --=20 2.54.0 From nobody Fri Sep 25 05:31:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6766047C0E2 for ; Thu, 24 Sep 2026 12:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251664; cv=none; b=iV8puRRThoysUhPFLB0ZUGrPWGQnu/+SMY3u/JtYR6DVVrSKk6HNAzLaGoW769rah9BSG/SqCo3jI9mf1YjfiVYS5yIL3py82w2Cv/6Sj12Rec8LH+h/vJsgxKrz0v1uY3uOPC9UxJc5lcrjgNd9Fh+ziJgZKge7pA94EDTAq44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251664; c=relaxed/simple; bh=+PKjOzW1qJOcRFt9jkyNFKMBUYcRkBbKtj0rZteEkXs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GeQAafUuiA+QULW62mqhQeQaSl8Inc/kq/2uHhp+0E30INbqFb1QeMCHt/qQeX87kSmiaRzwjXip7OadRuQaYhMZULRlfJBfictsmweUFswAOXacnMwBjaGC8pT6nV2hQiOVjWALx4Mqnm1f/5wXon9C9aZd9BsNbF6eDyrljGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AglOg0UL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gnyfnhps; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AglOg0UL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gnyfnhps" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4t3G803928 for ; Thu, 24 Sep 2026 12:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7NS4hgdEuI2Kn03sVLhMX8yjBjmnY6qzK/Yb9FsY/v8=; b=AglOg0ULxNznG+pD hoCMpYoPcN8KdU5CbM/c3/SPlKoXqPnYpcqj3s8T8ZOIbP3Uvw0/plyl+hjhbTBr xmcbF6BPE00vsaSjYB3x1DeagA537xvwtGx2DcxPvPVTtWfXUu9G5ziiy+HZejBq zuoXDb5OYpoCEvWrYipIodX9ZzHN228zvDQmNunHDwEzb9fykEYefNWXhXsnI4UM b/mIwTHunFyOUNXqkpLLZ0Mmi4NNuHqXbeuepYEqErl4h8FIG/3+8wC0khjIUYLH dCL+3HDPHH0r9OBaCFUb0o0fj9wXZ/JJj9T9A/UIRoxR4cnNYVarJSwQZte/I62+ aYbLOg== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8eyg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:40 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-78fb21aaad9so751153137.0 for ; Thu, 24 Sep 2026 05:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251660; x=1790856460; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7NS4hgdEuI2Kn03sVLhMX8yjBjmnY6qzK/Yb9FsY/v8=; b=GnyfnhpsRz+EwORz29R/C/Gf6nl5BE46xQuLp0us2J43gqmQ6qqravyG/7Nz69KEvm ZoS4OJhEJQ6CfQjt3jcIazR93Ovh3muoaYCNBuWRGKRJUG9TPVtVhDM6QpucWajf56Of XX4b0rUbxIo9B0JxmTUUemaa/FCcH0ULksKnGpw1pEoH4a2wzyv5k3P8Gav92Z+m3jcb xFJnis1QsiDAgEV1SUq4SDXQ/llRd/EYcjw9mqOGrN25d7+xe5KcPZh1TdB4mVYWiZgR noJoGQJiVaFcjWV0u9bV2LZpstWP0mttrWRCThF2UV6FaOrLe/epjhTjmSJM8ACkwnTJ /k+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251660; x=1790856460; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7NS4hgdEuI2Kn03sVLhMX8yjBjmnY6qzK/Yb9FsY/v8=; b=ivkL7CE/w2DqE7/KidSCOcZVHypcYzsVPEz/76JIRCENBf4l2Fd3zojXYiq4acGan6 h1bDsFPQ0r3gw90cO02jzGjWhKfe7GZEtU4J06wOsmNGqSGVSSce9gbChFAHUodQ5aM/ 62R9mBtIQo2b0qkOPTU01eTP3VoIizULTTRJOKudTKtqijlWH7gB+60gK+lWkwrU7/y5 0P91aNqv2L2GVIlRe7iO6SijIRkSv4FsPiygCQ2lO0pSkz0pN4oybxfjZzJgyxstI5FP LK2X4WVfS0IJwU6VQVQ/Yh8DPdn6bZcTEZeJJqQXSI0Qqhsa5cOKKInnvKwLiESYcxr4 pBpw== X-Forwarded-Encrypted: i=1; AKwUvByuxVZ6f/QTcqT7SKIh7oRHvMuYx6owOgeBB5ehB2qpsy8jgHXLtq0MffX6VT4qB4zPi6bVOgv7wmzJaJI=@vger.kernel.org X-Gm-Message-State: AFuF++kAGnW26sEiwEOlMWjEYG3DTDjEQ5cyo6qdUxkMmDrxJ91ebMhI SrIThSKk6UbWzsGW+WIqGpQ0WLH2WB0JchsA01ZMwQoCdXf5IhCLUWyHy2v6gCxl7qFfOHk1mwF C66AjfUk39Y/+Qtj9og+CgOfYONaz3rYflNVn4C8e8elhzsZEhRcbGvAzl9CXh5byZXA= X-Gm-Gg: AYBFou2ii64HrNUwUai6UpvNnRxbr9WsesPckpL194FCauTBAUD6yHgiFRAxjc11gOt j4rzgfDAWsx/BOhBE+Ro1i0ksiQrM1vCDJMb4U6OUpnGyGo81zanX3ysRdMsK3fIABvC/fUQuhs kLLEyrtvZEDXT+NwYPK9JLsx0aNJRJ/p+52QW1IYAV2Gszq/h53oCjRuI/d6iXRc5pgUUoMxCw/ XmJsFigLduT7YhuROJ7Te/V9Qpr89BOEce/74gCDVmWN37dwsr1R8v/Tg+kZM3BRTV2t4691eBM n3rR+Ji3D5LLvEy0VtroCVyV/vmRdpaKdU/0Gqr9ktLhLB98RjugNpLpRhFdnM2kCSnauCQ9Gn5 2RWZopalW X-Received: by 2002:a67:eeca:0:b0:7ab:f5c8:4e11 with SMTP id ada2fe7eead31-7af1f40f506mr732848137.35.1790251659534; Thu, 24 Sep 2026 05:07:39 -0700 (PDT) X-Received: by 2002:a67:eeca:0:b0:7ab:f5c8:4e11 with SMTP id ada2fe7eead31-7af1f40f506mr732837137.35.1790251658953; Thu, 24 Sep 2026 05:07:38 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:37 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:21 +0300 Subject: [PATCH v2 09/48] clk: qcom: dispcc-sm7150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-9-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1681; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=+PKjOzW1qJOcRFt9jkyNFKMBUYcRkBbKtj0rZteEkXs=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJKt6hYAF4jDceApu1mi9QJGM5gAV8SaRoLJ WuUJRELyOqJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSSgAKCRAbX0TJAJUV VpESEACiLFBQM6O5ftoSHB872E6yzFQI8+yupOXgPvj7AlIVv65MOalLK3VO/CnahIolCUtsCOi ytJsOH2taS+uff1QZHNXtP0FPsoRO06Z+JbeDvmlR7f9u0zbM2GEi/DkoKY6EKqmh5EeQwKrRqO i390cJbbqPau2h1RYTEbfl/UD+mJILn6H6duaTATA/FE3utEA6rG0H2sWPO/szGTWkUyZnryEgg SgcvyJOQHpEzStrxn0HgEE94Z2bNAdrENKt8ajoesFKtzlc9Hr68+g0dNkPqtlW6phi5b2kch5R dxaQBdqpbbJhuyDues8+Y4Zdg6cyJEGfls5jgNJ9DeCNblyWu9sDI1dkiuImAcGV0JZqY/lIavc XkR5jq1D5rOPhdmrK6mUTlJLI4At5hlSWvzC59mwMh5jmhhRxEFO5YrHTsFsixt1K+an6Js8EpM aKvFEnMklncbZ/Ytt0RTLcvTAjpDWWkSI7grxhewBRGPh374WJBRO5jXQW0oQ7RsyOUnDkxsSw8 u4TWudD+pIwjy/w27zbn3aHGS636cNfmPjfDR/Oq9rFPPvUKpMwuCIdTFAC4nUaFC46/mpialRu ohfDga3KK5XN/HOAoPtyV13XPf9VbsEcwKKlfTuLoz99MCueUhkohGyTTXEteXq6K+V523Rm0wU +RyCKKUuvnzSdpg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: KKalEDtDlx_s_dt1eaW4Nu3n6VMOGYcI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0zbDGfC1d2wV ZHQMgw9DMrHIueyhEAW4swKAK8Z7eTazXCbvT0Qrrtx7lwQv9IpdqSGGEqkxyAwoC213CYooJBW lC4LotXVpH7GuPLWd2SWqkZBBxUeAXVEl0NpmdwtYo+rhjQR2KdF5n8Tj+Nnfx6BYpPQXVgupv0 pm/SSiaDmsHztyFbmdlMGFnwjs1xW9vMdrAIyxDFqqbo9/wOjh8JKycXVwF5MGZVvU/CWGKKYB6 5cdTYWhzx2oHGvo64BAbZHp8CtNmqG26dRk0Q5xud5qEbMNZvGUlQMfr73PxBc7UX0X+9YQbOE8 C+qQXhlNtAweN3pYv5dUokQpJqBAyNxmtFYJre9vNN1K2zABeC33eWEqFK9TD/ABYBWRTDwUrDW 7QH8riioDB/nN3/+XHK762dZYNkd25D9PukD4/c1CHq0UrzrJoUSag823JWdyYBTPg0+BXiq9xL U5qmL34fEirXuWF7fcA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7EZlixCVnJBK F/w8J8fMBrBN0Zlkm4Zowzy+8E7aU8P4K8QeIu5VCHPwWEZPQDhfeKMIrc0/B4kzsHEU/JgxwJ7 0m+AvsQ71u9lS6Bnqy+okYOBxyMM89o= X-Proofpoint-ORIG-GUID: KKalEDtDlx_s_dt1eaW4Nu3n6VMOGYcI X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab5128c cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=6fVa3aOakVPtjiFSkAIA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sm7150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm7150.c b/drivers/clk/qcom/dispcc-sm7= 150.c index b9df6153e50f..da7610856e56 100644 --- a/drivers/clk/qcom/dispcc-sm7150.c +++ b/drivers/clk/qcom/dispcc-sm7150.c @@ -963,7 +963,17 @@ static const struct regmap_config dispcc_sm7150_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 dispcc_sm7150_critical_cbcrs[] =3D { + 0x605c, /* DISPCC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data dispcc_sm7150_driver_data =3D { + .clk_cbcrs =3D dispcc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(dispcc_sm7150_critical_cbcrs), +}; + static const struct qcom_cc_desc dispcc_sm7150_desc =3D { + .driver_data =3D &dispcc_sm7150_driver_data, .config =3D &dispcc_sm7150_regmap_config, .clks =3D dispcc_sm7150_clocks, .num_clks =3D ARRAY_SIZE(dispcc_sm7150_clocks), @@ -991,9 +1001,6 @@ static int dispcc_sm7150_probe(struct platform_device = *pdev) /* Enable clock gating for DSI and MDP clocks */ regmap_update_bits(regmap, 0x8000, 0x7f0, 0x7f0); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x605c); /* DISPCC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &dispcc_sm7150_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63F547C11A for ; Thu, 24 Sep 2026 12:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251667; cv=none; b=KOwXwrPNaGOoJ19F5pX8YBhBt5KYn6ld2c4007ECVUtWEJwjd7G5jeavauY5GP2sFUFwcPY6wGrxSOKIj0dDjBWJ1mOhx+mY8dRylOXgpDzW1gXXvIYT0ZAZtsvWtB9D54LTVnAfc2sCwXm3JmFKuJKu+MSgM5Sj7jWbjWp1FFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251667; c=relaxed/simple; bh=ln36Hj6KcOVQga3cV2n/3n0DleS9IFTsnosLmwz6Jqg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VenPsoyzzGWswmozyRY3XPkg6ynAqeEiYlMVghSzM/Dv6y+t6TgTGoXHYFdoE4gZJlH0ojCFJ/+eNBqDVEh9snmY06LD6/In0gEzSR86j64XqdxTtxo6ev5LksqVEUdpP+lQzLsYgR+UmZcBkMkXPvV6MaxJETyUteUEeY0qjDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nT3jWqwD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B/veWwHn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nT3jWqwD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B/veWwHn" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4s8i1630757 for ; Thu, 24 Sep 2026 12:07:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bUQ9oqq8ZI+JLx2cOtLyDRh8oQaGB19xWAL4U2iaC10=; b=nT3jWqwDwqgNYNeI ZOz3zhBi1ZIeG0YTPU/hmpSifZ7cCxak9O0lVWzmoDVJV0cxEg1SIqrQaFJso9km cuzML/J1V/nT6fRda3QHTE8eXtSfo2wSrfY0sSegruPi/nFBxOKJuJ1VevWg0Sxh //7Q8RnegI/tPcn6JwUcJb/JkDuG+SPJvYR4E+izpwht5wedZwt0HKVcOxITcKfu wYguIR87fZkGxkplDWyodaMEH8gutdMWWGhgarsloRVJqCOK2qITj3HL1HxfVnA1 akgzYwrbDmMBBh2/ROym9ACK6Vv9yZqAd7GCW3ABcp5lIS6y8kobdHGB31gH7dI+ ld6Gyw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90ax95-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:43 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-78a58df134aso566176137.2 for ; Thu, 24 Sep 2026 05:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251662; x=1790856462; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bUQ9oqq8ZI+JLx2cOtLyDRh8oQaGB19xWAL4U2iaC10=; b=B/veWwHnOQ5TsapPpVh4CDz8egjGmRUm4a19BGth0LBUtiRgXlqd0Bx4IqXNXoRdRs pHNvq2n5NTdWVPcDWo8wIiqLFs9TlpUp9hmnuzbFZ513IqrGFZSlUI+YSAVadjHHuZhu 1r+NhTVEJWiZt1eeBSOTXWvrGoThkoBGdg4xeIWOallnzJcM70Cid8QjFE8b/2BrcQLT HDkgGEBrPJ/72u2vKd4WZgxsZZSuMQLqfyfqKeW3CEkWyFoIy3NVgdbCDzx4qLOhvVfp 6tGAKw1J25Kb5+3WvkLEmeO6VZbIqj+28uhrUJwgC6EPEdOVTXM8DDAi3cKVr+UR0+j2 DBng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251662; x=1790856462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bUQ9oqq8ZI+JLx2cOtLyDRh8oQaGB19xWAL4U2iaC10=; b=powuzUWSXj4kWed5Ld2/afNC3FYChKKvag1zFd5NWjEW+myqobnuzgaDkSmIE8vwNl JccA/pRfAILxiug2hmD81IXTdNvEzG1gbWQvHDPTDzxGjHZQdDBbwcCW4Y4IXaq3fN+N wkxYqlFRqSi8G7Krg3WcY9jfIy9kFhyaoWdbwdpot9s+jWBvs8RBjno2aM6/UW9VhRxR 9Vf/uhf3WfsC/hRWhBezI+IXpPIi7py8S0noutUQ3PLZPCls47R0LuSWCCUcqQUgH1u2 EC3AZNFYg+Ev7BwnCZ6JlXbCrpyuM5SpAcqAxH/g43XIa69qEJhaZFUvw62zuS+bIqgL OUTg== X-Forwarded-Encrypted: i=1; AKwUvBxUXw4wKwoDKy7tG9vatq5GZf8uxIgp7CYmu2MOHuQ8xTzLcLnbTz4D8tpZWBLSStaUmR8xiCcfhUb1DdE=@vger.kernel.org X-Gm-Message-State: AFuF++mz/z5LwkFEP4gYwJfPtjddpYpJGlW0g/y9G7skYyY5RpaGEz4h PwqTmqTY+8cVjvqFDIHI82UGjXY3NIit9TX1H7DWmfn5uj6z7rMutlI5F2YX1Q2DH7n4CqYoart loCMZy8ZTkSf1BjsmBIym3YISYWUXd+n6Qdi9SKkc2+PM/ow4lwIUQKGpwb9j3QLCacI= X-Gm-Gg: AYBFou0aJbNdRfAvSfAuW52hECV0c/qXA3JDgsl8YVwB+tHTG9P8znOzwE0HpSNJZHC eMtWleqkhP/8wnPCgUyiEd10zz9F6rXnFxUpTjcJlZsvWhErD6vxmNulNKObNMni7qAgdfQbJV+ wKpk/XrJO3XVPGeslBHhuLXrUzgr5TwhsdssrErpW5FCYZS1u8NmtjwDoTSK5X7ERc3Viwc6k/2 mfDJKcVO4SBY3DrJf1tZital6DMtuYH0D/HPZRu7KTTzUoGr+6NKcpK8fgTmok/rUnDDrRuvO4F qNrK/K1VJ6OXBDkrGH3KGU2aWhsOkspnyzNqmzoy+V42Tc1izwXoezODROBt+YvCss7789zVuaq JEd8D4sua X-Received: by 2002:a05:6102:41a1:b0:7a7:19aa:f0d0 with SMTP id ada2fe7eead31-7af1eff6b23mr934967137.29.1790251662278; Thu, 24 Sep 2026 05:07:42 -0700 (PDT) X-Received: by 2002:a05:6102:41a1:b0:7a7:19aa:f0d0 with SMTP id ada2fe7eead31-7af1eff6b23mr934949137.29.1790251661569; Thu, 24 Sep 2026 05:07:41 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:40 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:22 +0300 Subject: [PATCH v2 10/48] clk: qcom: dispcc-sm8250: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-10-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1714; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ln36Hj6KcOVQga3cV2n/3n0DleS9IFTsnosLmwz6Jqg=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJLIVtMpp8ji+hnjq9GuAgLPArky/drRg5zU zqnXT3OO62JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSSwAKCRAbX0TJAJUV Vg02EACkoGt2bk39d5RHtziiYzGD5M8v77Z0nyqV3u+0+Y8aQ1JloklKYDAe2GJJATprH5kbaNY 4T+LQw/Hhw2hvVFdOAjkLEJ0tD82aqxyqAdFe3RHM7JLhSo8xn3hD1858q8wzvZ7aIZFsVbcvWE Etkxo9bubwUzoT1/YWD4q1U6VLXcM6hrhfYL8SQq7vzCJBucM9jMgKfvFdHPLj6Os9nYfWRtUHp ifQ61wEicbQT/b3RhKshoS1mK9Ds4xRuY8fUWBB1HRi+1kt3tegXxuw96c2b5Cq+5EONO2I2FBc 1IiqQE+9gqTVLX+8shczZXgqTpzDz3iFvRVUoSHar61vT/nNT9kS9TgII4qwVnyEwZXxUHfPx5/ 3O1NI/mzi3GQzjQpeWTsAkvuvwprMlHjdTcqGZFXnh19WjoKf4v6MDOJFlu29cpm0ELregO1yuJ XN0XGiaCs0XM3N97sjgkbcIDZl1Y0wx2HS2EGnQr28sBbU+ek7uyVs78PvUTNkk8A6uIDgQRe6N +jmVPmbzMW+uNebAxR1VfsJW83Zl+6+qTFiwZIKdq1TWIN+4ViZgSvJ3fhKTa+c7I2YtBHfi9WB IebtV3QoeBMoswEkFPgP/whsUjt/XIofuNC8IS2PcgZbkrSxJQ30aRvAiiBYQmb0aHEz6R8GN/K 2D+S/K/0MN4EJhQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXwugo9bcF3KdW ym1nlaRRLLg0hhZ7r1kgjuBkr1dPzG/PXM2SsSuVlvrF/1QM3vD3EcUWy0LsPHETehzZtI2UmOF L9s9NUvC4xoudPp4UzH73oM0EC86oGc= X-Proofpoint-GUID: ypRj__xe8hoADNsftDXw8UwKpcSVAMSI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX96OFRUhFViSN 9j8YCc4OUWbVdXG9v5XLmXH3HRLBlRj7W6WLqaFNj0I1uKff1AMu+OEjl1Rx1WBOMsd+lthzDkS 9Nc2Yop3hqP7BOHWMY7lfcbHb79rWQrPCayM9NREMiB7xf9d3KdQYvNRev4VEFWY843vPwUdWep 6+fFtqFA6a4zD6Gxh9TkJjKEXBDoc9oAZmrGCU4XOhO41Cu5AUgDsdv+aedv7eEh1FTdZXUp0MC XkDA7Z0JmBThMJOKhosu6v/mO2EgoYcWa8VQx0EgG9CTMNmUX2xB0l/wkq11ucuSB5qCvEAUgTb 7ftPs9wRG70qSoXi6bnnvBj0uDoBYjvfxpPeVt2lWfruR3YThCRsQvVQTn0U98GJWHwhs+9wmUk moUe4HzXCZ0nwtW39vegXgJamO9xxHdX1W/JO0FjevJ9LJa6947xNboFOd10/67xLnQwe3HqPYk wO1Yrsx5jneyHrD2WwQ== X-Proofpoint-ORIG-GUID: ypRj__xe8hoADNsftDXw8UwKpcSVAMSI X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab5128f cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=6NcTdUUM2wu3ikSZIO0A:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sm8250.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8= 250.c index fdc07323f298..dc62eb18deed 100644 --- a/drivers/clk/qcom/dispcc-sm8250.c +++ b/drivers/clk/qcom/dispcc-sm8250.c @@ -1232,7 +1232,17 @@ static const struct regmap_config disp_cc_sm8250_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm8250_critical_cbcrs[] =3D { + 0x605c, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm8250_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm8250_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8250_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm8250_desc =3D { + .driver_data =3D &disp_cc_sm8250_driver_data, .config =3D &disp_cc_sm8250_regmap_config, .clks =3D disp_cc_sm8250_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm8250_clocks), @@ -1370,9 +1380,6 @@ static int disp_cc_sm8250_probe(struct platform_devic= e *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, 0x8000, 0x10, 0x10); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x605c); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8250_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C2E483819 for ; Thu, 24 Sep 2026 12:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251669; cv=none; b=O/ygreMM7OkoiAxomA/FLeK+XFb/oe7qXdlywHowVcl+B67ELViMVSXXDQE7CWDl4uyHhBgmYxGUxV5o2VOK8NU+PMgALh9QGId1frPxqnV5nbdeNO6IfAN89hS/UVnHP7uaRnFTArXYWEyYEmF+JtAzg0M4875rWBDZoW4Curc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251669; c=relaxed/simple; bh=4qZgZvfQ1UVNLqQ1DQ+DesEZn6jUeXUBklv9SGrgPXk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j27QiAY2NTJBh9tePQOckBbzyeQiPHRTkF9oGnRGROrpmKZw2LamjX/3Gkm5kyS61zn6fHFsDLzqxQrb0xNm+JY3w34sx2zHLbcQT9kc8hz9hIYdghYg7mcGjCkRaP7qYFCENhZ6mDFoDi7w8bruXHCjXbFnU2AltdaU23adFvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fu4QGQdL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dfilKwrl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fu4QGQdL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dfilKwrl" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4Xgl2285456 for ; Thu, 24 Sep 2026 12:07:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OWnd8o6a3F8+dW3ewYtgcqbzJQnTNjuMNsusaTfXk/k=; b=Fu4QGQdLCX2euCKA BxIB2CCbFsHudmBqbEBgVifCPBa/1J2FWhMXwKqVmPSoTe1HMLC6/myH+fz4RAp2 q+iHl0KJTgz+3UsQ407IrsptzQ0qJ6qqcbGxcN605iZ73YUbDOU9AnwhfwNGVm41 02pnRetRtNhM1W3nLN8gfD8iqu6NxfSGudMpzFyeg5BcYClk6Epcq997j6nV3uWf clrK+7VaVggax5F9KJHaAkLtQcIx7YG3eNjztHHPUAV7gxmJQuy8RLEVDVeRVl4C xcxtw0xGkhsADXdq+rBd90kJr3giqlv3HrEMWMg2j31pzX4mrNlojG9OX+6pLy1J 4q3eYw== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvx8ahgm3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:46 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5c7a3b3c06bso790133e0c.2 for ; Thu, 24 Sep 2026 05:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251665; x=1790856465; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OWnd8o6a3F8+dW3ewYtgcqbzJQnTNjuMNsusaTfXk/k=; b=dfilKwrl7GCy5iviiSYJuBOysx/VCtQvwaL53ydOSyIwiO8mc2gHgZ3/gv2cRrMSPy wtzazvJGqOttDCOoq7iS6HlHesf41QilfRAe8ZcH9C6mZ/oSXpyzUW17TG+6IzPKLyCP zncxzG2n+8ZQe7iHRwCZT3OvSGdlfiVytiITQEL10bg4fVp9Mf56ZfVP8NylLPBSd+1s Udh4PFTS3fgzqEvjFar3PaIcKODwLQPlFA2do2Z7yU4DqNcUQX1HFyenvyEoKfChwI8b aNv/xA0QMpjKxLxWXQbEnqkTg7JwvmpyvFpDbiaSbVBuB0ejSM/h1kYZGYe6QzSZY6Sj Eh/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251665; x=1790856465; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OWnd8o6a3F8+dW3ewYtgcqbzJQnTNjuMNsusaTfXk/k=; b=iqwzlfp2EPr0/Plw6p3tagXbtz1fXWXWrg+9MX0DMvrObwkO8zDPfF9FSeqVT6NiZP I7Zy4/Zv4wnku1ILqJWvLbMGLOJFPe+01xT8C4TOGNkCokwfiJU6zue8mev9OJ+Q5SMh LLPO6uxe0azbu/2P7irjMiw+aMV4DtMEhJ2vvbacP+MQQPyzA7bcRxEk6FWKVw61120L j7aYiGLeOtXPH2716hXdi91z5/undICfNm/zb7kiE9BgnfN+mpw9I/houblFDsMF3eRd KSdOCloqMrCuxAP33cj0sJZI2m2see8W6Tr8CiMY1iE74S8CpywuScXKWiVOuF536UrX yNXw== X-Forwarded-Encrypted: i=1; AKwUvBxvbFGYVMRBbhq0QEULHFzFx4YEEpNdndgWimTcoJoaJi11QLdwpueqT48PL93LkIUpcJStLe0VzpwaoR0=@vger.kernel.org X-Gm-Message-State: AFuF++mJ4Pyj4fV4M1FaukbZ1EEkkK9ZzAI9R4JrWO19TiH7HEskyehw dKRYzDqamJrBVfx+yApDnabBzuvkT3ku+l1eXKWTbBomWBq6aVkzmhn+td6hy8m0S3J8mFb1Ogx P6laZgmhpUZSjc2/GJfPIEuVu8RL2m8ivquV5DuvQ4xmWzidlvS/A8wLJlVVQSf+WRb4= X-Gm-Gg: AYBFou3SvEE9DbLTrRZfJa7ji2gZe0d/tYk8NG8hsa1nNGxSwoir7duFr2j95YtvnHu hhZqNTQaLk0AQzC9rt3MPX4g4x84WGeWUDZP+mkyx1H9MCWB+Y4cnP/cHYQYRCDrM/VIoTZjOEr kSRkbJs/birLV7WrjUVWt75BBLcABioRtJN9DWZc0Jo0iFBYe98xtp3NPAI57/yAbGpl+vwuO6n vw4Ewi7mxpl7xanxFw2DjaVqx/0OqP5b5ubsrh5UzNhUzplW9Gt01UY2coyRBpr030JGMN0emyF OH3YlnCvFmthFVDFzpGRsiygjIbKTEWC6FfgzTE1J0PlSp6SzIXjFxB/NlmWHYw67jmnV8+J+SG YGdfDX7bj X-Received: by 2002:a05:6102:41a9:b0:7a6:b18e:6d5a with SMTP id ada2fe7eead31-7af1e4f6363mr992995137.17.1790251665015; Thu, 24 Sep 2026 05:07:45 -0700 (PDT) X-Received: by 2002:a05:6102:41a9:b0:7a6:b18e:6d5a with SMTP id ada2fe7eead31-7af1e4f6363mr992978137.17.1790251664460; Thu, 24 Sep 2026 05:07:44 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:42 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:23 +0300 Subject: [PATCH v2 11/48] clk: qcom: dispcc-sm8550: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-11-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1724; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=4qZgZvfQ1UVNLqQ1DQ+DesEZn6jUeXUBklv9SGrgPXk=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJMQcDPMs9FBoowBl/FRyf6SnT/oHvfXI1Wo VTPiF1JKGuJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSTAAKCRAbX0TJAJUV VrYIEACwW0+Rrz1sX0qpkjBslo782/gpdPx8+JiFBriFNAboypzZQWguW34vKJzoyQ2ACbSNHkj TKC3h8aY8ece55kbba5L+69wBSu4TRtQYiScX263SECpCingz+apxwFyg2Ic5LUIlP9GWTww7do VtqUc0+hpu2gWtaqz5LkiiCj95XlNRR9N4ixurvMxvzwpaU1WpylWLtdTBkmbdiJkGgXZgTBo5/ gnChPKpMyKVbXFr2alg2dwloV+GPNs3XSucrs5ZqNYVqsCrg7RscD1D1TbyvgfDf41vH72x7REs fkh4rQr6PC9Ajj+yRrydvWa0g0wMCzlCDN0da040lk+/CFfbWOmk6F1UL7yYaDQIiZ4ELTGs4Ej yMQ/wVDeqCKTZL1XqcsBrCKW/JVaaTK9MbXAxCdPnqQB+0JtYjitXAbh4IeVSkua/TBs//NG8Wy l22Hb6+llzxqVUZa7DfT3Z0YSZ7jkMLMcgzvUukF/gJ/K1PBnmSMzQpNjBV9iko7udH2XpoNhlc pB8vukuOOnTgz8fcJtns57I8I3M9AfjLOxE/2Lu1ttxC69aR2hjth63G0ztXcE3aFu4aNk+WhyI 2DOy+YZTZ/rVuJj19leSmaJR9t1S8V5wChNNuTtfx/HUT8W2SgzovqagV2B7sZmKMNkVskqfMn8 65xqD6pVed1lOYQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX+qUHeRs3kAtJ bPh5cgmVTRi18xdw8k9BLGmXStbJXMlEDDoUtc6uHfaqTCrcqnUxGmYgxUmSCG8nHUk0lpZ3D6O MW+vtmC7LGeUMidWisAanp2rYj5nCgM= X-Proofpoint-ORIG-GUID: wBYDMvELASS3W43ucfFxHrZ-uAGxyifO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX2qgNbXOmC+tu RndgUedPt4HweKFG4XrMSBPBLx6xmSR21YdFa/ktKvsc4SwpZqf7h3RmxqTjadQaCGIEUy7JZFj Nu8Wy60fI4o+9owX3Ptzsim0xjbaq6iVOQkN0xxE3oWQiY5ppjR57vkM+zFWspSLKAMinH7h0Vp SV+3Xc3zVDu5yE3kY3+92Qek5cb5gStCMNL4NZ1yBOK24ZdVTvqGo5OM0DFIJza007Ah0vBtIiS c1DOJL2t7mb0GJDzlBdttA0z5+5DpGXceyBEGjpaxKqlwvSiQS2pX7j8uJkRKVPbaJnkcDDWkLm tw/zPnI4wi2zK+zEFKpOoVhKV7Lo1+opzNch+aUPL2VIsAEzNUcE6u1OxVlrI5VqLiYZ2wACyPy Pd0h/J5RgDAbM73Sf8QPqKAIZldfhSMb1ClFWCqvnzNirarQG8FAxdl5wBe7rqpWe2D1sGTRVlT ejuda4y0HUr948cD5kQ== X-Authority-Analysis: v=2.4 cv=a6SlZkSF c=1 sm=1 tr=0 ts=6ab51292 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=Mkos_PfpLiWYs3bmBbQA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-GUID: wBYDMvELASS3W43ucfFxHrZ-uAGxyifO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sm8550.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8= 550.c index 418dcea20f00..030fc7ef1fbf 100644 --- a/drivers/clk/qcom/dispcc-sm8550.c +++ b/drivers/clk/qcom/dispcc-sm8550.c @@ -1744,7 +1744,17 @@ static const struct regmap_config disp_cc_sm8550_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm8550_critical_cbcrs[] =3D { + 0xe054, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm8550_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm8550_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8550_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm8550_desc =3D { + .driver_data =3D &disp_cc_sm8550_driver_data, .config =3D &disp_cc_sm8550_regmap_config, .clks =3D disp_cc_sm8550_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm8550_clocks), @@ -1800,9 +1810,6 @@ static int disp_cc_sm8550_probe(struct platform_devic= e *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8550_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E8E5484234 for ; Thu, 24 Sep 2026 12:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251671; cv=none; b=Fx3MRKDzB/ULSxw0IuXRdmQIuH41VOWZ3ySuvRACGFXYnnpdd+qw273EVXdNVXWJaiD1cXdkuLw26CHFI+9RrvEGudafAyKviU0wO5VkLwLlf10fC5GwVSFTa5f5wjBo544iWHJAGngypqpFOIUcI0kD972qdamgyUNnv/deFgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251671; c=relaxed/simple; bh=kUjOKgxIB/NpCDTYT/AAzaBzYBYfrFXzs3trDWh3TA4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JdSeXWxPSdN6PEOkPodQwjf1bCqfZWa/r0slRmpCPq3CcIoHEPIynv2LJJsrHoAC7LPJB8yLhQJ5hrsAAwsGRghBFHTa/I384bpnhJPxrjyngQ83yYPpYBA96LVeqJv2muFY/mBmdpn7bH/UBE4UGOE8oY8enUWVloGQRueQ380= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jX0pII6o; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P9qZAQ0n; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jX0pII6o"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P9qZAQ0n" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4thu1630816 for ; Thu, 24 Sep 2026 12:07:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V6Uxa2rM+N3dUq3DacWIBco9CYz6uwfZusKVoC6f3q8=; b=jX0pII6ojuZRwVAi paPgWOfjac3xUHk13x7aKKrH+fy9i/gnJXxp729w0YTddckPLpC/+m0W0WFQTRlS DDb5tviOjYf3vvg+F4DNowrAOvSSeEX3qyr5dyeFSYuA5suvLAZAxiFngK2dO1df 4gjgUPVfdlEAlbvF+v/SesaiiCDP841HSDCBhm6G+WhbyBiarfW+i7UteF1iPTd4 eykj0rha1UoLbS1wPrz6ON3VV011iUMHous8gKIKN62eJhfMA3rzUub+5uF8kAii NzXi2liA8N38YTTAZ6VIlPSCba1lgFb9/ZyzG0DjYt/xsKMGyIOU9GF9oPDD1EeZ eHEfZQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90ax9q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:48 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-78580a6b2fbso662124137.3 for ; Thu, 24 Sep 2026 05:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251667; x=1790856467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V6Uxa2rM+N3dUq3DacWIBco9CYz6uwfZusKVoC6f3q8=; b=P9qZAQ0ndoGYqglfDc5dhTYu5NRTBu9JEljsaNaZp+rfUI8b4lR7sZKQqJ2QxMuvH3 09T8tVJT6/GFppp501VmGsdMyPgqT4Ob6dUCj49TEuy2wAgqVzEY+2xTcpqKPh3bs+xr ebWXqVbt+pSBjwXCm/YDiBu+81hcRbdrSEZ+c14Lbz3AKyHxIlkV5pZ7Bh9XihASaJRg dr7F5Jy/3YpGkI4yq0UThW6bygjgb3FWgCPOJ6vj0UPK3ZLBc1m8zxpQVAwZLfWb+aGl t6RWO7m0hkqbWoy1p3J8cOAxae5HvawGL6D5S15vv21YMx+xorBm422O3TfNPQvgF/Dt w0cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251667; x=1790856467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V6Uxa2rM+N3dUq3DacWIBco9CYz6uwfZusKVoC6f3q8=; b=ToL0haU0qFs3bEz4PBOobqk/Z6CEjEPYp24Mlyj/4Iw0f+gqh/ece8SaNHwfpNDPpv XEJ8KpPy4zjK6ZoBbPc6XhWowOrmoKvAcbfmI0hsawJrQx40Q+yc1Q3FuUIrVa97mB7W uLSR9eAlPVdQIE5N4z8fv8Ei+gkTFL5NUX93LDAy2zSVPSWn2GT2RzWncQkCY9+JfL5K AS/nfkd9rF4HnNi/ATqlu44+5cGhGBOiDgfgY7X2bGZXsgu7hHDC6cqFoWsBXibU0Qer nON4UVMNJC/dII2ttuh6SHkn8+8mD/pGJk59S/bEedQsYqo1DC7Y1M117pxQ4XsIOCbK p+sQ== X-Forwarded-Encrypted: i=1; AKwUvBySAj8coQ5f1YCGDSjkrUXoQ0GrR8C7cx7iv2+BRoUO4igxkA8zRfvWCScmCSG/B9JRyjEiWl34jUVZLZQ=@vger.kernel.org X-Gm-Message-State: AFuF++miL95Ph2zqTmof1FkRmujvzUhyt1H+nOVRj4gy/Wl2CBmP9M5F yRfomX6RWpYxeaMbS77D7He6r4hsh8CTUWCn3wzokMzjCZshcXYGDMjwzencaMFEyMtIU8oABH1 3q0FA1vX3P8JUN5Ap+e2C7iY1DjXPOcn+w0OUdo0d+jSaE+yeUl1npvx12ixd9Kt3v5E= X-Gm-Gg: AYBFou0gltsmIchxtIcUoRLODHOJz97QpcxBV5hmXf0DfnFrV7lVNmvmfFz1YjJYMVK WQS7xgZcGg17Y3DBy+8dVHG1o0syrb6MaNLxclcjCP2zcn4542iUhGlkiEhTpbVG1+5Hd1EUihC sAjhChTHlRTAsArGwo1mkC9ociC/1qqgv+LWwfjNFDFnuLmYypy89sJZwGbz02goS/f5dUtOn8n XrgWyRrr0/dO102ZSQtS4WV4KEM8/KOAJvjMzJZAVnUNGXvElA3MfuFVIku7ZzU7SABo6kGV265 i+O/zTPcl72bHJDjC3BvmPTrXku8Rcs/Q+tJ6wkaADjCnhUopWLnkUKrpJ3HNhzrPeSTsjpSB25 GMJYW5TaG X-Received: by 2002:a05:6102:8098:b0:7a6:a661:efe8 with SMTP id ada2fe7eead31-7af1e4f74a0mr873637137.22.1790251667040; Thu, 24 Sep 2026 05:07:47 -0700 (PDT) X-Received: by 2002:a05:6102:8098:b0:7a6:a661:efe8 with SMTP id ada2fe7eead31-7af1e4f74a0mr873620137.22.1790251666255; Thu, 24 Sep 2026 05:07:46 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:45 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:24 +0300 Subject: [PATCH v2 12/48] clk: qcom: dispcc-sm8750: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-12-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2073; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=kUjOKgxIB/NpCDTYT/AAzaBzYBYfrFXzs3trDWh3TA4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJNfYqZQeRYjcdexfQGiAopAofdf36YCrYCU y7AQ+Hckh6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSTQAKCRAbX0TJAJUV VoKPEAC3TRjLh75i5HVl+XV9dvWnQigWYWaf30n6m8T7LP8BBNI8rJtiTsx74BpPNw5sB9/TwMV V8GWybtUMMC2Fcza1rUYK/fy2jzExuWEuaBROyumxqWWW0NK1g99IIJNcejmPXSvlVFaljFHUfJ owJYolqa+7U2oZdft1lx7rrMQfqxaUQ0Eh7VSIgYXNnVfBlaDKLEr+w6UnIbcnI/BoWi/st5vTD L+aoLiBeJ4e9YxbvsuL0+iuiMFwtPcCLWVRaoUiKGxDZAnBTsmz0N+wjKBeevRseg+aVYZnF8v8 VYFUCdqTEC/EV6B3fmnQtOdeBWq+iCfNJfR8FZnfwkfwB4WsmlXzZb95iOk1awPSE3bcB9VEwcP 3nGV5mtsDH33oMzFLJVW1zjS756Cmc7Z2vdgH1jlfTyZxQ2V0/Ixh6U/hzl2KttH4C3VL/hMLRd 8ZcLs0poim1Dko4LuuunMV9GUl8isloMAXGSXqc/Z7HTyiLxi4iybXnOgQYHPC6u9/7/iYac4ne M9+QJlHuRMUXsAAd5TVK5AhZ3MRHPiH4GaMt1kPdF6DtI+DZJdofJSLFV6S3jC5UJisp21IlCDx Y3JKv0daBqLtwSuNLQNHpmxcJwdMYTatRncVjDREoAr9LwOWS2lmOLInEbQ02xeyepo5ObYtheV V43beArEoyL2KrQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX165MC7VEDiwQ 0xZEVdmZgRJoqJxIM/heBVBavTPe87OWW7H8YtaheQomRF8tP3Qb3Ca6mFAyfdiIcDulF9AcssU 9RQXtvkIvD3fWBRpXfp7gz0oikfzAEw= X-Proofpoint-GUID: Ectjc7iSUIsME2C273BrH9x6ElSLsvgv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/3ilWKxXga2r o+d6wnI31Yez+CLIuuvqWZtquTWXx0KoL2FeOTDY+WU7QYGcSNxqcuC4lmm/UNkyXdKuNMOgPjr g+oW8jCqNEDh5yManPOeJK07cvkrSkqtlW81WAT4psIZU53CESGTOZJcL6TiB4nPq+Ey7ZJ7Hb8 cfCdH/3160SEcO7tYlmVA/vdX0wl36/bPiOpBuSEN0syKbIMiBXEBkjiPwWbjvVJ4PnIvuhk3ls NQhowWufl9fhGi6dB98Kt528qjgkDMJY5X+IbIgEINsbCbR80eS6W8BvOw8dOLAzRswCHmmOfXz DsIQ7+JmVoPB09LtaHW08SSYnF90WEqcO7A62WUOSUiiyLWYZCPraqz/HimqD+gKFsf8lX0EXMg 6EvZnoV1zNc8GbD8kUG/CUJPBeVsy52CmktkgRRqG1Pr/I/c8UcMi3vSLS1Aph+vNIbRbt/ChA2 8XiHAZI6NLXqYg+6MXw== X-Proofpoint-ORIG-GUID: Ectjc7iSUIsME2C273BrH9x6ElSLsvgv X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab51294 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=oq02ZYoPfhOxzj0u8kcA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sm8750.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8750.c b/drivers/clk/qcom/dispcc-sm8= 750.c index 18e86b80e581..3205ce5c1ad9 100644 --- a/drivers/clk/qcom/dispcc-sm8750.c +++ b/drivers/clk/qcom/dispcc-sm8750.c @@ -1884,7 +1884,20 @@ static const struct regmap_config disp_cc_sm8750_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm8750_critical_cbcrs[] =3D { + 0xe07c, /* DISP_CC_SLEEP_CLK */ + 0xe05c, /* DISP_CC_XO_CLK */ + 0xc00c, /* DISP_CC_MDSS_RSCC_AHB_CLK */ + 0xc008, /* DISP_CC_MDSS_RSCC_VSYNC_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm8750_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm8750_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8750_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm8750_desc =3D { + .driver_data =3D &disp_cc_sm8750_driver_data, .config =3D &disp_cc_sm8750_regmap_config, .clks =3D disp_cc_sm8750_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm8750_clocks), @@ -1926,12 +1939,6 @@ static int disp_cc_sm8750_probe(struct platform_devi= ce *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe07c); /* DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xe05c); /* DISP_CC_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xc00c); /* DISP_CC_MDSS_RSCC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xc008); /* DISP_CC_MDSS_RSCC_VSYNC_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8750_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5205347F765 for ; Thu, 24 Sep 2026 12:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251676; cv=none; b=hfCJrmIsOQ+XUzb+dx35doyJTXPpCsHkXwHZU0Jsi+fXH0fm9twCtjBFu4z0ZyqTeZ/p8T5QxNuoAGEERhct3JABEtLb5UjhGBPlb7DfjAHNKQm3aiqHqloPwJyHoNJwNw4TZfU3m8uNyk8tZbSbgprVP7NY4zQ5SuptzjpTak8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251676; c=relaxed/simple; bh=Qf+X0ulDflaYn1MY7pLr2NZjomRPc7FLiNF33Tb10hE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DvOcISRigdRmtCzsEy1CgWjF5kQMqSoezHQEDHBX0Z5n34VFU2RhzcwDUkJ5fTpTw64skrmTVbllwut42FD3KYC5fET66kHtCRWn2L6dYJP0UjxgfPfOd6MIGr0t1eRbyTHa+n8suwSRgbX1KbwvddAtajta10WG5JpdcHf4rHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M+4ahiL4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ia7nNV7p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M+4ahiL4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ia7nNV7p" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4sft2594609 for ; Thu, 24 Sep 2026 12:07:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b9Ur8cPAkq7JD/mNYQr6XjaNZO0hdzmV1h202Uj54xM=; b=M+4ahiL4bStJyiqa QNBXRRYWYOPSta19Qxs3NUyDWIYhyDHW8FNdnO6wnRnjhBpkR7hFvCJpvXPw6nDk 90thwhRzX0GuV8LE39xK8oS2mGDNYShV9Qfa339N9yTS+pWUi/ZG0FX5bTzgyWSE Oyx9A429J2QR1KU7XjFc03xohbWzbIaY3qMsLAUdo5hX6kT5lMz3JTIq/d/O4PTU +xgdYHmzi9GL2+f1OhVdDXqWq6oFjlyclheXB8LvAGrNbVv+TDzw4RrHCKYpDSuT GjQ7z9Baf/rpbF8L0SqVBq5rRtFNcBzBMQfKTrM0LyRk7/dg4V4nyV2iRZGZx87h 9zf1Fw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1tjge87-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:52 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-78fb9f59781so1812077137.1 for ; Thu, 24 Sep 2026 05:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251671; x=1790856471; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=b9Ur8cPAkq7JD/mNYQr6XjaNZO0hdzmV1h202Uj54xM=; b=ia7nNV7p6lAma/9jtzTlRR2u2+TWROePJeE/TpuDH6LAr0+YCPiDKPWdD/BsqLU7gZ PZbLDRjIhJiLs5ulFdlYBozUonsQPSL7x7EOpIJrAgcHDKg0TySyyqYsfrAl8f7kLA3N lIq7PYNPaz5QvsItwrwMr9Opr2K95hHZxwQZU0dE828+1ieAchjJgAkOTHUSSEZM1gxp A5m3+rd6E7ErGtdKEsiCuCuONRPv5HvefvJ7s9aPGpxZBarb+6CExX/I65RETq9Tmhs+ 1ambjA0nj/AVnsXxyLviy205mjrM+I8xzFN6iiaCWE1GwOjd4qsL6Wiy27xNYAs1b2sI 0iOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251671; x=1790856471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b9Ur8cPAkq7JD/mNYQr6XjaNZO0hdzmV1h202Uj54xM=; b=QD0pN7YwWSbXMmwfBsj1Ho/NV+g68lynoxFqFUDf7N9Euujr6UTV1vrAWDmxrKNdli IAOl2tCf2ds62NSlspaAj/WzMWmNDQKV6BsRJ8aLSypb91Wgdm8usToz5G9pQhlNF0yE jdeRPhJJRsukoUWQVOJrqMwAhB2ThgG+qCpsu6kfXKv09r943Spjyh0LPku4P+5k8n3e u/GSddXbn7lq3g71Nw/ldmhBpG658GdhDm8H1SEhYm0/2v69wJ1JCUmQeUDGha9Y40Mx /xuOYLVGXcHnMfGRFKYrJiBpYGU7Wby2u+rWJjLtjZrFIRTYeW8E685vZsTWbPqpuFMD lwLQ== X-Forwarded-Encrypted: i=1; AKwUvBwfSevqPdJY3pyeEd0/uZ+y+Jt3zE0IZZi1LGR9zsKvjA9fp0c/klqeFIdZ5XE5u71g8pD2U2ssi6zd2TI=@vger.kernel.org X-Gm-Message-State: AFuF++lteKaPAbCruQZRsdneNVEOuHYK4d+9kUBeljqejJ9aqjL8UwiL zFS/nQZZHNeWQ/4C4LvJ1acY2zJoqdwnZ2Dy0pqZXC10VZUhZlLXzW9mxpcE2/yMlOvZcaAgMsj nJTTHihyshh/KZvk+gLWvtec9Aq9jGnTzbeT456R8FOwZWmw/4D9iUA3R18AWgHpUYgI= X-Gm-Gg: AYBFou3SU3Qc6M8G/oDEYduZBGS2JbYbu4/1uN2eBKi/zgfntEz3WL/D4i7gNeCLIpU wj+o1nulnCxSsmObBjwNu1I1j8N3+gVQmn9QRaDV2wuWK6bm8Wp6THSQr/mJtZLo8qj1m7GA/fl XVolPVMtnmfCZY1n4M11OO+w+uD4/55WDtwmUYXA1ekfjWdRihx2/HYnhn0Q99uvyTtxK7hqJPU 3qOxp4RQ6gfGWYg7oGwq8LgqYxhiIayheAgGrRjocAczVmOf4oTBPA0t0WkhAi35qzOIBowMk9f VNbocx0cRvRdnuK8LOqepGdB1WI/iSfge8fTfZB1c7iw3ob7lWALOqDxnpyRSp9LiypOeyIdRDt Pk1kIOy+k X-Received: by 2002:a05:6102:6883:b0:7a1:f7d2:e820 with SMTP id ada2fe7eead31-7af1ecf1913mr1074371137.25.1790251671357; Thu, 24 Sep 2026 05:07:51 -0700 (PDT) X-Received: by 2002:a05:6102:6883:b0:7a1:f7d2:e820 with SMTP id ada2fe7eead31-7af1ecf1913mr1074359137.25.1790251670852; Thu, 24 Sep 2026 05:07:50 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:47 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:25 +0300 Subject: [PATCH v2 13/48] clk: qcom: dispcc-x1e80100: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-13-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1863; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=Qf+X0ulDflaYn1MY7pLr2NZjomRPc7FLiNF33Tb10hE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJO80Uxr2mGMK+LCHJj0UMjL19jse/NPJomH SfUL9lkfuCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSTgAKCRAbX0TJAJUV VrwXD/9GskLbx95X5a+GvjC/GkUffxCSh5p5Do8XtLPhfkWMkBEdZEeGK0H83OaQtsMEJKSlsGA ePiIxkAEScsot0ZCvWjpH0qg0FfGclYbs1iUBGWKc68vKK0jNmLrW3/Y5lX5bynn9TKJYVrwrvp I4DSXY6XKhOb0XX2AeYaNWPPZcmdZudmk76EujUfQ1fgsr2UtvBw5DHH8D/U6A8AWJVuy922v5l 2aF4uHFELDvrBfvRaRJihr6Rwlq1aMtE44eAST/okYAhUbaqRcOlFJb4GBwxCqURYtt17NYjP8p +haj3FkGHbZ8lBvw0E00Km9H01WTJnjwQcksCg8yrAUfUoDX3sjUlAReH03jovT2DTib4Cak6Th PEk/nD3/RN/JcecnXgSqLuZi/X3PhWLEcNyIDc9Q8AIz7VNNta9ZT6S7WKYwZLsFRh+bxYWrKdM frOgYnl7vKFsi7pizGfMprt//YFh8VWnvty1ywc5NKpUkZ7JdUvAw+za56gaVeRdQz8txTpoq/N 9v43LHbxa9McQOQ9kLzi6xznqw5whZaLlPCYuam//REE2AaSx7Z1l4JaH9Yi+6wjAiLoVikJa6A pOCVvtnpbOphX8MVnfE6JF3pNQ3TdcUNqlM33Q8liy/ATZ9IccHXVCVfMbDnip6l+bD32R9QPod ywykz7ph5Oopo6g== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: T_i_NS2IJCbbnsQw7uGtYndBoyyhpYYY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXxX4FOB2xkBbL HjRPrQr+5DTpwDWV5c+0mewM9aa9ujKNiNG8ZNAJY4DSl8rRsCDA4bPKNEYgAUeHyHpQJ3xCjv5 7GQ/7Z6gSJOdu5FvxdMe2RugjGQDHzIrLqjWDO1I7NYnyPQvQhUZTDSb0UfjdJTp2+bn1VPQnuR n2+fzT15r34cCT5Swoo6oG2bpJB1JF7Gw1chGoTy2uSvfPqpy8bLnzea6jkevA32Hz2Kz9CeXbM J985rdngb2xsMlWM14RvrVRXEBjtON3HpZ1EHbKfj6gXVvOsF+HWngkUoMfrSS+PmddmZbG6NWZ /100lYkGWNp6TRGVKuqFSHLahDtecbiozWVO41X89QfyVbAui/TP4h6MstbV8CqwQHpJjWJX7Ow wOCAZOqrlRC/G5i9BTmNhk5B1yQ41GxUktpWlwp15jqfLSNs9zww+ZpLIfqYF/tHMuN7XUaT/TS nkR92VxTh8xCHkoK63A== X-Authority-Analysis: v=2.4 cv=cK11IVeN c=1 sm=1 tr=0 ts=6ab51298 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=55LTGlQWyvwDnq5kMygA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: T_i_NS2IJCbbnsQw7uGtYndBoyyhpYYY X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX84zZoxYiUH6t 6ASqYCog2rH+3VML7ZlCBPID440yhuJH1Ka809aTDQxhr64osNbzoZWgveBOp+hbvYki7QRRJ7B fyrxyaUHfuQTk26FAxzyS72jhWQU7jI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-x1e80100.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc-x1e80100.c b/drivers/clk/qcom/dispcc-x= 1e80100.c index d3dc678a298d..aed06203a886 100644 --- a/drivers/clk/qcom/dispcc-x1e80100.c +++ b/drivers/clk/qcom/dispcc-x1e80100.c @@ -1637,7 +1637,18 @@ static const struct regmap_config disp_cc_x1e80100_r= egmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_x1e80100_critical_cbcrs[] =3D { + 0xe074, /* DISP_CC_SLEEP_CLK */ + 0xe054, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_x1e80100_driver_data =3D { + .clk_cbcrs =3D disp_cc_x1e80100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_x1e80100_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_x1e80100_desc =3D { + .driver_data =3D &disp_cc_x1e80100_driver_data, .config =3D &disp_cc_x1e80100_regmap_config, .clks =3D disp_cc_x1e80100_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_x1e80100_clocks), @@ -1678,10 +1689,6 @@ static int disp_cc_x1e80100_probe(struct platform_de= vice *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); =20 - /* Keep clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xe074); /* DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_x1e80100_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3144E47F791 for ; Thu, 24 Sep 2026 12:07:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251683; cv=none; b=qLwGn3OajTEMu0r6sxUO0h0pvmip/WGTbw4RLg3O6jg3uXR1zMOdoKFJ8LR0sItwxb1UUZMFuHG6F+PpOGPb++ijK+dMZqAvq+0CAaoJiHND75zpyS/RllFbXVDcF4Sbtz8Siq/FeaLreRB0uXj/8ztXsXUFu512yJDW1zEm7wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251683; c=relaxed/simple; bh=sYgFXxszLBRbKlfiFi/HT1HPgfh2QMci3itJ4u3zWFU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UX65tveeoGDI6pKcssruEKg2M9NZJK1UKQwFltLtgckzZyoVbABOKZQXpMwAcnXz9GsXCZyyT3pWR2YOaEmZ5By/ncZEHNemHtuW8kOArJxFLJXaUpB1bqpzdkpXSG4x6erdFPxdDKJfoDjhLC2nv0yDLoYHqYGIK8N3yIAgAGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PQVkZpFW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TQPA8/94; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PQVkZpFW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TQPA8/94" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4fG41437111 for ; Thu, 24 Sep 2026 12:07:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kPvqUT++vhjHwdSn9HIEn4vwQRXJH23+AllpPzU28k0=; b=PQVkZpFWyykFop1o 7aAI+wA3MiNHhHeyoTZRRcA02qagf8LhKu9Rt54+ru4TC7fKBUaZrSa/6IUvyXGO l2zD8sm2wWNzLhRb8dANKwvQzgaVH1vWbNVxQBkdTDy5Zsw7M9EIp/kvWAOMgIWw cC82uQyQnfv2LZzX/jzqc0u4CL4anA7V2wjVflR+cspqR5lf86DeKO/FzXFj68rK C5/mKa/4np824g+GYY62uj7w7S9gaHNThZOP4me8iOVG8msyl7TQZv1hvP/Bz0j8 Os6UKs6coORbbDr78iIxEgD426YrSMtdTSD++CpnNpcKWVpJwOW2IVDMC22Ah+TN ul0xig== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1t7renx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:56 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7915a83539fso1832643137.1 for ; Thu, 24 Sep 2026 05:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251676; x=1790856476; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kPvqUT++vhjHwdSn9HIEn4vwQRXJH23+AllpPzU28k0=; b=TQPA8/94258mqF8PJzwhPTVqFWi4bUl6ploFxfJoNx97yt5R5rR1rhuyCYQ0tuecEC qnkzlprxHELo4RcJPYEho8yLVfkOTLdO6XKz11fCtVntOOb+IVCe326pVY5k45dRyCra TqPAXDSYijH/i8kuH7P+9KtoEUtIXIjz5vxeuC0bMBN4npVOh5mieBgNbVtmwzogC1Ah v+U2bw+emfl91izVL8nEuyik9udfmoyysOjuX7960oRFtv5WAWxOXZ1dLaQUJ5Ki/abN k1q4SAbOsvot1iRz52ku5v1SHhFBsMMYOOo13Sl+T7X4LBHtnYkK3b0uoUjrQ3ctWfnM qBHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251676; x=1790856476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kPvqUT++vhjHwdSn9HIEn4vwQRXJH23+AllpPzU28k0=; b=0z5ipfssyNvBwMe1SeOdWn32aQp0/ioLIS7xmZMern/kb30hExvOmnL3NIyQwzmLP3 YDn4GgFA/9TmmfxTcjcSRbvbKzlHo3WqWAQelHT0ylIBYu9SokfrI6JALRrIhGWXcBJd mCIP0r7rl0MjKoe05E8TBpZutz533fFCWhCHoZYG5DmY5oPtC03gGE33JXieQbu3vN0O vMltY8mXsA4C8F4wY1VqpuasTr0bFcN92U4/sZqvmORgBGMnurDZXWjZM1/3Ec9eCEs8 1FKDrkpEHeny0mDPLaGu8uOf4O2tQsku+t+un17eHjWM/aXvGsmUCSrq9AOBFpW8j/dx HYpQ== X-Forwarded-Encrypted: i=1; AKwUvByRUuWuD5YeAjvl/T//kxTI/ANqHlhX7C5SDgi+5puQt/n/0Tm7Pyfrj07MpLd6ONDo0gzGMUroAZ9z4EE=@vger.kernel.org X-Gm-Message-State: AFuF++mcU9xXY8ZZLxqtFJlN8zERWD67yyYZALDieoHvfV+MXgt1WrSX +8AftmZploNTOgWgfHw5Nl4Zne2wHIz3KgS7IHj4FYN77H1NLM/Ew954PLzTwxTkN+SxYeuHqOR 07ryUFKe3NHkDQ437pm46/BSAIbfQ3OO98p6rkrUbzj36upMbawqNzzmMXHXrms2pXks= X-Gm-Gg: AYBFou09SXNdMtM8xQKoY6gWn8EWOEMOSHuvqWYCE8bfocu6cICuKF0zXW+nBtEfZeh pGtD+C9IuBPv3ZD1yrNg/B49FzwmqK/ugzpvk88YTqwByCSQtD7t9Tg411xbLJyx4CvBuVEgusE gsOBGMQ5fiJsWyw4YTpuz1vAVgcBNb9lXNbeV0kJcqIl5VsY5/pBFL3BE/4BA+32Z3a1XJeAHRR W5oPgOVzfKuA+blN4ohwa5X3uwWgahi+HMi3RxcvBZDqkepuXjbQYKh9VlSM209jI4tcpVLyDlJ 8siQnjvgKl5fQD/UPFha3zorAnQgPH9PcstMlX9xoFhjLtaxqRZ5+neqdmMrOFz2oRYA5owUNO3 9mMNzYH9G X-Received: by 2002:a67:e703:0:b0:7a7:36ac:b17a with SMTP id ada2fe7eead31-7af1e4f6353mr974825137.20.1790251676037; Thu, 24 Sep 2026 05:07:56 -0700 (PDT) X-Received: by 2002:a67:e703:0:b0:7a7:36ac:b17a with SMTP id ada2fe7eead31-7af1e4f6353mr974806137.20.1790251675447; Thu, 24 Sep 2026 05:07:55 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:52 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:26 +0300 Subject: [PATCH v2 14/48] clk: qcom: dispcc0-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-14-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1985; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=sYgFXxszLBRbKlfiFi/HT1HPgfh2QMci3itJ4u3zWFU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJPkj25FwpqZbnNY6hSj8Xv1cH9Q0zPmh57V gwj++laVg+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSTwAKCRAbX0TJAJUV VnOSEACGlQTJUmKe4tZ3zKmQMUWT0kaw/u2sfoWHSccBovhTjD+syzJ4oknF+j1Y9OhRrLvMQ0h b67DgAAN6FmcCUUt5V8S5Hjaf4IMrOsi074IxQ4KMldtqqjy5PgFffngAsQ4WSVEU0YwsHLRG6F zc5skSnIgkzftRhBIVaAjc2R6YuhZHTd/UlIO4JWqgEUUV0AldFK1P2VgPMm8VHXnDQuTWXdg4d wc0Ef/Q1Gp9xcFjPaDKWU9KB0el17GaHJgadEE4bBIe6QJvHzLkXI2AN5nG3i3Wg5BbeWnhsrD4 Gnx6zACwU+XF+/cRJZDJ7Lur0T+CiOfzu8ODzBhnXHCVOvB+OAFnfE//WD5SUuWxPRZ9n8BolO6 wDguNPCr5NWzNbelMYN1BurbY+Yb6UsWs9WRkb99DqtS3rOc3LbdhjfTnLCqVw4CqWyXciRXssR 42Qhh/jtX/wSjZRFKBcc3V7WewYm71kxSri57/Atsm8SslnFvWWqSPPHDBqAiQY0f4CsPJCNShd qCJ8jLxMIrmiNiAX0H4S1ktF0ZUV94zp+5GmKckbxlnp6RLcUDgC8GZpG/FAeLH4ZdW/hl6Ljub txohIiqFMSJnmcRDy6IECo0Cr5a6qha7869gmQXAC2GNYwsBj1c2M8n1VauyCiV56ggFWtDEufh anGzNVxncQmIU1w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: 9xc8-NgwYBYRA1484G3-C20MHR0IGohs X-Authority-Analysis: v=2.4 cv=U/MHnuru c=1 sm=1 tr=0 ts=6ab5129c cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=15gMRk_Tn8l8Lfg2mfgA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX9n0QxDaG0OHd LCt33uFld+lD6gFnuQXHUmOgzvbraddvxfwTdgFvmdSpfgzCcKv7W5NiSc7PvzxcPSR891ART+/ zYf8dd8Gwaa4+FmS+ZhgqusLO7jvs5imO01Ef6SvCju3gdveyURxJQvW5QEWB1hVQsk0YN9ybJR g/If8+rvjb51njXeH8EGIMVCXgFwzG+AeTRzD1d5r0UnYw1bRT4sIrE3LN9AZfD143Izpvde3+t aaxnHB7sTIY/Lpccwuk+Wy57+w2Gg4wt6AF0FVKzkXGiX6RFdTHM2LXSYxFB3GHD7M5sekj7jZN jDDRud9Q/NFj7CnsLXznVPRogkahrgW2AaObXPiYJusK5nlYMLq67kaLL1R72rwW39QxRrf8iyu trNd7fzQooMhKsXO63evV2QLlyhy3giy2qLgvYFHZS+rIyuPJJclmdn6BdjMlCjEl8lJZ2zLNiw qdK2a8Zkcjt0IlE9o8A== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX3tgdayEA3Ze0 MZT6MQ0iTsKQFoGjNxQljiadPO245WIBUEmkuogStXl/d/1dZdBO7XV4/fiStvs2zRmglXWgub6 ncAJLikDS2RXmQ2EI403sn8e1vDhfsg= X-Proofpoint-ORIG-GUID: 9xc8-NgwYBYRA1484G3-C20MHR0IGohs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc0-sa8775p.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc0-sa8775p.c b/drivers/clk/qcom/dispcc0-= sa8775p.c index 0e976442834a..a1861cc8343e 100644 --- a/drivers/clk/qcom/dispcc0-sa8775p.c +++ b/drivers/clk/qcom/dispcc0-sa8775p.c @@ -1414,7 +1414,18 @@ static const struct regmap_config disp_cc_0_sa8775p_= regmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_0_sa8775p_critical_cbcrs[] =3D { + 0xc070, /* MDSS_0_DISP_CC_SLEEP_CLK */ + 0xc054, /* MDSS_0_DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_0_sa8775p_driver_data =3D { + .clk_cbcrs =3D disp_cc_0_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_0_sa8775p_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_0_sa8775p_desc =3D { + .driver_data =3D &disp_cc_0_sa8775p_driver_data, .config =3D &disp_cc_0_sa8775p_regmap_config, .clks =3D disp_cc_0_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_0_sa8775p_clocks), @@ -1452,10 +1463,6 @@ static int disp_cc_0_sa8775p_probe(struct platform_d= evice *pdev) clk_lucid_evo_pll_configure(&mdss_0_disp_cc_pll0, regmap, &mdss_0_disp_cc= _pll0_config); clk_lucid_evo_pll_configure(&mdss_0_disp_cc_pll1, regmap, &mdss_0_disp_cc= _pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xc070); /* MDSS_0_DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xc054); /* MDSS_0_DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_0_sa8775p_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A04F148662E for ; Thu, 24 Sep 2026 12:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251687; cv=none; b=CFUODfLg7mn55qPS1kBZtH+Y8qQaTyGKbNx6V8FHE3OqXymDppfjtChqSZ1KyBVnJLvoCUsDthO5jKjDTgiFxFyWEnQ/5ws3TSw/8KHns+p2J7vkwLjff7ImE2Vl5EFZAaGnZxtv8jd1RrYgAj9FYW3gIJhFGkTJ60hx7CT4saA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251687; c=relaxed/simple; bh=CQXJofXOmMw3cH+dS3fdFOgmgQjockpxZA9akNR6TvM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cmWHAGIfVlvPQThwmaOdlcXq+gtouKcdKJid5SjgB1/hRixzUCTvuCBCPqhSVA7bZGmzrgABmePbLcXLlwm1CPiramaBhbdpSB5oLiVEK/eRp7PiTmJIqW9b7vQFUmyV/mdBPqmDGsDrV68upW2VxMjcNhbGIA4fzKwRhTIb1wo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bCJZGym9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hp9JcKti; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bCJZGym9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hp9JcKti" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4gi91437135 for ; Thu, 24 Sep 2026 12:07:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ID/czw8MMUTt+UZF4aIlgMGUS18e0Go/4J1TeukaYX8=; b=bCJZGym9ZJXX8NO0 9JoZJHuapsmSf0516wZ+cQSu1ltEH4yVVTEpzfCYAKhrpXMv7e6IxgsmsDFRO5Ya z0MgOG3TbmmOnCs31sowgwP2QVQM5R0wUyHc+QJfz0LfEaObcE9bIm/hEqR0lswE r6RXKBQJE2w09JcP4ROezVELTYbEjOBwvAxZitBkndMUsgr5xkiXRmrhy7Iyr/6W dN1YeyjMHY3tE2ErtrYQzTVwFtVkhNQB+8drZW4jI4sMgxdXAycBK/xJO8BMU+Pt R2bVCwB0W6rYMrnGAPGA78DHYSsRs84chYiL5cRsMZ5JKcP6iU/T9ksypB5GIxA8 LLmGBw== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1t7rep0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:07:58 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-790de8f0cecso559484137.2 for ; Thu, 24 Sep 2026 05:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251678; x=1790856478; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ID/czw8MMUTt+UZF4aIlgMGUS18e0Go/4J1TeukaYX8=; b=hp9JcKtiQuclGs+oeGhubfjJptWNVY5XPFqVAAC1qdFr8Dr2YAKaM+cpL13DUuuJX0 wDQwYeOA3FhZPaeYBu/UkGGsfwXAQLTKE43xnP/LT5dQkzYMEvKZNsrBEjLEmhEvSqvW 17AMo3S6swejmuNmWQbu6dpCCUVkn25i5cti9W1bZukSc0sPqnc6soWFFfwC9761FChq NawsNqu5uRkBpTQQNYP2xXJgXrUrSCsXkq+qcQVm1UTg8flH19HSLIl/194o5Nas+QwT y361ZkdBBqlRj6mPn19EnwO1V0WsA2kANUriWwYLMgHJLfMMwj2slkuShCvIpblxmO6O EJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251678; x=1790856478; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ID/czw8MMUTt+UZF4aIlgMGUS18e0Go/4J1TeukaYX8=; b=gLxR/CibKtSd0Y2i8IqhiDw5Lx1d4uBR9U5RQi+SalljG7LPzYDlhXjsweoKFufatU xQFeHfJoECdgroSDsntzT6hdWqzWltJZkjxxxeJQPv4xzPGXZx03Ajw8ncj64ebfO2wQ Z2yD61NLXBWl1vVuPf4noIJB3E+ux7PcZZJUCNFlg+bkgCFF2M7m5bbRCFrRkU4Jlv7i nFhiY8SPgS1SVg4tIZzh5EOT8ftbp3pZBSf3U7p7SlmrI3gu4+iiQUM2aVxvGNVdtiUz ncZ2y23HweRNtKuRDK8Z4pLTbfn4zQ0Gjd4FDYdtgQnNcrh9G679MWEi4KcVqarGAj4n tIZg== X-Forwarded-Encrypted: i=1; AKwUvBzPdqvOkcaigd8MzS93ynjThDeZUN4Q6zTDAjUxu6Zdq2skCBNYekd32Royp7HT9dzeVhJq1eVjhRq5qJc=@vger.kernel.org X-Gm-Message-State: AFuF++lXQnlkmsOvgZ9RATzSJAeIC7sGHTPPeKs7CwZE7EzdfrcFBSZv 6FI7myMJCq9fKS/LDqrWf5pESGEIXPR06e2ckLh9iG+Ism6sjBryHy0OaytkVqBitwOEwqwzu0e feEd9N77MGLp4u9B+8ZkVYgje2Lemg1viLPK6UZqEyYLeFd5/53jcF73oe8wx71EsPjA= X-Gm-Gg: AYBFou0QpndtMa9x0YCStMmWHxz36e8Zv5O6MYSSHjF1RQ6xOUUnYYIbCWpBReXidRW +P0O8tAnTIWSmp1FcqsN3KI9M+QlXNL+jZK9bwyf+O4rX5YU4VjKB8pMaAPvb8wSdThi2Gp4XQu G8yY+oMTpEl+pHqnS7MrG6RggavZOmipN+wNlrIBslqHmglOcPtD4Sis7VPhMGvKJHyBLfsHAOS zAwvK94lqRtG5i5UM/0/HFz+KjoAJRHvcvWufYENoxaufNj0DoLWOJ+1asCCaP1RDwWuBqN3wGt y4mWoWkBIzhTe+spuz04hynLAyi85hn/isBxwSY1vnCpikYKPrXiQtnhotagt6TYpT2W3HaqbTo xbfBFRZt7 X-Received: by 2002:a05:6102:3ed1:b0:7a7:79c5:d465 with SMTP id ada2fe7eead31-7af1973816amr1126118137.0.1790251678151; Thu, 24 Sep 2026 05:07:58 -0700 (PDT) X-Received: by 2002:a05:6102:3ed1:b0:7a7:79c5:d465 with SMTP id ada2fe7eead31-7af1973816amr1126101137.0.1790251677583; Thu, 24 Sep 2026 05:07:57 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:56 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:27 +0300 Subject: [PATCH v2 15/48] clk: qcom: dispcc1-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-15-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1985; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=CQXJofXOmMw3cH+dS3fdFOgmgQjockpxZA9akNR6TvM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJQy5ONo70EP64WXP3iFcC24rUeNgy+70UOL qaUpPGrSEGJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSUAAKCRAbX0TJAJUV Vjy5EACb6acFzFedBqO2kT8nPcKyzUgODZu38TyD0NDJevhgdbIuqkwqWTsRBpSJbbKbmF2jkGA cZVK/EPsR4QaA/CivWCyeCPCyFIpvmQH4itELw/QqI+6eA55K3wVmo192gp7VYw3f7nsKT3M8qI 0SBVBAddI5ZQg5mV1b5hUd+vDlcqh6hRUfju43B3i6FGmLWbyTMCOtArvQvtMa5FGpvXNxpuJhJ HwcmHxkrwtY6zBTwPtToI5U6TRYP+Ipan91+mSbXLvdL6+z/Pa1Qti2rYc7nxfc+y1yGvGZtKYj rzDOCwWKb1Yy0veR1UO3h9yVCiCS/Dn4byJwPkyZoNlY0tAPKvR6ap17yHDh0IPo3UdGm78NB6E J+k5FTV25IFViabvnjyPgxUw2z7Ppm3TsTLkQkIbsAUl+9GaGGDQzHs8o9YknscNRbjm5Y4fOiN wZFi/YE82KOHb1xriI/wMYoR+GKp+fgbd334SKfLbP+1NWhN6ATjYETQpfSFf7SZ6tNyWb5ye8A jVH47IxCGLD37G/NQi8IhZ+2uY3+0IgEFehas9iR5STdqWx6tyLfJ1WT8KLAbq9MLTVlxTptKNF Tm4bwM/+puWBTVM50wZKJQQJLmFkLvzbAq5wU7wUbN9HH9HHHuSkG6DMidBNLHOJlHN/8KV4+tz HMHXJxj6IKo9kvQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: IveicaauT9ST3cQAMJF85q13gbW56zg1 X-Authority-Analysis: v=2.4 cv=U/MHnuru c=1 sm=1 tr=0 ts=6ab5129e cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=xG6gKK67fXx6DpdPwiUA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0SXlGg6W3bK9 duAZNbW+m9aQ+onuDh/ygz2AVfN3VxS65fx7saDKX6hnTeyW7BUWH8onLW0UQUeKinvr7JmtiwF iYdJx5+Rvc4rECb8kYlqHvaq81sEB2n7U9fQooZpqb/SAV8I/b6sCZg7ZKF/C956jxuVa7wSYcz zt2qgpbFIKE+4N5pBqtOF842Dkb1EMoz3fqswlQbObDAUHNrLNOcTrT/eXBlaO97usWq7qyT9Ur CkW+3QcF0cZqx7HgyctTjumGb1OUhM138qqaXFB8fd/gzOGfRBtcQKGcJ3nQdmORVQ9heyBu6lA 2KBr+F5pbmzB2mltzQTVt1AZBoyMHcgs+qeEI0Fvh0QbJqzbbgUVDTW4/JWK+w3G+/thHn39sxT 3Rl9SvpH975Uh22CRXHipQylKfv5ZZj9mSAJ9AXVkXqtvJ5KSgVXxHvst1uNiwwFeqtqt1+SJ1K 8tD9OirzoV0I5ROPFLA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX1JGbtVcuie1I 5M+vfhyHQ4lYiMLLI1QrnGiUTtS+z6Jh2NJgz1dUjyIyWOcy2LI2wT9PD7kQBNdzPnmlW6gMKTS WIP1z7X0AfNdKLfCGJUOH+WBJ+IAPto= X-Proofpoint-ORIG-GUID: IveicaauT9ST3cQAMJF85q13gbW56zg1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc1-sa8775p.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc1-sa8775p.c b/drivers/clk/qcom/dispcc1-= sa8775p.c index 58008c1afc76..330d953b5e9e 100644 --- a/drivers/clk/qcom/dispcc1-sa8775p.c +++ b/drivers/clk/qcom/dispcc1-sa8775p.c @@ -1414,7 +1414,18 @@ static const struct regmap_config disp_cc_1_sa8775p_= regmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_1_sa8775p_critical_cbcrs[] =3D { + 0xc070, /* MDSS_1_DISP_CC_SLEEP_CLK */ + 0xc054, /* MDSS_1_DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_1_sa8775p_driver_data =3D { + .clk_cbcrs =3D disp_cc_1_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_1_sa8775p_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_1_sa8775p_desc =3D { + .driver_data =3D &disp_cc_1_sa8775p_driver_data, .config =3D &disp_cc_1_sa8775p_regmap_config, .clks =3D disp_cc_1_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_1_sa8775p_clocks), @@ -1452,10 +1463,6 @@ static int disp_cc_1_sa8775p_probe(struct platform_d= evice *pdev) clk_lucid_evo_pll_configure(&mdss_1_disp_cc_pll0, regmap, &mdss_1_disp_cc= _pll0_config); clk_lucid_evo_pll_configure(&mdss_1_disp_cc_pll1, regmap, &mdss_1_disp_cc= _pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xc070); /* MDSS_1_DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xc054); /* MDSS_1_DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_1_sa8775p_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C5E47DFA8 for ; Thu, 24 Sep 2026 12:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251689; cv=none; b=bFQTu5FA4iGgNbdvV/R4uRz8RAFasaS6ByLjErGGY93cp9pz+AgmFGzA7aaK41UofuWCX74OThvZayxWJWVuNs62QRqNuqolvr3sGk8iYSj8ckQsG3YRFfSlRfKVUbFGsuAZlc8WwUBBgRmKuMho2utI8a2vPMS5Mx3Fb8Mo0NM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251689; c=relaxed/simple; bh=2vywdcT8KOy7PEWrQfNdsIA4czQkQ1OxXcYuKXe3UwA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pUrk3V6O+tdyvqGFNCUIO/Hxa0+Od9qdpdtDYrhUOcjG7XAkYnOMtYnUVbBCwAZNHj9sNnNWljDgZzBikahSBZuu242xytDI7Yywt+V5h0YEt765ImgUv0xdsHphIE+fP+Vjx+OToNeFWXn/VSgLE0cCWSsCSxByseAEMZ+LMGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oOuIQsU/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dBOxV0Um; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oOuIQsU/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dBOxV0Um" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4Y8l2285544 for ; Thu, 24 Sep 2026 12:08:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5pDk/RHiyQFi83pfCI/NTaT5GCCo9P8LK834R+NcSvM=; b=oOuIQsU/gceEW8pk 30+hLQi/KC381B3Nq8SCDIVLmQEujZEr+ApHttzH+9MfAObII7m6zCET8Mos6n7T JKxib1wd1V5J3C7GJVXyj6la0GDSHg0daDQGhJD0FzyWqNCJs/WwsloqNd/bFulD V7AM81GFmlUeu64MjRfjnZdR/Ukb98UKabzFQ68CaRGLbX1vAreBXF4SG4Z1wfWD lAkwV8ZIxUFrHa3jDH0INvTLKbms6vjfnYkbsUzKvB8FZ8GdDABGqu6SsxWpNJSN pAe7fuWw8G/E3KbVjSE5G0QKPKFmJ4nhbPzo+c7I9eogVYGbM2oeXnrCjtjPD7NX 2Fg/EQ== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvx8ahgnv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:01 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7930cb5cd3aso1646166137.3 for ; Thu, 24 Sep 2026 05:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251680; x=1790856480; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5pDk/RHiyQFi83pfCI/NTaT5GCCo9P8LK834R+NcSvM=; b=dBOxV0Um0LaH2mirtTb+91mv+Go5xjS/zsJUU3POIepD9OfnhUGO4DpIoEe9Y4onck NaAndlNQ6BK8vyExgtdgavyLayVATIRO3gVxUQN869lq/elmkXLTXW8I34nSpFU1uxmm KW31Cu0WVFpbVHOBIoKyqwiC2Zg83MxudQv4st6vdedsz+gQjmIYePnuRPJzPuqPZxB/ zKgN5xwtbHQIR9gtwPoqk+03JMsdTB2ESdA8WCHkwlh3P7xa/ZElGQH0lF0OpxmKaDcD t7uyfvt4W1QlEtQ//tOb0tnyeQKNRGZLknznITnbaK+RWcOSn+E66RyXkQzx6anhtYSM YCjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251680; x=1790856480; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5pDk/RHiyQFi83pfCI/NTaT5GCCo9P8LK834R+NcSvM=; b=NFF69bSuylVIz6sUSJX7UafAgCb4ekgxAIQDrVHLN57TQVEnAPznts7Um8vzRAqoNA malwpWtxTjJO0+slCS+tCC2DLUjB6jP/xI4aoqe05HbNrx+KkclVVwuZcSkmz9QGWX/0 mr/zKUStVjYUzHR69xY0n792SXo4zHqhma5WrazxxhroJIzeGlurU850n2Fey3NNCsSF aBlavnRM8LYwTfW7WOo7w39bPKfQArHZ111YifT+7Qqypwkrw6MtzdxLGPywVaIyxgNd mPVMMMwJ0SQiEGIeKD+xPpPsI4nen8/JvmyL9nNRQMU2Jvb6HXS/w/2Fa6PBsXBMz8KI U2bA== X-Forwarded-Encrypted: i=1; AKwUvByZPv9WpH2PzvXy/3vhWP7SuTWkC2UAdGzTsReMRkkE6P6mDuSxCmhrE/ZFutE7dWnkdTRzxCaY4WRADh4=@vger.kernel.org X-Gm-Message-State: AFuF++kj9vAhtEAiZ5KwYH0/6ew4ym89wR6lOiIzGjMB9i5TG8TZT5pI vh5VDrWnqZvIPeloMUQlJM0bqwbPk4U1aiUYtc23nmz1vaFhsOsDhkIhuNjjDoKSur2t8GWuCRQ bdiBRQ2smw4Rg9ubfI0aWKTT7dStJq1q0TyY0NdR+lYZ5Td+F6SVTEV71w5QzUMuAh20= X-Gm-Gg: AYBFou3pdSTGaW7xRTz+P+QC5QiKFC1la77jo35HAehMfJEIXVR3Wg+hOySVhUvN5lU c5PdPzVWNMR1bYp0uaEZLOOs/rFK6f/ZkLSm5EliEUIkSbnGXfa3CgsuZfzzs5tmz+Fsg7mB7on 3rMCP6+r5gUQ7JQtmkMXG2SuHqr+wMg19NEaNdfZgFUT+KIPSgY5sy5P7kHCxvtkAyQLGaoEbxR zAzT/x2PHICk81rg/w0nn1j1TJB/zjzXtgw9W3PvakPbcv/1hSaXzCePyZT2h+Y0QErm3EY9O/R KXEUzgv9mU8XlSVzi0sG3X2rdyC44xH5b2mtEYqnbeMoJFZYiuUL/KQoASjHcQ9Q+T7aAkZkjQ7 hxRnNthrX X-Received: by 2002:a05:6102:358d:b0:79e:2b00:b4da with SMTP id ada2fe7eead31-7af1c692c06mr1291252137.6.1790251680312; Thu, 24 Sep 2026 05:08:00 -0700 (PDT) X-Received: by 2002:a05:6102:358d:b0:79e:2b00:b4da with SMTP id ada2fe7eead31-7af1c692c06mr1291234137.6.1790251679790; Thu, 24 Sep 2026 05:07:59 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:07:58 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:28 +0300 Subject: [PATCH v2 16/48] clk: qcom: gcc-qcs615: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-16-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3441; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=2vywdcT8KOy7PEWrQfNdsIA4czQkQ1OxXcYuKXe3UwA=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJRSIDl1aGyH8eABWLYWX0VRM+gAa/KIQpW3 Ac17iZ1+w2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSUQAKCRAbX0TJAJUV VmKmEACrmJ2afaOR7a73HwrO8Y28H/FuChEyE7W4byCXCv+Yae77dw8oCNs1GFybzfUhZC7ryJi kGgIlTo3YrosPBju/pCwqq+hncVMvS7eVhtzsAlK231cOCdEE3c1Z3esRzRmNu1Vogt3jezaW7X arUN9U9wcBc1WCwceyOROvwSVxvY7eqqMVvW1oMsRJMokti27mJH9KMRQvbhRxsKpoOlgWQamr0 7qki9jLDcPvijYzs1uT6LuGqclf0kAj4gj7jKHjAfsaRhbHqVkZD/mKmUA11vTJeH9myto8Ig10 7CjKgz1nWu6wzsEvBfZ2v7O4+ULr3emh1mAcge58M0ht34dN33k3JMjTjJik4c7ucpYrdH2gaQ1 9k6tsdlCG4MClU++2Hk8PQmaKsRxbKoX51wMan0rVEWkcvXcy22I2OJgYQdsp1u6pS7CoCisGxY GRbIYl1l0ycfcJSWfgO+ynq22LEci8EhPbGPZjrl7KCT4pdteOQZfOrVCNRCsab4t1dslGNmjKB L5wPONay3IyRGCvXtqLjyqTiqUjmM2nK+FB4Ip80qEqJnYCVzH5GvDQksUaf+aoTLAVBZu8U29i 2o7juy4/Mmy9RwAx+qISws74mL4Hw7Nv6QEr1umpva+PH22ag/urAi7Ghu+pGPTHTjamMQQIWP3 7O9jQ6IPGoeIhoQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX2Jid+nGrfwrN pLw56SzggT3Kf9GafnxOf/qv4eh7PByxdoBLzoHbV78Rxh4PitqxZdQh8dvn0o/iKwHmJbWTPaH ChE4/4P0zCkPH9iSjv4hg1Tkwj2f5jU= X-Proofpoint-ORIG-GUID: _jvHQloTdzMo3vT1m6NfOFFvNAMMQLD- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX5ROxbJAadtU1 LR1ZBA8KgYjb4UG4/zYKj1cjT9e5JecjxzR1XRSBrfyaLVU29IovfeNf4UpcUnR9UkyOfezzMvN e1trdsYvN0bL0Fr5a3QFRim+pmmPDpBYTW3K9EKH0Djnb0ER5tNb64U7g6fwXFTx38y/8j8eCGj kDuUfsoB8TCNIdCK8JtsLrKFJ3jwFqfgl0jzHFmLi2Tba1/4zy0UUGh1Q/o7PX9reIt87+8S+Cu YCxF9OrcaJ3RRn5GgrXNPenjuFp2bHXLFySNNMwr77FmQq0y/9e5z21JwLOK+fK2pxprTMmnOxX U7G279RkR8JWy8y8u00yOOoUxllQUOxypYnmAanPUmEqbYQAgbfQ+Q1A4XUt6Qv/wn6Ag/q19l7 9OJ6N4Y/ArxyIfvnCk8gl3fgLnf3QnTIoolxeGx2ugG4h0TZwO8wBxTFFQyZkT2U9MrxcNk0J58 PJisp8yXNgLvo+XUzvQ== X-Authority-Analysis: v=2.4 cv=a6SlZkSF c=1 sm=1 tr=0 ts=6ab512a1 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: _jvHQloTdzMo3vT1m6NfOFFvNAMMQLD- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-qcs615.c | 57 +++++++++++++++++++++------------------= ---- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/drivers/clk/qcom/gcc-qcs615.c b/drivers/clk/qcom/gcc-qcs615.c index 8910a8badc27..e096af7d82bf 100644 --- a/drivers/clk/qcom/gcc-qcs615.c +++ b/drivers/clk/qcom/gcc-qcs615.c @@ -2958,7 +2958,34 @@ static const struct regmap_config gcc_qcs615_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_qcs615_critical_cbcrs[] =3D { + 0xb008, /* GCC_CAMERA_AHB_CLK */ + 0xb044, /* GCC_CAMERA_XO_CLK */ + 0xb00c, /* GCC_DISP_AHB_CLK */ + 0xb048, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0xb004, /* GCC_VIDEO_AHB_CLK */ + 0xb040, /* GCC_VIDEO_XO_CLK */ + 0x48004, /* GCC_CPUSS_GNOC_CLK */ +}; + +static void gcc_qcs615_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Disable the GPLL0 active input to MM blocks and GPU via MISC registers= . */ + regmap_update_bits(regmap, 0x0b084, BIT(0), BIT(0)); + regmap_update_bits(regmap, 0x9b000, BIT(0), BIT(0)); +} + +static const struct qcom_cc_driver_data gcc_qcs615_driver_data =3D { + .clk_cbcrs =3D gcc_qcs615_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_qcs615_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_qcs615_regs_configure, +}; + static const struct qcom_cc_desc gcc_qcs615_desc =3D { + .driver_data =3D &gcc_qcs615_driver_data, .config =3D &gcc_qcs615_regmap_config, .clk_hws =3D gcc_qcs615_hws, .num_clk_hws =3D ARRAY_SIZE(gcc_qcs615_hws), @@ -2978,35 +3005,7 @@ MODULE_DEVICE_TABLE(of, gcc_qcs615_match_table); =20 static int gcc_qcs615_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_qcs615_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - /* - * Disable the GPLL0 active input to MM blocks and GPU - * via MISC registers. - */ - regmap_update_bits(regmap, 0x0b084, BIT(0), BIT(0)); - regmap_update_bits(regmap, 0x9b000, BIT(0), BIT(0)); - - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xb008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb044); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xb00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb048); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb040); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x48004); /* GCC_CPUSS_GNOC_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_qcs615_desc, regmap); + return qcom_cc_probe(pdev, &gcc_qcs615_desc); } =20 static struct platform_driver gcc_qcs615_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D684480357 for ; Thu, 24 Sep 2026 12:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251695; cv=none; b=ocAu+40bpWydJ1YE35UsqOlHJSYRMAphisEq2tkBV0iT7DBBpIbyuJV0lKRwLR+FVwtRmkW1sEWXGbG7WtKbirkUQOz0aJwufXXte9LNLWK/fLh3aEhfd4FFPoBlwf/wbVJEH81i+hjwcy0ILw/TcTEUc9gqDnWtiMQg1WGAjRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251695; c=relaxed/simple; bh=VDhDWMgzMC0PXchZby/wnzpwg3D+h8413NPkY9yBXp4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cVVpshVHGZAaTf3qutIoRXHGkTtXY29eC1iE84L6oilgbqVU6VB9/N/oEgNr4T96avRBVcl5lrOFpbHAO7qoWTnegBfz0s/CUWu4C6fS0dC35GLAMCiet3B6v8BdkCG8pLbzNJ8DCDX1p8SE0fh8AQ2AVPKjbjv7aUYIjhD2Uxw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HEUCEKmu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N9yc+UTq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HEUCEKmu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N9yc+UTq" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC50Dr1430123 for ; Thu, 24 Sep 2026 12:08:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2PmV+jegEhd1deuQZcEWItaphXBp+1so+sxalh4iYq0=; b=HEUCEKmu4smDKSbu VBf9H8Mq/H1dgLFeTvKb3XY+MiINclJ3HMDB8X5Kar9xShZZCbE9grPIVW046fs0 XmR0dCZ0dYdumen5kVhHcwMTRnoAQuLaVAVrzBFT/vZzypfipnxJRTpEjHmW4D3t Z+iizcfy4uD2F/yiZcZndlO1Ov1fpcq56wMg0hkBBdPHDcG/9uRD09JRvGc8qulJ 5L2Khk8reEEYqZ+E44nrspWcvRqRd4QNR3xtHj3nDpfYmRcjEMiuJxXO3KrElSCE f+mgHAYjHTnZ0Q+hsF7QxCTyX8C4feXSl2krZY487tht2+LUh9J5jFRr7Bg8OuJK jAtdOw== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvvgh9vhs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:08 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-79014f0b44cso1753297137.3 for ; Thu, 24 Sep 2026 05:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251688; x=1790856488; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2PmV+jegEhd1deuQZcEWItaphXBp+1so+sxalh4iYq0=; b=N9yc+UTq0RMmRTu3aqNIA8Rd2d6ZekP7U8aNZX+NTm8qnJqVbNh/Q/gV/066pOnZhC Hr3fB+dCUSRp0mVBHQfiMQWCcGDZ50tVsCwjLz+W5Gy4j5XhL+PG8fRObm24MFtjw5ZF xLQ5GmCvK8ZhynmXEhvvc+oDDBV3NszN16LjPVqDKiB03S3m0c1jqr0tmEgYmsXcGGly PrxcC7+aO50jQzLAOw0Vd0Wrek+6G0Ura6AQP5yGWhroMhTSgNX7zEx5duYJzkfIhhwO QuTxMCmlREbKG67twlZvzuyS911voCtlNdWo26eflilFja/dqNXcY4qxvp6iZXbng4MR eyXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251688; x=1790856488; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2PmV+jegEhd1deuQZcEWItaphXBp+1so+sxalh4iYq0=; b=Y+ISdoNwWIKbbuUhvLBNyPhODjvRjYNPgZor0VqNUAgD0LAyKxRiBrmrSb6tyfj3nO LK6DoRMa55JSR0yv3E3Dk+1u4iqCmlA4l0KvXD0TeXWyc6bouwYDin/07hAQmxIwc9KG IGjo6SbsFhph3MPx0Ytc15A+cuO6tFR3bORUWVtKVLpckUGS0VGs0zi1plNGr21lzOov 7g1eLq6o/cI0MRvdaVnkjbCfehKO319I8blXYV5pCH2dDwbC3yE/VuTO+MQzkjzFnjJE WknFS72oLO36RuQhvGNyX0QB7wPzz3isVzcasM1iDPe2XZkh9bmMI9k6AxnYkZmhB0z+ /Lgw== X-Forwarded-Encrypted: i=1; AKwUvBww6z/wIYEzKQPGLfZclGielWJxfPxt2qz5nWMnX3t3unhM4hC/7NyOSkB68ngJMYTlKvOqX7Wf/oqTFJE=@vger.kernel.org X-Gm-Message-State: AFuF++lhtMkeLVn89RMYYDbOqwujH/Z7cPtapcsYpV8y1jvVWR/ohr4q R4ikFf3edM5obgA8r8f3OA4TF7GwvuoYBzEyXBnOvhiH+F+jSYC1hhuJxxS/5915L2G7tnLwXnK /Q3iPw83nFmShCuPe39U1A0hziuWVBieGq2rb9mTni2Cu11vMbGb3FpEzrh1Hw2Kds3A= X-Gm-Gg: AYBFou0bETIMaHYbBibjCuMi79mFXXICjTI8tu+a1mdeVWmfHnsTkHhQ3fuHbHi3bTJ 2y10bBKfurK70btnUNp1Ys7nwWWFXZPIiokHZvu6Fic4YXhiee5OIcY2tTy75Pf/jd0yknklCm/ QvsOd3+iK5tqurjHDw+gO706hD/kgLGC5D8on4jkskIVLb1ZOBWoAiBtekov7baPsQswm0NvRbT z/ssXiVQO4FKO7ngfs3Y+bXn9yvFJfQ7cDI9lfIl5MUwbqY+oegyt+NxU2kxAp8qJQBReUMnTsL QAJM2a0Csz1oM9nm+75GS8L7JjhAHLoc7TPhfjNwlq8PzIJ9A+HcTuTEWgwcxXRPBhaF4R3dUow AGC+cLrfZ X-Received: by 2002:a05:6102:808b:b0:7a7:198b:6749 with SMTP id ada2fe7eead31-7af1eef1fd5mr1109162137.30.1790251687351; Thu, 24 Sep 2026 05:08:07 -0700 (PDT) X-Received: by 2002:a05:6102:808b:b0:7a7:198b:6749 with SMTP id ada2fe7eead31-7af1eef1fd5mr1109143137.30.1790251686611; Thu, 24 Sep 2026 05:08:06 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:01 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:29 +0300 Subject: [PATCH v2 17/48] clk: qcom: gcc-qcs8300: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-17-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3230; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=VDhDWMgzMC0PXchZby/wnzpwg3D+h8413NPkY9yBXp4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJR/mVQkWUg9EXLx4C98b1vxKmJgAiCYcnQL cttsUvo6F6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSUQAKCRAbX0TJAJUV Vh13EAC6lQ0nuxF9L7sX69f+YJeNpRMJ/BeBBCZ8TMluh6D0PfIyLxpjOYVKiBMmQMdLianreX6 EG0JGmnRl1GhblMJi0QemGiC8kn+YzS5yWe/354fUTqUdPmiK56mfDL4LgtE35vuFuxODZ/l0Di /jkSQqPckhxP0mGUUJq/erCnRfDwLB+pPSTgNR9QN781whiBcOfKb66cL2/h7Xo6i79DqXV+bH/ sdZCyrJcGUF+j0SYG/Jdh5hiYgijrPKumaw4PZloeRTqzNu3LN0F+cX1WOD22nh2V0C3iZK3bmW p5a4hwnlGlqRfOD2aPrpuuXWiaxEacTH8WSyWcVtwC7EV6hzdvBqTQVCfDTMlKaZr7ompcUBbFe wYDpFVD6tTQ3oNr4Y9m8sGbfUy78wG3GDRTiAtSepkWx2An3sPnbotu2iuxiqBmcHwEj3sx2S5E UBLcUf8blXiyOsKglPDyaL1ytMZ7aYlaKg91LNZUBAxRIFJ+5sAPmQ3nvj9ZcMrb7RdS6ryrhhY /+4tr4yhOJMK7ebLjZUOBc8Mhh75PCngj5Ci2hfAX2AJ0ZUIdHPxrvmUdEd1jzevZTLaikyzpMQ 954hI9NLW/WefSnCk7xV3mSfk0lwplpqK9c/z77boWDxObKOGYVhuz9VgROZJUTX9/VUy/ykm3F UK7lH7Of+IsCAlQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=KYhHIgYD c=1 sm=1 tr=0 ts=6ab512a8 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-GUID: wDkqY9xQfAHSpAfHVgbAy6jiSWUrx0AC X-Proofpoint-ORIG-GUID: wDkqY9xQfAHSpAfHVgbAy6jiSWUrx0AC X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX6r8S/9cF0kAP CuCqzjN6FtcdF5vYZYYO8l79vztu3b1Au26PH01xMZfxLPh36zMN7HpND/AMUKX4e5KpAdb6VOo 37kwmtFMtih6ZwOZXrj2F/uzPh88Vl0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX08YpDRQtn5n/ BwDLxstKnTTK3AQtMEhYzCrr44UkW1icjGQeroSBvRnvIO8qItGVvKVJgIVkPxylAqQHeEaz2FP 9dQwGx+/koNq/f1Usg/rh6NOpy1S0zcrkc8x872ftMhLFsJELLqE28yNxCooPRuVk0UWyMHh6q3 zme7KDFwzLZFddhnEXK7i1pRRPBlD3NEClaS152CQjSuCfEv3aM6ZAQ3dTCm0QopRY11VA3fi3R t55Uo19yTx9nuSCpuwfA40zKi8BylAwXw9wGKRxhyKkswkEEfKxOvTNgIEMalPIac2YvjfyPymE 52Ofxjd+9uWUOLyO9/XOqyKRuLueJKyQp6VZ25TMCJTIoTnU6cWuyWD6M+3sVYmiZzaguNrq0Ui tzROMGjfqIFHdg9X0ESAJv4WkcC3oXA6ZT37buMAqzOzUrK45nstmY/psYgFIrbRs1inkunSRlS 3Ww3FFZYa5uTV11WQeQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-qcs8300.c | 51 +++++++++++++++++++++-----------------= ---- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/clk/qcom/gcc-qcs8300.c b/drivers/clk/qcom/gcc-qcs8300.c index 57014c4f8c6d..b95ad566cde3 100644 --- a/drivers/clk/qcom/gcc-qcs8300.c +++ b/drivers/clk/qcom/gcc-qcs8300.c @@ -3673,7 +3673,32 @@ static const struct regmap_config gcc_qcs8300_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_qcs8300_critical_cbcrs[] =3D { + 0x32004, /* GCC_CAMERA_AHB_CLK */ + 0x32020, /* GCC_CAMERA_XO_CLK */ + 0x33004, /* GCC_DISP_AHB_CLK */ + 0x33018, /* GCC_DISP_XO_CLK */ + 0x7d004, /* GCC_GPU_CFG_AHB_CLK */ + 0x34004, /* GCC_VIDEO_AHB_CLK */ + 0x34024, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_qcs8300_regs_configure(struct device *dev, struct regmap *= regmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); +} + +static const struct qcom_cc_driver_data gcc_qcs8300_driver_data =3D { + .clk_cbcrs =3D gcc_qcs8300_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_qcs8300_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_qcs8300_regs_configure, +}; + static const struct qcom_cc_desc gcc_qcs8300_desc =3D { + .driver_data =3D &gcc_qcs8300_driver_data, .config =3D &gcc_qcs8300_regmap_config, .clks =3D gcc_qcs8300_clocks, .num_clks =3D ARRAY_SIZE(gcc_qcs8300_clocks), @@ -3691,31 +3716,7 @@ MODULE_DEVICE_TABLE(of, gcc_qcs8300_match_table); =20 static int gcc_qcs8300_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_qcs8300_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x33004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x33018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x7d004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34024); /* GCC_VIDEO_XO_CLK */ - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_qcs8300_desc, regmap); + return qcom_cc_probe(pdev, &gcc_qcs8300_desc); } =20 static struct platform_driver gcc_qcs8300_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8479948643D for ; Thu, 24 Sep 2026 12:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251695; cv=none; b=Ki7TgUCb2MPOcc8XrTNOv/yT18wbkc0aND0ahwfj3HKR/7eimrhCs4skkyv9MGWKNW+u5P7sK7tHZRJyhauX/YuY9H9Ip8hVmaJv112LTKf1Z+/jdZzbVbZ7ey8SudcUzV06PckOih0XHKtXwhWwsWIzYVfe0bSwmz5iqqLXDxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251695; c=relaxed/simple; bh=ARsbxrH/Q7WYwpyJReSEhO4CvLWr6uo+1CRyqPxe4FE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=toqhTnzN1w7L0gxP7e/PsZv29YxeoRGY+sBoOmniiIDSyB8kEm204b7FGZ6AsHItYdI/dGfPwP1Gsn3zOLsniTV1XHRp+g8Z9ASEo6T/D/tYDsAT4b/ZvGF/MiNZs1rXeR09tStAojUsuQ0col/NoZTUAgvtiiUHoPMiY0EMKrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eNvodxdH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ALYeefc/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eNvodxdH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ALYeefc/" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4WsE3134054 for ; Thu, 24 Sep 2026 12:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 87hYcWFubNegLgmjMiXeWDlEjaezFx+NSFVdbN0rlZw=; b=eNvodxdHqoR4CxK9 YqqlDGraeY9NnEYa8YxgiYfkg/9UF8bmQ8FWiJMh4Pkb7JEZS5VxUqoxntcCFaV1 vFX9FMjvY7qZseBVlQoI83Ga2vAJ+WUU7ljkMu8y/RdxYAzCIHlZ0EVSGLNMXTu4 55jO4w2v+p0pZW1JPxkXVzfCT2Yj1pfph8tY0w4CtAWDkyOear0jHddwIK9NZM/3 luHr4vxLcuZqa/lJ/QB88sxUjW9ukrt1DhJdORokyFV9gYH9/m3OYjvb4O+7CHr1 Wmw1bw3U5Y2hW81GqscHanl17vBMOJfOZhuLcEwvyepR3Ji05NPNugXR5BKZMe22 +zvk0g== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1ragggd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:10 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7a8e3cc28e6so757754137.1 for ; Thu, 24 Sep 2026 05:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251690; x=1790856490; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=87hYcWFubNegLgmjMiXeWDlEjaezFx+NSFVdbN0rlZw=; b=ALYeefc/Qmwmb8QfDvGmbrnxudCBfKWkdNJ5rMAlVTpWqP+yKbetdbUV3b59+SHJw4 uqQlxdj+xLFpbvkyNUyjch9cMaT/GCMO8lXkZY3dh4lBiAQ/C9VmLeGpuI4kQr6pkpNE uw9O4Rg4M66lbPzFl/trvSrjSE8/v7UIuyhLF9pygTMc+FFoeV7qlMech/vyUm7jDDsq R8eYrDMRThXUSVYIYPXnpjkJadbDTwMhjiwI03IAHpzgdiVEFEZbXurpR0biCIcbMhCW Jk+mm1yQGFIlJvK9dKLS18Oc6Tx0rQMBMpYmNqKwmmiHziyEu1pn6gXCGy2yUtA7asDE JxxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251690; x=1790856490; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=87hYcWFubNegLgmjMiXeWDlEjaezFx+NSFVdbN0rlZw=; b=ek8GwtKprvGEPBNXUY/gyFouzVSwD/HqwdlklXMA5K9g8xZAXgkvlutwL/3SDg++vQ oPdBaUNStpgJ1ErffXjk0SJqmQh0c6LvA+yzHpI/F/Jngj+YfQTX5vjkl+DC5+UiTMTk cHCefyPdXmpUEK8/mjIiiDSZNmu9RHUiOsoAzT5nfM+tbtN/0tnj+VUkcVIbygHq3otp ue/HPMrY+TE2NS3UTesQQH/mwLdysSSu9B0/9yF46GLeDJ7LRGfNmXoqzjdhx+Lu8+VW 5/f8+duo5mjVYDaEIuYeT3Z1roH70XK1cEqw8y9iLBtiG1LfFomtUPk76SGmrDEPacsJ pAKg== X-Forwarded-Encrypted: i=1; AKwUvByUfGjBSt0fQyNp8rLcSivj7pUupp6fP9msjXJ5izflre3vpsqzTGgfdzQ+847OVlINdVXvsBbmyv3NXqE=@vger.kernel.org X-Gm-Message-State: AFuF++lgTTbdMaFDn2vK5UoiqaU0RZXqX6vYyhPHj2pwzL4YhgF+m8xe oJ5u59Dda4S0xuvPgR9MlhonyFxmRiS0YP0BB0N2ZBNmSmYmpUKAQcgjcxfIz4APv/L6jpJq7Q9 rUS6qyvut0Naaf/y3RFACxc1v4Wu8jBIcYQOHHX6osLnO3YyTtXomh4beeWAykjCOwMo= X-Gm-Gg: AYBFou2aC8m5CLGf9fxHlVHQYZZ1XIRkNzxkGCUDFAkua7eZedxat3JbPNm1jFxYFFT BfYQdAmP38mIGV2X6Y0Gy6/ZkxpgA08DupASjnQ0s55Bs9cVe8h/YcwQDbJ5cH817pveFusg9vr YgLV/qDYGjeDKJzWljWUkHZ7S47vkQMq9HLiIGCcUn1bKhMMhJV4nIpwGoI4AlPWrJkKCyjdbtd x1PVgwQQKob/A2k7rtf+Uzvn18J8pdVmSWWGGdKWaP1ntEM1h/O4veft/Zap+uvM+L0uja2m7Va qlFHXnZpM/qhXLA1TM25Jj60C5gVzZvMJIDX/lg2Ni2zGgvviDIG6OOpM1dCwaTintSD7HYQjuV rCKJNXDgH X-Received: by 2002:a05:6102:a216:20b0:791:40c:a2ca with SMTP id ada2fe7eead31-7af1c692a3emr669695137.9.1790251689740; Thu, 24 Sep 2026 05:08:09 -0700 (PDT) X-Received: by 2002:a05:6102:a216:20b0:791:40c:a2ca with SMTP id ada2fe7eead31-7af1c692a3emr669683137.9.1790251689066; Thu, 24 Sep 2026 05:08:09 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:07 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:30 +0300 Subject: [PATCH v2 18/48] clk: qcom: gcc-sa8775p: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-18-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3431; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ARsbxrH/Q7WYwpyJReSEhO4CvLWr6uo+1CRyqPxe4FE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJSS5om87WcIhDTC7qf1gzvcQ7wAFHW3Cqkc 061PURAv+6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSUgAKCRAbX0TJAJUV VvcREACBmmog7zmvfyXOTZhZb9dhZTaioFGbQD3KcIaPS5vwz2AMsPQMC6MgzJCrKHJ5PZJ3zoq Tc5SGSVtg+95YGcXIWXOcYJ8pDm1S0tWGIA6Of/UcQ+0fivQJaftnldHgLPTlUrQqbAQ8fVDImB awMLHZPuqr9TM09hAb+c1A4wQ6Etd2hlmnG+z0jL0z8OWc7YPEEZUUeacQyMikVe8YAj7iDBAhG KlcMSrr+z3tyRME8UHH968a5n6imO/0VSq1eoum4R43a9zWi5Rbn2lwm4BFM0xeYuechKHfRFQ9 d9TFDO3t5rVQTdnk3DYUgI+z6wq+mz3wHT4lJXn+GttY7Iy/ITSaEXowBGl4hIJvm+EKZ3K2q0U sn5uq1J3m2xyINib6pM0R5Kwa+gJf/WzAzjS+l8tImU5veU+RIQ4awQwBccfN8oxVR20D3KFLNd BdzborU5JmYmGJwxeotMr48xZZopfnuBhvt+NA54eyUTuFRgZ6u377cheuZ2kuesba+6NmbArEe zR6AVR84JxBjAMqOUMITdk7W7XRzDGt+WP1XcCa/czt7ytxW0tl7NAzVbBkqByIh85rxxztLQUu CkWXnvyzKp2PkcteFpV0+sP0ubPFJgGfPanAEWnLXOvpPgYop9twhPqLikckIokRDhAZknhdT53 zv/haOm8U1CMcgA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0/UMYxyXnt7R ON17EbDbD7ggbTWl2jEjNukTYriBGiDtJAsvZr/+sRZMvJw3Sny90mJQBY/zaYAHG77JQZZxiRg pwXIXVQTJ+J6YThe5j+VvLpdvl4L61z6KWr/1lpqft+stpaFg+OAyPLgwt7XVegc3s7fQI8ktL3 MQkeT4KWZIoHS4astXdB6auo2Jfixl99mSOITnilObg4+YsGh4bZLay4NKanT7bUaeMCqJAmNS5 N51OvaLsf3DOzNBK6y4dg4Di80b7QSrqLVyjk/logXhxCdPf2mzxrRt1gJBxfCfqvbN0U9Ighzn EAFDjIA6ax45lSkyShcYIkAQu+eyDz36SgwUevR8jIwa6PPDLtq/FfXu0sf2etuJxb/Hz4IoXJD wWfixKnY6MIxSRlp/d9ayNSKxU/rwRlYzmz1V0oLF+QylyVha5T9Af/OJWQuJ0SAJKZkJ208lkz G5G8tAYTeCZ0L7WELlQ== X-Proofpoint-ORIG-GUID: UKvg4P07FNejSKq_qLlLPWag4jqlkHXH X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/quZPXRQDh+N GHalIdgpB68f72r3nlAbHAlAOEKEArV3oJIKJZa6CiXwcFGFrM8e19VZbkNSK3mmQJfFUfry+rH +9tkuHWFWuIovFJAsMZV9HmDxxvUw/M= X-Authority-Analysis: v=2.4 cv=fvpJ914f c=1 sm=1 tr=0 ts=6ab512aa cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: UKvg4P07FNejSKq_qLlLPWag4jqlkHXH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sa8775p.c | 55 +++++++++++++++++++++-----------------= ---- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/drivers/clk/qcom/gcc-sa8775p.c b/drivers/clk/qcom/gcc-sa8775p.c index dca316decd0e..fa31710ef557 100644 --- a/drivers/clk/qcom/gcc-sa8775p.c +++ b/drivers/clk/qcom/gcc-sa8775p.c @@ -4644,7 +4644,34 @@ static const struct regmap_config gcc_sa8775p_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sa8775p_critical_cbcrs[] =3D { + 0x32004, /* GCC_CAMERA_AHB_CLK */ + 0x32020, /* GCC_CAMERA_XO_CLK */ + 0xc7004, /* GCC_DISP1_AHB_CLK */ + 0xc7018, /* GCC_DISP1_XO_CLK */ + 0x33004, /* GCC_DISP_AHB_CLK */ + 0x33018, /* GCC_DISP_XO_CLK */ + 0x7d004, /* GCC_GPU_CFG_AHB_CLK */ + 0x34004, /* GCC_VIDEO_AHB_CLK */ + 0x34024, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sa8775p_regs_configure(struct device *dev, struct regmap *= regmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); +} + +static const struct qcom_cc_driver_data gcc_sa8775p_driver_data =3D { + .clk_cbcrs =3D gcc_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sa8775p_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sa8775p_regs_configure, +}; + static const struct qcom_cc_desc gcc_sa8775p_desc =3D { + .driver_data =3D &gcc_sa8775p_driver_data, .config =3D &gcc_sa8775p_regmap_config, .clks =3D gcc_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(gcc_sa8775p_clocks), @@ -4662,33 +4689,7 @@ MODULE_DEVICE_TABLE(of, gcc_sa8775p_match_table); =20 static int gcc_sa8775p_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sa8775p_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xc7004); /* GCC_DISP1_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xc7018); /* GCC_DISP1_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x33004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x33018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x7d004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34024); /* GCC_VIDEO_XO_CLK */ - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sa8775p_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sa8775p_desc); } =20 static struct platform_driver gcc_sa8775p_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4AB247F2CA for ; Thu, 24 Sep 2026 12:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251696; cv=none; b=TtrSwBZkbTjQ7rTbrLdZvn+opNIqwlU7NGigo17Eb/CyG3Zo+L1TqYObB7D1buKPVDdrAziWCUT5DHYBZOvPMI9XUlYenbZoBbVfPE6B9GBi0hnn/urlcdTX0+ulbL9q3bohQKB8cGca1+lTZqOOIpLPqmMSyf0mJG9sWFZhcsA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251696; c=relaxed/simple; bh=/w84xb811UCdfbbxRLB1tMb/4lRokzCJN/2N6GCioWE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qAwlmnfaN1E6D7z7SmxFaYEy0LvIreNYEsos/YHtIsN88SrRM56F4v33WTGm1CdvH03jcMjBjO7YX3PRj8lx+TnHhQwUJuYJTgg8tH9uoKxoJb9E7yRGs22GKXJzM/aZiAU6Qi5vbR5w3lNtmQ53xiBzhPyBleJONw7GwKV1brY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZI7nMF7M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DAGT3UCQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZI7nMF7M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DAGT3UCQ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4s8p1630757 for ; Thu, 24 Sep 2026 12:08:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sWSa5lB3j3mcV9ImYYXYzCgGvPWgSCaRoBUOlJ7hrHM=; b=ZI7nMF7MqtIx468z Ux6nv4gOPuuSpCl+Gra12VejnmtcYwLgeIrfSJNB5MLw3T7pGpSgeojsvWLrfDyF DTq2m4ke/xCHv+MEsGeoxuRiigYNLLChOAs0sIXZE+eaSnrO5qtlWpNXCBTZnCtZ M2wVN2u4bW8+zimOMNhghX8uWuZ0OlXtFg7co3gHTHlxsD3qiXAGbmaq9MZ8o1m7 gGHIRvQYBvfg1yMMAAjCG9HiGjb7aw/b9eMHc9/4lqLBkrHu2J4EKJfe2+MhfmWt vbJ87iFOWepAnbvMqSRBGFSI4J3XKjDWiM4b7MSquY4w4eVwOC5HsIQJ91FBVxcM uJj3Lw== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90axd2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:13 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-7a8a773db4eso605620137.0 for ; Thu, 24 Sep 2026 05:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251693; x=1790856493; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sWSa5lB3j3mcV9ImYYXYzCgGvPWgSCaRoBUOlJ7hrHM=; b=DAGT3UCQPLTeDwYfZbJfx6ZfieIGI0SNIQ2JKkFD2XeyIyVylTuZ0H8FYTX7MNMBQF UlP5scsEVDueLW/FHpl3YAYVFyVvOHmbkhCAbpPn8dCtOaGeTTvwhebsCLeoe1iQXzNK qx4Z+dtmG6gGRtiBrF1w+hZnzoO4EAnoNY4UIicc1VnOCDxmE7RCKbR/Uw7bfOAGOAQU 9F3K6cL/oEBJ0MC9miwK9QHdgMFVeKH3Z6hAVbhlqf47yDIkMsd+fSsOqUQUvM6Snc3I PbfKdP1XExQootnp1tPdtj581CHAOz+wsAtugGjnDXY15Drq7ClTacHsfWTIlMwtXN7g CIrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251693; x=1790856493; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sWSa5lB3j3mcV9ImYYXYzCgGvPWgSCaRoBUOlJ7hrHM=; b=G1i7gxaRYY4T85YaFoKCdB8mF2SUrclIngUzpalZNBIQ1CVr64Gh9o+w/laAW6MF1D 9US5IodBo3zG7FoIbU4eO5W8qawNwz0sqww3PAjaZO40l5VEdSresW5G5nQoP0Mmbkcf 5Y0421b8rdt/Gmc0FD5luYbHP9KwJnzafbijkb+YCHtpa3uSoH/4kh1TsoxytDsvT/Uw eNywqLjRMtP0hKHlCusNvRh94yjqvkwSd1WiLpCCobhl4fKfpmEJ31gQtkhF/hNovLGx bzyVELOCBDLg5FcwgWpU1zmbDGCCUBWJOhltpZwCMzkWGr4U05+bZGhjjK/8AqZMES3G jz7A== X-Forwarded-Encrypted: i=1; AKwUvByU3PIRjC/+T+90Zfky5bkRquG+upTy9FTV2iH8WXoZaqjd9lQKYJDLccTfFA9eSEpNJkgH81fkpO7FEr0=@vger.kernel.org X-Gm-Message-State: AFuF++m7rF7afyPeIdKU7OlUOomR3IiunjE54/R3yHgy4QRuxDFRaO2G cOZkocjnpJVMq5k+AXsTvr967ksZbQtZ3lAfoHoU7kHLOLsyhkHp9AXv8ZF3stW/J6JMHpFTgGX sYeVbJaoB3XlH08dxgcn0j/CmCEs8phdIIhAdOHtoNZxJ+zbmKjxgNttN8G/LXOLpoOAHg8fIWl 8= X-Gm-Gg: AYBFou077q75U1oJqos6UkyIbsVRz2oaMxukAaKDLTcyrGOZT8QXTEb5FwYQUmjemQU Wvc/qpBtIIzCuRnyk1M6LfqXUuVcQFLaJ2wJ1tQ08zzWtglaoZFw8noQ0gDbi9CWWuSseQF1yTi KA1irEKuS9Ugz+6C8fxNoYa7NQEcz2nFTjX3AzVuVPVdhouLtWsOIihG2s/qbKJgHdUaf6Rbqul eos9Z4gi25exF9zposCTvHvFgteZpSi/w73tOls5BB7Tdivx/LqR809j1Secghr5Dl3jKK+tHd3 myySApJ2h7oaB9MWfw6SbdDLcdnoyq38UFsHm3SWq4ownz8EIgs0n+bD2qQ09Z38NHyhEfhzABp NmGZqc/lW X-Received: by 2002:a05:6102:3911:b0:7a7:1db6:c769 with SMTP id ada2fe7eead31-7af1e4e799emr1024517137.22.1790251692504; Thu, 24 Sep 2026 05:08:12 -0700 (PDT) X-Received: by 2002:a05:6102:3911:b0:7a7:1db6:c769 with SMTP id ada2fe7eead31-7af1e4e799emr1024497137.22.1790251691828; Thu, 24 Sep 2026 05:08:11 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:10 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:31 +0300 Subject: [PATCH v2 19/48] clk: qcom: gcc-sar2130p: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-19-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2911; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=/w84xb811UCdfbbxRLB1tMb/4lRokzCJN/2N6GCioWE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJTU/zZ4BCqOOguIUe32WeglSEcxybbhOZie f9cP/zM9cOJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSUwAKCRAbX0TJAJUV VgNiEACTxKAop10Ugh+1QfmTPmkAkJTrM76NCH6Lm/KtiHW8RkCdtN3PiF0U9pWWib4ik8JE7iI 15OhaTiibzhNwJsjTIS9qkarionaj37U1si5tJeBWNz/U/NsuSfHbK2VsvS/w9aja706/Ndsqk9 xF65UnAkY5wKh0P/N6ZCQB6MTYU2RuEoyfBkcdk/eStuhrMgu8VLSddKjd2ytrksGMPVQjrjZ2e jNEBL/1sBIEvmWDqSL8WD61hB65LZ7uI/BIZ17RsnpPMWT55NtzVtd6WkE7xMLvKhsXAc9ypX07 haqhuzZX2rbL4sJHL6LoR2NOG0MvqEc5prRtI11wB+CFZMtwIisVpE6ddYsZ4rlD7adRWWQd+Q7 M3bsNIhcNhv2vesxV5Nm8vxXKdmLWPpxw+B64B6mg6fmDo3+lkqA/PzjGsUAjAVP37S/WIm62GJ 7/jaEr2WITgHE3UdqD37MyG1qXjQ8ifuZwCkJu+/epdRs95IzCSGaAxgYmTB3CufKjLllbHfvuh ZKGrK5uzfUFIRtC9s3s05rxbcAl3fn9kZ/oJRyi39XKCJnLrjluqC50/1wtAu6l77+NV0bXjRT4 NKdieGFWhfSJ4xru2tHWr/9KvcT1KR/Y4Tj0/3Qx1aRKMmKLyWSAOoq42ht2jxcnHczN0hzjdW5 4MwP38Fck/tgEVA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX696xaS44SHeS befEfnrLctbyY1e7Ad1cxhAhKFQzA2wDOG/lQloT5+3f5MYRY34GDFagfqbd/x8cM78RCjsFpGc 1CrwGe4V9CZvARoxlJOJXcQL0iPduc8= X-Proofpoint-GUID: NahQdA8Fl0fJR5OvThBE9m_iASVz_cIC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXx87npPjkDnpf Z4U4w6cEp/7qX6oaygKuu1zSVGX2QRCQMQlxdxHlcCmp0g+LrBR8//alAsg7paTr11TG9igwBtc Ku7hqGM23V8c0mHSnHqEG+F+csgRInYFkexnbP9qfcv/bAr04qq5iSruaZI82dary1jHQqPCl7g 3l9YzyRI57uEbSvYrDtXAnFWN/e1O58BO/2QlWvGbLnjzWaMKWVfAm5T40GpGsgZDH/i9celnLK gblgGm+CXAYxFh1igbBeIT8GmjF6F/ybMNByCVT5OhfBB1i4+IgTkNNUTYsmxhmPrdP98z+qw93 Z0IWUMB6m3mdR63Yj8L64nfmvBPrlfQHZahRfd5HsmE5FQYfsvRR9lI5pn9y1U9aMrj2xFfKPt0 +SfA5+P9QHjaPtJPQAbnsHmGhMrO7nGHCLHyQ6o5hlt4wStJ8nHXPU0GqsRm+9Ih77ELXjuLfKv pmgSZFt2z3u201BQXiA== X-Proofpoint-ORIG-GUID: NahQdA8Fl0fJR5OvThBE9m_iASVz_cIC X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab512ad cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=8L-1-Gifo5kdOXCWqOUA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sar2130p.c | 45 +++++++++++++++++++++----------------= ---- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/clk/qcom/gcc-sar2130p.c b/drivers/clk/qcom/gcc-sar2130= p.c index 7456001cf25e..f40d10274c02 100644 --- a/drivers/clk/qcom/gcc-sar2130p.c +++ b/drivers/clk/qcom/gcc-sar2130p.c @@ -2300,7 +2300,29 @@ static const struct regmap_config gcc_sar2130p_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sar2130p_critical_cbcrs[] =3D { + 0x37004, /* GCC_DISP_AHB_CLK */ + 0x42004, /* GCC_VIDEO_AHB_CLK */ + 0x42028, /* GCC_VIDEO_XO_CLK */ + 0x9b004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sar2130p_regs_configure(struct device *dev, struct regmap = *regmap) +{ + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x62204, 0x0); +} + +static const struct qcom_cc_driver_data gcc_sar2130p_driver_data =3D { + .clk_cbcrs =3D gcc_sar2130p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sar2130p_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sar2130p_regs_configure, +}; + static const struct qcom_cc_desc gcc_sar2130p_desc =3D { + .driver_data =3D &gcc_sar2130p_driver_data, .config =3D &gcc_sar2130p_regmap_config, .clks =3D gcc_sar2130p_clocks, .num_clks =3D ARRAY_SIZE(gcc_sar2130p_clocks), @@ -2318,28 +2340,7 @@ MODULE_DEVICE_TABLE(of, gcc_sar2130p_match_table); =20 static int gcc_sar2130p_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sar2130p_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x37004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x9b004); /* GCC_GPU_CFG_AHB_CLK */ - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x62204, 0x0); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sar2130p_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sar2130p_desc); } =20 static struct platform_driver gcc_sar2130p_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3871D489FC1 for ; Thu, 24 Sep 2026 12:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251699; cv=none; b=nTQWNXqO9BMTEPsPl8XE7Ql0RAHU1qTc+7eZ/ABjcSbgpA7QBBr6Ng42zTXZw0k9A0z20RJ6sIm6C6GQRDYHHawdMJFruEaGaqJ5058thSsfG/Rbpj31aomnVJ4n4+bhv5UIQnrZXhH8SrxAzKHkCYEl+mF4LSzB3BG1Cvw9hUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251699; c=relaxed/simple; bh=GOaZqDXf/TeKArbS7Ev2JBNtwRB7b/J0lUfFhyNF3Ec=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N7YP3pzVm1qyX3L23RxnEC0Wg+6J8MQLAkSnPlobxr1Zi4WDJohbxqHfF5XTew50lFXKHKQKBmwOpq79BHTlYVqUmyPP+IuW7m7/Nx2IjcOmDYPRXRmWnPURHVXL55vr2VxELQWWUNxEE6uO3ebZuZpTYvBj6+/dXMElnjd0T0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VYv66rtU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iSm5KFbr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VYv66rtU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iSm5KFbr" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC50rU2002349 for ; Thu, 24 Sep 2026 12:08:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kr63+K8VrovD5vtNEhfp/foiZPBihM8XyyQx+wo7buw=; b=VYv66rtUcydAAvZi ld5f7dQIviGTmk5SrEjwqsuZvI0L7WzKJ6+vtYCgb+UtiAnvZZHkT+wWb0smqD+L jREWHoJWJNRzKX6bF0c74sdELcPDBEX4BpqZgBdBcxaKFua6JhSAyM4H3l2O5g+c X0bhgtCq147CZ09k54tF7ri+oQZ48AaM0lax+AGIHcnFAYJwdvnfddpgwyXLmTNu jKxxMAI0OeAUd4rSyfnGGhqJ7c8HKaWmE4/iq7gkuolAdJsCkGhHtugkNSlS7e/S HC8kEBfffQFMFvC8R4a+qKzHXWnZDaMWbYWcFIYWJQAzgxaYoZtxzAm2zbwzvsZr kYwRCg== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvmrrbedd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:15 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-79285c98038so1729376137.1 for ; Thu, 24 Sep 2026 05:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251695; x=1790856495; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kr63+K8VrovD5vtNEhfp/foiZPBihM8XyyQx+wo7buw=; b=iSm5KFbrt6p6SZWInapzs3dVEnVvMg/Dub5floOkSDVEI/ZoAZ+x1fWOtOLqcpBKU3 gZnRKCjJ0NEC3ATMkBltjX0kLx1lnuaAlICHlPVU1jb19bwqn4B3HmYIQVOHZ6RYmo6X ogc8An1eAoceFW492U20TRPXsIvKnAY6ZZ82kTVWRsVNIjniyDI9lsJTUW42NENo+SRr CAWCewZI/njBZ4jUi8VwTBMntRXRwIEWa+EBUkgY6cvI7lQXlkAFi1B3kiKxQGNJ3e+B im58rZ6iFsCv4/LfBj3OaM0wGtPCqrVuvbdOjUUbfaYTee5QI4VID/iVu2DNkfMLOlgb 9F6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251695; x=1790856495; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kr63+K8VrovD5vtNEhfp/foiZPBihM8XyyQx+wo7buw=; b=D9MJEaUR+xMmQovdbZdggyEi/9uSjlxqynY6o8CGgnnEZweb6sLEqxBah/mlDuK9jL tcplykaF8uitp1+v1yRcueBRXH22WTLp6bunZheyj/7010oYVzumhOr2b91/tcTamMoK G4BurE+WGVv/khY9dVw9PXgtxDhCAy0G0K8oXT20U197fEyMVYG3aJ279VEpHe6al0pe wQAod2/Aox7zx4WupSTnUyR8189vfyvQ9K30cE/g2Iy9qOGXF5kMsF7KUksp0l3BTxyA H6+xhpCupEaLieathHOpLrZwL+lgMVhPgPZqjzy65mwCO2etBWOWtG1pEpq29Mpv5XMv jgBQ== X-Forwarded-Encrypted: i=1; AKwUvBwoqvnzIeh6+1srY4Hct+qR7m1EN5rg0uQJS8SrcP4dpizrV2yCApxbcow+IAykh7oDj3N30tUBkpHydYw=@vger.kernel.org X-Gm-Message-State: AFuF++nMSrU5XrGqW/KS3u5c6+8J0NhEyN5eeedwpvJrc7t98VzaH3e0 Wjka7UvWsfijIaM7TKOyxH2aIlpJ4qwZ2Rr0gO0y+2YXbyghkAIWqnNuODAQEsdc+L0J84heNkZ +QUmIOWTPJAoo1N3sIwIcujmECAJldubaGJuEAbwBzj3CY7ve45w33MJJVz/YmlACiEs= X-Gm-Gg: AYBFou1TpltXykllbs7ZzTw/QbmV7cFSyfVdIdGfJ0MicU55NoK+T3AHYVk/wxwvKpT mZdFEpOhnYexEeDgRKpFpPqXiw+CpLaaRPHr71XlaemL9jY/UYFBvpSghlC+vEXYbMGLxk3Rz8h yQXtGPabW4XaBUq7ihu5dmvi7GgxYOynoTHag/XVqw50FWB/vjfJ+mykwlV/hIt0GC4f8CPXIdb oENu3Wrs70FVM8bxtYYHW5OFjWxKjk/HWKc0itM3CP0YXCN2kZtSkTKXYgWtT0IHiPivGcOuBDU u1eGkojSGg50exPH/RE1q1PGxLCNZtobym/dXRj8GVibd4zw+4eWzvjjTvP8NLcJh3e/zbcf2mr YdzTQS8A8 X-Received: by 2002:a05:6102:3ec5:b0:7a7:198a:c2bd with SMTP id ada2fe7eead31-7af1e2f54d4mr1225043137.37.1790251695185; Thu, 24 Sep 2026 05:08:15 -0700 (PDT) X-Received: by 2002:a05:6102:3ec5:b0:7a7:198a:c2bd with SMTP id ada2fe7eead31-7af1e2f54d4mr1225022137.37.1790251694593; Thu, 24 Sep 2026 05:08:14 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:13 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:32 +0300 Subject: [PATCH v2 20/48] clk: qcom: gcc-sc7180: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-20-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3531; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=GOaZqDXf/TeKArbS7Ev2JBNtwRB7b/J0lUfFhyNF3Ec=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJUUdyjGnFQpfA6iZ43+BEF8rmPE5h4MvWxL mkn834xcKiJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSVAAKCRAbX0TJAJUV VoQlEAC1sCM5lZCA1uVHwvl5eKGgbjWzRcu4ggcowtDS8UZyOlLimEPEYxFqwA9q+Ny47xnCC09 OZq8ZRXxRkA6Mad6outUjJX5mcr3LXrSiSJEy6zQRzjGi/2nSn2v3SZLJRwatKkeKzY5j360YxE MVOZrtDCKaPgVRmGf78UQuLUIBKFTv5W7snqxsPHXc9+OgUfVIM2WWBLVTw+RE3EwN+LF984t4x Rc2bwWubL0Apt1TMaSItNh5suQJDRQF5VChK0Ozx6A+4JRSBx/zIj3UMKsfYM1NZufs1TXeLrhM Wy8o2lKd2wiMYMIO/xyIi6Jss6/TbEeWLeU11HWfV3j3aBJkjQG7JfuePfX5hv54NjCeocSxgFG h3QGjH4Q/1Vri+6/203lkeSWsd6GUlme0+Yl731f4LSGcB1V3BJ7X3vb8xzRRRZqt7uDX49Gmwq xti18SKgpirZCpwIVRTyg+rwAQLErhDsfsKiN+NbYl9k7k6lpPyLsfKZS/1HmcW7kWP3uB/ELuC AR/Ekt0lrfoaOUsR9Bj8A2EGmK6Msnf0j9hLM3TOq4vV1+kklNlVp4b3OYpj2Kvp3d9bTvAmCWA Bt2DXHkoNHq4QeMuyStijgJGqrAJa6/o7bgOts9gedFKLF37+nx6hRXYdTPtJ45gxszm5oMiggl xlBWHpkc906/53w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/BS/oNx5NS18 ypyZK0YzWu+FhNmKHBi3wAovtOe5oXU4Z+n4cz4SvNNQhUlFdfv6cmffrxCNN2oWAzdiXafjBtm Y+lgIBxaNcfZaEgzyrdy87y9sWWWk3bmwQq3b3M2N3Kx/p6l1YOFViFBkARl1WpwWt6RS/ip1Ea FTTkPnCqttHxWq9kRHnmeDb5BfczrfWu7oShmV3G5xRdGPOv27qDQnBwXB0f5LKrUocySViX+r6 XhK/BnXwnK/jp5fKiAJpBNHiVBAh3eb23b+J6VgnQDV5mD3wigP07efJT3+J1rzLsbmKCTQghpZ ExHxcjdXef5KHBFrV1+Ge9lyfu74rzq5/ibtAgx2OoflW8j/Yse+/FWO8qIS1OpMMd8tDsTQVUD CkClk1kahmL9/OZdxQk7E9KTzjRtv8668Cwpkxtxvt3GLMlE87+TkDV34WjYvkEx/a+EvIjTick 2KKYjDJFOaDzjB8chZw== X-Authority-Analysis: v=2.4 cv=TYwDJhQh c=1 sm=1 tr=0 ts=6ab512af cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX91E0BVRgWPNh YSvem6AAzx4F21cHiDB0ilsFu6mCVJP2zB5aSSXg/vqbGoLp2czNLe2bo8yE2MCeO4rXIBB4MmA XiJ/+fIyFDlqQ3nFhlY4+x6wtHMCkMk= X-Proofpoint-GUID: 7XgOqgtbXt_Tf1nJYb9OoIJinyEpAq0y X-Proofpoint-ORIG-GUID: 7XgOqgtbXt_Tf1nJYb9OoIJinyEpAq0y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sc7180.c | 60 +++++++++++++++++++++------------------= ---- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c index 4a49ad7a9e5b..6d9ee31044a5 100644 --- a/drivers/clk/qcom/gcc-sc7180.c +++ b/drivers/clk/qcom/gcc-sc7180.c @@ -2408,7 +2408,35 @@ static const struct regmap_config gcc_sc7180_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sc7180_critical_cbcrs[] =3D { + 0x48004, /* GCC_CPUSS_GNOC_CLK */ + 0x0b004, /* GCC_VIDEO_AHB_CLK */ + 0x0b008, /* GCC_CAMERA_AHB_CLK */ + 0x0b00c, /* GCC_DISP_AHB_CLK */ + 0x0b02c, /* GCC_CAMERA_XO_CLK */ + 0x0b028, /* GCC_VIDEO_XO_CLK */ + 0x0b030, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sc7180_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Disable the GPLL0 active input to MM blocks, NPU and GPU via MISC regi= sters. */ + regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); + regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); + regmap_update_bits(regmap, 0x71028, 0x3, 0x3); +} + +static const struct qcom_cc_driver_data gcc_sc7180_driver_data =3D { + .clk_cbcrs =3D gcc_sc7180_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sc7180_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sc7180_regs_configure, +}; + static const struct qcom_cc_desc gcc_sc7180_desc =3D { + .driver_data =3D &gcc_sc7180_driver_data, .config =3D &gcc_sc7180_regmap_config, .clk_hws =3D gcc_sc7180_hws, .num_clk_hws =3D ARRAY_SIZE(gcc_sc7180_hws), @@ -2428,37 +2456,7 @@ MODULE_DEVICE_TABLE(of, gcc_sc7180_match_table); =20 static int gcc_sc7180_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sc7180_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* - * Disable the GPLL0 active input to MM blocks, NPU - * and GPU via MISC registers. - */ - regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); - regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); - regmap_update_bits(regmap, 0x71028, 0x3, 0x3); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x48004); /* GCC_CPUSS_GNOC_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b02c); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b030); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sc7180_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sc7180_desc); } =20 static struct platform_driver gcc_sc7180_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD7548B383 for ; Thu, 24 Sep 2026 12:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251701; cv=none; b=KnLKGnbEQ6Wr/Yvr4cI0p3L5ZcJt5QaDW6ZZLUnS7uiIZH9Kw3DkChjxHamxriOpwS5WhyM50VE0NcwyTHEuUr5zdCuld8D+EoHu79FP/evoRE+1ecGSJY2DxcaJunFpg5MegtGB2cslWNfuhXBv51bOJvKjzewuEy9txsJIjso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251701; c=relaxed/simple; bh=TkNe6dbYFbBpRN0mUJBWTHpBKSQ2PJFZBXam3qDlU5E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iqrp4kFZyPgBZaiulzCQxXcYpyksK9J0+5HC+SAqliiIj15PrU4Ik74vgu8RWL1ddWyXIb9GiZaZLyAiKXIUmQAZ966JdE2etaildVQSuauAMuHqWyzp6tCtoNKmWxnI14jgCQeUN0YEHHEPJ42Tg3tkTkAvCql191PCDJ14I2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IEZI4A77; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OIKW0X0q; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IEZI4A77"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OIKW0X0q" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4ji72285740 for ; Thu, 24 Sep 2026 12:08:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qwzjn6cElmXfCp14l4ddV9QtlIXhn8pGPhPbkAHvkrM=; b=IEZI4A777l9WSP2B uiBF2/tPntucT7G1kzUn8snW5CfZILSGaGetgD72gpLlxVijbcLvCMayG7NBvrMi 5t1tvC7AT2oCzGEEObYQiIdGpbVYEnmm7XiihBRWgoHKifzx4d89NruK+5ASTB3r qzSkpAan8+LicfyLDtAUyMw/4yjs7zSybhzpdXFpLuMS08IltidQeXoFu5v6ZzsS ec7ABhocalBGRC4J/c3ZPhYfZcAnxwtVkWENPXaKvqpgGwtDPBEadWQ2bfCO4BDe zfoQvmsLbRLLypCIV2VT18XynKGHgGcJwrMI3FTLy8u6AiF1Cvviqnm4HvgHHPVv +7Hdcg== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvx8ahgqr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:19 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-97e768af628so1578429241.3 for ; Thu, 24 Sep 2026 05:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251698; x=1790856498; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qwzjn6cElmXfCp14l4ddV9QtlIXhn8pGPhPbkAHvkrM=; b=OIKW0X0qBhfzEf9D44ja5gCD+sW/QRdPADd5fB3qaOOPNR9+9c9toU1QKgzAmTnCUk RSifOChCsxC+VF8XgVULuqOBprkqf/WUEduF0mq+92HC7O7HgZ0+Ympe21M921XLoxuC 9aBkInNIG0VnieUEz8j8rBaTbZDL+o7MzQvEjOtbEtZEWA2Op9oCYuf2AMd+5txKhtwV qSppPdFWiBnlk9EbeYQWtRzFMI2FEriEgILrm8UUXHOHVKHLuUbZPOlygK2/waN+yWAH STXzWI7ZQs76lg15qRY67rEduWFQnvisDMV3ms7YjPOwaU7eVygubcBkPWdFxtHDe/qp PqsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251698; x=1790856498; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qwzjn6cElmXfCp14l4ddV9QtlIXhn8pGPhPbkAHvkrM=; b=wBbRJho+az/2eEDr3BIJlfhO98zknf9hL3uagB8+xSvtk1MfGfPvCjwfPxfJcfqp2f 2jISeqxQ2+Syv74B9RahTBRwTL7swtcpKebt6ePJyUvZPpUh4vc/cJUTJs53RxCDG93b L4c1za/o7hdTW0R6bNdngTUSjTHbttWg8zyA0+r4RF2iL20UpMPSdMUlyE+aSJKvlahy ubib0ld5y7FdVgJz3wIb36tgm9YeuruT4dEAGn47qaGfuTYhR+06LPbVeJCjIEmRK5jj aZ+MKVv0SO7Wmy+6cHZYlZz3P7NafcqS+TPPiEm7YwffVCVY3AJ0IJKxo6aqn3i++mVI P9vA== X-Forwarded-Encrypted: i=1; AKwUvBw8uEVDvGXCwe30ZpU1H0GU07HjHm6CjkhL3idUCOu+PL7mkClgZcov/xTFUYX1566zIwA54wUbGd7X3/Y=@vger.kernel.org X-Gm-Message-State: AFuF++kBzgt9bI06s25jndIase4rmgmvL+tACALzK4tX/PpFE8sG04B1 EwkA6bskjZt0qoJU+VTG2P6Y6sX0cWyiVlHw6BOfSK8L/v7LNRHN+aJDZbdhdHODuFo5AdA1rLb SNGJ6orKE+OAWT245e/tV3eLsOKU/CygDQKoGhIrvLBgqjUbc12XgPbSkBvR7Phyhl1A= X-Gm-Gg: AYBFou1ubbKXn5cl7wxmFQ5gfV2Kc3S3dNQ9q/YEUwsjJLqAUk6nFabz+QcnAWN8/xP Pr22uqfytljTsTzvLTxyKzBu9KEfy4xPhPUKi40iwKIrDI6bqiY5bv9AKjdAXgeemn5ARD/nN4a J2spvOSlwbr2rEJcdyzzSV+HwRRu4En0gJYv8kuaIwMiVC7xjMzuNrDOA7aMig6QwENJ1NX6a8H m6+wq5jaWmOLvPFiYA2e5YvpA40V7y1FlAFRXGzG/pxPfIiNPm7/jUOIEwMUtFZSrU4og7zE43X 4oOhoK0yrtaBrZvyPHHdRQmC/cc3yilGnPbK/lxb9yu/2uKz22LkreQjwhFK6wDzWHYShuwBRqv ZrZZEui+c X-Received: by 2002:a05:6102:4b0f:b0:79f:3bbd:aa3f with SMTP id ada2fe7eead31-7af1b96bb76mr1266037137.6.1790251698042; Thu, 24 Sep 2026 05:08:18 -0700 (PDT) X-Received: by 2002:a05:6102:4b0f:b0:79f:3bbd:aa3f with SMTP id ada2fe7eead31-7af1b96bb76mr1266017137.6.1790251697450; Thu, 24 Sep 2026 05:08:17 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:16 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:33 +0300 Subject: [PATCH v2 21/48] clk: qcom: gcc-sc7280: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-21-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3307; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=TkNe6dbYFbBpRN0mUJBWTHpBKSQ2PJFZBXam3qDlU5E=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJVGg4b1AyPYI4Q0ARlYl6HjJCWkBpNfEeaP Yfv95GjXbyJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSVQAKCRAbX0TJAJUV Voc/D/46mdtTzQZr+VHlY8rxF8Nudtsi1Fgz1zAy7xk8jTA/TOc6UPqyn4gaoYXmAuvEk2uVUcw JZQid7Gu1VzzxCPTF5Rx50/4r4CGytcjU3Lo5qqjMjY0sNmGjmL9BvSBq5PadHqgo8hVxh6J00A o2SXKVvh95GDmPknILHJN8RNZ2nuoHeB3c6vZpcA4kxALz3dLHrfH5ASHOIdmCZCJ380IpaAXte sn3iUdRgqkrs3juLDWMNfJMXjxUaCuaRcHNVLko4a0pak8H+wIGrF/xG55ZUXN0MviGXuPwHuSW JIvx4HfvRzIMejH9jvheJndn5SzfEWDp1ajp6f6xe+uEef+8COxnNuAqkHK968zUHy8pHoOFxsf vpVlHPW7R6l0Ad3s+VQ3IGNKtyk1J4SzqwFazHDzpqOKUeyVArXKgon80YM1f9Nyi9ZSuRDBF3t WXPc/CHkbhSm4oBZAyXk4rmhVuVCQFkC3lIArYm12B2g5hdQm+cyJjQP9o9yrrLlAHtxZlxsJEQ Lt3s6VHkEYpSA2aCcQWi0coo/oxfxrXSQsfP7LMdyAu0P2b3XuVvDlrajQbGFdQKYl51yc2s2xr pcmhaGLwNza+/PPW/g/3/PvqMdQiNmrFeH6YMxv/wMn1GWaZRaRKUDaTfhGclo17QUi2mtKtEMp nOfD40s4q6dmyuw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXwq3VISpeRqI5 kVyP/sNQRH+8XEhbp8hh5BfPNxgd5V6yieHvNsRE+kISlS+lUhDHankhgC+DXe1MVwUfzKA/9zP 9ZgWYo1W/RRDatj7i+OQzoa6wknYQuU= X-Proofpoint-ORIG-GUID: tI7HXnd3mVg0F20ys53MrdKa8F2gzqPz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX6mTPleMJbRpd yYGEzYG4ufw1J6ob6TkeW4XC1h5gilSJMiQUq7x5rUKOLBFEa0aOM3TcWpGZ0qzJuycS5u/gLYV kQTTYjuM5mDk3/2zmePpU8iMlcBfFYPur/gJlgB7LA8jkDtl+OKhCOFbdk/Q/v2atxZ7U83MbOH 75ruYIp3Sx5hN0DO6WX4IVxQEvC8vW3nXYRLMg93CQFJl4peT4ZCR4mNncF0oa+t4tsfXMwwdoh MG+zuhJTLqvrkSM7z8lgapiya6AO9F1AaGPTJlf2eaV3RC+4IzQeKESwGgU/mD6JwhprMG7osJi 0mUVn+qx8j12o2j9fduxmN24ZNpxmntDGG4JFTCzJnfG9p+t7UX2OxIun/O2E+Z1kxJJONxzHds FYDylnbRyM2MWvx3hzd/T+57PHbq1RhVBdHW7uBgces4mHPuN1vT2QCA0Mnv8rYSN4Rs1pGoaTD T2hCa5yFO1UNe8RyB6A== X-Authority-Analysis: v=2.4 cv=a6SlZkSF c=1 sm=1 tr=0 ts=6ab512b3 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-GUID: tI7HXnd3mVg0F20ys53MrdKa8F2gzqPz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sc7280.c | 54 ++++++++++++++++++++++-----------------= ---- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c index e1fe64463de6..1c9f8d8b99d4 100644 --- a/drivers/clk/qcom/gcc-sc7280.c +++ b/drivers/clk/qcom/gcc-sc7280.c @@ -3438,7 +3438,34 @@ static const struct regmap_config gcc_sc7280_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sc7280_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x2701c, /* GCC_DISP_XO_CLK */ + 0x28004, /* GCC_VIDEO_AHB_CLK */ + 0x28014, /* GCC_VIDEO_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sc7280_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + regmap_update_bits(regmap, 0x7100C, BIT(13), BIT(13)); + + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); +} + +static const struct qcom_cc_driver_data gcc_sc7280_driver_data =3D { + .clk_cbcrs =3D gcc_sc7280_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sc7280_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sc7280_regs_configure, +}; + static const struct qcom_cc_desc gcc_sc7280_desc =3D { + .driver_data =3D &gcc_sc7280_driver_data, .config =3D &gcc_sc7280_regmap_config, .clks =3D gcc_sc7280_clocks, .num_clks =3D ARRAY_SIZE(gcc_sc7280_clocks), @@ -3456,32 +3483,7 @@ MODULE_DEVICE_TABLE(of, gcc_sc7280_match_table); =20 static int gcc_sc7280_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sc7280_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004);/* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028);/* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004);/* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x2701c);/* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x28004);/* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28014);/* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004);/* GCC_GPU_CFG_AHB_CLK */ - regmap_update_bits(regmap, 0x7100C, BIT(13), BIT(13)); - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sc7280_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sc7280_desc); } =20 static struct platform_driver gcc_sc7280_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DF9048C8C7 for ; Thu, 24 Sep 2026 12:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251704; cv=none; b=Su3qs4gBdnbNUI/5o8YLIVnFZ2cPf6jgv505Ob6gNhLAQ7KHFuN/Uy9ibPsHr93Rk/S+trAVv79i9EGDPNMYIhkMilIFu3PtGB9QsfTYG6H+s+lKF9Mz7swqCg1vNHntXRa3j5OQWPzEjeUOyBk1ZFTwSQOsoDWOqmwRn01qpu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251704; c=relaxed/simple; bh=gZuwQv57oVG4zm82RhDWq/IE6v1+U8lJ/nOT3ANiXpo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pzYl7zteRgaz8Qd/IK8YGucFb72oIhEdSkqcWCcE5LTSBHcW7zIFNQyzMjONLoVVcm4djFT4b4j1uA5JBbw7MDwtB8vlsCllzeeZ/aSE3JbOgdmJ0kHI24KuWBnQOLYt0hgl+VqazwCd+95IiEYZzgnh/1U4/5Q9iXHxoWKgHn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T61Ui7DC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WFSAlsfl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T61Ui7DC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WFSAlsfl" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC57hp1631198 for ; Thu, 24 Sep 2026 12:08:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UaftVDjcgY5nBrJKvWUch/I8XKYUUaVNJfD6awIqQEw=; b=T61Ui7DCGtToa8/Q D7Zqqpu9FNqGgQ/PbM2338pxzO4w9DRHGnJ0AOvKlI6mir1chVjdPU5L0L6dm5Kz ViCAR4MM8iOMw8tqmxjG4FJnlNhkWM3K9swCDMAyoDmV7x47dqOfXrAZkTIzXF7V l70oy34C47JkCce4FJs0ZpWk9yMiws63wg+cT4aGbyw9fiDz3z61hsew2fMENNOO SrwTwXmOS8e6zWfDIMTMAr9lTyhVj3l6qezFOsgVup3dSAPbg2Oq9TafZu3yCiJ+ vy9YwXtFoWKyhWI+NPpkWmwyDP4sDRms8fstt3r6/H7yTRGobdp5GBHZsAOThiH3 BnRQHQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90axdy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:22 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-78830f4bebaso533936137.0 for ; Thu, 24 Sep 2026 05:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251701; x=1790856501; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UaftVDjcgY5nBrJKvWUch/I8XKYUUaVNJfD6awIqQEw=; b=WFSAlsfl5pZIYNwhpJAYJ4jWxz48CJPngbsXojDtw9NfaM3vQYbnbjm90Z7B2MuoJ2 IujDYpAKJMAYE60V6ZPYL02oLwC8DGZTooMpE6jj9o1u3QpejKtjvTUrFpbXwdtcFhex r+n6ayByYw90CUM444dBRc/roFsRF6NH2t7aNLGWbHa+k9P9QLYxFYD+/EZWB7XlwgBQ Bvj8fvvvztCDOhyg+5TcF91jIYnYvnGZe54fyg512Xcv6fufk1sWGY4LSGGBPs3AjZT6 QGfuCxNZDzfzdk+61PhxLuKKI9NUP5vM7kklwzz1mr+UTZS9CZ9JiH1EONj7MsYZBzUU qqnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251701; x=1790856501; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UaftVDjcgY5nBrJKvWUch/I8XKYUUaVNJfD6awIqQEw=; b=KH9f+seuiSZinYup1fWu7s9UywZLHe4u8k1OA3NL/2y52t4R5hgZzYrUPtY/X4osQ5 0/DG+zXoh8uvmhsb1C9ilI5MQVeO3iNYreFqyOAo9VepH5B7yBa2mU4SwPqe3r4L0blY Rxk/e/e2xQNBMYoQTW3ZwWO5p64b9iIBW5AEmuMzr5EsmGwkr4C91fDwjvpjvm6zbQHF pXFn1voDEKn41xj5/9yvoR3DoaKnovHY1ptVo8/z0UBoZPKU8zcUqPqn752Ce0v2jmn8 aoHPtOmGTdjJtCenHn48NYOmOoj/IUxTd2ykyjv53OZ8J+8F5OZrXRvlIyesZJ1x0Hwj /gmg== X-Forwarded-Encrypted: i=1; AKwUvBxkfRQX/uvYD3NdAGIPg6jQO3MT7vUQX6NsasI4g6WqV3GpqJ1DvRwQLM5lT9o+yaDuGjSfhBHjC+yWHvI=@vger.kernel.org X-Gm-Message-State: AFuF++lDD5IB1cv4Lgw2SpZeJeytAIMcUKXwyT/pVAQm3j6EQ1Smu0Ef 8a/2o8lDdlp51vZOSvqN9RUs3eCg4m5/dXS7QFUajMbPkgQlvoB+O+p+LizzkMzAVdh27I52u0c hc+l5ar17F3+HnanDX0ZxoIT3USpvQdNdd0fPHT+T6+wPQE3LNKnjFovGi6LMBuXteBE= X-Gm-Gg: AYBFou21GRZaP949g4q6QQmim6cMhJt+1Up+bxHx7fDuJ4WpJDmH59zjY3mf4qHk+dn ZPiVv82YImDDiz1b3k4H/J+UTFpCDxT7WEEklVqizLqKFmxX9I3GWjBSFcUvxCmBH0p0/cPEEAX dKYrDTm4+e2Y/EIj9aUiwdr0l6Um2uDR+sUhlN/4HiMv2lEgbZeraX6vB4KBd9u3t1GpF0wQBUR lAkFjcVCBwP0EoZF7+EDZYaxoaYnvNGMfvAi0wy460z5u3E4sD/VWBaL6oo69syLv/yIAVYszNU dywdTNCDLNIA5jrxcgydbrSnjYZinTcokbPBith+T3X49s3dCXsQSv5qQDcLNzT7bemZdWgvubN cRL6BjBuk X-Received: by 2002:a05:6102:3306:b0:79f:5d5e:11cf with SMTP id ada2fe7eead31-7af1d09c695mr921546137.11.1790251701174; Thu, 24 Sep 2026 05:08:21 -0700 (PDT) X-Received: by 2002:a05:6102:3306:b0:79f:5d5e:11cf with SMTP id ada2fe7eead31-7af1d09c695mr921536137.11.1790251700560; Thu, 24 Sep 2026 05:08:20 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:18 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:34 +0300 Subject: [PATCH v2 22/48] clk: qcom: gcc-sc8280xp: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-22-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2734; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=gZuwQv57oVG4zm82RhDWq/IE6v1+U8lJ/nOT3ANiXpo=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJWJy0eZWFtGWisVX1jRj4cPhIxGNh0OuWVD nsTE24zCHWJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSVgAKCRAbX0TJAJUV VttrD/4zYIDMFCF0BfQkeWY8DHLPgQhziRpkMHo6ozXlYv99tI827oKChVjRIE2n4qLMgIh++iW OO2ebqK9TPglo9MuDZWjI/Mi7rltMtX8RTV7NFd1t466L1d2L6lNvk9SjA+z6Zv0nWfSEGRRHMD gaKv25AG38La97CG57Rp0DHTGfXciJKlu1NjK/+yX0l41+Iyw5db+tR0+PVEbhiHWCy43iQ5Nwq ligC4OqnXXXTVrV/I9eATWIF8l80i2bM4EePpd+o//i9X2VymUhPU4Aau51yvu24Sid3xmBpxHf u7sA6ek4nPN/7SkYWJnSluxdW5VxjbRrtSRLf7yrirIA7EFtUwqRkIf4dwspW8VmSikb3j9KEGj 5yomZO6oE5KEXxl+lunHaAUe0XDc7lg6LLAnZYML0MssbNAviydsp3Smom2SIO4Bbhtu7+1szWN 9blHTJ8N7DXSBUe88Trob2mtWYlyVoQiF8Prl5cY+/MOrSy1i1dLELFHxKHXSPnZKyzFBTdl4sH r1AzXUjGPLSXqGBzygWFMNEnuqMsNVy5BxQVgLyjPnJL92Rpqs4RHt1NozncTlh+F8YFA6VxAYx wO6DuQtAnAquNVgPnoOzvgsliskQbYJDfIO7D+shCwIti68x+c2NPlP8r0nGxcUJ4VxVqtX7CIm H/oA5NW1raAbfEQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX5W6jZiCIbpwD P42xZRM1tInRmZqWLXvigIl0FRI9mCZk44vZzpk9nJ+r5e8ZVZFH2JYve2fqgm4VqIdzC0ftBSP Df7Psi8Pj5xOqllhcZoHJg56N/JBZj4= X-Proofpoint-GUID: yA3w1bFOtFg_M9blM1eLYId5St4rANuX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX4eE3ciNLY27s fcBBPkKMGUqX/U5QpxKLvLo6eiDPCD3ihCATBCFfmwGTBZ19EPrWhRoXD6MXPGFZSmypcSU5Or9 kLH2oiDyTdDSEJ9j6idIBCU1aqmHLGLFOaFvwK3jcGCyiZtYHb5Tyg4Iz/+YZ1si5e55Fv4C43Z lM4ljFZEDWke/H051oq4DhT2DwoxKfWugbuLp/5L3nUvpDZZNJs9pUIsGGyB1J4h1sWBn0cgWRv qWF6KtbkyvN3VuMzCYX3xAxHBXo6ZJY632+LXBvfd9Qlrbp3gzmSs6OHNVdoIjUzd4Nnl1J83Dw 5WudRwXNdO1T4gt1tHjaMqnJrqmDdhF9fV/XOvVaWXHBQYx0fH1PXi3Y48MhrExiPiFxqd5iHj4 ZSt4r4pVxQV9i6W5WK9//4RtULBRdsjrQdCeWh7dLA6+/BKpppeJFofY+KlNtLpyc/1R7/pgxhj +dF43Wv2hKLdfxqq+1Q== X-Proofpoint-ORIG-GUID: yA3w1bFOtFg_M9blM1eLYId5St4rANuX X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab512b6 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=jsp9moliOvjHjNtoyGEA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Delegate always-on branch and DFS initialization to the common probe path while retaining the device-specific setup in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sc8280xp.c | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280x= p.c index 81533e71e7ef..918c70648d57 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -7509,7 +7509,27 @@ static const struct regmap_config gcc_sc8280xp_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sc8280xp_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26020, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27028, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x28004, /* GCC_VIDEO_AHB_CLK */ + 0x28028, /* GCC_VIDEO_XO_CLK */ + 0xbb004, /* GCC_DISP1_AHB_CLK */ + 0xbb028, /* GCC_DISP1_XO_CLK */ +}; + +static const struct qcom_cc_driver_data gcc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D gcc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sc8280xp_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), +}; + static const struct qcom_cc_desc gcc_sc8280xp_desc =3D { + .driver_data =3D &gcc_sc8280xp_driver_data, .config =3D &gcc_sc8280xp_regmap_config, .clks =3D gcc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(gcc_sc8280xp_clocks), @@ -7538,21 +7558,6 @@ static int gcc_sc8280xp_probe(struct platform_device= *pdev) goto err_put_rpm; } =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27028); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xbb004); /* GCC_DISP1_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xbb028); /* GCC_DISP1_XO_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_d= fs_clocks)); - if (ret) - goto err_put_rpm; - ret =3D qcom_cc_really_probe(&pdev->dev, &gcc_sc8280xp_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACE248CD7B for ; Thu, 24 Sep 2026 12:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251706; cv=none; b=a/csPBxaULSKUa1yeFB8cPB8b9ZBn2+QSfkoTrSjssE8EpjjruDdcuxOSDXS3mIC6PGkLMlrhE7Dz0J0Dkw3OYrl7QfQrEQ+S77EU0HA1OkG1TzviLvG2JaTmJK/UZujVKXC+H2mXjwjBG4HRbnRDc4FTY2iLQ/eQ2ShvVN4H9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251706; c=relaxed/simple; bh=pMEAhmjQ8SoU5+CjnX88Vune5TxLlw3Sq9qAxDVyltM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QbdfnPxCAeHEEgG9NZMW7+St7x8G5NhtrPpbpCqHrH2jdz6X0Z/g3aPhFZusTJXNNqw4EAyPCVGJ9Ol9f3qOWdOQEHfDaafOn0jruURCW3pjODYqnQbrseYRRZNriINtGRinnJQDqYjp7DhEWar8yVVjltOOgsboRXCXbp5wl6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P6tpfxaV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SNWOs/VC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P6tpfxaV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SNWOs/VC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4ukS803936 for ; Thu, 24 Sep 2026 12:08:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HrRr+mDCkAGXrueKNpJnB0kvZSeCwJItxGhTTWWe0F8=; b=P6tpfxaVvhyxrmCE /aDu4wAQglwygP/+IiVul2CFdMvEK4MmcCzBigtN9rTSIH48qkg8LTJ72NLN30Bz 3ZRTXlmQaQht62v3zHxIjagzdDTQYkPYDOUTCW3YvTueAUe4rCF6AKjtVZ7swbhu fMye0mV8VCMHrzvdoru2r5tVqTUz6JU4jf+aIgQHN1/BBkIEkQmzgrn9+5j0pmxk 5ch0u8Rq60D4RFSfWbgPm2Pv76HXqXN8b28Ba6kGg8W661YavIeW2W1bNzkWDBk1 fMn+gsk7d9EquL2+ze55V6sAf2DqehtbHfoGf/lbbdhgUHwG21p4IPrly9pT0QCD poKz3w== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8f57-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:24 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-785827e6073so554028137.1 for ; Thu, 24 Sep 2026 05:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251703; x=1790856503; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HrRr+mDCkAGXrueKNpJnB0kvZSeCwJItxGhTTWWe0F8=; b=SNWOs/VC66eNKxeWjAod4P6w1uHCyr7UlMvDXsAfv2GyvErg5vaHt1WyFFalPkyUXe n0r0/fgYJaNYNTnDUhekwku0xItw/LFmPTFVGiCXQVyVPpa7FpaW9V4i2/i/kRb7OHpP crVwpYIP1dBXZxsHTRxykMReVx9VW52OsKrojxNUEqRWHqTKjteW+mmAEbl/yj3PFg4B FI/sApZeTnncIW06V9FkDgjLpInMLXLa+03zmZ96P7tApoFyDVGf21fnJCgPKdyAaHqw H1abvhEm+nZVAsa4e2VVDFnSetlMaYWeZqNx0xgQ5wN0LQIE1eCpFNzU9CoezDdFNZWM Lm7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251703; x=1790856503; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HrRr+mDCkAGXrueKNpJnB0kvZSeCwJItxGhTTWWe0F8=; b=deVBZlsdOeqePzb49SrhDiV8MWhEYbXQ2blYYfvQf05ohQhTAIG+xXClgmscrn0Zcu cZ/fTJ4znI9Gqxn9YitOmmdXIfBqeuvEcwTB4MNb7gJ3KYKyMzcVLZYelLUzz3pomRCg sbS1KgW/2NfGmmcGlpJHzl7CJ5MiSTc4iuoKY+G/J259fVz6eoJuIm32Zy1x3NlaH5hu De2GiFD1D7etn09L+8yy4FIXHjidQXuXD49Qtiwpw2mlEMfHyPz2PLpH6JufmAznbLrv SLRU8uXo9K2IUS0yMB6xfX0lFjQKtc859DH92yLhv5mU5Cwi7ajEjlU1S2nRmEzHS9jQ zGQA== X-Forwarded-Encrypted: i=1; AKwUvByR+pf6dOFA7YMaG8JIVPk1Y1kW96kh+EIzSx/191F5kUjowifsyUmSQiJh3IK+IEfQWuQBxNthWWlIM+c=@vger.kernel.org X-Gm-Message-State: AFuF++mbnevQgwyxu5BycnuboVcFg/kERLoGBvo/FImqHRBfcX76S/Y2 lepLK6E6upWsIA+Lg/kYVyvbWwQiYCO2MexWO8/+ZmFu8cTvgNAj6aA34ArdV3qTh4pqOnZDHC5 zZ8ZY29BvEm87kOa29/JTwgVOzAiVfrEtBSx2SwAVfN/dtMzGnv34CY08znMzf7oZVko= X-Gm-Gg: AYBFou1aFryCYikn70QbIy9vbxDs1f64EAN+i0tnPSRR+xFTuxuGSV1En35VaYev/F0 UwUjBol7xVmmZWDr5feDMJ627GlMBZhC4SBQ+yRXNJPBc95lqc+grBe8mf490NQj7DIxbH7ezjQ /tnR/CoqLj8IuTLoj4YLDh7zhjckp1VEnFpBv0J7Xu+USaB1a9oFrquyeiZLx56YX/kVWFaKkKk i4doHtF5xuWKutwS9jPQmtEZ8wJWBH9qKRrUYa+G4q0BWwCEpPTBIkeSzlKlTL6qLZ+7DQi4bvQ mSkVWhKIq0RJMUBIknG4UhPrM0huyURo8yRhfISocIhPjSxJg44DE2L/Z5BofS/IyYzAddZRCOh ZXdp2HfnK X-Received: by 2002:a05:6102:5707:b0:7a4:85a8:fbc5 with SMTP id ada2fe7eead31-7af1d1bb461mr1067210137.16.1790251703371; Thu, 24 Sep 2026 05:08:23 -0700 (PDT) X-Received: by 2002:a05:6102:5707:b0:7a4:85a8:fbc5 with SMTP id ada2fe7eead31-7af1d1bb461mr1067197137.16.1790251702747; Thu, 24 Sep 2026 05:08:22 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:21 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:35 +0300 Subject: [PATCH v2 23/48] clk: qcom: gcc-sdx55: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-23-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2392; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=pMEAhmjQ8SoU5+CjnX88Vune5TxLlw3Sq9qAxDVyltM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJX9KDo56OXYKsoACbcEGEJgfuiq4uumpAga JbdJ9u4RI2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSVwAKCRAbX0TJAJUV Vo9ZD/9biE3OVF4NZysl1yMmWTeNjHPSIe+Yoi4s7XaDxS3+FR1UFas/DV3tC0CW++tCneoy1BG UwbLrDocTnXRJJjZS/Vds2E0K4mu/JiWSm02gyiIqJHJs+plcua+KFuUPT3mnqgDifS3BmsfppP 81waVbGOJEFdSuD8WHgjAvJugKmhp6wEHI0S1X56CVzd+r2dBoeR6hsdLoSXyxnIGI0LTEuKZzc u4MWBeyr6p0V3JaASQoJgdpjSRoJxZ+Zm6g/zOwcO3kKbYEz2ZY1R4NJpOACR+KSOCVrGOg76p+ /X2bRa3hDdD/vcAgvpwFbW4JrHZvlzWjVI4zQRkiNItoH2peUYOgDWbFTDNIhxVhS2y/ma9vhOD IcEn9xbHN7LwI1nZ+t0L/vHrsXu/a65yWp91rieYcO0eBqmDJVmHQMTu20SPJSpS634qHnia2Va EGgm3dy/TwMzkZ/NI3TFTMG26qEjxJURMRJlBdNOMEAYYkiE4X9Ug5m8qM/uT4CmPeoILOvt4mP J5l3J0V7fcTm5pawdzHyEChLSYT0/FM6rbJXwxYh6OeHPKLoBFXxYHX6k1BSuqj/5FiQTMEvod1 yLUhXjy8yjIMaD4z9ehGGYtQCuUebJuNgpMT0iR3TMGEpjF8L4COTzIeJDXaAq8eqeEyUl/s7h8 Qp0PZ+7B1pAeljw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: QPWL2sTzkSnOSJCz64m0RVgrvWwI4QRf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX1GwAIKZDM3/q 8h9s9e4VXh1ECId855x8ZhrMr+RGjGoQ8+oNmunqCiq9N+zeZmIiLt+ekRBfBF0rU9ChTxNZpmW zkjdj1qC0EjVJcTwzEAYrbATtzM7k6SDTNeAMNJxBvfdfRe7W/Y1H9ITVJj8zjndRfw6nSp0C2s Ja15h7bAZu9cdpAuMxY5DC4b8yzYB6gN/hV8B3sH/qhOAC/SrsAt6IIR0ai5ouC0FHenUH9htVs wQkFVE/xe2YBtTfY5zB0hqNcAn2DQzSMFLuXkOMnRRF3trYW4Xhz/oO+3JPzEC2OiZlROvZXu4j VH6ov1+OPDvH/do+l95WnOf6XWmMUiEnarUpCIVbgWWI0FAWgDtbXPTXpSLXU+4Ey+t0lGLXBA5 yoaSBwhZDGuBHpZsDlPlk1qctW1tl3Mv0euVfT3X99C/RDwBrZHS6TzyqMF67hXXOufTRFyp9aW HVTsQhqb2EUIepWsInQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0nb/SmaGYlwf douC5VPkSh47WC7ipF/87YnHl9afANXJD19lVyMWLwKRNn8Q5FO9cqZwm64+pN8TiYW7hNYmNBX zbWbLAxhkq+8MOhwWnVD60MZV3etHBg= X-Proofpoint-ORIG-GUID: QPWL2sTzkSnOSJCz64m0RVgrvWwI4QRf X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512b8 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=8L-1-Gifo5kdOXCWqOUA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sdx55.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdx55.c b/drivers/clk/qcom/gcc-sdx55.c index 13d6c9e8183b..8d8547c12b19 100644 --- a/drivers/clk/qcom/gcc-sdx55.c +++ b/drivers/clk/qcom/gcc-sdx55.c @@ -1587,7 +1587,25 @@ static const struct regmap_config gcc_sdx55_regmap_c= onfig =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sdx55_critical_cbcrs[] =3D { + 0x6d008, /* GCC_SYS_NOC_CPUSS_AHB_CLK */ +}; + +static void gcc_sdx55_regs_configure(struct device *dev, struct regmap *re= gmap) +{ + /* Keep some clocks always-on */ + regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ + regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ +} + +static const struct qcom_cc_driver_data gcc_sdx55_driver_data =3D { + .clk_cbcrs =3D gcc_sdx55_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sdx55_critical_cbcrs), + .clk_regs_configure =3D gcc_sdx55_regs_configure, +}; + static const struct qcom_cc_desc gcc_sdx55_desc =3D { + .driver_data =3D &gcc_sdx55_driver_data, .config =3D &gcc_sdx55_regmap_config, .clks =3D gcc_sdx55_clocks, .num_clks =3D ARRAY_SIZE(gcc_sdx55_clocks), @@ -1605,18 +1623,7 @@ MODULE_DEVICE_TABLE(of, gcc_sdx55_match_table); =20 static int gcc_sdx55_probe(struct platform_device *pdev) { - struct regmap *regmap; - - regmap =3D qcom_cc_map(pdev, &gcc_sdx55_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x6d008); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ - regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ - regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sdx55_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sdx55_desc); } =20 static struct platform_driver gcc_sdx55_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AAEA48E0FF for ; Thu, 24 Sep 2026 12:08:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251708; cv=none; b=R0U1kOLZENXaxXWe6o9eI2I1KCtKZXYSI5Isz3hvwrhmc6Pkr97RnakqWnqo4WxGs335EQIgoThLZzYI0SaJECgj7wRO4fyXZ2uPCF46ztTIMANhwTmdH2EOp922MgGsRq9Lo2FFc8Q4nbWsz3aV5Ix6wFONO/+P8HpPSJ3y2cA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251708; c=relaxed/simple; bh=SUwK7+vvo8MXx+P0Y4VzWQKFb096limbIcKlkagiwbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UVc7uNwYhKN6PH3HChPXMwLD3Pcl8mLlGcuR/xChDb8/fyaKgpCbWkq8vVYp55zxofAQ37zoNgOX0/OGWJHQZ+czS5or6kOKVO4sHtYRMRN6GOy+qFG5RaQ0CtlSLjimmjRwhgfSHAwOOOTRYzrl2ua7BwfnYu6POoPd1A++ncM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TD8srMCp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xpkgo6/V; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TD8srMCp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xpkgo6/V" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4dob3134223 for ; Thu, 24 Sep 2026 12:08:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o50Vv5ozjRpwsqKEbhb317IFkWHZ+LfKlaV10R8xyQE=; b=TD8srMCpJN15v3Ru neaygED6F6WV2D0RNkXTmU0CRf/zGhNd/FB7gz7V+oc1ci7ZJPKGtWF3oDfIwMUl bwMr9x9whqZ0OFebCwF+4V2Y3BAjvwkKPKXBIqe3zW1LjaamH9Ws0fsYjIvW1xoy x+6n9oQu9E14eQKS8PfruCJgiAvgpe220HqlVpi6pS6QzYV8peZoBSo37Ijj2/Be MpQhuyoh4uzz98sRW8XC2nTgJkQKmUVA21iUcFM5sLOLbYedUZJJebIJPR8eD9/o XZftX6K8wBSRb0C5E1hTGCkQzEA3jrLK1oOLsYkAchapzwrWQ55D39jeF3JxS6C6 EzMTDA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1raggj5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:26 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-78a58df134aso566369137.2 for ; Thu, 24 Sep 2026 05:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251706; x=1790856506; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o50Vv5ozjRpwsqKEbhb317IFkWHZ+LfKlaV10R8xyQE=; b=Xpkgo6/VBY6xlKtOr8cvwoduTqV4UZXXmmeG1SSgLC0N4U48sfEsCgO32KAonusJwz 1hbjZDJQxl3oKGl4JZZeMfP7I+jcoquTibRcYmVbWoAhoPpltFz4JStfsMPpTVHcDfq4 plSc+rIwmqBfxwPTAspdIIwzrues51x/Od0IFuerCiYs3yBSH46xLBHjNRc6/aU+VHMz mhAzsxRmYc+8hY2NM6eh0D0mS5FI7ULRptK0kqaEvZ+vLI8hrSXm7ELuuSkqKZNtcszI yjGig2xKoQFhK2Zgwaz1sWUaWWauZPI3SpGFo+KGxHfJmfLgWi7tw6YWwwMgauepwHY2 bVNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251706; x=1790856506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o50Vv5ozjRpwsqKEbhb317IFkWHZ+LfKlaV10R8xyQE=; b=BCfljwNmjwHZxgB89GOMS9qcMm/DTldm+WOL2IEoiSXGlkUniVWxHg2g1+5wLsgp4y CFPQ31Zrxp9AQjXva7IrywOvQ+RaIJZXbAdY8RivV6NnmpWoRKz6Z1KEZDGLV2EsHzeM 9hO5UuzLS1xVuwk9xKVnKb+qJaDgiX7BMURfDUKd8eGmi9wKKgkz/JLtXmNS8hKuWI/K LfjHIU4Jz+ctCSJ3kP4DQwvN8olNjo2dwf3fG3R8Q6ThB18jNyWccxJ75h34FMiRjUnM qrVH7VYXTcK8bM8hYtwWAIjhsErCFXd0VR7PqhTDXqi90aQh+6fcNgogh6Zso1bHWUBU HVag== X-Forwarded-Encrypted: i=1; AKwUvBx5DEFoLUMQv5BYJfRgfu7vMgXCIVd3Zuxc4VLe03a7xGF+lyxnEabFImIhkyBYKCMKMYql1h3b7amaky0=@vger.kernel.org X-Gm-Message-State: AFuF++kZAX9HinTrvLte1+TfsKn4q9PWmhL5DfZFBmNy97rNOj9LxUa4 KA/geE60hY4k37bl6hr5/1XePkjlhLnC8ksJEMDjzvPNWLBkj20Tfsq5HnCx3OpKEqDLec6BKPM qJK49yoYfmVLNHAl/Jo597w0IaQ3fPpMwxl9V1sLljVL9oaiajAjfeMLAf0V6Hezecjw= X-Gm-Gg: AYBFou21jEHLc1vO4xZb31GTDTLMLUvwslw1CA58kQoDc3t2MxprIbzxL0rcZBYFQp9 gDpK+70zxWA6f0Lm1AIZ16XBlHhB4KDAa75UyXUGM2yoZh2w03WpM8wTQIO4bxbx28YKkHT/zMu 6JH2SlqyfswNJAhQWtn/OkVj4SP2gTm7suBKDGxRLZflySDPW1GQkKEeta02SYP5PmEudPwYcQF aScAQLTTV5U1mfTcI6qiFASSID2tSpClmlg2Zpge7aJ4053ARO72kE4wVlv3oXWwoN7Enhnn0oD +vbswik/oB9ZOO9RrfEWseqLUKpFmzbRfeViDyyGpEJYtYY6VqCGefqDN7dr5TV8mxd3q5wlNG4 /Ng+VQm0F X-Received: by 2002:a05:6102:2d04:b0:7a6:accf:72c1 with SMTP id ada2fe7eead31-7af19740319mr1080105137.0.1790251705525; Thu, 24 Sep 2026 05:08:25 -0700 (PDT) X-Received: by 2002:a05:6102:2d04:b0:7a6:accf:72c1 with SMTP id ada2fe7eead31-7af19740319mr1080086137.0.1790251704877; Thu, 24 Sep 2026 05:08:24 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:23 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:36 +0300 Subject: [PATCH v2 24/48] clk: qcom: gcc-sdx65: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-24-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2392; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=SUwK7+vvo8MXx+P0Y4VzWQKFb096limbIcKlkagiwbo=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJY86AicJNhLqrdq1luztbEgTGLOJtDxvzpX Q7HM85vxV2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSWAAKCRAbX0TJAJUV Vi8TEACE/mcrDGNz4VuYk452D3EH478DgF9c8SDed8rRLGDLcZezJPS4KIxHWkPHQFtZtP9mzcC dY0wI56AVVfZ7RXkdArCxJ6oAEC6lBVugfdi3mzukhKIrAfhigl0coc4rr4xfW8Wo7r6VcccBfI QdD65aoDpz/XvvZSrQbHWrB6SRA+t1Wumr8+/UtqBIlWyNANpVVxgLjz4xSQbt2QUVKqxNpRyEO YZTiD9MSeNY9SHQRZ5q9VlbqAWd4AFg8DbZ3Lqs8gfjSLqAthiVR8oyhh5UZga1r7OUIEOf+n0G gr6Qld1/3j2y/h5te3JRLvMWdEs64wJRSepx8Ykohi0dc5Oj1Bnt/cd9GGZJRL8IwmcPo2YqcIp GcLqctx8FxwBNnbQ/nTn7wrWW3vIVbFMjuQddI9NnNbZyC74eeQZKP79C9zr0loh10hAG7aHdjL 9/uODbztknwM36YvabQBiY8O26JQGoTTPLNZmlvvEzHjABSyapzxnTkgDP15bY+G5YYoRV3hXaQ UMDaaVjDlCO+oiV1PmChYZej5GlZaOmLcc1fPpRUV3POk6FmuKMw6CEz3BnTE5VHLhDgv308KJV j5dp7ASranr0jaKKVl2QwX904rOg0YWTWUPfQndqjEaLRz05O41sQBipnu47/slv52/ErYhIvNU ldr9azFkEK5cPjw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7y7rodvVBSSF tlOKtl1XdAwIEVbMnmkotTug8RvCLUewxvxc7MmWJ4V96vRIlXfJ75LxU5tT5LPFuInZZ9t6mUN CD93gTBAV446x6Xb4BSt6dj+9zcawy1Fo4SckWngt+9jYUn+vJ18/UHkBYqQGVGc1t9fwTeS6iP ana3rNs0WFz5rzyq7OKV4iKyisYdh6eOxLUIJzqCKCelU/awxZroh4JClflDWeApAEIBANdt5S+ sKCWjqZIoPHzXDaIeyEan5S3H/lSuddcjaFhqO/nfU1isIMbJPeS1ABfdWf8cEAOXnJlHEa5AS+ flNRSzpkJ1c768p/9V7lCILA2jCzVQ8OyHGaeNdtK9vxrY3wKLP8QSP5J+Ig2mGJumSCUvG2tRb gBUC2lWcp9GyvsxPXLJ4X2Yq180fLuPH/QoAB7P9Jb57vEs8YoXlLoao+c/Z15nHkXl1yIz6OmS L8gGLJWv8i7vdhY1QaA== X-Proofpoint-ORIG-GUID: oB7NyDxlOVWkbZANYgxanwfIVkqEfQ1q X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX2w76Iv64z/rD BmouCf4ewiaxzDjW1B0+RcKyyae75f/mYOgZvjtDS8hrpIv0dOE76iGoOhUrXX4PHBJqNWNnE25 Ik/4pS2fbaFk1Hilxu/+z4rz8VFt+nA= X-Authority-Analysis: v=2.4 cv=fvpJ914f c=1 sm=1 tr=0 ts=6ab512ba cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=8L-1-Gifo5kdOXCWqOUA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: oB7NyDxlOVWkbZANYgxanwfIVkqEfQ1q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sdx65.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdx65.c b/drivers/clk/qcom/gcc-sdx65.c index 8cae11a0b2c0..b1ab265ba2c1 100644 --- a/drivers/clk/qcom/gcc-sdx65.c +++ b/drivers/clk/qcom/gcc-sdx65.c @@ -1551,7 +1551,25 @@ static const struct regmap_config gcc_sdx65_regmap_c= onfig =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sdx65_critical_cbcrs[] =3D { + 0x6d008, /* GCC_SYS_NOC_CPUSS_AHB_CLK */ +}; + +static void gcc_sdx65_regs_configure(struct device *dev, struct regmap *re= gmap) +{ + /* Keep some clocks always-on */ + regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ + regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ +} + +static const struct qcom_cc_driver_data gcc_sdx65_driver_data =3D { + .clk_cbcrs =3D gcc_sdx65_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sdx65_critical_cbcrs), + .clk_regs_configure =3D gcc_sdx65_regs_configure, +}; + static const struct qcom_cc_desc gcc_sdx65_desc =3D { + .driver_data =3D &gcc_sdx65_driver_data, .config =3D &gcc_sdx65_regmap_config, .clks =3D gcc_sdx65_clocks, .num_clks =3D ARRAY_SIZE(gcc_sdx65_clocks), @@ -1569,18 +1587,7 @@ MODULE_DEVICE_TABLE(of, gcc_sdx65_match_table); =20 static int gcc_sdx65_probe(struct platform_device *pdev) { - struct regmap *regmap; - - regmap =3D qcom_cc_map(pdev, &gcc_sdx65_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x6d008); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ - regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ - regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sdx65_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sdx65_desc); } =20 static struct platform_driver gcc_sdx65_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A517B48EC7D for ; Thu, 24 Sep 2026 12:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251711; cv=none; b=m0M3oCMP1S7zCrI7mkf2/tpctW1Od8O2Q4m2aJ2UeFsrLjf+2Xjie9EG88L82fkmSDTaBObgOSywgfij+/gqLbv9X5L9rpjIqz8Ay+qWl2mrvREsayg9tzuutAhc4ek+/jkSkhx+tXRKmCNa+RD6x79jNd9uUp3XMGNFALiS4Ng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251711; c=relaxed/simple; bh=wVicLqiZaHQpK4cKVmkBC7c152NCcZk0J3UuKxOSObc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bsiA3lC6AF2BG25t0n/FBoBcf72bmcyq2omvynp5Xzz6AD+lVJhfubSIYalRUAs29+5OMcIt/BFR2abl6JCENw8FaFFI7HwFlIv5bq5QqT6MKuOjgJZiWKNZcUy12Hdlxdp3QrgceOLe2vBicZdoB2ppwBmXNQ1XizuJ1AEjPOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nQLw1D5Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IbdbnMH8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nQLw1D5Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IbdbnMH8" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC57hr1631198 for ; Thu, 24 Sep 2026 12:08:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wINPiwHQP2iJKtxxSgOnW9V9KgSkxNNXYHVR48986qQ=; b=nQLw1D5Qi8F5IWAf HoPMrVh4HJ80lMMytF6QNKhOFZrckwc3c/8mn6u78Wcr5gj0a7fxTJYZ1P+IASN1 p1G90RYq6WwDkLLe2ZkXtJr7L/uoeV+Ml5WwawyzgNRISjTvqCPF+5Nn3RZrdUNh 3huOwTrscAOUyC+hUo+M9lrC4y1lmUFZlLCVxjaTAJChBVxJUoFN8+En49rjZvVC rMEx8ipj3jB1vxHFzVT0sPD5RRSNTkRXrJuQit4yOZ20tjIMxEBzLCvbTegl7zRV N096AHXnMegHkjaCXOKW743spbo+NcNQA4RzTBG15EZSTWQj+QxsfKjUWDWhUKTX zAWm5g== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90axee-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:28 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-78a5a291af3so1819566137.0 for ; Thu, 24 Sep 2026 05:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251708; x=1790856508; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wINPiwHQP2iJKtxxSgOnW9V9KgSkxNNXYHVR48986qQ=; b=IbdbnMH8zB432dVFPoNrwXxGhNZtvRayZGu6E3sPhTRkxCHmpx2fp8xpS8C8HDZNXj H+/lv4hVqVF0JA81ApZ7ejj0WxTi/hprOAV6374djPC/g9AN18mofnLQRUPEN50/Ym1c JTnlOc3GChAZi55uH7fxzSBMdrP9jz7wSBHoGD60y5JUVxpAopR6HuXA8HS513EpkOfC rH/oHP+E0EsLAyXrMlEkp5iIKGvbigjcecPd9TK5qgd0SNTl0NNS1ymyuy/GDVDvUNyX VPpSrFfPTffy/3UkaGCSWEY0RXaRkyPZKLW/J9JYSu/pAALY//+Ol8hmdGqyd7cbFTgj 7rIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251708; x=1790856508; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wINPiwHQP2iJKtxxSgOnW9V9KgSkxNNXYHVR48986qQ=; b=fH3SJevNjPSSqVRYBuwqJJfqLog+laJ6IRBxf/1Ms3ttRkmjfWaFqV6et1xVNArpf4 i5hnKOB+QTSN4C1aLfDmbF67swtnyS4CbOr7bvClkfAQE2UPmBZrLveaTB65D20uKJ/3 dgJ5PjCaQGDKfONmuouQPFWNYdkhGBI1s5OTmgmgWlTFcbHt9fgiWWXWR48tZqauhfMh 6qOXRf8Kvi3R9qIiVHhTbynyVPGg1LZP9dgwur4M7KyA3s4RtrveX2PyMl/egpF4iAPv ezI4ymGLt+uoZjPueITFWVpdJ2qgdzIUH638gQ5rCa5aEIRxKQ9+XuLNprrwIWchkw3A Q34w== X-Forwarded-Encrypted: i=1; AKwUvBwUNcZCs6amhnCDfLm+//16LTTUYcE7yd69CaYGT31hvC7r+tTIYbw5X9xwm+h8Vwxp/6PtWqSTS2KUrsc=@vger.kernel.org X-Gm-Message-State: AFuF++l3PXOwZSwhBJCNBYQ6399Byy5SGxqwbLvNFcX8MQnFt17XL6px CLok13O11hLsE25kmiiWnLKi7azYVB+NomY05m71j/cx0Z13z+0lzj+Fqj8qC8E6uH9cb9i4Cpg MtdewcewABz2Oc/w4Xe3Q9jqi4/nNND49bpYdHDTDwzNRgeiisHoTHioqM7ziBMIWAOIQFCryvS Y= X-Gm-Gg: AYBFou0Ve6IqU20/cflJg5rkU8qKi0usuc558D0UAailz02YEUWsRYiiYg3Z8cpMrm4 8QkZHKye2BNqHn/HnCjyhobb8F944KcBUXaZwB0wKD4fsni/ASnnItQzlnmcKsbAdI91vQ/z+YZ czcS0Xjt5N5OzNavaL4W2E4MCxyfpiE1UwWHnNpiJep/0PNjV3ql5C2r/YGygtgWNhuI2D5VKP5 CUg1wXxk/Zz0RsVCqRw9deqy2nhjhnjeE0mPsfwrg9BKzpbufYizla6rZ3O1pMODQk0SfBmR30F oazrGxw0BH409BMoNXrv3yDj4KyJG2COFoIRijDsSLhvT29yKnr/IIY8k5We+al2UWiq9HFmn9P WBLlaZjM/hkvOR4e981Y= X-Received: by 2002:a05:6102:41a9:b0:7ae:c2ca:8dd with SMTP id ada2fe7eead31-7af1e6ef68fmr1224255137.18.1790251707602; Thu, 24 Sep 2026 05:08:27 -0700 (PDT) X-Received: by 2002:a05:6102:41a9:b0:7ae:c2ca:8dd with SMTP id ada2fe7eead31-7af1e6ef68fmr1224228137.18.1790251706758; Thu, 24 Sep 2026 05:08:26 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:25 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:37 +0300 Subject: [PATCH v2 25/48] clk: qcom: gcc-sdx75: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-25-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2188; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=wVicLqiZaHQpK4cKVmkBC7c152NCcZk0J3UuKxOSObc=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJZ6iWqAkUXQbMJbRt1TGihJgwVSz1IphPjQ 61ItvgGD5mJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSWQAKCRAbX0TJAJUV VpT9EACIJ9g7XWxUokYjlrQaNwLp0isvM5oj3cVSJTMlG794pYt5M3/640ayDzZHqQtug9amfob sZbNzRMVx8vI5mruED04PDsOnlvbCzBh20CpRcEyxbe6mkBxJVK5/tmG/LmcnD9lOVM2bENwBZ+ nPTQ90sBKq2sfhV4NUVYEGmWawhfbFdlYK8QmNwNO2dghtiSKlDzNNPxe6lvIZMH3PPOy888WIP 0nyqyMUKi/NBuAICRDXDRAZ4HaGbbtP5oIcPOHUmhoJCvbqb4LTrvSxHhBDnepZdXkMmeOzBxzM DI5SwAHIwOk/+2ndzF+8uFKDf6pdd6OPQeXuh/0w0uG7lqzIe7amD9d7Fuob76oJOmcaJAHj5Zn dLoxiwfdxyZORUWH4w6XDeDJd7pHQqdZvTb+3gfAc+iJIIfVbxp4uF52puuKW0kg0i6uI6DaZyS S5Z3qbK2OYx7lPBQE9BXjDMyUBDc7DKYF06SNhyESJb8SKj0jh3ChjhTG6M4SiyJGB1VpE5X5+y ASDlq5WZiriT1JMpLZlAdCQO63Ef4YwPHqnGFNeyZjHsE7BiFuUGpu8KLv7OVN8RQLEMyyziZ7X hdYGfVgf9TNEBOwmQQusKlOgUVyVDy1qHj5/vgkBcbGszXdwLlQaasAh6N8+0Po4MMPz+7k8I0D SHYOvdVcf1XCWGQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX2M3LWAR85rid zPqrbhYsh1LnT6kQ6/YEmo2lwwGN+t/9fiCtriyy3xxqDPc0DRXLCRrKAY2MnSvsXoJkCdULf3Y wwFVnP2D4ti/SPYj70QgLdQZWGKO2lA= X-Proofpoint-GUID: d0OOve0CcBGObBSxbRnwZek0n28dJdMo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXzVDAiVocZvQL 2QYD0W4jtGzcfjcM95pC2Ye1zpx6CoC9zLGyocqDfBCwsYhRiGknVGjuTDH+P9NxmwKcBFRc5u3 hBtR3kPdNmt5Y/FqDb//syDPpupdb9fB/sjY1DsSPywPOOO+F29VA+9dSjEjNnN2QJN+e46qKlv fEkUjRU2gkT/MI+PK/gW5VVG6C+UDJD5ZPp6XqcYTOE4MmihtLM02Pz0Z2qusUDA73eKVM3xlmZ gLtAs19zCil2T3jMaaBMCwMCbIfNKuy/JGVzGgypvwx6QdoXAW341fgzRvt7M+ZHyDMNjJqbX9s NRnApxVfI/rqwxm61u/ASA1rqw4JcuATDupWQI1IqsTu+2o6MtvPfxck1tz57B9pI2fRBM3qf3U 6NgvKTv5QWdIzmtH/EfWA2feFyZJTfSAIeVb98mHIDQTTfu22+kroehkTUyI6rwSke2ZFJtayDd BqcQfSXKgAixbvZvukQ== X-Proofpoint-ORIG-GUID: d0OOve0CcBGObBSxbRnwZek0n28dJdMo X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab512bc cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=8L-1-Gifo5kdOXCWqOUA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sdx75.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdx75.c b/drivers/clk/qcom/gcc-sdx75.c index ce9f19655d6d..035647627f91 100644 --- a/drivers/clk/qcom/gcc-sdx75.c +++ b/drivers/clk/qcom/gcc-sdx75.c @@ -2905,7 +2905,20 @@ static const struct regmap_config gcc_sdx75_regmap_c= onfig =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sdx75_critical_cbcrs[] =3D { + 0x3e004, /* GCC_AHB_PCIE_LINK_CLK */ + 0x3e008, /* GCC_XO_PCIE_LINK_CLK */ +}; + +static const struct qcom_cc_driver_data gcc_sdx75_driver_data =3D { + .clk_cbcrs =3D gcc_sdx75_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sdx75_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), +}; + static const struct qcom_cc_desc gcc_sdx75_desc =3D { + .driver_data =3D &gcc_sdx75_driver_data, .config =3D &gcc_sdx75_regmap_config, .clks =3D gcc_sdx75_clocks, .num_clks =3D ARRAY_SIZE(gcc_sdx75_clocks), @@ -2923,23 +2936,7 @@ MODULE_DEVICE_TABLE(of, gcc_sdx75_match_table); =20 static int gcc_sdx75_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sdx75_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x3e004); /* GCC_AHB_PCIE_LINK_CLK */ - qcom_branch_set_clk_en(regmap, 0x3e008); /* GCC_XO_PCIE_LINK_CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sdx75_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sdx75_desc); } =20 static struct platform_driver gcc_sdx75_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BFE48F836 for ; Thu, 24 Sep 2026 12:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251713; cv=none; b=B2VFJIdStRkB171ct+3G28U0tjeofA9PSyccWaEysbAceeSgQGnNT+XBb0zFCeTRHdD2oLW5BcIatbm+E55v8cSTDATK4Tu42vrr15J8/imDYux8gAYq0M+whrYuHxIIWe2dKhnnC8EOsY2tRGUfCV4PIlRO5PDMgzTa8Zqv/VQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251713; c=relaxed/simple; bh=CGpOnWkk/ElTZDyGYJM8tH/j3V0H3wY0rAfUpu2dMVY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BNnDdEELyRyQ3/tNLtFQDsWZKie/vzXtaVdTdctlc/hVoRznzqYo2YoZsV0BD3/kwsrbVQiYj4cZ4wb3cwKZUhToGIc6d7y0mHEVhbYek9TCMdN8aY9Ep5IMg/Zkn07kzZi//NIz9XZH6TruKwfRiPY46vu7mJhoZ8U0MEoQgV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AWa6LzeV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h0T0U/BS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AWa6LzeV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h0T0U/BS" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4tBQ1630793 for ; Thu, 24 Sep 2026 12:08:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2tNQ6jvHLom1PA68jaL5sN5X5omMtKHYp8VZCdztl78=; b=AWa6LzeVHIh+EfDH YwTLqnBC7MYo7B5OS7fTBQiRl66nrzwtOTy28KOcvX9VqYxo540nUa7EOQmUB0Xc h2h6TM4S5S/2ukeIeZ5AXaxKP39ByKBBaoV9yC3uwcxa3AS19X0H2deEVvY1Re3g vTYSirSOMKSMz77lKgylUIIznvxqKMg5+xivDrbXDhaIMU5xbcuoQTJKYc7FUMDu rFb32yykPHhRi8TtzKzqUhtV64LT3g9fNppHguhUad9mUWTK3gjE2W6wlfE+c7mP mqgiQOLkzinj8MTgmh58orj3NR/sbVk19dcMNmAeV/XzN14MPlgJD1Ur6n/rTB7F EQNMCg== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90axen-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:31 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-790de8f0cecso559627137.2 for ; Thu, 24 Sep 2026 05:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251710; x=1790856510; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2tNQ6jvHLom1PA68jaL5sN5X5omMtKHYp8VZCdztl78=; b=h0T0U/BSrQ6V+6Rl6Qw1g0iP1T65AyCP4kyOVYkVdzceSW4rd3Tb9s13HYLU0POZly BbAdhRsr6WDQGAPVdS8Us4n4/NXERRBpzqu/1O6d8GE+k/j2E/eFMoVKGM+s2do0gMKR zDini/ikZ9rZvF2Quw2LhpEDpY5E/EC7WKv9Lf+8yyNTMTGlyXHfsCvOvjQa5KnUjL+I PHLCLkydvTs3OO0a6pxK/wvU2rzTEKbWxob6FcQl4mgjKZ1z2Rgcg+3tqBFJcYa0wB/f WJxRnwK77FCnXXKvhHKn/RkXNIeS06RzUSB3SC05tfoCjAwnNNDCsJ306FCsnI/WHBFY B8CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251710; x=1790856510; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2tNQ6jvHLom1PA68jaL5sN5X5omMtKHYp8VZCdztl78=; b=hpgqHZfn4hZL/l7VaF3eL8BYnT0oSzOAcB2Z2yur8h/udi7rQ0vYjWcteY4aqrXBV9 kseDpu6dlUGFbMLhjx8fPDyw92RGHw33HpDhwUAy8OmvHyIFfgjUqudTLS54mBlonGiB UK/Wyl5Xk5Osk59TTqvNJoVnQ/JTjU9vJXwgjVdVB9mWCzH6t6DaFTFAqQYZnAOgKNzJ NUXoxqyUN7VqMvyTg0NRpDAR3Q106E7Q0fpBOKedVwEI6yiks0jTotSG8W9TLkTTuYRB ZZuMrCXthtjGPI5KkmyORSgSV/3GmT+/1COBfJW/rSy8MG2GzCnjhCKI5sDAhPS78hg6 b8PQ== X-Forwarded-Encrypted: i=1; AKwUvBxvjUNl+jfmTr8nxasW5WEFK1Shsq4RUbL12Dm1J6fXsIA8pITEtzQ98uGm41FwG4OCGshJ1FoujcgL0XQ=@vger.kernel.org X-Gm-Message-State: AFuF++lhvfh9oeLuPnVwn+5X0GQlJGlONAP3OGmIt+oalxu0T8wf5016 RtzMQKTjRi9bimziKQRiSq3DEC+0jfammXbBkgeBU7m47SgeJyJJGgfQO3kznrLMPKcnC3NsfoQ zo1iSuGRE7yFRLeJiHTKSOcGoiSLxG6vbCWxad/v+XnJNOWnwdxIF3sIImSsRGZGJj9FEJ3kJGR s= X-Gm-Gg: AYBFou0YTY62SILoZOWDhWi6l9A89nHXz2I2XwMQQKxdisPqx7dx4SydPlpyq8+oZ1y 4EmI4cpYROSB9rEsRepqxLOVI4yq8J18ZT+Atkusgu74rgs0afqpKadiADm14Rx80C7HAj2UkuO 3Pgy9qe6Pyamt6i97uvOOidyUns7crvDAd8if2uRHm19vemxkH+hJHzWYRMi5PY30CgOVD+9n+D SvzI3vgErruHZabRhSzkJ838rCGp02mU6vTiMthUC94IsStrNrq87KcpZj1htTTlQ90wQJcHJEn xykgxMDr+4emAnVh1lQlgKm3ksH0aAaOvXrC8SfGyLwrJieye05BG2Ngopg0bD8qd+JalhIzdv6 S0AuO54EU X-Received: by 2002:a05:6102:5792:b0:7a7:195a:1b2b with SMTP id ada2fe7eead31-7af1f815d47mr918228137.37.1790251709990; Thu, 24 Sep 2026 05:08:29 -0700 (PDT) X-Received: by 2002:a05:6102:5792:b0:7a7:195a:1b2b with SMTP id ada2fe7eead31-7af1f815d47mr918205137.37.1790251709278; Thu, 24 Sep 2026 05:08:29 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:28 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:38 +0300 Subject: [PATCH v2 26/48] clk: qcom: gcc-sm4450: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-26-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=4313; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=CGpOnWkk/ElTZDyGYJM8tH/j3V0H3wY0rAfUpu2dMVY=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJaD+o6idrGxWBaeESL9UJPdkdbJh20krdgA CWQr/k4a46JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSWgAKCRAbX0TJAJUV VqBJD/4vTuzWAzVDAJBJV3cA0yCM+19hdzQfR6oqDyy/jXRakYvJWO0xYLMJ9NmHsJcVXkZUIhv oiWN06sn2bCzzf4/IIcuSn4orALpe6CGKhwvWith4LLl517M8DBs5ge45HKgo0SiWCZ++BVNejk NsmNYdgr5t34ienPEGac/u5YwtPboIeGcn5BxrZLR35GQbOt43vpBQkoMS6uu1s5eAf4Q2Eby2V CuMwIJHNge2/xpy5/yQSLz1J2ZSkyHoXMFAM5JM5s7nfQBNZPvwUhF3GhEc48+olFFOklFGAeQG S01HLGPJuY6IJsiR4A2umucuM6TvMrNf45GnbsHhIbeAjdMPHpHzcr0V85rmOmTB/mqtvWcnvDm 7iCuZT/rfJAZhJwUbX/8DLjIz1tey3T8a55HT3tuSwVpfzK8nDXZjYkicqBF4jWhoOWXnxcPJCr +C4VFLn/ksh4qsi7JR8glAWi1MLuD5qt2gSUYZZeKbZ5iiMiFLgS+va5irHZEgnkvsIAhIIIZHJ QBTY3ElSYvHaJk92+dxrQ3ci2JKOxv3BmfuA3tqDzeqNaohhvPU8C02RYrdWlMXluCyTQHjYTFX 5tEFyFUm6FBamL08HwDcCelmYa53zIXPb+CFUqvDmWWzW1mkqELlsRfiF3vdl9Rs0RI2aUxs662 kDgyIhyypbnUAYg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0hfWGW51+0DC t8HrB5RCYJMNjfhAvhSgsYxkCr7KlPO9jgPpXl9J9lnaG6APH7UBKrRcBBvA84JxjiaaxPXuGvf 6Jk+zBdIaVq4jZWPSiizKqsPSychj+c= X-Proofpoint-GUID: kBeUzWnRPNjZi7URVKCo71P0oeR3num9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0sqW7y4qAPew +V2ey4yjv1yUZesohFGRs0e1mlgNTZBIG9k+azGdFCcoWqelyflRkYQjILct+wgnfrFaWjf8RXQ xYvcMw6LYJ8oCToBKcM2PZvMgxl7lmojKB2NEg5CGcdODGY4a9kBCmAdlJ/84Rh1+aXJQnAnAVd kHdmh2fnSTsi9wWU3zphT6EOuHvNKQouG8HfeOYKymX+xxzFtF4rc6QNljylm6YcGRkG9vOoWYZ pwOHXUIxGArnPatKDXSU2A87dsngLS6d3FsoD7EqAcoHST2mv/XhZoP0wrIuaDka8VK7swm72hG iCWtk3mLCXwVlG/4RKEY6kZN4DzHtEfBeToOhXMrdA89tz4a3pgPLsVwHLF/Tfoiany+wqbvTXh B8xlVmfVha+Ywx8Q3ge+ZFDWJom86HcJE5MjaEtwfu2BuREAgiMt3lEqvYn8UvPqn1FNDx15Xwk bgDkl0huJUJn+CfqRhQ== X-Proofpoint-ORIG-GUID: kBeUzWnRPNjZi7URVKCo71P0oeR3num9 X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab512bf cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=rMBTewrK3YKLiG1KudIA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches, DFS RCGs and GPLL3 through qcom_cc_driver_data. Associate GPLL3 with its existing configuration so the common PLL setup invokes the Lucid EVO configuration helper. Move the UFS PHY ICE core FORCE_MEM_CORE_ON setting and the video branch register update into the clk_regs_configure callback. This moves the UFS setting after the always-on branch enables. Those branches serve the camera, display, GPU and video blocks, not the UFS PHY ICE core clock. The UFS setting is still applied before GDSC and CCF clock registration, while GPLL3 configuration still precedes the branch enables. Use qcom_cc_probe() for the resulting common initialization sequence instead of open-coding it in gcc_sm4450_probe(). Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm4450.c | 64 ++++++++++++++++++++++++---------------= ---- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm4450.c b/drivers/clk/qcom/gcc-sm4450.c index 4fb4d43e8582..7a5274687890 100644 --- a/drivers/clk/qcom/gcc-sm4450.c +++ b/drivers/clk/qcom/gcc-sm4450.c @@ -140,6 +140,7 @@ static const struct alpha_pll_config gcc_gpll3_config = =3D { }; =20 static struct clk_alpha_pll gcc_gpll3 =3D { + .config =3D &gcc_gpll3_config, .offset =3D 0x3000, .vco_table =3D lucid_evo_vco, .num_vco =3D ARRAY_SIZE(lucid_evo_vco), @@ -2815,7 +2816,41 @@ static const struct regmap_config gcc_sm4450_regmap_= config =3D { .fast_io =3D true, }; =20 +static struct clk_alpha_pll *gcc_sm4450_plls[] =3D { + &gcc_gpll3, +}; + +static const u32 gcc_sm4450_critical_cbcrs[] =3D { + 0x36004, /* GCC_CAMERA_AHB_CLK */ + 0x36018, /* GCC_CAMERA_SLEEP_CLK */ + 0x3601c, /* GCC_CAMERA_XO_CLK */ + 0x37004, /* GCC_DISP_AHB_CLK */ + 0x37014, /* GCC_DISP_XO_CLK */ + 0x81004, /* GCC_GPU_CFG_AHB_CLK */ + 0x42004, /* GCC_VIDEO_AHB_CLK */ + 0x42018, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm4450_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for the UFS PHY ICE core clock */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + + regmap_update_bits(regmap, 0x4201c, BIT(21), BIT(21)); +} + +static const struct qcom_cc_driver_data gcc_sm4450_driver_data =3D { + .alpha_plls =3D gcc_sm4450_plls, + .num_alpha_plls =3D ARRAY_SIZE(gcc_sm4450_plls), + .clk_cbcrs =3D gcc_sm4450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm4450_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm4450_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm4450_desc =3D { + .driver_data =3D &gcc_sm4450_driver_data, .config =3D &gcc_sm4450_regmap_config, .clks =3D gcc_sm4450_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm4450_clocks), @@ -2833,34 +2868,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm4450_match_table); =20 static int gcc_sm4450_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm4450_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - clk_lucid_evo_pll_configure(&gcc_gpll3, regmap, &gcc_gpll3_config); - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x36004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x36018); /* GCC_CAMERA_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0x3601c); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x37004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x37014); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x81004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42018); /* GCC_VIDEO_XO_CLK */ - - regmap_update_bits(regmap, 0x4201c, BIT(21), BIT(21)); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm4450_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm4450_desc); } =20 static struct platform_driver gcc_sm4450_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4AFE4908AA for ; Thu, 24 Sep 2026 12:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251717; cv=none; b=oQdn13fgVQsmAfAj02RgobQOFj8k7Oq5Drvkl30WS+/Q6gc3aGlV8dmqeHu9HIEMOuUyrYX58wZiXdME5qOrc8xs+IMYXhinh77oo9dNs2S0lnve1ZetvWtvYCuLIg6oXajgsK1IH+LXSefSFZZmgBfS6qcxlilkyz6RfbPg2zU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251717; c=relaxed/simple; bh=5/+yq/OZHU59oTI0w+M5LmDPVmxLF6klF1uvoa/fUG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bysqPbUtOUF/qzxI4rhKMYQBBlrmsRVOVCkgpRp/oXfBq1nype3A4LUsrQ99hWeFpnGWZeMc0z2WmGUAyyfMb/Mv7W9z6FEmiLJTGcqVb7Nos39VJP3wiQzOAuMpMfyovWhafBtmo0F2TstkpKy+LPJQ2ozKM8kG9cm7CfdLJPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JgcKaWiw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M9w3i4K0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JgcKaWiw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M9w3i4K0" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4uK6803963 for ; Thu, 24 Sep 2026 12:08:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dcEkS/CKWxZJmC0ME3XU/7Y2HZzoqTfbuvowuFPXkHM=; b=JgcKaWiwmYXqPm/b D0girXkKNmXTcSZpphfTUkqGLEmosZJBBp1I3otCLQd/IYrr6QN2j2RgPMlQf9gt bZqWFSIlvK5FyswsxIqttJYw3j9shdXExi5th4rLJZy7do83KZriOBSa3i/Oc8Pz qqa0PSqv8gr2+ZoEFYZEVojpzfavPqTfbTruB40ow1DHf8Q/CXYVY5fpZC/8KYST TLL6JNurF1NUuL1BXPYVjiQVLYrFQrrctmw/g1orW7woDYKxLxJ6GxnqLBDltq1X 3mVCyd/VukjtYdpeMZecG7uj5UOt9MCCulxzvfaWr0lIX7ASJWS5EY5J+hYN2M23 UY5fKA== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8f64-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:34 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-785827e6073so554073137.1 for ; Thu, 24 Sep 2026 05:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251714; x=1790856514; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dcEkS/CKWxZJmC0ME3XU/7Y2HZzoqTfbuvowuFPXkHM=; b=M9w3i4K05JdS2QOXCnufjfUdjnqgLJuH3nTGCNJdxxv6w+loNgnzGLA+vDS4HdrTDr lW8R6bY5mgz+c08EzNLnCez9AbTwuNO1L5IfMvS54sgXQWnM0YRL93SUlBFlBU3rNloc fcuagcpYjUrius7LGIVM3s6NTmhhPdkmtJ7Ed0bs1uvlaWXgawyO7tqj9NIpSaf2bVvx KRSfnqpPNVpLA68KDjDqMum4ZlNNyCkh0RKeh3xeImZloy6lT2B4tKdNP6U91y5ITJuy TBYjg62B9ox9sN3uH/ZlA+up58pxe5DpfD0T9Myo2pvf6ZoJnpVHxyfwAdXIF62CdjgD vLgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251714; x=1790856514; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dcEkS/CKWxZJmC0ME3XU/7Y2HZzoqTfbuvowuFPXkHM=; b=lhbdbGrO3DH6QdtnN+s6YS7UEJgS0ZT0AoHV+0+t8UaOZSdqEIIO7CyCitAZy5kFUE Ss/z2EKa49aul/v63hyKSTA9Pa2L3+kshoXq2XPOkkJKaDbgDhADQvEngtusxMmiSnlI WGoHl+DiB/Y1N9GX0GwbNeZwOHYVHKDXxydznnKrSBgGBYte5jGbovhFv/yxPrjp5coc 7w+tv2XQp6SuVoIfTsqWu3y+bkGp1gCJ1IJSKEwX02D/hIrVGPmZeTaAto0IIaDIW0Bi 4pVY9iTpyDz68LLeWy1KzqSUQFiUqCvHUrPh3mrSxtrwS0+hvmSDz95bwKHGTT7k7iav hZqA== X-Forwarded-Encrypted: i=1; AKwUvBxhvTxGMYs8iJvBe8VUG/F9056hlkAgYP9xWVmdhx0z7atuQlugV+vPALUnVdHPS7I407XW/dgrXp8G5NQ=@vger.kernel.org X-Gm-Message-State: AFuF++lQbDqVhKYju6GLZ39ETAFWWHU1ysDFjgCV9c+vZzz/CrXAmAPn XI8bYnFQg4HUTRCGp2XRx0QcthtHOSHPhIpoL/J2OJ8qYviy8ub85nX9FGT6DL08yDdQXUzbnjK dO8Lpa75CJZl8AFJJF0NclT8aoMkOOu2sk8UrMBUT0W4OJvPQ4djSFIB0bXaN3xjn4MY= X-Gm-Gg: AYBFou1b0X/CClHInq2tLg8R6+XSfuWqoA0ODab1RRCs5kJDuVlRnMTlKyyNWHiOcuI 7ObJip3WcuQrjx8aNxxYaCrXayBXGMjuwu1yTf0bjxkIkULoiS4L5Netcd74vA8FeZXwfGbRZCH N6kPCgIhfT+I/CcQvPEjSWhSugX547CXOtcLBrejKv6/38n2J02f3QFSttAI1zw8G7Ermz8j51U YJhI/6xzrzvcOpK/2ZyE9e/9Tu7bvqsez2enaLZ4IBP2ZI3X+ifUJWEDCR+3v7S5hdPNrcgSuj2 ytc/aJy9hnJkevOLCYFxadUsc2GZpzL7lQXROqYYFhLsbjXEGTPx/IlyDoHVAH4RWr9jBifKaNZ GebDLsvo5 X-Received: by 2002:a05:6102:1627:b0:7a6:f970:27d6 with SMTP id ada2fe7eead31-7af1e9f2d0cmr910348137.20.1790251713713; Thu, 24 Sep 2026 05:08:33 -0700 (PDT) X-Received: by 2002:a05:6102:1627:b0:7a6:f970:27d6 with SMTP id ada2fe7eead31-7af1e9f2d0cmr910329137.20.1790251713148; Thu, 24 Sep 2026 05:08:33 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:30 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:39 +0300 Subject: [PATCH v2 27/48] clk: qcom: gcc-sm6375: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-27-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3051; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=5/+yq/OZHU59oTI0w+M5LmDPVmxLF6klF1uvoa/fUG4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJbeYoXXFrv60EPCFg65cmW4ghKjAtUc5qi8 kVRvFqQrRaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSWwAKCRAbX0TJAJUV VtY3EADIv/2HrvaCDhOkhl4o6eD7YMZYF/Jlov3xKJA6Zjj0cdukXsV/e3DEITItCHnfmX4kff8 Cp+6CTrKMT5Zc7sXO0GYEvbOvTHHbnrdXMSm2saldq1AiSk/446EiGIBMTy9fq21MOdq41taahO 7NPZWiio6GkJUI3qJNS/ypb/zU87n04cVLB5BGHxgT85+TgK797pkwwvzRQpIZ36AdsqG3qU9Ke W5YzMOWJnaPPjD2EPgNb7R4F7ZY2kdp77FBU4zJhxOqCikDv4WBEr3YilO6gN/67l9QtScn8gT8 XwGIPAV5d8vGj91Ckfkaqh/dPEVQRKesK1vfC2tbCbfsj39/k/87nycosdEyLMKkiACg72fE7Rz F1xIJGyD7v+M+dJZIe3uQdWdc5495hcoqqTx5zoSPLbrPvc+IjTl+ISCwdmWYFwOYF2LdVZsSjM CjklAYQZ8xTEYvj/5x6PeIxOMm00Q5sc/VciWpJGI1mriK1fsYX5+/AHlM+0gA4ufLzbT8lPVcI 2qiXntTaowkQJfyIZr+hqEF9T8bvydFozMP0be1yHVpks5qXfGq/8q3YB7OiFCAfpH2ce/gCtQ7 ZoamorJIv1jsvAZhIsSxN+Zo4yXMU4IxmNX7LG9hAqiVDFtoijvwxyHdgGLHSX/HQmb1Fzvl4V9 fe2Z/WASLitzaHw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: 30OC9sDqpQ09WHOU8PZCLFJiysWvba83 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX5hYASUoFkkZn 4mDpz0FJ6LU/HlYpMEEtphdaxDK84/x+82/J8w1i1550V/aqMR1KznJRg6LQYV/OT3p3CmRxPAc VXVzNMoJ0Xq4xS5bn1CKTz4BVuyFD4Y64zCSFrv577VFfDIZr1HfxK7nYYUjt5JCWQIbYNjoa/r HE0RD8gaWdOB+ORIa8eX+hpcNHSnqhYCFGX+HAG8WXPBLgbmWGP1huVSg6ZSPLJXgB/1vZjjh9G wZ5szItHxE3EAR9sWbvfJoapD7d7MFZ+Avfnaz+YVwtB0FKJIdTD0OVjg2Jji6rV6RGAybqRVA5 JdfTwClRmF/QhYNUpGMOOnwwEgUzfLdw9I4DZ/IrSwZm9Q0p9UeR7E76qFlebQ4GGtOd9sAGujy 7qFcGz83c1aSFr57AVyMj2DzOA4KuCKNmKBtmbXGA+/AGbqT5XdWhdYaTzh0edpGtGJ1uiMGlWP n/K4b10ue59g3VzEIhQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX2zrPUVyYY8Tm 3g13kysF44hoXz4iS5811A+2sk+z4ogr/IwwN9C3N6rro1uytFd4nshnpztdAMMHQzImlxxikG3 DD8IlH6HkD3d5IOTUC0owu+0J3r9R1Q= X-Proofpoint-ORIG-GUID: 30OC9sDqpQ09WHOU8PZCLFJiysWvba83 X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512c2 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=Ob_rVKpFIq5ZwUCH2zsA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Move the configuration of GPLL10, GPLL11, GPLL8 and GPLL9 into the clk_regs_configure callback. This preserves the existing ordering of enabling the always-on branches before configuring these four PLLs. Using the alpha_plls array instead would configure the PLLs before the CBCR enables in the common probe path. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm6375.c | 46 ++++++++++++++++++++++-----------------= ---- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm6375.c b/drivers/clk/qcom/gcc-sm6375.c index 9c2acf8dc4b7..c67d4293c76b 100644 --- a/drivers/clk/qcom/gcc-sm6375.c +++ b/drivers/clk/qcom/gcc-sm6375.c @@ -3853,7 +3853,30 @@ static const struct regmap_config gcc_sm6375_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm6375_critical_cbcrs[] =3D { + 0x17028, /* GCC_CAMERA_XO_CLK */ + 0x2b004, /* GCC_CPUSS_GNOC_CLK */ + 0x1702c, /* GCC_DISP_XO_CLK */ +}; + +static struct clk_alpha_pll *gcc_sm6375_plls[] =3D { + &gpll10, + &gpll11, + &gpll8, + &gpll9, +}; + +static const struct qcom_cc_driver_data gcc_sm6375_driver_data =3D { + .alpha_plls =3D gcc_sm6375_plls, + .num_alpha_plls =3D ARRAY_SIZE(gcc_sm6375_plls), + .clk_cbcrs =3D gcc_sm6375_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm6375_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), +}; + static const struct qcom_cc_desc gcc_sm6375_desc =3D { + .driver_data =3D &gcc_sm6375_driver_data, .config =3D &gcc_sm6375_regmap_config, .clks =3D gcc_sm6375_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm6375_clocks), @@ -3871,28 +3894,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm6375_match_table); =20 static int gcc_sm6375_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm6375_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_d= fs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x17028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x2b004); /* GCC_CPUSS_GNOC_CLK */ - qcom_branch_set_clk_en(regmap, 0x1702c); /* GCC_DISP_XO_CLK */ - - clk_lucid_pll_configure(&gpll10, regmap, &gpll10_config); - clk_lucid_pll_configure(&gpll11, regmap, &gpll11_config); - clk_lucid_pll_configure(&gpll8, regmap, &gpll8_config); - clk_zonda_pll_configure(&gpll9, regmap, &gpll9_config); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm6375_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm6375_desc); } =20 static struct platform_driver gcc_sm6375_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C5A490C02 for ; Thu, 24 Sep 2026 12:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251721; cv=none; b=nD+MPo6sMBQvkWWqApl57ZiDIdgZ3pfb+WHH+L13MyfTOh9yyfQZ1DyDa9u7//z8+077xL7hFV3KjoDEYgaUalosk9ZfQbNjklhvNUlf7cWA90W1oB6YJusHDAcc3n+SinaDYo2T0rcqv4W24+yLltlSdOhzZztP86T0nTNdrT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251721; c=relaxed/simple; bh=930j+Yt2IV5aPts+d6X+P6nNn49+MTBzgKfv23AxygU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k8HGVnCWc5ycO2qMKyMZjdhTCIgsxkEOZIfnxMugm4oMeNfyj9gFI7niH1hK7KzGCVuOZQYnI3GzZJUy2NKrwqmGPlgP48hAL4sFa1Raa/X5r4+U4Jcol7glORXruxhceZp/6IHSFYjsrPedKGpwGBhY/BROc63wpF0vhkdt21o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FT3CwevA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QF+mxjAK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FT3CwevA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QF+mxjAK" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4rRL803909 for ; Thu, 24 Sep 2026 12:08:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1pEaX+hgn1vMihkCpuYdkI1lXN1VpbY/l6gRmgJPZHw=; b=FT3CwevAgxUEqcuu TqEfZULKCf7c5g/WCEjaVQKu7TdyZO33S3NABjvYCoX368i0lelEDjX3ylFhOq1Y hIrXM2utwpiXUed+6sXAWCWw39/DT22p7fz14HJbWe6e5UTniRHJystclzsCwL8M ZTRYWTcKOO4Drcy48yT7HkYwBtsvQ76TaaW6JQvv9Y2H9tfqNoU0DN4cgvx8VOv8 wCYjKlZb/2m1c0aRxm8OFv17ZI1FhFDljOYpzNPZtEqZ9foOr4Gtji5uwbCbweVM O97VpXb+Y9Yr+c/LiOKB72KPci/ZX4ui067+py5cdcltma0RPX2TIpPZzo/ZmEUd dLRGsQ== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8f6q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:38 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-9806e283b0eso1468727241.3 for ; Thu, 24 Sep 2026 05:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251718; x=1790856518; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1pEaX+hgn1vMihkCpuYdkI1lXN1VpbY/l6gRmgJPZHw=; b=QF+mxjAKw97pLxlOMiIHxwsEEEDc1YTYrrBarvR1j1aa1awK/engwD1U0RDKK6dHXn iXgg5D0d6TmdfQb+XarwE9TkWJxUH0dWLJcZ3ZDvqPAu8cDrW9PuHrYhWnMrafhHNzpA 8jWaDA7DDZxPEaJ7prljAKPtXZpDb/RPDHdF47w0vmmI6iu9B3ydkxRddZNAmyLaBl0O PZItA26qyuxaXVcT+f7nOYzFGCzoyaN9JOG9XJlkJ7jUD5nr2yEb4fk9YG6hb0XDMSNw QUfgxlcU4eEcECC8aXKOMJ213pvppOgw9lHLV/44iPBHo4Pon7JjoIrwlwQXBUnV1/ZO R27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251718; x=1790856518; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1pEaX+hgn1vMihkCpuYdkI1lXN1VpbY/l6gRmgJPZHw=; b=pcdFY0Hz068CQ0MeQvJf4xROIQvcLuPwL9caVmiTneNKWHrriDGD4ugBkO85+GqJrh QK78ZeRk27A8h6aReATUuxpDnINYkoamjVuRlMpdbkAv6F9w3EjbKdtv6r6lsvYlntoi H44wVU6aPqKAIHiS4LCcg6CmKSLT4MWKwrJsUCBcriaAqwIKlTyrc5Mw+Cb8aP5tdf3t uIXaklN7hkabDp3BVnYAoVx6ph/8GAWw8s249ViL6tS7h7vUFPqo3pCg9dBkKvD/eHwW cbwEVnukzOlWAS4DPDWjDr+6XCKlWMOAGdnVo7zSb1Y2hSk1n5srFhH2I0hAKjnhUtj+ aUJA== X-Forwarded-Encrypted: i=1; AKwUvBwOHJwRJvbcCOrIQGF2h1L3CEfMxV6PAW1TP1y8KrU9APnB1NGtZTvXkTyJ+5mncavX1rAWvnoc72hoj0c=@vger.kernel.org X-Gm-Message-State: AFuF++m2YRceNh0eDHs3N8KSFKZzjySddL/rqZPQA6nnD31kWBwAcv/E SFNxYKskhSVwc1Fcxxs5xMoo0IQJy3PaW/JS4AVSmN80CfEHk5J7VBRWSg8DrF4Iz6QUUF1nHXf COD6gD/k5rzSj2d+IXkSpKC/BGHatZotYpd8j1mS43srAWrHpkliDXX/LA78fMqEyW50= X-Gm-Gg: AYBFou2XgB5tNikEMm1sZGyuid7cbdqaL1+M0gpY09dYr1tyHC7lp54ZH+f0vf+iE6m YcsBbDXgdfQA4gV4nFPZhvBOm0H4XJUlIWNXkFFzXj0oJ0kUhKH6Ot0Od08V0N6mr/CwMnzIOpP muxeaGHdePj6ItQj+zhb/4fCFBm1cYUvA1C/DFWuH/ZQqWTSneSraeek1M1jnx5LPsweJPG0e/a 00F0B9C5IpwBz44dQxfjP90dBgQyVe0yTI7BEmNd/eQECf3ipprriL5r5cyMHGxokzb6R71Q6dc LU1kvH4FHAp58o1PpG44PopzoYELp6/WO6qvpyNWFo6SXTJ5J0lHAvQxk6KhU2YqqkxWlxczUAa CbLbmltmk X-Received: by 2002:a05:6102:1489:b0:7a1:f7e2:aae2 with SMTP id ada2fe7eead31-7af1e6f380emr1144003137.20.1790251717593; Thu, 24 Sep 2026 05:08:37 -0700 (PDT) X-Received: by 2002:a05:6102:1489:b0:7a1:f7e2:aae2 with SMTP id ada2fe7eead31-7af1e6f380emr1143982137.20.1790251716962; Thu, 24 Sep 2026 05:08:36 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:34 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:40 +0300 Subject: [PATCH v2 28/48] clk: qcom: gcc-sm7150: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-28-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3551; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=930j+Yt2IV5aPts+d6X+P6nNn49+MTBzgKfv23AxygU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJc0vLQPdDyaZ6dZPF0Av3pwuTqhr50eTxGi nt9fK28OsCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSXAAKCRAbX0TJAJUV VnJHEADE0K8tztCP/AHg05VbvHfB+NGQ0P/lcojqj37YIoqEHibHyxKYeMFWe3N/mg7fF6c+Bj0 cDsgwKslPrmGXaw8g4MTc1wLvUQam544VJpQpXMz1sYOTh7oKE2hTvvX2AO891qCpwROmmvT0fv LzM1SqXLr5CYoS/yIaDWTmdMY+/g1lmXYoLgy3a9gswUKuxblTIB/PyNEGpVOOZ4Gw53fhVPZ/h DK6Kn+qk0NIG5dyezfUMiu7hXtVeK9ojw2Xn2itWwgcNA+H5El4d1tOTJwtn3fP0F8tr/pXmA// vQqkJ1LRUFccKYHKgYTjtu3JPyfkY59DD6x/ATKEWnuzwuYR/cW6vmYVKxLbuSfW66uS6KG4PzY H4+LxoqLqghZLGa2UDSW5g5Jcxk1Qf7iNmEA6TlCPCedcngmoZOz4a35daDF0N+Ky6OERYlru6f Rc9PEuvItRuTHq0MyeVs0m+Q+RV2ymTWTv+oWoEORKx/+rTGIYjlI8/POn/jYX0eTVw7QjX8RcK aYxkGfLh4sgMMg+AyOVI+7LSa08d8THJNBEA7EiyWTL61ClyUYGx39GkwXj5kgM+OuNLYS+t98E s5Hy7/0qG/RaMNwWOh1eaGdCtGouVUXGtKOFW5BpU0+tDu2tu2TN3uxxMaqULJ9JQ156Vdy+dyA F2m3nihhGAI8gMA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: QPMV2f-j3vldvEf14qn6qHPXbtZxl-Tp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX5cUFTMcvWZzj LDI8m7Q1AzVYsGsaeafNsvrFR172nuMjUzJIUZr91SS+ZdGCgDLiLxqqyfcBeB9C7Mkvr1PVhQ1 QMVY9VAGzjXEsz1dlDZJCjRKf+e9mIuToQDD8Pu7/SCDzfKDldSXPY9akvHBxKsdmvY5kSJzZs/ X/aAVYX+q2r95vwgN+Gqi0NyLDMeTgC6HZsseiFGDWqVmxe8jjrAxLapDvv2yQkLQHe+NRAd8jv WGePVom5HvOveoWBDBvayVBopNbku+bnwfBXKyZGaTjsoKoxfYiDDX+1G8Vebp8WVFMbs6X6oo8 TsaHWQly5v6W0Z/BECaf+35Twp3+wQJmPw3LsM9Q0rcDfiYu5bq1uQog0o3Nl+zw3qx5qSxsnhe oGMeEwHvwls51FJrSvIZ1+6dD9rLPkhMzLNngYB3FN/MWhzT/Edibq4aQjwofsEGwCXDy5JGpnj CsGYnQeEv7AE0vCzwxg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXyflNQJsmvZww iZVanEuUuKY2MMHE5p0ubowJQzaZCPmYLGTDNlGXsLpx0PlYbgjheo1ICLZzNq4KD5+DQckV0dN vABGaTNOP7cxHW8R876dTFXTaHNhfuI= X-Proofpoint-ORIG-GUID: QPMV2f-j3vldvEf14qn6qHPXbtZxl-Tp X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512c6 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm7150.c | 60 +++++++++++++++++++++------------------= ---- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm7150.c b/drivers/clk/qcom/gcc-sm7150.c index 2ab3e92eb3c7..169aef61e749 100644 --- a/drivers/clk/qcom/gcc-sm7150.c +++ b/drivers/clk/qcom/gcc-sm7150.c @@ -2966,7 +2966,35 @@ static const struct regmap_config gcc_sm7150_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm7150_critical_cbcrs[] =3D { + 0x48004, /* GCC_CPUSS_GNOC_CLK */ + 0x0b004, /* GCC_VIDEO_AHB_CLK */ + 0x0b008, /* GCC_CAMERA_AHB_CLK */ + 0x0b00c, /* GCC_DISP_AHB_CLK */ + 0x0b02c, /* GCC_CAMERA_XO_CLK */ + 0x0b028, /* GCC_VIDEO_XO_CLK */ + 0x0b030, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sm7150_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Disable the GPLL0 active input to MM blocks, NPU and GPU via MISC regi= sters. */ + regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); + regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); + regmap_update_bits(regmap, 0x71028, 0x3, 0x3); +} + +static const struct qcom_cc_driver_data gcc_sm7150_driver_data =3D { + .clk_cbcrs =3D gcc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm7150_critical_cbcrs), + .dfs_rcgs =3D gcc_sm7150_dfs_desc, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_sm7150_dfs_desc), + .clk_regs_configure =3D gcc_sm7150_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm7150_desc =3D { + .driver_data =3D &gcc_sm7150_driver_data, .config =3D &gcc_sm7150_regmap_config, .clk_hws =3D gcc_sm7150_hws, .num_clk_hws =3D ARRAY_SIZE(gcc_sm7150_hws), @@ -2986,37 +3014,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm7150_match_table); =20 static int gcc_sm7150_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm7150_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* - * Disable the GPLL0 active input to MM blocks, NPU - * and GPU via MISC registers. - */ - regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); - regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); - regmap_update_bits(regmap, 0x71028, 0x3, 0x3); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x48004); /* GCC_CPUSS_GNOC_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b02c); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b030); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_sm7150_dfs_desc, - ARRAY_SIZE(gcc_sm7150_dfs_desc)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm7150_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm7150_desc); } =20 static struct platform_driver gcc_sm7150_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CDAD491583 for ; Thu, 24 Sep 2026 12:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251724; cv=none; b=W/1ZfyLLtRjfE0PHoQNHwjkWq7lZhEM5UNCsKfDD+FmBKR6WzMwdROHbQW9HTPVe23lrO8/p8Q5iG5i/Wi7RFz4SGl2RLE+4T+MYDs29AT/MHMe6tSzxtapmW/7oI+lUZIearLJPrpL/x2w2HgJx8+k4p9OPBz5rjQelfmb6HsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251724; c=relaxed/simple; bh=84OKeBrl3IKjvgDlfAkMLCAYo5otzVQbeGYjLU1sscI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R7LMwbqWzrF7csgjbPem1YlGFvbOIH0zv/nZldZjNFetyQ/+B3puYhP4Q/6B+pE34MV3ljmIw9GTcEGpaq+9wzfims0J+ymXCZiwBzGVP6oBjvT3Ar58DLSRmjI+uNj7XQGfpYtT9fNypMyT18n37MMOPwnoGEHobqKM3gFY0OE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UVfu6Va0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jRsNCQxa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UVfu6Va0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jRsNCQxa" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4Xgx2285456 for ; Thu, 24 Sep 2026 12:08:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qWFUUAsjl5pE8emDfliUkXbUsV2Ad/7MODHAHrTzKFA=; b=UVfu6Va0qsfxiTRZ k65zqf9wk7JX9BlL45pe3+pcFWxTg0ML7qV5+Om1LP8zIcT5TaUnwh+t85gkFd9u kHfbkspw9MoORmzXR4ejI2mVJDEi5/GQxn1KF39hlF18/ftcxwfwUTlmxYMogfki soIIUfMH7Oih+dEXqMX36T86CWoeDynIBGvSYRhV07QksaKN5qQyZGP/cB0DcXR3 hndLxJI8rqrfdDa2ZOO2/KuCvQlqBbd+GzVm+6iK+3uBptpwdFKKxhb093L4LZr6 3IQvhoag78h7qrV/3GPgmXzs788QEISYnQu+47F+A5osswHPdrnO326/0wRzhUJ/ rVHQrQ== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvx8ahgst-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:41 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9806756ea40so1527251241.1 for ; Thu, 24 Sep 2026 05:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251721; x=1790856521; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qWFUUAsjl5pE8emDfliUkXbUsV2Ad/7MODHAHrTzKFA=; b=jRsNCQxadKq//hZvBwGjOgwGpx6P3PAhlTnWiRB72mvKiU4nB8Z+04+XIQ2nLVwgGv k0OLSSBisAQDgCoGrnx+qW6EyBlZEpMyBLLA9CcImcQc36MPHIJMXCAJtGgay0p67uxm u2+rhdcMT5wf8vAELFNJR/FmwZTLOZang8G0RdgpEuDDA4tj3mI/OnVaqQO2wg9LN/jW uKfrqJ+dZWgWo3j1Fa16hNlhXjDJSeDPqKX1S5ztS6gjImxxS1cHWAjuWnkYClhVNbQc jb8x5AVoiR7FpFYOX/vnLukVcMdREI83wMhxMTCYmQkhnl+kv0kUvtKF8vwh1DpTNmdk mKVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251721; x=1790856521; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qWFUUAsjl5pE8emDfliUkXbUsV2Ad/7MODHAHrTzKFA=; b=t42unZ+JXXwz9bUyxCLu7GHEgOlVbXtqIdRC0OvL/HkjJ9pTOKzFf4lsaqpjH1zP7Q C5bu76brooAAEraljUs7DocWACuitIu/RGoR77GpRZAZtGlRTCCwHLQs29yJGBHPpUaS syPLgAbJk5bn01lPC/uLwGvKaeVv0pHDI5Tccxhwyq9jOt7mP5pnwXWn9D2goAwPdd94 gjQL5tWDwzPMStszEgPPwD6udK5Y9ORPy2j/ZY5rDyYZatZb9eaGvVCfW0/O109cb4Tr eS0J15vQxNaeHGkJvy13CQxReEumKwRLIMnsN6jruoHKoML1opsT2T0e4AsQ5pkd+iWH S3Ug== X-Forwarded-Encrypted: i=1; AKwUvBy9j11AyW0X2YqNibltJMOI6oY0fhIjzfVKxxmsWhkg4Z6sYKcGjMKE8j3S8HYMfk5UuncSHgsI+bo3B2w=@vger.kernel.org X-Gm-Message-State: AFuF++nU2uzF7owY33CWCRun7ELzv3oK2Yj11jcAQswrzpO99CVx3Dvw 1CM03o34vo+sdMil87HWzdZBR6hfynhkpLV2Zu/L1PeyMTImRVG2cTQ56AXHGMvvoEcHSej0qA9 LxSosAB/0MmlXRB99FkPotc9hegffjbi+P5sNqLAQoUA0G4+JFZgDsayX3DXsu7Y2wHY9vVRxYk k= X-Gm-Gg: AYBFou3PQgVTuExKH9N6PzZql5YIbskYCGwwY1zP+fN02olI/t57iQ38RPefm77LnGm 15BCWMj57/ofmC02kg5+lXrrNUKFVZ3/ky4t81b09RQbXWB1YtF0P0XaOWaITxB+7UQxRFTs1ao 4yPbnQrXN+CMPxDNcQ8kYBk8G5xF4gs78Sxtvd8LnkiLUjL2Bqrn5866S+7jmCpchs2Fm7in6ky ijHrEHD8D5MPAMo64oe9AaAB/nLUlOwtLRI86ci8sS+FAysTVVxoNH4Q2TIioxjzNl9VzviDJHv cc10Awb0L8hHivaVoWtOvZW4bMugCGBuJJyGlpZWhcYMktmua5odpQc5QX2kzgtvddGqW7ZCBQI YxqrO0ZUU X-Received: by 2002:a05:6102:6a91:b0:7a1:f951:664b with SMTP id ada2fe7eead31-7af1e4f29c8mr1102719137.18.1790251720403; Thu, 24 Sep 2026 05:08:40 -0700 (PDT) X-Received: by 2002:a05:6102:6a91:b0:7a1:f951:664b with SMTP id ada2fe7eead31-7af1e4f29c8mr1102707137.18.1790251719853; Thu, 24 Sep 2026 05:08:39 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:38 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:41 +0300 Subject: [PATCH v2 29/48] clk: qcom: gcc-sm8250: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-29-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3702; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=84OKeBrl3IKjvgDlfAkMLCAYo5otzVQbeGYjLU1sscI=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJdiZ4JZw6hkus9b6St/w9UqB8+37EHfB0mK RGhP0IriTCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSXQAKCRAbX0TJAJUV Vt5gD/0Thh+OvJ2xvWin7MMA3ulAj61Ey+b32ZlHNq7DmO5Gc3+8M2z3O5utFjZ7s8mh0xxs7/g czhvKyuihdoeWWvv+aJ70VH6KTUMZ3DeZYk+bkrYPOkkRlwbK2BhF2F7lzaa+2+DKpKXvlFjZTJ L3A6D1icu7xnPbKYxPylP4absR3L+YvD3hhM7CUpp3opgRP3RslGQNGCw1pyHkAzXBYlaipG4U7 qpxMNyO+dAmkwhQO+9uJ0pAgQMVU+Q0D81k5Cel1dUm20qjk/so2goaL/Z3/KD34s7rRN5UWrdi EGmJAnqBT3cQsnVEQLGZuUmzMst5uV2p5AEv00a1aec5sPKFBNvkrfCgHkGF/qWsliY8crJVSNI s+9MRjMAcmxryIJ/2C2IuAwShOOYnCahAGwNfCBBhMJxkFNqTsMOnNgxpKakDo0GxuljkA58Tne pUX1YSmatFNDZ+Ih6QwAK+CEmREz5flR76Z5VgGrErzhOHYYTleDbsgO9OqSOvjKJeRtjoUavKY FPGYD9spUV/cNJXlkaEIwEfJOYXuhooo154kKHExd/kXdIyhm5uiDXczVdc64EVVqWMNWEHb8Jx h49RDFzgycyrRrk/JLtRJMGOgi6nGfqyBv22UqdFDHahWJI0Bg+kIErJYTV5QqI3Ugwy9pnd/fZ EDiM/Rc4p9D+kLw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX8J1G8J8/Jwin mVieZfv+bISMGTqpi43rR6xY9AFmwlDZvxXSJvLbez0y1gCOJ56An8sXquCitMIQzpVRK+9v916 Zdk8jnBy1xLpa3+zBivlkMTlol1f6Cg= X-Proofpoint-ORIG-GUID: Cb1MkGindMrZubyYC907-B6MeY_-DJ98 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7DxyFWXOFwDa wCMnyL8UwPnUlTs7lJH9pH4Qmzs7Qx6ixv69VovGxUa7rMhf2S9R1naK/PO0tBFY3IyGHwxYYaR qIN4nQteihhub7jIw7X+300vLGgfRUV1k9cP/dzYc405CPfTnhXeug8RDTyu+0FlwSOHqwS2cL+ jhJ7rq72PVVl8ItqFOwCc24PwYHePoacryQTGcdTjjFgFPuFLL2TPHI4tPu5Nb9Pr3zQ4vnzLml U3ZTP0lGW0k/Xfwc76mrvrUnine4nKlxGCejBUK/cT9S24pjG6qRkvYZdaohG+cwJNfBly6qFc+ uPY4Vb02zO4/vqbUBvHMuXTjHD42BrXGK3zAX4ysALgM8w+McJ0V6ddf5RwyM+jouukQ+zdXgUn lGjCKvAVZLGUMQPDZoqmB7x5WJ6C2tjwtW73OJZyQCVN8TsVod2+i0Xhnu5+O84NCzwiOznhlJH IfXwdbvJ1PpX/JuI/HA== X-Authority-Analysis: v=2.4 cv=a6SlZkSF c=1 sm=1 tr=0 ts=6ab512c9 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-GUID: Cb1MkGindMrZubyYC907-B6MeY_-DJ98 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm8250.c | 57 ++++++++++++++++++++++-----------------= ---- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c index 93c1beacee01..7ed7876577d1 100644 --- a/drivers/clk/qcom/gcc-sm8250.c +++ b/drivers/clk/qcom/gcc-sm8250.c @@ -3603,6 +3603,15 @@ static const struct clk_rcg_dfs_data gcc_dfs_clocks[= ] =3D { DEFINE_RCG_DFS(gcc_qupv3_wrap2_s5_clk_src), }; =20 +static const u32 gcc_sm8250_critical_cbcrs[] =3D { + 0x0b004, /* GCC_VIDEO_AHB_CLK */ + 0x0b008, /* GCC_CAMERA_AHB_CLK */ + 0x0b00c, /* GCC_DISP_AHB_CLK */ + 0x4818c, /* GCC_CPUSS_DVM_BUS_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x52000, /* GCC_SYS_NOC_CPUSS_AHB_CLK */ +}; + static const struct regmap_config gcc_sm8250_regmap_config =3D { .reg_bits =3D 32, .reg_stride =3D 4, @@ -3611,6 +3620,24 @@ static const struct regmap_config gcc_sm8250_regmap_= config =3D { .fast_io =3D true, }; =20 +static void gcc_sm8250_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* + * Disable the GPLL0 active input to NPU and GPU + * via MISC registers. + */ + regmap_set_bits(regmap, 0x4d110, 0x3); + regmap_set_bits(regmap, 0x71028, 0x3); +} + +static const struct qcom_cc_driver_data gcc_sm8250_driver_data =3D { + .clk_cbcrs =3D gcc_sm8250_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8250_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8250_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8250_desc =3D { .config =3D &gcc_sm8250_regmap_config, .clks =3D gcc_sm8250_clocks, @@ -3619,6 +3646,7 @@ static const struct qcom_cc_desc gcc_sm8250_desc =3D { .num_resets =3D ARRAY_SIZE(gcc_sm8250_resets), .gdscs =3D gcc_sm8250_gdscs, .num_gdscs =3D ARRAY_SIZE(gcc_sm8250_gdscs), + .driver_data =3D &gcc_sm8250_driver_data, }; =20 static const struct of_device_id gcc_sm8250_match_table[] =3D { @@ -3629,34 +3657,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8250_match_table); =20 static int gcc_sm8250_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8250_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* - * Disable the GPLL0 active input to NPU and GPU - * via MISC registers. - */ - regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); - regmap_update_bits(regmap, 0x71028, 0x3, 0x3); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x0b004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x4818c); /* GCC_CPUSS_DVM_BUS_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x52000); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8250_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8250_desc); } =20 static struct platform_driver gcc_sm8250_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47B7149219D for ; Thu, 24 Sep 2026 12:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251726; cv=none; b=VFOUxDDKd/AQiijyQuqwFL+wbCqpocABICc0fEfcaY2BAiEzqJxSphfscNkyjCTc/0NV3IUdkRqXX8WPDB2mLrxZSkTqUya63hqetbM6OrqEIGf1npOwwrrCkOIn63GsDLCMGNr78J+ZUcOapYQp3rbSf9gDpilB/tQ1OcjRXmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251726; c=relaxed/simple; bh=+dgVDoyuNZIJW/FkhRhEZTCDcKbKOL5pIR7Lq6zXtMs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j0L2uDs97piv/nOGUBr9NumF7DKPC1KWrZB2kLTUMAglRFZ0WaaHvGfA8Zwh0MSxSUD1abjZ3e+ZX98KmgqsZGr+7dYCVmb/nLESww1ntjLp/FTMJzY5scwAG5wt/EyGPXiSZ0lb7QK6ZHsH4GWdIXVp7jbIi2O0nklQJnE662w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rjd4ibLc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G0jhSfN1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rjd4ibLc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G0jhSfN1" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4jiC2285740 for ; Thu, 24 Sep 2026 12:08:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TqzuSoKOuC5OpDZ1aiqB3JN1ideQiCOXQ+R/xa0Dz5w=; b=Rjd4ibLcnVFjDnEw r1v/20USHfsauFW6l9VcreEWfgvosymNt4vpJKzv4ddIJU6tdYoS07Oc3ZYBWY4I jEzpfPlrpu61VdHXyoH39BiQH9Bk7PYefLCDIAl0Az4HywLZ6J3pghs5B2lA7hAi 0dnUG1zK4NRVB98nsUhtvUOqZ2tIXq2WQ/r1I2xVd3SqYHOtymQKsXxs8dW2sMS/ hnyb7T613HBG/H9nAbIucYi4MlKQbweJhf1L/R8ChUoNy+B02VsuZ6hQZBa5tZ+T DF/gFbF5TlLg+kEvO1lrlYhMJjgBPiX2Zt6OxRBf2OpCfQFs5x0t3Qk8YCucmTme 2xxaeQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvx8ahgt2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:44 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-78350646d7eso795970137.1 for ; Thu, 24 Sep 2026 05:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251723; x=1790856523; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TqzuSoKOuC5OpDZ1aiqB3JN1ideQiCOXQ+R/xa0Dz5w=; b=G0jhSfN1kL9efWpzI7U1/rHGTYH2cYAEcG2v4AatpdKMq8v15HeW/sEz+YQLT3lqJ5 PLprs7Tl5RibtDSBFT+eipW+d8YtdHnx8x4UQNlppYD7wYoZLjWY+XRXPe1ZvnYhBYQx OFp6qHxfr0fmHzRhe7gbnj6PcfZE7O6GEFf8nn8dh6Daae24NxxZaCIJS0vFj6cBNU9o gsT8SUtrMqIPAxlxmUejrM+1kjy70/8sb6n9K77de2czKhh0JrsT5gYco8+YGEGVncbB FtF7ZV5PLq2MApdgcNlvD3OjxheuU9JfUE7kD5P8f4dSJhRaGcjIJ29/bYcP5CupmANG SVOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251723; x=1790856523; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TqzuSoKOuC5OpDZ1aiqB3JN1ideQiCOXQ+R/xa0Dz5w=; b=oc1+9/R9aTG65tTg1WEt3LVj/WaiRL2DuZTGK4g5+Ou3HpzYaBCuZ4VJvIxOKE+9rt pD2zWAz+1kcRz0Crrp+ByJoW6TeKVfHo8pm6h0iMFy2Tz9jpON7e3SMad7pmIragQBZx rDxUDF8ON47DVlCaB6nE/bnYuT7pLAEBO9yQjHQ4Y30GkHAZZnf/HuNmYAX6LMTpi3WT Ro708FwNWPHV2FHvoeKKy6DLjmiaHAJ39gbS/AW8M5g3pB9QHLZxR+rpnBhdLcUfsbmo I3LAi2Y3hU9HjNoyI9cwy4OGRgUbnMfl9Szgtz04lV6BaW7MH/yZjeOetsWu/0cUGK8A x0AQ== X-Forwarded-Encrypted: i=1; AKwUvByxrFGtStrzS0iXQ6U1eXKFbXbSw5lfdAEA3p/zGCW3QDIKE7wXtj5PklZqCigxR5WSmvlnHhehnpkd5/0=@vger.kernel.org X-Gm-Message-State: AFuF++mfkF8q6HW/6LWgF/uNzVdXSNbBM+6WCgLuJZvqjwx25FWu3GEy DGgJYlCf/OeI4CUJIqsbKQyJUPXyzC+/C8gTuL8z3byroj1mkweDRdSx92FF/GAAq91gHIxqxBj 5srKATdbDG8r6+6GBPvo245Pk4lJk3SinGtTq0Ks22YTX9yFX3dJvsCBWuj4DZpfYimc= X-Gm-Gg: AYBFou2kiesDvuzl8B+80DNgsazoI4RCfzxcBNf9fCSVBIDZpqw3yJstBGxeBrB6KBa anv4sirXyeFnWY0V4thEbn2lDX+dJYHdW2boQoobAixyixhDD4DWMQgkg5nhMEhzxwlWJc//Gb3 yZDHsJD/vSJyGweoA/sQZl2IZKv7fAtyIwUgsZPgS2g1hFfzY234MA0D4I3LV1Scz5i15aeTOkf VXTsOD2hRTcLeN2xWSSOYPCGBXJFeEkVJRA/6JpBVCU4aLnB8nYb6OiCv5QiDTCDgwgo2EbR8kC sx7mvKYclK+mYgFy08aZmLFx/80qgjdR0mkxw+fFCzT9sAC1hb4MqO/WnZnjIFiHTMm4i9YzqS5 YiHwQz6u8 X-Received: by 2002:a05:6102:8681:20b0:7af:4518:2084 with SMTP id ada2fe7eead31-7af451825b6mr486962137.44.1790251723331; Thu, 24 Sep 2026 05:08:43 -0700 (PDT) X-Received: by 2002:a05:6102:8681:20b0:7af:4518:2084 with SMTP id ada2fe7eead31-7af451825b6mr486952137.44.1790251722792; Thu, 24 Sep 2026 05:08:42 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:41 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:42 +0300 Subject: [PATCH v2 30/48] clk: qcom: gcc-sm8350: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-30-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3273; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=+dgVDoyuNZIJW/FkhRhEZTCDcKbKOL5pIR7Lq6zXtMs=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJe7Yc9vi1dJvukkcXGV1liFr0y/YlGHs+IW EbvJrNQbJmJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSXgAKCRAbX0TJAJUV VuK3D/9u4TkCpaYeg7nqbUJ34vtBumbuOrtB9OWGHSA0GB22ghIPS0ypd1tw3wGJZZm+nLKei3f pv3A20nZmOde1l184U6gWYJfON1HEujD1/IQPAZOKQJHtfLltiXiSIU23Ta7nk5Rwa0041wm5vD ob2TcXOJscq7Reb0b1vpUAXbgPjqQ5y53Z4luj+eebHkQuAC99kMp15+LdyulJo07espq/Gt8fh hiuOBWoezL4Za14inT4FPEH6o7LTPJ45MyyKM7DH5OaLIV+FdQEldHIezum8NqYyn7S4z/N0LMj J6/9MDwQwFGsbK/8h0t3Rb5t9P8c1MBaaKS+i+yAMW9ElYiozyLlGX8ZMOm3V1GEe2OdNb6dDnK c9xyVJGHhG2WbI36oq4AUKD1b/WV2fZd0dWgVpidqigu7GsQJBr55ASUaQpr2xFXBWicb+/wWfh ItDGookeI4aL4otr/P3Cqanib/Btixmf4l3mvBiM3+0OG8Cc2ap1WptPXJDrpE8l24s4ZXTuC2B oLu+Kg7aKycMOsRdxDk5d01ykJJCghwt1d2udFWkHbwyIh6eTcCWN66Z39kSmWHsmqB0j/oiE07 7z4oLXzq1BHu63CXzcg3cUns34Tn65/itxF56JJpENubCIxsPUdNVNXQlzrgtK8cWyCqTdXZ1pP QsJZefuM5Z7OcOQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7UCrTfdQ33U2 1MNBfp6Z+1TIE54V5GYbESi4OUul2Rm+ZBVOgfLBsfGV0t0TOpl2SUL2Dl98SUpAhZ07TBJ2U4+ +s6JSht7aFf65jb7Kz2cUFvMB/zbweA= X-Proofpoint-ORIG-GUID: 3CdgrRpKJg477rOQdD8zn2BuZQexvgJP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX1upladv3uxWB liPpyObLBqzkfpUC627ytL/5ccq0xFp29L9U4LqjTRZarHlqpBArvn316Gxn/9uci8NXPQG9j01 ikn0qZqoAiECgnoSq7fE47keN3U/e/yM+xrq+wJsSS5tRHCJVni09TFGKr16JGZdCDPlstvnIhK uYBu3Y9hXDfYEy2es8lDQv1NmV+v+nGkVKIpUzDfkP4qAZjVBRibWLjVtbBIKuZSAJ4ocsZNvWa kZQ7it59SeYjmbFTb9Ve7z00nvGfxEtjISOociI50viZ2jRcidGHvJOPp4MaGKw36uhoPLzXkGL Syuqdqq/R/2Iam+RGY5EnnTtOuWgvZ36oEOubwy15mbdt5q3LH6dha6F0TQNL1bO1BV4Av4xVOV zh/dD1nRlNxUiwFmjsxSN/VJZS+3SubmBP+Vu9IwBEg1QX3UdYmYVsVBTnEiJOe6BPfn0MtHTjl Jcs4hVZ3y8MA1IqQsqA== X-Authority-Analysis: v=2.4 cv=a6SlZkSF c=1 sm=1 tr=0 ts=6ab512cc cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-GUID: 3CdgrRpKJg477rOQdD8zn2BuZQexvgJP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm8350.c | 52 +++++++++++++++++++++------------------= ---- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8350.c b/drivers/clk/qcom/gcc-sm8350.c index cc6eb7ca9c03..10a944e679ae 100644 --- a/drivers/clk/qcom/gcc-sm8350.c +++ b/drivers/clk/qcom/gcc-sm8350.c @@ -3779,7 +3779,32 @@ static const struct regmap_config gcc_sm8350_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8350_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26018, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x2701c, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x28004, /* GCC_VIDEO_AHB_CLK */ + 0x28020, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8350_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); +} + +static const struct qcom_cc_driver_data gcc_sm8350_driver_data =3D { + .clk_cbcrs =3D gcc_sm8350_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8350_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8350_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8350_desc =3D { + .driver_data =3D &gcc_sm8350_driver_data, .config =3D &gcc_sm8350_regmap_config, .clks =3D gcc_sm8350_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8350_clocks), @@ -3797,32 +3822,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8350_match_table); =20 static int gcc_sm8350_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8350_desc); - if (IS_ERR(regmap)) { - dev_err(&pdev->dev, "Failed to map gcc registers\n"); - return PTR_ERR(regmap); - } - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26018); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x2701c); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28020); /* GCC_VIDEO_XO_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_d= fs_clocks)); - if (ret) - return ret; - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8350_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8350_desc); } =20 static struct platform_driver gcc_sm8350_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C6D4825A1 for ; Thu, 24 Sep 2026 12:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251732; cv=none; b=nicxyumvF1n+XXVsdQwvMcgkoidADZXX2D0eqpckJcuX6EIsmSsuGfgn/qGa7qY63WQkj5gyAQruF8F4NICdjt6pEbwa0hPq9UURYy2ToPypNbRX3NyiL5SSTuUAuzcZqLyNPmO5Sh/Slf4DyDj7lDnjb6hw+zX/57bWHHlhf3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251732; c=relaxed/simple; bh=itpF59inKHzgDkBngB80YimFpGhVlE9Sl453Da21Iys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s8J68r6CjVPFhYdXC9rgM0ZX7tZkDm6Q8ReuH/vfda4XqA5bwfwu6cqU7Nrf7V1tRI7GdnosD0rtAg5ldpnjDJaOQCDn09z59Z9tucQI57lCAFKr+2R6MHZzT36QGFJe5NEcvC9ZdMYxnFV6APncjEFuFE488TP4NtNbZAYNJQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BOphyTaQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KJtQTRA/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BOphyTaQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KJtQTRA/" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4t3b803928 for ; Thu, 24 Sep 2026 12:08:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v/AmL1qeks157TSZFSYxIg5YHYwxhYYKw9JDPqI+Llk=; b=BOphyTaQ5W0DdV2G AmNgmaT9Q14y7p2kLPynbZN69+XIXgltdpIJUX5MNh2+bDQYISHsagD9OPwYswKh 1hxOwkemt91ipL7dnggrxtKng3hkoGgAOdpoujk4LIDStibAbl8s/TpEVT37gNr6 KCAiCnMsK0eiujoEsVJdvVuef8adbJYhygLEO1gsAUxMHh9rAsBePVwqftlFm71n LziavCRV+bxB2Tv6/4ohFdto9P0NAp1PxTMmuTUP4XfrJBU7sWLX50s56VpV/RrF BRdgARMaQJwkRc5/GrJ/Y0PaV/FWHcbqfC+x+2q/cEr0ARXcjDEmO/k1vOtr0iXg bKstZg== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8f7r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:49 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-79cdabf7d89so1827889137.2 for ; Thu, 24 Sep 2026 05:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251728; x=1790856528; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v/AmL1qeks157TSZFSYxIg5YHYwxhYYKw9JDPqI+Llk=; b=KJtQTRA/hd/euyYOLDIWf6akkdM4OqkP1Yqb3UEQFfJ5ZHoZFjuTMBNjTWe7RvEV8S fd0sIMEqxBno0CzJ7aay0GNY8P0L0sSABQgtwdV5eQoiME+lEQ0Yf0qJrJvDlrDUbhG/ U3DV7W4ZjSgjKrCmNNT/uG2ap1Wg1TdYPLHomR4G+tBVE3FzhtmAobz+H1EizU2KSk4W aN4X0EYfkymaZ5MmpQGzRM293+M7fHarz5wNAT6u7IkaBWQHNIxBmyVfDL0eQ+wuPLua C6VLv9HsVUFB6HBShfWl2Jzl9HIB/1qfMngYOhDott1FEFwTFLGXp57s2atoPGse6vAG Ek4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251728; x=1790856528; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v/AmL1qeks157TSZFSYxIg5YHYwxhYYKw9JDPqI+Llk=; b=HsEYFsgESvIAUiD36rBq0mgyuoAOJ+ucIj8Rk+uHRDFqrwy3yh3aqEmxmzJyKi6NLI 9gv0TeGYpqpvfy0NJlQoyle63H1TfHR2C1PFQ89FxmZCiKeKeEobsLjZFW5YwJGBZiOj tdcc2ifppDrGsSLVCf3zMqCSY+Xg86j5JoTDDQuWODSeTCxoC3xyFrVEMjMCBVSVhrCX A/5kMrxfaR5KRTEKMFTwlux537gDFba0rAYXbY1VCHrgo/9SeT6V1w1zZ92Dq+xU2m8l XgcjWB5n15rYZ7mYHiJX8tEy0uyYFt/hXJIRsnpQ5pm5j2/t21VlpzzW6xTE9Vq8eAV1 8N2Q== X-Forwarded-Encrypted: i=1; AKwUvBwl/a1/TX38Uz3Zn6BxdTrPxkDFVzNqzPSC8vQF7n0wE5qXiHJiaNjaKORC9iTbnLFgJzQlzxrzzKti098=@vger.kernel.org X-Gm-Message-State: AFuF++nWV/YqRAufCPSAbpfmodsPI9otliIn8JchhnZ9iZBs+AHA9j/k ESDBxSuFIaB89GmpaBJctJagG2KHwlQW4jjaUxGaF4FviF98qocTHHgbpZSSiTN/n7YJV1wS+SN GrNsQCxosSb23A+8m+ihwSI6JbYt430LiuCGOnsYhfTCX3Ul1AtudSn++Cz/BVomnu68= X-Gm-Gg: AYBFou2VFhp1m+pfq5VvWD/CwTEDocljJEOktw9x9ChvOJHHhVxChOfxbzf9q51tfut sQKa2x7a6poIMelJJAPMq9NKObPTTKxKLkfEomStC2euSsL7CHzIm+XAdvLBrvMX+C+xfcIChXO U1ih3BNKPthAMXzMKNPCbFrRfRPT7dDbZThbEd4FbwRE7ntfXWIo6Z41wHBa87SsswQw9dwDi8Z +eJiSMYw60bBM0GSDT/K4k9U/ePZuwW687f5ERf+Ojgq+2rj+oOspGQYPM2oNhN+kmTDj6XYO5T 81uFD6SZRQHxZR96IIe8rX1IjUX189LDktjkVK6wVJt4kjVUyeP2u7QN1uYFozPsL8WEqmcmliR 0dDsNP+t6 X-Received: by 2002:a05:6102:e0f:b0:7a6:ef60:dac with SMTP id ada2fe7eead31-7af1f2087eamr1287428137.34.1790251728211; Thu, 24 Sep 2026 05:08:48 -0700 (PDT) X-Received: by 2002:a05:6102:e0f:b0:7a6:ef60:dac with SMTP id ada2fe7eead31-7af1f2087eamr1287410137.34.1790251727615; Thu, 24 Sep 2026 05:08:47 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:43 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:43 +0300 Subject: [PATCH v2 31/48] clk: qcom: gcc-sm8450: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-31-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3882; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=itpF59inKHzgDkBngB80YimFpGhVlE9Sl453Da21Iys=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJfnIn0DOkqZ9hx2Rt9yTHQ/K9fEAgisnZ5a ZvW7QjigaCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSXwAKCRAbX0TJAJUV VnZDD/9+jEKTLVylVIGgW17UG08W4DTKq0yzJXk6KnuJPDg1gBLjKij3OXAHsrn73cCy0P+dpYB 8cLnNpbTbt4xJTeajzmhEMKaHeBDUFaV3QKwagT/Lxyf7iKhc4bm8gQ9++TTg8bAWovi7/l9IbE zrtMcj+ZAMzAA8BI6T12tDrF7uUxfAu3P3Lg2r8FPTNJM2Uds7TD+xgXRTGgxPdHlLRzC21jRKT 1ceYknCYSKhsAzIQaqByvUXljFABHWPT2EPPjBAMawfNTSwv4QnEoK8aiP3Y+YgKZEJHehE/vEf M/B01f0343UBudAHwSvYwwD03+FSPLRd85gsaKqBZ0rkLrhVTXHwZhRcf9hejb0UbggUJw2WQQZ rB5f3c6UNrFngXwZ2+C4vY8cMNW4oF9gmz69x6Y7oPtfIF+w40CbbhEuvMrWeyo8+2xHcqozIzO hdO9T/bENWIWjs4Kub+IgmGtThi2inP4q/OjQLXwmg+5+TTVzqJu2aw0MzTRIrSuz9aEmftcBt6 +5RbzTOsFT3L7HjVuBQM1xTAszD50dvh4FKrH3KT+JrI4GwNl7kM2WucH6Tl241AgTNDXoLJ0gX fKCShvQ2lsnWfSkQqgy18ngdpKyF792ItjsVwA8jFhsJ65gmQ5pw6UWDrNN7PkGD18rJNGyH8JJ 8ThYLCNZzZ99LUg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: EbOYIHW0IMijzPwgSN8fQ3p1f7MTScnF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX63PVZpR1Z9WM PoIJtT+v1rhmlVPLJAIpOejnhMUokRnZ6qMHCEnTYQDnc8bU9ZW5/dF+3A8K9ajVxYlEPyMAtZi 1HFmunxWkt5+h/QVC537+GkVB/6OjPOxG7uzh6/XWyBttF9kboeVDRbr6NYdUjVeF78+gWLoWuE WVtxdhjUFOLiWiZUB4LbyvP9YjIVfB9niltTrKeofS7zX1uvWXLK3RDcZ/Z4jk5FF7K/4JSoh8J Kfk9J9Q/cTlo2zOSd18+Nmr0+gnW0vCXmf5MJ2nXLQDf47wxlGmCtPRFRvA3cZnK5xYJbMIkDtC Nn627CTv6CBbmR0o/4qbZd+MMyzCzPbKa0u1iDi0vwzhstcHSer8+1MRRmwWxlac2rzGnQH33fD fVdlbWNDJ6EsGEN2qpOS+19sdFtwPzn54fKwPzygSbMe5DeTSxHMgmMP6kfsrd4T2VYKgyk9xti Pi4K48AwdZhW8G47UPw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXzQzAriY8ymMS d4D70c+mYf+hNuBbFnRXEQPY5GMsEv9j5iTGxEIdWNikHmHv82PGJJ5PKJ3bzlicWBy0sYKciSJ KiZlNoGPa/D2XHHLLkhxKdZIUTAdhr8= X-Proofpoint-ORIG-GUID: EbOYIHW0IMijzPwgSN8fQ3p1f7MTScnF X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512d1 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=39i0T9gdeGRrow2g5OEA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Move the UFS PHY ICE core FORCE_MEM_CORE_ON setting into the clk_regs_configure callback. This moves the UFS setting after the always-on branch enables. Those branches serve the camera, display, GPU and video blocks, not the UFS PHY ICE core clock. The UFS setting is still applied before GDSC and CCF clock registration. Keep the SM8475-specific PLL and RCG adjustments in the driver's probe before calling qcom_cc_probe(), which now handles register mapping and the common initialization sequence. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm8450.c | 51 ++++++++++++++++++++++-----------------= ---- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c index d473a95bef92..739e567462da 100644 --- a/drivers/clk/qcom/gcc-sm8450.c +++ b/drivers/clk/qcom/gcc-sm8450.c @@ -3392,7 +3392,32 @@ static const struct regmap_config gcc_sm8450_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8450_critical_cbcrs[] =3D { + 0x36004, /* GCC_CAMERA_AHB_CLK */ + 0x36020, /* GCC_CAMERA_XO_CLK */ + 0x37004, /* GCC_DISP_AHB_CLK */ + 0x3701c, /* GCC_DISP_XO_CLK */ + 0x81004, /* GCC_GPU_CFG_AHB_CLK */ + 0x42004, /* GCC_VIDEO_AHB_CLK */ + 0x42028, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8450_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); +} + +static const struct qcom_cc_driver_data gcc_sm8450_driver_data =3D { + .clk_cbcrs =3D gcc_sm8450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8450_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8450_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8450_desc =3D { + .driver_data =3D &gcc_sm8450_driver_data, .config =3D &gcc_sm8450_regmap_config, .clks =3D gcc_sm8450_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8450_clocks), @@ -3411,18 +3436,6 @@ MODULE_DEVICE_TABLE(of, gcc_sm8450_match_table); =20 static int gcc_sm8450_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8450_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - if (of_device_is_compatible(pdev->dev.of_node, "qcom,sm8475-gcc")) { /* Update GCC PLL0 */ gcc_gpll0.regs =3D clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_OLE]; @@ -3456,19 +3469,7 @@ static int gcc_sm8450_probe(struct platform_device *= pdev) gcc_sm8450_desc.clks[SM8475_GCC_GPLL3] =3D &sm8475_gcc_gpll3.clkr; } =20 - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x36004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x36020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x37004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x3701c); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x81004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42028); /* GCC_VIDEO_XO_CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8450_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8450_desc); } =20 static struct platform_driver gcc_sm8450_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 513C34825BE for ; Thu, 24 Sep 2026 12:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251735; cv=none; b=rC+VmeklBOQyLueLT0t6Jdq+TWUjsdrzcGdTffpW0g+sNGIMxpbJnjPOkMGPXifS+Uv96XN/8PpghV/V2aeKqrqNbJvYRJ0GQSWDf6XTfvUIoP0c/AoeAClP3m7y4q16xN9lPM8G++5IIJtNTxtD1KQTh4fmC8FSUTjCym9LIHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251735; c=relaxed/simple; bh=R+sa37Lfp9ZhGnL08+LTmFtDPjfO1VmCypsEThPMfME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NTF2794kaUNK7EUJ7WQ3h7tRLjH44zHBuhENlfE5sidiPWA9dnxejPs06//2jQoydQ0K0INDsvtjgfRqX3rhLgBMHL0b7p2uOKJq/TgW6r3Dpdl8fTdvWnkAi63QTlqj/5gJe3qOVZs76M2csG7A11shhTupXtWvw/9uzsqAPrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WNMQPHWE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d/WReC5G; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WNMQPHWE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d/WReC5G" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4vdZ803993 for ; Thu, 24 Sep 2026 12:08:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9PWjAwHkd2fIpK+WJk2FO4ElGGZUOCTPP5oU6C/yT+Y=; b=WNMQPHWElJtDhu0f IDIHMOq4wHKpUKyFYxvE7wbENVqTHcZTLl2achEvevUeOifMjrd6CPh8/kFpRKia CCLN+5RVLWqQhKkxFt1LUBfFiGe/u4FxuwMDoZOzxBuWc4h8JoaU/RvFUncRI4oa F/37WVxjUtJHQ5o7W3VAX9Q2gk7HZ7WzSZn2OXcqhX2OPZJqvfiB24lGEAokBkaJ gDU+cG004nmBGPNfNGZ5fvBoKF6hG+iJaM0Oy3CNEfNS+QGCW8qZVCQaiHMVoy8y y4eDs3vaT4iFcRedrQo+Ugy4bBRNF3UTl/Ow9qV001mTpjrkP8dSJy7/3on1EbQw exhcdw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8f85-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:53 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-78d25a8ff32so616481137.2 for ; Thu, 24 Sep 2026 05:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251733; x=1790856533; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9PWjAwHkd2fIpK+WJk2FO4ElGGZUOCTPP5oU6C/yT+Y=; b=d/WReC5Gsd20yhU1EK6wA5VN91k+BaJ8eR1fj9HSE7rNsx4ZUdPz6oCTL/c7ahF7rb blodPKIvB30xYVTvJfhmgOPhuOWbim58lmii0MUhlA1qMkTZgSWBYiTI5WFiJmTI7sZ0 3ZEG+UsgkmpDE0wybh0vO9aLIJBF4R7Or4xY6HIEkpc7YoO2J1i94DRZAUsB9NEmJbSO dMV1fa6wbCiFJZzCovl/SlFXfC9qK66Gn3+RhGqSQP1HDYdmGU8bwUZ4x4+lYDKoyBLN Gm2cF0IOhr1ugoBkO5w84enyQxbx39bY2c6lk3cWAscrP7fC6jFXF/fPWGnRWLujcCyZ OYwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251733; x=1790856533; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9PWjAwHkd2fIpK+WJk2FO4ElGGZUOCTPP5oU6C/yT+Y=; b=jCudl2oqeYPe0oMTYW1pfl6UyArtDsrJzdS1pr8kuOI8xAv8tdy0b5R8k+1nNEfPn1 qb+9EMyXxfLxIgyD4HinlmQDDI/U1mew3ijHw3aVAMCCtQ4YgElCIVRzknZrTGDWx4/X DRj2DO9qj7Y15AbaZiHdWzpYoE14WVEf47CwBmloT6MldesW6V1cRucqt7chgIF2KcLN EJlIl1UtIr2ZgShrX1wbv4j1xW7+PZN+xvAnUxR+4G1DqJz3EVRoqcVzlKQeExc7C3qj oR0uLpuhWvDTuoNxmyAwvllwxP8VMp3FfR+OgNKtwzmywigXe40I11Ky7zI/QuSOeml1 mMBA== X-Forwarded-Encrypted: i=1; AKwUvByufAuTDtxCBYW4gmyzmAg5W1SzL+6phTwgZ6dFNS6b5acAkfUbiE3J5GjMyjxa0ukTTrYIFLZo+qxn6Dg=@vger.kernel.org X-Gm-Message-State: AFuF++l7M9EdR5EvO/OOLUSGOv1hcopGCqrJO2WjHnP0NEAFP3e7PtvN 2a9hpJnfARiUY0bFRsWUmzRanRZbgtkECn02wQ5QFtCYjgGlBnT5/Kts2ZMdvh5DNdX9EOc0zdP AYalm0zaf60PSQ/158rSAnaaSYEoFWXIkmfPlPycb85/s46uGYzgIajNctCxg+JKmyik= X-Gm-Gg: AYBFou1BQpRB76Kr632nPP4YBsdya6g+Iy242fcLvxWZY3ZvNwkdSuYONs81DWzu8j2 4CLXx0C+y14d2F4hPWdsx6VKbwpWngnW7/X1mUvYdH7+aDEonumO1Y8vK8epljx+X4Rv4zEhm+c WK6cE89JCkFo7KzfXWbXVpDkANpdrHZ+knUPGfKNSbI1CQTTuODjI+4GSws46yCJhSbqIi1ozzM qMgqNKEuZVavGw8RYTKXAxWeSWRZ8DZ2r2NPZscejkxCCejh9wgZvu8wBL8/iZaZWN/ucJ3N/mz jCGW5l+cCiBOsFn4Ej3Fhlr9KYasmVZgMbDhrGqOEoZ5Cdd5h4VWcAgjGfpQNj+8pMy/y3Xnvn9 eGRgHjb8g X-Received: by 2002:a05:6102:41a9:b0:7a6:b18e:6d5a with SMTP id ada2fe7eead31-7af1e4f6363mr994215137.17.1790251732374; Thu, 24 Sep 2026 05:08:52 -0700 (PDT) X-Received: by 2002:a05:6102:41a9:b0:7a6:b18e:6d5a with SMTP id ada2fe7eead31-7af1e4f6363mr994196137.17.1790251731765; Thu, 24 Sep 2026 05:08:51 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:49 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:44 +0300 Subject: [PATCH v2 32/48] clk: qcom: gcc-sm8550: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-32-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3461; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=R+sa37Lfp9ZhGnL08+LTmFtDPjfO1VmCypsEThPMfME=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJgpIBZVCFgwFgGC1sL2LQ2A5ZBdfZjxrv2/ 1nsA7faXoeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSYAAKCRAbX0TJAJUV Vu8kD/0SvAzIswWMbPOgjJ42QiltEQ4oraXFhOqLVBNGqGKVXVXX7I3Ge49bPrWz5AwxVrMKoYD Q9VOHF+NMaVZ67eHYTCvgII0lLJOYhnc/KefvvuOuDz7Zywm1YLgv+ouMYUd0wXlwhVOe7slYZj +ZzCKzsiWzQUa2O7yOsAZeBVzsecR/w6PigMK+AsEXeJycfZgbVBaNCUz5EtklLPYOvYvYc7Xj6 XOOyTI3eq7J/ZlhnbwTs34WQTigU/STtFY/gj0SGwFq0OLGjlNmeQKd9Tju+NCy8DErLWveouDj H9DGW1nMoMbuhS6tP+uazqCPacp6lWvbjhhPVqISdqJtr39jjgcgd83kZ4bBjH7EMZ6TIaRCHJn zfBnbDse2UgVmXZCySDLRQBCxXBJbK2bthW+A9dQP1wJ+T622P+zmZDYe1tcOnkJDMGlEQ9US7f 9FjKro3CZ3K/9FcF4/x2NqI+8mku8FAIoBBySLXr0QH7iT9o6r313FTCoN7sFcO3aPITrL494c2 2HH8bKvH4yGNgVGXa0EnIqQ2jpDwv0lEPkGSdngiA4RXTH/3MHW3n1/B3g1N+kWL3udDIsZegY0 xrsW4aHojI9gXkuW20Y+ZXytYLy7hpw6brvfIdIdpKRgcvdv6sbtviltIYZbgNsJNsJagIsBlHH WZ3gI+Kkb4eQVkg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: FvyMCq5RXXk-J3QyB3I5uVDuyACgzKUJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXysMvQoRiB8Bo kToncVf+vTHaAZXyBCds2TrK4myN5KEM+CXdN4Ax8rYryDwMHzAgd62wrtXHtv+XpYz3Mb7gs+B 9kZ7zDfGDnbDj/YL73gh5uW2wQ5vtGxrr3nC7mYJ/Y4l5VZD0j07TXjI/7AWOZHEkEjCFlWuUHw hjK8CiK7+B0gUuLAPimCOtLclYrPyQQlQzjr455lvp0FIRTYS7lS9UG848SffPCfYhBSdDdSrzZ S0vIsHiM3BoznR0puwrdUYU8oK1EL85zvy9JSe5sNJ8rvG09excvH+mdWUHy2yQkv29un+B4aje ZhcBA477O97vrIZyo+23FxBUAZqgQiYY4xnoh18zarfYDeDvpDrjOuFjJZlaL2BcXB/JPFKa9Qy M237bmBA9oXMamkrUbxnP0o5A3qRSgsM7s+3AQDiIlEhT3gC9ZjPz9AlJsuTTqh/GAWSaxmO9qt XhUo/le8QyvgtzZz0Mg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX6a+4GaQryXvt CbkfCQtTh3NfOOzSyr53H01duNg1xh/vkXtyBUn4vdcEiY277Cu+B8VoB+nFQQVUGOPRpD8PnWw 0dF5ASpsUPaykQOA7WuINLm04Nrn2a8= X-Proofpoint-ORIG-GUID: FvyMCq5RXXk-J3QyB3I5uVDuyACgzKUJ X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512d5 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm8550.c | 57 ++++++++++++++++++++++-----------------= ---- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8550.c b/drivers/clk/qcom/gcc-sm8550.c index d83a7bb5356b..2bcb37f27025 100644 --- a/drivers/clk/qcom/gcc-sm8550.c +++ b/drivers/clk/qcom/gcc-sm8550.c @@ -3319,7 +3319,35 @@ static const struct regmap_config gcc_sm8550_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8550_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27018, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32030, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8550_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); + + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x52024, 0x0); +} + +static const struct qcom_cc_driver_data gcc_sm8550_driver_data =3D { + .clk_cbcrs =3D gcc_sm8550_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8550_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8550_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8550_desc =3D { + .driver_data =3D &gcc_sm8550_driver_data, .config =3D &gcc_sm8550_regmap_config, .clks =3D gcc_sm8550_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8550_clocks), @@ -3337,34 +3365,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8550_match_table); =20 static int gcc_sm8550_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8550_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x52024, 0x0); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8550_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8550_desc); } =20 static struct platform_driver gcc_sm8550_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4EF493D3B for ; Thu, 24 Sep 2026 12:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251738; cv=none; b=KIDFTHRrXNGXuOn4aGYbyOKS3APfAIoFQFb15+uSf2FTh1o4l2OdnUrgPZrz3DJnG70dRR7bo/XFTWYU6lA4ERKLSKdE/sr1cRvnAXuW5vLGu+LEEK3+7adNJ/pOHMDjiZPv8u+8vpcCsTm/a7hdRGb5uD/CXxwdW9r5JfOBX9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251738; c=relaxed/simple; bh=/32dUnX3Y9hTXbE2uhZLl9TmWEKzN+ZFCsKbbZqUQEI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ErxxQCmA5ugJhGeXadzbqQrjaUxZrhaaIAXdn1qbeL2Zz3j1//kLMsHxK98gIntH9mD+fmgBiw200K6b53uiuAIbZpTdY9BrOOIF1eYmSiJuN9ISAmpYBrPIAxbyCTzscj3HjuRIOYq1MY08VEBaFIFb3fAuk2Ht4LnFQC9DkAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HIyOuFip; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dx+F4Bl2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HIyOuFip"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dx+F4Bl2" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4t3e803928 for ; Thu, 24 Sep 2026 12:08:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iBI9qtvaAApgbw1L/VNeL4X9l6h2m9dSC8EnLdiU09o=; b=HIyOuFipio7G4vky IEKsm8sM6u+/PBDlcoY5ptujHXReU6kLD1LdmFD3c9qHRVW0eazNjY6KzKvLCK0i WekM5QXHgQmAOpGpjZxOg7s5QmNIvb468kSEHwoAOP+uqhpZdXHDdpa5Gayk76iz FGjHV56Eo1jO8fId06IfQYaTiy1GRPRayT6ukr2T5/J9F2dz2ZamNJsvr3nMTn28 XH/wBzQdBRvTOS1oSXJ6vPuXfBvjVTDB+J3G8/eGEyexJJzTmHtFN6+A+XrbKUzE 5sLEfLcJosy+lMeyZu2/j0ZrwUdBxV9L6L91Y8gh29U3/26ndPSh6aidojopscbe unyE1A== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8f8e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:55 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9832d9be02fso926100241.0 for ; Thu, 24 Sep 2026 05:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251735; x=1790856535; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iBI9qtvaAApgbw1L/VNeL4X9l6h2m9dSC8EnLdiU09o=; b=dx+F4Bl2iAWFgmDJw90/KwU36BxqgwvRdOqL9Qt+/OcOyV08cO6Hr1B36SNjsigvdT K9+DVwjTjY+oA9UetjU5ZLcAI4Pssb2D9ttf7cRoSX7jteC20ROs28A7b17aWtbkelzP L9Vu5cTA6xXnCt82NlsLgOcwVWz8aOXvQ6/S0oZHC6x5uqe71XRHYrcEbMF60acBsEcZ jN7TKJTNe4mvqw/51a5LHFcPR/G6M4912xF0yW4dqKHWRiIm2RBZEzYdWtJuG3VBdtaZ 2Jzb7dj8HZMBetTnC9vk3qKy7onyXiiaYJxXors9ylAISM2VJ9UyrQAUiKa5Igp/VOUE lOkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251735; x=1790856535; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iBI9qtvaAApgbw1L/VNeL4X9l6h2m9dSC8EnLdiU09o=; b=x62iwPQ0/QIU/XgtYya+b6rysI0SeENOcxkqFq+46rXL79p09S/xqvAR57Qeh4B13H iPXDj6SenIYxBe2XEM8GVNXaTrGfNkdpO8yggeAZZYQokqlynhZqn3eOA6zc7MdLJrnz teJuNrFg9Pmb35GjjXFQ5OkfmY4lOJOfJ2Un/kcRFWZ84cby277MKTD/tR68v7TJWoMD pAY2ZldUxcvZTy5ga6fTkeXzZNrdQYhyf/JLE/iwKR1ygeXVvtrySD1MjviP/0XEhEis FG1UsB5Ek0qQRBlrXBs5KS6WZr6Xq+I4Xv46eRRFqSXBZLDEG9Ux8n99L72zyIULJDab aBUg== X-Forwarded-Encrypted: i=1; AKwUvBy1YpbWGs+pnQZwanKnFDEZyexRXUatWEWSzsMl9Kxm1k/ybNSrJsAgbuoyUFrQ8cUMGAIRKxHTqNpua1A=@vger.kernel.org X-Gm-Message-State: AFuF++lgzTJqOYVGCPza4/7afxtAwIb3+Yeygyb8Bs7NOUKPxCWmiYJl iGVIbeMQU0tvYkNjy9Nu8Akv7DnKC0pFSElMnT4wbmvhZUImVawu4Zp0mCyJZvU7mtUGZYbWIFu vQIKcwkBokhg/YVpzDzXO3QxHj+YHJB19qYwl/U8iuXtFFevw3MiyUjkAnzgYmCFXbs0= X-Gm-Gg: AYBFou0ABfqmAw/eGziZbEw+dXa46JF7PCqn0FC+cIsHH6tEV0jdA04WTUCOIaUrGZP CSZTFvraM/LW6f0FClHzzJsGghziW2CezgKVYDuDBqjk1zwvCg+er0LsI+pGEVWi4kAozgaKKQy k9oM3JNofyFt0POlk9mSvjxR9mu/DcbWzSPQWGGui9jwXUdggwwsTA0Uh4GHBZoA04r8CKpXRJQ kG1J+GbWRtSA6fThcxiYI2nqgNaGVKykbB3NA76n6P8FZXDojTUZROSvkD4+5cFNI9HhR1sGtGQ Bs/xSU6r7E7GMkB0LRxj/GL73Ssu/onkvzvq+BRNiwOkQzVeq6zVIdMe8064+1k/M5vI3pGEXbM Ys+0or2jx X-Received: by 2002:a05:6102:4412:b0:78e:1e0f:ea42 with SMTP id ada2fe7eead31-7af1c7a3747mr1255675137.2.1790251734595; Thu, 24 Sep 2026 05:08:54 -0700 (PDT) X-Received: by 2002:a05:6102:4412:b0:78e:1e0f:ea42 with SMTP id ada2fe7eead31-7af1c7a3747mr1255652137.2.1790251733980; Thu, 24 Sep 2026 05:08:53 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:52 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:45 +0300 Subject: [PATCH v2 33/48] clk: qcom: gcc-sm8650: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-33-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3624; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=/32dUnX3Y9hTXbE2uhZLl9TmWEKzN+ZFCsKbbZqUQEI=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJhvC43UEci7S/KeVA3AovARvcS4pPa/dbjq K/K7LtlHEaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSYQAKCRAbX0TJAJUV VujhD/sGyZsgYWSKZFQKQXmSOtfWLs/lQfJMSnz3/f58Dw/X1RIvIazEb6xWhMxqj5yNxMP+x4r y2OlhvVpplkbi1UXPjx0A8Ry3eHcfyqPN87D4OVcLQkHyIquDtA+DmarlwwrnYC+HaXJ/aCYmlI zbENp3fzCL7qHlrZ5XPa3L78PWSDED6Ffq3b9mXdWOVfjvyz6p0IOT+oj4W+OWyW4UiC77w8aDu 1GD6GG9oEwZiLWOUsUpCp/FXlxeZy4o08TeO89exYgsn1h3noDc+xjYfFXDIAUa/64Y8bZ3yQe6 RmZ3sQh6AhrX5bwojKBVk4YVzPmk0dYlb45zk/q0tX/Pq7jExFlRxSxbW4o0nm9HT/7Eiwe7BbI pdp372b51mULs3TwqlWWWc6JxMkgUpBAmORC7+ZrACe9IQPLEbtXBH8lpEI38JK1owEEutAHRx4 G9R8iaOB7w8OfitIyfOR/8a66wL3jKVORQ3x54Sy3kNso42vRtDXK/Wb9lwGQC0W2ADS9++heBk nA6Moq8VFsD+tVQCLnA8Uam86gSGdLQb98lMLAW+lQffviExWG9sUY1Nb1GXbp6x/hoLzsBi6LJ UOOxtGE1Q6oddiDPSMYFxWOm9lwaIQ1n30iSzMwCGp76TD8ky67Gx6//+g0+u4BE+LxnDeoNfNu Rr3xJvBmrVnI4zA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: ICB9i4cVpxrvTIONfyek71BQPsu0oCM2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXyR1dlKJKH7+x +PktgIsk0sidlKkN9/KrwCH1W3yhN7wJLcZH9dng+F+eKITqLx6hS6c/E4A8isckJY83fAsOBDH gXSO4UNvGWJA1cPS0eKpr7z5cQYCwHTlYFIJyPZ5++jI4T/zZMLTrGpIG+FZ0H14JxzyQP7df/r XsW8i/xqfZAJaPdljtbj/MTiDrmJX9qMBLumI5wqx1EQ9h4Er17oBqsL1RqcivPS7nZpG6UV3xK HHEchMDHj7rEBeFY/mUpP7lRraA0y//ocI4wWb4KupJ5Wc4xZvCvdYr0m+18mI27dNVRKmzFHVJ 9kV7PIzYpFCcd8obeGFmspJ5hMFovHzQLegPDWreCrrCRy17vSkgJ+w9wdgbSf0ZlG9mywiR1TU KXpAXZaCOA2Zbf/uW0cblQWOMDJbjg3PFl2ln2tvk1qGTBdwHK1Y64Q0ebfYXofTNjZFZkpPa2e 4os6rmPJbkq3dnW2+sg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7r1eeUT2vXuF MQylrIstwvil00Os8PJ/yte8YWh+dv6C5dzaK14qXyL8w5446tVB/9u9Dv/DiWhRwIAxWgfZD52 pvTkFmANvtQzbo5I5m34vEdAqdQ6Kkk= X-Proofpoint-ORIG-GUID: ICB9i4cVpxrvTIONfyek71BQPsu0oCM2 X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512d7 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=zVTGKPmrq-ksKY0k6ekA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm8650.c | 59 ++++++++++++++++++++++-----------------= ---- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8650.c b/drivers/clk/qcom/gcc-sm8650.c index 9fa362f0c447..fb006076ea79 100644 --- a/drivers/clk/qcom/gcc-sm8650.c +++ b/drivers/clk/qcom/gcc-sm8650.c @@ -3777,7 +3777,36 @@ static const struct regmap_config gcc_sm8650_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8650_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27018, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32030, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8650_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); + + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x52150, 0x0); +} + +static const struct qcom_cc_driver_data gcc_sm8650_driver_data =3D { + .clk_cbcrs =3D gcc_sm8650_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8650_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8650_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8650_desc =3D { + .driver_data =3D &gcc_sm8650_driver_data, .config =3D &gcc_sm8650_regmap_config, .clks =3D gcc_sm8650_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8650_clocks), @@ -3795,35 +3824,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8650_match_table); =20 static int gcc_sm8650_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8650_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ - - /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x52150, 0x0); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8650_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8650_desc); } =20 static struct platform_driver gcc_sm8650_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1377494827 for ; Thu, 24 Sep 2026 12:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251742; cv=none; b=oagx2lR+BLIYCOStOdckLyAuwDSz+WgEj7tlnw+76Ymdu5JgbVMofzehfVAFYPxgxc1fP0w2T4Wy2rhVhbahvrN21R5ns/Lq3SUzg24M1sMGK3ZPAzz7xruJGayvzc1PTFaHOru/5S4IxHF0/fBDsyK9gw8nPjq6J3C9rvCyiRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251742; c=relaxed/simple; bh=0KIncYxuhYT/4RBit5pRVcbVgHpMdB0n3bw2oLw0x0w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YGdKrTRnt7UUH7tY/bLpJLuSf4y4dzNHb4OIMMIj9mCMwBYvaa2Y4OhekvRFGZyhovKSwY5lssnX2TlMBiZdf/hmV3hmD68J0ibkGdOF/eMvYiN/tykmVJnES82jdiX8Mu+dSOI0YZOE5yYqHq8EYGu2pdC3rwcOAroifPi/Oc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lgjJp9v0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RPqL3C+2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lgjJp9v0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RPqL3C+2" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4V3E3282824 for ; Thu, 24 Sep 2026 12:08:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kebIORO5OlEBTHDRjMHE5KpcC0HkkUR4Ubxle5GK7nM=; b=lgjJp9v0imBnQ86A 7DtxfYp+ftQsAPBBpDVYEaOmEs0Zdl280Fg0fVoqG3Xiweb/RInwSIZk6JekrZhT zZoBhRwqoip13OZMkn1MIyELqE53OkUmJVJonhrcXiYo8pQjLt4zP6NyeDixycrA 6mbGjTgSu+kcjKJ4AUBhgWaq9mU4ZrQFQCa1VbtTLAOoUbqRL8oclSFUsHwE2R+3 QII1NjBz4QMsL694czvyGKbenCbU+tTqfpi3ZBSR349zKzSQdoMRWrD3Q6PVLHtj ocRzWMHDXf6rumkt4FSV3hPQYBGgTxW+n3xAgOJnfrp9tHA6XSbShq4wVgmmzAYa JNserw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvstujfwx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:57 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-97e99aaaa6fso286507241.3 for ; Thu, 24 Sep 2026 05:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251736; x=1790856536; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kebIORO5OlEBTHDRjMHE5KpcC0HkkUR4Ubxle5GK7nM=; b=RPqL3C+2kIpIHF7GkSLRum7bGR/CCD9eDtz5Q/kimejlH3DVMbwV8WH7OTIecrSO7O u1A2l31xzuhcFcWWwYsMQT4m/cJqSERYsn6pzEX3hr+zJA5Ff6rOiSqsxNo1Fm8EZJZQ 1CuZrT71mowaNp5e6iosmWnTaDkHPv1ozYY5+DQV9wcp4RcdBx3CGsEktnZ1wHmlnKfc uvYFGGbUEjfMzZn50koBDliOVQGqQHM9ZIkLiV/Z2BAGgeSGXp2DQ9xhdQylAS9ozYBN 5Vwwr7sfFfkp3a5ZHvEdOmWdMumbmMVwKBKNl5eGhRkW6QaZMpoZB66PURyTPFTtf5MA P4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251736; x=1790856536; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kebIORO5OlEBTHDRjMHE5KpcC0HkkUR4Ubxle5GK7nM=; b=BMApbS3PYB+Fl7Ass4f1JCJFfPXj9ilfgR9Bp0hHGfz3oFTAiEogE6R3Z4Ou6v7lnr mihaxseOz9SBRwZcNDq5ukiS0nMstnXI/PzFRO/JMWLRohg1woHDqrCUyD2P5W/R8QGu xmiI02GOEBzitM46IpgDdFiYSAVOBak9ZJFwcdazG/PF5ccuym9fXqf2y6YpUN4ajGXN qr8Qc0EQJOOHv09ySlSlkzcUyxxE2obm8ejMuLF8a9TKMkui/gAZ82QmHp9BoHrQ7stw XF7/mxsiC0At/acm2dQO6inoHHgXWy9aNeBpl7kob+Q8aiq+6/ktCXsyRqif3dckv0/j 4DGw== X-Forwarded-Encrypted: i=1; AKwUvBxm+5yN9uguQVGCF39oqDh76QfKFQloamXFmBmrALon2/hlbS/4Sitxk5TUGlREwg2i/gzCUlhyygDuu+g=@vger.kernel.org X-Gm-Message-State: AFuF++ke7OaCPAM+CgjxQPjc8KhwOky4SArCpXO45206Ruk2qHTWL5Uq n9ICpbij4sZNZ8II/EKsrSAdO3x3/AMYlK7+P5eQZtjVhZXcO0zo//i/W9s/z3WTn7HnI/TU4OE acHiJ/XRkyHPST4XuPOjrC0r+DF7JLGYuVC6+DBX5rQowqXshbBzzhpLkcJWFS4vvdC0= X-Gm-Gg: AYBFou3dQFbFNfSaMKTCxFOX6pcCKtr9VLO8WKWqAUosxU1u9Gqs86gkrvTprQrWTQy hJhMeYNte2mlZQoJ2u+P6kCBLAppimYKlHqfWA7/EZ6YlxyiLcmVKCxz5ORn0fVisxJEofMbRKb edklpGXbIH6EUuIoqgk4x3NEdnVLjFiGzMgAmr+MSGl+v0jtnAj9girmHaUidM5BV7PWW6TN/ho jaXYX8fxGEMgrgACEuqaqD6b2oAoQPGmTw5yferbhcwlR4vCslTmSdL4et62miixhs90v4xBJMG YoSHb3XQpeciu64nsazUbISoFP/j20mIZHlZvqVyOPH6YfUGoSPIhRYMh04jlJfJ5v3B5icU7z2 o8Pad+9a5 X-Received: by 2002:a05:6102:dc9:b0:7a7:195a:1b28 with SMTP id ada2fe7eead31-7af1f619ef9mr1137361137.34.1790251736353; Thu, 24 Sep 2026 05:08:56 -0700 (PDT) X-Received: by 2002:a05:6102:dc9:b0:7a7:195a:1b28 with SMTP id ada2fe7eead31-7af1f619ef9mr1137337137.34.1790251735731; Thu, 24 Sep 2026 05:08:55 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:54 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:46 +0300 Subject: [PATCH v2 34/48] clk: qcom: gcc-sm8750: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-34-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3981; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=0KIncYxuhYT/4RBit5pRVcbVgHpMdB0n3bw2oLw0x0w=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJislxYoaNfzy8Pdh3NQ34TEvPXIalg1ec81 G5CMms9LFSJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSYgAKCRAbX0TJAJUV VvfCD/9uGtXfYltYMeSAsO4aF7mm3HPFUQlikD3AqOFZ+e4VmP6fCCkdScgysL+RI44Z5BSz0mP 73sVAWT7TUOygdpeAlJ25xJi1Ra1upSDHYs6mmmag9COLTBBgmaSCtEzytpmz9M1mK2/XABE4hg V6Y6CQexnZR8xuNwtSLLIt6rhe78Wb5E15a6N1zsu5/EchYMJ4+Vezr3Gx9dgUV4sNVz9UaMYLt OrBX06rFCgQ63WIz+bA6h1N/nztaMNoRo2cIexpjH75CLabY6akSC1EM+7Zl7bmhWlCNIAWp2H2 FikRidoveW7x5LBWisdqJP7Cucn1lHInvVqxQ8xavEdqtUOVxHN+fecHOtFnd62EIJb+JVExp9w 5v1/qQGo6WGT8gawMZnpe7CtPUen0kFd4wA+prTN646Zg0UKppdPXxa3ticzttTGezOovWBf26K HMyueVJr77vz8bA3VOicfAm19m8RCV61usT5EYr8qLFe+uyowGtG9ndnmI8y4TID7wWPdogSIjw 6cND4hnWnruWk9svtm80IOpG5g2/41azSjB9AOipa1KVYQv8SwDAhcI1vE0LuRInMpOU2nkiqD6 Mv+2lbKUcClyUW3/M3i0T8nKrIwJPxrwdKM1bzE2vrYgApjo9oD4a06CkRGHTFTqcu9/piD29eP dfVom2diPr/We9w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXyg45R5rqNMpa NVwAoGelpOH37ddavPsxlKeZq9ynW2C0LeejRIDTZQF1q3iobERColtoPV+2he1Bx9Dw7CQssOt tpDUyazdU+wmP/ith+Dj16SvKlVexiI= X-Proofpoint-ORIG-GUID: UoYJjibE9N83dUr-chrluekntiTmNsL5 X-Proofpoint-GUID: UoYJjibE9N83dUr-chrluekntiTmNsL5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX9rPIvOBL19sD GZZR3wg+8dmg8KnCY/ZTvm8Ny68Hq7BCqWwWhJ/9Yo80eIdeEh7vmJlph47CLlAomoDOPz53hnF TFr2vsRU4+BeTpJ5pWL7RgG9gh0VU8GRywu1pvhVZix77DAXecwzUThxYTh4aUkPqYstTvEwHHv rSBqKjuBYcHt2+TZOhue6wT1rNUhn7/RQTZ16MVqUApUsfslwW4tps8e9czgOsJD+aDX981rSya D5nVs+JjbMIhchgdr7Hf2h7jMG1bsb/3OmsvGOlUGxFu4xnyEmMqYblWdUyzdBDcizc0YqIzMvb X3gwbvDkDmbSM/Kn65N1kCmcpRbBEpDJrZTxnPIdZ9rU1mHKf1ITpImcyWfNtaSU5WJSzOh5Exu 6FhE2h0GjXK0wYbGV3dYldBwroVsgUMhTID46+Typ+jzqRHKVxVid7rLWevSLpcbSEIU+0QTePe ySxtnACV5awRAi5bm/g== X-Authority-Analysis: v=2.4 cv=cKp1IVeN c=1 sm=1 tr=0 ts=6ab512d9 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=xSywTFWZ64xYcUwTHGYA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-sm8750.c | 76 +++++++++++++++++++--------------------= ---- 1 file changed, 33 insertions(+), 43 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8750.c b/drivers/clk/qcom/gcc-sm8750.c index c08130218efe..a3c7431ef4f7 100644 --- a/drivers/clk/qcom/gcc-sm8750.c +++ b/drivers/clk/qcom/gcc-sm8750.c @@ -3188,7 +3188,39 @@ static const struct regmap_config gcc_sm8750_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8750_critical_cbcrs[] =3D { + 0xa0004, /* GCC_CAM_BIST_MCLK_AHB_CLK */ + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26034, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x9f004, /* GCC_EVA_AHB_CLK */ + 0x9f01c, /* GCC_EVA_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32038, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8750_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Keep GCC_PCIE_RSCC_CFG_AHB_CLK and GCC_PCIE_RSCC_XO_CLK enabled. */ + regmap_update_bits(regmap, 0x52010, BIT(20), BIT(20)); + regmap_update_bits(regmap, 0x52010, BIT(21), BIT(21)); + + /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); +} + +static const struct qcom_cc_driver_data gcc_sm8750_driver_data =3D { + .clk_cbcrs =3D gcc_sm8750_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8750_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8750_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8750_desc =3D { + .driver_data =3D &gcc_sm8750_driver_data, .config =3D &gcc_sm8750_regmap_config, .clks =3D gcc_sm8750_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8750_clocks), @@ -3206,49 +3238,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8750_match_table); =20 static int gcc_sm8750_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8750_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* - * Keep clocks always enabled: - * gcc_cam_bist_mclk_ahb_clk - * gcc_camera_ahb_clk - * gcc_camera_xo_clk - * gcc_disp_ahb_clk - * gcc_eva_ahb_clk - * gcc_eva_xo_clk - * gcc_gpu_cfg_ahb_clk - * gcc_video_ahb_clk - * gcc_video_xo_clk - * gcc_pcie_rscc_cfg_ahb_clk - * gcc_pcie_rscc_xo_clk - */ - qcom_branch_set_clk_en(regmap, 0xa0004); - qcom_branch_set_clk_en(regmap, 0x26004); - qcom_branch_set_clk_en(regmap, 0x26034); - qcom_branch_set_clk_en(regmap, 0x27004); - qcom_branch_set_clk_en(regmap, 0x9f004); - qcom_branch_set_clk_en(regmap, 0x9f01c); - qcom_branch_set_clk_en(regmap, 0x71004); - qcom_branch_set_clk_en(regmap, 0x32004); - qcom_branch_set_clk_en(regmap, 0x32038); - regmap_update_bits(regmap, 0x52010, BIT(20), BIT(20)); - regmap_update_bits(regmap, 0x52010, BIT(21), BIT(21)); - - /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8750_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8750_desc); } =20 static struct platform_driver gcc_sm8750_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB68A494824 for ; Thu, 24 Sep 2026 12:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251742; cv=none; b=nBCQD6UO9eDzG5V9MGVAumGZWnho56KPKX1KKOPh3Da1zCJSL4PYbzS7jRMdQj36kBrmIDFfHF6v6rnZrjGdWMfjZb6lfJ7ULv0uidNjNEYhqVuE1XYco81GbKvdVeLg9g54GubSJTNq2c4TKS8yO8ylWa2dfAVgG6P7Y/pC8Ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251742; c=relaxed/simple; bh=p0KMuyrUwigTxHa9cMX6RyQh2s4AdzkmM6lxAmU2A8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FhemELkCtinWzTIJfwdQ2+OnQlY3GFUbofhpmHTn7xketTJdzs+VvkKehlY5hEDDwue/xsXrfkUi6//+AParyvhDKx/fVOf+UrHT6h/Hn2Ny/BV2iZKA7LAkX+ZGwqcZXZqHkViwA4cfkSFnyr63u+8Ypl0JB5ZWdMyIr0pbnGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q3KElv0F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FKRngbYh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q3KElv0F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FKRngbYh" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4vfh1630822 for ; Thu, 24 Sep 2026 12:08:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= js8buhZeDJ4iEw/5I1GqGOYmeIOXmn4DsTz9MpDTgdk=; b=Q3KElv0FBQynwPR3 ebNKtQmCnw0g8wYe4AWjP5V3McmOLtm6mJTrD1wSc/Ig04KVCNCZ8n1bvNaUCJ3e n8q6W4wsJLo3UYv+WLyAZynvz+oG1vGaA0y3yae7HHPGLSmi6CMcgfaO1hpA6RrW t7/uZyEldn0W8qRhS79fuRWdT6Yf50OR3+jOwFnjBzSSwJ005jKQi1V5mteUbgG+ 1RhhPHrPcARauUCAdXYm5xMElPQ5TEaYxjVvd7pQHU6AC+o1snTFIQuJEdkbwc6r B2VdflFgkQjFoGhJQm3jWbPtEuOolIvd9tiwKBejKZQ+WOv9qg74ym6shTsovV3q J+qcAQ== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvr90axhe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:08:59 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5c683ca769dso783229e0c.2 for ; Thu, 24 Sep 2026 05:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251738; x=1790856538; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=js8buhZeDJ4iEw/5I1GqGOYmeIOXmn4DsTz9MpDTgdk=; b=FKRngbYh1ju+Gv49Sdd0vqlTiy/wNGCbN5TDTeVeWaVARadpxrJVq3sq8WBDZJPRzg ERMc6p/5bLdsKh6NiXq9yoXoFMwiqlB7R+wm7YA7P9R1QNTb/ZeOx23T+kxe9ZTFcizo JorgS11MGEan65NEXAkXRQph3N9CLa8C8HugMJH4nKUJ1leR0vhg5Afx6cqvCf0VM1ts kXQBm0cXzuMZtfhNaZTrmakpDGthpgsuXUjPURbceUtMige5IMA8H4K6cNbRowSXDs+/ GemR4z53wtoc8LVU1Lx5uUXNKucBW+GJN8AbPt6jI1QGFDaBuqS74ONCesdX7WxA+DaH h8jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251738; x=1790856538; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=js8buhZeDJ4iEw/5I1GqGOYmeIOXmn4DsTz9MpDTgdk=; b=nVICts3kSk8fcSpqT/UrGr45y3dinsxpy5toeuO+FLxG5cDuUKqaeBcz0Y2HuG2xcI vc7qE1sUEXsMMpqcNX7a5A8yQefpkx/R9YMWVykKJ36Y3fy5gp9E6IjyI0FyHZMJ/EQ3 HaXQ0IJ5Jyu/GfmkC8CHw5RuAXYRC+/ISTakCJaokwLVID2CC3Wa4du69xNtUem8w6Ma IiuRl5pXH3Ldw+tIeDuKVoUl1Jc+WNTw3NYbDFKVG/iuWj+f6Sd3MnoYca389X3sGzcj WkSjamVe2SMa6CWzUKhBd8anfpVEHDj+Fea4rsjlh3eJtgnun5UukieLhcRXW3FiF61C YklA== X-Forwarded-Encrypted: i=1; AKwUvBxfNzOo7lQvbiYzSGCJmFKRXrropiAmTZMrzOV+q1Grp8gn+mlyC+c21Tuc5kVBv1en3sna75IQ9RQkQDY=@vger.kernel.org X-Gm-Message-State: AFuF++ntGMMSiVNlKoExUM4FUV3OlVZ1lIW7iZ4frPCk6Wh6PS3mRaJo i0c/vO1PAsPqCfisCv34sZFBdooFP26y0lJ2JcYNAtwq4NAXIZJZPdFQpxeTKQetWihxm1GN6Pa EwBZj4SMPMmY5/QcMrEJT8D5wi+4ummWWq7nbGBGzYYVYmTxAXypuV91MLsbIoFmXM70= X-Gm-Gg: AYBFou2A1CTuXQ3x3f/aIZu4/Tcc9AKH/bNPEONtqrojA1YdSUVeb2EmR/fUsBllkQx HJdaWLEj5Wab5oduMaCPGd91p7FAEZ+2g1fwu1SjPCwdFpIoaeIAGVxO9trx+PQyOjoaKg/kLaF l4/IjVBH9/Vy2rmqDgVwlr77fGUASvL2PjmRbM6HS7/7tVle6zNWeGTD2Wxo/j+SoqohncFO6sf aFXtADrxZ3i/5Wps1sE/ZiMQKTSv7O+M/tsjlgMD6CjCl0m1yTbE1C8S8EwwARduaH363mimfUN QFB1xzGD5FBB0ItTq8rVvTDVxtpHnAEAyBwJ3+wyJ9+RUrU6DKVjaw7mgI2lbUTZ+qohuzsiS3b c4U2OaFmh X-Received: by 2002:a05:6102:2922:b0:7a1:f951:f2fe with SMTP id ada2fe7eead31-7af1e4e7dcemr933577137.17.1790251738103; Thu, 24 Sep 2026 05:08:58 -0700 (PDT) X-Received: by 2002:a05:6102:2922:b0:7a1:f951:f2fe with SMTP id ada2fe7eead31-7af1e4e7dcemr933566137.17.1790251737572; Thu, 24 Sep 2026 05:08:57 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:56 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:47 +0300 Subject: [PATCH v2 35/48] clk: qcom: gcc-x1e80100: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-35-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3818; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=p0KMuyrUwigTxHa9cMX6RyQh2s4AdzkmM6lxAmU2A8c=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJj6+19VSPQkZK4osz8RRRQCs39vusRXNKkB pph4yX1XjiJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSYwAKCRAbX0TJAJUV VnpAD/9W1Efb/h9LiAPHHp7od6ImqPk7hCL6CTe5JhZYiY3CydCRo3+qAgc6v8rs4P+IYTQrs3j fOFem17gav8zFuj8voKBynq2pcItc0LO2faW3aBYsfr5FK/l6SrePGCImwVL2NC2rWwpKuIKK8T wwZV++zcGhgAn5NEh5mKhac4UgclDqb85T9r3zpEIH3P0KC+HCGEkDUVeUfNVD/V3RQLa6TIg+m vGRE//JhfDNcEfT2iH06Wet+5NfGJkE139WrNBG1DyDFt/3iw0WRdguAhGZMkpdSeX8yVr7Omgl DVnih3LHz3fhSYC04BR8uIe3W6OPjjNNIa7AMRSZzbJpeRXRh1sT0BwrKvZdoIDcqM3ufIGmTMd GelUW8DGOY4WmG3IhhBNVHKEL8GWZYF36eoHcbkdb1pSlPxBylQsZs3dEdWCjyXcZNj3JAxjKmn Z6XZuFWh1UAiiyoR3Q6h16zuQZUKHRpYp0W69ROkct3C98Gy24bTJ26au3B+WGI77ZYozkEfXlc 6GEGbzRDhnX2yOM+7ZCYPYIyGJiLXH2e7TrxQdC37O9kXwiaU1qMocaXoFePqXlkzzk7WEbetC2 xORD9Hx2GdNVh+EAp/76RZ89sfqSfu4UytjD4lI2IFRgUQPqiDrwF6ulI+0MGuWREICpTvtyZCh 6WMU8Rwv/MUyKUQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX3hHDLYyM3CO1 0ecnvb8p4L/jzT7KTJwTCLIYsy0pAU/ohmkgfgxdl2ftUG52y0C7D/RKictDcan5PFRUTlqIF8m v2iVsN9VETfI3B2zTUqVnTy+gdB12xc= X-Proofpoint-GUID: rVeCC8uSJRGBzV6wh_RGwnYNBcec1GMJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXxvtb1VlWWlk/ kUAL2geDU1G9bP8ImX+XcoIUbAx2PthBSyLSyMtdpWIA8mkQWN5gvaLhM8dEPYgumTW0RjwpXyj P9EDFv5u5e1Vhc9xoEkKaZOanKBW2cjRmrd2JynNhNsgzjV18rMFv3iItE/e7xRd8gWuC7Xymgy 58tz7s+1JaiLVqWyQD73yIAKu3kezFEDcR+L8fIdi9T07xANTRtwm/W0T7Rngrmwm1xZ0UM3tYS M34usyVnXSDgMkC1m8BvW+XTDJ66b+tu0gstNFJwqvUyOdd6MDQADiRxe49QFhLfo3MkRSS+jmG IuZEz4cqTtVlBJ8hifOHRnjfNcxXTicWXtytj63nwglXrp8rkXzZ9RRE5OzSUVtRm+FnxplWP+Z HIjlcdtNZcME72YhK3+/gRK+ti09/yJADr08j0cxExsGdbnfS9VAL+Y8JYAQU8MNJwcExk5zsCp ULirKqDjn3hsgRO6dzQ== X-Proofpoint-ORIG-GUID: rVeCC8uSJRGBzV6wh_RGwnYNBcec1GMJ X-Authority-Analysis: v=2.4 cv=fMusTpae c=1 sm=1 tr=0 ts=6ab512db cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=3W-9O9G7v02zwTbmxhoA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gcc-x1e80100.c | 61 +++++++++++++++++++++----------------= ---- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e8010= 0.c index 9402fd7fddb8..41a66b0ce529 100644 --- a/drivers/clk/qcom/gcc-x1e80100.c +++ b/drivers/clk/qcom/gcc-x1e80100.c @@ -7441,7 +7441,37 @@ static const struct regmap_config gcc_x1e80100_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_x1e80100_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27018, /* GCC_DISP_XO_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32030, /* GCC_VIDEO_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x7d01c, /* GCC_HLOS1_VOTE_AGGRE_NOC_MMU_USB_QTB_CLK */ +}; + +static void gcc_x1e80100_regs_configure(struct device *dev, struct regmap = *regmap) +{ + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x52224, 0x0); + + /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); +} + +static const struct qcom_cc_driver_data gcc_x1e80100_driver_data =3D { + .clk_cbcrs =3D gcc_x1e80100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_x1e80100_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_x1e80100_regs_configure, +}; + static const struct qcom_cc_desc gcc_x1e80100_desc =3D { + .driver_data =3D &gcc_x1e80100_driver_data, .config =3D &gcc_x1e80100_regmap_config, .clks =3D gcc_x1e80100_clocks, .num_clks =3D ARRAY_SIZE(gcc_x1e80100_clocks), @@ -7459,36 +7489,7 @@ MODULE_DEVICE_TABLE(of, gcc_x1e80100_match_table); =20 static int gcc_x1e80100_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_x1e80100_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x7d01c); /* GCC_HLOS1_VOTE_AGGRE_NOC_MMU_= USB_QTB_CLK */ - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x52224, 0x0); - - /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_x1e80100_desc, regmap); + return qcom_cc_probe(pdev, &gcc_x1e80100_desc); } =20 static struct platform_driver gcc_x1e80100_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F1734825BE for ; Thu, 24 Sep 2026 12:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251744; cv=none; b=MvGBewh7QitLEs9jYTPDrUQkDx2FFqvADujpej+sz1mOCQ6icRpm+qVWpZy6CuSy6eI03TARUqHvLIdcC75FWDVimXh4R+POed1+36c0NSqOYlzh90MkczdTRTUGLMLlQG3I8Q8OdHvj1Z8PCH1XDLm6lnOBAxYIsErktHNK9AI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251744; c=relaxed/simple; bh=rY7wgkiQmG20BFEGFvP0I4E2oVi8REXs0MtZfXyGIvs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bhh6UC+lF5gok/FaaXMEXBloOty8kPDwvmqS+VfI4v7Fvge9PDf9Joy4BTKq9MTtdc6UE9YlSG+armv1kK54BzDcpAOqhR9cm3cxOXxMo646gq+jmpPDnwdH60G/auT0HM3y/KDVy573ji0XRB8lJsFwTtWwZt+PkV/Ch5zJ7HU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GMadr6Nx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E+2Id+6v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GMadr6Nx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E+2Id+6v" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC57GI1430271 for ; Thu, 24 Sep 2026 12:09:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0PW/zkK58dpl81VK/4qo8pV07u1jHEot7u5W775V9u4=; b=GMadr6NxaJNQ5uw2 vlRiu1AZFsXPdh9t2ZrFHQ0ZFjLnJDxGHMG1YXNAt/Wflh+qvfawAmAI28pyr/r5 k+OBUEcJcJmUIlRHxSyr3sCm6hrrea7F+bI8+FO519lJLWQyKaC4dqrgkw2IfP5/ oI7fga3Zrx1esuNkZhuymWrGyRUiXEugt72bKucTqxJ1e0LTyqEb5MABT8pzX9ni GCyE6Y64Kr+z0AiDhWDSLy5EZWs+oc1AolbO58S5Z3cSAJVRt+8Dz7i/eDWH4qMc db4fusxgvCvIz5Wjb/us0q1ShtqaReA5/WIaTBtxBSTXHdb9WqdEyoRAqnxyyxtf le9/+g== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvvgh9vp3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:01 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5c96bf59c31so634738e0c.3 for ; Thu, 24 Sep 2026 05:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251740; x=1790856540; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0PW/zkK58dpl81VK/4qo8pV07u1jHEot7u5W775V9u4=; b=E+2Id+6v9ZWUFWgblNuBxELQJbA5rE2Fa67MNzWnbiQNzu8Cy+gNPfwcQPnSkxz+6K uw/NHG8to1t4u+06GPpd5gjBsW6PWXafqoEEKk/JZj5NkYq8ZyYt0JbnZqW84ANOacQb p1JdP+KPBjQbS49xOhJhkQAD7KFiBkgVbZe8kUD2b0WTxnEDMKU41v7MgC7T1YMh6tVs qTjyyxSYiWatNuj6s4vlrBhys3Ku1hg1bex5zvKXKAhfqx1V3Ay50txeo993MCw9VdTf SDYu4751f1AN4Ffq+h66XtSLGBW81YdFo99Ay5POEvvnWyfVwz8Uu4INz8TCWX7g5inw ha/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251740; x=1790856540; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0PW/zkK58dpl81VK/4qo8pV07u1jHEot7u5W775V9u4=; b=kHlmBO4tlq247TSYJB1qmJyiZLaFgPutttGLTiCRqSWH3Hf3737SOCyozaFfLstkKS h37l3aPne3qJQ+6XC2wVKyhhorni6Fz1dr0JnX/VXotH9J/9tw+v0ArYbgaI6vf5k2HX GT3bxJQlg+d+43vRx4G/BYgkWxsrDzHuxONcgyCKLuLCfuBttaZU0Ndaew5so1YPFHQK LblT56h/E4kqiRrUgKgGcsvieTTCbR84PM2ciF6kEUKwdac4rp1J8+yRjRTrn543hzYD YVCdLnyfYSUAdrupLWY9/teO8+tjm4vgv1cugy7D9FViyZ3Ymg9jb6o0zqNjeM4f9gcE IBCA== X-Forwarded-Encrypted: i=1; AKwUvBzPQxIhhlAMeRJsAZMzmxUvVxtzQXmT+Eg544UDCrss78tVCEh41y62/QA9PLIDDn3jg8tKx6/taIGkFmg=@vger.kernel.org X-Gm-Message-State: AFuF++nOEx7DfBFIp4Y546emCLzE9BcFaUTPOFmrA9iQQWK3vbwL7yIP dH0hX61Uur1a95MQ2WAkZPMKDThZuz7N+XQa9OMrHqMqioDljnux8AV7o9q2CIiMsLK5tjx/42p mWnieiyG4s1+Wph+s7BWjBYAahli86r9c+qh8zZy03JgneXI/CNkMNF/mKw59YNyD/00= X-Gm-Gg: AYBFou2Q6jxsh8PUTAXmS6Jexe7VIya6J/KsGsRU5qJKHi/EjNYK0gW2wIi6W+G3v7k p5uOql0YajzZLSdd0Nw/vwGuHqvO0xmBkdNP0fQ8NZO9kxpxruFGUcr7uzW+n0mKR9XmNYysyc0 m5Hlit91SRjLk3OCwLKGwCKDTbdbVlgBLpBED15dgSobtJxo8cZFIbuiBUn7fE9Yu6jH//gHZqw 6OsOZmLPCLVZH5AzYeVhu2K1dq3SAIsrenoQy3BzM9VHC3ildJz4GwZ8bpBOjpADnJXLBOCjQPD 4bHCNDZpZRuUnloRBPyixZUo7n0JpqM5+3lXDAbpedeBnP0nXbOCvchLBZuQdQN4/cSesRh7i+t Z44Swhu8Y X-Received: by 2002:a05:6102:4b11:b0:7a7:36ed:4b43 with SMTP id ada2fe7eead31-7af1eff6667mr853407137.25.1790251740174; Thu, 24 Sep 2026 05:09:00 -0700 (PDT) X-Received: by 2002:a05:6102:4b11:b0:7a7:36ed:4b43 with SMTP id ada2fe7eead31-7af1eff6667mr853394137.25.1790251739560; Thu, 24 Sep 2026 05:08:59 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:08:58 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:48 +0300 Subject: [PATCH v2 36/48] clk: qcom: gpucc-sar2130p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-36-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1753; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=rY7wgkiQmG20BFEGFvP0I4E2oVi8REXs0MtZfXyGIvs=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJkRfd7+v5hA45Elj+8OnFoV0Dv48n9myJHb +igJm+qFsOJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSZAAKCRAbX0TJAJUV VtJtD/9Bs5HoRLWMA3+F2VAkRdXLwilTCmynPrurTptuvvBLSvDg96BMoILWLxu0RRd8nDPKU9h vBmgcfNuYOIq4ZiNBtl+FZx5f2PIMq5dSgOchNkWgTp4mtjcEHdIZnExYFGdO8Z3IXLpL13nnCl bmHpm6pG+CwroCiEw6sJaw3yuUJQEPZeesoGQWeU0hnDoZGXxy2x+R5/+0CldNPp4dN1KWxxwsL VTkfB5E/GDonwz+Pr/8nc54CndnFqTgtACUvnqzhmVtCUJGQCg78xeE90TK5qXbJYkmeCE2/Okv IYNGJ8t5V3qSlhKPYQBHBvI1EaGKCHi0KHNOwRtfeZT++Ap/odnPkSX4jn7bxqdJfPTalGTH83M OM2WxJFJBTnR1ydFNw0xRzYYgcuTRYRNy1WN8e25OzZwyiymA2RKDz8HtXTxLlLV0kFZO+KxXzt Gztom8QQx4506/kZm0mwlWbFI0mzJDFO+xkOQO4XmM0iMiW4t8BaOQDWZqZzzjp6p8L7gp1Oogq 7elImwNO4NFD2p+cjixNYS1etJCiAVSn8uMehAmjRQZ9pRN4EOv3/D87vGF8aj13YTOjkQlbs+s Eb7bBsNH8KHOfqQnDx6NOJYAgyxbmyix2f7ZiUM8kaMosEGISz+1/dFJiwyiosOpqdiwjQN5upF tcsNqkrLLwBevMw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=KYhHIgYD c=1 sm=1 tr=0 ts=6ab512dd cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-GUID: yYoXlKFqytM98Z4-R9n0e2fIDDQlzEls X-Proofpoint-ORIG-GUID: yYoXlKFqytM98Z4-R9n0e2fIDDQlzEls X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0Da+D4/lbmF/ VsYcxhFcqBze7jRojG3unmxBNjw7e8Vb8yqW11xCqmv+MGtpFPlgT3PURXe+MSkz2VRDasQyn81 qfq3YgTigzVfRPnJhOv/JSBJxBUcjKE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX00zn4mnJEX4a 5Q+zqEMx2vpqunp/NdDSlXQeGUptwqIog0jVz6ObjJn+HBQw+l7yTC9xc+vlkoQonkIG1HT6gN1 HfA2Pb1/VDgknPq8u+YB7ehSdNOzYX7BA9uDeq5QuCnc68hDx/REyBRjnkZnxqFr9FgTWvPCteL C1maIYvXtOAbqNSS2ubCACV+kkZD5WygmHyk1lIckgaw+Repyp9odabW6F0PrEzIhFE+rnDLiVl +ZendjC00ygjub+UFWK3yBqJzWQViM5xiEm9Jxt3z2zwLG/4U+Au24NjjSUjQkG5IUX4umC0L3W ivycb7scW5tX1I4m4yIPavoY6Ew6UtKQ007nCoDKx4Wxp3/5ywZ0zpzy4KjXHCVbHgLsSkSipW4 uoFul0YYmkg8J1ObOoi0dX1GD/WNHiMN6grSG0CcCk/RIEroNNcSXBscyRhZonqJc58aAkaWb+D wHg3Z53xmVCKaiMz8IA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-sar2130p.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sar2130p.c b/drivers/clk/qcom/gpucc-sar= 2130p.c index dd72b2a48c42..fa261664c1bf 100644 --- a/drivers/clk/qcom/gpucc-sar2130p.c +++ b/drivers/clk/qcom/gpucc-sar2130p.c @@ -455,7 +455,17 @@ static const struct regmap_config gpu_cc_sar2130p_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sar2130p_critical_cbcrs[] =3D { + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sar2130p_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sar2130p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sar2130p_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sar2130p_desc =3D { + .driver_data =3D &gpu_cc_sar2130p_driver_data, .config =3D &gpu_cc_sar2130p_regmap_config, .clks =3D gpu_cc_sar2130p_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sar2130p_clocks), @@ -483,9 +493,6 @@ static int gpu_cc_sar2130p_probe(struct platform_device= *pdev) clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - return qcom_cc_really_probe(dev, &gpu_cc_sar2130p_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD43F495048 for ; Thu, 24 Sep 2026 12:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251745; cv=none; b=cK5YQaJA9zlXu+0nQd88nffu6lJqR5l8cNEdxHU3qA3Wo7BoHmLEARmxMc0BQsTgkYbWbrGQgZdozJIiH13LUQSnVte7eJQLotEKSxuvUWnAyJIO9dEZodZlx9OQZuQ5uqETV5OKvMy2Iv0Ic5YBtWoIJKAfpVa1rzcjQRrcVQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251745; c=relaxed/simple; bh=c0wYPNUgewRDJMW5F+vd3xsVEtdgJT3QfwAzWTspO3s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XIqcisFCTUvKfu5i+mvmXvRKw1wZbN1YCAWtRm/QmfQIy8SAzpo9urpIap1qLTD8bm30ZYXXocwsaXoJZYB2J5gO7LG9dl11xYBD+4WCaIwnEWLtpiP84aqIAUlRES2rBU4Pt3JzyH/TtkudVZYTQg+JU5L+6y0PmqIK3UlnjSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qp0KlL+8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Uts076WM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qp0KlL+8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Uts076WM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4WKk2749219 for ; Thu, 24 Sep 2026 12:09:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y3li9eu0m/HtmddfnsisJDYsvstqJmy8Yy/P6jNbQpI=; b=Qp0KlL+8sSm9NYbb 1uLWae2ye9pU00CprxrRVIW3vJEWeyDdK61aZuGF6erkjKIijx6MierlwnoDdnVu MvZjcpyPvCEEJJB1jXlcicYfPVVQ2sy/2VAhQIIX3fmTKTbzkFd1mKi1JFMjB00s MhZKM5oniciI7jCaYIBDeloRUxWG2EIkk3uIha2uqMC6973BixZHs5HxJutgSM+5 8ZX3DB/y/fMSSv2xKItFv5bEA8QtNN4AFMqTaoGGRXDq9t1bQmeYh200V3GWfwP1 gAI4NRloS60dZW7cV86oYeWe4ZtGo3RBopMtTVbfnXxKZc4jm21lQkt/QiL4jYdR KOXQ+Q== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1s90ev5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:02 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-791463ed29dso1737059137.0 for ; Thu, 24 Sep 2026 05:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251742; x=1790856542; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y3li9eu0m/HtmddfnsisJDYsvstqJmy8Yy/P6jNbQpI=; b=Uts076WMCLbbRiGQQi2evgoLAmyMWcXxlVfvfBDLnoj1+esg8KIiK5qsDB9XUL9Rna 7HCYYkiNylcZ+KLLf/euJp7c0GTroORUfesfSsB9sqVLJzxnbvYIE7yziJZqTfVwfS1F BnBarPQh+UfWKuwmmle8c0VFdakv40mHmq90+KcdTI3kSdb4Iy4IH5APdpE4TtEdajDq MAGPVoA8GInf4RsjFOGneESpAKQyF0alDBVItP/ZZTGl3lHmmq22gjKMhLbJ+fTGE8zA nKIw2+Yk341j6sQRPRA6cgGqn9+xQ1QNuZFenjPV+wCDne7/OG+JoPGsp4/fIp6PxI2Z pE/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251742; x=1790856542; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y3li9eu0m/HtmddfnsisJDYsvstqJmy8Yy/P6jNbQpI=; b=c0gqBzPQ0PL1irlhthN5NixUGm8whhujhRghF05X1prdab1ZGL/HCVHsqKOvtygHqL 4g+6NXs2Y7M2w2tdPoaKVi/TvXg9ryRKLfEP9aViE82qrbUgzkapl05xUICQpeDc/pPM PIDqMHgTXr9dVAgkybsGb5EBDnEX9rof+Pbl7UdTIkxctWwdz6FZlZ6eOU7uL2V8Dx7y J6VN2v+AqsWC/YTUFTvwUzYP8sjJDB3lFBGuVdDVkIB6eeWfkNxOK0J+p7cTKNFS+7z8 qNTWg2SUYdD9wSYO6SZYIsf3Tnr+7uOXjl9d56cedN916cIrMcJEfhoaKsmkDRXS9dzQ IEAA== X-Forwarded-Encrypted: i=1; AKwUvBxWKYL6PVEvvjwd7AAiqM3BlxQxPP8n3zszcma4YkLDLnPC4clG1ogHnegGyUEMKHssi/vRzpGSH59I/nQ=@vger.kernel.org X-Gm-Message-State: AFuF++lofW2mX6lS1bM45NxtSDSiy/mFZeVyFlQKfAExqrhf5el1twol llISc2idWm3Xf0+B+RuLRwbFSaHJgNnWfY6o766jDMFtFdXwx5bR/zELpjvswy+/gR7Yg0yTGF8 5Xji439m98xyx5DBsmc6nPuv4jcw8HBOga32P2NCZompYsU6hahA2cT88UJ87NZ7+OP4= X-Gm-Gg: AYBFou3qYKTJekqcWC4YCOW1gITCr3wVpuJbdhc11iiDBL8xCLmdqTbLn5vUQheSFGj ZzEBuYkn8sU9aOcdomh1Z0YI9vG/Ck8A0dgH3FiDWN5sRievgzZrwOUBmOllCXvOH8u+eTH7cUH IsvTrdIQ9nEYvU3UrtBaA/0l9LsePcBYTPo2XZ2qlvapgG1/9W/FyyluKRuTUNaTimrGM5dsCCa lcTqOfrWeu+jxO2lBQAWIitc5DFS8fwt8X+ibPEH7c3dAJWOwYZ8cOG7JVa/6yLU+B/Dbb04nl7 MOw7AUL0rrAUpNOzFyNftJZBck/B3bEW2TDzU0yfasUw7QpOg34ZtQM+Xdun4oN3OPu+DzTzuxe 1vRBIf6+4 X-Received: by 2002:a05:6102:f8b:b0:7a1:f7c3:3a47 with SMTP id ada2fe7eead31-7af1d6c2e25mr1025326137.20.1790251741893; Thu, 24 Sep 2026 05:09:01 -0700 (PDT) X-Received: by 2002:a05:6102:f8b:b0:7a1:f7c3:3a47 with SMTP id ada2fe7eead31-7af1d6c2e25mr1025312137.20.1790251741280; Thu, 24 Sep 2026 05:09:01 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:00 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:49 +0300 Subject: [PATCH v2 37/48] clk: qcom: gpucc-sc7280: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-37-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2147; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=c0wYPNUgewRDJMW5F+vd3xsVEtdgJT3QfwAzWTspO3s=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJl/9yp3g10naQVMDMNr5N+hsbFUv8EWIvVJ UnXbdxKer+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSZQAKCRAbX0TJAJUV VqjND/4z0NkhOw/OWCCz0rQkE8gUjGr463luBVOcGHGelzCG3o+vOs60/WH/LQaH5hLqixx8SN5 IWGsrWnOkWEOhAjm+HEXgtrltybm8OnSqVFOWkSbJWsmWVShxyx6tAWk1/3mIdt/3I6mE6SxCZ6 pra9ZwmS/OSojq7kCf4idb8iHDTKbJVKC8h12wby/jeq3CSbCTnr//Dqzb+tR88scZg4QjmIhpb uTF/7vBZK6MzMfJ7+53UzSwwaFNao60RQjT1MiNbh6GwUl7jZst5avM6lBPLPk0BCpO3wxOmY+w JeZHKZx4HT0FooPRY/otkqII3JKrTSrR+18xeCn66hMpSrB0nRciU2ljp2NVmtVu5nYcYWHzxa3 EHrMKyGA4wsPYjyRwJhWsYILqgW+LeFQeeZ4gT8KPFKXEnnOWa0jJKN/WzseG0rfE/KwN5Ba+kG TW5HvPI0vY/fYpTolNdsafTi7BF88EO7jx3b6y5IbjBDbcCSo4d1S9B7BMQ/c9MhPyLO9+Bub+v eULRWTEaHwN1qQGuI6oqbmDaHZJf4GJA7oox3yAYskPBjRoynLYPwPzc5bRGsS1ZTmV+g/S4HU9 1eoAVbGx9YGjMvTwEJWIpUAE8D+3jaTYW4mXvbbbCdO5Aj+Be9S2BI8J0JOJbi5CGTGVnPUZj+T axSlTRfrelsbrnA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXwxOqeUh69f7f peRPIyxdnRHScLXcgtAF3FTx/lkTgSEHx9KhH39ovvTRrNyD1evxJj3Up/Zzwo68EL2DidCaaGk widPPKEwXqDVnN+JKuUSYhrHql8UWK+y1uLwUdBRd+28lEbejndr8lWhRjd9dnm/not2P/BGykD yhV5uZJsggaQAUARfHkje8sNUROo2dbPfEqBcw2D05kWuD8UFHQvMU4wDXi7TBHIwOg/zHn/8T/ JJK32v31mFSdXF694orZiKe0I2gEFr5cp8amfUcKevypAYEHJNPC5KwhH9VZMD2LZNKhFlfakqh 3Gb8Q1VX0YW+TwkYiG5UL4/TMD8UWmdq2I+CwKUVITnHD6cNdR67ND0a/ia+6s4fpgAypSxRtUR IK6IkTYPbdtefHXyyAZTb4t37tCZ58a0DwWaBNb3On3XNGiH1Jwfk1yFei1axHcMdN7koTjjF8P B72O7SQVY+2nrNGptRA== X-Authority-Analysis: v=2.4 cv=VPxIDNPX c=1 sm=1 tr=0 ts=6ab512de cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=W2O9Cv0nt9n2xGTIkqUA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX8OJiHz7XL/ns hStU3Uup8d0VeBHumytiRZK05f0EbEW1ZX8emeSrFOq5bClSYfHz3fo5laD8Z9gsQK3cH8yGCHQ iD6ESx4R7mZR0fuzNU7JaOsK51QjLrk= X-Proofpoint-ORIG-GUID: wlyC9PKqcK1e2rwtS4PufTuQQ04NawMo X-Proofpoint-GUID: wlyC9PKqcK1e2rwtS4PufTuQQ04NawMo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Move the GMU branch register update into the clk_regs_configure callback so it still follows the always-on branch enables. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-sc7280.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc728= 0.c index bd699a624517..9b267276eac7 100644 --- a/drivers/clk/qcom/gpucc-sc7280.c +++ b/drivers/clk/qcom/gpucc-sc7280.c @@ -440,7 +440,24 @@ static const struct regmap_config gpu_cc_sc7280_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sc7280_critical_cbcrs[] =3D { + 0x1170, /* GPU_CC_CB_CLK */ + 0x1098, /* GPUCC_CX_GMU_CLK */ +}; + +static void gpu_cc_sc7280_regs_configure(struct device *dev, struct regmap= *regmap) +{ + regmap_update_bits(regmap, 0x1098, BIT(13), BIT(13)); +} + +static const struct qcom_cc_driver_data gpu_cc_sc7280_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sc7280_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sc7280_critical_cbcrs), + .clk_regs_configure =3D gpu_cc_sc7280_regs_configure, +}; + static const struct qcom_cc_desc gpu_cc_sc7280_desc =3D { + .driver_data =3D &gpu_cc_sc7280_driver_data, .config =3D &gpu_cc_sc7280_regmap_config, .clks =3D gpu_cc_sc7280_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sc7280_clocks), @@ -464,11 +481,6 @@ static int gpu_cc_sc7280_probe(struct platform_device = *pdev) =20 clk_lucid_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x1170); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x1098); /* GPUCC_CX_GMU_CLK */ - regmap_update_bits(regmap, 0x1098, BIT(13), BIT(13)); - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sc7280_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E21A496D2F for ; Thu, 24 Sep 2026 12:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251747; cv=none; b=Gw2MPKxsJbAepP7J7eMI3YTj8y3xrlq1IkHBT7Kmx2w3Z6F1rogcl+8LvMK3oynLyfr7HFHLgOsEhyGM5xHCsGmH7AyaYN1a9ZrNkiFT8lGtxKzD8COeWIV+L6OSC1FAwh2MZpNSlJ5VTGThAZjJNgLtRKtpKtrWCVuZpv/ajbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251747; c=relaxed/simple; bh=wxH2A5NltypVNyoBLsOyo7htIGEyAFYuwAaak2EL2YI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PYNbL0OyOkRWwr1e0WHtM4S4NiJGdaDv+aArn/4Ox2vX2x64xJJBQOHbTWJlOgqxqtxGKZrNWTq5sBXv4R+vs2CGeooL1uko+srTBJrf7Ucg/Y4KQNal9Py46G6SbbNNC+5c72W16bvxAnAjWPf5oZx2ZE7FJyjdBEDMhcchIwg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kZSeca/y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SkfSNeGV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kZSeca/y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SkfSNeGV" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4gkX2594263 for ; Thu, 24 Sep 2026 12:09:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vKdS2+i+Or9HfpD28AojxWPrXGU6WCfX2xA9f2H8Fk8=; b=kZSeca/yFBbsmVLp DZMbZVOUcU3ehICxDieN4WkrPkOTdz5byOqaixH/7Slp/E/0be6Jem3YwhKSx3FM E4db1ugYULb9T9XhRbyuLy2C/tYJLDpLxUfPuoeeHGu6eiDNRhH9gF3do/D8+4hs FrDCz23Gtszuy2QGL6qMzEnWu0gJelr7Yt49UqN9TxZR/y70zfj71A92WpQMVKlt gElWuLhmH3sQ2K3Lw94bbSQg7+vpYsBeAtiBFUbT6fYH4xxV2+M6JwgnRM6mvU1i PRZaz6Ox5wkMh9U2rUKMdj+VxtYxRf6F47Q3qbeRvlr+ycjQifFUrw/1pFVEsCxi Fk724w== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1tjgeb0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:04 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-7961a79fcd8so595953137.3 for ; Thu, 24 Sep 2026 05:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251744; x=1790856544; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vKdS2+i+Or9HfpD28AojxWPrXGU6WCfX2xA9f2H8Fk8=; b=SkfSNeGVHrNfCJVFXhotnpg7djCExSOczYnLons2gVFncDVp8L69fd69OlLmT80Yw/ ed3da0KFZdjtdTwTNy8k7kkI1zkc5HgnUBoqir/ELHP2QGkhb1T++OJE8hiBXAxu2NaV 6EViDGcjgIoccLNGKyV93mAkdsskGPEQVLGDJDhERbJccCFWSwjC9uPk24v6XyBsWl5n kV1fzGWMT3sM0NW7sykzeQHKa01ta3C4b/I2HxzQU1HAqQyhP9r+aUzv4nx9Vn55e/jO pJ8blhtSW1nUHv2aXzQEwCjPNMymiEYgixII7aAD1TpBp/ty32cR8AYCi9aCW8I5t8SJ s8xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251744; x=1790856544; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vKdS2+i+Or9HfpD28AojxWPrXGU6WCfX2xA9f2H8Fk8=; b=eo7PhiGp9NXyK3Y2+sU09eNW27FbmzTCsOyzuxeaGrsCTUTAk5AVW8oMyQMgECdnqW /yMirwD1xuK9YN9zRdky8JieIP07Ezj9Rbjjo9ZI142hFodM34JNdL9p6mm6c8QOYSlZ RNG2mgg3/XE4DeiVz2B3GHUEa0kc7XbbNeG9lp7YhpBKeqDdRJbyzLulNbWNhwK6ravV i8aVcC7dwY61b1l4x3ZFWTCCtD9//yK7NMrc6cbaJosgpJ6pniaYCfgEie5xjSiOo1Fc UBFfoekzvlsCuiwzUory5dpVqaEGZwGdnbrx2nChzxF7pNL/qDj0xDV5MfrlaIQ87taM cDmw== X-Forwarded-Encrypted: i=1; AKwUvByKaT66Ga30aqJ5xxz3MbzXTS/+/C6k/VSYbGuZxMcE6X2ke4ScFj7p8HX9XbL26UR1KGwsM8fX//qefo4=@vger.kernel.org X-Gm-Message-State: AFuF++lvSapgiazaDhKzwGwBpGfZHDPSOiAvBLYSvnuFUjqi3bkvBX1t SH/alv5tOgaFI+nUzxYaZOoflOc8InBvFV3qSx2qxtBfVVMEL9VTsUM5WsgIFDBQ+R/dSFRTt7K BeP5ug7CSmoLb6uqn48RyEOkwM3esNpbeKENO9ZgUgmM4zSTzRWeiokn5LfO/SdblOeQp2jJftI 0= X-Gm-Gg: AYBFou28+hO/nF1+EbAWz/A+sVrzagCAMzXIVvGR6D0NETUg4B3Gze7LB9/omcL2Mb8 SjuHR38woeYXg4Dh28xAWkpTF1NrZc8mEAkuRHYo2eYYJjsoEarLgBjPd4LAhYcNQyMzXrR2F+C cOqyQEYZayGXrR+m9KS9/U4hbFgtOcCIcmgEA3klIpk+IMDx1bz5ydythi0hQiiNUsZuTCxNWL7 7uYGN+xAPyqv+b4vfVAEAvP/fElcOUIbWsXIwMobz0ryCN6b+xgOsESVh2nPQeLt6ka93D+XvXE pm3BiXe4BMq2WkiG4nPufWEp59z6zr/mzfd2u1qS4uB4oLDW1euQ4JFI7nq15iWv6B34F425ALF NJNrAiVRW X-Received: by 2002:a05:6102:3ec3:b0:7a7:19aa:f0d8 with SMTP id ada2fe7eead31-7af1f621049mr1004965137.37.1790251744068; Thu, 24 Sep 2026 05:09:04 -0700 (PDT) X-Received: by 2002:a05:6102:3ec3:b0:7a7:19aa:f0d8 with SMTP id ada2fe7eead31-7af1f621049mr1004946137.37.1790251743411; Thu, 24 Sep 2026 05:09:03 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:02 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:50 +0300 Subject: [PATCH v2 38/48] clk: qcom: gpucc-sc8280xp: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-38-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1871; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=wxH2A5NltypVNyoBLsOyo7htIGEyAFYuwAaak2EL2YI=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJmmLf9L+zeW+sIikLbJmIHAg+4ekWaUHnt9 P3bPRZ0/OmJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSZgAKCRAbX0TJAJUV VtekD/9rGUwcl8cNbr3rDfQgLAAkckSiqbtsKLaiDjvDE+RerfHlcOQjrg4WMhy1qDRrGJzbF3P 2ktJkJ4KwhT3HxK96Sx9LTM5FKk486+BpiCkyM1ldaZCFniC6zozIHEb+yCLe8GLI65OS3pEkdA bMGpUQZnu5y13ex5HCu7sIi4+h14nOFVm8I92/J3WGbAXcCpgPVEIsuTuqAjLePsjTmwoGFYEg/ 0OZdvf/UpvhTU98D/pWVEQJNs85H7ZE/njwZyEbn1hoJER8iMbI+YGeggbLXje5ieIlvRJAkWFX i+rHIq4sU3ayCoUpl3wL0HBzRhUJVyA7uClgakWHXw3vCkmfsHyxBMK5rfyvIHCCuBQ0jGd5O03 5fNQpIc2gqok8vfMm/77u95R3Jb9iryioKwmU/cOAcNQ3Ns5WmETrNZGAbJKLOdi2vmCQoQG9Xd y5+QnnrXcI97sbuk98wpSuM4eC+Ur10VMDQFp/p1HN21gRMDQSdZyZU88iRARc5a+T73V3ZNnz3 3rVsPCOwu5N/iqhkagTTurekisnnIX/FiKkfFxZZykyEi4Ml/gJPWCQNo/rzwDc7mF2gZLxEXBf CPZJ6ELumRbIJnblCq4J/qBd6cKUFUQRMgdNoOpzZF3ME4bh/j9blcewDTcsrI3d0qNlN3VrApH saCiVMme2zhRDrg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: 9XUjZn2zHk3_krUNe4NV-kLsNvflYwHm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX9qrtWyvasZyY j2ehVWo7bgiH/De6O0CBBR3hhGnSCiY1cV/3DUC82t8pVBRxrsMFNjtGbLMcApWkQQxzIa3pXL9 C0I2cgd85wbw+m704unVbppWJK5pPIJ8ZokEwGmpvalveKqDn6TpAQj+a2Dqr6rg5EU3xs/Z1lq Q29GMR+oc385f87mb9DZJeCgKqgs7LZ76DBzFizeh9D3EEkKzLsSHcm4qXPVJrYyu3MnO9RtTMC HrXmAwscH/Fv/4nu62AwFynMAbaOfnzzZyP70bV6trdYUnxzpKmCcFHA4wZdETjH14eG/4Ju2At xfyCKGojE/ekQTsgC3X9ZlXJF6QKFax23xlTl2zovAsEz4pwkXPqy0J2GSMwtTeukP1wjPhSh3u Glj98xxAE4LKqmIwP+y5JboEFKwh5N7vOlOnygwajZ6gH03eK+s6iihg2i/wSCZ85gyptzPRj2l UldA28TWjkrxw52wXsg== X-Authority-Analysis: v=2.4 cv=cK11IVeN c=1 sm=1 tr=0 ts=6ab512e0 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=tHUDbLQnBSC955iDWYgA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-GUID: 9XUjZn2zHk3_krUNe4NV-kLsNvflYwHm X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX3nPsn3tUcpXq Z8/D+vgr+Eo8y1NdVgpZiqL0XBHbfwCBGDM5NcfpKi5/GgnTRawAPIfR8B4VoxzvHl/99rdLqcj vVzRjZbNOv7L8PoLjq+0owhiYt0BuSw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-sc8280xp.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8= 280xp.c index 5dd90b854afb..2ccc083a4f98 100644 --- a/drivers/clk/qcom/gpucc-sc8280xp.c +++ b/drivers/clk/qcom/gpucc-sc8280xp.c @@ -415,7 +415,18 @@ static const struct regmap_config gpu_cc_sc8280xp_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sc8280xp_critical_cbcrs[] =3D { + 0x1170, /* GPU_CC_CB_CLK */ + 0x109c, /* GPU_CC_CXO_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sc8280xp_desc =3D { + .driver_data =3D &gpu_cc_sc8280xp_driver_data, .config =3D &gpu_cc_sc8280xp_regmap_config, .clks =3D gpu_cc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sc8280xp_clocks), @@ -445,10 +456,6 @@ static int gpu_cc_sc8280xp_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x1170); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x109c); /* GPU_CC_CXO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &gpu_cc_sc8280xp_desc, regmap); pm_runtime_put(&pdev->dev); =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24076497B8C for ; Thu, 24 Sep 2026 12:09:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251750; cv=none; b=bzhA4GvTWKrM9yjRBwbWsdakOAtxe7BpCNFy2NdQvS91PpMBebuYAoUTTambS5G/KwYTBytbCt2iFhbl4uOGBvay3H/9KGxvTW1urpo4EXlWlK8u1v0Fsj6MQ1C6rJ/7RUQh4IRHvJCndeZzrpTEyUBiDdqhVw4uM0g5gqGS9lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251750; c=relaxed/simple; bh=LAioNN1IDG6WlUHJDv8W/X17kNzAhU+Jnw7JDkfH6Rk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XOtMqhFEd8nBkJ2YSeewjIqqc+2otJ3IK2lRtC2Lf3Z2XS90yCbOH/GG1JeTd+6g8qADgTIrpTuxZ3Y9RqZEcmvG8yzlxoERp+WMrkJnxcW4TQp2eD1MLEtN0AyD09aXsU0om7IqYdUpO4C1YNgjz+pqopi15RSZesPILWHa0II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aTeXCvky; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KRvBgLPz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aTeXCvky"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KRvBgLPz" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4b1Y3134162 for ; Thu, 24 Sep 2026 12:09:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Lt4it/SW6Uq8rX/R/noJ33j3tUYVR8IVNYB4olxOXog=; b=aTeXCvkyarCSBiLb ralAOtEwB86cu6QkTMbEm8GYn9lWP+DC5EQAZgoD0BOY/DI23Sz/JDVzAKa/wPBk RqBMYsKdVH2tprWLGfv7UUCnHqex4WZHlnOerveg8Go+3+YcGGDVr/ByRBGX+zQ0 PZY0rnA7GB+dkiNIqiVaoKOJ66ibEdOx6IfIkNtBLdnCdyBwi8R9SGahSLDrmxje fkqZdI0PtpNHTLJxhnNoiOww3EWxFZI+0pTMMyvOzvIMvJLdpoGIULI5JABK4MYI J08YOXzHXolSZic3blTbqoMPEbPqf+/GdwnHpwU513UYrSJaWQjCOoOXwe06Z5I4 r6bVhw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1raggpj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:08 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-97e768af628so1578951241.3 for ; Thu, 24 Sep 2026 05:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251747; x=1790856547; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Lt4it/SW6Uq8rX/R/noJ33j3tUYVR8IVNYB4olxOXog=; b=KRvBgLPz1HFbt5daKxc/ARi8mewGt5ALWM2x4TqpOHd1FDswYmB571w2zeqfowey7C gVaxZwUhOXZ3OcS+zWD6iuXXXFwe4/lWLmq+bpzK2vvvLfWjHn8r8ys5IiHvjgekGv5C lGE1nHVVw5qs5GuByMyQ2lhvw6yJF+qEQBsWPT0t6M6lFOjipeDKyMekF1rS2Sv4frJ0 7Az5n1JiZoHly53tokrJlS3rU4tmK3nlbaj8O61S0ywgaCw9LWbrCdDb5Iw8V/r0s5YZ EBeVYN2y4MUrZb6X9tKoPOp1j9rBb3V4jLIzfKAt6rDiTEF+BHFWyOmLqNgFriQz40B1 i1yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251747; x=1790856547; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Lt4it/SW6Uq8rX/R/noJ33j3tUYVR8IVNYB4olxOXog=; b=tZk2DzCQp8qByzXwuCnGob4PQX1A6Swvrn8sufAwwSYrKC/XkiUQNeXAgYaDn9Q4+y EVZHNB64OBMX8nz2K+UvDlGtaKKMDaZbkRAlH6XiHVrYE+Aue60frJ4SL7OqMyt056zx qL8tJDS4UX0aK1aPY70szpZHHNDXabjlYBMeHAxcoVXJ5SfbcXn9VZiQtFVE3X6sgEx6 SQnKkxJHaT5EoBMpL95iDHUI8Kd2wQ+gYR8vguwx18WzBzH5DGEQMp1qx4V+2h0Ma5PZ 21IORwXgpUJ6RT8Li0gTenYCgo+h/FnkyC0rQ9kE7+lTQNKAKisDIZXJ3dhpamXkSpga /8nA== X-Forwarded-Encrypted: i=1; AKwUvBwtuai6E/twGVdsSZ+rO+DF1WKwwA5QTx6BNBHyaOp1WVsvHDNplUj5B0+HWiPN00+IEbiGUZUrMcMPAVs=@vger.kernel.org X-Gm-Message-State: AFuF++mPSxRq8aeoWLq8dUl1RG3eJwA7VGwJ2vDzoE+Jo0K6kn2J/VrJ q86CjnLCxdPyfnwQzMyjsS/YaWO46s/AR9wtF0TbsxSCPMsORYamhZxaQjMRZbFK2sdTwiFU+LS 893/XsZ2FlMEDP953OwcOcSOI9hVUuRBbPSWw9FQqsu4TgNJDTlybUTkbHtDMnkKd54M= X-Gm-Gg: AYBFou2ZARLxU211egBw28vODG1UELhG+/sCggvwVqngEpoWBUSz2ObW9kOra3Pbpr0 61f1ogAW0wn41Yoa6ZCCaYoYFjysBmCJgg8K/oGRlkmn+aBv+2kcOXkIP1YS58SjiTu8f1dHr13 ze0CMc4iUHCIvV6FmMBovI1KGJtv932LVPGXQ5OkraPDjeBb3XS58q0vCZyiO+8/7+zVpUjr7Mt rn4RJMdpTkVMFc+7jvE7X202bKDWDI/NAWXqVm1R4cfU3OpQKvqQaVYdOfsMg4V18l9SoQLboMy +cQXxSRtq/2SvtCa1Aivdl/zh2WjsWbc1APZADQL2jLBdW75f8oGFGegXvLkaxe8Jk+MHQ3eSzJ xoELFeQxl X-Received: by 2002:a05:6102:c53:b0:7a1:f7c3:3a45 with SMTP id ada2fe7eead31-7af1d6c4296mr1188578137.18.1790251747399; Thu, 24 Sep 2026 05:09:07 -0700 (PDT) X-Received: by 2002:a05:6102:c53:b0:7a1:f7c3:3a45 with SMTP id ada2fe7eead31-7af1d6c4296mr1188566137.18.1790251746775; Thu, 24 Sep 2026 05:09:06 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:04 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:51 +0300 Subject: [PATCH v2 39/48] clk: qcom: gpucc-sm4450: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-39-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1934; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=LAioNN1IDG6WlUHJDv8W/X17kNzAhU+Jnw7JDkfH6Rk=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJntAdyrGG4ORat9hhIwYHpYsmAML/7qM2LA L/WXVt0lV+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSZwAKCRAbX0TJAJUV VvKYEADI5rVwpr3PKuujNpfkhG4OHvGmc3LY0yJ2E1F8YlTiKiD3qXF1AhZEUZIcOO9Tu3h6ZMj ChtmT+W1Fh5nUsIa5ZRhzlMWJJsbzX2vCCIkNC+239mSZ4mTcIJJxD9EgyrQo0ldOMTC8Lf2NUP JJXpxSd2zMGnJfSbx0oKQLo8YglWDcrcFnCS2upDcjwoQA4pYPMA2AC92wNVZ82L+pu09Pl5l/A 4Km2T77EIXF4aFiQM/+5HzEw1v/RB/pFqY+hTREL5r1JFy+h/fbn4CQJUsDqkb4tA6xvtbp86xN Plzk7he33lpo17+vTEsv5MUlwE4H+BoRJObhhqUpBohMfUHbQy3ucZqSbiomAuOcJg88nuaY294 awQVmoAX52x5F5ULQyaCYu2BIRzVD1jCA/f+owSJpNwW8jgMn2eA08uEdPgHwcvzKEEgaXNkWGi BOjtIEw6SePCtIyIO1XqHi8uhNJes46f/7q6Haihx5cxoPW2bdeU4+wg36czrOy98mZtX8y1+YO sNcXutTHpvAhR5UNc+XBykvg8IqlELWCgKWcc82LG9ZDo0Z/2WGx4Ez1I8GwxwZS+d79GhsBH8s I4LDZFeyqX621PD9Uqs1qHHGnB7bb+uEDQMploDWS46n942EvB25nGc3GWJMqUjMIJ5RWp8rRz8 2jzlgGlp/ac3bqw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX98OhBX5yVoI/ zDUuQNqr6yl1nS5w9qp4ez47aeZs+6Lfym0wkKdcxUgmFWy1lqJ8W04KVHeH2g6KX5/PS/UJCpp 3jZoITZpvlRvDP0MRRcDEylWU/w2TGwqD8s4gLMrx4sEBo1JhwUSvUjU9tP69eoWpPq1dJyxRrO 1kZ87kFCwX5BKjhpPFWZ8EyjFbKCyMEW47gLgSPLoLDzUxGWeuY++jLzUf46zLQqzsuu0KY2elI xV+be9UYm6hGFOWCFJgfRT5EAEeWp1bdXLQ+boY2J2dYVU9rVHdBZc0S5tn3HrtYftbpcQtXZpE qSiLqaXXPvHqre/dquOPvIKSIHLSqzSBiFhFmyul8vxPuE1qY+UOsfCX4GbrkS9apo+vOf6TbtP vxVlQkiYkPfhOELHId5slzb/JT55gDws9D0wMM+PlzfhvQjI3sOtLoMA40WHK0UxM2ZVutV3/PJ gSPqPtit77Lok1JrwVA== X-Proofpoint-ORIG-GUID: KQ9iPVezaZJYwtnlecmpYgD9bwj7o0dq X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXzA3tnXTiXjPF 6q9pUQD4qc9LHtPaiALAnExrQJW/WmeCXuxizGUsaw6jw/TM/6E+7ZTVzeJ3zHgQPnUsLMCfDnS oAV1xVpHRnD2ATP0dP84GYnAm/af/Vo= X-Authority-Analysis: v=2.4 cv=fvpJ914f c=1 sm=1 tr=0 ts=6ab512e4 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-GUID: KQ9iPVezaZJYwtnlecmpYgD9bwj7o0dq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-sm4450.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sm4450.c b/drivers/clk/qcom/gpucc-sm445= 0.c index 808b1eaa59d1..bd0f3fc2b726 100644 --- a/drivers/clk/qcom/gpucc-sm4450.c +++ b/drivers/clk/qcom/gpucc-sm4450.c @@ -754,7 +754,19 @@ static const struct regmap_config gpu_cc_sm4450_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sm4450_critical_cbcrs[] =3D { + 0x93a4, /* GPU_CC_CB_CLK */ + 0x9004, /* GPU_CC_CXO_AON_CLK */ + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sm4450_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sm4450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sm4450_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sm4450_desc =3D { + .driver_data =3D &gpu_cc_sm4450_driver_data, .config =3D &gpu_cc_sm4450_regmap_config, .clks =3D gpu_cc_sm4450_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sm4450_clocks), @@ -781,11 +793,6 @@ static int gpu_cc_sm4450_probe(struct platform_device = *pdev) clk_lucid_evo_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_evo_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sm4450_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C91496D2F for ; Thu, 24 Sep 2026 12:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251753; cv=none; b=qqmEu6ViIkTCo8l76ONPokADgK1Jqm0PZydL3LLiwP4KhoBYhpT+4gDR7Pm8koB7EzvYrvsHPhGAMI1JKQra7oClq6D3KbIyTRLjXxLbMRAqYZqmoi68f5Akl4eL4zdwRUG78cpH/cNzUZLXuyfqIzV2i1ViZ56m7c/nNq5b6QA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251753; c=relaxed/simple; bh=ZlV0ToIKIheLrRQzvesxiJyF6G0753SHmic9A9RRTjk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hWixAr4Iuo6JpndXqkteQfL1fHJcYKFdMyfVWF9ECJ6CgezKoA4XEjehInrOOBEdI/izTH3bQsdHvwp5S1ZDS5r5xmSJY24XDF09wYnPz7ogFlejmOVrDRiasfVvW4xLRcVhxmJGNMKMjMwuJaSPnysbvzX9XbIm9YPR2KLd0bA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mUqzIZ3a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RnTG/4nx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mUqzIZ3a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RnTG/4nx" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4TFi3282813 for ; Thu, 24 Sep 2026 12:09:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OMuGpuatFPZ3Bg+0hqcyf/x4nQdJJ6oYxUDjpEqSRyU=; b=mUqzIZ3aCF2zmXoA R/d9nEsH/v/jX4PF+zZ00vnjFbQvA85ZtDpBjQ2HPJdaD5OQsmt9KnRdZLUn+XAR hys83ZGwJAJKwaDtKZeUhWXMvSIVs9lAoQ9JVrcGDI5pleWpTgBid7/BmhmUkukJ e19dXRAmlLUJD1N84FaAvZmg4ngcJEuNZuYNQPD1PDgu8X9NbzuZz8CyM9dRWyTl pNDzNRX5R/phf0/dzB6JVkvseCQqaFNqfJFzsggTPRJaziQEHkinRZaQtNZpXeOr IVdpWAkQqVKAKmPmHiEpyeTK7uFaSxTRm74jQ0ziuNl997/BudVxkFv02L/VH2wj cWhjAw== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvstujfyd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:11 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5c7ab4af214so864520e0c.1 for ; Thu, 24 Sep 2026 05:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251750; x=1790856550; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OMuGpuatFPZ3Bg+0hqcyf/x4nQdJJ6oYxUDjpEqSRyU=; b=RnTG/4nx4x3XVv6Cq67ifDPc8aJYLRkboyMF28pLF0rNSyLwZTPFVSkwEnYF1Q1+tz 0wbHG4ezxyCHPy5IF6X9nxQjHc2N1f3a0sXW+AeifVKJ2aIw5cJE7TfxN2le/6e0ouhT uWfwQIy5rGG+R4EPvR7Kx8rqnpBu63jBZnAuYO5GjSNL8vWuwml8LIOLUfMad2zt9OFx S3Y8QNedngviHUC4BGR9AN+isAciCKKpu2knidCq17B2IeehhUDygYQpssIawLILZt10 zZqzOKSy2mGd9DgG0aRukslTiFLUYPRq9uEp0a2kuYMMEkEXJOeZXEL3DPn5Edb9RkMk fLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251750; x=1790856550; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OMuGpuatFPZ3Bg+0hqcyf/x4nQdJJ6oYxUDjpEqSRyU=; b=UfjX5Jm+EmVUYdHWXct6OXUApcrawR4Gia2LoyVvUk0qrmMhPc3Etn7IOhxslL76pM 3Wq1qTsJOJXx4zeDIKFBVnKlZ9y8ch8VF7rfiX+SIe4Hii6PP0YcbGagCV7ix3hOZoga 96mnKYjtTOB+j4/wEULWU0UiW2rG2B+04zQT1kPz9W6OOlZgO9cTLFpbHYfuH09icN+r 3qpvfe12T246b3E9WE8UB96zUVjM1luvkv3G2MF0+/eqD/gLcVwN3Rfs7SE2qEIFZZp8 i1UCxLczLut37jldxsy+2M2bDoyHYh5Vqo3iuHYp/p3dGDG2QwkvkTXb2U2IeNm0jv1z qV3g== X-Forwarded-Encrypted: i=1; AKwUvBzdII8vZAGHo3VLUADrCA2Ba7se1vgQeTM9YzxgH4k6q/ndcYoeMtFIyXwvCAU/fG1NzAonV2KpWAAdQHE=@vger.kernel.org X-Gm-Message-State: AFuF++mdkg9qSHSKRYURfl0X9iAq3p9cljS5lx2rX3CBB6pY1Izyrqij +X1FJ9+odVqcdOuvyHH9jrX6R3iw++ZJMNa5gSRBaaEguRD/YGopRIuc8zAe66ClvnG3Ui7h+jm oftS1qODrbMbZGMEsY1NlKng76kEXcPlGbZoSK6C8/tgAhFX/JTZ9mLboil+qnHFGR2M= X-Gm-Gg: AYBFou2obQGlk25uiQ0UjeO2vz12YSTCU0NyEnd0Y90ryaoAm5MPP1Bb/ZJvO8DLO3z n9FSPgTgYRVXI0Ws4REHFsdqhpNev5qiEOPWgLfsKBt2NV5T6QvsPMKCSRYU34tKh6oXfu2V15F u7dhRhai4OQygB2Hw8+MVX1LXnhUIaFS/e0cKmjryBq2q2dt4pig4gyZFIzLdEW1h6jGrlSsMVE P51lt3Jnygb4R/sdDS6f0zEQjVRooqbL52sKVVJ0EvCNjKH03AwjBgK3g46iczYJoC0rLj/rMy+ WQGJacMn9HeGzlFoTb4p+K/mYCHFnxki/lX066J2Xd5Zx6PmyHKUdzbLVv+jmLNqL3PffPbO2hW J6fVsuxI5 X-Received: by 2002:a05:6102:160f:b0:7a7:196a:84ec with SMTP id ada2fe7eead31-7af1f1fe5b5mr1088074137.36.1790251749754; Thu, 24 Sep 2026 05:09:09 -0700 (PDT) X-Received: by 2002:a05:6102:160f:b0:7a7:196a:84ec with SMTP id ada2fe7eead31-7af1f1fe5b5mr1088048137.36.1790251749022; Thu, 24 Sep 2026 05:09:09 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:07 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:52 +0300 Subject: [PATCH v2 40/48] clk: qcom: gpucc-sm8550: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-40-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1833; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ZlV0ToIKIheLrRQzvesxiJyF6G0753SHmic9A9RRTjk=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJoSpH0HQzLkTM5wfxmpv+jplK4B0u0n2GVE BVN2j8HSVeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSaAAKCRAbX0TJAJUV VuF1D/9Ml5SbMGeNznrPvr1sEeBSW593eGrbFmF4x+U/PEaC44X0SBXJeX9X2Q82TLY8OAvrcaH KBT5+LOC4nwgQK9lc8xxOxgVpRQHLsAeOiI+1xVWZn8/Pk1WkAaIF/HBdSa9PauAIX7psNmWgJ7 4pbIT83iiD/8GgJ5cBlE/lyfUvkomGJZGS25BOhcF1pOWZzn5U86ogqpJzwVtSiHPU31xK+zwdm EtCxFhqFymxH9ry6beajozCFvKOb7BMz+D48EDw5GlsEImSYNrYhgh/lhe7pnzJNbKNvwL5LeFV N3w15rL9ntQVlz4fCgHhu83py0m9Rf0ShTrqo9rP87aPraHwlPL1FGcsB1NT2iTjUXvF+3KhZWb tNy1TWtVPNCpozQfe5t+g9XMQ5wVXCWqg8h6qqxwcliaFUDOAHEetdObtEJuoA1dghrjzvH2uNs X6YVNIljxThsKi+SexNSbWcR1qj1fp4UBhIBxKHfmLbsQOhiIbdd4V9s+1XJAQTZoPzuePe8BkO L4b9pOIYmv50aym6PccXoYgmrBXaLbnX0I+ZzXIBgcEP7yJYIs/hzd3ll1KTh/sbFEAb8NISqCh DFUfE3YoDHui5e/PhEwclW0HyK2P430fyWTo1bwSP/ojMGC8fKjPuqVRV2/CC92MnBKEaA+as8D nDv29ftSrxxxP2A== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX3TF+v+EaB3EB H233PhJi0YjC6BNtWX/m8IHHXZF4K+LE1D1BeHvOziZI2xZCSKi1L0ffwZHv5tBncs6KrrEhcG7 xfcRha6aRCzTBS9jWCqJSHdQkOVxvfs= X-Proofpoint-ORIG-GUID: P5o4SgQvOmvTe_69WWROHkEexEjPoOlR X-Proofpoint-GUID: P5o4SgQvOmvTe_69WWROHkEexEjPoOlR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX4/B47SDsY1zL 5bAFnFo/M1wDol3C26ltWZYhHcmsLzgXIM9klF5HFKDQ+USPmtNjCxdD7dxH1SX2zOHGnpxWy4B tUSg3Z9ICPcOTtFmdpG/5N06TLCBk3Uc9+AqxCW2jCeoKUVuyeZh4ZXglY7PcqysKHNTk9XKOPE Cx0D8p8L5ons9DSs8WW/lA/AIYPcNGj4l9Tzd9H56Hu6nw8DvPFOODa0Nyw18VkpTkGQ2R+iMNE FidGgBQoZgT6oTUXkcQpMBc37tXEe9yfV9XrKmK5zUpztCpDHysddsVam6qHhIVLsnL5ZrfHo+s ZzFfyg21a/FWa99iyhDZBtzGCEWip0HznMauiCoJQf2MmV3MkibaQTFWiOOoLDM5Ntkq7rrqelK p6olZjIGXfFYAD//bwJFm9oYg/bCLaooow5ME8OcJ/5P4ON+3nNKfu6bA+v4tDI32c8pQuXP7Q6 xxDRzzJI0SpdZ5n/HTQ== X-Authority-Analysis: v=2.4 cv=cKp1IVeN c=1 sm=1 tr=0 ts=6ab512e7 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-sm8550.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sm8550.c b/drivers/clk/qcom/gpucc-sm855= 0.c index 53614e980b26..f8dd1727c080 100644 --- a/drivers/clk/qcom/gpucc-sm8550.c +++ b/drivers/clk/qcom/gpucc-sm8550.c @@ -547,7 +547,18 @@ static const struct regmap_config gpu_cc_sm8550_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sm8550_critical_cbcrs[] =3D { + 0x9004, /* GPU_CC_CXO_AON_CLK */ + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sm8550_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sm8550_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sm8550_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sm8550_desc =3D { + .driver_data =3D &gpu_cc_sm8550_driver_data, .config =3D &gpu_cc_sm8550_regmap_config, .clks =3D gpu_cc_sm8550_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sm8550_clocks), @@ -574,10 +585,6 @@ static int gpu_cc_sm8550_probe(struct platform_device = *pdev) clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sm8550_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4950649B201 for ; Thu, 24 Sep 2026 12:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251754; cv=none; b=oQEdhAnxELpBcVBUSazhXC0puy/u2XPaoj8VFbrsFiiy5deanndUSEbOIfZdjzD6z7zWgr6jXXZ9tZ8+UUd53C+COdOS4QxWvxT26CQA84eJGUOBhQh+AE4ijzre6PShzp7oUPJRqVkN0SgyEa5ANWuy5HGHM9AXXhikrNyTfR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251754; c=relaxed/simple; bh=go23fVzIuD0WYJGICdaRrnZaMgZbehWOjW07vqTupvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n9GXs7OOGHK6d7BI4FYul7mk6IvdpRxSn3bd8QezV2fS0LPn5AITfnlDdD8ucx5qqHjzMXq2xfjAGa61yEkrgWfHT1UVa4O/4Kw/6aQeU5UOevipWQMbI3N/lh6godaMUbpBmNIWu3xCLWvpjFADrB7YA37AukyNUjTY9nVMyuQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tc1iqxhL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PIqI2D5l; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tc1iqxhL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PIqI2D5l" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4WuD3134060 for ; Thu, 24 Sep 2026 12:09:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YyIrMqDjgclq6Z9+jyisqmAzAdaX1WE5GYxOifG6sPA=; b=Tc1iqxhL7bbEo6Tg Ww71+63N8u96AutJxODRG6neb6qhCKFmveCPPuSryri6r/VOAakaE1ZVvsNsahjY kLN9tKtnP4LBF/wWAKAFiuI/bCMfTwhezha9wEeJBUrsZJo7SMvDf55hSkymvW2F FIIrbpGo8smlrxzjvtpRInQ1ZSgSSm4JaDB2D6X0qljJUTAa0jOnXU93V6otMmfO iSxtpHgKrASIyWdyOIFkjMusxWaHywRVzKdHeApxMTfKtEVZ5daXTy/jpVD3AEK1 xdK0AsqeypgoyYbdXiHPgHmskC1DwmZTa4Zhe4W57yp6pwaitOLC01YXneznodwC puXJ5g== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1raggq1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:12 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-980989f5030so1690698241.0 for ; Thu, 24 Sep 2026 05:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251751; x=1790856551; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YyIrMqDjgclq6Z9+jyisqmAzAdaX1WE5GYxOifG6sPA=; b=PIqI2D5loHdkdCmJE9AT47FXCl3Qw1lOh1Xrq+8/pJFrfb2xlmlDnt6EtkdcuDikUU w1BKnhj0X7IQrmlCXSN6neL8JeWjsajg8VMIi5XruUZLni6rci35631VE/vxq4Wht+Cg IF2C/ydXZilRiED6qDCRN6IBH6Q4xPYDSK0UTK05AbNJUPJLaX1wvx3xK6Ukktya7xvj hVW1Sof9CZoo6Hy8JULWSx+U1MHH1v3OeuFPmrjiQ4XBLD6G+nq1oneTnRKeoQU9k/sU eEpvkTj34fRyHwYYLGEMhU7Ng2/Dftmn0lgQQwqMrcRXbgRLwlac4VSp1qEoASLj67La 6rOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251751; x=1790856551; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YyIrMqDjgclq6Z9+jyisqmAzAdaX1WE5GYxOifG6sPA=; b=eyTJjn1PDn7AuyCKfIOHJ9SBHtFOjrMhptMVpNBczyNDD4dHQeciBxNOMcpcCkBL9s L4aq3JMavaANKfyQZgc7LH27xDdig38mcX4gli/JODYmYwDSOEYIYy3XpeP4bTNI1JZO DCudiwwaUlWn6lwWYfa1hTGH/Ho6engTBjHyjVGl3+HjLzQBUTV5QzCEn9MxyCsSxh9Y HbyQYVwwkUGzgmUGCzIa3eMYBt9Y7y1+btHKuK2udl8uMMZxDcOxLFf9Qj4FnP/NugEb qNSo9I8wGLun6aBJ2r+RKZNo0sb9zBkTlc5EuI3C0nlanYdYH33IuwqjrpoApHq5C+yR BFDw== X-Forwarded-Encrypted: i=1; AKwUvBzSyZodCku8kOigtuk1KheIhtHft9rve8SEj9fehPpZLdT1hCHzMH3sjHCotP4wv5Yw7BpQlYShKEHGYbc=@vger.kernel.org X-Gm-Message-State: AFuF++lopH/Sylk1kbQ/yMSk+C1kcCKmusvh+0+OeMacz/INNleyC/UX dn/ZH8zgMo9UPTalQgXS99FPtHF9qqytazuCJdg+qSXvIb9ccBP26qtw2ef8Sv0Ms91KeM2pX9L XOeDiN+nfaCnRiTnqJNkeEZeJIo3jvHhqFrZXpi9lGuOex5VmzhxiwjSVeleAEUtll7w= X-Gm-Gg: AYBFou2k/WJ+MOIK5dNk//m06Wcwctzs+46+8dHSTvV83A4cfxWCVHo5aZwoc2/f0fx Ou9cguuZqetj3RYfKiM1TVNO/tWcwTp7R8iO7FJPqhPCoP3sVi/XYleHTDYOZarI2GZs3mNCIOv 5ctIiINiw36DJQP5NoNyD8R98ScM4GGYvg37rT2TLwbXOaCoNURgdQEyuapdjkLuW0ZLfwXR9qG 0R/sl3F2LVr8Nmj7D8vBatGYezNoH5sWqGbyLg8wRCMyIiEtcbWFPZfCynJxzyzUv9dg/eL1YON RKw6qHocK8BHhVotTp9IsxKMBS6mKGZ8jCbhrcXh3n803ZYNgopijsJQsproRx/MZ+4nooTHEoM +ywFP570F X-Received: by 2002:a05:6102:2927:b0:7a2:568f:815d with SMTP id ada2fe7eead31-7af1e6f7995mr1166709137.18.1790251751357; Thu, 24 Sep 2026 05:09:11 -0700 (PDT) X-Received: by 2002:a05:6102:2927:b0:7a2:568f:815d with SMTP id ada2fe7eead31-7af1e6f7995mr1166690137.18.1790251750772; Thu, 24 Sep 2026 05:09:10 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:10 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:53 +0300 Subject: [PATCH v2 41/48] clk: qcom: gpucc-x1e80100: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-41-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1750; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=go23fVzIuD0WYJGICdaRrnZaMgZbehWOjW07vqTupvU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJpnfB8dfrJK7m9Gkr6VD0RdoQ6f1v8mKbu0 3AUwXBX0WyJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSaQAKCRAbX0TJAJUV VtGsD/0fwn6mHHmCTTYAyLwWZ2WGae0TxPyeehWERo8g9Ersu7Eca0iTaVkCgZgi1By8fQGCkTf PFG8KU9J2t4GlnU2w9PpcsXoLN5TwIJp10qBmFrzvQPCuqwM0EywjZ9YMOSAJdDqDYYrYVoLGdw OcBswQkxoxt6IXXexbo4wVkih6ksNQeBKyEA/UFQCU9rYao8hAmAJFVizlYhhLjAeAYvZ7olLNL cTKtUkhePWQ3u1+gWTKWVcmSwg2++q/2CteGRsugGHdAPOTov9TzBytCS6IZuaMenY+d1RrUEtE CZJoPK2fCMpFTn8/OtNSKfeXg7IlOEpwhw1A9AZbbJCRwMSgx/zXfkU+T4BbllmaYtS3FBfyFVR jg9x4+jMFpKBzXAxxKwAe39W0bGcja1ECanF36quYKJbF2taA6iSUomg2VhPoDesLhZ2CB8M4Mb qghMklznvQknpSrkC/xbQ/LEeW8SeoPea53OddjdAHtezDpNq3DzE1JX3hGfNM2mSKv0KWen6Fh RXNVOFOY7n8lAsXfXtvPI1ps0LXAaYisB+I+WzNQc06/QyAHpAxnnq4IlKX7tGY3nY2+7rFTP0k eH8GvPSr8L9kxunYJNPQ7U8s5ktZm2+k0nAr6jo8cSErEry6xQvrKYSXK000qrYQHsC8zMSRtj5 /Iqk1abvVT8S6HQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX33ZBZIxFbd8G li7Zq3V4haeuk5gnqxFjBZwqU3Z4WHJrX7/+GpAW99mMApskd9fgtBVN3tBKI76ZjQd5Rwi9XwD 6ZDbB8mghNaOgBApbll8REllizj0vebgLgKOni+0d5aPhbEMhOE7TbkR3ODqw1QplBqoyk8z+IP W/RpfpSTCF859Zy/tWovKKzh9GmJFXHsOm4o4JGBL00MWirkg/cXMJxuGpLmapNDxVqf3D6asD7 hH9aHkaIuRc8wQlvEXuy9lU7SXzxo1+qbvkB0vjeOXRjpmyQc50iQUdMI+ubSybgzqTW54pgDq8 3+lygVUfayxAZFtfFbRxLHKXKRdLaf6Zt1W4Oqx6LBVfa+x4lHl5SRf2Xx8EdkqA87Je0F705+U Sj073kl5PRV5V/MqF2nsLEalG6uGgK4R3RY0+2z5+4LmpuxRnOn4YOG4qwhiCf5MGdSJxj+6of+ r37Emm+f82O8CQ9Kb3Q== X-Proofpoint-ORIG-GUID: Ur8zVLHBDCQ0n_M05OlvtnYB0kTdHxC8 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX9V1zlUjLgoqb AxKJIcF2QTyIaw4cd9JeRlUnCK2ghL2GF1xqXra/crhKDD0+blvYcDonXTbuT4OwAQ+2CLj36yn vRqDW5I9rj1Oq0iMM7gKRDX2WFzwXSI= X-Authority-Analysis: v=2.4 cv=fvpJ914f c=1 sm=1 tr=0 ts=6ab512e8 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Q3WM7qoV2j0wxbEI33wA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-GUID: Ur8zVLHBDCQ0n_M05OlvtnYB0kTdHxC8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-x1e80100.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gpucc-x1e80100.c b/drivers/clk/qcom/gpucc-x1e= 80100.c index f9161dbaedd7..10a0b11927e3 100644 --- a/drivers/clk/qcom/gpucc-x1e80100.c +++ b/drivers/clk/qcom/gpucc-x1e80100.c @@ -609,7 +609,17 @@ static const struct regmap_config gpu_cc_x1e80100_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_x1e80100_critical_cbcrs[] =3D { + 0x93a4, /* GPU_CC_CB_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_x1e80100_driver_data =3D { + .clk_cbcrs =3D gpu_cc_x1e80100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_x1e80100_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_x1e80100_desc =3D { + .driver_data =3D &gpu_cc_x1e80100_driver_data, .config =3D &gpu_cc_x1e80100_regmap_config, .clks =3D gpu_cc_x1e80100_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_x1e80100_clocks), @@ -636,9 +646,6 @@ static int gpu_cc_x1e80100_probe(struct platform_device= *pdev) clk_zonda_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_evo_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */ - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_x1e80100_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF4649B5A1 for ; Thu, 24 Sep 2026 12:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251757; cv=none; b=dnswr8LrqJQug+4nwLfgQi+51mZ6KXN6ZX7rrStzT4pJqn2SHK+IFtu95V+YL++EspZBwgY3Tgk7ZLm9mmdgJc5A2zQNY58hZ2eHoVzAFlvjBjFiBqtO9RWfg8iL0bh8P1NuhwpPoP9JqZ+xcg5MW1tjBhLTeAhx9sMetZpU+As= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251757; c=relaxed/simple; bh=hSMBCUSJLODBj/QMnEWIHI6W2J4kYwr3G7rNE1Tk1f4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ky3tOTevcyjDYofhoGKi2COcTHXHVkm3Jehq8CsqpsqaNNTvLXSekwA1U34Y9cfjX5FcW0InaOM4bY8H3ta+TjFVS3n2jqHr4nnrZh8h/bNtD4jCP6qPAclzAo2NJ1hVRcGPGbFuNYM2lNI7923w3hL0LnMy03x1R5xdyR/yayQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l2devIni; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G18RN472; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l2devIni"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G18RN472" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4eAW1437096 for ; Thu, 24 Sep 2026 12:09:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VdEyG9Ski0zk0dTxnSTkOQuUEfWwpxgZdeJl7X2UE+A=; b=l2devIniKxKLE2Kh uJxfNzezAcOWh0xdLm1YoOqIotadNO1P7+UqrUlJI7oJ0RfpfQtv7WobImAloG/1 uE4t3H9L02I17E0XSEm8MvBvNkZld9Nl1J3URIqwSqNX8CLBEbWFu6WeT/jZ/Sgy qL7HKho4XRg/96OjlCG6PIm808x+TGxzMRJwC29RNv+D3lEujfsO3kXz4sHWd5Ii C9sB1FkYQgqzRHbnGhAkMfOv3geKVX+18hNuH2kNWd3sWfIgE1RqCTsodlxd3NDY pjt6dz9U9uFOief8LGYadG0K5u+Su6CUs+m4WC4E1CkUDydQxdXh8zvRrvWNHPwb pTahag== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1t7rerr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:13 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7930cb5cd3aso1647052137.3 for ; Thu, 24 Sep 2026 05:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251753; x=1790856553; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VdEyG9Ski0zk0dTxnSTkOQuUEfWwpxgZdeJl7X2UE+A=; b=G18RN47226bDG3/T5oI0M/hmiJJXgvKwF0c7E6+RUrjz3AlAkXhbLaVdqIBOOQ1HVO zeh4RbP224VamhsB5v75nR4noiFyGuX2FyIPIjw9mM5B7c4266PKHcBfhEM28WdIvsK8 +3QzUPqVv6gyO+Utlu+VvsO/xO4bvParGAQe5Zj/wW8lQOZlqM0CRUW2N/DvXwXvz4Zy GaYNLk6Oh9vNY5YK0G6xMNkUDCGDYWPscPoYinpeQJVouHELy34xX5kwTg1aGFX0y3Un rhUtvwBPG2D14RbGzY+2N9Zvy0+PyHoPbmY7cS1X6xbJWsDwpVV1RS24Cg6iOe+0Rwdh t/9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251753; x=1790856553; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VdEyG9Ski0zk0dTxnSTkOQuUEfWwpxgZdeJl7X2UE+A=; b=tlg8hU1WKFekz6bc66zO42SlLsHeo1JnqI5jfzmNhXHV2mUvOzeBznt+v6hYHBsXgL fmIFZzXvKIgPDxgIOWWh1BdlUlcPeAzEHfiDphZ/LIiT7vgzvxGsQDj4oV7InZOaTBhJ Hj77DpIqbKHQ2av7CQzsSpZSQOqjblpq8X/tFsBXUMUjTiF+DpQDxBm5e1oSxywzq7rX MjDWeU+PDHm6ARG63FmanvFWHaKBPgbSoh2OY+CFiQk32JS7OBExZJqA1Y9fEcMmk/g3 7hmjEfUJ0Qp1eSQhpy1d0Gqtwc/VH6Yl5DbwFXXlSamORIEuiaQllZfnIjMpok/ohMIO mR+g== X-Forwarded-Encrypted: i=1; AKwUvBxkNLJOJx93uFr0wrJKdnzi3TiSZXMvfBoSyPYoVg46tamPGTnH+IpfH48R3wwBgX6yRJG6xo3mCnq/RyM=@vger.kernel.org X-Gm-Message-State: AFuF++lJLgnGjMwEQKuhJstePozQD4PCUr8pioY5RDDRoJ2c8oY7IlRw bcuZlYPAjRmQC1wSp3oUjav/vVmCDdiJl5lg2zncPt9HjEB3b6AoIZjeyJ4xqguFM3s0yrdsoNj 8H6aS0h4ZFE4x88doI8jtgpfP06FMiUMzgpkM68mHd+KidnKxd2G4dabhpKqvMNAUXjGyxRS+Wk Q= X-Gm-Gg: AYBFou3Q8VR623sMzp39/acTDYz7o1L/kRBVNh+iYr8ijOENVZW5axIqlIcsA3xhSsC 05MGC88xKb8txXEejbIaJsSzkp8ZgycFze68zKB/LS3CS8yMKBOy2HtzhLOstByw2j8XSIb2HuH YvF0ahBfqyNPPsbQ7etydqHs7KhgG8qJO37n8/cZ+Ik+wSzc+yHH7IcIjOiIoWTssILJsTxGE0k 4zeLg4VKTA7IXIMFsUmw3ztysXr+C2eztSdpZR8aaV16MMXVKSCoXnNrskoAFAdTBxkP6oMNXRJ +zREe8JwyCQWG8mgpTeQnHarMHt5nVQ1p5w4d+UJFQj0ER+4r5FZXnR3BerUFnA0TjwjOyc8odf bsdZ79za+ X-Received: by 2002:a05:6102:8099:b0:7a3:2e52:1163 with SMTP id ada2fe7eead31-7af1ecf1936mr1330038137.26.1790251753010; Thu, 24 Sep 2026 05:09:13 -0700 (PDT) X-Received: by 2002:a05:6102:8099:b0:7a3:2e52:1163 with SMTP id ada2fe7eead31-7af1ecf1936mr1330017137.26.1790251752432; Thu, 24 Sep 2026 05:09:12 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:11 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:54 +0300 Subject: [PATCH v2 42/48] clk: qcom: gpucc-x1p42100: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-42-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1994; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=hSMBCUSJLODBj/QMnEWIHI6W2J4kYwr3G7rNE1Tk1f4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJqNv7IznQ/cpDJBdAvBO25U3BTH6R91Tn94 Lx7R280tuWJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSagAKCRAbX0TJAJUV Vqu8EAChyb804l4SPuVNavT8pYQWWC3t0JkiAbdEcg/W4MEw/zvnQRRJ1i5XPKVeYsNWSHC9sug 3CgRk1VOdFWq0JQCweyxHr25H7Ls02wjeNHdEW1WNovmeJocdtNrr81VCPRHD1Gd8aJxgSBpgW9 uoZ0jKyLcFHoxO4QTAQWGHYLnqJHdNwDOa+ctfM/9/gAAMUbHtfMlX3uN6T0AIX8/oYA4iiKS/m 8D/jVSq90nSHP3XTQtuBY9ZcvZZxvpcOBAiBEy4oF5S+4OpyyKx34mxLEz32zF5cardFawfBs3C fHK9Ct+RM/tDr2lb1ifN/MaYyz169QmG7n/8VPAzdsC33EckJwg7Pmhjtn/ncjkvYWPo3udpYdi 4dO8t1XmJm8OHf6liFwYh1yarw+xaqIg1nL5QdQut7v/QN1xsBQ8ZvbryvnFbyqO/9kyeyVdYgC gGW+7BI12CBIX3oAmspzeDZlaZRC5+dLh6wZ+g7jOruTFZEfTFvVLTEKMGdZ8MuNCA2Wr81Bytj oNFpmRiykw6GvV1muncKRDjvg9/kYE3hxrBwBWogYd/zyZc0DZI0A8sP9DInFNP3YlB2AKTKvtB ygshBq7q8CbSrFjyfJOyrmoWRzVnt33mjyBHbFNMWATtfSLXOGFZOgqH4Qhj95AyNitQDNFBmK0 pXPyPl+C/qRKa+w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: BQgOxeWgF0QlA-_KsyRgMt-GGoYs8uGf X-Authority-Analysis: v=2.4 cv=U/MHnuru c=1 sm=1 tr=0 ts=6ab512e9 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX4TnpQUQcYLRE 02LRmQ59+yxHIV9A/slLBq3ortH6kx7GGX8kc07fCe3x4NKnQhZ1VyMSztwvcrqdpCU/XsmaQ8B 4kTIdrAtMPBghY7FwLTY9aW/Q3PcbOb6qRuuSSZdvKhSb+U5MGEDbPL+NmYD2g8eMngzD6eAmRC rKgPFfLkUoksWA2S05z04ZIbGkbd7yV8PtLIorZqbk0h2qzIvFhc8iOQqT6uOKMDxqTYdplum/O bD7FMYjIbe9mEdFBG3av3xNYYWrNZZHO7S3UnC0ZnTiUnwsm2NS6xFoW6OtbOcrMIJEOrvR12Hr zUQ0V92gsTrUhd9e//gNDdG6BeZypmVU3dvL/83Ra4On4uVhP9PflBL/vrwp0k2ozEok6NbxtuY ZIHqxj7vElMYkmzW37hXgiiwIPj9oTppmkOEd1NtwDgnnfSYebJfcBz56TXFPrxJ3teTU0IZnL/ 6ZZlz1ICMlPcXRfzTcA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX6gGo230VZmpi f5h/qH+6szOLP6wM2+NhMZZ/QCOZkayJO+gXV0yedbjQdiRc3+p+UIOJR8Q2Wc3d0k6AOqhcxNO pwlUs6mULTvHlk6WCym1yAgONWl+fjo= X-Proofpoint-ORIG-GUID: BQgOxeWgF0QlA-_KsyRgMt-GGoYs8uGf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/gpucc-x1p42100.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gpucc-x1p42100.c b/drivers/clk/qcom/gpucc-x1p= 42100.c index cfc34e0fd290..3f3fec257f2d 100644 --- a/drivers/clk/qcom/gpucc-x1p42100.c +++ b/drivers/clk/qcom/gpucc-x1p42100.c @@ -522,7 +522,19 @@ static const struct regmap_config gpu_cc_x1p42100_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_x1p42100_critical_cbcrs[] =3D { + 0x93a4, /* GPU_CC_CB_CLK */ + 0x9004, /* GPU_CC_CXO_AON_CLK */ + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_x1p42100_driver_data =3D { + .clk_cbcrs =3D gpu_cc_x1p42100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_x1p42100_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_x1p42100_desc =3D { + .driver_data =3D &gpu_cc_x1p42100_driver_data, .config =3D &gpu_cc_x1p42100_regmap_config, .clks =3D gpu_cc_x1p42100_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_x1p42100_clocks), @@ -560,11 +572,6 @@ static int gpu_cc_x1p42100_probe(struct platform_devic= e *pdev) clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &gpu_cc_x1p42100_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D01149BD85 for ; Thu, 24 Sep 2026 12:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251759; cv=none; b=Ue1DZAxuamEhkHn8HMsRTtYYHVe/M227HQ1lql8yZkvZBXZ/qF3cK8FJIola36zZFMPmAfPCcpgyOlRMFYC6beWCVAJs3SpZDFJsskRECHHgLbfmVawwh21hq8+2wfmDFKFYGpIZ6A++88D4uXnrQKw3xuL+pAP16xeVDr0d+CA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251759; c=relaxed/simple; bh=Ur9XMo8/WNsqyrpM/jASCNCoKeitv6aKZHCBTi8YLvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u/NKMMEuXWTzhWmwR1Cu7GOPyD9pVLSveLxT/J7YvyuT4D9hlbnc7r7OP3yET9iuqFPQW6VHajUvBa/cE+7uECwVznSNyet2KR8XpV8dpEmxL5LPZaPUlsbUQdEYzLU9PrKHAoRaZ5OVgCq1eqzAChvZ3K/IJYVkIGWJS6JjFKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FmFzFtmP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fo05IBzk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FmFzFtmP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fo05IBzk" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4WAp2749207 for ; Thu, 24 Sep 2026 12:09:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ublmzr0ZA26jmxEwj6p7kovHMeaRLc8XdUhY8Td12pM=; b=FmFzFtmPGKMLdObj SMKAf/R143wIpdvRc9ZVsedb8gnz3FVa5AfqJJiqLj0Dr3jNt7XWDFXGgxvRz4Mi uJ16omqoO/WYQWOvDyVAc2T3VDvxqVTPM4WZtoUboqEFmjJxL6yEUO0F9dvVX60/ 1xtFuy1ZWHYOBGrUMKEa/bBDQA7pL/ORCpvX/zH1DgNQ330OIjt4rYZXV69tk1IB vyu/PPrrSJZF4EPHE+ZQVOE/ZQizur4QohsimTp6z6fOu5MJgF2x38f7+FjIBrJy 0CqXR+8Ych8LR+mx/eLFTrlFpjRWVhQtdHjuaG4/9sV1QqyC+9+r2AkqLvTiWib4 xI+1HQ== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1s90evs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:16 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7a532e31dadso1933384137.1 for ; Thu, 24 Sep 2026 05:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251756; x=1790856556; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ublmzr0ZA26jmxEwj6p7kovHMeaRLc8XdUhY8Td12pM=; b=fo05IBzkYvr7UIo+bW4Y50rbLnBGXeBCtQ539g5PasL7s8U2yy53ZCfkQS9dcDxRtz hgaH1FMQVYZA6WNKJveEWi1PJUyo5NIoDDcSJikEPtOdoGmP/DDlgk0lclBLc0+ZItXp xAdO8S6QGWyH/WVkerTlsCxFkvgPDgmlZNcd0rrV3YJIqOUc9+uzCfZRiQqu6/rydIQj HczHzI5vPIAq/FgsZLciIpT/JfGyVqABCcld4BpU6vlnGmZKb0nVIL0/q7RtP+Uw1CN3 IqWJk+dzF1borUiOKSApbB81c2I6xhaARi+DdH66a7wOhrDga0hBJ2nxmYYQW9XOHma3 x4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251756; x=1790856556; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ublmzr0ZA26jmxEwj6p7kovHMeaRLc8XdUhY8Td12pM=; b=wgObPlFDCix7PCKNH3LMNnzsVLUVi41SRMWroP/r8xt+4CfOAUFb6FFowkDUFE1se8 1lE59YoKuCLhU0R5NyEP4GDY+NVY09AkfTEXDk40WEO/3vGe/d8/UQ2sCxJ3Nt+R8BxH u6VqO3iwyG9m6nQjbVt9nTiysQ3Ve0oBo67KgAGq6kyjY1lfiG+FhlAd+bHHLQ2J/Jfb +qbZVkNyk34m3BEVQpmFvExmlnIGW1i9GfA1XNdMO+KR3aMtZa8fPKJmMNUsj7MYSlPd f1ml1zQF8kL3jEY7yaRUjWAKTQwfVsruPU60D42AJ4EjZOk3Pt7KvMbIZjYLFW6v0I/u wAcw== X-Forwarded-Encrypted: i=1; AKwUvBzCHfKkxWRkNYM5fCBXqB3iYmjYttfLYBqF4b50dlnpupnh98yvkqjAzPtE4JTwi4pk7CdAVvOXp/s5agQ=@vger.kernel.org X-Gm-Message-State: AFuF++lKgaRMqTp9C9tOMWmxvIMlgjfTzMpuVFhjkCb9ypn9CHmn+kJC XICZ9pTWTSQLI6DKxRbPsEbT6eEvHsVZfYrG/nWMro4uvSLwtFpjbLTgoY2Sjg4OIG3xdow9OFf FL98Egxw2JZUEHV1vlWlpo0CoULiFxdJwFXsQnM1Q9xEam4RQ9ngNfjRnC3vDLg8kgl0= X-Gm-Gg: AYBFou3umqaGPpNCuCFtgcy+JG3VdKnBBG+JavYlPW9sAdqTHBfNVHT/BM9O70zC56Z RXXOhd/U2XMGzMSzpjpa3hMO75Gy+DQaK6t3phqFVgTqplf1rn/AxZNk3jtDoAxYuGRRXahSJdr FAcZ7j3OBmJrODC5PC1nrRa0PKHK9DZ0Kg5PTPXlX9MHD39vMbDzfjYyYFVhG2ElVfrKm2YNQzE qK6dOqueRMkm9oJB1ETW1H1MgdKXylt2qshNHTCCwQ1TQ5pHKwPwPxJfrTR5L/g/uRg27mbXAdU akFs3KfVM0meglvH8pW25Rf+vxi0QZV9UXM6B4hO6OYIIGAS9vHzBjZ6Zn7V4HTSEN+BziSv5JQ 1BtnY8uBw X-Received: by 2002:a05:6102:8647:20b0:7af:7e52:c7cc with SMTP id ada2fe7eead31-7af7e52cef0mr403113137.34.1790251755523; Thu, 24 Sep 2026 05:09:15 -0700 (PDT) X-Received: by 2002:a05:6102:8647:20b0:7af:7e52:c7cc with SMTP id ada2fe7eead31-7af7e52cef0mr403099137.34.1790251754946; Thu, 24 Sep 2026 05:09:14 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:13 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:55 +0300 Subject: [PATCH v2 43/48] clk: qcom: lpasscorecc-sc7180: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-43-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2598; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=Ur9XMo8/WNsqyrpM/jASCNCoKeitv6aKZHCBTi8YLvU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJrThymT6e0LgYFngocqyzSCyAxLkjvP7ec4 YqG0tsLAgeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSawAKCRAbX0TJAJUV Vgk0D/4v4cL3cgN+frv1v1B6nuwbjXJfmjDb3QOvH+8XJ3pV8yI+wLLGVwzidmiYDYggshSuLMa NXkq0X2sRH7P3NCr+VOg7DcwyNx3sPgkMAJN3Q7Ugj9PEVvb4N0KfHuhg+Qp5F1TVvkJvfrk/jw S9SjhaCjm//TAnGO3GuRC5/gVIhEfXAzFRVYX0VyqUADufJH2alCrwsWuPRlsWkmoifwi5jqNKO djdLeyRAN9kWiZw3g7jsyBsOHwZ+/nbYAsKCI+6WjubskYWsnbTiW6pJ6PbSKID2UMN6eFtCfA3 HaF15w6gGDInsXe4BKmf99P77S67uUWqRBG9xbmnT0d/+n6ooiQ4MzM8OuVA5LP8NVPiHj6g4qi 3nWt5mldze8tngE/N89Lx/J3bN83a+4TYHoTS4IV+19wKeKYJ31p5cvXIB7AISyKXFqiU+aWuP1 axw7YiOkttBRmHy5WD/T40uXeMf88uQd85C7bfrxkvQ9L6ypII57KdJdZa5CHD/5J5H0PEYN8bZ CXgaGHBYcmKS5sW3DV7gtMh2uW+hUiq6STSMGH9KaTf1MlyHVzYhxTinC39d5QinMUMCG0P6+Bk GWuP52A6cm5gEBWqs+Jm77+fuNiXKQ4+tzaSfh2vXWQH9xv2957JUEcOMQdwlodYXJuEGIGjKb/ yqDYk5/7EDt04sw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7ovwAdgS7YWU kzU7E4UtbSdaJEYTnQKvsqz2KBAv1vKYe8WbukSMUSWjcdQYLNnNNfSuMdfkRz7yrNxr1rarZGj 4U/bLMHd6f+JyvBcWfFmOQPRP8Axbp4IAakkcq8OpHt4nk39Ci9VCcB1c8j9YIlGYTHjUeDcETM 2a8paIcfl1dXBu+HFZCugABi06JPKT0DnSfBTWdxM9DigbmnsOTmnBObGUgnAsgkLtsFWmUXgV/ bICJ0z9lIXxDj8YPERCeqooFLZoTz5/paWKu22uJ1v3D3DdBv4jrWVdkNxru0d4PjT05DoQKDeZ ndWAEOqae46j28Er+H2OX/15KetHtCoM/Y4nHXuNVZvNVB90UXNNhJ8QauCZPduh5lk8Z3UW2Tl HLdnw8DKANBUcvyMUqGc30mTyubHrq28w7ymbRyN9Isuh8CYfdUI2ZZnpZTZIADvBxxU+OmXrMq vJzuoP2KoXIIsltkW6Q== X-Authority-Analysis: v=2.4 cv=VPxIDNPX c=1 sm=1 tr=0 ts=6ab512ec cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=6y-cbsPRrUJUYPj_W9gA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX3tAaSPaK5ReL fluE1ze35+OrHfOZku+rwVykpIGG/RikrhhCzZLmoVh6K1jLqbO6IvymjI63uhfzRXHX39Pz13m xGbj8coQ7NEjfkOl+Z70DVgn/XGK8dQ= X-Proofpoint-ORIG-GUID: 7emAfFKyuvvQG7TgCXRM2Z6OSDMpMfbm X-Proofpoint-GUID: 7emAfFKyuvvQG7TgCXRM2Z6OSDMpMfbm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Move the PLL register setup into the clk_regs_configure callback so it still follows the SYSNOC branch enable. Attach this data only to the LPASS core clock controller descriptor. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/lpasscorecc-sc7180.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpass= corecc-sc7180.c index 5174bd3dcdc5..af28da5f04b3 100644 --- a/drivers/clk/qcom/lpasscorecc-sc7180.c +++ b/drivers/clk/qcom/lpasscorecc-sc7180.c @@ -343,7 +343,28 @@ static const struct qcom_cc_desc lpass_core_hm_sc7180_= desc =3D { .num_gdscs =3D ARRAY_SIZE(lpass_core_hm_sc7180_gdscs), }; =20 +static const u32 lpass_core_cc_sc7180_critical_cbcrs[] =3D { + 0x24000, /* LPASS_AUDIO_CORE_SYSNOC_SWAY_CORE_CLK */ +}; + +static void lpass_core_cc_sc7180_regs_configure(struct device *dev, struct= regmap *regmap) +{ + /* PLL settings */ + regmap_write(regmap, 0x1008, 0x20); + regmap_update_bits(regmap, 0x1014, BIT(0), BIT(0)); + + clk_fabia_pll_configure(&lpass_lpaaudio_dig_pll, regmap, + &lpass_lpaaudio_dig_pll_config); +} + +static const struct qcom_cc_driver_data lpass_core_cc_sc7180_driver_data = =3D { + .clk_cbcrs =3D lpass_core_cc_sc7180_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(lpass_core_cc_sc7180_critical_cbcrs), + .clk_regs_configure =3D lpass_core_cc_sc7180_regs_configure, +}; + static const struct qcom_cc_desc lpass_core_cc_sc7180_desc =3D { + .driver_data =3D &lpass_core_cc_sc7180_driver_data, .config =3D &lpass_core_cc_sc7180_regmap_config, .clks =3D lpass_core_cc_sc7180_clocks, .num_clks =3D ARRAY_SIZE(lpass_core_cc_sc7180_clocks), @@ -400,16 +421,6 @@ static int lpass_core_cc_sc7180_probe(struct platform_= device *pdev) goto exit; } =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x24000); /* LPASS_AUDIO_CORE_SYSNOC_SWAY_= CORE_CLK */ - - /* PLL settings */ - regmap_write(regmap, 0x1008, 0x20); - regmap_update_bits(regmap, 0x1014, BIT(0), BIT(0)); - - clk_fabia_pll_configure(&lpass_lpaaudio_dig_pll, regmap, - &lpass_lpaaudio_dig_pll_config); - ret =3D qcom_cc_really_probe(&pdev->dev, &lpass_core_cc_sc7180_desc, regm= ap); =20 exit: --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8AAC49C4BA for ; Thu, 24 Sep 2026 12:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251761; cv=none; b=NBR1qyzWZxaQLU8mJdo0M2wa1q7fwKCJn/cPtAF1Dg3dTz1bizRWzNL7pFBBOuBqWcAUgi7ntDVou29R1uNIperNUWwMnpFyGk/Qti9WnBaxikqzeFeWWeSNghqkE9YFg1SmXJCLVp0xsjZWeDRrxUHhM/O8zV4hJUDQAKL9pVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251761; c=relaxed/simple; bh=+UM0Iz72EwmjnHaCMh960dF5RvV27yJ/jffRcq438PM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mAjOGu1991TNYqlQ9GfT629aUOlkGCcJk5HNFPkYCdgD/X7QDOWY48aw4KKuujclE1UW8mhSn8eoBJIvYVZPx3qYz6DE69/Nxwx+7A6eaQ0zT6x572SsrY+gfGMdFc9X5SwJ+bSjnNg9+MgQw8n4YsD3Lrwn1s8erycPMT9Qsfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kNiF4GSt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YUUj+wUf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kNiF4GSt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YUUj+wUf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4YoL2594174 for ; Thu, 24 Sep 2026 12:09:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MevRHPZU6PeFsKVCB5vLjtUmc6J8ZAcrLv1nQ2mJKgs=; b=kNiF4GStAs+pUu4L pEq8YhqZCAkvCtftyGMc04snms2o8HpGuuhK4qaJcjPklFq9cLDnrwT+z8WvOTo0 r2Y10IQrfdZOt14BO7QSNeFsCDU+LDUhpcOsFn9FN16Trqcs16zZ2RW03f/e63Rj fnwRD8BoFlKqTdoOW0Z6PG8HeKU8ssfuD20g4BEq4QTXOCuNpz6WTU169171RKXu 8cYegTA4gWretinYnhQoyO0ocezUMc73sSqh5WWHX4GHkq5uBOWiLUOs+MHBg65h 4Ovr4Ov8gh+7wuuHuXbzuE0T4tjdY1hQdw6WEaUhX3CzFmoYzArfBMeG1dCIvw/R /4UU/g== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1tjgebu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:18 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-78a58df134aso566588137.2 for ; Thu, 24 Sep 2026 05:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251758; x=1790856558; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MevRHPZU6PeFsKVCB5vLjtUmc6J8ZAcrLv1nQ2mJKgs=; b=YUUj+wUf8Bx4ZkfR5fiNXRym/jvQ6ELKQ2oJ/S+I4LnWg4L15TrzN/qlODedVieKKu 324cjLxz2x297gJgh3PdpC6akIyYJJnpbDeQdOY1uiCLOhTMpTKhgAFR4FE0kkkcI9vu L5rTvFXbP47wCiVKXpiqyRpk+H9woQcNT1m4NhsiJz0cpq7ahspvbkgx1/akcy4R0Hid ERtOiJlnyEPvqbQW92Hk2h867iBNqe5eDuzWUxrWQ7SitLITZOi+fpuXV4l6zFrUEADw i+YmXLgaX39lu5ycv4rAhS/30c5C7RPLQern6OmnmFHgvWvruVGvbkAGV5WU9GjJH5+P ZvWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251758; x=1790856558; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MevRHPZU6PeFsKVCB5vLjtUmc6J8ZAcrLv1nQ2mJKgs=; b=1b5l8x/DclTy0klXpOvvlYKNOgOYwLG4fkrJnTzgOLwmRJ6JunZarNG6IkiJvoTVQN y4J9Za148eDutlIEqWCrsEW6Q+VUHFn6dM4Vjur7lLa2KTX6JKiHx46UjXwdntzbbANK 8MAseitaJOtc7BfxDwiDkZqyk373+Im9jjmj/teHms9rWUAosWQ0yaNev70LFlD1S3E3 OxmMRIng5yZKGkksFYIJwJIASbFFHuUs1tsMkV01NrO9zRYMFdiTf/JYyZ/vs10LdU89 soik54dfnXnX+0eg3hC6nzdzXan5s8tSkJEHmXc2CpF42q5or4g3EDyfyKnfaHWOGl47 d+qw== X-Forwarded-Encrypted: i=1; AKwUvBwr3BTdnXHIplwSId40Av5MHAdTz8i+h/kN8auGv2duhujJt2GsjTPdQ3Vz/Kh0xrdb6PN4nMmeRhhy7L4=@vger.kernel.org X-Gm-Message-State: AFuF++mtx9mGQnV4MH++h6nv0mvktM2ABiYHiJNwu6zV32osWZB8YB0y a14rSQ3Hu+baTggnZAHL8UuAnzL76BzKQjGPBJjw1dK4y8I79/Pxy2Z1iNV/dIzf9xes0+5ZqI0 CoyG11ccY4PfJmHHeHWyJiXkK023uQq2qlIA9HwZyTI4sfML7uDxyVt6WXxBjMWGQgqE= X-Gm-Gg: AYBFou0A416wexzQxtC/LaBFjH6zN+Rugp82DBo83Lx1HkcDVaW4XhHv1vhjaqJB0zE 1jHySl0dX0e3UEfM5vb6tOKd5oRi6/1rBYDRTJ6v+9aBI1Ltp1om1v+ETrENUmYhgJdocaHwnZG ucV3CthaOtuFiba/aogTARPD74VTkQY1jX/7VA+3MXdU9PGq66G68+HlADJEfUfEl6dtRg9zq0t PgPRMEeaD98419nzYAc2Tv9Xp8aTkSJJiPyt4d5TjhUyL0Yl6y+QAxbPAXsay/FSroqlG/2mA+x 9tLdFGAvQofJlGW7WWWfTRxT+BMgBJ5BP2yLcwldikCJ4AHIGjDtvzREkH3tm0r5awtUlLWxaet Kk/jy1eRq X-Received: by 2002:a05:6102:5801:b0:785:c39b:6a1 with SMTP id ada2fe7eead31-7af1c99cf51mr930680137.6.1790251757546; Thu, 24 Sep 2026 05:09:17 -0700 (PDT) X-Received: by 2002:a05:6102:5801:b0:785:c39b:6a1 with SMTP id ada2fe7eead31-7af1c99cf51mr930666137.6.1790251756901; Thu, 24 Sep 2026 05:09:16 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:15 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:56 +0300 Subject: [PATCH v2 44/48] clk: qcom: videocc-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-44-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2006; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=+UM0Iz72EwmjnHaCMh960dF5RvV27yJ/jffRcq438PM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJs00KJnymJqUgjbfq3B9kSnPRA8ZXa8JR9y Z7kcCWUWj2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSbAAKCRAbX0TJAJUV Vn/fD/9WqZnc/DGIvl3QIZrDXWIMjJlDbe6zgSMfHWK5xhRsz1mpow0+rkSX7hqGD6XQVvjZENO uCwzHkCCe+4l2RciSvqM6Kl76wQc7w6fj/II9gjMuWelv22gz7eJpVg+553cuYsXl827n3sOReN WpzWEDsejgi2peuHv4W27Kbr9c1pAFz+VlbFhs1esYb/94tNYIVi0XOi9K1oNbFrkGZiRcQlY6t 2Qm+/2rPiNxkitB7nP9VGg5G2PV1uJelPaJ/ddp7Qfvkc5y6Y8WaZ6EZktf+rcIbXuwLhxpItAI U75ERYXbMGql1GZBGOhEfyEIXAwQvVKWAg7Taax5OWC/tNvpLzknguCymz0aTYbuyhL+nHrBn+Z eaW2tPR8ANPgTeu9aZ82SiaQsLTORPFK0wOYZAZePnxMb2mIZgftfjrj4xqj4ntlbLzbuokAACw wXfbAHf8t2sLRNEqwDpDDtFRysLxT4SSPdYNZch4tRaBjJJyXsT0GyE8Z99YM3f0n02Z6PNpm/m sBVo95/DJahp1L1F/X34Y/ETtIQ/La+7T1U7TxOWBqhPymWbssEYJKeM/TD8EkSRIfQsXLUvzKA 5NHHTmbUdCkbBfu243I47y+/DeQ11cOYCixd8yLNDcYnYB2BSrHkl/jZ/JM8eBd8VdH8Ivo3i6e KIuPKjcMoPU0FCA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: R8xpzw0aNd2OmvAT9vs-6geAROPRcayc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXw1pjSfUrFff5 44/K8JVo83HE1sAAV7FZPJqMcuou2eWfxwh8oO0HbqQBdz+loHd+QfX0WzGAkD1AWmuQsR6swii ppwccSmhi2E3X/kEZ4s+Kl8PAsMSWX5DWvgJJPoHLSAhib+9Bh87sUV/0U8E3/jnJfz8KYtXudQ Px70VSmSCIcDRzxCqbHQpyfvVR6u/vf3+U3+c9q/6fjKEKcJw3+Eid7YqI+ntYhgj31ZBX7OAdy DIx2q+/o05AVLs755Ado2wWoE7Fr8aU92TQeVrQnIyJnJdoTi7M8bO+HRv9FmAr/a4f6mf0nKnu /XGt1Xv8l5R5cBgwX9VixXpKe3Le3gADB6jQvQC4DfQGEDJdN+x/HO4i4mPPoq9etliNrRocb5r 6CD7EuTF3FZ/7xgTKzKjYHPDr9jPHQbk/yW66F7VBBKF8f9OGOib2Gl/KurW0cn/9hE62uy4REq O6neoZDEFFUUNlMkQ2A== X-Authority-Analysis: v=2.4 cv=cK11IVeN c=1 sm=1 tr=0 ts=6ab512ee cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=i-6CURGfGzB18q9V7KIA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-GUID: R8xpzw0aNd2OmvAT9vs-6geAROPRcayc X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXx4lo/RCUHJJg XCPSeoeC7R7BYdcqfEMicv25sj/h7XnmXnazJVeiRS885nyd99Mg5tENDcyJIFW9KKD3kENrExi s8sg0tQ7wAVHoIOQ/Tlbp16W6ac9ZRk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/videocc-sa8775p.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/videocc-sa8775p.c b/drivers/clk/qcom/videocc-= sa8775p.c index 65a2d5bafea6..2ca78af8c20c 100644 --- a/drivers/clk/qcom/videocc-sa8775p.c +++ b/drivers/clk/qcom/videocc-sa8775p.c @@ -511,7 +511,19 @@ static const struct regmap_config video_cc_sa8775p_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sa8775p_critical_cbcrs[] =3D { + 0x80ec, /* VIDEO_CC_AHB_CLK */ + 0x8144, /* VIDEO_CC_SLEEP_CLK */ + 0x8128, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sa8775p_driver_data =3D { + .clk_cbcrs =3D video_cc_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sa8775p_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sa8775p_desc =3D { + .driver_data =3D &video_cc_sa8775p_driver_data, .config =3D &video_cc_sa8775p_regmap_config, .clks =3D video_cc_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sa8775p_clocks), @@ -557,11 +569,6 @@ static int video_cc_sa8775p_probe(struct platform_devi= ce *pdev) if (of_device_is_compatible(pdev->dev.of_node, "qcom,qcs8300-videocc")) regmap_write(regmap, video_cc_mvs0c_div2_div_clk_src.reg, 2); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x80ec); /* VIDEO_CC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x8144); /* VIDEO_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0x8128); /* VIDEO_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &video_cc_sa8775p_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39AF549C4D1 for ; Thu, 24 Sep 2026 12:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251763; cv=none; b=nlZXA+a0iCBtCTo1fQnJ7PEzD0zbk4NX/vvyCSLCfNx8oHYK5xNsCFPuLuB++FoWbAPA8Y7Ry628cXaclH7bq5Ky8H9AI4niw4wfdAXYMHHxplcM+XjiyTe/smMKCSloaGalNhzjUZn1KDZMjdiaGV/T7t4OIYVNOOGe4Lx1UpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251763; c=relaxed/simple; bh=diY7zExJS3GMDS0fUrSKp1bx1soJ0E/u2KKOUSicqUY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fvk/tiTMw4vGb6ufqRHfp+Rx2qcmAo7g5zUoxQx2TvrE8Zfx1+GSbvxkzj7ugrlSnME9rRq8YUSPW+GkWwW6I9I3fCCv4lUymZ2EW4EfDeJorT8Dj1Vg1UDW1JrIkI09c3X7nUEQjYZRpxIFRNT5l5RjfX9l5ow2JmZW/8HJMjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MXkxoKkL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a8TSAOY6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MXkxoKkL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a8TSAOY6" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4sw6803921 for ; Thu, 24 Sep 2026 12:09:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fC3Nc6iC5ouqaFpOr7lVZ3gvlecc9GuCQIC6kCfJhec=; b=MXkxoKkLOV1MVCWT G5LjllWPjdzSvLJUyQQekXxk0tZUqYf4ZmwCqusuObWign8iP6IsPVbDQFDo6Qmr /BSixISL6O82CU022YTiKxmgMQIWxFKhkvyS48LnfpbS2aQA8nHNoy+MzhDK19rH dSCxpFGXThexQ/UlYlxsQxx+PBirvNG1vQkT7BfkxAv1IQPawzPyMmsLrkUM+oHH 7uC6W5E4kPmnKtrMlWeVZQ7bl693ItcM415LuLNoN8q0rjBabd2RlE6eS2X7UYUN 5cx2jdwX1VvvnwgHRagen9Y8OXDmnLErQ70VIvf5K2X4EPhBaElXuaZ5hYXA2OCx EZstoQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1sc8fad-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:20 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7a10c3de1baso1726689137.2 for ; Thu, 24 Sep 2026 05:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251759; x=1790856559; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fC3Nc6iC5ouqaFpOr7lVZ3gvlecc9GuCQIC6kCfJhec=; b=a8TSAOY6wBbhnVm+npmZIoOgBky+f3utRdrAmARVojWgxmCx7eWG2DBW6iMBt/cyZ6 U1NJJ9iZWErScFzQWq/i1EfpTIdImr6749A0QkAKo20c809grCG5IfzlC25s4QD8BpRt 1jznjKdfaNl/yfrpbzVKGxv5fVaa0zLWIbNueGj/zOHmyECMSbTn92vNy0VZDp0wS0MG 9lvYpQakN5GSfUKDpqANGRhsVdDDAgqi2CYdFiD54FP7ShBD6S13n7ZB07G7NNDbAZpR M/NhMe4I3cZ9Q5VAJPwE0O/Kf0bXta+0k1GLEtRX7IEO63r+wa5pG8ERhP2zwClzZP6Y DslQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251759; x=1790856559; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fC3Nc6iC5ouqaFpOr7lVZ3gvlecc9GuCQIC6kCfJhec=; b=LyOrrsPmUnUqPbQbsJP0KBASxDjpl+87z438c6mWlaGF0qD/y4kuD0rUyUKsEJYbRS /s8c10jK4egM6YbonDirpzOIPZ//6ubguXBSiDCUlMBVCUAu6FQUFtcEShO29qDLDLcn KXPE8eljF3yZ3T1kMLXhJ0FI58o8laGn66h8/mu+SPUD+1rZyClUAGw7rPosQOxMg+Me CC/8CvptHWtBrtbOw705yw909RLA+848gL5IYxYMjSVcHTVk3106vgq0kE/+JFICEpEd ZKSEdUOUt9dl8m8yB/QJpypWc8M6uzWLAhdPhMNbH70V3YaAx5/VfJOIkuF8LtaX5Nw+ 19Iw== X-Forwarded-Encrypted: i=1; AKwUvByMTjJgDWAVxYuqAd4XcS6sxoI9K4cH2mJVD5HBAEZI8AgY/ujNiOxmtWWmt3G0Zd0YVMxRA08Xs4oW1Oo=@vger.kernel.org X-Gm-Message-State: AFuF++ns3y4eXxx6UkRQ054X62ZmHRrDNEq7G9arNND9D+rn0gFKJioc xXVuBW9lLxzhkxoJ7EQyRkLRDCEr+UdJlK9QXgIL82P3YKmTZ79MRIsU9VnM5s8u8G0Z6YGe1mv jUU2xcYPerhrpyQvdqET/JAUBhR+C1BTFRwopBocE4+S1tn0TItJENJv6cdHm8VLdE1E= X-Gm-Gg: AYBFou0nfDzyaX3WPwsv0zrs4LYxDcxZkwLzyoluwt/3R/ALQER64h8GDgW/tpPDQXD OWRjfg4phuxaU889O9sOhFp9wH7PnCnqLgIPpXTv2i/lKZWMaTSVucQnFnkuCShRrlLbWPTB2G3 wPmge3kGcyfjP37vkUht4EYagy96lXShI8bG0Yj1ciWhvkRWZR5aMyMj8eoyQbkkbK3eoia4UAZ wR96gBU948hQL8UpmAUvrqleXne2mJn9R+m06SGOcFBYVyFPb25qtUUkN/RETgUIxwtlminxKYY 7xY5xVuM875NNTYNYEU78zL1w7hLleF1fU2kXscYvOHtqydhDteU11n8c/OBEEk9aoNY6XbYqG0 leZZA+2ei X-Received: by 2002:a05:6102:511f:b0:7a7:198a:c2ba with SMTP id ada2fe7eead31-7af1e2f473dmr1156537137.34.1790251759275; Thu, 24 Sep 2026 05:09:19 -0700 (PDT) X-Received: by 2002:a05:6102:511f:b0:7a7:198a:c2ba with SMTP id ada2fe7eead31-7af1e2f473dmr1156518137.34.1790251758731; Thu, 24 Sep 2026 05:09:18 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:17 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:57 +0300 Subject: [PATCH v2 45/48] clk: qcom: videocc-sm6350: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-45-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1680; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=diY7zExJS3GMDS0fUrSKp1bx1soJ0E/u2KKOUSicqUY=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJt6+zBDvol//2l6Tx5u0AO40XQcCHIpMAAz de1h9J7lRSJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSbQAKCRAbX0TJAJUV VoElD/4owk6vB3bszCQ364+5NhJXWEALP0g1aqgsV+3iK5vLwkf1WI4XdkKeSO3tqw8jwJ39Jp9 a24XZrlxCdi24Mbzub0ji5KIdxQMps81W6G2OAvObA7dCep2VLAHOy7e/DPjGCmISblUQWE0qCZ 4mWQsOHfaiSQe+81l7KPlRZFUsN3AWB6XCCjrhkduXAithWB7XsN8HEjvcgtw/8dSw3hHHhSr3G bG3BRYEiKBpSnPkMwJj9fhQV6cOyj42/Fhs2gaznZu66Cdm5iJD0G9kqQ883min8WmEH+nzqV53 MjTJpPu3iR9CW6PQXq4XJe8LzRBc1eW7QXySP2pvd8YuGMuCrjpYX/8FWr70OJQUngKjGZkhH24 QBmz+fJoTqLb7HGla47M4CMVCTjzAqdiQm1IJ5t+EFXXBC1aYPwiXvCu+yfKVB6Kh5kRSxzc2yo hqSfT42eaX8APYEoDGHWph8tE1EHqxhtP3mLd+QygPjy74mAxcSwef/ce0zKYZc7lKIap/cR/CX hj5Xs72tUr6TQHiPAIZSFuo1o6smFU91Bemjp8VOZLS4cNnlk15HRUWzBD5CWniLzorWT9423vd vyMRhVA7oK6sZ1RhPwlhY+ECWW6rmrF2guxBiSfewdZwerDr5pk2iP7eno12nyLlKuOIj+6YgK1 ZPT5DJvVRWRwTvA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: sckUJqN1HWQhbUr1lwl49-_hoOc2CpgY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXxeANscBAlKvd UeVQPC8VnoeeKuEHraszKMx0EfqtISzCyepus0GjQ5s5ppFsRe8awfYL6Dsb3SCWC0CJ0A1Guxd 1TdtNpLXJFUHd5YEosEqnu3TDsqxv6zyScyR59X8sislMfjpO3wJf9o/y+2+rN+OwkObn5HNWpY z4+kvgHo4Lk6ZDOWDdgtGhhhoG7Ln3gTFUHPrLBVGhiuxLsFZJ3fEIopNvOwjHkV+2nOYbXUrsv AygqFOs9DDbIA7cdGfIBEIeoUc4iizpWRHXC+eDv32JsrZcuemICoViR+5zgO0GA6m8gCowIwdR /48Oa93W98K183V1gMMg0345O97RkczTlyN+w3OgJUdZPafpy6nfLLDuo8QPPJcC5HQpLd3TsYY M+0DiWjfmeEvx7HwX9Q4IGkPY6h2IInX4V+HcPCELOppym9UHV7mmfS1ukLuSTfDS/iaRE1tgO0 TxRZomGUjgmei36OVBg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX1KCEJUGxxsRq sRl+yDTLLyf/k4EB0UfyuD1CDfx/lZenmSgsDQq+vySEVSslUloMCsTsMiZXget/XuJA3RjXCva KUhvviVAWAJagoEedetzhrTGZUQmDRY= X-Proofpoint-ORIG-GUID: sckUJqN1HWQhbUr1lwl49-_hoOc2CpgY X-Authority-Analysis: v=2.4 cv=GI+dgeNK c=1 sm=1 tr=0 ts=6ab512f0 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=35KR4dZN77wT4OcJcwEA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/videocc-sm6350.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm6350.c b/drivers/clk/qcom/videocc-s= m6350.c index 34bdc5aa865a..d3926f87497c 100644 --- a/drivers/clk/qcom/videocc-sm6350.c +++ b/drivers/clk/qcom/videocc-sm6350.c @@ -311,7 +311,17 @@ static const struct regmap_config video_cc_sm6350_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sm6350_critical_cbcrs[] =3D { + 0x7018, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sm6350_driver_data =3D { + .clk_cbcrs =3D video_cc_sm6350_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sm6350_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sm6350_desc =3D { + .driver_data =3D &video_cc_sm6350_driver_data, .config =3D &video_cc_sm6350_regmap_config, .clks =3D video_cc_sm6350_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sm6350_clocks), @@ -335,9 +345,6 @@ static int video_cc_sm6350_probe(struct platform_device= *pdev) =20 clk_fabia_pll_configure(&video_pll0, regmap, &video_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x7018); /* VIDEO_CC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &video_cc_sm6350_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ACAA49CF36 for ; Thu, 24 Sep 2026 12:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251765; cv=none; b=XOvzZQNe+VyGe994BHolgfVNaljCUIj3pO8OscnE9ObuLfV/wUIWvSMYoXkOIEMk8E9waYprEIH0LamTHOxMqzwYcI6ekvJSJcDMgvfIThSriLa7/sQY2uCRVyeYI8TTQ3ykimz5cfTdAUElabv18VPuhqlyswOK+b7cDyPzlKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251765; c=relaxed/simple; bh=oz11M2wrwKFK3+vSAbicVJWmbq+jkXzbbamqOEjW/JU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aqJAj1wlzdkjpfv8sMZhlfbfDOBxO9ZkEHtVkpHuqXEUm/9TYzjv/0VwR8WMXQ265rj2pcVKGAnhWIeWebrBdRrH2IIZdPDABWvwlKsYhv9BKQeW2T7/EOPOKUs//N0rjuUJEphw3HgWE+MP/omUDOAzIygh9PfXbRtlHfSVz5E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lVHTlYZp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gDoNBbDx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lVHTlYZp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gDoNBbDx" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4lvj1437264 for ; Thu, 24 Sep 2026 12:09:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qeKdsxYcHc+Ri00U0V0fl7QmJgNHnzJocuSoN1PXB/A=; b=lVHTlYZpYPwWBtg0 h76lzVi8u5tNVaHgSMC8Ubi4CTuDCb2ZHmgxm6sxIr/y/cDwL6qD5MMg8Grvt+/Z yM3uE1OfEcJolt130av69aF0tN1e2R+XyECXiEvdMARSdr9O5sjZSGIke6bQWHoS nHMhoTYP+zJTOKwYzTz4yx4Dm+IqfH3OQUisxjLZK3OiXINIDM9qspcYCveMBKZv DKesEyPrjroMPwe59S403lfFkRshriXBf22fGj7MJWjJy0xmoI1Opv3yu1qJW1WV AwIdELsHVtroyKfCn65Y6DPcEmJpDwv7IxUx6JeW5OslXRENAXNz76Tf19dnUJzw u5eN8Q== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1t7res5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:21 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5c851df59edso857968e0c.3 for ; Thu, 24 Sep 2026 05:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251761; x=1790856561; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qeKdsxYcHc+Ri00U0V0fl7QmJgNHnzJocuSoN1PXB/A=; b=gDoNBbDxZMVLcgXE1opdkB1VBxxTsMvUm6LDIzscyWdA2URE5Nh4JgOM1LIgb/9EBI SrXCqmrUx2hYmnwuSXSC1dlO8gkJVJlkUGXkoaeMOj0lbTdSzBV97PbsQnWjnzVXQDaS Yf96MaZXtKh4M0kcvQLpm1N3z6o3T0FsHgxDlCxzwiZkWTMeWrLGaKIQPREQOeP7En0C c6FNATO/neYFBUbcWa6fq8k0z8GmAr8Cz37UuOfHE+LJ8qzUpjlf528iq7kzn5yTjC2t krEzwHWlgQjFQPBWkqNk7+ApdP/cal9w4yuhFDZr8+vmoOHf4HGx43sshtddFUGKNoQO /AeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251761; x=1790856561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qeKdsxYcHc+Ri00U0V0fl7QmJgNHnzJocuSoN1PXB/A=; b=gQHvAsRZpfbfImZWcBfA9EHnodJEAa2W1mRLCM7dV8AIXv+Zyh6W72Q6A1zpZOVoii Su2JkiQ15Rft/cHYTHyhoGGpXO2Qr/+sTTxU+n98Te+QD3BqqxNDMBOc6NDbuqBoJjtv 0Lc4CkHtyg7pGvCPKV30Ws7GotFDcla4uoaa+vJJgsjbcVjSO9ckufgKTcnWsqD3ASJp EKLuKEIyLs8f6Zvq8qg+eIuWSzyVDrgTJ1ss4k4FLasMXTexWnGKhRoFHg6U2iOgeQzH 5r7EL83118snu1tABENF+dET0/wrAqyblxa1hZ1G2oWU9SUr26dUXos2/C+WwI/sUihG KJpg== X-Forwarded-Encrypted: i=1; AKwUvBye/fMHXsB2hafuHxxv1KlXUOwq5sD9xope0tiVXrkO1mKg9912jsESR+O5wLt9rf2dF+QRRfMxZWXwCFs=@vger.kernel.org X-Gm-Message-State: AFuF++lkloHomKEQ9sAytJgx2eIKwwz+WuB8wi/4MJpRrL5RZDE6YCNz 1AZzLka7hIiLEV1O0LLgyDwoI+220QjWZm3+Gd7DWhCqh4WI5Cu0btroIU2wW95ImU6oHlIDxbB He2UBB3zEAL8rLb95vaghrd1ri+FlEmOKegAWkmos0F1vhuE2R2gB3sMoTvFl9hmbt6A= X-Gm-Gg: AYBFou0D+Op34RZaXu3Xi02fzYuARejigbyWSHgIuITVypJsmcJplJ9FS1081XCbtIB IJTM1DnGLWtVAk1mJ1ljs4diAIGMLk1uiYNJo+Uh8OLg6pG/0mRYFyDt4fKH/8YeAhYhgfZb44n MBhGdOdfOwnrL093UOeAnAxP/juLBx6PnwKdWiVGw6yOy/FMKgC6g3TjkvLAHedCnOfBDXP/KNl aX9ET/FlvWVlgHoXgoJq1AEnlXprJXIz8VAjg/h184CULkCAnZeSZbeKCNd7hVeYuDlmfXo2mfq aS/ojVTeFEon6CwY8sVZTIDalIpdnKluX+XbqBpvuHHmSEPLd6a05/+mPW097p7t5Pxm/SV99rR 3tM5kS0eb X-Received: by 2002:a05:6102:6882:b0:7a7:198a:c2c6 with SMTP id ada2fe7eead31-7af1f0ffd39mr942363137.36.1790251761082; Thu, 24 Sep 2026 05:09:21 -0700 (PDT) X-Received: by 2002:a05:6102:6882:b0:7a7:198a:c2c6 with SMTP id ada2fe7eead31-7af1f0ffd39mr942343137.36.1790251760445; Thu, 24 Sep 2026 05:09:20 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:19 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:58 +0300 Subject: [PATCH v2 46/48] clk: qcom: videocc-sm7150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-46-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1668; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=oz11M2wrwKFK3+vSAbicVJWmbq+jkXzbbamqOEjW/JU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJukCmS3zbBLKoTV3kwTEq7qEhAABav+F3To YgIGjKeUsWJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSbgAKCRAbX0TJAJUV Vn+pEAC461z1qg3HSY+7RlWo5efVcPefwo8A4fyzIsqLCxtNLjT4vNFliSiSMcz51z1etRa/+w3 abWjdAWAuOn3uylyoYPRLRac/D9/FN++qTiNvkHAkpvIDxycYYdkhWJZa+iRmCwnq4PV8rpp3nC ERaDThmR8k17WLxLX5uTNu7D9VCQmhJ981HYsN4tYFufmBV8QkUE+Z1FYj2fvFtsJo1vwmhbxyi FyGXiJ9E4ihb1kCssBS8I0GbOObFCPM2OT51i8JVSsXcrybL53qJMzFKxqQ6H4iwkOXWjhTiWxR J5mcRhryrsb6v41bcprO+tWQdJbsK9XwkxPVsQHRzAks7XTtl2UpAgQGzl6V+aUixIm8VCnuldE PSA7eq+e+XltnRapoClAEcZpctJx5S7+WFk0p+H5LtJAGz30X2BwqrWRMBRfZm5Z/BIqTTOBsJw ffVmiZS1R+XTmhHdVM8JMm8uIAAbrdpT4uE8GAfVQgKWiKWR91K385ZO1wzHBgVZ9d2UHQ0aQmw LCXI9ZZoPsrIuSq9LfhwVevlWBG7dj3Lky04w6gR4SMu1rPfsMapkepJsrjnMfNI7sFCpcok+45 enTqPPW3g6Ph0aPM1licjBwI0OyNQ9le1vdlymm3T75nS1YeZnmPMVYJcxjICt1lAxeUZAjkh1g 011S6hRACCcYfwg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: gr80jrY7wpD57D8EGeJOsg4lEPKYNHzm X-Authority-Analysis: v=2.4 cv=U/MHnuru c=1 sm=1 tr=0 ts=6ab512f1 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=sYFbF2zXfO1Ub-DH1h4A:9 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX3KQCyVqBRGOC PJc+FEAnlvr5G9owa3oUHptDDrUeAz2QJiq9PF9RgR6fpqcALw60HfpjuIxSImMCe4OgnKZlBmB ZUX8UtuLeFS/nAG+GG9+7MfbPSiH70ugbo4E7T1YFSQJHLtQyFgxwAF0B0f9erJ35Pmj3YMBUn/ w66I4NGBfwnVrXl1lFyaPqK4bl6Er/txPJzQA3sCTJ0KEH6w++BKft29ywm+1hQj89itOQcTAbk pFXzNMf0S0INpqI5HkWq9HdGE9zFOOZiBQNIe0Jfws/wO9uyHQocALG1Ykn0TJvnlgyBVIwL6CM N2o0teg2hqUdFMWc3LrbNAp3sBCWWT6vMepCzaNIyjv0hsHzrytmUEiMK1eVdeBa64q3nS5MxEI 4ZlMKzQ1I8gbLyCkVuMRfvr0GKP0T9FFsHINwrA+hxw+d7PPuMtsN4qMc+FXe5WClzV8g9kOfWE 1GD0QyJt0w3Mloox+SA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX7acA7dqxckb6 36en2JBNccI7xv+bxhZeecEzGqilCN2Xab4LSFYznNbyODVv3BhmEM7SRkhoDFyxFxdQ3fmZWg0 Lu//yd9t+uqvcgFHKnjAj7XcqOrLMJk= X-Proofpoint-ORIG-GUID: gr80jrY7wpD57D8EGeJOsg4lEPKYNHzm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/videocc-sm7150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm7150.c b/drivers/clk/qcom/videocc-s= m7150.c index 8d2e00799f96..32bad5e09056 100644 --- a/drivers/clk/qcom/videocc-sm7150.c +++ b/drivers/clk/qcom/videocc-sm7150.c @@ -313,7 +313,17 @@ static const struct regmap_config videocc_sm7150_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 videocc_sm7150_critical_cbcrs[] =3D { + 0x984, /* VIDEOCC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data videocc_sm7150_driver_data =3D { + .clk_cbcrs =3D videocc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(videocc_sm7150_critical_cbcrs), +}; + static const struct qcom_cc_desc videocc_sm7150_desc =3D { + .driver_data =3D &videocc_sm7150_driver_data, .config =3D &videocc_sm7150_regmap_config, .clks =3D videocc_sm7150_clocks, .num_clks =3D ARRAY_SIZE(videocc_sm7150_clocks), @@ -337,9 +347,6 @@ static int videocc_sm7150_probe(struct platform_device = *pdev) =20 clk_fabia_pll_configure(&videocc_pll0, regmap, &videocc_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x984); /* VIDEOCC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &videocc_sm7150_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB2B484242 for ; Thu, 24 Sep 2026 12:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251766; cv=none; b=Bl4Lh4oTfHR3x1MK67Pc8RqQRB/WxKvHnutBXWTJwkB/1jSijQUNBOaWaTzGv4SjOxv6W8FupgJT0OwsTMg3fDBl/kNqpubdHHo2bzKx50iIzyerDAvXjTyR5T0OOs48agyEhcHU7WLt+PAUOm849YRjSoUUx073VomdKpAkbLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251766; c=relaxed/simple; bh=fpAqyKfFKWy71M9unm4jkKwXTIYpTZjdc2DJToIUe54=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sDZWR0MJYpzJ2rbKkMhFLiRCIJVZS1dQ7Wf7bpV9UgCvfXkFHnFiwp5jVeg/oHPs5WMDAeKePXtD1pKrJxMHJRi0J7DgcDoq5V6uMQMxKCvmh/OwGfzyGlCNCuNnSQS5XFGy76znW8nVXM/e3EMU+Dj/bUhPrBs9+WRT8WLTH0w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pk0xdaAV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z89Bpsct; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pk0xdaAV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z89Bpsct" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4V3K3282824 for ; Thu, 24 Sep 2026 12:09:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZLwGTbScYA+2Nkx7d7vhUGR21/t2WEvalslJyIBCbVw=; b=Pk0xdaAVrZff6v5K rqVDp0DBlVBbHFqKvMGEa/efjXm9u5SemevNc1qnurPEQimdxybF6FVwsQ5awDKR aNNMGz4Knlw6CY+hiXu22bHIN6KvPh1V9SZ1oW1lBs8xdaoA07MP99/tyUAQYxlJ wDMvu4B8L+OpTRctL6AdxLj2pwMaNLbkyHRlxM8u8YZEsiqobtSag71iBtmOdO0S DAOwEgzO2i+a0XdpnniPndLLZFu8ai0FRYBmAD32Mq72xWt1iVP13XeVE0DW8/Op zCMRwYgu5WtEtnMBQscESfGoYs11KMkXh+ZOxNOZW0IM/IZPGLSLNbqK8vq5T3h7 yxvTAw== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvstujg0q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:24 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5c93c294214so754370e0c.0 for ; Thu, 24 Sep 2026 05:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251763; x=1790856563; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZLwGTbScYA+2Nkx7d7vhUGR21/t2WEvalslJyIBCbVw=; b=Z89BpsctTdTDRzBH9x8SBOp9YVuIXJkNcSomVR1pBmQ7kOdIKrjY7aWIiIvqcIfZ1r mBOL0PZrvfkyZEaNT5iE0EYX+IZpmiIfi1L68EBdWRNPtHCiMUZMRi13jWMzrJzcK3sk KNe0JKSZww+l+jEOAhOneGki7GTK+7eHqGJRHyyl2uxKWKU3Eco4wJ6NDl/W9ZMbAeXq 9Fq07DhAOhXi1OUypH3ip0QLycENTpnLcLrHuWa5oKCbXwyXA6lA7x8SIV1l4IaKFHO7 JewNV6boC7XTG3VtDH6OTDQ/PAYuP8o9rrQ7Ch3eUP1U72IhwY86F+WbAh70PFjJuA57 FtAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251763; x=1790856563; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZLwGTbScYA+2Nkx7d7vhUGR21/t2WEvalslJyIBCbVw=; b=v3qpgkFcKFTgu7/+3SjEW1tESLKmbgu47bH5oSW6wLFxAaKLy5E0ra81Pvo+RldI/n qx85K4tYWfNX0K72c5sDfP8hMJUfVLlMszG5htBhRcDjl7HsTFlSnhKSRvgJ6JRLXxey dT2graOBEHs27uJYJ6Tsfw/JhH37vmLAKPw0rPtUZ6ZodpGzcPkxiENuWKs9DyntyiXf ajbWUyJRPEEuNIsBUCXWCWWPZc5QsjgFaIsJ0QgDm5N2Z3kfekjYB55MpAkf+KS44of4 oAktmpItN/kjT6b5vc0e7MErpy0mv92glyXvHwUq5Cq87luGlwauw70iV6aQpPxMDLgZ f3OQ== X-Forwarded-Encrypted: i=1; AKwUvByDtwHraQG+KGQXStzaXgsbxjVyqaHCm1xNub3YTp5ngRmIMorTrAAXtO9VRSwPGckGexb8m6xx7MfoWwA=@vger.kernel.org X-Gm-Message-State: AFuF++k6u23yRFz4ZB793IBIFyN0CrAVDuJyuEx4rLcnYqies2aibs1X mpw4hzHCURC44x8w6ycs/UHnRr7Lii6qm5GzzDt97EAYt898uDyC7sc+fYrk7JZbxtBltNdbyKg LqeWw9fnGzlyXAQ6kX+G8VanM74uOrGHQOdEVT1XUyA0+c14QG3nvuKK2l26iPF4fFF8= X-Gm-Gg: AYBFou3tAo1k//PSFoe3xaxTVOkFbG46oPc7c2zEfmzGOw5xg77OsPJsZkD5MXeqqE7 tatw/I5gB9vc3ysx6PgcQjwwpabZjvHO/Cm9BkBknQLtrCaliZiDbKmugHUpltgnJrI2vos/Q/Z P5DztoURrvBQT05QUpYBSHwd+tWhZUTDa4SDnd51FSAu3p4yS2oCF+OEZOtS6B3SKs60woqmZ+X y9w/MjEQNTK6pfH7FyA4JvtroNXcGjMBScfhsC+bieHp6oUR1iIIOmGNIHbPc26ZDxYEOP7gAhm 8mXY6+qu59IqBm/E9s6z1edOwwOI0UZbk0Ul4Nc7wP9KREyYs04u5sUqkkhem54eP3DU3hwCHcn VYn8y1X70 X-Received: by 2002:a05:6102:50a6:b0:7a0:eb10:76aa with SMTP id ada2fe7eead31-7af1c7a07f0mr1109255137.2.1790251762984; Thu, 24 Sep 2026 05:09:22 -0700 (PDT) X-Received: by 2002:a05:6102:50a6:b0:7a0:eb10:76aa with SMTP id ada2fe7eead31-7af1c7a07f0mr1109234137.2.1790251762049; Thu, 24 Sep 2026 05:09:22 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:21 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:06:59 +0300 Subject: [PATCH v2 47/48] clk: qcom: videocc-sm8250: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-47-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1871; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=fpAqyKfFKWy71M9unm4jkKwXTIYpTZjdc2DJToIUe54=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJvto0gM6txrFaI6aQsh0PS7s8e6iv4ckNQW i30X50y+vKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUSbwAKCRAbX0TJAJUV VnU+D/9thqA7exHm/mgM+2LKawqDr76G26Jy759bIYvgb7kTbHBXHmLXSg5kd3DjfQWrq58OAF0 5iKebPsXpnFEdI/5/khHAA3KYkfuUJq7wycdrRtdoq2ImAcRZ/WFhvdLK4OgyGzpeWj4d9/weS/ HWLfNyYbqhigYGYrwgzG2L/faYs2m+2GS68GV0VMdTU4JQ/JS/HihrYTB0HxnFGPv+cpAn3QSqJ gDy8SPdgC5e7CH+TDPeci3fqOnE1u1JWnaXt/Qvrr/C/wVB81lEYv+YsLCum71HkKV5/vv1DjzJ awQAX5zQyCww5UWQ4E78grN5bKFoBfb1Oz4126EAQLY/9417wxrK6WHzNGsjHigYDb+UzkG7zu2 U2GaXChlR1DnhjKxj1H9s7Oh2tSIIE/t/cr109xQs2K8z8eUf/KbgJ4M478c4WZF61L2W4YhjeS F5lIA9/q+MGewts5JnCCxn0r219xwcjiEHNmbRwVEkXj8PfS0XF3WK6rAXMoT+qOGidvRUwig9K RHfHpM45tOvnDqzfCez7QmTtpq8Ey1L7t/Em0c3Dwn4ek38ZNTBO7Uvs1MpQ3ugvyR3jbAlppCT mbAvKKh8A00pQhtjqEV/QTsZ8XWfdIkkwlEJw+nGiTeeeTiTQxkTf3AUoA8tjXplU1GXB0qdELS 732cwwvcNHfIyRA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX0S9oM/TGYFNK lMKQ3Lg7i/tmp10ng17gKZ8y85G3EJoWTibacX5HMXxk/BuahPPO9ppb88oXCa/jIoqq+WGDZMK uhg6PZUyTfqQxpGT/htb0K5Mpcid83g= X-Proofpoint-ORIG-GUID: z6MsnYPxqK0TdaUZGkboeqwLMi_j3FWT X-Proofpoint-GUID: z6MsnYPxqK0TdaUZGkboeqwLMi_j3FWT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/Db042BW+KMf vSN42jE4volTyMZAUZSXo9yHAAmOo/Vamm3hsXZKzpIu+7Jc7yEEjzxt6ndsdee3i+XY6Gl91rM G60/Dgn+Or6Q0aLdCYxUForAlzJ3lmwF2i3HWO9V3n82FK89UWoSFzFjkoAnVLgeWzCI49QHQXW UdXc1FOoDoR1mYOKLy6noE/uMBNR07kilWSO3HQ6OnHBLwdq0YwsXIEex0JUfYZu+IzKTtcJ5Ft sUhnhotSnV0NcE0qhUc5HXcR5q0CNqdZ/wEb05pXvPq//Sg5RbgRwQyRg0Aka77L5IBPF1rIw3S PxvolzJMJBIou7VCFamcGU6ZupXf3NQ7jqY7tDNiSpLZf3/xn7NRIvOXpmRX4iVJdTqBMcUWPMN JTgOk/gb685+x4esN65bVneMbt6ZanSzYKsYGZCD31OlBiXooq063DFLyByW2joTDEtwpOREU7B Pp7qMVr99qKDkOGrwQw== X-Authority-Analysis: v=2.4 cv=cKp1IVeN c=1 sm=1 tr=0 ts=6ab512f4 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=w5mbRZx1dI4nJrn9fZAA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/videocc-sm8250.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-s= m8250.c index df479a69cddd..d29d64138508 100644 --- a/drivers/clk/qcom/videocc-sm8250.c +++ b/drivers/clk/qcom/videocc-sm8250.c @@ -345,7 +345,18 @@ static const struct regmap_config video_cc_sm8250_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sm8250_critical_cbcrs[] =3D { + 0xe58, /* VIDEO_CC_AHB_CLK */ + 0xeec, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sm8250_driver_data =3D { + .clk_cbcrs =3D video_cc_sm8250_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sm8250_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sm8250_desc =3D { + .driver_data =3D &video_cc_sm8250_driver_data, .config =3D &video_cc_sm8250_regmap_config, .clks =3D video_cc_sm8250_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sm8250_clocks), @@ -383,10 +394,6 @@ static int video_cc_sm8250_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&video_pll0, regmap, &video_pll0_config); clk_lucid_pll_configure(&video_pll1, regmap, &video_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe58); /* VIDEO_CC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xeec); /* VIDEO_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &video_cc_sm8250_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7442249E121 for ; Thu, 24 Sep 2026 12:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251768; cv=none; b=d/8bJNkaFsbvO3kfu1LE3ZvbBGiqga5tfXQA/2r3yJ9KJQK6Dmba0UAfOoBSd+k6slQpnsGomMbng6ZJFeGLuUWRqaxO/Y9BoJWT715vtTaTYf2WLJDmgD/feWL3mw3UWEY+qfROzaq0pUauoPWRvi3dC9a9qKOpbHr8Xo4MsTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790251768; c=relaxed/simple; bh=+ytC9NAkfv9kbIOKNH8ea9oA05pxToOL3Hy/iiMk/2Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UhEqPsPxnT2GUTWJpCRAcVxRpWxT45wpdmScVZoRiKS6snTUM40YvTguGoRbkeaWPxaZ1Mcpxp0V5ROQ5OvI3jIOeAgwxeYipUXkd3BiLMKEi8JGfDp2JrvRZSeieqPEFOaQz7aewSFFrURl+VmMTnrCK79PsEH3VIMyRgfGo8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LFjVNO/J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IaH/1oPi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LFjVNO/J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IaH/1oPi" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OC4pbG1429907 for ; Thu, 24 Sep 2026 12:09:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IhL8gol76EjqbZDJ2aFsY87OiuKYM8j1uxXZhsgz7vk=; b=LFjVNO/J3eEgDeCs q1bj0CZscLHrtRYGK1TQ00GLMuUKdaiCvyrUrAUuQ+tfdWlxUKgRuLdovlzN0PU5 MtlS96WGhDAwqaTILvIXMh9xlQzDnmwksWVAeKpUgNf27PHIAQ4hpG8t0C8NfWmf qxA7a9CoPOfXiydaFr2f7PnJaNw5z8TXH3x/Tcxg0GnjH9MPgjOFtRm9s8BQxwqJ U9Iiw3F8k1rMSh6T9Ts0ZnFtOumLkny4ZjvgjViHl1ckTBInqzGlz0vjDYTBikHo SyZn1f8bhf3rNdtfMHzLWQ65zghftzBcQ10IzftoCAPmA1nbnNMjiPg0Qb/C3r9W Mp3XQg== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvvgh9vr5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 12:09:25 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5c7a3b3c06bso790658e0c.2 for ; Thu, 24 Sep 2026 05:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790251765; x=1790856565; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IhL8gol76EjqbZDJ2aFsY87OiuKYM8j1uxXZhsgz7vk=; b=IaH/1oPiNN4CsWAM0AwV7C8X7xkNsnoMknE88JKS5/pjA5amVIMRNTC6PF09TRCk9W ZsosCsRuvPfcVUkkI/IM4yEaobVcUxeksgWFdmT08EfKWuxVy5O0ujp8bnp6dA+AFo/H bOe9DveoCNZW5vjZqHpmqbzKsLDg9S6hMi6FtJwz9diaaI2L2XwvN5dvlYuPoqROq0g8 UTcOMDhWiTSsUOZBChn3TDXAEYb3Kcn2mutLOyvclwrf+LHseCjPzBKtjnlQQ4x7GIIV j7qYI3/uTRiRe7aY0J48KlWFvUAKWdSNnjfcr0RX7kEkAnet3qIjIkp6oKQ6dSTPyiw7 g5+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790251765; x=1790856565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IhL8gol76EjqbZDJ2aFsY87OiuKYM8j1uxXZhsgz7vk=; b=Ax0f/6KrasCOT4zD2CaMwQMb2VEk/2X9O7Yqp8pF+Uu85HxTDW9gZzJi8UAv4qssx5 SoGLHRmvYoiZQpRGUn3sX6qc4g7V+KPqhZBZEZjoq0UKZy2+39jdlAXODpJOa2GRwqqo 2tG4dxviteyQMqxTF9YkGEcbE9maquKV6Zi1HvFms/owMkrvU2Kqd5JJJhSYpySJt+go gU0XsTZtNrg6n3gaQGaXej0S9xqYg7BEYgj3RfhvRBsbsMhrU+lZSNlADGtMyNU/xDm2 DTT3xuVPssMQUa5urkdCyPzYt7qiC5bF6Y0AUjdOuKdPLB8uUVD3ozz/xLzpAqtlNuER PQNg== X-Forwarded-Encrypted: i=1; AKwUvBwMMjm7JEn8ANb0DWFUbFRbCv41ybixmDwAkuJOPO4hVIbI3dShTKercIdsdAAEkYhiRetofWB888jjQlg=@vger.kernel.org X-Gm-Message-State: AFuF++noIXHpKSne3BGK/zVgbbAv0uc78iLxyZwEZ0VruJJZzizo2bW/ Rp6ynUT+jC3rRgG65YhLTHAvPCqBN206+pfqCxxRMBeu4fRp6VIQjyjH1t1rizFRLq53O4RpeWY XNsbxDfju86qfulvM1EbcbM+uCjLjdTxOAcdGzAItki4Xv+tisbwpWBGe2waujt6r1l8= X-Gm-Gg: AYBFou2wkv2VFhnKGsUEPwvppOp2zhkz1IrZxDdXm80mfUvx7kuiX3/IjqI1VvjQBwM 0IEFjoMkJGoFcAkdeDLZissHBN5joROTGhSVYChweq98fGGKwwh/mNgbXfelBqI0xlIkKF0Nt5u XBmUqyDO/WL2p6lOCuHdncohwHZy3ESnfI+YXXWGyaw6NVC1WCQZCftS2W1CYcz/j/iOZSodJfD MB+zXZUkMFZMuancdrbN5eycBjmtq7wWixeukIvswqqqYIqB35+FE0LevepZwrr2gFnV0luyIk+ jtH298TBc+3P0XwElb4RXC+p4ktY1Au4QAQGNAmC4w5gVDO7i+RHKXFZWr11tP2x8zO8bhZzNzf hjNTAYfuI X-Received: by 2002:a05:6102:32d2:b0:7a5:4d80:a913 with SMTP id ada2fe7eead31-7af1c58fa50mr1049640137.7.1790251764528; Thu, 24 Sep 2026 05:09:24 -0700 (PDT) X-Received: by 2002:a05:6102:32d2:b0:7a5:4d80:a913 with SMTP id ada2fe7eead31-7af1c58fa50mr1049621137.7.1790251763861; Thu, 24 Sep 2026 05:09:23 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe667ae2fsm61376605e9.13.2026.09.24.05.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 05:09:23 -0700 (PDT) From: Abel Vesa Date: Thu, 24 Sep 2026 15:07:00 +0300 Subject: [PATCH v2 48/48] clk: qcom: videocc-sm8350: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-48-1479443ee016@oss.qualcomm.com> References: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> In-Reply-To: <20260924-clk-qcom-rework-legacy-always-on-clocks-v2-0-1479443ee016@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Konrad Dybcio X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3128; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=+ytC9NAkfv9kbIOKNH8ea9oA05pxToOL3Hy/iiMk/2Y=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqtRJwXy91zS9yygq1H9Ixamvn29f+Oxzyd4Xqz 89FxhThUf+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCarUScAAKCRAbX0TJAJUV Vq84D/9MMfPToI5LZ0550ef17dvpTVe873xiGraW9WRVWvVDFFmovlKFL9g6GW7tmjTzZLG9yfy fYT6eq4hl2cEDBeFmYHJdr2qQGmb1hq9LXVvSdV7FCWrDm6Z959WxJm7tWk9VDqkYUl55nAb9oU BGj6pHfYBAB7Jqho6Bidb/cIW7Y2uyGeC/WGJ8CqZ7Lksd+ADnsr1GSiPgN3IfTlJcXjsbL5/4i DjdgVyn7EQcOku1lvDhRjGfRbekNNeVLI0B0rGq8BOampVQVtZA6SGLHnIWRkc8jMcWYn8UT0ZR vb1pdzpyOiKw7gmuzX1e9P9aYEHTSK4VIqvCkWCLc0GPJP3gi9Wg1MAewYS1j3Hu8xLGzr2R5nS iI8cBhp/oId/E5thWeAvJ9kiPZbMNGvy+0UDjgLpB5bVwQ75FclaKTyFcJ9sO7mV0sF783fJX8l mxQAlRpufEQ11nRswMHrd9w3tHx/gknmz9/6AX9lac7o0GFREMnSAdGihQ/IgH14b5Z+la9BbDI GXfJY5yiMf7vjiEuik3t3OvdpVaKEcGpTR4sRC4YD06UVRbzvv2s5rYBEJlt7QvMDK/P6T+pvCz PtYlgCUU/o9GxKH33R1n4WxBUaY1hb0Ji7QVFtvs/W4jlT9TJB95ammKPetI99BeA6AgU5q9mV6 gE/3Q/qzmvDRkHg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=KYhHIgYD c=1 sm=1 tr=0 ts=6ab512f5 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=mIQC-RI9wbHEycrXaygA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-GUID: izAJDqqAhDMy9wRgcvROn-x578LfjTKR X-Proofpoint-ORIG-GUID: izAJDqqAhDMy9wRgcvROn-x578LfjTKR X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfXyNIYj4VuX/QC oosCawLRIGixejRIxiscot+4w6vzSMhDhTugIp2Rq6+JYFqpPCtGkWls4baoiSb9MiuJoLgP7QV nSnV4Ua6y6I64bSNrTW2K4lrZtNqCHs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA1MCBTYWx0ZWRfX/WwZ7o3lRUwr 44QarUCDIYF53gzrinUV1NgN10OFmMmqiGvEY1JyxRHLNvbPg1qxBAKWF9pDm8x4LYY1zsYAIF9 NgbmnkGKKXiD9JPv3e5uJJpYOd44pVWVTcRjzLPq32O6Alp5iPKJ6uGA9slmHzHNBeJyAVW5lL7 79dPzB5T+INbJtpTNbYdwuNgJcMBPeU+sthGqZkkpYQlmW+XvD1sgoRH6tyANygD3d8JPfopYtL JKkNNqu84/vA2alXB38jAiT9Mra7+BM005GFZkHRCAqZXL0YKwCAPvxY0+KRhwKjIJPyokk9G6m xlsGu2GE0TLZzb4xYUqlTquFXH5+GJofM73d7zNCITvISkklFB2y8FkKye87ks97uQz3Fmz+bId /aZXZD+44/JZr8nWoYk1pbp6LrDAynNgJ0jeI4uikLel2Gs/9XgyW6h/FB0feHWPsFoDhQ9Jv+T pXpKIp5I3C4tYNh82ew== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240050 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Keep separate CBCR arrays for SM8350 and SC8280XP to preserve their different XO clock register offsets. Assisted-by: LLM Reviewed-by: Konrad Dybcio Signed-off-by: Abel Vesa --- drivers/clk/qcom/videocc-sm8350.c | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc-s= m8350.c index 057a9474894a..8528aeb3a342 100644 --- a/drivers/clk/qcom/videocc-sm8350.c +++ b/drivers/clk/qcom/videocc-sm8350.c @@ -510,7 +510,28 @@ static const struct regmap_config video_cc_sm8350_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sm8350_critical_cbcrs[] =3D { + 0xe58, /* VIDEO_CC_AHB_CLK */ + 0xeec, /* VIDEO_CC_XO_CLK */ +}; + +static const u32 video_cc_sc8280xp_critical_cbcrs[] =3D { + 0xe58, /* VIDEO_CC_AHB_CLK */ + 0xf34, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sm8350_driver_data =3D { + .clk_cbcrs =3D video_cc_sm8350_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sm8350_critical_cbcrs), +}; + +static const struct qcom_cc_driver_data video_cc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D video_cc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sm8350_desc =3D { + .driver_data =3D &video_cc_sm8350_driver_data, .config =3D &video_cc_sm8350_regmap_config, .clks =3D video_cc_sm8350_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sm8350_clocks), @@ -522,7 +543,7 @@ static const struct qcom_cc_desc video_cc_sm8350_desc = =3D { =20 static int video_cc_sm8350_probe(struct platform_device *pdev) { - u32 video_cc_xo_clk_cbcr =3D 0xeec; + struct qcom_cc_desc desc =3D video_cc_sm8350_desc; struct regmap *regmap; int ret; =20 @@ -539,7 +560,7 @@ static int video_cc_sm8350_probe(struct platform_device= *pdev) video_cc_sleep_clk.halt_reg =3D 0xf58; video_cc_sleep_clk.clkr.enable_reg =3D 0xf58; video_cc_xo_clk_src.cmd_rcgr =3D 0xf14; - video_cc_xo_clk_cbcr =3D 0xf34; + desc.driver_data =3D &video_cc_sc8280xp_driver_data; =20 video_pll0.vco_table =3D video_pll1.vco_table =3D lucid_5lpe_vco_8280xp; /* No change, but assign it for completeness */ @@ -558,11 +579,7 @@ static int video_cc_sm8350_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&video_pll0, regmap, &video_pll0_config); clk_lucid_pll_configure(&video_pll1, regmap, &video_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe58); /* VIDEO_CC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, video_cc_xo_clk_cbcr); /* VIDEO_CC_XO_CLK = */ - - ret =3D qcom_cc_really_probe(&pdev->dev, &video_cc_sm8350_desc, regmap); + ret =3D qcom_cc_really_probe(&pdev->dev, &desc, regmap); pm_runtime_put(&pdev->dev); =20 return ret; --=20 2.54.0