From nobody Thu Sep 24 12:09:31 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 314CE3264D4; Thu, 24 Sep 2026 09:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242755; cv=none; b=k9c0XNNqwVAdq78a5we+BhwPHdRzwxdpXnA5v/LdCo64u+bsbkn0oz0UKAaIVG3ugRyG/1QlIBPsu1bHEbndMsha9yYpC/A7gJ3SJlFngKpbYwGC6b3iGjeyihIqjjJujoL97R2Ds0bODJAYcutIPvoKwlvfA2N7BfcF52MUPN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242755; c=relaxed/simple; bh=bT2W1UDZF4zdPaoV4uUSUjqsSdEIUuEZX91HiXXbM3U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZcsUVYaokQxnswgenu81H+mB1n6JQJ8rwN5MNgR5xoHcIb3KjbL91hK5IzG4SvjG3JhjrDYQd50xomr59lyx0kOdogVFBrDWDkCKZTA95H/Ttl5u1oe1+0kzSgUe4fQMAC4YgOerUyEOCPwGgU8PYZ6jY2nWVH8VUNgsBujkS4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=heZJ5oIS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="heZJ5oIS" Received: by smtp.kernel.org (Postfix) with ESMTPS id C3F57C2BCF5; Thu, 24 Sep 2026 09:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790242754; bh=bT2W1UDZF4zdPaoV4uUSUjqsSdEIUuEZX91HiXXbM3U=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=heZJ5oISsm99AdOvdPiYsZstT5Yc3rpzFpCmQhUcmPum1jmT1hfNx95XxQVLy/ATD XzOmTBz0N5qNk3czuJ1PFUtMcxGGt1XMsdxg9i58LLtfS00nh74IjmaBdMb77aAzU9 GEQO/PV+UbeGFZvM+r3KKSuIziPhXJsCA9cuyGdGMXaGKQ83mB1inDcDg189XFRaOD M2Gi6iHcxAzzUjJ6OPNiGcsl01NWYI9349Y/bSlbrVfoGbRsC/McSNv83u5o3oqlam HI9vThN3B2nXSFDcevgr1RzZktbRxqmhYkEQv9IttsXP6UpFahOWTEQapFTRstqZJZ h0Ku5zYDGTWZw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA380C98311; Thu, 24 Sep 2026 09:39:14 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Thu, 24 Sep 2026 12:38:30 +0300 Subject: [PATCH v3 1/3] dt-bindings: soc: mediatek: pwrap: add mt6572 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-6572-pwrap-v3-1-64769b6446ac@protonmail.com> References: <20260924-6572-pwrap-v3-0-64769b6446ac@protonmail.com> In-Reply-To: <20260924-6572-pwrap-v3-0-64769b6446ac@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar , Krzysztof Kozlowski X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790242752; l=991; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=uNVyUZDV8R4iF2b6R4zcLD0vBmolhtFBIa0lDNJRWD4=; b=ftKlSyYqYUwhwaHAhRGBN11hEB23eQMqN7A1kzia/kjMRE6hb3OiWVgCC/d6sPjxSDM0ciaMo NNpAy1U0jB6A2Yb5KlDkCS16tkgWUftcpAvI7Ai31nkUpFNR9Wp1flX X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add a compatible string for the mt6572 SoC. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Roman Vivchar --- Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.= yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml index e7c4a3984c60..a3cf11153fba 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml @@ -31,6 +31,7 @@ properties: - items: - enum: - mediatek,mt2701-pwrap + - mediatek,mt6572-pwrap - mediatek,mt6765-pwrap - mediatek,mt6779-pwrap - mediatek,mt6795-pwrap --=20 2.55.0 From nobody Thu Sep 24 12:09:31 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 315D83B38A4; Thu, 24 Sep 2026 09:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242755; cv=none; b=HKW9uJtHxnX2c7/hWvxWXMHEjeIsrpi1xDw3awfBTfd1UCykYiSTi+SiMTZujT247UPPw6C2IZCA8miOpCO/Jfnv0EXBvArlsleKlSv+o16PFWUxWfT9eH25Z4PldAN4zTOsX1sYumAnoQvSyF6A3I/aAUapHRHLRw502lBez8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242755; c=relaxed/simple; bh=LhBf7uyvNWdc+1o7fNc8Pq/2LIhba4ntyJokJmrlauQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S/zi5OY3LX5WafnAwzyyTWJeVWadpNC8wDhy5aMl9VxDJ3G7ZwbuL0k1X5ljGDkeN1SARyazU5joyD9qeAaQYTBQnX0HC2vDpeWrTtk7hVwWKAPf/i+0kLem2U6SUmZA4D72UGB2ab+8NSXHuVbz97V62YfY/XqsD0QCyRMPkbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y8+ag2xy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y8+ag2xy" Received: by smtp.kernel.org (Postfix) with ESMTPS id DC637C2BCFC; Thu, 24 Sep 2026 09:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790242754; bh=LhBf7uyvNWdc+1o7fNc8Pq/2LIhba4ntyJokJmrlauQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Y8+ag2xyT5Ik8isUvlaiIiyKJSkZT0+eqaNL1mM3Qtssv3moeUVT2C4lQzA3GrHln hUTzDnRjuLRA1wogT4C1gtUgtzjCq5pHPGOSJi6xQl5ncuS+RBFUy6uYNVX72cjDx2 lnFzk0RyloAXZuCItTrVurAQwz7DrIRiUgW3Wkc05MYfeXLQeZzWYiDFEA4sRA/f5N rov6D2t5FakG1w8vI0aSelqJe7YJvNSi5l6ID5xMoqCHhcP4I8gGyp5lrxC3Voj5r/ H4cftD+PjiwbDr6KYd1l2KzUDWs4dQmhxNH5HmKlcU7nOAx+vbAIPWoNpnQY7a5EPm WkSfObHaL04wA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30D7C98317; Thu, 24 Sep 2026 09:39:14 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Thu, 24 Sep 2026 12:38:31 +0300 Subject: [PATCH v3 2/3] soc: mediatek: pwrap: use correct log level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-6572-pwrap-v3-2-64769b6446ac@protonmail.com> References: <20260924-6572-pwrap-v3-0-64769b6446ac@protonmail.com> In-Reply-To: <20260924-6572-pwrap-v3-0-64769b6446ac@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790242752; l=3556; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=aBJoby976DV0fnBJYf0Tm1Mpi+SpQNQMduSmydmf8uw=; b=+Mav+ZxvifWc322AWdI4+wK84IHSoI7II6Bl7jqFWPZXNysQtvF403/OX3jbztBCHnqn28Ygg w+lmcis1De/CssAl3Xuk5jDsaGY550GRtlLD2oRihXOQtjKHZsV7in0 X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Error paths should be dev_err, not dev_dbg. Replace all dev_dbg in error branches to have the correct log level. Also simplify dev_err and return with dev_err_probe. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Roman Vivchar --- drivers/soc/mediatek/mtk-pmic-wrap.c | 45 ++++++++++++++------------------= ---- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index 0bcd85826375..a4b10b0a97cb 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2475,10 +2475,9 @@ static int pwrap_probe(struct platform_device *pdev) if (np->child) of_slave_id =3D of_match_node(of_slave_match_tbl, np->child); =20 - if (!of_slave_id) { - dev_dbg(&pdev->dev, "slave pmic should be defined in dts\n"); - return -EINVAL; - } + if (!of_slave_id) + return dev_err_probe(&pdev->dev, -EINVAL, + "slave pmic should be defined in dts\n"); =20 wrp =3D devm_kzalloc(&pdev->dev, sizeof(*wrp), GFP_KERNEL); if (!wrp) @@ -2496,11 +2495,9 @@ static int pwrap_probe(struct platform_device *pdev) =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_RESET)) { wrp->rstc =3D devm_reset_control_get(wrp->dev, "pwrap"); - if (IS_ERR(wrp->rstc)) { - ret =3D PTR_ERR(wrp->rstc); - dev_dbg(wrp->dev, "cannot get pwrap reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc), + "cannot get pwrap reset\n"); } =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_BRIDGE)) { @@ -2510,12 +2507,9 @@ static int pwrap_probe(struct platform_device *pdev) =20 wrp->rstc_bridge =3D devm_reset_control_get(wrp->dev, "pwrap-bridge"); - if (IS_ERR(wrp->rstc_bridge)) { - ret =3D PTR_ERR(wrp->rstc_bridge); - dev_dbg(wrp->dev, - "cannot get pwrap-bridge reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc_bridge)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc_bridge), + "cannot get pwrap-bridge reset\n"); } =20 ret =3D devm_clk_bulk_get_all_enabled(wrp->dev, &clk); @@ -2535,10 +2529,8 @@ static int pwrap_probe(struct platform_device *pdev) */ if (!pwrap_readl(wrp, PWRAP_INIT_DONE2)) { ret =3D pwrap_init(wrp); - if (ret) { - dev_dbg(wrp->dev, "init failed with %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, "init failed\n"); } =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2548,10 +2540,9 @@ static int pwrap_probe(struct platform_device *pdev) else mask_done =3D PWRAP_STATE_INIT_DONE0; =20 - if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) { - dev_dbg(wrp->dev, "initialization isn't finished\n"); - return -ENODEV; - } + if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) + return dev_err_probe(wrp->dev, -ENODEV, + "initialization isn't finished\n"); =20 /* Initialize watchdog, may not be done by the bootloader */ if (!HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2593,11 +2584,9 @@ static int pwrap_probe(struct platform_device *pdev) return PTR_ERR(wrp->regmap); =20 ret =3D of_platform_populate(np, NULL, NULL, wrp->dev); - if (ret) { - dev_dbg(wrp->dev, "failed to create child devices at %pOF\n", - np); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, + "failed to create child devices at %pOF\n", np); =20 return 0; } --=20 2.55.0 From nobody Thu Sep 24 12:09:31 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 316C23BB104; Thu, 24 Sep 2026 09:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242755; cv=none; b=XXimEyvqyKjd0hhXTDNT7yp4J+SisHxVHoA5eYzuD6bne7oXbP5UlQL+B7iCyT/0c+9igiRVgoiq1QRJ1aB+zVotZz5UealAHqEkYU/fS/1PhoianrH7rbbT2cRQF3mKolw+WsQJKajJcJMPx8KUIQmR1+bNhKqFSbI3ISZSQAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242755; c=relaxed/simple; bh=0RTxQHG5SrtpOkmN7+AQ0qZmluLnT0Jxv21b+yq+lq8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dR51jGCJX4MdJclRRIMhff5xm71ZMyjKwA8m07n4ygoQD2T9oEJVkKGyP/g9GOW3tiqRNe3P5PRuzBjm4BSzeO6u0gzTuj9w0HENPDjthbDBRvhUl9kwHt8A5AaOqinaCDoZpHbrOp7Q3wnP7Ii87007KzOS6++EKX+XUUVi8ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PcNCsIZ/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PcNCsIZ/" Received: by smtp.kernel.org (Postfix) with ESMTPS id 011F2C2BCFA; Thu, 24 Sep 2026 09:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790242755; bh=0RTxQHG5SrtpOkmN7+AQ0qZmluLnT0Jxv21b+yq+lq8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=PcNCsIZ/vgfG3346EY3GJ0vXUj0aWbAbqnyhTABImkzh2FwQZ9KeiZ7AkixB2Tn80 7fOEcjyJFQXB9ebm47ftjq8uikQuE0h/6UN+sVKjf4VE/9IN0c2GoGUidzld+Dlrct Vzs8otNFlqN6QzAFUFBpTsMtyA4osbALrwp2aFBtaH3BH0AKBtftteW2D4IrXWeiHi gx6GkNggMsRcYfLLUHKLl0YfrZuUxjOFABODsasRq59iNZlMvRABqBrzcpbbCVlcjr smoQzLnZcXcgbih+iMybTJoBlvL4BoL/qc/IuZKCaLxHyZgZFgs2Zbw2T9O8adD+p+ gG5fT+YgzJw8A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE39BC9830E; Thu, 24 Sep 2026 09:39:14 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Thu, 24 Sep 2026 12:38:32 +0300 Subject: [PATCH v3 3/3] soc: mediatek: pwrap: add mt6572 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260924-6572-pwrap-v3-3-64769b6446ac@protonmail.com> References: <20260924-6572-pwrap-v3-0-64769b6446ac@protonmail.com> In-Reply-To: <20260924-6572-pwrap-v3-0-64769b6446ac@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790242752; l=3136; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=5/Rr8S3k+cl5buopSAZz/51dHnX8PxgtHV+UdekTJuQ=; b=3zna0fCsAZGuoEu6X45tKEbLaKOi8CmV2a1/9jAYSfRoPrJiPoGh8AMeJthOLkL6WItLm4gk5 F2X2Og9coxQAeuyxSgaO8HM62n25DBavqHKp+Zo5QRb2KOtLK2r4TxM X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add mt6572 registers and platform data for the pmic wrapper. While vendor kernel source code suggests that mt6572 can be paired with the mt6320 PMIC, no such devices have been found yet. Hence, registers that not included in the mt2701 array are omitted. The mt2701 SoC-specific initialization function is used because they share the same GPS_INTF settings. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Roman Vivchar --- drivers/soc/mediatek/mtk-pmic-wrap.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index a4b10b0a97cb..3f05fc724e15 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -1314,6 +1314,7 @@ enum pmic_type { =20 enum pwrap_type { PWRAP_MT2701, + PWRAP_MT6572, PWRAP_MT6765, PWRAP_MT6779, PWRAP_MT6795, @@ -1733,6 +1734,11 @@ static void pwrap_init_chip_select_ext(struct pmic_w= rapper *wrp, u8 hext_write, static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp) { switch (wrp->master->type) { + case PWRAP_MT6572: + pwrap_writel(wrp, 0x8, PWRAP_RDDMY); + pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_RDDMY_NO], 0x8); + pwrap_init_chip_select_ext(wrp, 5, 0, 0, 0); + break; case PWRAP_MT6795: if (wrp->slave->type =3D=3D PMIC_MT6331) { const u32 *dew_regs =3D wrp->slave->dew_regs; @@ -1839,6 +1845,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp) pwrap_writel(wrp, 1, PWRAP_CIPHER_START); break; case PWRAP_MT2701: + case PWRAP_MT6572: case PWRAP_MT6765: case PWRAP_MT6779: case PWRAP_MT6795: @@ -2277,6 +2284,24 @@ static const struct pmic_wrapper_type pwrap_mt2701 = =3D { .init_soc_specific =3D pwrap_mt2701_init_soc_specific, }; =20 +/* + * MT6572 register map is a superset of the MT2701. It has additional regi= sters + * OP_TYPE (0x10), MSB_FIRST (0x14), GPS_STA (0x40) and SW_RST (0x180), + * which were omitted because the driver doesn't use them. + */ +static const struct pmic_wrapper_type pwrap_mt6572 =3D { + .regs =3D mt2701_regs, + .type =3D PWRAP_MT6572, + .arb_en_all =3D 0x1ff, + .int_en_all =3D 0x7ffffffd, + .int1_en_all =3D 0, + .spi_w =3D PWRAP_MAN_CMD_SPI_WRITE, + .wdt_src =3D PWRAP_WDT_SRC_MASK_ALL, + .caps =3D PWRAP_CAP_RESET | PWRAP_CAP_DCM, + .init_reg_clock =3D pwrap_common_init_reg_clock, + .init_soc_specific =3D pwrap_mt2701_init_soc_specific, +}; + static const struct pmic_wrapper_type pwrap_mt6765 =3D { .regs =3D mt6765_regs, .type =3D PWRAP_MT6765, @@ -2446,6 +2471,7 @@ static const struct pmic_wrapper_type pwrap_mt8186 = =3D { =20 static const struct of_device_id of_pwrap_match_tbl[] =3D { { .compatible =3D "mediatek,mt2701-pwrap", .data =3D &pwrap_mt2701 }, + { .compatible =3D "mediatek,mt6572-pwrap", .data =3D &pwrap_mt6572 }, { .compatible =3D "mediatek,mt6765-pwrap", .data =3D &pwrap_mt6765 }, { .compatible =3D "mediatek,mt6779-pwrap", .data =3D &pwrap_mt6779 }, { .compatible =3D "mediatek,mt6795-pwrap", .data =3D &pwrap_mt6795 }, --=20 2.55.0