From nobody Thu Sep 24 14:26:04 2026 Received: from mail-dy2-f43.google.com (mail-dy2-f43.google.com [74.125.229.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E23748C8AE for ; Wed, 23 Sep 2026 20:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790195877; cv=none; b=CD6Uj0XrVM2RWXvXgyW+BaE37PpsQYQKVS+yEkONd6Yf13Bj7VsgMpAFSxzORPAsB5YltPO3epldehSxImLzc8OrFyGAo0FXhv+GveJ0BwW0Q/p9GC0C9XMFpPGFgyXmmmSHJo/PprPE5Vynz68o659QTgw4RIkEAjxmu/N1mNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790195877; c=relaxed/simple; bh=ktR9e2h8nCd9S0EFkl5DruJEUJcripKPI1tSmR1JOBs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=C+nQEFN68KdLVTQela1CMOv41zzWYkSH7Mil01tN6GHtTrRaS4+FbHG9d0KXESkJocVkrL+/ZLfQh9Y+RJ4/s/1M8Rlzxil4fPseLAiFPt64CeyQ4/qh71P0t9AdsoHWZo6CyNp5xn6FyZlrsiKg2CeC2N8rBgWASlqWfluqi8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WsPFLco0; arc=none smtp.client-ip=74.125.229.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WsPFLco0" Received: by mail-dy2-f43.google.com with SMTP id 5a478bee46e88-33e630052ebso1624343eec.0 for ; Wed, 23 Sep 2026 13:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790195875; x=1790800675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+ZvYoYp7T3tg2JMG9Cckdchh+Egbf2tNmPcdBTT/ZU4=; b=WsPFLco0BTKLwvvYD/SgZxR7EEMa9176KlisVwB54AJYvwXv9rOttuYZqbe0GWlG0R O7Nw2L40x7ZTi0y3HFViQBW7I5H8TwP9jDHjZnxezZ6FiVrMUL7y143XHfirYtGq8TdU 2q8omMlKbC0+07N2TvZ/wMi6kxlGlMHWdk/8CD4IksXriQqXBuHTGDEycFGunSj09DKz zXsXRxiWmd/MhJuuc1SRm+TyDX+3R43WfVngqkSGYgcRfi/HLTyW6MZY2TlMng4/G1l4 CAcvrlDEkB8E/Q3UsM2rUHqyF1MYSaQqko9AFY4yDhr2EszY5YMdXbFEBL+fXiQQEQZv YdbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790195875; x=1790800675; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+ZvYoYp7T3tg2JMG9Cckdchh+Egbf2tNmPcdBTT/ZU4=; b=FZSqoGNyAqM+tI4OEJKYpZ3reYT+zs+s/EvhXRBDp8WutnZ+G4fDwW2jSesGzVtqgb xl1hYOMFKTfqsFLPxCCFitA0/2aGLp4BBa5QnNko3Hn63GjfRTGVD8U9+nso2QOZIn2W LR5uBDE0dPqxsS6+cCUN2Cyzjp4Ts4nOIb1/WZfyrIgo7t6NjP5S2K+lp6bSAmeCy6g7 sC3uEx2ObZxTvePiD7aQQstDI/rVsljZ2B4YcxE4tZVJ2UH7B/ycnGzV5zQtcDMNo8UM IYW84Cn5+6ih0uzRhpTchgE5z+WPmNCqGZCD13359HlJw/C+hPuvCvKiNpTPtP5HG5PN sR7w== X-Forwarded-Encrypted: i=1; AKwUvBw4gwpLRrfcS1E4Qhkmsz0/3NBV56tOA94PvNsvZSV00bwnd3qRrdUpKgavThCp34jGnh/NLUT0KVc+ic8=@vger.kernel.org X-Gm-Message-State: AFuF++lQkKY0sD/hPQZ953DInW+OvwvqX1msyXauA525djg7e+108v36 LSSFB+KPgXJlx0f7xof2n1HreP6ELTyFoON2lFsQUvVYngz7iMHG2RQa X-Gm-Gg: AYBFou32ZS6yYUENv2CvKFZwUDo7MXyASaY5M1l5iTXReQ83PZ8IZFXDjEy+NaZjCz0 5iPOsVh/PHs3Xy5BcLwpylovMMpU+aZuOgRLGQeFX8iKm6ovnpGM4+dsqvv41vGdlq7M7wa2jvn y54K88Yj31RZrPzgJQovcypF10EAEC2ZPHsF5QAgw/kvyPW3TNqYLXcdLWY/NcQscKUQSJFBgez nNi7Ak+EfNeJfKy4J1kHFKaMBNa5YHDPfTQL8lJQvyXMmVAxPKDrGNt0QcVVcbQX3gHntmMPvXp tcijeIa5e5JVHl78N2N1vVAJlyP8uzvVVBl5OE1iUujpZiMKL9/Lni7OES42txh3+iLz1Xb2Kfh AcZvTWcm3rvohnq3fCEKwqtrFhT71VyKJ1ORwjj2pN8vdjLcYxWIEXl2TbWwFKo23t5o01zQ8IW WPA3rNl4q8s1QLwdoRJqywCzHR4lJ8LYeudqGu1u6uGR4xFboIWLwZd5Yv0HaczMA= X-Received: by 2002:a05:693c:8206:b0:339:8131:424e with SMTP id 5a478bee46e88-34006978035mr212595eec.34.1790195875080; Wed, 23 Sep 2026 13:37:55 -0700 (PDT) Received: from beelink.. ([187.13.30.172]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e95c7cfd9sm8375052eec.5.2026.09.23.13.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 13:37:54 -0700 (PDT) From: Aldo Ariel Panzardo To: wei.fang@nxp.com Cc: andrew@lunn.ch, frank.li@nxp.com, shenwei.wang@nxp.com, imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Aldo Ariel Panzardo , Sashiko Subject: [PATCH net v2] net: fec: reject oversized fragments before bounce-buffer memcpy Date: Wed, 23 Sep 2026 17:37:38 -0300 Message-ID: <20260923203738.1583735-1-qwe.aldo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fec_enet_txq_submit_frag_skb() and fec_enet_txq_submit_skb() copy transmit data into a per-ring bounce buffer when the source address is misaligned or the FEC_QUIRK_SWAP_FRAME quirk is active. The bounce buffers are allocated as kmalloc(FEC_ENET_TX_FRSIZE) where FEC_ENET_TX_FRSIZE is 2048 bytes. However, skb_frag_size() can return up to PAGE_SIZE (4096 on most architectures) for scatter-gather fragments, and skb_headlen() can exceed 2048 for certain GSO packets. When this happens the memcpy overflows the bounce buffer by up to 2048 bytes, corrupting adjacent heap objects. Add a length check before each bounce-buffer copy. If the data exceeds the bounce buffer capacity, fall through to the error path rather than performing the out-of-bounds write. Fixes: 6605b730c061 ("FEC: Add alignment handling for FEC driver") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Aldo Ariel Panzardo --- drivers/net/ethernet/freescale/fec_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethern= et/freescale/fec_main.c index 794ec42..8614984 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -558,6 +558,8 @@ fec_enet_txq_submit_frag_skb(struct fec_enet_priv_tx_q = *txq, index =3D fec_enet_get_bd_index(bdp, &txq->bd); if (((unsigned long) bufaddr) & fep->tx_align || fep->quirks & FEC_QUIRK_SWAP_FRAME) { + if (frag_len > FEC_ENET_TX_FRSIZE) + goto dma_mapping_error; memcpy(txq->tx_bounce[index], bufaddr, frag_len); bufaddr =3D txq->tx_bounce[index]; =20 @@ -634,6 +636,8 @@ static int fec_enet_txq_submit_skb(struct fec_enet_priv= _tx_q *txq, index =3D fec_enet_get_bd_index(bdp, &txq->bd); if (((unsigned long) bufaddr) & fep->tx_align || fep->quirks & FEC_QUIRK_SWAP_FRAME) { + if (buflen > FEC_ENET_TX_FRSIZE) + goto release; memcpy(txq->tx_bounce[index], skb->data, buflen); bufaddr =3D txq->tx_bounce[index]; =20 --=20 2.43.0