From nobody Thu Sep 24 13:39:02 2026 Received: from mail-dl2-f43.google.com (mail-dl2-f43.google.com [74.125.229.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F16E47C10A for ; Wed, 23 Sep 2026 18:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790189543; cv=none; b=EtEHNOC1NO4WxL7NQuIHeoWij85FJvM6uxoqbkVnoI7T+9s5/qpTDX51c3dJYN+l5FQPz7mrAsLPHm6HPZqg7VJ+TvUHTaj8I52RfQvlWvFfZ+/VlPi5zooimDlGWFOrzji/wL5d/njDEqTVmcY9yYBlz5xoDWBGEo0mne0Rf6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790189543; c=relaxed/simple; bh=S1kGMndTJBeB8hHVwavfqDOuTps4RpJZyzuxQjF7lOs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NEhgO3gANyNAMUaOjS/TQ1a0rJbY+dA4RRGfu89Eq9iKNDtipoeNbu+D6xJRpbpt8ZkCqzUDZ7r38AfWqbSKi63L8aXi6GqfwDnyjD7mCqtvoq6xxIpmafyhFPiV4rOHDJbvh6CHuPyggULc5bXVccXH9dmD6LrxRn+1SmhFWY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eSosJwGX; arc=none smtp.client-ip=74.125.229.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSosJwGX" Received: by mail-dl2-f43.google.com with SMTP id a92af1059eb24-143880e27dfso355171c88.1 for ; Wed, 23 Sep 2026 11:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790189538; x=1790794338; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=LHB12ofgunTotyZpvRl/PbRaWxixASh+pYObMSubPjU=; b=eSosJwGXzay6kp0eEGaylxnvoApBvyy93aS9EY7yMizN1CDylg6LpsP8eUqInN2V8L nhHexEqumWOWRseCperGbxFgU6gmTb+2ojW5av9Xx9+MMvjFfaZTEzmUgUCqMosvVOXC Z2/Tg0aJiIhCU+EWACfsB1To/sYfj5NbKhWW5Nb0mWJRXdDdq0hWmE+nDrXbLbgV5ppl rGEJLXKm9bZWevsyni3l/Yocr2J3vqWg9P2RvHQv7SSL640hQGxy8rnYLomMYk7WZnM4 Qm5rKrhEGaM8xgrZQh+O+FO45TpqD8viVDI9tv3PK2ahXXLCIvdYyBHPlmGZ2aAd7IBK KiwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790189538; x=1790794338; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LHB12ofgunTotyZpvRl/PbRaWxixASh+pYObMSubPjU=; b=LqTv96f6A+81VEoSZZIBeJaWj6BGJM8wjs054BQBRF/lPsOmsTFXsegKDMtn7XOgc0 /eNz77Z/hFDf9kZdrLqt9IaG95v0BYaa6z1JguuVC5BurF28HLjMODGbbCgw6inqk/Qu vAhwZ04a+V/4GEUktBWAcP6d20j5hh0z1QYJmnQU/1PR7zaxzhWNf4Gxf74oFSkgNxhk isy6VRmWTORpFdY/BaFMklFDdS4ifVmEFp36lvGVehhGRoBwqe0fJobG7sOECg0QtE4k vNo2V6/osVEBTxdFj/qzlToC4EJhecr43uh1aXUf/xB2Q1+73lmPyAEDcdyhqWLx3q2+ Zz6g== X-Forwarded-Encrypted: i=1; AKwUvBzOihBhj553sMmty5okQwhTbavru6OhhNE74gowYRS89Se2vEoNADBWxAXeGS5i99KNWxuEja+Eq/oBOH8=@vger.kernel.org X-Gm-Message-State: AFuF++m5CDyRuMw7npUNZJUCTkZkkXazhcSxJBAzYasQuBF0BMODvfFI fmdjjKBUy/0D8mQmFGoeqPDbLVINXD0/AJ+xyJHHZkRpeQ4TSzPRl+Jt X-Gm-Gg: AYBFou0hAFRhUZ1eCVixChAbtn2C7z53tOgOEkiHwe6ZZ3sHHXleJbrW9WRTsgVtJJf RaNX2Q91fQ1eGn1ZT0q/1GmD3Xy0L+BoyZLk6Ww8Vvt+J1GwKMw9LNprxqzvuq381VcHTfOrOu2 qdFismHAc6EdlI3bHGUDpqIR1qR6sTuii7FEyA/zXHlcam/ViXH8kRIh9cikxqrE33XcQSsEttH PsWjXmmZTlQuqXXsIjpjpey5w/JmfmAaSHL4HOX23+qTNw7rEkGEnnH8ejYLSI3Xvb6TTtDBriW NTcITMbGFrXFCU9ZbUF/eZBFLGVuofO2DmobW71WM3WKKDGeDnsu+xuk90S+FeFkGes916H38ix S15v7iW/BvNpejGXGt+m0c/O3a7GWB5mbfCW/q4gLVmscWZRzbXe8p7wjAIX+CE3tVTBfEi99dj bWKM1hVjLoA23j2aCmFrleudwVSAKvZNCr97ygg4FrjPXmK/ijpQ8rDMkDQjT1gaJaS3TWKQzUW ANHTJh+8gq6Iqitp+kIbVnsQirZLKwiiGDX X-Received: by 2002:a05:7022:3f8c:b0:143:2979:c87e with SMTP id a92af1059eb24-14503fefaf0mr48309c88.33.1790189537699; Wed, 23 Sep 2026 11:52:17 -0700 (PDT) Received: from archlinux ([205.254.163.5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-144f983d73fsm9654094c88.6.2026.09.23.11.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 11:52:17 -0700 (PDT) From: Suchit Karunakaran To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev Cc: song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev, brauner@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Suchit Karunakaran Subject: [PATCH] bpf: Fix inode leak on token FD preparation failure Date: Thu, 24 Sep 2026 00:22:06 +0530 Message-ID: <20260923185206.91210-1-suchitkarunakaran@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bpf_token_create() allocates an inode before calling FD_PREPARE(). If descriptor allocation fails, alloc_file_pseudo() is never called. If alloc_file_pseudo() fails, it leaves the inode reference with the caller. Neither failure path releases the inode. Call iput(inode) before returning the FD preparation error. Fixes: 981bec8f698b ("bpf: convert bpf_token_create() to FD_PREPARE()") Signed-off-by: Suchit Karunakaran --- kernel/bpf/token.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/token.c b/kernel/bpf/token.c index da915a4f972b..7375eaee6a23 100644 --- a/kernel/bpf/token.c +++ b/kernel/bpf/token.c @@ -169,8 +169,10 @@ int bpf_token_create(union bpf_attr *attr) FD_PREPARE(fdf, O_CLOEXEC, alloc_file_pseudo(inode, path.mnt, BPF_TOKEN_INODE_NAME, O_RDWR, &bpf_token_fops)); - if (fdf->fd < 0) + if (fdf->fd < 0) { + iput(inode); return fdf->fd; + } =20 token =3D kzalloc_obj(*token, GFP_USER); if (!token) --=20 2.55.0