From nobody Thu Sep 24 13:37:13 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6494A0EED; Wed, 23 Sep 2026 18:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188153; cv=none; b=XVGPzu742EKWznTiEtTq039AnAzjkK6/2prNxuXMfC47CBOnlFKpb6b3BD2tyJM5cqelyAZxupiV8wIXWvLIo6fgYBWq5SpvGj9jU4U19RKxLvgQ4r5wKmF2OiBbrZUGO2AmtPr+EhvXfmnsbtNegn9T2fWdEyChoJcVtObat1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188153; c=relaxed/simple; bh=egPyPSMytQkU/uhH8h/JTmuFUeEtv2s+PSJRuV7Xdg4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UDmbHqAnhbjwD3vmuy+k5M+V3y59KL6iU4skToVd7qWLZ9TOOMH+3KwpITO+sh0U1M/ZpSsuqeUQTlTZLbQpELSy/qlchKCcQ8I3NL9C4wmykng20QyoCZGnMhAk2yYYYlCGSOrNDoyFL1iqq8LTW2dsL/jTCdia7jRsLkf6lYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=bz+XIa5S; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="bz+XIa5S" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZOLP2048265; Wed, 23 Sep 2026 18:28:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=gO7WMLMxLCLeKAuVc bRabWl9GxDrv3S61aRQovTiWdY=; b=bz+XIa5SVYh9bAfpzQFz9s3p2ufZ+HuVf 7oItWKcmq+qBfN6L+vn3ED9xlmkfC3uAIVOB5MezBUwdtNtdf/FXvG58PKbf/Z6E iM1Hx/ItVKYpEkq+CaesG7a0hUaIkfENTal1jzB9ic0s3euAMB2vcLMLyOUvJXAN iHmYLqzSXuZu//qTlme7e+QBDzXLs8IBxW39SpbLDAz7ns1JkHFAfphbThiYVxg3 CMCQ1i6CGXQI2uBQpGnNMz38kHYZnuxZoY0yDGLc7r9fIeGrgDfSCG/75htscL8V ePCJyaF91sw2VEV5D77RTjq8I4GqVvILbBe7jLXMuK7CTZVZat9ng== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gske1vy2y-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:28:58 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWtuP664875; Wed, 23 Sep 2026 18:28:57 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbe1t99x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:28:57 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NISrVV33489280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:28:53 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 86F7320043; Wed, 23 Sep 2026 18:28:53 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D71320040; Wed, 23 Sep 2026 18:28:48 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:28:48 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 01/12] pseries/plpks: fix error handling in plpks_read_var() Date: Wed, 23 Sep 2026 23:58:05 +0530 Message-ID: <20260923182816.151451-2-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: dDqJ8daWDB0lJWgwI9pe4Ip3naXO74It X-Authority-Analysis: v=2.4 cv=EOCTQFZC c=1 sm=1 tr=0 ts=6ab41a6b cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=gFDXozieBbrukydjEA0A:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX1QAHR6kOrAaP xKXN29oAKKj/BNWp1PSp8wcYEMrzBDVZBu1p+/047bmj41n/s2C5PrP64fLKMNUmEOCOEUJ3cKo XPtudeqj4qbE29UPHKIaqozE6lHDzNY= X-Proofpoint-GUID: A7C0g6-MtWkuF4Iy1IulKj_L6ifq3Z3i X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXzfwtsxil7Ggt xqsFb78EdMGmsW6GbWuiLkm9neEsKQf/kEzhw8V6n3/+qZ/riDEhxVIMkEV0zXF9lCY2qf/4r2I z/F9ir02vpiNGwBkHk4whHSS5pAF7C9luto7aU9SGa/c45KRw1tL9iY9+3h+IivQB0ppEDagVwr 6f8DR1rbj4KydLJSrysc/5Cb4SBY7Yi8Mvo9ABL8RZUs6oAH0mXDu4v/3RjoZo/2tcTCBJGLryA 4OAHR7e68df9wdXm+kPsaAZE/r6vmfkdTjbKGED6xr7i/yGzwSXDsqOW+S6DvJHAingYa35cI3z XPM/sScSJ/AtlqjwXUcCtwIOIoSRHhj+tiUj9cH4oxLjxEqI1qmhgzJjVlwQxSE8HEyAlloB6Vs JQJW462SllRO3u0wWNVjHagsKuDN5CCFeaWzcBRbZrsRCzxgBRV871LViLfwLnBFr30wUjr3d9F DBRk1HuCGY3X63tvTUg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" When a PLPKS variable is initialized without a policy and used to read an object with the PLPKS_WRAPPINGKEY policy set, the hypervisor returns H_AUTHORITY along with the object's policy. However, plpks_read_var() currently treats this the same as any other H_AUTHORITY failure and returns an error without propagating the policy information to the caller. Distinguish this case from other H_AUTHORITY failures and propagate the returned policy to the caller while preserving the authorization error. Remove the explicit assignment of zero to rc on H_SUCCESS, as it is redundant. Also validate the PLPKS variable pointer before dereferencing it. Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform KeyStore") Cc: stable@vger.kernel.org # 6.0 Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index 23e4e2a922fc..7e56b3dcacbc 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -822,6 +822,9 @@ static int plpks_read_var(u8 consumer, struct plpks_var= *var) u8 *output; int rc; =20 + if (!var) + return -EINVAL; + if (var->namelen > PLPKS_MAX_NAME_SIZE) return -EINVAL; =20 @@ -856,22 +859,21 @@ static int plpks_read_var(u8 consumer, struct plpks_v= ar *var) virt_to_phys(var->name), var->namelen, virt_to_phys(output), maxobjsize); =20 - if (rc !=3D H_SUCCESS) { rc =3D pseries_status_to_err(rc); - goto out_free_output; + if (rc !=3D -EPERM || !retbuf[1]) + goto out_free_output; + goto out_copy_policy; } =20 if (!var->data || var->datalen > retbuf[0]) var->datalen =3D retbuf[0]; =20 - var->policy =3D retbuf[1]; - if (var->data) memcpy(var->data, output, var->datalen); =20 - rc =3D 0; - +out_copy_policy: + var->policy =3D retbuf[1]; out_free_output: kfree(output); out_free_label: --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B214E77EF; Wed, 23 Sep 2026 18:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188164; cv=none; b=KinuXYCwVQFERfudzxd64ILCM2Cx4fZmtA50mvMdf7xQe6FAj09cQZ7SecTffeWteQq9ohQ/CNn++V6Q40KxvdW1jmmifK1aZp1qQWZv71moGS8rm1Od+wh825R+7OvozcNRTffPkqI//kMxNVrdiEnFf4eZAbBzLh+zgN5P3yM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188164; c=relaxed/simple; bh=ZuhdfIdhnfSW4LL9CGp1sKtQ2Tkj0KT8VDa2575y9tc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nPfDZns5rSooUaxhD4jfViW1BvL3z4+c/Kz84qk7MEqJcJSyJiCzjosJLlCkXJhiiq1BQ9kYTWHDXyQv18NfCJoClPmzZtFycCmzHhhk9Kspr1/AysvHVaACsISFgpRJ6QQHVW2gq4vtOcf2rGjc/zxELrdyE0q2NmcborYGGiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=dG99u3yp; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="dG99u3yp" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZUAC2748577; Wed, 23 Sep 2026 18:29:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=ywCMTSCyeGAzbgXH5 x2KBRyc3ZG46OMv0ToQVSC5CN8=; b=dG99u3ypLoVjczPELGUEhV6Qfg+/CW5QR Z5h0V5APZSjgvGo12d6eIghEFPhblH6LAPDZJBFY5fn4QZF5kqo3tPGGiu38Fejj ZuEkYAB75AeQZFFsZJfrSabby9LkrvhnJ7s6rPswZ3fOK4na8TWvSJKjkK8DFxCV gS24jq2duN+sBjLTRk008JZtRvSwP7aMB9YBQJaykxUk0LfBIyN762S2Fu1k7hjM UFpRtUxu5zRe0NR/+v7UwPQ29u2SYY1ibBZpINq/05VX7e5bQHJXRpYkTJCFTnAp GqDXQE2t1WwqxtKA2Y2Rl4Q4X5v99mru8LfHH3Gvd9b2+z7xKud9g== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgqmc7e-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:05 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWvGg627784; Wed, 23 Sep 2026 18:29:05 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbt2t585-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:04 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NIT1IM39977254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:01 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2185020043; Wed, 23 Sep 2026 18:29:01 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8707C20040; Wed, 23 Sep 2026 18:28:55 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:28:55 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 02/12] pseries/plpks: fix error code for wrapping key reads Date: Wed, 23 Sep 2026 23:58:06 +0530 Message-ID: <20260923182816.151451-3-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ab41a71 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=NZelvwgA2UR8l0CqTt0A:9 a=zZCYzV9kfG8A:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX8xBlUSKcUzLT /Ot8eOE+EK6KQkyouPcrWN/uP4Ec83dShNCgdJcsSoRPWVSgpQAg7fYUwVzQdOaHxo9Z+mkQkgJ xlWWLX0LOiqwxScakxkFFCx4Jx1mDtQ1I3ZqjKnhYDousp6oFO65Ehdm6Dcp/hUllTQ3XKKp/Q5 u6j9GXYMnBffmuHsJ9oaWzM7C/OEmkU3V9qOIf0dc4cELHsBKze6ZrROZOjLL7zTSkM7ykfZxwP jUZUBnxjnP6TMHDy2T+ysQzWNVDqrjTH8OOzMUSD/AyZipdNHgczfIBxOj73ckVsH1/VOjC9XzX UwgEo0Ak2PsYzEKuVY1O3DCxo6WTLb8dhHam0+5QPGjUeixUXhIxslOmuE/UpFkd5prcMH8toNW nd3fL1HI2Z+FAcqBrii2hqAPbV2Gqi0Kvl9IdDZ9phKJKF6fA7JtFRUTwg3a8zQXI894Xvf0tBO GsE33ZsZdlHrMm+rUNg== X-Proofpoint-ORIG-GUID: S7BzPrRGZtS10uKzJDj2g4kMevZHVlPE X-Proofpoint-GUID: VowuZ-cfXH1a2eK1HrNdZa7bRnxQLKRV X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX4ZCbHVE8Xgvu kUOy1XHw3ekRvqAfjknbZBBd88I7/WEX1U/vHKdZwflCpnW19bZ/um4a5dBm72zvLduBVRmaVsa fSd2w1DNQFa8PuMfJ9b2JMo7EwYY9og= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" PLPKS variables with the PLPKS_WRAPPINGKEY policy bit set are not readable. Return -EPERM instead of -EINVAL in this case to better reflect the access restriction being enforced. Fixes: 133aa79e211d ("pseries/plpks: add HCALLs for PowerVM Key Wrapping Mo= dule") Cc: stable@vger.kernel.org # 7.0 Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index 7e56b3dcacbc..ccf5765a907b 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -829,7 +829,7 @@ static int plpks_read_var(u8 consumer, struct plpks_var= *var) return -EINVAL; =20 if (var->policy & PLPKS_WRAPPINGKEY) - return -EINVAL; + return -EPERM; =20 auth =3D construct_auth(consumer); if (IS_ERR(auth)) --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B0F5293E2; Wed, 23 Sep 2026 18:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188172; cv=none; b=JgfE+LCfn5PG4WPiTp1jkcVOaPdIYAZVWwApNgwG+OCYl2PYHbcXSbkudbQ9brytVbEo8D8UHi62VmJPEh0wNXx3Qwz1ZEK2Z3HapLLIoPkHii4ruiuDRh4CNV8GXbJVCoXo60kHk0x+48azk6f87h3q3MQEkSIiBz8DWSnpC2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188172; c=relaxed/simple; bh=tQZk+JgKLtZQBxD9D+Yyo/U4Nn3G3/3YwqbReaFRgJ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U8376WFXmG1b4dcjpoAVb8ZEqm0fLOxjyONqaj9W7SXPi3oKron4m6CKk4inK1jRO4ofLTLz/XkZZMh2TfjbVPD1cNLuO1ZIZTGNlodXHzCbjgVHlvPQ96RXp3IuB0ZQnX3O9aa2jue8+1l2fCTEsLQdx84Ybl/NUuHOKiqUc+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Vv46exxg; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Vv46exxg" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZR5G3922270; Wed, 23 Sep 2026 18:29:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=+wT9UEH0zRXl8PkUH GwD3BWZzUNntpye/wP+VfQ6Xng=; b=Vv46exxgD216knRyALJ6l3GAUPGmWU9bU Pwre7jx3E3bsqZ+2VFwoVFlAtbbjVFmgbbpzOcJWEZ+ambc4neVzbYBDY2kmj7o8 2bjgASBKE6akWj8AH2vCopHhkYr6GCHW2nLFZMQ+ddOjCQBE3PS50juOI0e+7AxX lp5UTl6dbc4REwLHQwBMJXKaA3JKdbDsokr4QAzBIoHDjl2XcngNL/5wNOC2+rNc jSvXFm4UP+Rrvu1yTKyRiSySfJGesqCmDSwOi55ISwqXgMaHf/c6cvKq5EP15Ibo yCCytL2lGT9IllpCtUruQLtSezbOFoO22gBvRPvdJn8gYn7L4Jycw== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgscxkk-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:17 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWmM2681761; Wed, 23 Sep 2026 18:29:16 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gvb6qj9tk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:16 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITCQT51642750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:13 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0C7D20043; Wed, 23 Sep 2026 18:29:12 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7588920040; Wed, 23 Sep 2026 18:29:07 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:07 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 03/12] pseries/plpks: validate input to plpks_signed_update_var() Date: Wed, 23 Sep 2026 23:58:07 +0530 Message-ID: <20260923182816.151451-4-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=V/XoQuni c=1 sm=1 tr=0 ts=6ab41a7d cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=sfM6kBY1oWISPlYXYLMA:9 X-Proofpoint-ORIG-GUID: me28gTSg2Pl1wzWIz2Xth_1DeFbfD_4I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXxAFBXPd4zp25 81h2EO2kPuuDC5847UE51MTT5NMdytGlOgUqi8T3jVdL2cDSUEr6bsRHMyzlqzFvADD9J8CqHsO 0anYtKGm58Xt4YZfszdcAP87t5DK2DXy71ZT+G8M9mcQ5DidRWwmutZzYlsTPnjm61VGKEViHEV BIr/SUebODwcH+nHxZO0aWhGRRExvnFQbmi7HZWzJvJxG8Zt1pmHk4F94quTqhswWbCBhZZZPTy /PFFxGEAZA85lre9jYBAZt6aD8fCD/8iaD+i42gFpMJvzjU2JnGu5K1BnWgIHk8RpuN+hIqju0n LXirzDaBkkmPxNWDODk6Tjo6d+7lkvkHdrsKL+QiFRbSIUMWGyFopnvM/KMe2i6y5QvaCYZshp3 Q2O0l0qY7Dv5AUhYm/mIk34+JRm2xl5c6KLhODE35QGExgvxgdWPaHTBspQp2dpfp419Q6jeGsP QH9GZWUMzc+gSI2C2GQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXyGLiQgqATDfe /QxFWURxJS9DW8bJd/2H5oU4woaFXHoM3AWW0rPhZQWyhPJhsq37JX3uFCzsZ2kCC1gzBgX8Kiw wDRATw72eXx3QgoPPwJZ1lDLAgXmDWI= X-Proofpoint-GUID: hIWcNDcfGi5OTBbQEdXaplvwqC5_rohj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" plpks_signed_update_var() dereferences the supplied PLPKS variable pointer without validating it. A NULL argument could therefore result in a NULL pointer dereference. Reject a NULL pointer argument with -EINVAL. Fixes: 899d9b8fee66 ("powerpc/pseries: Implement signed update for PLPKS ob= jects") Cc: stable@vger.kernel.org # 6.3 Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index ccf5765a907b..e3ae2cd78247 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -637,6 +637,9 @@ int plpks_signed_update_var(struct plpks_var *var, u64 = flags) u64 continuetoken =3D 0; u64 timeout =3D 0; =20 + if (!var) + return -EINVAL; + if (!var->data || var->datalen <=3D 0 || var->namelen > PLPKS_MAX_NAME_SI= ZE) return -EINVAL; =20 --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E905326A0; Wed, 23 Sep 2026 18:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188182; cv=none; b=erSKO5gccjHTpcvIizKeloGjLmSG5i8JTs3vuxkAjrm+6FGTdRP689tfUvKwE9rAbJQFlF6QuDUwQByCWYDgI5DF/e2xIz9H9388wy0LRnqRjTtdz5yeBN+z8KKPipIecQOccZvv9FoGrcxc+i2knZ72FxuOXX8vae9PNwz12PA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188182; c=relaxed/simple; bh=Ia2a9egR1wh2McHjPFZzuxJM/PhWu5apl0PD+4LMRn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RZ84T7g7BY582ScUDvt3qkhzpBfj3AO+IP9WXR9r9LMtTqacZe7KY+69rA2UsMCI5W++NRjAq0ux4db3jOotNiku6ngfBnRN1WdMPh7fpaJx0hXcu5+TQhsenmauBaCeqM1sFI5bDcOm/RIIyTUfhVdZH243x9X8mP0S5HDNSCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=adf4DQpN; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="adf4DQpN" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZLr33921943; Wed, 23 Sep 2026 18:29:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=P7boCCNyEcigrL7CU 59oRfKRZkngHfHczb87pzUn4Uk=; b=adf4DQpNAPrIAeeEGrTJl29KPLRbhAOa+ 4QeJVI9rw6lIMphrkzAT7JEgjMwlcKiaqOcgKYRjkIldYRMUZqYb9nbZqwo3I2+n jyTt2VmfeP11u9LLKXQD52qCE5AlHe8l/k5Pow1W4oVvSMVeNOVe0Dd+OGXCunAY Q25sRpPVO3awPylGGyZoCSk3VF8JQxJLECbtwjijpMXFC1DLlBG2AkqAXsy1mccy FuOAs78CmWlvtvxJgen6bYrB18JOsEUI3jO56pd8J6JowBYVgmP4S9S8xkZviJTr t4GQfgdS5Uqf8/n/llcJ8/UmEWVlIZafEAy9WdJgJ45N2BBvy6Rzg== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgscxm6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:25 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWnWF664394; Wed, 23 Sep 2026 18:29:24 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbe1t9bd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:24 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITKFU45416830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:20 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91E9320043; Wed, 23 Sep 2026 18:29:20 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D456420040; Wed, 23 Sep 2026 18:29:14 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:14 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 04/12] pseries/plpks: clear sensitive PLPKS buffers Date: Wed, 23 Sep 2026 23:58:08 +0530 Message-ID: <20260923182816.151451-5-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=V/XoQuni c=1 sm=1 tr=0 ts=6ab41a86 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=vus6YNbAzWr4A5RBNAEA:9 X-Proofpoint-ORIG-GUID: YI4qsMKNQlCWu0eUOi7I3VxAthQIOZ7o X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX/8tOXSs8ueHT DqNvCRZYF4t17rUoSzv5TXtScR/rlvr2HYybUyPvkmI/tbarBtbxZKu3xQUEM1ECSv+CcH8cgbz lIliqONiaZclFrHIefhKCR53xu7B+mTCNf/zkISjwwpgm5c1wx/4L0D2EYrwZp6Z9/CPw8gb45K Np9RkhCuYgVa3O+uDC0P2dlWWMtEMTDr6r1IC0KowBH4FeT3pzLlKIN/SVnOQb1YUTNpAU1UiLO 8XQ394olE0UjR0JcSpuIyiEuG8G0uBb++YPm7rIEMKiLbfJJkLVm5j2/+hwJha9cTFgtUNT/7jE YvLl40i5UJDlSS30Xmg0iDNtyqm+sJmL6kTaWnaaaq/PcLHeDuZZGXTU3sMjopIS/tT2upxAQ3Z ioW1U9S++VOnni2irIia0icD71Rzqc0FBXpsdeuABOkmMOg84bj8QoJWWvVwLdlhGMFTCnb21++ BqldbmazqyOonO7MhbQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX+SUJkb4vnXFr PvABrytmKroSlEiIrNvo1WEnXLaZTf4kLZfo9lt0KVB3Gb+lOt3Qx6qve9HhGHI5QyYhuSQRIb5 Mt+U3RKozKNV+pc4bo+E43q6yKtMw+0= X-Proofpoint-GUID: jlwCKsWSBKq14AFC7aJoN1EcZKVb6XB0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" PLPKS read, remove, and write operations use authentication buffers that contain passwords. The read output buffer may also contain sensitive data. Freeing these buffers with kfree(), without wiping the contents, can leave sensitive data in memory. Use kfree_sensitive() to wipe the buffers when freeing them. Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform KeyStore") Cc: stable@vger.kernel.org # 6.0 Signed-off-by: Srish Srinivasan Reviewed-by: Nayna Jain Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index e3ae2cd78247..8dbf85e9714c 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -754,7 +754,7 @@ int plpks_write_var(struct plpks_var var) rc =3D pseries_status_to_err(rc); kfree(label); out: - kfree(auth); + kfree_sensitive(auth); =20 return rc; } @@ -812,7 +812,7 @@ int plpks_remove_var(char *component, u8 varos, struct = plpks_var_name vname) rc =3D pseries_status_to_err(rc); kfree(label); out: - kfree(auth); + kfree_sensitive(auth); =20 return rc; } @@ -878,11 +878,11 @@ static int plpks_read_var(u8 consumer, struct plpks_v= ar *var) out_copy_policy: var->policy =3D retbuf[1]; out_free_output: - kfree(output); + kfree_sensitive(output); out_free_label: kfree(label); out_free_auth: - kfree(auth); + kfree_sensitive(auth); =20 return rc; } --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390765172C2; Wed, 23 Sep 2026 18:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188193; cv=none; b=ke5AKcoek3yGNG+MECRFin/9vpMnlwCd5itqbnyPc5R61RFxU0ipz8Q2hAMUWKwH71DzTMNSrNT0Cv9x+cDMqi7M2t175TSYWA44I5GBCmVYjkzUtLyN+1vs0v09kh02Ix5FhNAaSTJQs06M2J0E+LPDW9eAPN7L6ZocpNEfZeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188193; c=relaxed/simple; bh=qvp028X4Wu+yDQDg2akIbxSC4mOxIcdq58cDFCTU768=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kVf65BMdTeBrGXFJHRrmMNIuDoyKUU4jWgVoiSbFQEUIpzCHApSHs5ia3YPVRGObDrIdlnRWUTr5+FAzElxi5XsCl6S7lqu0PEZJ6hvkSTqVP2sxYS1xd4kS9eEOdhDvVlXDJDkT1dA+13gU5iYIHPwySWUYa1RZqUkCghtZcFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=kVYdJ3Xj; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="kVYdJ3Xj" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZn112049004; Wed, 23 Sep 2026 18:29:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=hsVQLhtCzN5/A7h3M LQOWfta3UL2hW82uqetma8bkhk=; b=kVYdJ3Xj6hLtG22QiMIrhaOKe3HFHngaj 2rmpraCcIe18JlgeEO2jM1LBgOj4vju+TSp8sXyl/cDFSf0hoZGqRTxDdxJaVDKw KeKjkXVaNiX6h4AFalByuYPdKLtN42qDbvTe+hjagguXWCAiVmveykfgEapQUmC/ qa5ez4Y62Fr9KUzhqVtCZ4x3DlVKgrseEHZQzE7CbvuLGwxI1XRLFk9/hLWg2/7r siJeKx0HM0UXeRnozQQt4au4P6P2mOtgTg2ZON7Ty6irmlcdzxZ/kkTC8Gi3c2fz va6DZQu7BTxOXjwyvbnErUA4se4NRJEZMha0JQhGAuoOARNasG2iQ== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gske1vy5p-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:32 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWonU678708; Wed, 23 Sep 2026 18:29:31 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gvb8jt9gt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITSus32178468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:28 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0AF6920040; Wed, 23 Sep 2026 18:29:28 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F39B12004B; Wed, 23 Sep 2026 18:29:22 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:22 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 05/12] pseries/plpks: clear sensitive buffers in wrapping operations Date: Wed, 23 Sep 2026 23:58:09 +0530 Message-ID: <20260923182816.151451-6-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: YcFY314aKpeYTwD69oP3pBvR8U0jRKRm X-Authority-Analysis: v=2.4 cv=EOCTQFZC c=1 sm=1 tr=0 ts=6ab41a8d cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=2vvbgfWMNvI2M4yFCmYA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX7KlyrjQ3xHNH dR/ukwN7LTe7x8CnwId0aF7RnpsQ2JmYxMHz2Un9IJahKqhyihguL1m8zsdI2H/xkp4mTPvkFhc 20oOeFu8JJwba8hOadrcV0OxMZCRDbA= X-Proofpoint-GUID: ISnitQ1LhWYJCUmKtWT_W1YQWZz__bbG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX8akLhLF4M6Hv zfriAHBOHpgil3+JkfZ0xHecMfj5QoihLJiyQrdeVwOyZjul/IGJK/1q5pnMXh/q07hJB0T53WB 0bx6tQOp26Q2QlXHOAa8WTOleFfPD9NNfwEG+xSqhboQFH69/2X6UZ7kd7VARriVJlsG/8PvVwI RE55EsO2n7dkrNJSZwufy1j5dUGEot4iuv7rigA29ZtfO8t+IhPQHKBV01Vm0kuHguouHZG1ReH MhC4qnhQAABpvTuUhR+U8nluICKpC9kWbzsrWhf4CCZIpl6f/aXoLNZRWBmIWq+i2zixu2UUQ/M UVgHNUBn9mOXXWY1BTNlNmQt/POhN+TtrlJe04NSQuQHVgah4av9pzAF+75rC6orjMm/bDrjKY0 pPzElQmd0WJKyA9QlDk/45oZBCY6UWy37rYBIiLvQqSjxGUxQz48JrPKfz8DdLwPLJ+nVJdkjXw Nwc1W9+InUXpambcVqA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" PLPKS wrapping key generation, object wrapping, and object unwrapping use authentication buffers that contain passwords. An object unwrapping failure also frees an output buffer that may contain sensitive data. Freeing these buffers with kfree(), without wiping the contents, can leave sensitive data in memory. Use kfree_sensitive() to wipe the buffers when freeing them. Fixes: 133aa79e211d ("pseries/plpks: add HCALLs for PowerVM Key Wrapping Mo= dule") Cc: stable@vger.kernel.org # 7.0 Signed-off-by: Srish Srinivasan Reviewed-by: Nayna Jain Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index 8dbf85e9714c..17a73a04d45b 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -975,7 +975,7 @@ int plpks_gen_wrapping_key(void) =20 kfree(label); out: - kfree(auth); + kfree_sensitive(auth); return rc; } EXPORT_SYMBOL_GPL(plpks_gen_wrapping_key); @@ -1100,7 +1100,7 @@ int plpks_wrap_object(u8 **input_buf, u32 input_len, = u16 wrap_flags, out_free_label: kfree(label); out: - kfree(auth); + kfree_sensitive(auth); return rc; } EXPORT_SYMBOL_GPL(plpks_wrap_object); @@ -1177,14 +1177,14 @@ int plpks_unwrap_object(u8 **input_buf, u32 input_l= en, u8 **output_buf, if (rc) { pr_err("H_PKS_UNWRAP_OBJECT failed. pseries_status=3D%d, rc=3D%d", pseries_status, rc); - kfree(*output_buf); + kfree_sensitive(*output_buf); *output_buf =3D NULL; } else { *output_len =3D retbuf[1]; } =20 out: - kfree(auth); + kfree_sensitive(auth); return rc; } EXPORT_SYMBOL_GPL(plpks_unwrap_object); --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1B253CA69; Wed, 23 Sep 2026 18:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188194; cv=none; b=mttdbq/YsiMYg/LCsSPNbrnjxve5cTYCuVn9ON3WBnRqiO3SKIHx3OPXKzPx4Q/c81R3mUpyWtUXiDCsT9OASR/33mDtnlUJeha5DsVKB8IHLkA2NXnzbej7stQtapnsAhc52nAy1NC6oI2y7+kionrwp2NXYsYmQmBHNKnbm1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188194; c=relaxed/simple; bh=TfC4I1EYh+gAknpU8osTIY7sl/c9WJN/9EN/jbLVtYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MXle6F6L4aV+JhB0HGFmgIobZQ4+8b149wu78dAErltVWG42Gd9D+zShiUXIWm4gnm8w3gwYhpJ66DYCzADJ5YFLcxj2p/uWp0zbqJkrGnlXAUACk6nvOhv2D3JbSaRWSibicrVqo7iDF1xsp76etIyN0EAv2OuO5H6xzd6T2eU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=mD4vznrk; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="mD4vznrk" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZngj3926353; Wed, 23 Sep 2026 18:29:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=CIO81MQmUZtyjUlkt nrVjloqMXEXfOvi7Kyr/qIBmBY=; b=mD4vznrkbGbhZDPmfSkDb6+hFpweMOfE5 qpR5Jj5GUplUiRRxcsq8YxYheKKKgZnlzYNUu67HgqwL8IoU8cYK+BYqFMPJNKch l00S12WSqRN+r1fzVOxwD95MUc3KA0v5+B+40LFfchYSIupdMhWdxtEdvigkBRYj xJVmWryHKkR8PsP1weOLRVuyrPHiCVbFeCI5il/8KOJo1uJNqT0eERCW0cu8TVsi F3qLH9ghXGW59jhlOUqFgx/OA6jVpHvtcn4AKjao8a6UOKdz7Ghz6vlFnZ9/Ko7X JdOjdjXqgKRS/n5VQ4NffPh6NTtJAsg5KcTvPGVNuyCk3wVlfwDIg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskg2n0rh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:39 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWtpc3571223; Wed, 23 Sep 2026 18:29:39 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gu5bkj93n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:39 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITZnQ42008976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:35 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 667D520043; Wed, 23 Sep 2026 18:29:35 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D93CA20040; Wed, 23 Sep 2026 18:29:29 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:29 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 06/12] pseries/plpks: clear signed update authentication buffer Date: Wed, 23 Sep 2026 23:58:10 +0530 Message-ID: <20260923182816.151451-7-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: pTlMW5FpqqNPDc4iJtWWC8fLY4K1NgxW X-Authority-Analysis: v=2.4 cv=I43w19gg c=1 sm=1 tr=0 ts=6ab41a94 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=aIiXfJ5NXcxv1dgaZq0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXwK3vRJxSY8s6 tS7kovMHYKcbB6+mM/XJ4ImhJWfROy2jPJfhCnLKHz7ztWgKh0d5I7PPeH/dPnY8OkHUsVigELL fLylOzd5VxNGykw1w86aI9IjnJ8ukTkjxjD0TW5P6Y+KM5OojB7xTrRYYpXKaGWU52WWgo2y8Rg ktFIbcLOx2NsLxhc29VZjjHONmZeszCS5F0ju5PIp6M1Oc7OISe8FrVcKOODZlWPraKXPdT3E9A oRMi/S+H7YrTDHZH3FFx7LHinV3CRodEA8cKEqmAjVqNVWotZg5Y0gwXZOBCEBUjJm9ugf3zdFR V8KuS/8t0W+6XM55KIrfFG7guhBUtirrhPgO+kHv+0SY5cb4PkXXQRAWPgtLmMVoDwTOhTGcvWw ijy7UlhR2r/mx63IU0x+LJW03vxJ0DnNyZv3NBp0OmgwjGL6hxGI0oSm97OTMfID4DdFAvyJsxl Tlq8f572oL1j8TWBWdA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX3OJ01FwRDBKP GMiZYvVlO4vdGkPZox+k1U1WWNZXfHeFkh8LZ06VsTKzxLrJPBwd0VD9F4L0uok8JjEP0Rk5Fld TlgpKadrq4EAL+oryhe0VYLiX2OaWHs= X-Proofpoint-GUID: HBBs54GYQynKQnWX-v275IboKyKe_sLO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" The PLPKS signed update operation uses an authentication buffer that contains a password. Freeing this buffer with kfree(), without wiping the contents, can leave sensitive data in memory. Use kfree_sensitive() to wipe the buffer when freeing it. Fixes: 899d9b8fee66 ("powerpc/pseries: Implement signed update for PLPKS ob= jects") Cc: stable@vger.kernel.org # 6.3 Signed-off-by: Srish Srinivasan Reviewed-by: Nayna Jain Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index 17a73a04d45b..b057e378a6b3 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -685,7 +685,7 @@ int plpks_signed_update_var(struct plpks_var *var, u64 = flags) =20 kfree(label); out: - kfree(auth); + kfree_sensitive(auth); =20 return rc; } --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E936556B92; Wed, 23 Sep 2026 18:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188204; cv=none; b=flMJWBLZvv5rLOQhLPEXFA9amDLbURAXBCtjT8x2YOZbDw9bAnF5BHdNbcytRquI2ZpOnK+yoUhuaSWl99OknHjp1FhIv2ikdb1tpZMjn/yGGimwLnWdiVkXnIHk4kKrUJ1P3cotI9jlyNbUWAq1taGstM8FW1qg6n5jHObHwQU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188204; c=relaxed/simple; bh=UOa264gU0HKr/iFrlj9ZmkKo4b/IK0gm6en2+TvOe+Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I0t0qJzHMERHayomRVgXmiyrA/irb5FAY4vWoKe5BABnnOd3wii9c7Uc//m8zDvcFYtb/iQ5eJFoRVYbFIHnaVA4d5w30rSbSHRQMeRcICPxSJFvSMTeBNcon39Wm8wA1Jd7wbX9t/N9jRtOgVe900Uz03xpGA0MK5dj7C/2/Jo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=RxPxyGeM; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="RxPxyGeM" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGaFY53765689; Wed, 23 Sep 2026 18:29:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=/68d2jRHIXwzdYdWg ZQG+0mX5K+5CfoKIkS3N3rtcq0=; b=RxPxyGeMkBUznQIxbBEq86GEGH2uLcNxw hRn16REu704PPj4XXlVm7HrJvoRzskdk03cJyLGGn8+drsR2oi+QFGmL7Jf7l3wD xdhuz4mqbjx1lK0tlAekS3OpvtIGgru17vTNxCz58RJbTeCZmKDK9Z02yLIORozU DOsWDy9O0HdbqXZpjRyt1SfE32AZvpPEeoY4/V7xxHa/oWKALWAGpjV13fgdsPlt anzp75wIegDOj1XNw7ctiu6dAKyTeKFgaEgJEUI8VjrvRqu6XnPM4nq2pglwRqQc Wys+am+YCCl86YR39ihY3NbZb+I2zrL5YpR/0DIF4+K6NNopc8EBg== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gske1mgnf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:47 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWmSs681758; Wed, 23 Sep 2026 18:29:46 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gvb6qj9w9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:46 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITguZ42074388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:42 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8FC2020043; Wed, 23 Sep 2026 18:29:42 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75FE020040; Wed, 23 Sep 2026 18:29:37 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:37 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 07/12] pseries/plpks: clear SED key data after use Date: Wed, 23 Sep 2026 23:58:11 +0530 Message-ID: <20260923182816.151451-8-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: OaK4aawNOFcwnCv3Wa_qvEK8Jv15GudF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXzPHcfBpH3PMz mWecZVLxRUnQotKQJNB5NsVfxFcgFEIHZERuY1+L/A2ngLIYqF7tslvLZWn8shLRPW2+Dh5m/Ll uSg84xXNvDT1ERcfj6aumnzH1R4Non+UPG7D7VGc2b/hI5yTNrFDsjAlm7VOB7cl+VNaKweuvgd ZPqkv2eoUqo3P6zkuEz9y0vSrQLjnvUIKzM3zouZUkNC0QrDytUKItZhV0xBSOT1mycGhnkB517 5exA72hXpgJfClAboCSv+OAJ/E4+LtZesIoUMY2scRsDrAMbg4zFjdhiySd1FNG4K5XKkgZAdbL hAwMnTUCVu86oSA1aW1pZVBJWK99o8J9pVsjEOQNlidGw3Wu+ELlzMFK4GUuUQXjeBbFkGtmIzl 0fowuYi4aWlBY68ABjzPSWbKQujf0PJqF6iGdGe+DYSToxWYkz13yz0o1CEtXLjFTNP6oFJr1AA AFY3kcvAUqyMMZOt4JQ== X-Authority-Analysis: v=2.4 cv=O/KsLx9W c=1 sm=1 tr=0 ts=6ab41a9b cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=uQcaG2zeyhcm6AiLOIwA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX+ssQjkiMYQF7 dKyD6E8elWVdlkXCd8VTyzkKDsIgSfvxZZR7b4yAfSv8yygRIbkMXMiZhuCgZTRdiZIvwO2nnub HuU5g+oL0UzZRovjF+2kuFSt3laQDok= X-Proofpoint-GUID: 8ZWD4pzB8hvzzxyI8mssDMUS0t-senxN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" Explicitly clear the temporary buffer containing SED key data after read and write operations. Fixes: ec8cf230cecc ("powerpc/pseries: PLPKS SED Opal keystore support") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Srish Srinivasan Reviewed-by: Greg Joyce Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks_sed_ops.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks_sed_ops.c b/arch/powerpc/= platforms/pseries/plpks_sed_ops.c index 7c873c9589ef..ac3ec2ca7fbe 100644 --- a/arch/powerpc/platforms/pseries/plpks_sed_ops.c +++ b/arch/powerpc/platforms/pseries/plpks_sed_ops.c @@ -84,14 +84,16 @@ int sed_read_key(char *keyname, char *key, u_int *keyle= n) =20 ret =3D plpks_read_os_var(&var); if (ret !=3D 0) - return ret; + goto out; =20 len =3D min_t(u16, be32_to_cpu(data.key_len), var.datalen); memcpy(key, data.key, len); key[len] =3D '\0'; *keylen =3D len; =20 - return 0; +out: + memzero_explicit(&data, sizeof(data)); + return ret; } =20 /* @@ -102,6 +104,7 @@ int sed_write_key(char *keyname, char *key, u_int keyle= n) struct plpks_var var; struct plpks_sed_object_data data; struct plpks_var_name vname; + int ret; =20 plpks_init_var(&var, keyname); =20 @@ -127,5 +130,8 @@ int sed_write_key(char *keyname, char *key, u_int keyle= n) vname.name =3D var.name; plpks_remove_var(var.component, var.os, vname); =20 - return plpks_write_var(var); + ret =3D plpks_write_var(var); + memzero_explicit(&data, sizeof(data)); + + return ret; } --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557B255D89C; Wed, 23 Sep 2026 18:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188209; cv=none; b=OJgi0gcySFq/enVcRCAbZ0O6dnvh/NWoBYte8rOXX6b631nS+qLjdKiuq3hYoEfMuTuI5lgOnSHgGEktVSM5y76JbgnH4zfGfJia4O+oDyENoEZdU8CWPB0qnVoHjzwaDh4R3OOCdpOmdugyf6eKHyYSwypQBQp/VPVyaRtF8/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188209; c=relaxed/simple; bh=YLuPwJpRrmKtVSDOoydIzHdGxglaUyYE9ZRhsdfHJww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Azj1T3uSQ9EQip8OztKueqpayrbH277fhatr7TRdvxeTgj3x27UDw2nq/pKRinGc4+mmqsEyFeZFUu+rkKe6lDDr8oU7I2hJvJETrNmcfUOh/xOLyIr1hE44dH+6Z8GaE9OxBVqBaGQtUDz+135NfsUpbhK1CjAFOJGuS3x+fEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ITnSxDkX; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ITnSxDkX" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZU0t2748589; Wed, 23 Sep 2026 18:29:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=iaEz+6QywLOSl6dAT a3b4zYaVDYmXm67qihLDTlnzZk=; b=ITnSxDkX1Xvi8eIrVJEJLNRB1FwtJU3RG BbEZb19AbFq4/n+no+7mT+to2dlQJQENQRW04mKHQizibB+hueY/UE0+b7kza/fa y0lTBXz85/Mi/jhJrEEujdBPYnLuUSr3cJ7MPgboiipszOZ5rB7ZyNYvcTAoHVTW pPAiACzP1L0VvfbAFzbKYVKCsvJtYIeaJ6jqirmT1oB+LxnEhfFTCXt2VNzKlk8l VsKRYC1nOP/F0lReNm9YBeRgbAHUpvfNBZPpL/qcdDwVirbSN+z09wzshuRGhkFu QxCqT3Ll8tVU8hHsFyS/tpx/6++OpWOERKxIJEmsBlFncU8wJsKNg== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgqmcaf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:54 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWlHQ627135; Wed, 23 Sep 2026 18:29:54 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbt2t5cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:29:54 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITo6h37945636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:50 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3BC4620043; Wed, 23 Sep 2026 18:29:50 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DEE8320040; Wed, 23 Sep 2026 18:29:44 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:44 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 08/12] pseries/plpks: fix self-reference in plpks_var initializer Date: Wed, 23 Sep 2026 23:58:12 +0530 Message-ID: <20260923182816.151451-9-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ab41aa3 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=yo0uri9pEEIi5ApSFXoA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXz8krcbR3/MPD x27Jp3R7tFQMCKhNIwrjZR07Druiy0pnfSMSFqkCmqNVGkiiQWbu94vEzr/FUW3XFnuwvmvrsri dw1CRNWIMUl/JZXmgF3J8w5UKUTQqM09sNkS+siMr3JfezCfFn2cAg5ysJuluTXsDJSHQgBFXeM PRvygci7yaL5wq5fbog4k2k8kWYRzK1DxdRslRcvHFzKn6TjRxRTyDTWDMi9SF/vA+XKloBHIU/ RvwZATysAumR4H5RgsDNq9nU9EnqkWHbdbdXOmeYC1HYA9rOX2sHupcDg6I5iR+qaxBjV/pBAes wSRtCXqKoQRRrpLGhKjE59nklZBfCLl4ALRrQwjK2OepmSR/2PpiYJh3kIZwz3lo3KZ8+O/r7UI m7iDf2Kw6yaUnHkXIP+O8hO+a8K2t72vfixOzYOy1U443z5A/iGIPGNV8gOZn2BiZj5HvrZDgPU AXtkYLt+KVmm/TdGlZw== X-Proofpoint-ORIG-GUID: xwLBW0TR392Uhzyl-Cs4IEPM5itDGu2c X-Proofpoint-GUID: YVNtTcaKrZFciylE5s9l1Z8VG-lYsgOE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX+gMMagsVD04e hy0oOzdzgaGAEHrlwywYUTsty1UKwhw8arBWHRWaX1L8M/T+0zfxaoGBN6f6T+hr+R/e/3wvJNO Ng3UXW9MEydekqjiMFsxyts0lrr6B60= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" In plpks_gen_wrapping_key() and plpks_wrap_object(), strlen(var.name) is used to initialize var.namelen within the same struct initializer. This references a member of var before initialization of var is complete. Use the compile-time length of PLPKS_WRAPKEY_NAME instead. Reported-by: R Nageswara Sastry Fixes: 133aa79e211d ("pseries/plpks: add HCALLs for PowerVM Key Wrapping Mo= dule") Cc: stable@vger.kernel.org # 7.0 Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index b057e378a6b3..896eda3eb65f 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -939,7 +939,7 @@ int plpks_gen_wrapping_key(void) int rc =3D 0, pseries_status =3D 0; struct plpks_var var =3D { .name =3D PLPKS_WRAPKEY_NAME, - .namelen =3D strlen(var.name), + .namelen =3D sizeof(PLPKS_WRAPKEY_NAME) - 1, .policy =3D PLPKS_WRAPPINGKEY, .os =3D PLPKS_VAR_LINUX, .component =3D PLPKS_WRAPKEY_COMPONENT @@ -1034,7 +1034,7 @@ int plpks_wrap_object(u8 **input_buf, u32 input_len, = u16 wrap_flags, bool sb_enforce_bit =3D wrap_flags & BIT(1); struct plpks_var var =3D { .name =3D PLPKS_WRAPKEY_NAME, - .namelen =3D strlen(var.name), + .namelen =3D sizeof(PLPKS_WRAPKEY_NAME) - 1, .os =3D PLPKS_VAR_LINUX, .component =3D PLPKS_WRAPKEY_COMPONENT }; --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A81E652120D; Wed, 23 Sep 2026 18:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188218; cv=none; b=fcVslyhJABc2LaATZidxmNUYx4YFvlTrV6RGavVdZyzCu66394QSh78NUcLfRvJSB5ah+r6LeETTIckU9KJWbe3GgciJh+rqw93W5IL8OG9YDOcpvYBDqb3keQcJcoJ0qXaJeCT79/VCVMEuar+VWqyjh6HXYASpJrA2uZTyMys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188218; c=relaxed/simple; bh=QrL7s1L07E+hDgPq4jr4STH+66HbgawTnYeKQXBrTSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nUVwClh8AqMS0+2fOaUcYVx/0QdeLhe7q+NX8iuDY/Jsf3ygdl3OXvSwuNgC5vCdr6MATFd4z/IIRRW58+ZOv9FIvEBIUKSLAWE0pdCNGhLs+A7lX15zXEvhM0GUvfUcpHx6rpvtdSUWlZY8vUdutFy4fLUEDb7hkFQ8697ZA2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=TbA70Nlj; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="TbA70Nlj" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZeWh2748809; Wed, 23 Sep 2026 18:30:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=V8FKdjbglwkp6JeUw /gWkGs8RKEryyBfh04FHL13StI=; b=TbA70NljE3q3EtTp6g/Omu+9daTUPCJzA fdl4cCHWmojL2zGYsj4FNawPk8XUlw7nHIErIkkYoI23fQ8gtremtvNx8DQP5dMd vmB6d6hLshi6eTTWslf9Ik9HHy1tPUMLk5jjEWx1i0RhyeIiHilMojarbLDUgsPY Zl088EuOJ5vY0K9ulN83Y/q/oRXL7iVPG3jcherEw9wLCE2kIKNVbRPfkhVc7Ftp kvWAnQ3eSqg21ALFc+BujXB30VWooAa2sNoHAJQOnYdD4iW1olsUJZ79kNw7fpxi /2Zo2BAX7s/Ul3LpgvP21dtDPNA2OEQM3HmNwLdjhScNSmA29wceg== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgqmcbe-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:04 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWxfY682244; Wed, 23 Sep 2026 18:30:03 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gvb6qj9xa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:03 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NITvxp35062226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:29:58 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DBAD22004B; Wed, 23 Sep 2026 18:29:57 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BCD9820043; Wed, 23 Sep 2026 18:29:52 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:29:52 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com, stable@vger.kernel.org Subject: [PATCH 09/12] pseries/plpks: hide wrapping_features when unsupported Date: Wed, 23 Sep 2026 23:58:13 +0530 Message-ID: <20260923182816.151451-10-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ab41aac cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Lnrgi2ogIeW2OlIaXxgA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX3bUJz79CUo1k kyFllup6jF18G/dmEYgpaVeZRvzeXZ6vOJv+WQC0Tqc0dpX10uRG9JX92yCyMS/YA4cEJU/hKzJ gDDa8j0JW88zlIhLSSx1BTsCFlJfSA/2ws8+5Vc5T7ebplk2guSanx27mzIcTtHAxfIq6Ab6XNi 5dTMCVUSUl7hj2HhE+dlCvbgSXNlDZ8EZkujcRqx+jBLB2Y7szWnQ6IbJ4nrj59Cnow+UxfHVhG bw8KF3ZBM1Mu9TFCaWJ8UwmIQ0sabUkBm7CB9iFU6GtnGASll2ERHUtf9EFNL3sdvNvzhCkqbpL itVbo3FIL6mz9wuUL4O8JowHmm1WPrMBOvpenJsC3LDRFrg3yH8DrIDJzxEYli1H/HWHsyI9zAQ ucz3uKlCRB4PzIpZF4TMZ/+sZCqnDEOZcjylh5QKJX/cdG7+T+TOSDUp4HiOicItWs8bjUjabsy nQblRVECyoCjqVZtiAw== X-Proofpoint-ORIG-GUID: QW7iC57hErNGErSPMKJzBhgkoI269dXZ X-Proofpoint-GUID: 5eRUMSLeBeUtEqrBrcPgrzQdtvOBZpNp X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX++zTutXSxTlD gbX/etK04WeEwgspq0zA4uyW59/aj9zOU3i0ti4KOzF0hhKK7aFkfRlMRa2vaYt16QtqkwsOP+5 tEtoH5mQYh+q6tOwecL7LBgq43lZ7+I= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" The PLPKS wrapping features config is only valid on systems that support the "Key Wrapping" feature. Currently the config is always exposed, even when the feature is unavailable. Add an is_visible() callback to suppress the wrapping_features sysfs attribute when the "Key Wrapping" feature is not supported. Declare the attribute group static const, as it is not modified after initialization. Fixes: 447eb1d5ef00 ("pseries/plpks: expose PowerVM wrapping features via t= he sysfs") Cc: stable@vger.kernel.org # 7.0 Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks-sysfs.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks-sysfs.c b/arch/powerpc/pl= atforms/pseries/plpks-sysfs.c index c2ebcbb41ae3..f2436229f323 100644 --- a/arch/powerpc/platforms/pseries/plpks-sysfs.c +++ b/arch/powerpc/platforms/pseries/plpks-sysfs.c @@ -45,6 +45,16 @@ static const struct attribute *config_attrs[] =3D { =20 static struct kobject *plpks_kobj, *plpks_config_kobj; =20 +static umode_t plpks_config_attr_is_visible(struct kobject *kobj, + struct attribute *attr, int n) +{ + if (attr =3D=3D &attr_wrapping_features.attr && + !plpks_wrapping_is_supported()) + return 0; + + return attr->mode; +} + int plpks_config_create_softlink(struct kobject *from) { if (!plpks_config_kobj) @@ -52,13 +62,13 @@ int plpks_config_create_softlink(struct kobject *from) return sysfs_create_link(from, plpks_config_kobj, "config"); } =20 +static const struct attribute_group config_group =3D { + .attrs =3D (struct attribute **)config_attrs, + .is_visible =3D plpks_config_attr_is_visible, +}; + static __init int plpks_sysfs_config(struct kobject *kobj) { - struct attribute_group config_group =3D { - .name =3D NULL, - .attrs =3D (struct attribute **)config_attrs, - }; - return sysfs_create_group(kobj, &config_group); } =20 --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE627566C62 for ; Wed, 23 Sep 2026 18:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188225; cv=none; b=KMKvIjMMjrgyZTHuHzarGJS2l3oXpOJGXdhBAjNTmwM4bWcxEWTVDjZ9XeVr3vFpLSmFu1NrVOtqOcW/vDRf0NOP6Lt46XytO5FbWmQIrc8t6njn7xEtD1Z+j7JRq5kvBdmDXF4mHRx2mJaDFNlvJcPbUKzGjDJ0MiTxMT/gSCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188225; c=relaxed/simple; bh=C9bSu1Xspx2U/xMpD32VaRhgGHRoZM+b0YWx21+jm1s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K8+S6uOuVXPLJE5DJwrrMHlcHqMBN4IMv11e4ZhYAlCPrzKJ4MDheAIYGTN+gsg/ARamMq6vJN0MMTv8105Jm4sbyWQfUEi4k+hnmcLbAL7RhN9yHdZ7xYa0vUbAzKaOvhjJ77AC6oasT7wKhn7eD3wdHERIl+vEuA4KbKbV0OI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=mTfiIPu4; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="mTfiIPu4" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZTVR2748562; Wed, 23 Sep 2026 18:30:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=sdxfwwrHrCSqjhwaY IipuPSuQ0vL3R2PP7JOg4oF7SM=; b=mTfiIPu4+HqxVT5deEKYGh0VArJOdjeoG ZBzeqwaBMq9mAcGuJ0KFpLnAzoR0OCnqAxFRq+H9i/MM1fXmZal/vYKh75RaVwDp nRFT4qtv3PdBVu/FPBzZOphRmSL5WP9MsvbPhgAuzKlmSD+15+q3QoEeI5fcJtjz iXf185P+R09XnW6xghHq2xUA9vThEGr6pIqVALc2S0LMnB+W8i3hDZ34LK80iKol pk3JNRxhhm3QpdN8nkObNW/eyXnR9aDEdbEfZReHlnr6Rfh+QXDTiAOn5ve3AeCO hKRHHFXIZJgWOcE/zERF5IIJbQ6Dfrvct9Bv5BUQTrAQRE90Me3MQ== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgqmccd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:09 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWsOr621739; Wed, 23 Sep 2026 18:30:09 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbu8t56b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:09 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NIU5R945351372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:30:05 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2DDF320043; Wed, 23 Sep 2026 18:30:05 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 64C4720040; Wed, 23 Sep 2026 18:30:00 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:30:00 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com Subject: [PATCH 10/12] pseries/plpks: make narrowing conversions explicit Date: Wed, 23 Sep 2026 23:58:14 +0530 Message-ID: <20260923182816.151451-11-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ab41ab2 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=o6eGJc963QcO2VXH5MgA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfXzisjlBCbdw/X 8GLJLV1HoNsJRH+3q6I4VlqzMw9bwAk3mfds3tLggnZx1WShWIvtbN0deFEc3TZtW2CmawdwCfJ +Smu9lYcVjIbGUBX3cLdeBJ2T7KjKiVMgRCC+07nvryb5cJFmpe+bTGCYTtK8prR7HbpM4mneGS zDq12pSDSaJuSd1dhr61WBD0YFP2z+5E2gOxmE1BYwYB59i5el6ei7//afEpei3vzmoOmdBThJG MKvaxR1Ihp1WfgLRPDWtayOgRkxEA6OBqd894KZ3fAwQR5cNTILcWqOAj6jIPnFqiDk7I7guhE3 dSf8AYVPal8ltmCRiIf97UUy03Aw86PqF2I0roOUkisK/URtpeY/Nias14l4VYj1AE81fhvL3lE 6ihNZGj/fHHSxi2YbgpEwdbeD945ub9Mj79gjKTOJA2SaFz+Gc+p+pn5E3ZMiPDn73Z9TBmna6b JA4Aw42RIKkc+DVv5MQ== X-Proofpoint-ORIG-GUID: mwGjclovUukbAl6Sf-RiAoGqRsdNdpIR X-Proofpoint-GUID: OTf-CWWn2AY9zfclvapt_5aYFLl7QYwL X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX9Wcpr0y0fCn3 x8vUYn0HmI8tQYM4UETOKYscEjXYzT1FkVtrW6XQeozbFQ2y172SSvkWi0y1WWtO6G+NJn9AArE CpBi4jRSX9Mu62JlTzlxPC/H5liZshc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" Add explicit casts when assigning values from the hcall return buffers to narrower fields to make the intended conversions clear. Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index 896eda3eb65f..eff968fe5ae0 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -576,7 +576,7 @@ static int plpks_confirm_object_flushed(struct label *l= abel, virt_to_phys(auth), virt_to_phys(label), label->size); =20 - status =3D retbuf[0]; + status =3D (u8)retbuf[0]; if (rc) { timed_out =3D false; if (rc =3D=3D H_NOT_FOUND && status =3D=3D 1) @@ -870,13 +870,13 @@ static int plpks_read_var(u8 consumer, struct plpks_v= ar *var) } =20 if (!var->data || var->datalen > retbuf[0]) - var->datalen =3D retbuf[0]; + var->datalen =3D (u16)retbuf[0]; =20 if (var->data) memcpy(var->data, output, var->datalen); =20 out_copy_policy: - var->policy =3D retbuf[1]; + var->policy =3D (u32)retbuf[1]; out_free_output: kfree_sensitive(output); out_free_label: --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 148C6568544 for ; Wed, 23 Sep 2026 18:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188235; cv=none; b=qDSG1a2vrdclMPWSuRF98sByp/a4zY8ouUFTyyhuzgHsymKxldlSvzXZxjg/jYzz2La9lIFfLFiI3yL/R1K4opUOL4ECAod6HlFxU0SAfL3wyDgDmnIr1/oUH9j71dM8Exf7S9vDKeIL6QcHvFhulaHt0Jy5/gqEoJGmgl2oDdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188235; c=relaxed/simple; bh=ykaPsaBcf3wmsqZTDXV/oUlFMV4ag/AD+dVfvmDTVyA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sI3ooOZoL1GnY07wc/S/WZO7yVyb63cmuTc7oK/vZkaDXtaz//u7rl7nJ1TYkDm6zyMuTAYVuux8RJDqjmm0gNq4B/HV3h4lAwBe6Xd1Hq8His1cfxKj+2vEyHjGdGDYGjgeH6qPlZksyIkrSF+bxhojhSwmVEl6xo9BnRyYps4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=VahgeL8L; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="VahgeL8L" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZmbV3926266; Wed, 23 Sep 2026 18:30:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=nRBPVkwZlntLgCYvE n3XzhJ8yN0rCtAWrZRJ+coOhBM=; b=VahgeL8Lwj7YVN5RLQvFf0tnqSDAr6g8+ e0+QTnZz7vbQRVlZAQ6iOWQH0g2b5L6ODd4KFufiAT0CED1MRsd+b80g/vHgS+1v T/OjjBh9eBGvRZkegmlfJjfsJiI0MWGqrFiJl+gV4VSQo1C/5rSB60oi4HzSKzUy 9QZrXk2rvJJYPhvkAq3sMYnBvZZXhEbewyR/nHFsndrIuF6aPWU573dZWG2lkYRK xWXexIfvRXmqekLhAKmHuETdADeLXKhC98dWzW/S9QVz9wa9GDVZLsgMw0v/+ki0 5+rZ1ckQdFd80l18SeggTOVGujCSAv1tTfYnQrn/pA3s/ntLhxC8A== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskg2n0v9-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:18 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWtuv664875; Wed, 23 Sep 2026 18:30:17 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbe1t9ff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:17 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NIUDfX42926346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:30:13 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C697020043; Wed, 23 Sep 2026 18:30:13 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33D3720040; Wed, 23 Sep 2026 18:30:09 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:30:08 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com Subject: [PATCH 11/12] pseries/plpks: rename the default wrapping key macro Date: Wed, 23 Sep 2026 23:58:15 +0530 Message-ID: <20260923182816.151451-12-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: WjcLWUqHA8MIeP_pIhRS1a527kYUfZk3 X-Authority-Analysis: v=2.4 cv=I43w19gg c=1 sm=1 tr=0 ts=6ab41abb cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=ZsBnnucTmTjdUaLPtLYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX840Hjm4nSwOw Lyel4RONMC/Mr4cRZmQkt2C7DsDDtTmOZzErRUX9XZ9i59fwfJpuI4YRfTgEMnEqP3DMuggc4vp m6nHOxc9qfWV1178TON61WR9tLHddyHBNuA1EEiGvjApmkMisLdLpW0ch+AvpIjJnuTMigrbNfS ICaHERg0XhM6ydi7mtcagnYN9vld1eX22VojB4K/irSa1SAy68KDY0KaB/QduPgSVeUSdnZ4p48 aPfIUgt0ytBR1rCmOCFmpH2pLmEnB+97Zi4ME43FrIl127bW2BF2rbAZrNaiCqsdiwNXk+u8TB7 KtTOMGMGMon3Eh6PwLUGw3/OOgxlSsHmSNyamriwnQbZwXLUYUQPy7io/YyaeCp+V1im/BUMv10 URJMtVm5ZR3CPp1uopcufBcQSkjXtPP/A6e2/hZ6wS+YW0SXpvPMjrJbvt2oMLcoM88428tqua4 XIdMttKE8G0jhc/u1Vw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX0VO5mMp6ZxhW WRmtWoxaC9xXrRnW7NzxXcfXVKuX1uVP1gd7puGfgbKlyHUqOrQ4d13dafoXENTCfFZT+9O7l/L glj9HMS7661BKq6j8o2mzygmbFLZmyo= X-Proofpoint-GUID: OMqHZxx-qGQH6QWrixx_ZecZtsUgYwMc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" Rename PLPKS_WRAPKEY_NAME to PLPKS_DEFAULT_WRAPKEY_LABEL to clarify that the macro represents the default wrapping key label used by PKWM. Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- arch/powerpc/platforms/pseries/plpks.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platform= s/pseries/plpks.c index eff968fe5ae0..240cd5632446 100644 --- a/arch/powerpc/platforms/pseries/plpks.c +++ b/arch/powerpc/platforms/pseries/plpks.c @@ -10,7 +10,7 @@ #define pr_fmt(fmt) "plpks: " fmt =20 #define PLPKS_WRAPKEY_COMPONENT "PLPKSWR" -#define PLPKS_WRAPKEY_NAME "default-wrapping-key" +#define PLPKS_DEFAULT_WRAPKEY_LABEL "default-wrapping-key" =20 /* * To 4K align the {input, output} buffers to the {UN}WRAP H_CALLs @@ -938,8 +938,8 @@ int plpks_gen_wrapping_key(void) struct label *label; int rc =3D 0, pseries_status =3D 0; struct plpks_var var =3D { - .name =3D PLPKS_WRAPKEY_NAME, - .namelen =3D sizeof(PLPKS_WRAPKEY_NAME) - 1, + .name =3D PLPKS_DEFAULT_WRAPKEY_LABEL, + .namelen =3D sizeof(PLPKS_DEFAULT_WRAPKEY_LABEL) - 1, .policy =3D PLPKS_WRAPPINGKEY, .os =3D PLPKS_VAR_LINUX, .component =3D PLPKS_WRAPKEY_COMPONENT @@ -1033,8 +1033,8 @@ int plpks_wrap_object(u8 **input_buf, u32 input_len, = u16 wrap_flags, bool sb_audit_or_enforce_bit =3D wrap_flags & BIT(0); bool sb_enforce_bit =3D wrap_flags & BIT(1); struct plpks_var var =3D { - .name =3D PLPKS_WRAPKEY_NAME, - .namelen =3D sizeof(PLPKS_WRAPKEY_NAME) - 1, + .name =3D PLPKS_DEFAULT_WRAPKEY_LABEL, + .namelen =3D sizeof(PLPKS_DEFAULT_WRAPKEY_LABEL) - 1, .os =3D PLPKS_VAR_LINUX, .component =3D PLPKS_WRAPKEY_COMPONENT }; --=20 2.52.0 From nobody Thu Sep 24 13:37:13 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E99753B5E2 for ; Wed, 23 Sep 2026 18:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188246; cv=none; b=ejGSVn6Jo9w+MQ+rGf6TdGlVZ+7ZVkHsz2RxrXxagSYJDtD0H4etQ/wbvB9VJFaKS3tCvIqekxN1/VwyHTrHptjywQW21QqOVcS8uovL+E8E6a+UJVamoYkLiD1rG8IOTd0rfjyugNwabq7md1G5pWRg2fFAIGpc+U7vfnr+HAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790188246; c=relaxed/simple; bh=T6H1MbO+/HsCdp4ct+vmmgbf1et9gES/M6QvvfhlXWM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k+tpJ/NQ61VSYXi44tMeJet1PXZSL+wc1+YrcHV86mxyVdCXQL/jWsjL7x0Lzp/MOAbJCA7eYgpwyZ8/IFN0DfLJoLemSSv6PtdoGjlc4bwBR1ItCjZiqouczaS6srl0cZjlgLwbByOfg4F6Ncf3U6BL1Uh90L+ErlE0WzCpVuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=bjRaQ6tE; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="bjRaQ6tE" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGZnsi3765043; Wed, 23 Sep 2026 18:30:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=w1J1z+N+G321cxNkE Z3g3FhEOqDogrxBFm/mVGaYJgk=; b=bjRaQ6tEgjoIhKQq5nolG/L6IFVJrNfUx LYvkP+ZBhHJeID30XIDSMDD5XsuvVe0BTN6Hy1kyv9avp2mNHq/y631YQg00zl8f 30J1PMdRlRJPN3Fu+N6z/WCrqFNbowkwqOS45E/pt1BZ8vAaqZyTpDxgvQp1lT0h FZxSQvCrpsrBcdFQYdSmUo+g5aZZnWyG9CrJHWim7tD5Z+fb0I1ItvVLd7WXl1Lp JzuUwVCAZPPTMFt73Fyit7NzafNvFOjmX5qzkwAruZ6gGE90xoMmiAQm0PtBfuhX gHydFe5TyEseDiW5f/yiKGHw59xLfhsdl8CKfp0umB1N5ydI9ej7w== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gske1mgs4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:25 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGWlHf627135; Wed, 23 Sep 2026 18:30:25 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbt2t5fx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2026 18:30:25 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68NIULD111862522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2026 18:30:21 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F3B82004F; Wed, 23 Sep 2026 18:30:21 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A91B2004E; Wed, 23 Sep 2026 18:30:16 +0000 (GMT) Received: from li-fc74f8cc-3279-11b2-a85c-ef5828687581.ibm.com (unknown [9.67.83.254]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Sep 2026 18:30:15 +0000 (GMT) From: Srish Srinivasan To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, nayna@linux.ibm.com, gjoyce@linux.ibm.com, ritesh.list@gmail.com, sshegde@linux.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com, ssrish@linux.ibm.com Subject: [PATCH 12/12] pseries/plpks: update PKS documentation and MAINTAINERS entry Date: Wed, 23 Sep 2026 23:58:16 +0530 Message-ID: <20260923182816.151451-13-ssrish@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com> References: <20260923182816.151451-1-ssrish@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: vG6r3mDQVpY-Bhhy7IrFQv6ZMeMORD8q X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX7gqcY44SItNH MDTt8QohiQ2W/844g/AGgXryK9ub2jbV01BcIuFTB5nP7Nc0gSsulf4LrVGR8pT7a0IGuKJyXTp 4KApv/Kq4OeWWOG0L2XtPH0TUlRd7hRLINSmm6VXQUE0SM5zRPxLeEvQ+ZGE6rwG3ZxGVv2FLOS ObPcDDkyieGP7nd2Oc+hES+4Ts45Nu/PR8WeINWC0KSvYXl/71a1PRHcC49dlwOzTeL+u4I8aaX M423NXBB2DfEm6BYTEP9f0uuSvq0s9b79mocPbS62aApyTYBRZ7t1HMOqxaPhAlY0ZS9Abgr1I0 vvZ+1KsAz7w4mFNGQsfUXHife7xi6lVfr46c/6TYjBHihUwkRoQUuCly9/9M6t6vJdA+WhA4RTY NskpWAN4GXu/e2nXgR0iovKvYoJEb/UZ5XUrzbG+XP3KdCegVdIFJz8eSXgeTYipRoRScYFGdYh 4lBZc0hrSEYDf+H3J/g== X-Authority-Analysis: v=2.4 cv=O/KsLx9W c=1 sm=1 tr=0 ts=6ab41ac2 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=2YPxekF_mspUCEnIjzkA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA3MiBTYWx0ZWRfX0BM+pQO7V3Ka WFrIU061/xte2YBs+/12Vd4AUAEUMWXIn9oqXyD9rFBpyS3tcXdQ32+WyS5QuFQ8aklb2HsV8E3 lyqvWF46WCMFNcIoOCyIw0a0sM1axbE= X-Proofpoint-GUID: Ox6s56VtInLl4zrN01vsQYbAmN9UIv84 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230072 Content-Type: text/plain; charset="utf-8" Wrap long PKS hcall return-value lines consistently and fix a typo in the H_PKS_UNWRAP_OBJECT description. Also update the MAINTAINERS entry from KEYS-TRUSTED-PLPKS to KEYS-TRUSTED-PKWM to reflect the PowerVM Key Wrapping Module naming. Signed-off-by: Srish Srinivasan Tested-by: R Nageswara Sastry --- Documentation/arch/powerpc/papr_hcalls.rst | 16 ++++++++-------- MAINTAINERS | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Documentation/arch/powerpc/papr_hcalls.rst b/Documentation/arc= h/powerpc/papr_hcalls.rst index 14e39f095a1c..44c9c8b32ae3 100644 --- a/Documentation/arch/powerpc/papr_hcalls.rst +++ b/Documentation/arch/powerpc/papr_hcalls.rst @@ -305,8 +305,8 @@ like core instruction, core LLAT and nest. | Input: authorization, objectlabel, objectlabellen, policy, out, outlen | Out: *Hypervisor Generated Key, or None when the wrapping key policy is = set* | Return Value: *H_SUCCESS, H_Function, H_State, H_R_State, H_Parameter, H= _P2, - H_P3, H_P4, H_P5, H_P6, H_Authority, H_Nomem, H_Busy, H_Re= source, - H_Aborted* + H_P3, H_P4, H_P5, H_P6, H_Authority, H_Nomem, H_Busy, + H_Resource, H_Aborted* =20 H_PKS_GEN_KEY is used to have the hypervisor generate a new random key. This key is stored as an object in the Power LPAR Platform KeyStore with @@ -321,8 +321,8 @@ the user. Generation of wrapping keys is supported only= for a key size of | inlen, out, outlen, continue-token | Out: *continue-token, byte size of wrapped object, wrapped object* | Return Value: *H_SUCCESS, H_Function, H_State, H_R_State, H_Parameter, H= _P2, - H_P3, H_P4, H_P5, H_P6, H_P7, H_P8, H_P9, H_Authority, H_I= nvalid_Key, - H_NOT_FOUND, H_Busy, H_LongBusy, H_Aborted* + H_P3, H_P4, H_P5, H_P6, H_P7, H_P8, H_P9, H_Authority, + H_Invalid_Key, H_NOT_FOUND, H_Busy, H_LongBusy, H_Aborted* =20 H_PKS_WRAP_OBJECT is used to wrap an object using a wrapping key stored in= the Power LPAR Platform KeyStore and return the wrapped object to the caller. = The @@ -331,16 +331,16 @@ which must have been previously created with H_PKS_GE= N_KEY. The provided object is then encrypted with the wrapping key and additional metadata and the re= sult is returned to the caller. =20 - **H_PKS_UNWRAP_OBJECT** =20 | Input: authorization, objectwrapflags, in, inlen, out, outlen, continue-= token | Out: *continue-token, byte size of unwrapped object, unwrapped object* | Return Value: *H_SUCCESS, H_Function, H_State, H_R_State, H_Parameter, H= _P2, - H_P3, H_P4, H_P5, H_P6, H_P7, H_Authority, H_Unsupported, = H_Bad_Data, - H_NOT_FOUND, H_Invalid_Key, H_Busy, H_LongBusy, H_Aborted* + H_P3, H_P4, H_P5, H_P6, H_P7, H_Authority, H_Unsupported, + H_Bad_Data, H_NOT_FOUND, H_Invalid_Key, H_Busy, H_LongBusy, + H_Aborted* =20 -H_PKS_UNWRAP_OBJECT is used to unwrap an object that was previously warapp= ed with +H_PKS_UNWRAP_OBJECT is used to unwrap an object that was previously wrappe= d with H_PKS_WRAP_OBJECT. =20 References diff --git a/MAINTAINERS b/MAINTAINERS index cc3cae2e378b..932eb463428c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14485,7 +14485,7 @@ S: Supported F: include/keys/trusted_dcp.h F: security/keys/trusted-keys/trusted_dcp.c =20 -KEYS-TRUSTED-PLPKS +KEYS-TRUSTED-PKWM M: Srish Srinivasan M: Nayna Jain L: linux-integrity@vger.kernel.org --=20 2.52.0