From nobody Thu Sep 24 13:37:32 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0BE6718A6D4; Wed, 23 Sep 2026 04:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137849; cv=none; b=UzE74UTjReyBxuUxYAQFjgkYndTyyMGYgzjtmtihsLFx7hDghNt2/yNZCGCyqy3oetyqOjVggRnq3f6I2HU5UxBz/s2N8bwy2bQGcTHvP0eYpya4BCl03ZhnCnSznZ6hgZyloj2QE66PEIHw7Jv+HQGFlIW/NGwp60VaLji4Hms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137849; c=relaxed/simple; bh=K2GFsavACM59BHppKSMay0OsbiJTq1fuN6nauzgf8T8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oyztHOx/Pp8+ugETR1/fuKmQBqX5EvsU2rgL3wxKfYEYzzvBxEXyGD2xH+ftJXivFO1y2J/+1BBaUnJs1umf4ZQ2uN8xSuQWAN4a1eyXRMNUnNTdsL+7rCEu6wjJjR4vIz4F2mIpZK6LYPUum3EnFxvQxRuwwZYTSDM941AVHC8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=YoTOmgv2; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="YoTOmgv2" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.23]) by linux.microsoft.com (Postfix) with ESMTPSA id F2D2420B7168; Tue, 22 Sep 2026 21:29:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F2D2420B7168 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1790137799; bh=aJnylgL/JMRa1kdRFmfz0S/D2y2aRlKrsPKCUd98fZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YoTOmgv2I1O3A+6EsJzkEwOQY53x5xaqr4QYpQbNyY76YpsShEzV3lHOT8JK9saVN vt1ilojnRcNPFT3cBy9YHoje+wvdlZBgkphRDyl+rc1PdXDFiQXI6AOTpwqmHVjIRe QaKZ7ikji99/qocWRl4TX7ETBLGxZe9+Ny86PMRA= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui , Michael Kelley Cc: Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v6 1/4] x86/hyperv: Set irq_retrigger for root partition PCI/MSI irqchip Date: Wed, 23 Sep 2026 04:30:20 +0000 Message-ID: <20260923043023.3150498-2-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260923043023.3150498-1-namjain@linux.microsoft.com> References: <20260923043023.3150498-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Hyper-V root partition vPCI MSI irqchip lost its irq_retrigger() callback when it was converted to msi_create_parent_irq_domain(). The callback was present on the original irqchip and was dropped during that conversion. On CPU hot-unplug fixup_irqs() migrates the interrupts which are affine to the outgoing CPU to a new target. If an interrupt still has its pending bit set in the outgoing CPU's IRR at that point, fixup_irqs() resends it on the new target through the irqchip's irq_retrigger() callback. As the root partition PCI/MSI chip no longer provides that callback, the pending interrupt is silently dropped, which can result in lost interrupts, stalls and "No irq handler for vector" messages during CPU hotplug. Restore irq_chip_retrigger_hierarchy() as the irq_retrigger() callback for the root partition PCI/MSI irqchip, so that a pending interrupt is resent on its new target CPU via the parent x86 vector domain. Fixes: 4691db0704ac ("x86/hyperv: Switch to msi_create_parent_irq_domain()") Cc: stable@vger.kernel.org Reviewed-by: Michael Kelley Reviewed-by: Nam Cao Signed-off-by: Naman Jain --- arch/x86/hyperv/irqdomain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c index b3ad50a874dca..6d790636c8b95 100644 --- a/arch/x86/hyperv/irqdomain.c +++ b/arch/x86/hyperv/irqdomain.c @@ -316,6 +316,7 @@ static bool hv_init_dev_msi_info(struct device *dev, st= ruct irq_domain *domain, return false; =20 chip->flags |=3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED; + chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; =20 info->ops->msi_prepare =3D pci_msi_prepare; =20 --=20 2.43.0 From nobody Thu Sep 24 13:37:32 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 66A073932D1; Wed, 23 Sep 2026 04:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137858; cv=none; b=h+7Wylft81nFTSFlWpUL6GGnLIOkVkEvbPvbBuueT9lYtk76TaE3kBsOh6evNqLiqo+xt/gi8uuXQCmeKPc91pB7mdyhIQiQieiMx14BPSws6fewrmV9oW+JwS/q/h5TM5Pgy60VFG56s33o3kkraB4wEMUexHM1WxkZS2tIJ2I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137858; c=relaxed/simple; bh=gehx3dGvPj4lHDhG1yjySyw9izTXNOZnwAeWbXnmxQ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VqdNGoCL6UHJkoznJG+KFGgSqRu3Lq11hcJHU8ZA2MAkTPxjD4oEezYDmfn8EHY0ZZfs5i1qu33tnls2c1ZfFb1ic8uENbnk9QnjuFucxLo9wKBDiFzNzfEfaSTkcpUSOQ2srXqnT0ug1OhNqn/ptv1TmKyT2y6iNtNhME33rT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=Pug7dBR9; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Pug7dBR9" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.23]) by linux.microsoft.com (Postfix) with ESMTPSA id 540BB20B7169; Tue, 22 Sep 2026 21:30:00 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 540BB20B7169 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1790137808; bh=Z0jk5C3tkM90FIKbdzHQoHfOO/fj2jZb8Pw6AX2HRk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pug7dBR9wXlEFL26h9zCbwmTnCBoGlC9NXu1OyY2pKanxLjVVZq6NqZDa3174Bwi+ KEYB+zwpJhPmB3/IqZbrLhagbyOBl12EENkf5zxdKITItoa00nbk4wVyvovTaUpEPH 7lrKZuFdS5vUF8rIoJSO+jdIwfKl9uxgOY2pph/I= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui , Michael Kelley Cc: Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v6 2/4] x86/irq: Use irq_chip_retrigger_hierarchy() in fixup_irqs() Date: Wed, 23 Sep 2026 04:30:21 +0000 Message-ID: <20260923043023.3150498-3-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260923043023.3150498-1-namjain@linux.microsoft.com> References: <20260923043023.3150498-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fixup_irqs() re-injects a pending interrupt on its new target CPU by looking at the outermost domain chip and invoking its irq_retrigger() callback directly. When the outermost chip does not implement irq_retrigger(), the pending interrupt is silently dropped, which can lead to lost interrupts on CPU hot-unplug. Use irq_chip_retrigger_hierarchy() instead, which walks up the interrupt hierarchy until it finds a chip that implements irq_retrigger(). This fixes the issues for those chips which miss initializing irq_retrigger callback. While at it, use a scoped guard for desc->lock. VECTOR_RETRIGGERED is now set only when the retrigger succeeds instead of unconditionally, which is harmless today since apic_retrigger_irq() always returns 1. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Reviewed-by: Thomas Gleixner Reviewed-by: Michael Kelley Signed-off-by: Naman Jain --- arch/x86/kernel/irq.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 30122f0b3af96..acdc1145cce6d 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -469,7 +469,7 @@ void fixup_irqs(void) unsigned int vector; struct irq_desc *desc; struct irq_data *data; - struct irq_chip *chip; + int ret; =20 irq_migrate_all_off_this_cpu(); =20 @@ -490,21 +490,19 @@ void fixup_irqs(void) * nothing else will touch it. */ for (vector =3D FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) { - if (IS_ERR_OR_NULL(__this_cpu_read(vector_irq[vector]))) + desc =3D __this_cpu_read(vector_irq[vector]); + + if (IS_ERR_OR_NULL(desc)) continue; =20 if (is_vector_pending(vector)) { - desc =3D __this_cpu_read(vector_irq[vector]); - - raw_spin_lock(&desc->lock); + guard(raw_spinlock)(&desc->lock); data =3D irq_desc_get_irq_data(desc); - chip =3D irq_data_get_irq_chip(data); - if (chip->irq_retrigger) { - chip->irq_retrigger(data); + ret =3D irq_chip_retrigger_hierarchy(data); + if (ret) __this_cpu_write(vector_irq[vector], VECTOR_RETRIGGERED); - } - raw_spin_unlock(&desc->lock); } + if (__this_cpu_read(vector_irq[vector]) !=3D VECTOR_RETRIGGERED) __this_cpu_write(vector_irq[vector], VECTOR_UNUSED); } --=20 2.43.0 From nobody Thu Sep 24 13:37:32 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B981B392C21; Wed, 23 Sep 2026 04:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137867; cv=none; b=Q98Hg/SdtH5bsvGd8fNGU78yUo8K5XE2NZ1LkOcc9hkGYEo1k6H3YbbfreYJ/WvJ3K9jWJqRCEcI8Ge4XhMx8nWudWdiRFPN1Rx+NyFSyvysx965vfgmV0ZVhGKkIPyRyOp7pmIeBCGDTSXoFScfi1UAsndTumgGSRe8jEfOfnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137867; c=relaxed/simple; bh=Pi7Ov/Kal92hj7ToqKQT4yMx8oPKKvCb1enscGJV2wY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=axnLf61j/7t1yIqP1FZ4O2hfJ8lfsoDBCmEtHpnkQyRQ1i4IvUF/fePqHmgyPSsYhWTJcnMzNxEm0XDw3tbFcPdYxwRUDi9WAS4q9hYYFZ6UU4xr3u5OSlpafWXUMzIK2thH47SM4GXfyRXDduOhfh4QhD0iLkg0tFjyjR8PN1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=aKfjzPiI; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="aKfjzPiI" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.23]) by linux.microsoft.com (Postfix) with ESMTPSA id A3F1720B7167; Tue, 22 Sep 2026 21:30:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A3F1720B7167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1790137818; bh=LJpQliJCdciXzpLxkEWt9focC/jmzFSv0JiuBHEflec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aKfjzPiIkX1O9wCWkgkoLnZNExfLC3wpqtRuj4xmrLqZVT0Vnf690D0yQoYFY+ZdQ KcJqxiVdbsjmGn9LJYYDFAe+I53w6kKjVFrb7nbj00VSqKDtqCR8j3PxlFs4Q+DhYA dP7q4oWF/YoSfwm05jxMhrwd6GIBH2WEssnI4V38= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui , Michael Kelley Cc: Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v6 3/4] x86/irq: Use irq_chip_retrigger_hierarchy() in msi_set_affinity() Date: Wed, 23 Sep 2026 04:30:22 +0000 Message-ID: <20260923043023.3150498-4-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260923043023.3150498-1-namjain@linux.microsoft.com> References: <20260923043023.3150498-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The irqchips used by msi_set_affinity() are initialized by x86_init_dev_msi_info(), which sets their irq_retrigger() callback to irq_chip_retrigger_hierarchy(). Call the hierarchy helper directly instead of invoking it indirectly through the irqchip callback. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Reviewed-by: Thomas Gleixner Signed-off-by: Naman Jain --- arch/x86/kernel/apic/msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c index 66bc5d3e79db3..9160227b9b32a 100644 --- a/arch/x86/kernel/apic/msi.c +++ b/arch/x86/kernel/apic/msi.c @@ -137,7 +137,7 @@ msi_set_affinity(struct irq_data *irqd, const struct cp= umask *mask, bool force) * IRR. */ if (lapic_vector_set_in_irr(cfg->vector)) - irq_data_get_irq_chip(irqd)->irq_retrigger(irqd); + irq_chip_retrigger_hierarchy(irqd); =20 return ret; } --=20 2.43.0 From nobody Thu Sep 24 13:37:32 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A29C39280D; Wed, 23 Sep 2026 04:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137877; cv=none; b=FiYBp4gPalNe7I5U/3ZQxKIM2nWdOBSAVR1hPaYyuEkID4fWpeDtq6d+Tg4pDjYUQzFVCn5cLXHyMP2ruDNwyrbasdFMVJvOkbqWQYgrjuw9Te01vV9F7hivP+cUCEs0jO0dDsr2tbKJvRZsJzF14rMyUmgxybmRMF1n5ArxESM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790137877; c=relaxed/simple; bh=E40V7jmt/NhE7nK7gwVRkI4rHeelo2GfEYHRHUBQIbg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WgnYSl13k57P2xYZFKSitXjN1Atlx4ixAKGD/nFFYEKfkZDm0CMbXwaVkrJuB5BlivGlnyt4L2uiSaNfZMoB6vtC+IAWglJXDQR+kQ4ra6462KWKXmESqmXxnH8qsxIFkIrb2pwuTDZaesyEXp3mZAQ64/K3vpeHW64jqgiQeaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=R2pJDcr5; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="R2pJDcr5" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.23]) by linux.microsoft.com (Postfix) with ESMTPSA id ED4EB20B716A; Tue, 22 Sep 2026 21:30:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ED4EB20B716A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1790137827; bh=OHGvDx4In6uoYof4xS99Sq5eG9shGpVVMJxwspj1MTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R2pJDcr5uwl2jHiogCCGegkA8Yc/j/GwshUliweEmnilZIvx/wkNy0rfYSRBsmMn0 UaTAsyAJd+CYaRRRzP5rqNUYg/yvWYUC+Ilk8o+ToM9wwJ48rXNbZazyWLDJ5presg wHC+XtzTaZ+zhga+BMDwWItx4NhUv90K3EW9Y5sg= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui , Michael Kelley Cc: Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v6 4/4] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits Date: Wed, 23 Sep 2026 04:30:23 +0000 Message-ID: <20260923043023.3150498-5-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260923043023.3150498-1-namjain@linux.microsoft.com> References: <20260923043023.3150498-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With fixup_irqs() and msi_set_affinity() now using irq_chip_retrigger_hierarchy(), the outermost domain chips no longer need the helper as their irq_retrigger() callback. The generic resend path already uses the hierarchy helper. The hierarchy walk reaches the x86 vector domain's apic_retrigger_irq() for all of these stacked domain chips. Remove the now redundant irq_retrigger() initializations from the outermost domain interrupt chips, including the Hyper-V root partition PCI/MSI chip. No functional change intended. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Reviewed-by: Thomas Gleixner Signed-off-by: Naman Jain --- arch/x86/hyperv/irqdomain.c | 1 - arch/x86/kernel/apic/io_apic.c | 2 -- arch/x86/kernel/apic/msi.c | 2 -- arch/x86/kernel/hpet.c | 1 - drivers/iommu/amd/init.c | 1 - drivers/pci/controller/pci-hyperv.c | 1 - 6 files changed, 8 deletions(-) diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c index 6d790636c8b95..b3ad50a874dca 100644 --- a/arch/x86/hyperv/irqdomain.c +++ b/arch/x86/hyperv/irqdomain.c @@ -316,7 +316,6 @@ static bool hv_init_dev_msi_info(struct device *dev, st= ruct irq_domain *domain, return false; =20 chip->flags |=3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED; - chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; =20 info->ops->msi_prepare =3D pci_msi_prepare; =20 diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 7d7175d012288..18f49a251f23b 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1857,7 +1857,6 @@ static struct irq_chip ioapic_chip __read_mostly =3D { .irq_ack =3D irq_chip_ack_parent, .irq_eoi =3D ioapic_ack_level, .irq_set_affinity =3D ioapic_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_get_irqchip_state =3D ioapic_irq_get_chip_state, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | IRQCHIP_AFFINITY_PRE_STARTUP, @@ -1871,7 +1870,6 @@ static struct irq_chip ioapic_ir_chip __read_mostly = =3D { .irq_ack =3D irq_chip_ack_parent, .irq_eoi =3D ioapic_ir_ack_level, .irq_set_affinity =3D ioapic_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_get_irqchip_state =3D ioapic_irq_get_chip_state, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c index 9160227b9b32a..aad2f15eb2176 100644 --- a/arch/x86/kernel/apic/msi.c +++ b/arch/x86/kernel/apic/msi.c @@ -246,7 +246,6 @@ static bool x86_init_dev_msi_info(struct device *dev, s= truct irq_domain *domain, info->ops->msi_prepare =3D x86_msi_prepare; =20 info->chip->irq_ack =3D irq_chip_ack_parent; - info->chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; info->chip->flags |=3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP; =20 @@ -313,7 +312,6 @@ static struct irq_chip dmar_msi_controller =3D { .irq_mask =3D dmar_msi_mask, .irq_ack =3D irq_chip_ack_parent, .irq_set_affinity =3D msi_domain_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_compose_msi_msg =3D dmar_msi_compose_msg, .irq_write_msi_msg =3D dmar_msi_write_msg, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 8dc7b710e1250..2bb7a6f466af3 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -509,7 +509,6 @@ static struct irq_chip hpet_msi_controller __ro_after_i= nit =3D { .irq_mask =3D hpet_msi_mask, .irq_ack =3D irq_chip_ack_parent, .irq_set_affinity =3D msi_domain_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_write_msi_msg =3D hpet_msi_write_msg, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, }; diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index 8a410d4aa3704..0d22324568911 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -2477,7 +2477,6 @@ static struct irq_chip intcapxt_controller =3D { .irq_unmask =3D intcapxt_unmask_irq, .irq_mask =3D intcapxt_mask_irq, .irq_ack =3D irq_chip_ack_parent, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_set_affinity =3D intcapxt_set_affinity, .irq_set_wake =3D intcapxt_set_wake, .flags =3D IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_MOVE_DEFERRED, diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/p= ci-hyperv.c index 056d379b3cee4..a004b08d68fe9 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -2119,7 +2119,6 @@ static bool hv_pcie_init_dev_msi_info(struct device *= dev, struct irq_domain *dom info->ops->msi_prepare =3D hv_msi_prepare; =20 chip->irq_set_affinity =3D irq_chip_set_affinity_parent; - chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; =20 if (IS_ENABLED(CONFIG_X86)) chip->flags |=3D IRQCHIP_MOVE_DEFERRED; --=20 2.43.0