From nobody Thu Sep 24 13:42:43 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61B43B5F59; Wed, 23 Sep 2026 03:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790135015; cv=none; b=OmaZaZqAKcsDrV1bhFhBnPF5du4+MBLdG6ievGkTMSr9uv45OzR3BXcdSpsBgqzO5em/T5fgey8zYCn0b/ATJGCqh+DOQF9GOb3GRGSiA8GIPm9xmasTxldWuqQhm4H/pni/F1s/c2L909bBzfoH+jZ3OqT7giN5EXq+8gVic/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790135015; c=relaxed/simple; bh=yrvLjoXgKccs5n6WAoDBAtAQZg7b6w1sphjFoqImoGM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AfhIAfnb8wIk8SD1rTL36AKKbSBVKc52ENjaYT0VB+tGhREH3Tk2rp3nZC9H4oRv/HHhLozAQY62r+KKZ6WeSkZmZTcH2U9h3B7GyfW7XiMMPQYD4QH3zIFCgofi3e1A1n1iaMRKGPM4LyBNPtRDnJVM11+NeogP3fzqSE7O90g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=LrzEKssu; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="LrzEKssu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=q8 6DGD7uxSyxlDZIv19eJILS2tByPatUUONmvNrIHDM=; b=LrzEKssutUXqjtyY5H zurCzN5sGB2iJglqX2kXOPdZm1NCubXShN+noAI+ZMKdSIeSZ+4dnNMi9GX7sokU JBwmBU3YgizmJ4hRiVqeS6MaxauFyNZuG0FqJZdD/6XV4pG9cbp4unGopED99VIN 10Bh7pBynO62w9oNJWXTmox8I= Received: from chaosheng-ASUS-TUF-Gaming-F16-FX607JV-FX607JV.lan (unknown []) by gzsmtp3 (Coremail) with SMTP id PigvCgDHL9e_SrNqfmmwAw--.13558S2; Wed, 23 Sep 2026 11:42:56 +0800 (CST) From: Quchaosheng To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Chris Zhong , Zhang Qing , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, quchaosheng000406@163.com Subject: [PATCH v2] dt-bindings: mfd: convert rk805 pinctrl to DT schema Date: Wed, 23 Sep 2026 11:42:45 +0800 Message-ID: <20260923034245.396417-1-quchaosheng000406@163.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PigvCgDHL9e_SrNqfmmwAw--.13558S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxuw47tr4fCry3Cr43Cw15Arb_yoW7Ww45pF W3AF9xJrn2gF47u3y8t3W8Cw1Sgan7Ar4UC3WjgryxXa1j9Fyqyr15Kw1rX3s8GFW8Za45 ZF1DWr98XwnrCw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pREoGPUUUUU= X-CM-SenderInfo: xtxfxtprvkv0bjqqikiqw6il2tof0z/xtbC5AFKv2qzSsG3JQAA3Q Content-Type: text/plain; charset="utf-8" pinctrl-rk805.txt describes the pinmux controller that is part of the Rockchip RK805 PMIC. The PMIC itself is already described by rockchip,rk805.yaml, so the pinmux part belongs there as well: the pinctrl node is a child of the PMIC node, not a separate device. Fold the pinmux description into rockchip,rk805.yaml and drop the standalone text binding. While doing so, add the missing '-pins$' child node schema. The rockchip,rk805.yaml schema ends with 'additionalProperties: false' but did not describe the pin configuration child nodes at all, so a valid pinmux node like the one shown in pinctrl-rk805.txt was rejected: pmic@18 (rockchip,rk805): 'rk805-default-pins' does not match any of the regexes: '^pinctrl-[0-9]+$' The pin configuration nodes require 'pins'; without it a node that names no pin is accepted silently, while the text binding it replaces listed 'pins' as required. The RK805 exposes two output-only GPIOs, so 'pins' is an enum of gpio0 and gpio1 and a typo such as "gpio2" is caught. Reported-by: Sashiko Link: https://sashiko.dev/#/patchset/20260923025302.374919-1-quchaosheng000= 406@163.com?part=3D1 Assisted-by: LLM Signed-off-by: Quchaosheng --- .../bindings/mfd/rockchip,rk805.yaml | 36 ++++++++++- .../bindings/pinctrl/pinctrl-rk805.txt | 63 ------------------- 2 files changed, 35 insertions(+), 64 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-rk805= .txt diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Do= cumentation/devicetree/bindings/mfd/rockchip,rk805.yaml index da2391530c16..6353aef3ebe7 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml @@ -86,6 +86,34 @@ properties: unevaluatedProperties: false unevaluatedProperties: false =20 +patternProperties: + '-pins$': + type: object + description: + The RK805 has two output-only GPIOs which can be muxed to the GPIO + function and driven low or high at boot. + additionalProperties: false + + properties: + pins: + description: + List of GPIO pins to configure. + items: + enum: [gpio0, gpio1] + minItems: 1 + maxItems: 2 + + function: + description: + The RK805 only supports the GPIO function. + enum: [gpio] + + output-low: true + output-high: true + + required: + - pins + allOf: - if: properties: @@ -125,7 +153,7 @@ examples: interrupt-parent =3D <&gpio2>; interrupts =3D ; pinctrl-names =3D "default"; - pinctrl-0 =3D <&pmic_int_l>; + pinctrl-0 =3D <&pmic_int_l>, <&rk805_default>; rockchip,system-power-controller; wakeup-source; #clock-cells =3D <0>; @@ -137,6 +165,12 @@ examples: vcc5-supply =3D <&vcc_io>; vcc6-supply =3D <&vcc_io>; =20 + rk805_default: rk805-default-pins { + pins =3D "gpio0", "gpio1"; + function =3D "gpio"; + output-high; + }; + regulators { vdd_logic: DCDC_REG1 { regulator-name =3D "vdd_logic"; diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-rk805.txt b/= Documentation/devicetree/bindings/pinctrl/pinctrl-rk805.txt deleted file mode 100644 index 6ad49e51c72e..000000000000 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-rk805.txt +++ /dev/null @@ -1,63 +0,0 @@ -Pincontrol driver for RK805 Power management IC. - -RK805 has 2 pins which can be configured as GPIO output only. - -Please refer file -for details of the common pinctrl bindings used by client devices, -including the meaning of the phrase "pin configuration node". - -Optional Pinmux properties: --------------------------- -Following properties are required if default setting of pins are required -at boot. -- pinctrl-names: A pinctrl state named per . -- pinctrl[0...n]: Properties to contain the phandle for pinctrl states per - . - -The pin configurations are defined as child of the pinctrl states node. Ea= ch -sub-node have following properties: - -Required properties: ------------------- -- #gpio-cells: Should be two. The first cell is the pin number and the - second is the GPIO flags. - -- gpio-controller: Marks the device node as a GPIO controller. - -- pins: List of pins. Valid values of pins properties are: gpio0, gpio1. - -First 2 properties must be added in the RK805 PMIC node, documented in -Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml - -Optional properties: -------------------- -Following are optional properties defined as pinmux DT binding document -. Absence of properties will leave the configuration -on default. - function, - output-low, - output-high. - -Valid values for function properties are: gpio. - -There are also not customised properties for any GPIO. - -Example: --------- -rk805: rk805@18 { - compatible =3D "rockchip,rk805"; - ... - gpio-controller; - #gpio-cells =3D <2>; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&pmic_int_l>, <&rk805_default>; - - rk805_default: pinmux { - gpio01 { - pins =3D "gpio0", "gpio1"; - function =3D "gpio"; - output-high; - }; - }; -}; --=20 2.43.0