From nobody Thu Sep 24 16:07:26 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C83748B37D for ; Tue, 22 Sep 2026 09:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069491; cv=none; b=l9EKzLm1ig3rlKa/IStiCjoJEj8F3qmUHYIaru1y2hGV40XW2ckbl3f5u+RyQzW09Ui3zx5R1L4EaLx6jtfF/zCiy6LSCgWzYJEIkOhO+7Mzl9jQyccHMKIVTakQAVHh+f4bAYcNSGAqhmgi2TKDxB3h+PEZWqNzWWL8xoNWuz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069491; c=relaxed/simple; bh=aJVsoy5Trk1oVXSy6lO13HBYy2aSxZSVKLzYy8qqiKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QlyEkJt7RtXVB08zEVNig9TP0WXPYsZgSaWs6ZbFv507qtW2WUZjSTrVTdyPZxnNA+WcBQ6+2pIKvAGLAqH2QmNLSqeg3HQh1AnNOQe4ObzZ+8tg2+wBhCU2Pf4kCeoKkfy+L6EjkTIjc3vBuxhGA2s94/YD8o773V0VJ5Q5y5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oHeRpR3x; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oHeRpR3x" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2db1ca069c8so39106435ad.3 for ; Tue, 22 Sep 2026 02:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790069488; x=1790674288; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CtXRhGuw2qVKHIOiXDCs7JborWUyDWhbjStFj79j+rc=; b=oHeRpR3xi5Bk3lr6BWOxege83BSI83jVqgb81lO+9IbZVEnDHIoJBT0PCs607MtviL 83YiRrWHTCUkCwlRwCCBiFGZOAR+oIMiVgO/W6WvqjRcCLrgHmUoWtkMP5EjwTfv/kCy +yswd6ZFh4M2gzBNff2jsEHF21lHdrT87w59VQOYgkfhn1lUcyFzQ5OxjA8mAkmUzBdm Xixf44j9xT2X1n0MlmkOV1Ow/uUrvEuNViQ2yut/U198Njbp3axXNIx1mMUqtt9SDUmu 2DME7Xc0UMgSUZ1d43Av4lggC9sgjstcR0527f4Y6ewi+0E0aISbVheDVhiFayqoxExV EqNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790069488; x=1790674288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CtXRhGuw2qVKHIOiXDCs7JborWUyDWhbjStFj79j+rc=; b=SH1r/itVly6Vb4KfhIOoMAUEQzxuMZDwPPeNbGESEMGKBvvRtjJGCgGljlk7BJ/z6q g9l1bdya3OiMY5LUXo34jwaXfDjfJZ0UY2KXVA0n/pW/MwBWoep9mZMasMnOpwa23jvd jKiJWtGJc8C+oRyeG2NZEYiM//zqvgAEfSza+tFz07pISRr+oZ8LnnlYMCpZQxVQMtho HQ7tikCEIanWSqB3xqZZOPVOVy7IjqpIG/52kh7T7e9Bm8veY7RR28c7/zeHu6V+0AMN VcK8r+CVtBH8jdMnr2e+FZSqYS6SoSdOptFmn2v6luoFGR1DcJeZYyYPkO0fWVHyr5rf rAdg== X-Forwarded-Encrypted: i=1; AKwUvBzdJonINZ8sNYACGRn89hxCGfghjSf9VVki38YUw+XivrgRJNw7/TDYTxIPLUofpsFOyqhOw7xT2iLVpVo=@vger.kernel.org X-Gm-Message-State: AFuF++lXUm9J4/CPZoFwcmvSAVrI8vqLOy+lWW4AMa+UNx+wsjZwRgW3 frW4b2EP+ZZ2V6GB6L0vHsdrzJHMclC36QscVtlqWqE2Wsm2PaYWkF6l X-Gm-Gg: AYBFou0K34v5RZPgyfcb2P+LsfjmHlQ+eW6SWyuzastX8Ze2kciR0QrdoKS/jFLeMQp WCc8elCQFTxPrmKJ7KoPh1RoShlFrgFSieMHCI1LAqxwf01+ufbLmb4Mp6aAIWoE1lB6DBLp5Cn MEQxarxduwPCgbBp9EaTIfyoepk1mo/6paUDZ5glU7GQID56LG9AVvdlVKXVMEcvy5EbNGXh1kD 9oQjgNGpvmOvBEpb/uJEH5nqgEEezHES8uqbTXmLHPTBWnLmNf3WvYtFksGYLLuD4ZCSZ5ThE0M XClGmOyf5mOY8pBXbg5eEv3oyCcAiratP+ZnlwJVk/8dUQqI+KjJjwmE8eYmjKEolgx+J03o6Ut WyHnG3NxB4e54tyCf3LDz6iFCHF8piMJdB7vCcEoNqEAOukPikwZRXiLdPmHgXliN6yk4ZTpcUk wzWexR03/qPjD4YDQv9JaORl+9OvIEIXGs4um9c94UviKg85t/K+BgbOjm9NyFsW2DhclHn0rca sw3kMUXD/u9i8gFSpCB+xsnsTHxs3SURHx4Sha8xkEY0Xe8d3Or25FntAmE+IsR2mS30Xr5rKd0 NJWaQBTnXOituCkNXQ9j X-Received: by 2002:a17:903:2312:b0:2d8:d4d0:7931 with SMTP id d9443c01a7336-2df609d5e88mr7101585ad.21.1790069488413; Tue, 22 Sep 2026 02:31:28 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df63a22f54sm103915ad.61.2026.09.22.02.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:31:28 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: Hui Peng , David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v3 1/3] ieee802154: ca8210: prevent stack buffer overflow in ca8210_rx_done() Date: Tue, 22 Sep 2026 09:30:23 +0000 Message-ID: <20260922093126.141969-2-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <20260922093126.141969-1-benquike@gmail.com> References: <20260922093126.141969-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ca8210_spi_transfer(), each SPI transfer reads sizeof(struct mac_message) bytes into cas_ctl->tx_in_buf: cas_ctl->transfer.len =3D sizeof(struct mac_message); However, ca8210_rx_done() only checks the received packet length len =3D buf[1] + 2 against CA8210_SPI_BUF_SIZE (256). When buf[0] & SPI_SYN is set and priv->sync_command_response is non-NULL, memcpy() copies up to 256 bytes into priv->sync_command_response, which points to a struct mac_message object on the synchronous caller's stack, overflowing the stack buffer: BUG: KASAN: stack-out-of-bounds in ca8210_rx_done+0x117/0x6c0 Write of size 256 at addr ffff8881009e7c40 by task swapper/0/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 ca8210_rx_done+0x117/0x6c0 ... This frame has 1 object: [32, 182) 'response' Check len > sizeof(struct mac_message) instead of len > CA8210_SPI_BUF_SIZE in ca8210_rx_done() so that any packet exceeding sizeof(struct mac_message) is logged as erroneously long via dev_crit() and dropped before copying into priv->sync_command_response or passing it to ca8210_net_rx(). Tested in QEMU with KASAN enabled by passing a 256-byte SPI_SYN response into ca8210_rx_done(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - Check len > sizeof(struct mac_message) at the top of ca8210_rx_done() where dev_crit() logs the error and drops the packet instead of silently truncating memcpy() with min_t(), addressing David Laight's feedback. Changes in v2: - Split the ca8210 fixes into three single-issue patches (1/3..3/3). drivers/net/ieee802154/ca8210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index 01af4f9..a990a0f 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -686,7 +686,7 @@ static void ca8210_rx_done(struct cas_control *cas_ctl) =20 buf =3D cas_ctl->tx_in_buf; len =3D buf[1] + 2; - if (len > CA8210_SPI_BUF_SIZE) { + if (len > sizeof(struct mac_message)) { dev_crit( &priv->spi->dev, "Received packet len (%u) erroneously long\n", --=20 2.49.0 From nobody Thu Sep 24 16:07:26 2026 Received: from mail-pj2-f21.google.com (mail-pj2-f21.google.com [74.125.227.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4505492188 for ; Tue, 22 Sep 2026 09:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.149 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069491; cv=none; b=YLS7pgTdEyCzBezDajL7a7U78thI+2OV9mQNaM+it+9+2e7QUXSccNGYP0BYf+x5vODxMxYJrNtEvQ8PFhvrAywG9IjYM3/oM5ZI7fICYMyRs4I4aK77tOQ+RO+zS28gfjh15GZT7EGvBiDGHnZxsjOzIrsrNBzxLvu/wXVO9ZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069491; c=relaxed/simple; bh=i4OC9tNxEONK3UJ47m/89liS/etDNEUy6A3P8O2bP9E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qh1Se77Y2CBUpvfL3NaK2V0IKZnjg9mqb6LkLfX0Q7FMMyHIJkHj2oaSpdwCasYrAt7pl0UvpZC+JWDN7nBawB8uXoSLzVuQ18odP9MpnTD1DkMBaRsekRoPZyWR/3yx7/NZHMNZsjztOh2R4FRMdyTZaQwDGcdUrLsNSrnp3Sg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZPG7OrNw; arc=none smtp.client-ip=74.125.227.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZPG7OrNw" Received: by mail-pj2-f21.google.com with SMTP id d9443c01a7336-2d747f0b25dso41968935ad.2 for ; Tue, 22 Sep 2026 02:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790069489; x=1790674289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HeXwpq7Q2HF6GXy21WP33oJct9TNeHbmlRru5hr30uc=; b=ZPG7OrNw89Ql0ckmyWb9BU/lSS28OdBzUTejWW/3dK86of03atWQFNDFqZ6H/xQchE DhrRDrEpwypyrmveiq+G4IvA1lU1/yjEJMRidqmKPaIx6wGsKALxeIh2oTP8tTptaAxQ q5BJA4q79fypzdY2S8UNEk5qPoV+BAzwhC4fysqZOD489UAITFIkQC6NufMZ2KQBanqe Muzv/CYAna3z+mS1QbTIf+z1pHhLbkw9wxFAdMdySHjVnk9xeF4MEEV3B2g3/vY3eLbI 41BU0wCINKKJJ8QfVeEiRcoC/ZTADV/yxwx0uQ15/LJEGU3sQc0MzvdIEKr1rzin5Nhb WXbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790069489; x=1790674289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HeXwpq7Q2HF6GXy21WP33oJct9TNeHbmlRru5hr30uc=; b=j4Teba444Vr8HDLtDXGTat6tsodhcS7yPl2KTg5SQU3ymst4V9xH1quZ1QHD7um92c zmsRLqdu0i5/Pd6eh0aJbCx8l1s5OKXR1sxp3Eipzq34N1F/PbWiz6q9wpn5EErnAF0P cewlqbCWELlb+jyrhcBRPFTV1IYcEz4+HYS/yEAMROSSjCOWvEwFoFAC4wM/2+40vm2F nNUiT4vj0ARiAjh5jfy3AA/9io6ApJ+12O5aRPP4C4O/pwGeW5Sl5uOm9FVhMHCC6YpE xxlAcKGBmcmEkFPxIxS9Kjj8PSHTzxcqMxc3Sz7cvIl5d3bwuC1ZgREXduVNfA1CEq6W oQ0Q== X-Forwarded-Encrypted: i=1; AKwUvBztLBmbBc7iTTgQHn+7dkpmnp1qyRMZ8kfdEPf+DEYx97elHr31pDHEVFcbXTwa8lLJ72QoYG8MmMuTUMs=@vger.kernel.org X-Gm-Message-State: AFuF++mjiJkLpbuoqjEeKBsQrR05xdjIfdkZdpg0eVps6UloQ8zWuDN6 PvANZ6WLCNKcRKuLJ/SiHaa4xPqZAiY6SOeyFbYJH+/cNxP+ZmHbGzg0 X-Gm-Gg: AYBFou2tQZOgycEOorm9M1AdRpqMoznbaZqSmgOJ9Pdkj+/Vm0A/kLdqOZXxd6/6H/T jd1GRMvI3DgfEaGfplJAIavJUof5OMew25miDDlzGNTx1xcqn9OHuPEMuPsunIIYr+bDW1kII0c hUFMjavoZiUvhB2sUv3mOy/VA1Q1tB3yledpti8d3BjY4oYzhTUJvbSYpHrOqrkp0l09F3F3skJ zkLgzu0fv21jstjmKAI92x7Q82siYhW/fHrKyqAewyLeSnS3l4Xb0zLmhYtp2almR3Py+sdvBOd 90zXPsLf9bM+A2dqbA/xY5ECJQVm98IL/1ddl9N/3hqKtt89jjdxVCsIwRN9YAPwN6vAQwCoKkB dec1rUMT4vehjoTyzU800VoU1f1fbFp9GcJDL7JVTBoGL5rKI3bSSK+J+bXCrVQO7PjSEqVZ31D PfZQfytZRNpEQdUxXaP2aMvGPSwGiYf9uI858zAEYuJO1VMEnRxcD1XChEpK3QRdF0qzuMi/E6z Xo0e5W5o7mERvS5AjNWs8aI0kH9qSihWIqh78DhUJGFsQDBq+rmnLs5nj3p+0c95qHG9jB+NgEt /JMzi3LtOA== X-Received: by 2002:a17:903:8c3:b0:2dd:c100:3133 with SMTP id d9443c01a7336-2df60b640ecmr6299945ad.47.1790069488860; Tue, 22 Sep 2026 02:31:28 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df63a22f54sm103915ad.61.2026.09.22.02.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:31:28 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: Hui Peng , David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v3 2/3] ieee802154: ca8210: prevent stack buffer overflow in hwme_get_request_sync() Date: Tue, 22 Sep 2026 09:30:24 +0000 Message-ID: <20260922093126.141969-3-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <20260922093126.141969-1-benquike@gmail.com> References: <20260922093126.141969-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ca8210_get_ed(), an uninitialized u8 lenvar and a pointer to a 1-byte stack buffer (u8 *level) are passed to hwme_get_request_sync(), which unconditionally copies response.pdata.hwme_get_cnf.hw_attribute_length bytes into hw_attribute_value without checking the caller's destination buffer capacity, overflowing level on the stack when hw_attribute_length exceeds 1: BUG: KASAN: stack-out-of-bounds in hwme_get_request_sync.constprop.0.isra= .0+0xf3/0x170 Write of size 16 at addr ffff888001907780 by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 hwme_get_request_sync.constprop.0.isra.0+0xf3/0x170 ca8210_get_ed+0x9c/0xf0 ... The buggy address belongs to stack of task init/1 and is located at offset 48 in frame: ca8210_get_ed+0x0/0xf0 This frame has 2 objects: [48, 49) 'level' [64, 65) 'lenvar' Initialize lenvar =3D 1 in ca8210_get_ed() and return IEEE802154_SYSTEM_ERROR in hwme_get_request_sync() if response.pdata.hwme_get_cnf.hw_attribute_length exceeds *hw_attribute_length. Tested in QEMU with KASAN enabled by passing an oversized hw_attribute_length response into ca8210_get_ed(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 2/3. - Replaced the temporary stack buffer in ca8210_get_ed() with lenvar =3D 1 and an upper-bound check against *hw_attribute_length in hwme_get_request_sync() as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index a990a0f..8aa7ffe 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1677,6 +1677,9 @@ static u8 hwme_get_request_sync( return IEEE802154_SYSTEM_ERROR; =20 if (response.pdata.hwme_get_cnf.status =3D=3D IEEE802154_SUCCESS) { + if (response.pdata.hwme_get_cnf.hw_attribute_length > + *hw_attribute_length) + return IEEE802154_SYSTEM_ERROR; *hw_attribute_length =3D response.pdata.hwme_get_cnf.hw_attribute_length; memcpy( @@ -2027,7 +2030,7 @@ static int ca8210_xmit_async(struct ieee802154_hw *hw= , struct sk_buff *skb) */ static int ca8210_get_ed(struct ieee802154_hw *hw, u8 *level) { - u8 lenvar; + u8 lenvar =3D 1; struct ca8210_priv *priv =3D hw->priv; =20 return link_to_linux_err( --=20 2.49.0 From nobody Thu Sep 24 16:07:26 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A53496D4A for ; Tue, 22 Sep 2026 09:31:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069493; cv=none; b=gaaZ0Z/ak92UMjgkGdh/gLuayL+3KTVkdFURbbTqEkJODtRpywW+hNN730abwM9FO8xG1JGHy6HYtPVxdMSLen2bK0OQslj3xsnt5f7/rxbyUS1tcbK5ljJTpJBymQwRAszyBiCRgCTyy0WdErv3tIV8cfJTM/mIr/9feCprOWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069493; c=relaxed/simple; bh=HsCTEwCejflIPGn6aDN5s1ankMoE3xb+l71/mPF9Rtk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C8805OArXWeKkytbvpFWLpN/uK27nlqzv5kMW47dE7pv3RCmAGtHBUoW0kWfG20fOewBazS+qCCavlc4ze3nce5SwRUr9IhOOSJ/uU47ErJ0x6x/aSkREOsxgGVsPsgvXGgPUbV+2p6Smx5ZuOzead9BV3gW5pqFF6UolKx8ZzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VFES/QKq; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VFES/QKq" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2d8fb334ddcso32357305ad.0 for ; Tue, 22 Sep 2026 02:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790069489; x=1790674289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SSk/o6B7IWQ+VmqUZ/savpxYdtj5YDadYMQXYJCjXc8=; b=VFES/QKqFYMpjZFNWkcWcFi5dFQSjHZstd5TZflEVJwY76hQbTgE7ofQDLNCpM/Y8+ 6OJ0WgwxIVJTXSPS8zIdrABmQ6+BwtPj3hZIfv1HLIsZirihnuxmyAjcV85gff8qpqSB AO9AbLszt0Pyxids6NUgzAadi36hJhe3kspf1n1LIbpUe6gmudMP+A//W+oK/MiWa18r kaCTWCiWp1V3EVDFIUzy72CEO1fQHmAIbbDoWigjX1yQZxoiLwHQ89XuSxI77U+o59Ck vhd1jhZahCuMzwWMsImrdR6ZuCucFg1gVNaHJei9XSGI4S0+328KI4CRkejSDM20vdSk tZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790069489; x=1790674289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SSk/o6B7IWQ+VmqUZ/savpxYdtj5YDadYMQXYJCjXc8=; b=rCxivyK3yW9Mq9qLWKwfAd5FbEQWbr2uV6vsiRZmQ1Db6OA0055v5cPqHQUZhlMKWz assrdEXUbJVJFFmta0QvsNBAiLK2nOv1cFKoznAV+X2w+eqMpYJifRRnptWxv35HXu/i v4DI8o9ozWBShOc43o9htxUHEoQkEHaPPB9jWHhD1adh403x/VkZhJnnAYC31fdZXmnR 9rJ2Gsw7d+ojum2XB2/tm7B1ksMnsWUq18L4zUaEcF5YlqplRo9rBOh6Acpml0lYpmK9 A1UvJjAx2Uod5AuWvGO12lfAHWpUuVX/uRR06M82MDkdPSl8lkWMJey6J0JmeXE/Cy84 lWpQ== X-Forwarded-Encrypted: i=1; AKwUvBwP6+TlPpIm1pc5nyKcgvpsfWXxzvR1l4kvVlFyhIMT/xsoDN2xL8hNxOY61WpMvMB8t3vTytnhi4e7KsM=@vger.kernel.org X-Gm-Message-State: AFuF++nukVekzRXTyA3KgXKGc09HVdxCG/D7Ssi3WfirzjHVjMw1N6+X VIqfWkeV/EXeKOJUzq1Ibjg/YphrWikUHnwsD5pZ/wu9NAz6p10Z8IuW X-Gm-Gg: AYBFou262nzH8Cz8d6GDRCZnwQ9BWI7j9b2oGVUh1tW3RXYT+phvT1hbVn6BuyH62oi i+LGG4p/c6o9wy282nhxZw2qp0zXyeb3yThR5Jx+jlD6Co9GCgO2qL3QfSthJ1ahdaFmm2NaChR RWoOex/9+Zakln2NsZlBAVs/hQ1mln94fMjG+DsQE2SZX1I4Cvfe04PsfRJxHkmSumv92b2cakW 2u6hSq0c40iwVVZeNW82a0125eayGLSk82oJghLYPYSw6e7THPd5SWgLKg76f4oqR/UdvimLX9H K/rgNmEk7wP6sgigvk8IU8op1q4pfNabENW8j2gVEcX4wBgds+RVugLBqXH3mPxQh5zVPvev7SL 2JsYoJZngCLexGygXYjbOM2eQO9GdMBrstTSB/mnFI95GMye+/4k8faQhYt5vsgtuJ1nDzrsqWK enyBtuzN0+m2qMaZGz6jAREtEDjAUqtzpXm2itKKQEUmTXiAVH/+PUqOvQ9v8hknp/6TGyz4I6C wz+IsaztEvw8vR60w9q3oLRDEhf07OIrsMaFCrJqtx/9On0iHsdQfcvN4KeCgzn3lH8fbCqy52P RYr1sviHfyPfm0pfYZJU X-Received: by 2002:a17:903:3c4d:b0:2dd:88b4:6920 with SMTP id d9443c01a7336-2df609d2351mr6599915ad.22.1790069489351; Tue, 22 Sep 2026 02:31:29 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df63a22f54sm103915ad.61.2026.09.22.02.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:31:29 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: Hui Peng , David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v3 3/3] ieee802154: ca8210: validate data_ind length upfront in ca8210_skb_rx() Date: Tue, 22 Sep 2026 09:30:25 +0000 Message-ID: <20260922093126.141969-4-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <20260922093126.141969-1-benquike@gmail.com> References: <20260922093126.141969-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ca8210_skb_rx(), data_ind is read at offsets 22 (msdulen), 23 (mpdulinkquality), 29 + msdulen (hdr.sec.level), 30..39 + msdulen (security header), and 29 .. 29 + msdulen (payload) without verifying that the received SPI frame length len covers those offsets, causing an out-of-bounds read when msdulen exceeds len - 30: BUG: KASAN: slab-out-of-bounds in ca8210_skb_rx.constprop.0.isra.0+0x137/= 0x160 Read of size 64 at addr ffff888006453ddd by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x23/0x60 ca8210_skb_rx.constprop.0.isra.0+0x137/0x160 ca8210_net_rx+0x96/0xc0 ... The buggy address belongs to the object at ffff888006453dc0 which belongs to the cache kmalloc-32 of size 32 The buggy address is located 29 bytes inside of allocated 32-byte region [ffff888006453dc0, ffff888006453de0) Consolidate all length and msdulen validations into a single upfront check at the beginning of ca8210_skb_rx() before allocating the skb. Tested in QEMU with KASAN enabled by passing a short data_ind buffer with msdulen =3D 64 and len =3D 30 into ca8210_skb_rx(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 3/3. - Consolidated all length checks in ca8210_skb_rx() into a single place at the beginning of the function before dev_alloc_skb() and dropped the unrelated hdr.seq assignment as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index 8aa7ffe..ab245ad 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1758,19 +1758,15 @@ static int ca8210_skb_rx( u8 *data_ind ) { - struct ieee802154_hdr hdr; + struct ieee802154_hdr hdr =3D { }; int msdulen; int hlen; - u8 mpdulinkquality =3D data_ind[23]; + u8 mpdulinkquality; struct sk_buff *skb; struct ca8210_priv *priv =3D hw->priv; =20 - /* Allocate mtu size buffer for every rx packet */ - skb =3D dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); - if (!skb) - return -ENOMEM; - - skb_reserve(skb, sizeof(hdr)); + if (len < 30) + return -EMSGSIZE; =20 msdulen =3D data_ind[22]; /* msdu_length */ if (msdulen > IEEE802154_MTU) { @@ -1778,9 +1774,25 @@ static int ca8210_skb_rx( &priv->spi->dev, "received erroneously large msdu length!\n" ); - kfree_skb(skb); return -EMSGSIZE; } + + if (len < 30 + msdulen || + (!priv->promiscuous && data_ind[29 + msdulen] > 0 && + len < 29 + msdulen + sizeof(struct secspec))) { + dev_err(&priv->spi->dev, + "received truncated data indication!\n"); + return -EMSGSIZE; + } + + mpdulinkquality =3D data_ind[23]; + + /* Allocate mtu size buffer for every rx packet */ + skb =3D dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); + if (!skb) + return -ENOMEM; + + skb_reserve(skb, sizeof(hdr)); dev_dbg(&priv->spi->dev, "skb buffer length =3D %d\n", msdulen); =20 if (priv->promiscuous) --=20 2.49.0