From nobody Thu Sep 24 15:13:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F235D53F699; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790079633; cv=none; b=MDekBaIPqy7EcV7jWOY9q7xButd7Yj1P4tK+bROWc8gf/hni02Xi6DG0Uuh3CeTCiZqMH4C3wx/wLMIyaYkQEOv5iZd+MoG3LBgNFAau0tlcSQsN3jGdo3/A4s1qEBeIoD5jXJwHEGQiliZ2u9H8y+TbOu0lIS27bj6zCUO3v2I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790079633; c=relaxed/simple; bh=4O8ZQghr/b2vo2kcWDO8kn89KdXTM4f5o7tWhR1fOhs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pA8fIk+HyfWuQEIyAKLRPp2Iaf43rhU6PxSIIfTf506+tiynXphzcW8Mj6esgXP0NTFmDgH7MtwpeKUi4MQcy8G1zka5JfwHbCuZ3d7w7UqpDFDZ/d8MQAVL+GDMZdH89rjBjBXQdS4DsULv+U709EEtjmDM3RoFiYGwVdGv8ZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wn70OdqZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wn70OdqZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9EFA9C2BCFA; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790079632; bh=4O8ZQghr/b2vo2kcWDO8kn89KdXTM4f5o7tWhR1fOhs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Wn70OdqZwZ1wFYRIT+PxEVfgNktkLt0tPtc+7uQbvr2+WdF7BeMmyUwc/geALR26+ sL2LFP2pU7VxatZ3U8s+jl/mZFcTslcCYpIi2AEQFIyTRHeqbF0l0Qa7liB2ZjVHIe zUprqBQwZJF9QrnMunwLCiN/IATSfip+RO5rCKDVGuRUWRQSH+0wyyhfLHbN9HO/92 ohy7pm3PflafAjxO4n2ySpQPnhbT76H3WmzM+97ElPq+BNaQ3rsZvdSH2bUkbmdyPb dBXNV93yVnGZdUiLez7bsDFxxYm0JH+nqydxyejUZWpT+7pcSo3dDTf0nl5HJhPy+l eXFMnhbiGg1ww== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CAEC982FF; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) From: Jens Glathe via B4 Relay Date: Tue, 22 Sep 2026 14:20:19 +0200 Subject: [PATCH v4 1/3] usb: typec: mux: ps883x: support TYPEC_DP_STATE_F Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260922-ps883x-disable-usb4-v4-1-0a7b5b70cba3@oldschoolsolutions.biz> References: <20260922-ps883x-disable-usb4-v4-0-0a7b5b70cba3@oldschoolsolutions.biz> In-Reply-To: <20260922-ps883x-disable-usb4-v4-0-0a7b5b70cba3@oldschoolsolutions.biz> To: Heikki Krogerus , Greg Kroah-Hartman , Abel Vesa , Bjorn Andersson , Konrad Dybcio , Sebastian Reichel Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, "Dr. David Alan Gilbert" , Dmitry Baryshkov , Jens Glathe X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790079631; l=875; i=jens.glathe@oldschoolsolutions.biz; s=20240919; h=from:subject:message-id; bh=bPpIDIw9LIDQr0mVlf5HDy4Ak7MRxbqehghQmc4sQjc=; b=LYutUwrX2NhEe/07FRonVp2SR3z0wNds+7OPGUhDO9gCbp5nS8VTeUNYJt4pVMzHfseNlg5iV Db7WH4FZV3EDfYpjCdUuoqIVJ2UhV6XHPiXs+HhZ8+NoLyZdiiE3NfK X-Developer-Key: i=jens.glathe@oldschoolsolutions.biz; a=ed25519; pk=JcRJqJc/y8LsxOlPakALD3juGfOKmFBWtO+GfELMJVg= X-Endpoint-Received: by B4 Relay for jens.glathe@oldschoolsolutions.biz/20240919 with auth_id=216 X-Original-From: Jens Glathe Reply-To: jens.glathe@oldschoolsolutions.biz From: Jens Glathe Several docks, including the Lenovo 40B0 and SSK SC220, still send the legacy TYPEC_DP_STATE_F mode request (deprecated since DisplayPort Alt Mode spec version 1.0b). Group it with TYPEC_DP_STATE_D. Assisted-by: Grok(xAI):4.6 Signed-off-by: Jens Glathe Acked-by: Heikki Krogerus --- drivers/usb/typec/mux/ps883x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c index 64e0a61b776a1..a5696aef054ee 100644 --- a/drivers/usb/typec/mux/ps883x.c +++ b/drivers/usb/typec/mux/ps883x.c @@ -207,6 +207,7 @@ static int ps883x_set(struct ps883x_retimer *retimer, s= truct typec_retimer_state =20 switch (state->mode) { case TYPEC_DP_STATE_D: + case TYPEC_DP_STATE_F: cfg0 |=3D CONN_STATUS_0_USB_3_1_CONNECTED; fallthrough; case TYPEC_DP_STATE_C: --=20 2.53.0 From nobody Thu Sep 24 15:13:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F241A53FD2A; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790079633; cv=none; b=b0z1OHOrTGAUddAMBELbXBr6kIhiQQ/W25XHyz7c35drQnY9El5ANrDMmmiIANejGVEoMAjrc6/VK6mVwINByyqHZIPDfyiZYLUPnjRcEgPUGKTE658h0u9wXQQcnB61KJIaAnCfvV5r90vWav+fwPrEGcYXcqEqfujl0FFXq5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790079633; c=relaxed/simple; bh=JQb7VN7D52q9ySt+RSTPP0oOy5LMHg+rfhWRb2KNeoc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aIBOuXNEQxCcowv9cXkKWlxLC/s61L+6qVjAmDJ8/HOaP3WcyvWhFOiu4U04P9N8HyGCwPS+Ysgq1qHJ6os5CxD5OnB3RGrLTo97IaOXGJAEVMjrmG1iOed06q0shysycCwdA5k566rvNUqgXmvuznC2pSCmlVVKYWDChF02GGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Aok6KapY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Aok6KapY" Received: by smtp.kernel.org (Postfix) with ESMTPS id AC7BBC4AF09; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790079632; bh=JQb7VN7D52q9ySt+RSTPP0oOy5LMHg+rfhWRb2KNeoc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Aok6KapYP7ZIo5CvxUrGoimpnAZNq1UWgvyxR3C2qMGfIEQW/RMIqvfqGsH/BQuh1 NR1M4I99zVzy+zgWlrxGY8omgo0L4T2bFhDaa3ZyLMaKA9dIfKjv6uWM2Sknqoyvjj TaSxLj52onaSZ1z4XfXMlDqydHW6lDmBe+Ua+QeVaZfaDqDtf9Ks+dScTMKcSANiZ8 U3xw8qkQzm6qNeEQ68zOlEHCd7WMIwplPLnDtjiP9+RdM9/uPhT9imJdpJ2TCBS94m LyVYGfrVUnuIwq6bsM7f0D+9u96M34UCyIswmRZeSVkD7IpJzY4outiUMfyhxQuDGS cuNwj3hzL5/oQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858F9C982FA; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) From: Jens Glathe via B4 Relay Date: Tue, 22 Sep 2026 14:20:20 +0200 Subject: [PATCH v4 2/3] usb: typec: mux: ps883x: add a delay after writing config regs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260922-ps883x-disable-usb4-v4-2-0a7b5b70cba3@oldschoolsolutions.biz> References: <20260922-ps883x-disable-usb4-v4-0-0a7b5b70cba3@oldschoolsolutions.biz> In-Reply-To: <20260922-ps883x-disable-usb4-v4-0-0a7b5b70cba3@oldschoolsolutions.biz> To: Heikki Krogerus , Greg Kroah-Hartman , Abel Vesa , Bjorn Andersson , Konrad Dybcio , Sebastian Reichel Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, "Dr. David Alan Gilbert" , Dmitry Baryshkov , Jens Glathe X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790079631; l=1571; i=jens.glathe@oldschoolsolutions.biz; s=20240919; h=from:subject:message-id; bh=QjUP6gScoHtaAUdZ8JeHXSs4MMhjRv1uTt6ick8pHTM=; b=jogfcruiWItBP+TeH2BypY8axlXi4h2/BDb0m6pYFruVIa27HdoxE87PIGo4BCw+NSVLpM2L1 K2bYLBDqk3jD3W+TzhZBU5gpc25v7iZkqGKKrIOqq6hFfC4wNXPiR4x X-Developer-Key: i=jens.glathe@oldschoolsolutions.biz; a=ed25519; pk=JcRJqJc/y8LsxOlPakALD3juGfOKmFBWtO+GfELMJVg= X-Endpoint-Received: by B4 Relay for jens.glathe@oldschoolsolutions.biz/20240919 with auth_id=216 X-Original-From: Jens Glathe Reply-To: jens.glathe@oldschoolsolutions.biz From: Jens Glathe The connection-status registers need time to propagate through the analog front-end (PLLs, lane training) after they are written. A 30 ms delay after ps883x_configure() brings DisplayPort Alt Mode hotplug on the Lenovo 40B0 to a reliable success rate. Tested with T14s G6 and IdeaCentre Mini with the 40B0 dock on the HDMI port with a Type-C host cable. Qualcomm firmware that programs this retimer from an MCU uses a similar post-config delay. Assisted-by: Grok(xAI):4.6 Signed-off-by: Jens Glathe Acked-by: Heikki Krogerus --- drivers/usb/typec/mux/ps883x.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c index a5696aef054ee..15aee1d613b1a 100644 --- a/drivers/usb/typec/mux/ps883x.c +++ b/drivers/usb/typec/mux/ps883x.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -184,6 +185,15 @@ static int ps883x_configure(struct ps883x_retimer *ret= imer, int cfg0, return ret; } =20 + /* + * The retimer needs time after the connection-status registers are + * written for the analog front-end (PLLs, lane training) to settle. + * Without this, DisplayPort Alt Mode hotplug is unreliable on some + * docks (e.g. Lenovo 40B0). Qualcomm firmware on platforms that + * program this chip from an MCU uses a similar post-config delay. + */ + fsleep(30000); + return 0; } =20 --=20 2.53.0 From nobody Thu Sep 24 15:13:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21AE53ED0A; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790079633; cv=none; b=g+3RDk0olHTPq1ZVFX60ap4eh30KSuIFayPLJJRLeLmeBZV+uSY0Ri12Suh9etDEUjnviUMQjVTngA3pou1cIPlsn4KzITye+Lexsz9RjTcxFEbaV43glmyfW8P6hWbNZUi1LxfmvfVVIqGhVJQDwuFH5XsSUlq8YwxsDYtLkOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790079633; c=relaxed/simple; bh=OjSrRvdB6Sb28ACBgMcMc/tOR88zWDlxdM5cKCVe3Wo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nZdzjouyjI5TY5AhNGipR9M3we3Aa4wTE6BTiCk/oJdYqETz+t/5CQseXPRLgkd4ctwSIuOwigY2OqfgXGLCUIWD9DeOrmFZGA03iHcaYM81IwtStrwHTCazzGLOgWSjrAhYZsvnEmNIzb4M/2sBSh67z9dNm4Nt7TxVCLvmfE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iNi5+m+K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iNi5+m+K" Received: by smtp.kernel.org (Postfix) with ESMTPS id B48D0C2BCFD; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790079632; bh=OjSrRvdB6Sb28ACBgMcMc/tOR88zWDlxdM5cKCVe3Wo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=iNi5+m+KHfs04mCgFbBRAxiHkA9Biu0wG8BAxWuc2qqZr9lmcLW1MH/E+Mx/jWmuB TVj7+3XMxVeszdb3GLyvZZC5hCCnFdJvYEwDuFCRkS/r2HSACczaJBc/0PS7bzpBXN U72oPAyb2nsJKVsh/WXp/cv25PmoJDzm+SXsfsCa0+3RVVk4KRFy7UiE3RcCBNrE3c S/DcPPQhMlLCIqLhZXWr7fCHs8mdNQYZEZ5Iloi4tgflgyJyAYi+ftqjnbbo6dng6q wC5VQcAV6vGghQAHpFhUj42kjhxrrRnj3uv3HZ2HQ2TYpqddA0S65adGl23X/gNs5s UDP+oCL3Pae1g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973F2C98306; Tue, 22 Sep 2026 12:20:32 +0000 (UTC) From: Jens Glathe via B4 Relay Date: Tue, 22 Sep 2026 14:20:21 +0200 Subject: [PATCH v4 3/3] usb: typec: mux: ps883x: disable USB4 on incomplete USB4 platforms Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260922-ps883x-disable-usb4-v4-3-0a7b5b70cba3@oldschoolsolutions.biz> References: <20260922-ps883x-disable-usb4-v4-0-0a7b5b70cba3@oldschoolsolutions.biz> In-Reply-To: <20260922-ps883x-disable-usb4-v4-0-0a7b5b70cba3@oldschoolsolutions.biz> To: Heikki Krogerus , Greg Kroah-Hartman , Abel Vesa , Bjorn Andersson , Konrad Dybcio , Sebastian Reichel Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, "Dr. David Alan Gilbert" , Dmitry Baryshkov , Jens Glathe X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790079631; l=3472; i=jens.glathe@oldschoolsolutions.biz; s=20240919; h=from:subject:message-id; bh=1iyfmiUDL9sgFDlX61zRTpyxAquXyuctxtavKjTdzIc=; b=J0IUqClEUZPz1wWom/lQCMTO4v8fyoIfQF/bbD/d9SuXRG/vyp8zSbreuHbgUP3MVqnOqEMvJ x3waPJ0VHuuCK2otyRIwSyjXtCTf42dUM6dCdz72OG7HzVNCfIFrHjy X-Developer-Key: i=jens.glathe@oldschoolsolutions.biz; a=ed25519; pk=JcRJqJc/y8LsxOlPakALD3juGfOKmFBWtO+GfELMJVg= X-Endpoint-Received: by B4 Relay for jens.glathe@oldschoolsolutions.biz/20240919 with auth_id=216 X-Original-From: Jens Glathe Reply-To: jens.glathe@oldschoolsolutions.biz From: Jens Glathe On Qualcomm X1E80100 / X1P42100 platforms using the Parade PS883x retimer, hotplugging USB4-capable docks such as the Lenovo 40B0 can result in working USB but no DisplayPort output. When the dock negotiates USB4, the retimer receives TYPEC_MODE_USB4 and forwards it via typec_mux_set(). The qmp-combo PHY then selects USB3-only because no classic DP altmode SVID is present in the state, leaving the DP transmitter and AUX channel disabled. Reject USB4 with -EOPNOTSUPP on platforms whose USB4 / DP-tunneling stack is not ready yet. The Type-C stack then falls back to USB3 + DP Alt Mode. DP altmode configuration continues to use the existing ps883x_set() path. Use a machine-compatible table rather than a DT property so the quirk stays inside the kernel and can be removed later without creating ABI. Assisted-by: Grok(xAI):4.6 Tested-by: Dr. David Alan Gilbert Signed-off-by: Jens Glathe Acked-by: Heikki Krogerus --- drivers/usb/typec/mux/ps883x.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c index 15aee1d613b1a..2ec57cfe748a9 100644 --- a/drivers/usb/typec/mux/ps883x.c +++ b/drivers/usb/typec/mux/ps883x.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -42,6 +43,22 @@ #define CONN_STATUS_2_TBT_UNIDIR_LSRX_ACT_LT BIT(4) #define CONN_STATUS_2_USB4_CONNECTED BIT(7) =20 +/* + * Platforms where the USB4 / DP-tunneling stack is not ready yet. Rejecti= ng + * USB4 here lets the Type-C stack fall back to USB3 + DP Alt Mode instead= of + * negotiating USB4 and then failing to drive DisplayPort. + * + * This is a temporary, kernel-contained quirk (not DT ABI). Drop the entr= ies + * once the corresponding USB4 support is complete. + */ +static const char * const ps883x_disable_usb4_compats[] =3D { + "qcom,x1e80100", + "qcom,x1p42100", + "qcom,hamoa", + "qcom,purwa", + NULL, +}; + struct ps883x_retimer { struct i2c_client *client; struct gpio_desc *reset_gpio; @@ -63,8 +80,21 @@ struct ps883x_retimer { =20 enum typec_orientation orientation; bool in_reset; + bool disable_usb4; }; =20 +static bool ps883x_should_disable_usb4(void) +{ + const char * const *compat; + + for (compat =3D ps883x_disable_usb4_compats; *compat; compat++) { + if (of_machine_is_compatible(*compat)) + return true; + } + + return false; +} + static int ps883x_enable_vregs(struct ps883x_retimer *retimer) { struct device *dev =3D &retimer->client->dev; @@ -260,6 +290,9 @@ static int ps883x_set(struct ps883x_retimer *retimer, s= truct typec_retimer_state cfg0 |=3D CONN_STATUS_0_USB_3_1_CONNECTED; break; case TYPEC_MODE_USB4: + if (retimer->disable_usb4) + return -EOPNOTSUPP; + eudo_data =3D state->data; =20 cfg2 |=3D CONN_STATUS_2_USB4_CONNECTED; @@ -389,6 +422,10 @@ static int ps883x_retimer_probe(struct i2c_client *cli= ent) =20 retimer->client =3D client; =20 + retimer->disable_usb4 =3D ps883x_should_disable_usb4(); + if (retimer->disable_usb4) + dev_info(dev, "USB4 disabled until platform USB4 support is complete\n"); + mutex_init(&retimer->lock); =20 retimer->regmap =3D devm_regmap_init_i2c(client, &ps883x_retimer_regmap); --=20 2.53.0