From nobody Thu Sep 24 16:07:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE014189BA; Tue, 22 Sep 2026 09:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790068115; cv=none; b=Ua1P+yz0iEC2EzF72ZlAzRM16SH6nRb4bmhof7IeofHg+8DF++xa8Tgy6sdqteLRT2fmpZEM41VLCu5AUemzwvvpUI9Fh1sW3lo7ENJjk0v6cDFhhlmkfASh38BrPiDMsUKA2nGHOzx9P+QmBLHXAEcO2ZYFxoLpNvFNmlhnfKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790068115; c=relaxed/simple; bh=aWEqlZnVkFRgp0qQKu7X23kGg0ZHVehrYng8L//OeY0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mA3XSBbtkzAIkfzS7/TibvxeEsK93whXPR5qpqj6xD7PlahDHjvrF6uNOpZ8kuTkxtThavJrSWKerpNAld2zkIgUGRgMhk5UJ4QYbpifvJk2SmjUUMp6lGcHAzfCrvvstMICAvBgRbk0VmiqVDt8n7jlnsdQIbLUA2QlusW314Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cwyC67CJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cwyC67CJ" Received: by smtp.kernel.org (Postfix) with ESMTPS id C8E61C2BCB8; Tue, 22 Sep 2026 09:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790068114; bh=aWEqlZnVkFRgp0qQKu7X23kGg0ZHVehrYng8L//OeY0=; h=From:Date:Subject:To:Cc:From; b=cwyC67CJTTnwPjKJ8FlgqgfhQDe55lCyCaslHwZ3X993TMNn3NocalVYthl8VVuW7 ZfwrnlMAxCq16OHPmZ4FtZs+YKLJZaVA7BZqI0VvwQtLQJRZ33wfmyaCll0EczpW1v 91d8raG6rRq07cOfbzycDBE+AxHHyvnPhr74o8Hwj8IJtiEbyobgUKuPVMqufQXZN7 UvgTwSXn+qb2X20UsRxTlJIXl8Y9ci/rDHIbqsc7jdlvVB7TyrF5XeS2V1b8Cd2QBY mO+e8LJfu+AY1QJ8RWPqwnr/QUiov15WSvpojqK8rtIVcreK6cboqkfE3MqnUADQl+ 943P103SfCoXg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BB1C982FA; Tue, 22 Sep 2026 09:08:34 +0000 (UTC) From: Joel Granados Date: Tue, 22 Sep 2026 11:08:13 +0200 Subject: [PATCH] ipvs: skip committing sync_threshold when proc_dointvec fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260922-lklm-sysctl-retval-fix-v1-1-7290ea4253a4@kernel.org> X-B4-Tracking: v=1; b=H4sIAHxFsmoC/x2M2wpAQBBAf0XzbIpRxK/Iw9odTNalHYnk320ez 6lzHlAOwgpN8kDgU1S2NUKeJmAns46M4iIDZVRmNRH62S+ot9rDY+DjNB4HudD0xlHtbFH1DmK 8B476H7fd+350fIRlaAAAAA== X-Change-ID: 20260922-lklm-sysctl-retval-fix-abad29dc37bd To: Simon Horman , Julian Anastasov , Pablo Neira Ayuso , Florian Westphal , Phil Sutter , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Joel Granados X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1296; i=joel.granados@kernel.org; h=from:subject:message-id; bh=aWEqlZnVkFRgp0qQKu7X23kGg0ZHVehrYng8L//OeY0=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGqyRZGUA0KCGTVtlF++nMgUcIdQrRiZq3RUU /YgHZ0t3bnNBokBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJqskWRAAoJELqXzVK3 lkFPDmYMAJI5M0li0IFDoGjBI7dEFL6+2/SLWT6ezLqZGKpiiRPP3nCorSqTS0ybmW666HQuCL5 dl+yPbeZ7QhF6ret88F/aAbXd0D24GHNSsgns1igp2JdZSpfgJWVFwYXed3twvuH8C7ZOlkpwTY q1MDtTpBcHHo3iasIgrhs3ve760S3aEWRFx0m5t1X1HsiBqF0OPl/4E4A/0D/lKXV3Xll3mhnSA zH+0b2/bmW/N68hXf1BeUgxPRQzrejpqiGy+VTMxfT/XF0fvpktRdIaDPyOeFVRvIfLX+gkPl8b qjWI21hUbFwmQUmDe+gJ1A743mX4qpKw+PuIcR9xo/hk0P3pN05i4WcBUhtfinx7cYQTmjRwZrh 9//gOU3degccRS6r4Ot/Qqyb3+EX0RtqReRilJAdaB5Kvx46ukpCnBvX8vuYHKfDoc2wXLjiOQg S/GVKugi5BLDPXCSqC1jArJQzeBwgwu7Z11zRLwTe70gaQiOU+S7nkCHMrYk9fTuS93/sayKDF5 do= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Forward rc value and skip updating sysctl_sync_threshold when proc_dointvec fails. This targets a write such as "5 x" which would fail with -EINVAL but would store the first element anyway. Signed-off-by: Joel Granados Acked-by: Julian Anastasov --- net/netfilter/ipvs/ip_vs_ctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index 4c1c739446b76ea455dab2958a844d05e31a46a7..7c260529238cd2015f1d30abd09= 4d25b056b30fa 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c @@ -2454,6 +2454,8 @@ proc_do_sync_threshold(const struct ctl_table *table,= int write, mutex_lock(&ipvs->sync_mutex); memcpy(val, valp, sizeof(val)); rc =3D proc_dointvec(&tmp, write, buffer, lenp, ppos); + if (rc) + goto out; if (write) { if (val[0] < 0 || val[1] < 0 || (val[0] >=3D val[1] && val[1])) @@ -2461,6 +2463,7 @@ proc_do_sync_threshold(const struct ctl_table *table,= int write, else memcpy(valp, val, sizeof(val)); } +out: mutex_unlock(&ipvs->sync_mutex); return rc; } --- base-commit: 93f51579e7df248780214094418f205253383cc5 change-id: 20260922-lklm-sysctl-retval-fix-abad29dc37bd Best regards, --=20 Joel Granados