From nobody Thu Sep 24 14:26:05 2026 Received: from mail-oi2-f43.google.com (mail-oi2-f43.google.com [74.125.231.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486E64A92E5 for ; Tue, 22 Sep 2026 19:53:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790106823; cv=none; b=UuTpS6VeD6LB8dJE9834YCnqe33mu/GostUr2EBuB4B9P4HRVu7wZCoH+kjXdRRdo64SpOw0o/I/jN78bFAv60h7EmPhXhVkVafEqk9XD7sSgKxobRgO3hRaCA+9/j8YoxEKmybuMsrycPnB6RVTB1Rh+X72yfoiIaX6aqg+HWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790106823; c=relaxed/simple; bh=rVQcvu2nQ9hhpSlEWzP2hEyq51SDjt+QGpBeBBaBtz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Nf4nLKWOKhgGGfmE3pd7p4SLuT9swDYUs7M+PMgdFO7C5c7kBop93oIJIqJiq99FVWbxSIW1vTEVsosJFnNDVpvi0GTievuYpVq+nrJyyKFj5aLQ1IH/xug8T2kS3Df7/66SA5vFty9gLhKfM4zgmaSHKpjr3MlI4oXrjGrO+0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A7dIBAnB; arc=none smtp.client-ip=74.125.231.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A7dIBAnB" Received: by mail-oi2-f43.google.com with SMTP id 46e09a7af769-8137b129131so251402a34.2 for ; Tue, 22 Sep 2026 12:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790106820; x=1790711620; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=30kr5BweW/mill+9FpYAClX2qkZFuhc6bMu71N8WrHI=; b=A7dIBAnBpdbzaWlZKqZ1VhkmnbdUsGHhZOp2KG7NKtD50ueAoCKaG2HC2YjQr4HEPz t7B4kfv5PeX/ec9jZLRrqJ5WAKpjFvuh2s5416BvlatY4ucLgaBJM44NS3Unajox2jeI of65jOoBsacQPnS1IEvSJGP9q+Dxl38nf6BsdIe/k3C/p9XX1xRQc5/PeKztKDVGFLPy pK31A+A1Wj/UUXOfntxDrvWANVK0vrELOxCnJXymZg8MckOgEEdbQEaUg/RaEMv0s39X 3pBVPxGhzi+fPfi18lBD/6sY5sp9XLcyWRrCC3TLtCjIInhmri5qjjJbuwe14zVa7Mdm pvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790106820; x=1790711620; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=30kr5BweW/mill+9FpYAClX2qkZFuhc6bMu71N8WrHI=; b=mSg5HzbET7awQL4r0q4xIxwziu+xXYTF7HeXmZWMFJATNmwv29XEQQQN4R3EKOJ/fO +ZnZVxMvVdR8V2AyDT9uiVHMub5bFOAMuwKcWDuu3h35IjAyhgV5oCLshQimEWUX6/h7 U3Riw71DcfmlOEZCYuqa58PIWkzUs/ILzb5f3gplbXpe+61BWR0+H9pv+5kfAq4J/yz2 DScVI5qn67txqO8LM5EPpnKDYDaMXhLXfLJWDep6NGxQL+5nFjWwevnUSRe4eJT5B4R6 w787gSQnmNkS+TnbkRvJtQ/Unzy86vx+kN/86EeOJKpar8fFkoXSPV7M0oHBAyaHqPTb pNHA== X-Forwarded-Encrypted: i=1; AKwUvBxzijZ/5tG3RH1go2FftcOBjVzAEH69Yd4av++MgKJK7iiV8Uus1ZMPFB+RSc16KWnojBAitAB9cmjiWE0=@vger.kernel.org X-Gm-Message-State: AFuF++k2u2WGSHjbJsB+i540cr1Eeq+JXzaSYwytKN9RreM5eang0Xn+ iaA2TV5C73cu62dmcEmY6oJTxUyqHNHFz0tATjfYNjok6Xc9sD3kXNM+v/wC8w9R X-Gm-Gg: AYBFou3bvq4yIiEWD+ZqjL3fQKDQhKNTVNQUolffAQX+7E0JlPC+Sun75XeU/sRgL0e fbMOutQAtdEvamSFUdKsskmHRanVs1v0DJR6sURN0AWJCtWRoZi1kJ2c7IRSK7Ry41JURwicNE9 bvEBAVP/d++H8oM93Gp3g2CZHBNBv28p4ccRNi3H0QXQ3UPMV1JMUcV7D/Yq25vB5CjKB788TAf BmjXmU0f3+4qkujqXGybd4GQJPsQX5jZRj+NB77PyJoRLuCZqHcb7VYhJlTIbf+naPwyyAuUQbr V4WUqpnytGH2LWGOAFWr19OhsFG9wn6i3mgoi+gRw4tMlY/41kEdnaQGNOxF9URtHuYqFg22nVe LgwXOMzd16LdL7TE5RUjZmqi/rHoFUjtgJcpY5bgiiGVbeY1TMrGvL81RznZvvgIP2+DIbAE8cy egUe7Ic8yu65KY4s/OJ6hE25xYd/3lJExaklKrSyJmlsW4UVMiEa7HwGhjnL0zTlLATOrg X-Received: by 2002:a05:6820:810c:b0:6b7:46e9:96fb with SMTP id 006d021491bc7-6d2d25210c4mr422952eaf.43.1790106820016; Tue, 22 Sep 2026 12:53:40 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:73::]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6d2dacc5db9sm426923eaf.2.2026.09.22.12.53.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 12:53:39 -0700 (PDT) From: Daniel Zahka Date: Tue, 22 Sep 2026 12:53:28 -0700 Subject: [PATCH net-next] eth: fbnic: put back netmem reference xdp_buff_add_frag() fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260922-fbnic-refcount-fix-v1-1-31e5862c9893@gmail.com> X-B4-Tracking: v=1; b=H4sIALfcsmoC/x2MywqAIBAAfyX23EIZPX8lOqittZct1EKI/j3pO AwzDwTyTAGm4gFPNwc+JENdFmB3LRshr5lBVaqrRqXQGWGLnpw9LonoOKHuB9PontqmM5DDM1t O/3QGoYhCKcLyvh95Vav4bgAAAA== To: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org X-Mailer: b4 0.13.0 fbnic_add_rx_frag() takes a page_pool reference out of the buffer's pagecnt_bias before handing the fragment to xdp_buff_add_frag(). If that call fails it has not taken ownership of the netmem: the fragment is not recorded in the shared info, and fbnic_put_pkt_buff() will not put the reference back. Put the netmem reference back on the failure path. Signed-off-by: Daniel Zahka --- This error path was introduced in commit 61f9a066c309 ("eth: fbnic: Use shinfo to track frags state on Rx"). This is not a fix though, because the branch is unreachable if the device is behaving correctly. --- drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/eth= ernet/meta/fbnic/fbnic_txrx.c index 447ec5522499..bbc3c9e89a38 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c @@ -1045,6 +1045,7 @@ static void fbnic_add_rx_frag(struct fbnic_napi_vecto= r *nv, u64 rcd, pkt->add_frag_failed =3D true; netdev_err_once(nv->napi.dev, "Failed to add fragment to xdp_buff\n"); + page_pool_put_full_netmem(qt->sub1.page_pool, netmem, true); } } =20 --- base-commit: 6598456d72e48d779445bfec8f72114747f8b8d7 change-id: 20260922-fbnic-refcount-fix-a78b3a7e536b Best regards, --=20 Daniel Zahka