From nobody Thu Sep 24 18:41:54 2026 Received: from mail-qk2-f13.google.com (mail-qk2-f13.google.com [74.125.230.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D89373CA4BC for ; Mon, 21 Sep 2026 23:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032139; cv=none; b=ZmtTJGPCPPT+s2/YnfgZ18DGLopyxZfdurkVKfqX+cOmu26i8loj+a3IzJPcZs5K5pem52RZpV7LrGcx9LchKXQOk5QZgjyHoq+riKEdCHqDoL0ysS714s8oIWEYtplZ6hU0RQYHX5epSU1WSedZMXPbtau9guMRg888TXyO4iQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032139; c=relaxed/simple; bh=1gnA8TGe9af5RJ6waDfAsYApcBrdbInaq4eInVQa1YI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PEHO8uSNwv4yK2pdd9r75U5LbvEJzqlIjJHXqnfJXgq9u6VsEp/nmQh43l1gbkl9UJgYN/H3SsPFoPYRFxa+WV9Pbcz7BO9nlhA+VQ57ppmCXUfMwF/3fl2u5C456Une4GSwAllC0cUOfmZQ7vCR8xeYt8TE1/SOPbPgRGeBnQs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bxemTQS+; arc=none smtp.client-ip=74.125.230.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bxemTQS+" Received: by mail-qk2-f13.google.com with SMTP id af79cd13be357-93910cadeb7so357703085a.0 for ; Mon, 21 Sep 2026 16:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790032137; x=1790636937; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uil38kKcJdnxLESM2C/w42Vib+0WwToXVLrxxQmRKFM=; b=bxemTQS+2DFclC5/fsx+gHH1PG43tVu5KjOWk5bfXVu0elQhvWAV6v4FyLkUvnEnW4 CiO016aTfsnenevBHUcYPc+WCSq8UJfwVpnd6ZwQEoRFzG5d86zvAf42aaHUSyTrsvP5 3rssbewrN/HGWWyY/BuuKjZSk+w3jKL1z8ZlIaMt5yJcIrCDEJ3PABi58GSv0Cxt1AaR 6hEJvauXXzGjcILnvNIt3Q8fAFFBBRevjnp7d4tKZMc91iOwx2D5ADl3Z8IV53GlE/CD gaVbWpu4FWXTQVVA0gpu5DdzSccolI4L3uJYbfGk15joVe7oIQKGOPK4MNbhm4Cu3+9j dhLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032137; x=1790636937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Uil38kKcJdnxLESM2C/w42Vib+0WwToXVLrxxQmRKFM=; b=hOCdsKKsqmUY/fhf2+eh3yuVpO5wF10oBUh6znckj1AJPynvepSQob5wLWRFAI5W0w PxfdoTZLYuF7e/KIsGzl74GFh7H4DS2f17H9RLYzta7Y9LXPjCUuK5m//ocYUnmBZ6ST n8NXWKMMQZ6t3C2o0CUqcv5JvN+sNsBnyGFH/hogrHf/UUiVyguZI4rkPjlJebiV2WwD yILmM1nQMI1j9fc5LaylloPNQYSADLZPC9ATctQ8p3JmaKdbWCFAYd59k6dyLdCytEya hkqBiKzZTq9env174uNescknMSyU36L0UkJxoXuvMQppy8pOMvrNxF60VJSHMs/z2enM Wxhg== X-Forwarded-Encrypted: i=1; AKwUvBxb6yXlWbVDUhvwbqYTztUoSnyf7HTd5RNSSVJ4zewvzkU+OTC5qZ8zkq9Sr2YJNb34OY0YWCa7rXJ3qZ0=@vger.kernel.org X-Gm-Message-State: AFuF++kLJQTl5mEpTSwQEfc5MJA31dhhyrtajx/ogbUfVH8CpJyej6uE l7XJqPDT8Plx8yKz6moFj/fnjYxMjPdYvxlD3LkKYVgiGaaaWUZ+pGc= X-Gm-Gg: AYBFou3Rrd6qEISR0EMXlbW7TmHWFfQe7j64A5g4oAI+K5B8yOZVjPVr9mUKoRpdL/7 181CtxAHSZWwr4auhJdS7ShyoB79qtRDgviD6RA8fkkcz6EnmAwwt/Tltvw0tHeRVJAGetgxOSL DvHJPZlGP3XjrrYairRC5aiC9HF5BC77MVdXhXCC3QnbE3UNbhblWAT8dSD1qElnGMbs49ps+7H qC0O9txQdaGPfpNYlG1VXDe9BHHoAYqltwRLkCIv/0ys6Zhou6sRVVMqW1QGhK3B92kp/0fbEpk dUPnZ2rRUQrhKhx8EBiNmJ4MNKQorfY3NUwQ6era92JBVAwJe1AizWCXz+3W37xkp+DyEULNduv 7UtqWjsugAA1zWN3lVRfG4Ui4D2qS0px0luEhrCm8LMf2awEP4pcnsFSRF3uMlX+RwCtE+RNWir JGGkPGZBeri6GLdHj9dnomkYrUif5DyPE0V9pQ7YpoKwd6bMPnMm9MBw/egUHEg9K+BmtYNEMMF yt4Rwujqao9o1HZbVoAixDA6DhKEBkERBUU94nMRfgYUjTArHjsRA6CgJ53YBAbwbHlwMWMhZbn PjyfO4fO8tMsLx1agR3qj/Rbz9iq X-Received: by 2002:a05:620a:404f:b0:93b:e412:8cee with SMTP id af79cd13be357-93c15eea61cmr284237385a.73.1790032136724; Mon, 21 Sep 2026 16:08:56 -0700 (PDT) Received: from i4-gl-tmk5904-1.ad.psu.edu ([130.203.156.90]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93c19a7f592sm39933985a.17.2026.09.21.16.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 16:08:55 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Ijae Kim , stable@vger.kernel.org Subject: [PATCH v2 1/2] usb: gadget: tegra-xudc: Unregister VBUS notifier Date: Mon, 21 Sep 2026 19:08:47 -0400 Message-ID: <20260921230849.502492-2-mhun512@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260921230849.502492-1-mhun512@gmail.com> References: <20260921230849.502492-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" tegra_xudc_vbus_notify() queues usb_role_sw_work. The notifier is registered with usb_register_notifier(), while devm_usb_get_phy_by_node() is passed NULL, so devres never unregisters it. vbus_nb lives in the devm allocation, so a later PHY event calls it after xudc is freed. Unregister the notifier before cancel_work_sync(). That waits for in-flight callbacks, and the existing cancel drains the last work. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 2582d629c9e0 ("usb: gadget: xudc: Refactor update data role work") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Unregister the VBUS notifier before cancel_work_sync(). It queues usb_role_sw_work and is not devres-managed. drivers/usb/gadget/udc/tegra-xudc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/t= egra-xudc.c index e9d33be02866..a0585a1f19f0 100644 --- a/drivers/usb/gadget/udc/tegra-xudc.c +++ b/drivers/usb/gadget/udc/tegra-xudc.c @@ -3926,6 +3926,12 @@ static void tegra_xudc_remove(struct platform_device= *pdev) =20 pm_runtime_get_sync(xudc->dev); =20 + for (i =3D 0; i < xudc->soc->num_phys; i++) { + if (xudc->usbphy[i]) + usb_unregister_notifier(xudc->usbphy[i], + &xudc->vbus_nb); + } + cancel_delayed_work_sync(&xudc->plc_reset_work); cancel_work_sync(&xudc->usb_role_sw_work); =20 --=20 2.53.0 From nobody Thu Sep 24 18:41:54 2026 Received: from mail-qk2-f13.google.com (mail-qk2-f13.google.com [74.125.230.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4F342A176 for ; Mon, 21 Sep 2026 23:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032140; cv=none; b=UI/ApVlaUqptpr05QIWc1LLkmrOqQAxxRhIWAbasfc+QOQMBnw1ZvqAGfb9AeACPtOqDw/lmzZyuz6nr/fn11aqpDLtzLcWZvs180tvhotEvjQSvXvwGkiQ4IjnwiYHwCDVE4ouQ7rsXAXIvBKYEkp3FzcywAQx9PFthYuis/s0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032140; c=relaxed/simple; bh=kAvYqeh9lhIbm8YtKATUVDPt4SSV0dL/01lCzjcwo3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rUGevKPkAV4VSUwUkZDmXNyEqWQWTlYjjJDZ8Cv+zUXizXhhE3BIf96kYAmiqu8U515eg3KrjlsGqrI4GgZLPq+/ObtZrFr4FoQBtxtHHHS4OfG1VkX+2BPQ6czgWbHY6gQP+EuffKf/MGRZ7uzeLL2ePkyfbOF3eSCR2dp+l9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QyZUYmCF; arc=none smtp.client-ip=74.125.230.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QyZUYmCF" Received: by mail-qk2-f13.google.com with SMTP id af79cd13be357-93910ca5aa7so318936385a.1 for ; Mon, 21 Sep 2026 16:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790032138; x=1790636938; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=81aKjimYrYOGXnfGd1vfh7o17MNAV+GZaQTkl+KjGW8=; b=QyZUYmCFqcGdPDyj4LBCoxHGM3l8H92abHSqBj5QZZpXopqZSyK2Q5bFOaguO9b/IO amUpJJWphzwIfhp3awJ0SEoCjqA2VbDlYzYpgOKHbPlesrGdT0qY/Jz84vj6s17+ua89 1pvcqTcZo8KcPzZlN9W8Lll3MUCQd9md+Clz6fqwOISzSx+mRNW0oXxexnynFvql6sC2 qzFI9M5TvlTf/k5I7pxJDKtj8xhEGw2i9ZuWQ0J2ou2tF06iXVDSsYTYvc+n+ZXCt/+F qVmrGJY8P+2Mk/JUgyJ7MOSeF0tn7BiBDUJCXiMgq2YE1awp3nDuFx5EDA2643Rb1U9w lR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032138; x=1790636938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=81aKjimYrYOGXnfGd1vfh7o17MNAV+GZaQTkl+KjGW8=; b=YQ6FcA7ncyEjYxVaNCv+GkD/wOGL4k/opUwGOghKEfAv/OzAVsvn3LMhAAHTnfrRMC mj89i+6OOzVXnZJfeWlPu+SQ8G5ZticB+5ilmxbQ6Cf5yuPpzImKZw8DbHxudT258r3h vqX2z7ve1p78NNSlnqDebaSMTARtZqg7k9oV52+eLkxD/AMvIxhK1CHm1aKCyzzZGxX8 bFWfnDgf+lGXiwQKtFRk6lfTIc1+e0GnrfOFkuOGHhRU0Fg5f3ZW1xloEs2oaRI6MZ5J gy4/RIS+QgFZ/oDLpG9FLqO7r75UOLjXh4XRs9P6w+5TWirlVcwuwcjKmHjhyJiJKiTc TVdw== X-Forwarded-Encrypted: i=1; AKwUvBzcLUGPADieJ732QP/gT+qV4SXNmpGO+ZJpHKR0iLjeHpcYkylhuttO4Xa5OnRUD+ant2Lblo1mP/G9wnM=@vger.kernel.org X-Gm-Message-State: AFuF++kmEB7+YwqqEnpiVIxwXuXKolrrVznmEQD/w0ojfgohCGZPn/kW sq/2JZw81kH9pCkjAt3sXFN5x9jFLflOJ53Hd56db9LlUTlrKogL/6Y= X-Gm-Gg: AYBFou1kHqZTjC8GSHJwSkmM2LBVhnl8zN0YNR8QjFErYuuUOBDQUrjvHQSJ6f3I6ui eBwZ3tULCcOD+dDifpTgSxwGKpNvf0U+QX//SFOlh2SixT4VxRfjbM/gq0YLaWxnknOiVigrivi oxRMC4xmm1AwATXYmvyKYOO3gbp6TvVVj7kMJ7AYbXTwoaRvcsg9/shbn5zk47VShPcIeynjWx4 +BFXIX+oAXdjMZLnEKMR9p4nT4tCX0RbiI6vCrwQLkk6StP/+3t4VjXwnFpuNMCJilEpdKhdvyq Dly3t9LLD45XdbYfNA7rEv/4biW024yBKYagEyvN18C2EMJdpUQIKWpYfspZSJokBIw4zkl3IgP nQZwzLf7nl9fKrYjZ+uoEByoprR9/tNJquuoSOTZsTWo2vJg7lolCNwAmuUx5x/zPUnXSW/Sfx6 rcYHRvoypYE5hFTQYmqRoGEwoZGoed+2OYw0xlUB21y/SBk4rHF9qe07KWG6gCf5NXuOCJq2BIa JakUwYEnsxa/vRvfGkmGuVf6jIejRCv7v9j0TGakEGu7mDSprci/ucj6IY9+Gh/2d2NZQaYKlOq n1VXX1QuqKxMfIcodUQ15rCVxTRZ X-Received: by 2002:a05:620a:6f0c:b0:939:feaa:949c with SMTP id af79cd13be357-93c15eed484mr268135185a.36.1790032137800; Mon, 21 Sep 2026 16:08:57 -0700 (PDT) Received: from i4-gl-tmk5904-1.ad.psu.edu ([130.203.156.90]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93c19a7f592sm39933985a.17.2026.09.21.16.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 16:08:57 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Ijae Kim , stable@vger.kernel.org Subject: [PATCH v2 2/2] usb: gadget: tegra-xudc: Disable reset delayed works Date: Mon, 21 Sep 2026 19:08:48 -0400 Message-ID: <20260921230849.502492-3-mhun512@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260921230849.502492-1-mhun512@gmail.com> References: <20260921230849.502492-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm port-status IRQ stays registered through remove() and can queue port_reset_war_work and plc_reset_work after cancel_delayed_work_sync() returns. remove() never stops the first. disable_delayed_work_sync() drains both and rejects a later queue. usb_role_sw_work stays on cancel_work_sync(). The PHY notifier is its producer and is unregistered before this cancel. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 49db427232fe ("usb: gadget: Add UDC driver for tegra XUSB device mod= e controller") Cc: stable@vger.kernel.org # 6.10+ Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Keep the Fixes tag on one line. (Thierry Reding) - Disable plc_reset_work too. The port-status IRQ can requeue it. (Thierry Reding) drivers/usb/gadget/udc/tegra-xudc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/t= egra-xudc.c index a0585a1f19f0..dd0a033b4a7f 100644 --- a/drivers/usb/gadget/udc/tegra-xudc.c +++ b/drivers/usb/gadget/udc/tegra-xudc.c @@ -3932,7 +3932,8 @@ static void tegra_xudc_remove(struct platform_device = *pdev) &xudc->vbus_nb); } =20 - cancel_delayed_work_sync(&xudc->plc_reset_work); + disable_delayed_work_sync(&xudc->port_reset_war_work); + disable_delayed_work_sync(&xudc->plc_reset_work); cancel_work_sync(&xudc->usb_role_sw_work); =20 usb_del_gadget_udc(&xudc->gadget); --=20 2.53.0