From nobody Thu Sep 24 18:40:33 2026 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9A32E266C for ; Mon, 21 Sep 2026 23:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032030; cv=none; b=fP67aBQeSJJCEB05SvZ/dv1miA7aXoHu5lY9sLzarGTcV4iAfUDcjCamUMOzwaKw3fyQJ/qY2d1vX0oXYFMlbv4NvejORGxfZHzxPV0qZb11d73DXoghaLtoYJ6uijTopWcx0wmDH5L1ngclNOCNXvJyOqY8m8bCXl4ykpPOW4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032030; c=relaxed/simple; bh=HGszQMeBtGpcbjkEFUOHfoC/2lvOPq5mMavL1qn3WAc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lcURRowVvh2RyJvawjvrkH7c3W87cHlB9wdoUNSJD8SqiHm1SXfqoZjQIDvCTLnoUIURhe64bV2ZBarg/iFRO6vf4EKR8PLVc62EPuO65xBiNk4PSPoyXs/8m6mYFIY13p56oYKrK0G/3cGfScybbEjpHI2P4Hfrdx5GvuxeZR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GtinnQDy; arc=none smtp.client-ip=209.85.215.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GtinnQDy" Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc1b8088202so3155874a12.3 for ; Mon, 21 Sep 2026 16:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790032028; x=1790636828; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fKYG5VGbTPWmb7q1Nsotz5JXyK1vTlAdhH+6NwpOCvM=; b=GtinnQDyuWC9Ak5XQPRhusV1K+9rz4qU2n7R/z0Xq4U0GvSz8LBRa43jED0vJG3b+1 TgFKLR/q7T/cB3ACt5htEUooFv38QAnOI6zQRDFKDWzUg5jyxRWSYM2wV/r+JWqZuR9x 0vSfz6lxM9HyGkE3TaasFp8xCgWr9BblLb46EolD1whEMtfRAUue86CB63MvTAI2OKTi qjb7IMfBFCKtrNZ3Ph4mfVhJH3tYeuUkGj+uFr0zMmwe8ch9S8kT4xO+ZGQjH6zqakqh Nlb/M+MaliXu7QNzMaGBGtw09F41VB4kSE1lqg8ZatvFZWKIKpLFyM/6p04JFywy2c0x w66g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032028; x=1790636828; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fKYG5VGbTPWmb7q1Nsotz5JXyK1vTlAdhH+6NwpOCvM=; b=VYPBdSyuSue005zvCRg+jO5tR06BTd5TmLEZ39WUHmBP3O/fEGtn+XTUZDLVhrwbSw fMVGh0UkMrMt9fow1TFdIyuTpnyepHp1Eg8gKjXaH0eA+8p9lmLeBTRJZuEs9DbHdP7X 2vXoMOdZVjueD7m3JGzT8UoyzpC0rLtDPQQbYRaY44GZDIBxFIvQLtWw5eoy80IU9lKQ sPgtGCVlMgb7lCvrw1Iu4dancDc3/cpRU8v+tuPPMiKr8aW2lU4ItPlITR5wG3eV0+/U 7vopBejEDvrg6qX8i7pvG4U7X2VnhtVQpHABsGl3niHw35MPEtGSxAUmB11GC00uyZ3V 3yxQ== X-Forwarded-Encrypted: i=1; AKwUvBxAshdt876Xe0Rt/uwxK+tcrHF5n8wIZbvJZIpQg+3HVdGx9x/lEQYuAPaMSm+KRE0LLvdDHFxeB7uLcwM=@vger.kernel.org X-Gm-Message-State: AFuF++k/y4PkL4Yq1XPruTrsSA6AL3O5VKtsJQm5Xu0ZzKvnXHICXoYE wBAEihshiVngV8QjEz3E7Shuj95XVuHlQo8AH3/ZdJQY5QGYk/PIeEo/Z+Fvk0ounIhxqY7Dbyz jFvrChXcAXj4z4RSpbdXfYWuwOaBKgA== X-Received: from dlae24.prod.google.com ([2002:a05:701b:2318:b0:144:d326:40ff]) (user=samagazaryan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a10f:b0:3dd:a196:30a4 with SMTP id adf61e73a8af0-3dda19633d1mr11930087637.84.1790032028317; Mon, 21 Sep 2026 16:07:08 -0700 (PDT) Date: Mon, 21 Sep 2026 23:05:59 +0000 In-Reply-To: <20260921230603.2518652-1-samagazaryan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260921230603.2518652-1-samagazaryan@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921230603.2518652-2-samagazaryan@google.com> Subject: [PATCH v5 1/5] i3c: master: export i3c_masterdev_type From: Sam Agazaryan To: linux-i3c@lists.infradead.org, Alexandre Belloni , Frank Li Cc: Greg Kroah-Hartman , Wolfram Sang , Arnd Bergmann , Adrian Hunter , Meagan Lloyd , Vitor Soares , Oleksandr Shulzhenko , Boris Brezillon , linux-kernel@vger.kernel.org, Sam Agazaryan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Vitor Soares Export i3c_masterdev_type so i3cdev module can verify if an i3c device is a master. Signed-off-by: Vitor Soares Signed-off-by: Sam Agazaryan --- drivers/i3c/internals.h | 2 ++ drivers/i3c/master.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h index 86a36b951e0d..cbc00c862104 100644 --- a/drivers/i3c/internals.h +++ b/drivers/i3c/internals.h @@ -11,6 +11,8 @@ #include #include =20 +extern const struct device_type i3c_masterdev_type; + int __must_check i3c_bus_rpm_get(struct i3c_bus *bus); void i3c_bus_rpm_put(struct i3c_bus *bus); bool i3c_bus_rpm_ibi_allowed(struct i3c_bus *bus); diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index afcd7a21a3e6..e8a9f8c3041e 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -864,9 +864,10 @@ static void i3c_masterdev_release(struct device *dev) i3c_master_free_i3c_dev(master->this); } =20 -static const struct device_type i3c_masterdev_type =3D { +const struct device_type i3c_masterdev_type =3D { .groups =3D i3c_masterdev_groups, }; +EXPORT_SYMBOL_GPL(i3c_masterdev_type); =20 static void i3c_master_shutdown(struct i3c_master_controller *master) { --=20 2.55.0.1082.g2b9226bbc0-goog From nobody Thu Sep 24 18:40:33 2026 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7E5441DE01 for ; Mon, 21 Sep 2026 23:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032032; cv=none; b=CQnDQX8h+tio9B0vMBRKmrXaAEPyKFO1Ip7gVWKoPNM+DjcuJYFqAMyS7fmOcwOiLdY1FRnFViZ1/aV1BBwqN/MlEzoO1+Pjc2uhpXo7LkatiYcHMBudP4fJg1wIFAagxu+v4OXaKubq8em4CnrsA59d2Sphzhts3PRKyQGsKn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032032; c=relaxed/simple; bh=1kqLnj+8FvoNP8Iyva2qZ+5nUXP82oQZlgmxYX2kTFA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZfhenjIYjJu8n6tDrNWg7CZ9/eMLIvTkx19yaeGIoGC9lAQkoCFl+okHH869jp50KV6z10uqz4XVl0hvw4lp2Ccc3m4cpnTMzcMrzO/nFksffIx2K25iP982KD9jaRpx9NUYo3G0ymUdpIIp0jw5xpeZRvqcdarj5N3Z86HZ59M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=olGKUuNc; arc=none smtp.client-ip=209.85.215.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="olGKUuNc" Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc1b80835d5so4735162a12.2 for ; Mon, 21 Sep 2026 16:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790032030; x=1790636830; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rN3UiEVeD5JTvm5L/WrJ3sMgipX1w5Id3f3Ngl73Mok=; b=olGKUuNctDQHyfzUJ1BsQDZOqh52iEYhIA646YOE7tsQ5v5cnhlzuvx1G73xRPie51 CGB0NjOMCM5DHah+/GgDQ3aaQptVLeODxyHaBAwxAJ5WQ/XcihYfaRdMfFP3qza77Iav OAnOmabeiCy6OLOq6YvaLbgWv9VHgxvhkaJUo9jukSilSabtN4Phlxq4SXiIoPEKueyC bjEHS3TsNpBe/mOwxCQMVmtC7CFHWuQ5kWiPr1vXekeGsmOUo0d6glhvUYsobGrFNXK6 WK+Cws8804XYICqUy+0V3GFGkoKJWkG3Uv35dYTpzAf3lCzdRrf96Jy2BeXSCdTSeLTC jjCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032030; x=1790636830; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rN3UiEVeD5JTvm5L/WrJ3sMgipX1w5Id3f3Ngl73Mok=; b=fJ2PxG4AzoCFDY6GppRbJjI9HfzY2Bt/dsaHr3NhSPkWYBFqSVpITzPMq8Ynm4btA7 p2Yx7VzSrBw2eGiprORONsmTX8JvtiEHzyEf0zdqwh935JANHhT0CrgFDPI0Ap+kMGBC 9XXI8uGYKq9jqVfLRjf15fW6D26hk8JiqbO8V09knAAKVY+R73TUdE7cNGwL/obkGxUx FonGucmYpBEbfk5iFZc6O69GJsjKWukChPIKIVctNNc8hqXns/+a8vntBV+hhTPobCjJ pzS66z05rWolHrw7h5pcAWJoKEd1yvB0UT8okM2ALscmVCODZfw57WbAlhZOjSNpHA6C kvwQ== X-Forwarded-Encrypted: i=1; AKwUvBw+RwnmkEE5pV3UO8O5ePP94gdvksWCJmUnRzGyMn8hV2s5nZ6QwJCAW13STbdxmG8B6fE5foZzj1RswoE=@vger.kernel.org X-Gm-Message-State: AFuF++lvw1bqf5DCw5HCxVXJfNJcZSaghYdhgaALhtBQ+OVKd9txGBWe SZljTLzK77vpjKI5tY3xBC2m6z6jhRjCt6fmyn5Vhpt0IisGUVq/tUdpliTigoK+7ZywZhkOCYJ roXyoGjhOZCYo5Q5pLCGF9Eeui0HWhQ== X-Received: from dleb16-n2.prod.google.com ([2002:a05:701b:4250:20b0:144:dc13:586b]) (user=samagazaryan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:7704:b0:3cc:ec12:a788 with SMTP id adf61e73a8af0-3dd8c3f1681mr17721014637.4.1790032029435; Mon, 21 Sep 2026 16:07:09 -0700 (PDT) Date: Mon, 21 Sep 2026 23:06:00 +0000 In-Reply-To: <20260921230603.2518652-1-samagazaryan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260921230603.2518652-1-samagazaryan@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921230603.2518652-3-samagazaryan@google.com> Subject: [PATCH v5 2/5] i3c: master: add i3c_for_each_dev helper From: Sam Agazaryan To: linux-i3c@lists.infradead.org, Alexandre Belloni , Frank Li Cc: Greg Kroah-Hartman , Wolfram Sang , Arnd Bergmann , Adrian Hunter , Meagan Lloyd , Vitor Soares , Oleksandr Shulzhenko , Boris Brezillon , linux-kernel@vger.kernel.org, Sam Agazaryan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Vitor Soares Introduce i3c_for_each_dev(), an i3c device iterator for use by i3cdev. Signed-off-by: Vitor Soares Signed-off-by: Sam Agazaryan --- drivers/i3c/internals.h | 2 ++ drivers/i3c/master.c | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h index cbc00c862104..3c53a5108b81 100644 --- a/drivers/i3c/internals.h +++ b/drivers/i3c/internals.h @@ -79,4 +79,6 @@ static inline struct i3c_master_controller *i3c_bus_to_i3= c_master(struct i3c_bus return container_of(i3cbus, struct i3c_master_controller, bus); } =20 +int i3c_for_each_dev(void *data, int (*fn)(struct device *, void *)); + #endif /* I3C_INTERNAL_H */ diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index e8a9f8c3041e..07540ea73aec 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -4011,6 +4011,12 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *de= v) } EXPORT_SYMBOL_GPL(i3c_dev_free_ibi_locked); =20 +int i3c_for_each_dev(void *data, int (*fn)(struct device *, void *)) +{ + return bus_for_each_dev(&i3c_bus_type, NULL, data, fn); +} +EXPORT_SYMBOL_GPL(i3c_for_each_dev); + static int __init i3c_init(void) { int res; --=20 2.55.0.1082.g2b9226bbc0-goog From nobody Thu Sep 24 18:40:33 2026 Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0385C3CA4BC for ; Mon, 21 Sep 2026 23:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.71 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032034; cv=none; b=uLFXbzJ8LJXSdUMksBDX+Q5mJZAjyWbkI1zHVnZQICWWeVDY0Y8cN4CiKfuiyofKz/n2chRk9c6XE+/xjtTj7NWv6tkvciCckygCTvETzIIA4qU5kU9uHUIvYfXXhOba4YrMmtHNx3MnItFkSwdvRQjAuZvScBVJ/n3zjgBN664= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032034; c=relaxed/simple; bh=uJfzgfSGRNqdmsECGrwEUb3o+9fvnIN5kQou+V0cHC8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=F6WAERPiUhAKtEgfu7y1yvjNVTmlT2JwnX7bTpGTswqwo9clHs7XlOVGpGlb3PN5cDtbAhcBgxkkCLsb6Qr5JbJ79a4bNINP1kJydXyqFN6kXu0l2dhszb57M6M/KQEqjQ65y2Ad3Fhyp1vDwcTf7Ah/KVA4kUMbCBXJvE3oP1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tKjMuWpN; arc=none smtp.client-ip=209.85.216.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tKjMuWpN" Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38f97b3f853so5272247a91.3 for ; Mon, 21 Sep 2026 16:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790032031; x=1790636831; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=R6tln3zzXyXdjXIsZYRibDgjhT6eLkPrDJnsUsI23uA=; b=tKjMuWpN92sQ6reT6fgQnabnGwuCY4wF99Oz5M0Crwj98CtH17KzA264CQfYCHvPyr 5HYCY0MjlkVvuohPEJiUi3/URHDF0zmfHIA3oD7YYfbub12dmYtwCIdfs4GzrSD07tNs wfMNIvsYci5+N1U4QEqi8nfINiDWDXRh2febfj6T6Pbq9IE8XQBOnKnaODDZhLnaft+A HznMGiuK0vcT/BJauw6y2Cd2q83L/jTGCm6wBU4B9C5kX7fl4vU5UK1h6t29Wfdzuuh0 uFB+nF8GPpSHzBQp536kU67N++GKTOnjJ62Wgg2H9SraxheFSx53a5B1QlidR6c/xs3e 9UGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032031; x=1790636831; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R6tln3zzXyXdjXIsZYRibDgjhT6eLkPrDJnsUsI23uA=; b=Sg/ExhFpV/VZByBsoyoOUN61IQjqlMErHaD2tZDk1AarcdijOjZRYre9TB9H8PNrEi dXIU9FTOnKrb3vltwI+6yyXN0F5jG60PrwRPyhTPr0Xdm92KN1LvTdVN2YmmHJZXhBLu e0vm8KEe4wqPDEstS6CN3sqmupSwMSY+e5ChMZmUlhqcPL52Og177NGMpnoQI45yrhVs UpRwDUhhQQzufOQpNrp3W0t+arR0TtDIoymDGOkjGL6e3bJlkHmM7n7pQS+cXmwADK8o dLSI6F8aRh8wzCpZGp9augC0d6ptWw1wMjKcEayjKGBXwLzI6vtVWScKgq0/rORYqJaw QVAQ== X-Forwarded-Encrypted: i=1; AKwUvBwQ6ZoPYNk2eyXkWrMb2ROxdRcfS4ulGfPjjA2Hu58tqTSoMIFJRPEyLSi2MyMZAzhdHVRtgQhm3xKrQTY=@vger.kernel.org X-Gm-Message-State: AFuF++kM50cFvrVQ4AdolxDgR5RMD/Lqre0oRiCWv3DzI1gziJBKCUvi dNrikIgeJ71v/IkWFowlGj3dwBstMscNzte6d5jnA6HRuJOKMmiIlxusyEssKgwmV844PQxWXT+ JcfJwoRiqahI1g8y9ETamFgZDfpksmA== X-Received: from dyrt38.prod.google.com ([2002:a05:7300:4f26:b0:339:6b44:abf5]) (user=samagazaryan job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3909:b0:39e:3558:f925 with SMTP id 98e67ed59e1d1-39e54d86a97mr17168028a91.24.1790032030595; Mon, 21 Sep 2026 16:07:10 -0700 (PDT) Date: Mon, 21 Sep 2026 23:06:01 +0000 In-Reply-To: <20260921230603.2518652-1-samagazaryan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260921230603.2518652-1-samagazaryan@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921230603.2518652-4-samagazaryan@google.com> Subject: [PATCH v5 3/5] i3c: use actual_len for read transfers From: Sam Agazaryan To: linux-i3c@lists.infradead.org, Alexandre Belloni , Frank Li Cc: Greg Kroah-Hartman , Wolfram Sang , Arnd Bergmann , Adrian Hunter , Meagan Lloyd , Vitor Soares , Oleksandr Shulzhenko , Boris Brezillon , linux-kernel@vger.kernel.org, Sam Agazaryan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently only the amd and svc I3C controller drivers populate i3c_xfer.actual_len on reads, while dw-i3c-master and mipi-i3c-hci overwrite i3c_xfer.len with the received byte count and leave actual_len as 0. Because of this inconsistency, mctp-i3c reads xfer.len instead of xfer.actual_len, making it fail on controllers that do not mutate len. Unify read length reporting across the subsystem: - Clarify in that actual_len reflects the actual number of bytes transferred on reads. - Update adi, cdns, dw, mipi-i3c-hci, and renesas controller drivers to populate actual_len on read transfers without mutating len. - Update mctp-i3c to read xfer.actual_len instead of xfer.len. Co-developed-by: Meagan Lloyd Signed-off-by: Meagan Lloyd Signed-off-by: Sam Agazaryan --- drivers/i3c/master/adi-i3c-master.c | 5 ++++- drivers/i3c/master/dw-i3c-master.c | 2 +- drivers/i3c/master/i3c-master-cdns.c | 5 ++++- drivers/i3c/master/mipi-i3c-hci/core.c | 2 +- drivers/i3c/master/renesas-i3c.c | 3 +++ drivers/net/mctp/mctp-i3c.c | 10 +++++----- include/linux/i3c/device.h | 2 +- 7 files changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master/adi-i3c-master.c b/drivers/i3c/master/adi-i= 3c-master.c index b35386260350..d033bfd4ecc2 100644 --- a/drivers/i3c/master/adi-i3c-master.c +++ b/drivers/i3c/master/adi-i3c-master.c @@ -412,8 +412,11 @@ static int adi_i3c_master_i3c_xfers(struct i3c_dev_des= c *dev, =20 ret =3D xfer->ret; =20 - for (i =3D 0; i < nxfers; i++) + for (i =3D 0; i < nxfers; i++) { xfers[i].err =3D adi_i3c_cmd_get_err(&xfer->cmds[i]); + if (xfers[i].rnw) + xfers[i].actual_len =3D xfer->cmds[i].rx_len; + } =20 return ret; } diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 4563d8761ba0..28e8eb293747 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1029,7 +1029,7 @@ static int dw_i3c_master_i3c_xfers(struct i3c_dev_des= c *dev, struct dw_i3c_cmd *cmd =3D &xfer->cmds[i]; =20 if (i3c_xfers[i].rnw) - i3c_xfers[i].len =3D cmd->rx_len; + i3c_xfers[i].actual_len =3D cmd->rx_len; } =20 ret =3D xfer->ret; diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-= master-cdns.c index 2d98c1ce9b12..331062c10b31 100644 --- a/drivers/i3c/master/i3c-master-cdns.c +++ b/drivers/i3c/master/i3c-master-cdns.c @@ -795,8 +795,11 @@ static int cdns_i3c_master_i3c_xfers(struct i3c_dev_de= sc *dev, =20 ret =3D cdns_xfer->ret; =20 - for (i =3D 0; i < nxfers; i++) + for (i =3D 0; i < nxfers; i++) { xfers[i].err =3D cdns_i3c_cmd_get_err(&cdns_xfer->cmds[i]); + if (xfers[i].rnw) + xfers[i].actual_len =3D cdns_xfer->cmds[i].rx_len; + } =20 cdns_i3c_master_free_xfer(cdns_xfer); =20 diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mi= pi-i3c-hci/core.c index dadf049bd4b5..f74c02fab9e3 100644 --- a/drivers/i3c/master/mipi-i3c-hci/core.c +++ b/drivers/i3c/master/mipi-i3c-hci/core.c @@ -509,7 +509,7 @@ static int i3c_hci_i3c_xfers(struct i3c_dev_desc *dev, goto out; for (i =3D 0; i < nxfers; i++) { if (i3c_xfers[i].rnw) - i3c_xfers[i].len =3D RESP_DATA_LENGTH(xfer[i].response); + i3c_xfers[i].actual_len =3D RESP_DATA_LENGTH(xfer[i].response); if (RESP_STATUS(xfer[i].response) !=3D RESP_SUCCESS) { ret =3D -EIO; goto out; diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-= i3c.c index 28c0927a0179..a3dcb4cd9b0e 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -918,6 +918,9 @@ static int renesas_i3c_i3c_xfers(struct i3c_dev_desc *d= ev, struct i3c_xfer *i3c_ time_left =3D renesas_i3c_wait_xfer(i3c, xfer); if (!time_left) xfer_failed =3D true; + + if (i3c_xfers[i].rnw) + i3c_xfers[i].actual_len =3D cmd->rx_count; } =20 if (xfer_failed) diff --git a/drivers/net/mctp/mctp-i3c.c b/drivers/net/mctp/mctp-i3c.c index 6d2bbae7477b..5f94c11a1712 100644 --- a/drivers/net/mctp/mctp-i3c.c +++ b/drivers/net/mctp/mctp-i3c.c @@ -131,12 +131,12 @@ static int mctp_i3c_read(struct mctp_i3c_device *mi) if (rc < 0) goto err; =20 - if (WARN_ON_ONCE(xfer.len > mi->mrl)) { + if (WARN_ON_ONCE(xfer.actual_len > mi->mrl)) { /* Bad i3c bus driver */ rc =3D -EIO; goto err; } - if (xfer.len < MCTP_I3C_MINLEN) { + if (xfer.actual_len < MCTP_I3C_MINLEN) { stats->rx_length_errors++; rc =3D -EIO; goto err; @@ -145,15 +145,15 @@ static int mctp_i3c_read(struct mctp_i3c_device *mi) /* check PEC, including address byte */ addr =3D mi->addr << 1 | 1; pec =3D i2c_smbus_pec(0, &addr, 1); - pec =3D i2c_smbus_pec(pec, xfer.data.in, xfer.len - 1); - if (pec !=3D ((u8 *)xfer.data.in)[xfer.len - 1]) { + pec =3D i2c_smbus_pec(pec, xfer.data.in, xfer.actual_len - 1); + if (pec !=3D ((u8 *)xfer.data.in)[xfer.actual_len - 1]) { stats->rx_crc_errors++; rc =3D -EINVAL; goto err; } =20 /* Remove PEC */ - skb_trim(skb, xfer.len - 1); + skb_trim(skb, xfer.actual_len - 1); =20 cb =3D __mctp_cb(skb); cb->halen =3D PID_SIZE; diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h index 971d53349b6f..f868a7bf2bc9 100644 --- a/include/linux/i3c/device.h +++ b/include/linux/i3c/device.h @@ -59,7 +59,7 @@ enum i3c_xfer_mode { * @rnw: encodes the transfer direction. true for a read, false for a write * @cmd: Read/Write command in HDR mode, read: 0x80 - 0xff, write: 0x00 - = 0x7f * @len: transfer length in bytes of the transfer - * @actual_len: actual length in bytes are transferred by the controller + * @actual_len: actual length in bytes transferred by the controller on re= ad * @data: input/output buffer * @data.in: input buffer. Must point to a DMA-able buffer * @data.out: output buffer. Must point to a DMA-able buffer --=20 2.55.0.1082.g2b9226bbc0-goog From nobody Thu Sep 24 18:40:33 2026 Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 315C8423783 for ; Mon, 21 Sep 2026 23:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032038; cv=none; b=bEzCtaude3Tz98ZOKQEbZS6c/D5nXwciCCaikHKFYoG9wkaFNO5BNLFSR2HH5DNL/wIJL/ybcWAzs+HrBc+mZHVKDelPyL1Om5Db5ksHhsNBwrG6WttQEB1MP9m72PeOvAAtgkApbuB1HWTNnoX9rtWdlZANUyMAhfx64AJ6uj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032038; c=relaxed/simple; bh=k6D9L6ciHlLLaPvdwvp7qrRKyk4DudHGu0gEpK4cjIQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VsgxdQMDeMYB3tFF2uYgmKn+U5TWtkVjpZu9EskZdBLnWmcHLKkbediB276suTd4QflCz6dnaIT18Uv/sJ0QWfRWGdmIaEUgEhUV+ia9uBvMLiSNofIQ7QrFqWekfpWz539mkWzS3eBDOaxi7t+XMBTWwx5DrT1wQLxJ1augZcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BbgqO3Zu; arc=none smtp.client-ip=209.85.215.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BbgqO3Zu" Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cc7348bd56fso2911163a12.2 for ; Mon, 21 Sep 2026 16:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790032032; x=1790636832; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tV0m+z1ifDmYlEkqt8pxe/iOtaP+lMeY5FfCPnqmkp0=; b=BbgqO3Zul96nXr9F++uYPZio77eBMA0f48i5yna/+E5sBe91SRBKePWgnW3Oelw7A+ 3J2QxlyiAOCV+DVvkw76Gcp4IfqRrmW+y4Y38vRPF44ax0pcRR+nvqEI5UBDEAqbopYZ kMuIidPKUbTzbSK60hJiBbmmO80ipDNMW86jBJujQJpKMPvXyFew0zq58RGc7u49xzd9 MSrbk8nk8G/BlLnAqsX8im2BMJ3NTRCm+82IqrYLvvpyD/E9j4/tTaAHIfBSAKBp7hyl xe+rSnnnO7BMhrbo7nobXRE1eY/kmlBhb0Xn7dnmyLMH5gTSEynnDZEqsf/xW1oAZLUx Tj5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032032; x=1790636832; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tV0m+z1ifDmYlEkqt8pxe/iOtaP+lMeY5FfCPnqmkp0=; b=xlcpq+z8ddoSMp7AwrWBh1b/NHmmcJ5GOBNKt6hOoCcLDr1+h3qTmR/LwXetOKEsXD 7tGdrOv/cOA6pwkgLZ/JtWEepctNTw2DDW4Gf4wDEM2DhqDShwXYZXnVtUr8IF80bKZS JZCssn+AnLtfquY6q9AgxNxHSuWL4FtAqF9PP0EnpSrt9TswKiW5onjaAtuBvODdSDeQ cwS5b5Vh4FKwEDXN5EcmE515zoJ/6VIO/mRD8O8QZ2pKxFlQhicEFIQZU9HBNdatKNeK LiN8b6F2GAd8zncbi6QG13iqkZarc6dJ1YP5Ms6W8VqfQ7BAua0DJVKW4DdrMVOUoWry GG6Q== X-Forwarded-Encrypted: i=1; AKwUvBympFZya8AsY1BWG7wuaMRO4M6KzMyp7bh8hn3Hlrzl6sZ7nhitAUCGiRaeov4TZ+2E4EQNSkR5/S/YTjg=@vger.kernel.org X-Gm-Message-State: AFuF++l5SaffJuqX2PJstDt15efei2qwIwNMozTh9xrBUuyUpJeor5kr gWOYDgAy7IjurjzWIwMDBMMC6pxLGH9sDK/A7VZx2VDCk5w3VITXBhZPLDpK5zzCq4b5PjrvFNt G54jaY1MwcO0OcQzXbbVsi7i0+eJrFQ== X-Received: from dyaw12-n2.prod.google.com ([2002:a05:693c:414c:20b0:33c:393d:b309]) (user=samagazaryan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a10a:b0:3dd:a196:9072 with SMTP id adf61e73a8af0-3dde4127ee2mr474767637.60.1790032031849; Mon, 21 Sep 2026 16:07:11 -0700 (PDT) Date: Mon, 21 Sep 2026 23:06:02 +0000 In-Reply-To: <20260921230603.2518652-1-samagazaryan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260921230603.2518652-1-samagazaryan@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921230603.2518652-5-samagazaryan@google.com> Subject: [PATCH v5 4/5] i3c: add i3cdev module to expose i3c dev in /dev From: Sam Agazaryan To: linux-i3c@lists.infradead.org, Alexandre Belloni , Frank Li Cc: Greg Kroah-Hartman , Wolfram Sang , Arnd Bergmann , Adrian Hunter , Meagan Lloyd , Vitor Soares , Oleksandr Shulzhenko , Boris Brezillon , linux-kernel@vger.kernel.org, Sam Agazaryan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Vitor Soares Add userspace character device support for I3C transfers via /dev. The module allows userspace programs to interact directly with I3C targets that do not have a kernel driver bound to them, such as devices in ROM/bootloader recovery mode (e.g. OCP Secure Firmware Recovery v1.1 and Caliptra Silicon Root of Trust recovery flows). Features: - Dynamically exposes /dev/bus/i3c/ character devices for I3C devices when unbound from kernel drivers. - Dynamically allocates character device minor numbers using the IDA allocator. - Implements SDR and HDR transfers via I3C_IOC_XFER ioctl with 64-bit aligned UAPI data structures and actual_len read reporting. - Supports compat_ptr_ioctl for 32-bit userspace on 64-bit kernels. - Uses cdev_device_add/cdev_device_del with device refcounting to ensure safe lifecycle management and prevent use-after-free on driver detach. Signed-off-by: Vitor Soares Co-developed-by: Oleksandr Shulzhenko Signed-off-by: Oleksandr Shulzhenko Co-developed-by: Sam Agazaryan Signed-off-by: Sam Agazaryan --- MAINTAINERS | 1 + drivers/i3c/Kconfig | 11 + drivers/i3c/Makefile | 1 + drivers/i3c/i3cdev.c | 491 ++++++++++++++++++++++++++++++++ include/uapi/linux/i3c/i3cdev.h | 57 ++++ 5 files changed, 561 insertions(+) create mode 100644 drivers/i3c/i3cdev.c create mode 100644 include/uapi/linux/i3c/i3cdev.h diff --git a/MAINTAINERS b/MAINTAINERS index 81a9a02c919d..30a5cb12c4f0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12364,6 +12364,7 @@ F: Documentation/driver-api/i3c F: drivers/i3c/ F: include/dt-bindings/i3c/ F: include/linux/i3c/ +F: include/uapi/linux/i3c/ =20 IBM Operation Panel Input Driver M: Eddie James diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig index 626c54b386d5..166875837ec6 100644 --- a/drivers/i3c/Kconfig +++ b/drivers/i3c/Kconfig @@ -20,6 +20,17 @@ menuconfig I3C will be called i3c. =20 if I3C + +config I3CDEV + tristate "I3C device interface" + help + Say Y here to use i3c-* device files, usually found in the /dev + directory on your system. They make it possible to have user-space + programs use the I3C devices. + + This support is also available as a module. If so, the module + will be called i3cdev. + source "drivers/i3c/master/Kconfig" endif # I3C =20 diff --git a/drivers/i3c/Makefile b/drivers/i3c/Makefile index 11982efbc6d9..606d422841b2 100644 --- a/drivers/i3c/Makefile +++ b/drivers/i3c/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 i3c-y :=3D device.o master.o obj-$(CONFIG_I3C) +=3D i3c.o +obj-$(CONFIG_I3CDEV) +=3D i3cdev.o obj-$(CONFIG_I3C) +=3D master/ diff --git a/drivers/i3c/i3cdev.c b/drivers/i3c/i3cdev.c new file mode 100644 index 000000000000..309ce8181209 --- /dev/null +++ b/drivers/i3c/i3cdev.c @@ -0,0 +1,491 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2020 Synopsys, Inc. and/or its affiliates. + * Copyright (c) 2026 Google LLC + * + * Author: Vitor Soares + * Author: Sam Agazaryan + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include "internals.h" + +struct i3cdev_data { + struct list_head list; + struct i3c_device *i3c; + struct device dev; + struct mutex xfer_lock; /* prevent detach while transferring */ + struct cdev cdev; + int id; +}; + +static DEFINE_IDA(i3cdev_ida); +static LIST_HEAD(i3cdev_list); +static DEFINE_MUTEX(i3cdev_attach_lock); +static dev_t i3cdev_number; +#define I3C_MINORS (MINORMASK + 1) + +static void i3cdev_dev_release(struct device *dev) +{ + struct i3cdev_data *i3cdev =3D container_of(dev, struct i3cdev_data, dev); + + ida_free(&i3cdev_ida, i3cdev->id); + kfree(i3cdev); +} + +static struct i3cdev_data *i3cdev_get_by_i3c(struct i3c_device *i3c) +{ + struct i3cdev_data *i3cdev; + + list_for_each_entry(i3cdev, &i3cdev_list, list) { + if (i3cdev->i3c =3D=3D i3c) + return i3cdev; + } + + return NULL; +} + +static struct i3cdev_data *get_free_i3cdev(struct i3c_device *i3c) +{ + struct i3cdev_data *i3cdev; + int id; + + id =3D ida_alloc_max(&i3cdev_ida, MINORMASK, GFP_KERNEL); + if (id < 0) { + pr_err("i3cdev: no minor number available!\n"); + return ERR_PTR(id); + } + + i3cdev =3D kzalloc_obj(*i3cdev, GFP_KERNEL); + if (!i3cdev) { + ida_free(&i3cdev_ida, id); + return ERR_PTR(-ENOMEM); + } + + i3cdev->i3c =3D i3c; + i3cdev->id =3D id; + list_add_tail(&i3cdev->list, &i3cdev_list); + + return i3cdev; +} + +static ssize_t +i3cdev_read(struct file *file, char __user *buf, size_t count, loff_t *f_p= os) +{ + char *tmp __free(kfree) =3D NULL; + struct i3cdev_data *i3cdev =3D file->private_data; + struct i3c_xfer xfers =3D { + .rnw =3D true, + }; + struct i3c_device *i3c; + int ret; + + count =3D min_t(size_t, count, type_max(xfers.len)); + xfers.len =3D count; + + tmp =3D kzalloc(count, GFP_KERNEL); + if (!tmp) + return -ENOMEM; + + guard(mutex)(&i3cdev->xfer_lock); + i3c =3D i3cdev->i3c; + if (!i3c || i3c->dev.driver) + return -ENODEV; + + xfers.data.in =3D tmp; + + dev_dbg(&i3c->dev, "Reading %zu bytes.\n", count); + + ret =3D i3c_device_do_xfers(i3c, &xfers, 1, I3C_SDR); + if (ret) + return ret; + + if (copy_to_user(buf, tmp, xfers.actual_len)) + return -EFAULT; + + return xfers.actual_len; +} + +static ssize_t +i3cdev_write(struct file *file, const char __user *buf, size_t count, + loff_t *f_pos) +{ + void *tmp __free(kfree) =3D NULL; + struct i3cdev_data *i3cdev =3D file->private_data; + struct i3c_xfer xfers =3D { + .rnw =3D false, + }; + struct i3c_device *i3c; + int ret; + + count =3D min_t(size_t, count, type_max(xfers.len)); + xfers.len =3D count; + + tmp =3D memdup_user(buf, count); + if (IS_ERR(tmp)) + return PTR_ERR(tmp); + + guard(mutex)(&i3cdev->xfer_lock); + i3c =3D i3cdev->i3c; + if (!i3c || i3c->dev.driver) + return -ENODEV; + + xfers.data.out =3D tmp; + + dev_dbg(&i3c->dev, "Writing %zu bytes.\n", count); + + ret =3D i3c_device_do_xfers(i3c, &xfers, 1, I3C_SDR); + if (ret) + return ret; + + return count; +} + +static int +i3cdev_do_xfer(struct i3c_device *dev, struct i3c_ioc_xfer *xfers, + struct i3c_ioc_xfer __user *u_xfers, unsigned int nxfers) +{ + struct i3c_xfer *k_xfers __free(kfree) =3D NULL; + enum i3c_xfer_mode mode =3D xfers[0].mode; + u8 **data_ptrs; + int i, j, nalloc, ret =3D 0; + + /* Since we have nxfers we may allocate k_xfer + *data_ptrs together */ + k_xfers =3D kcalloc(nxfers, sizeof(*k_xfers) + sizeof(*data_ptrs), + GFP_KERNEL); + if (!k_xfers) + return -ENOMEM; + + /* set data_ptrs to be after nxfers * i3c_xfer */ + data_ptrs =3D (void *)k_xfers + (nxfers * sizeof(*k_xfers)); + + for (i =3D 0; i < nxfers; i++) { + bool is_read; + + if (xfers[i].mode !=3D mode) { + ret =3D -EINVAL; + break; + } + + if (memchr_inv(xfers[i].pad, 0, sizeof(xfers[i].pad))) { + ret =3D -EINVAL; + break; + } + + if (mode =3D=3D I3C_SDR) { + if (xfers[i].rnw !=3D I3C_DEV_DIR_WRITE && + xfers[i].rnw !=3D I3C_DEV_DIR_READ) { + ret =3D -EINVAL; + break; + } + is_read =3D xfers[i].rnw =3D=3D I3C_DEV_DIR_READ; + } else { + is_read =3D xfers[i].cmd & 0x80; + } + + if (is_read) { + data_ptrs[i] =3D kzalloc(xfers[i].len, GFP_KERNEL); + if (!data_ptrs[i]) { + ret =3D -ENOMEM; + break; + } + k_xfers[i].data.in =3D data_ptrs[i]; + } else { + data_ptrs[i] =3D memdup_user(u64_to_user_ptr(xfers[i].data), + xfers[i].len); + if (IS_ERR(data_ptrs[i])) { + ret =3D PTR_ERR(data_ptrs[i]); + break; + } + k_xfers[i].data.out =3D data_ptrs[i]; + } + + k_xfers[i].cmd =3D xfers[i].cmd; + k_xfers[i].len =3D xfers[i].len; + } + nalloc =3D i; + + if (ret < 0) + goto err_free_mem; + + ret =3D i3c_device_do_xfers(dev, k_xfers, nxfers, mode); + if (ret) + goto err_free_mem; + + for (i =3D 0; i < nxfers; i++) { + bool is_read =3D (mode =3D=3D I3C_SDR) ? + (xfers[i].rnw =3D=3D I3C_DEV_DIR_READ) : + (xfers[i].cmd & 0x80); + + if (is_read) { + if (copy_to_user(u64_to_user_ptr(xfers[i].data), + data_ptrs[i], k_xfers[i].actual_len) || + put_user(k_xfers[i].actual_len, + &u_xfers[i].actual_len)) { + ret =3D -EFAULT; + break; + } + } + } + +err_free_mem: + for (j =3D 0; j < nalloc; j++) + kfree(data_ptrs[j]); + return ret; +} + +static struct i3c_ioc_xfer * +i3cdev_get_ioc_xfer(unsigned int cmd, struct i3c_ioc_xfer __user *u_xfers, + unsigned int *nxfers) +{ + u32 tmp =3D _IOC_SIZE(cmd); + + if ((tmp % sizeof(struct i3c_ioc_xfer)) !=3D 0) + return ERR_PTR(-EINVAL); + + *nxfers =3D tmp / sizeof(struct i3c_ioc_xfer); + if (*nxfers =3D=3D 0) + return ERR_PTR(-EINVAL); + + return memdup_user(u_xfers, tmp); +} + +static int +i3cdev_ioc_xfer(struct i3c_device *i3c, unsigned int cmd, + struct i3c_ioc_xfer __user *u_xfers) +{ + struct i3c_ioc_xfer *k_xfers __free(kfree) =3D NULL; + unsigned int nxfers; + + k_xfers =3D i3cdev_get_ioc_xfer(cmd, u_xfers, &nxfers); + if (IS_ERR(k_xfers)) + return PTR_ERR(k_xfers); + + return i3cdev_do_xfer(i3c, k_xfers, u_xfers, nxfers); +} + +static long +i3cdev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +{ + struct i3cdev_data *i3cdev =3D file->private_data; + struct i3c_device *i3c; + + if (_IOC_TYPE(cmd) !=3D I3C_DEV_IOC_MAGIC) + return -ENOTTY; + + /* Use the xfer_lock to prevent device detach during ioctl call */ + guard(mutex)(&i3cdev->xfer_lock); + i3c =3D i3cdev->i3c; + if (!i3c || i3c->dev.driver) + return -ENODEV; + + dev_dbg(&i3c->dev, "ioctl, cmd=3D0x%02x, arg=3D0x%02lx\n", cmd, arg); + + /* Check command number and direction */ + if (_IOC_NR(cmd) =3D=3D _IOC_NR(I3C_IOC_XFER(0)) && + _IOC_DIR(cmd) =3D=3D (_IOC_READ | _IOC_WRITE)) + return i3cdev_ioc_xfer(i3c, cmd, + (struct i3c_ioc_xfer __user *)arg); + + return -ENOTTY; +} + +static int i3cdev_open(struct inode *inode, struct file *file) +{ + struct i3cdev_data *i3cdev =3D container_of(inode->i_cdev, + struct i3cdev_data, + cdev); + file->private_data =3D i3cdev; + + return 0; +} + +static int i3cdev_release(struct inode *inode, struct file *file) +{ + file->private_data =3D NULL; + + return 0; +} + +static const struct file_operations i3cdev_fops =3D { + .owner =3D THIS_MODULE, + .read =3D i3cdev_read, + .write =3D i3cdev_write, + .unlocked_ioctl =3D i3cdev_ioctl, + .compat_ioctl =3D compat_ptr_ioctl, + .open =3D i3cdev_open, + .release =3D i3cdev_release, +}; + +/* -----------------------------------------------------------------------= -- */ + +static const struct class i3cdev_class =3D { + .name =3D "i3cdev", +}; + +static int i3cdev_attach(struct device *dev, void *dummy) +{ + struct i3cdev_data *i3cdev; + struct i3c_device *i3c; + int res; + + if (dev->type =3D=3D &i3c_masterdev_type) + return 0; + + i3c =3D dev_to_i3cdev(dev); + + guard(mutex)(&i3cdev_attach_lock); + if (dev->driver || i3cdev_get_by_i3c(i3c)) + return 0; + + /* Get a device */ + i3cdev =3D get_free_i3cdev(i3c); + if (IS_ERR(i3cdev)) + return PTR_ERR(i3cdev); + + mutex_init(&i3cdev->xfer_lock); + cdev_init(&i3cdev->cdev, &i3cdev_fops); + i3cdev->cdev.owner =3D THIS_MODULE; + + device_initialize(&i3cdev->dev); + i3cdev->dev.devt =3D MKDEV(MAJOR(i3cdev_number), i3cdev->id); + i3cdev->dev.class =3D &i3cdev_class; + i3cdev->dev.parent =3D &i3c->dev; + i3cdev->dev.release =3D i3cdev_dev_release; + + res =3D dev_set_name(&i3cdev->dev, "bus!i3c!%s", dev_name(&i3c->dev)); + if (res) + goto error_put_dev; + + res =3D cdev_device_add(&i3cdev->cdev, &i3cdev->dev); + if (res) + goto error_put_dev; + + pr_debug("i3cdev: I3C device [%s] registered as minor %d\n", + dev_name(&i3c->dev), i3cdev->id); + return 0; + +error_put_dev: + list_del(&i3cdev->list); + put_device(&i3cdev->dev); + return res; +} + +static int i3cdev_detach(struct device *dev, void *dummy) +{ + struct i3cdev_data *i3cdev; + struct i3c_device *i3c; + + if (dev->type =3D=3D &i3c_masterdev_type) + return 0; + + i3c =3D dev_to_i3cdev(dev); + + guard(mutex)(&i3cdev_attach_lock); + i3cdev =3D i3cdev_get_by_i3c(i3c); + if (!i3cdev) + return 0; + + list_del(&i3cdev->list); + + /* Prevent transfers while cdev removal */ + scoped_guard(mutex, &i3cdev->xfer_lock) + i3cdev->i3c =3D NULL; + + cdev_device_del(&i3cdev->cdev, &i3cdev->dev); + put_device(&i3cdev->dev); + + pr_debug("i3cdev: device [%s] unregistered\n", dev_name(&i3c->dev)); + + return 0; +} + +static int i3cdev_notifier_call(struct notifier_block *nb, + unsigned long action, + void *data) +{ + struct device *dev =3D data; + + switch (action) { + case BUS_NOTIFY_ADD_DEVICE: + case BUS_NOTIFY_UNBOUND_DRIVER: + case BUS_NOTIFY_DRIVER_NOT_BOUND: + i3cdev_attach(dev, NULL); + break; + case BUS_NOTIFY_DEL_DEVICE: + case BUS_NOTIFY_REMOVED_DEVICE: + case BUS_NOTIFY_BIND_DRIVER: + i3cdev_detach(dev, NULL); + break; + } + + return NOTIFY_OK; +} + +static struct notifier_block i3cdev_notifier =3D { + .notifier_call =3D i3cdev_notifier_call, +}; + +static int __init i3cdev_init(void) +{ + int res; + + /* Dynamically request unused major number */ + res =3D alloc_chrdev_region(&i3cdev_number, 0, I3C_MINORS, "i3c"); + if (res) + goto out; + + /* Register device class to populate sysfs entries */ + res =3D class_register(&i3cdev_class); + if (res) + goto out_unreg_chrdev; + + /* Keep track of busses which have devices to add or remove later */ + res =3D bus_register_notifier(&i3c_bus_type, &i3cdev_notifier); + if (res) + goto out_unreg_class; + + /* Bind to already existing device without driver right away */ + i3c_for_each_dev(NULL, i3cdev_attach); + + return 0; + +out_unreg_class: + class_unregister(&i3cdev_class); +out_unreg_chrdev: + unregister_chrdev_region(i3cdev_number, I3C_MINORS); +out: + pr_err("%s: Driver Initialisation failed\n", __FILE__); + return res; +} + +static void __exit i3cdev_exit(void) +{ + bus_unregister_notifier(&i3c_bus_type, &i3cdev_notifier); + i3c_for_each_dev(NULL, i3cdev_detach); + class_unregister(&i3cdev_class); + unregister_chrdev_region(i3cdev_number, I3C_MINORS); +} + +MODULE_AUTHOR("Vitor Soares "); +MODULE_DESCRIPTION("I3C /dev entries driver"); +MODULE_LICENSE("GPL"); + +module_init(i3cdev_init); +module_exit(i3cdev_exit); diff --git a/include/uapi/linux/i3c/i3cdev.h b/include/uapi/linux/i3c/i3cde= v.h new file mode 100644 index 000000000000..69e901017378 --- /dev/null +++ b/include/uapi/linux/i3c/i3cdev.h @@ -0,0 +1,57 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* + * Copyright (c) 2020 Synopsys, Inc. and/or its affiliates. + * Copyright (c) 2026 Google LLC + * + * Author: Vitor Soares + */ + +#ifndef _UAPI_I3C_DEV_H_ +#define _UAPI_I3C_DEV_H_ + +#include +#include + +/* IOCTL commands */ +#define I3C_DEV_IOC_MAGIC 0x07 + +#define I3C_DEV_DIR_WRITE 0 +#define I3C_DEV_DIR_READ 1 + +#define I3C_XFER_MODE_HDR_DDR 0 +#define I3C_XFER_MODE_HDR_TSP 1 +#define I3C_XFER_MODE_HDR_TSL 2 +#define I3C_XFER_MODE_SDR 31 + +/** + * struct i3c_ioc_xfer - I3C ioctl transfer + * @data: Holds pointer to userspace buffer with transmit/receive data. + * @len: Length of data buffer, in bytes. + * @actual_len: Actual length of data transferred on read, in bytes (outpu= t). + * @rnw: Transfer direction for SDR mode (I3C_DEV_DIR_WRITE or I3C_DEV_DIR= _READ). + * @cmd: Command byte for HDR mode (0x00-0x7f write, 0x80-0xff read). + * @mode: Transfer mode (I3C_XFER_MODE_SDR, I3C_XFER_MODE_HDR_DDR, etc.). + * @pad: Reserved for future extensions; must be zeroed. + */ +struct i3c_ioc_xfer { + __u64 data; + __u16 len; + __u16 actual_len; + union { + __u8 rnw; + __u8 cmd; + }; + __u8 mode; + __u8 pad[2]; +}; + +#define __I3C_XFER_SIZE(type) \ + ((((sizeof(struct i3c_ioc_xfer)) * (type)) < (1 << _IOC_SIZEBITS)) \ + ? ((sizeof(struct i3c_ioc_xfer)) * (type)) : 0) + +#define I3C_XFER_SIZE(N) __I3C_XFER_SIZE(N) + +#define I3C_IOC_XFER(N) \ + _IOC(_IOC_READ | _IOC_WRITE, I3C_DEV_IOC_MAGIC, 30, I3C_XFER_SIZE(N)) + +#endif --=20 2.55.0.1082.g2b9226bbc0-goog From nobody Thu Sep 24 18:40:33 2026 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04FAF3F7A83 for ; Mon, 21 Sep 2026 23:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.69 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032038; cv=none; b=in2ymVLBeCOwb5BX/+zejfPPcg1riB27VrUXLLuBFMVv44qNjjrJ5dtGXlDM02pg11pmxryoAUOQAg+7c+c8fNNnFaTZyv/fT9gFPBDGzpfPIKRZI1USp25ZIiSzB3WGbqRyYzithX+okPYni8xi9R+GQl8q3eo0pCDKXi9oAuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032038; c=relaxed/simple; bh=c93vebiJj6iy2djm+3lrIDeoqd5Be76Gyj2lctZC6wI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=U7tSVefuGilGqdP8zMEsaUraL9FMvDC1f3lp1hNfSdvsHHo0n1HvhA0zoWgXkRuG+Idbf4GlqogAAxZgbWJwZcm8IhzKRT6Nz5ZFqkYpLpoLSqS03P9AJtzvuAfF3Me2B72RCh2p+t4fd3f2TVqMdaZv2KihCUskihE7RQVuTXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=TbOGyDea; arc=none smtp.client-ip=209.85.216.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samagazaryan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TbOGyDea" Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-39533bb224cso6273381a91.3 for ; Mon, 21 Sep 2026 16:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790032033; x=1790636833; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RR0zZiXpRm2WDANYV1GsiZi8Wtsj9oHp4lONKDVQ0To=; b=TbOGyDeaeoop2PUQJ478m9EpQljZ6OSWGMYWoRLs5TUEloHfG7diQagyOyQFhdvVdK EZYTsZ+P5lNwzC/Fv2Jna/Xr8b4kekEQEDeogQd5/V/m3v/1LJ4kCoNCkx1EkpyPQ9G3 JIBDq+dDaxY+FqIjlEpspfhLk8Hm7dcm/tayYkXnPGlSz2p8EsWYgMD99Dp5cWqB2loU R99pmL0ymIiOv0xmu5tB6m0bDA5OiM4wlTzLnNxJFUEEvfrzyGHp/mug2gHqKiZAps2w R7Vod8WkaRYqx8hsKcDtV5lBe/G62MnM0upjh9CngLKjIue20T7I6EhG4i23bVMz7bwQ wNKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032033; x=1790636833; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RR0zZiXpRm2WDANYV1GsiZi8Wtsj9oHp4lONKDVQ0To=; b=tAYMstmQ1TJ2NcvlTZ3GkGYLvY8x+Ph9k1C5nhxAAF73/aQJmEy28eOX2mi54p4c93 bVpINBY2j+iJI+x8Q7vw12LSF1/7I5qkj4/XTVdeDyeYs8TUvpzmBt/ngFkuzNo1JjGN xHdUmfVVCOxtCblebW7ewhTOGB2PHmo8qlOIehMM+VwURoOMvmSbX6EZH8j3ThHoyIuI Hjt2H6ATPmTm9khRCKIxnW7f32H2uIsOz2DoMnjTwktVWyHG3jiP1LjdPll+YKSUXRr3 FRLx3KdbAi4EinYQxKT9F/BwG7n4gvMzy1h2wDOpoHM+VrRdawMEjbjtzS3m9Kx3F9Tx GmtA== X-Forwarded-Encrypted: i=1; AKwUvBy+PwpNwUztm/ORoxlzrpYNSKThFWofs/Np3avKnIKiUt7n10Eb621rO2lJfOncy3gaEetQ9bJ8RdknRVo=@vger.kernel.org X-Gm-Message-State: AFuF++kl2EpkbHr+ypcZrrsOFCUfef+tNBmM9j7HkS+F5g9NHE5RawrS mm9mDjGina7TDYUVV08csd1vZTIDvv2+aWY8UFguVVBd1imNjg+rH8ft9nc0zqLFFiSHORI7eCa cFCFGUhvRMVxhLrmqdBduh1jMyQyHxg== X-Received: from dldz19-n1.prod.google.com ([2002:a05:701b:4193:10b0:143:9704:de05]) (user=samagazaryan job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:fc4b:b0:3a0:2900:f577 with SMTP id 98e67ed59e1d1-3a02900f8f6mr9538685a91.51.1790032032957; Mon, 21 Sep 2026 16:07:12 -0700 (PDT) Date: Mon, 21 Sep 2026 23:06:03 +0000 In-Reply-To: <20260921230603.2518652-1-samagazaryan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260921230603.2518652-1-samagazaryan@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921230603.2518652-6-samagazaryan@google.com> Subject: [PATCH v5 5/5] tools: i3c: add i3ctransfer utility From: Sam Agazaryan To: linux-i3c@lists.infradead.org, Alexandre Belloni , Frank Li Cc: Greg Kroah-Hartman , Wolfram Sang , Arnd Bergmann , Adrian Hunter , Meagan Lloyd , Vitor Soares , Oleksandr Shulzhenko , Boris Brezillon , linux-kernel@vger.kernel.org, Sam Agazaryan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the i3ctransfer userspace utility to tools/i3c/ for testing and interacting with I3C target devices via /dev/bus/i3c/* character devices. Based on the i3ctransfer tool from i3c-tools by Vitor Soares, updated for the unified I3C_IOC_XFER UAPI (struct i3c_ioc_xfer): - Supports SDR and HDR (HDR-DDR, HDR-TSP, HDR-TSL) transfer modes via -m/--mode and -c/--command options. - Reports actual_len bytes received on read transfers. Signed-off-by: Sam Agazaryan --- Note to Vitor Soares: This patch ports your GPL-2.0 i3ctransfer utility from i3c-tools into tools/i3c/ and updates it for struct i3c_ioc_xfer (SDR/HDR modes and actual_len read reporting). Since the original GitHub commit did not include a Signed-off-by tag, could you please reply with your Signed-off-by or Acked-by so we can properly record your sign-off? MAINTAINERS | 1 + tools/Makefile | 13 +- tools/i3c/Build | 1 + tools/i3c/Makefile | 58 ++++++++ tools/i3c/i3ctransfer.c | 307 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 374 insertions(+), 6 deletions(-) create mode 100644 tools/i3c/Build create mode 100644 tools/i3c/Makefile create mode 100644 tools/i3c/i3ctransfer.c diff --git a/MAINTAINERS b/MAINTAINERS index 30a5cb12c4f0..8a4166ebc9dc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12365,6 +12365,7 @@ F: drivers/i3c/ F: include/dt-bindings/i3c/ F: include/linux/i3c/ F: include/uapi/linux/i3c/ +F: tools/i3c/ =20 IBM Operation Panel Input Driver M: Eddie James diff --git a/tools/Makefile b/tools/Makefile index cb40961a740f..7c17e7555fd7 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -20,6 +20,7 @@ help: @echo ' freefall - laptop accelerometer program for disk p= rotection' @echo ' gpio - GPIO tools' @echo ' hv - tools used when in Hyper-V clients' + @echo ' i3c - I3C tools' @echo ' iio - IIO tools' @echo ' intel-speed-select - Intel Speed Select tool' @echo ' kvm_stat - top-like utility for displaying kvm sta= tistics' @@ -70,7 +71,7 @@ acpi: FORCE cpupower: FORCE $(call descend,power/$@) =20 -counter dma firewire hv guest bootconfig spi usb virtio mm bpf iio gpio ob= jtool leds wmi firmware debugging tracing: FORCE +counter dma firewire hv guest bootconfig spi usb virtio mm bpf i3c iio gpi= o objtool leds wmi firmware debugging tracing: FORCE $(call descend,$@) =20 bpf/%: FORCE @@ -126,7 +127,7 @@ ynl: FORCE all: acpi counter cpupower dma gpio hv firewire \ perf selftests bootconfig spi turbostat usb \ virtio mm bpf x86_energy_perf_policy \ - tmon freefall iio objtool kvm_stat wmi \ + tmon freefall i3c iio objtool kvm_stat wmi \ debugging tracing thermal thermometer thermal-engine ynl =20 acpi_install: @@ -135,7 +136,7 @@ acpi_install: cpupower_install: $(call descend,power/$(@:_install=3D),install) =20 -counter_install dma_install firewire_install gpio_install hv_install iio_i= nstall perf_install bootconfig_install spi_install usb_install virtio_insta= ll mm_install bpf_install objtool_install wmi_install debugging_install tra= cing_install: +counter_install dma_install firewire_install gpio_install hv_install i3c_i= nstall iio_install perf_install bootconfig_install spi_install usb_install = virtio_install mm_install bpf_install objtool_install wmi_install debugging= _install tracing_install: $(call descend,$(@:_install=3D),install) =20 selftests_install: @@ -166,7 +167,7 @@ ynl_install: $(call descend,net/$(@:_install=3D),install) =20 install: acpi_install counter_install cpupower_install dma_install gpio_in= stall \ - hv_install firewire_install iio_install \ + hv_install firewire_install i3c_install iio_install \ perf_install selftests_install turbostat_install usb_install \ virtio_install mm_install bpf_install x86_energy_perf_policy_install \ tmon_install freefall_install objtool_install kvm_stat_install \ @@ -179,7 +180,7 @@ acpi_clean: cpupower_clean: $(call descend,power/cpupower,clean) =20 -counter_clean dma_clean hv_clean firewire_clean bootconfig_clean spi_clean= usb_clean virtio_clean mm_clean wmi_clean bpf_clean iio_clean gpio_clean o= bjtool_clean leds_clean firmware_clean debugging_clean tracing_clean: +counter_clean dma_clean hv_clean firewire_clean bootconfig_clean spi_clean= usb_clean virtio_clean mm_clean wmi_clean bpf_clean i3c_clean iio_clean gp= io_clean objtool_clean leds_clean firmware_clean debugging_clean tracing_cl= ean: $(call descend,$(@:_clean=3D),clean) =20 libapi_clean: @@ -227,7 +228,7 @@ ynl_clean: =20 clean: acpi_clean counter_clean cpupower_clean dma_clean hv_clean firewire= _clean \ perf_clean selftests_clean turbostat_clean bootconfig_clean spi_clean us= b_clean virtio_clean \ - mm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \ + mm_clean bpf_clean i3c_clean iio_clean x86_energy_perf_policy_clean tmon= _clean \ freefall_clean build_clean libbpf_clean libsubcmd_clean \ gpio_clean objtool_clean leds_clean wmi_clean firmware_clean debugging_c= lean \ intel-speed-select_clean tracing_clean thermal_clean thermometer_clean t= hermal-engine_clean \ diff --git a/tools/i3c/Build b/tools/i3c/Build new file mode 100644 index 000000000000..6a22328ad983 --- /dev/null +++ b/tools/i3c/Build @@ -0,0 +1 @@ +i3ctransfer-y +=3D i3ctransfer.o diff --git a/tools/i3c/Makefile b/tools/i3c/Makefile new file mode 100644 index 000000000000..43ce8769185b --- /dev/null +++ b/tools/i3c/Makefile @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2.0-only +include ../scripts/Makefile.include + +bindir ?=3D /usr/bin + +ifeq ($(srctree),) +srctree :=3D $(patsubst %/,%,$(dir $(CURDIR))) +srctree :=3D $(patsubst %/,%,$(dir $(srctree))) +endif + +# Do not use make's built-in rules +# (this improves performance and avoids hard-to-debug behaviour); +MAKEFLAGS +=3D -r + +CFLAGS +=3D -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include + +ALL_TARGETS :=3D i3ctransfer +ALL_PROGRAMS :=3D $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS)) + +all: $(ALL_PROGRAMS) + +export srctree OUTPUT CC LD CFLAGS +include $(srctree)/tools/build/Makefile.include + +# +# We need the following to be outside of kernel tree +# +$(OUTPUT)include/linux/i3c: ../../include/uapi/linux/i3c + mkdir -p $(OUTPUT)include/linux/i3c 2>&1 || true + ln -sf $(CURDIR)/../../include/uapi/linux/i3c/i3cdev.h $@ + +prepare: $(OUTPUT)include/linux/i3c + +# +# i3ctransfer +# +I3CTRANSFER_IN :=3D $(OUTPUT)i3ctransfer-in.o +$(I3CTRANSFER_IN): prepare FORCE + $(Q)$(MAKE) $(build)=3Di3ctransfer +$(OUTPUT)i3ctransfer: $(I3CTRANSFER_IN) + $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ + +clean: + rm -f $(ALL_PROGRAMS) + rm -rf $(OUTPUT)include/ + find $(or $(OUTPUT),.) -name '*.o' -delete + find $(or $(OUTPUT),.) -name '\.*.o.d' -delete + find $(or $(OUTPUT),.) -name '\.*.o.cmd' -delete + +install: $(ALL_PROGRAMS) + install -d -m 755 $(DESTDIR)$(bindir); \ + for program in $(ALL_PROGRAMS); do \ + install $$program $(DESTDIR)$(bindir); \ + done + +FORCE: + +.PHONY: all install clean FORCE prepare diff --git a/tools/i3c/i3ctransfer.c b/tools/i3c/i3ctransfer.c new file mode 100644 index 000000000000..a5b071e63530 --- /dev/null +++ b/tools/i3c/i3ctransfer.c @@ -0,0 +1,307 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019 Synopsys, Inc. and/or its affiliates. + * Copyright (c) 2026 Google LLC + * + * Author: Vitor Soares + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define VERSION "0.2" + +static const char *sopts =3D "d:m:c:r:w:vh"; +static const struct option lopts[] =3D { + {"device", required_argument, NULL, 'd' }, + {"mode", required_argument, NULL, 'm' }, + {"command", required_argument, NULL, 'c' }, + {"read", required_argument, NULL, 'r' }, + {"write", required_argument, NULL, 'w' }, + {"help", no_argument, NULL, 'h' }, + {"version", no_argument, NULL, 'v' }, + {0, 0, 0, 0} +}; + +static void print_usage(const char *name) +{ + fprintf(stderr, "usage: %s options...\n", name); + fprintf(stderr, " options:\n"); + fprintf(stderr, " -d --device device to use.\n"); + fprintf(stderr, + " -m --mode sdr (default), hdr-ddr, hdr-tsp, hdr-tsl.\n"); + fprintf(stderr, + " -c --command HDR command byte (0x00-0x7f W, 0x80-0xff R).\= n"); + fprintf(stderr, " -r --read read data length in bytes.\n"); + fprintf(stderr, + " -w --write write comma-separated bytes (e.g. 0x01,0x02).= \n"); + fprintf(stderr, " -h --help output usage message and exit.= \n"); + fprintf(stderr, " -v --version output version number and exit= .\n"); +} + +static int parse_mode(const char *arg, uint8_t *mode) +{ + char *endptr; + long val; + + if (!strcmp(arg, "sdr")) { + *mode =3D I3C_XFER_MODE_SDR; + return 0; + } + if (!strcmp(arg, "hdr-ddr") || !strcmp(arg, "ddr")) { + *mode =3D I3C_XFER_MODE_HDR_DDR; + return 0; + } + if (!strcmp(arg, "hdr-tsp") || !strcmp(arg, "tsp")) { + *mode =3D I3C_XFER_MODE_HDR_TSP; + return 0; + } + if (!strcmp(arg, "hdr-tsl") || !strcmp(arg, "tsl")) { + *mode =3D I3C_XFER_MODE_HDR_TSL; + return 0; + } + + val =3D strtol(arg, &endptr, 0); + if (*endptr =3D=3D '\0' && + (val =3D=3D I3C_XFER_MODE_HDR_DDR || + val =3D=3D I3C_XFER_MODE_HDR_TSP || + val =3D=3D I3C_XFER_MODE_HDR_TSL || + val =3D=3D I3C_XFER_MODE_SDR)) { + *mode =3D (uint8_t)val; + return 0; + } + + fprintf(stderr, "Error: invalid transfer mode '%s'\n", arg); + return -1; +} + +static int rx_args_to_xfer(struct i3c_ioc_xfer *xfer, char *arg, + uint8_t mode, int cmd) +{ + char *endptr; + uint8_t *tmp; + long len; + + len =3D strtol(arg, &endptr, 0); + if (*endptr !=3D '\0' || len <=3D 0 || len > UINT16_MAX) { + fprintf(stderr, "Error: invalid read length '%s'\n", arg); + return -1; + } + + if (mode =3D=3D I3C_XFER_MODE_SDR) { + xfer->rnw =3D I3C_DEV_DIR_READ; + } else { + if (cmd < 0 || !(cmd & 0x80)) { + fprintf(stderr, + "Error: HDR read requires command (-c) in range 0x80..0xff\n"); + return -1; + } + xfer->cmd =3D (uint8_t)cmd; + } + + tmp =3D calloc(len, sizeof(uint8_t)); + if (!tmp) + return -1; + + xfer->mode =3D mode; + xfer->len =3D (uint16_t)len; + xfer->data =3D (uintptr_t)tmp; + + return 0; +} + +static int w_args_to_xfer(struct i3c_ioc_xfer *xfer, char *arg, + uint8_t mode, int cmd) +{ + char *data_ptrs[256]; + int len, i =3D 0; + uint8_t *tmp; + + if (mode =3D=3D I3C_XFER_MODE_SDR) { + xfer->rnw =3D I3C_DEV_DIR_WRITE; + } else { + if (cmd < 0 || (cmd & 0x80)) { + fprintf(stderr, + "Error: HDR write requires command (-c) in range 0x00..0x7f\n"); + return -1; + } + xfer->cmd =3D (uint8_t)cmd; + } + + data_ptrs[i] =3D strtok(arg, ","); + while (data_ptrs[i] && i < 255) + data_ptrs[++i] =3D strtok(NULL, ","); + + if (i =3D=3D 0) { + fprintf(stderr, "Error: empty write data block\n"); + return -1; + } + + tmp =3D calloc(i, sizeof(uint8_t)); + if (!tmp) + return -1; + + for (len =3D 0; len < i; len++) { + char *endptr; + long val =3D strtol(data_ptrs[len], &endptr, 0); + + if (*endptr !=3D '\0' || val < 0 || val > UINT8_MAX) { + fprintf(stderr, "Error: invalid byte value '%s'\n", + data_ptrs[len]); + free(tmp); + return -1; + } + tmp[len] =3D (uint8_t)val; + } + + xfer->mode =3D mode; + xfer->len =3D (uint16_t)len; + xfer->data =3D (uintptr_t)tmp; + + return 0; +} + +static void print_rx_data(const struct i3c_ioc_xfer *xfer) +{ + const uint8_t *tmp =3D (const uint8_t *)(uintptr_t)xfer->data; + int i; + + fprintf(stdout, " received data (%u bytes):\n", xfer->actual_len); + for (i =3D 0; i < xfer->actual_len; i++) + fprintf(stdout, " 0x%02x\n", tmp[i]); +} + +int main(int argc, char *argv[]) +{ + uint8_t mode =3D I3C_XFER_MODE_SDR; + struct i3c_ioc_xfer *xfers; + char *device =3D NULL; + int file, ret, opt, i; + int nxfers =3D 0; + int cmd =3D -1; + + while ((opt =3D getopt_long(argc, argv, sopts, lopts, NULL)) !=3D EOF) { + switch (opt) { + case 'h': + print_usage(argv[0]); + return EXIT_SUCCESS; + case 'v': + fprintf(stderr, "%s - %s\n", argv[0], VERSION); + return EXIT_SUCCESS; + case 'd': + device =3D optarg; + break; + case 'm': + if (parse_mode(optarg, &mode)) + return EXIT_FAILURE; + break; + case 'c': { + char *endptr; + long val =3D strtol(optarg, &endptr, 0); + + if (*endptr !=3D '\0' || val < 0 || val > UINT8_MAX) { + fprintf(stderr, "Error: invalid command '%s'\n", + optarg); + return EXIT_FAILURE; + } + cmd =3D (int)val; + break; + } + case 'r': + case 'w': + nxfers++; + break; + default: + print_usage(argv[0]); + return EXIT_FAILURE; + } + } + + if (!device || nxfers =3D=3D 0) { + print_usage(argv[0]); + return EXIT_FAILURE; + } + + file =3D open(device, O_RDWR); + if (file < 0) { + fprintf(stderr, "Error: failed to open %s: %s\n", + device, strerror(errno)); + return EXIT_FAILURE; + } + + xfers =3D calloc(nxfers, sizeof(*xfers)); + if (!xfers) { + close(file); + return EXIT_FAILURE; + } + + optind =3D 1; + nxfers =3D 0; + cmd =3D -1; + + while ((opt =3D getopt_long(argc, argv, sopts, lopts, NULL)) !=3D EOF) { + switch (opt) { + case 'h': + case 'v': + case 'd': + case 'm': + break; + case 'c': + cmd =3D (int)strtol(optarg, NULL, 0); + break; + case 'r': + if (rx_args_to_xfer(&xfers[nxfers], optarg, mode, cmd)) { + ret =3D EXIT_FAILURE; + goto err_free; + } + nxfers++; + break; + case 'w': + if (w_args_to_xfer(&xfers[nxfers], optarg, mode, cmd)) { + ret =3D EXIT_FAILURE; + goto err_free; + } + nxfers++; + break; + } + } + + if (ioctl(file, I3C_IOC_XFER(nxfers), xfers) < 0) { + fprintf(stderr, "Error: transfer failed: %s\n", strerror(errno)); + ret =3D EXIT_FAILURE; + goto err_free; + } + + for (i =3D 0; i < nxfers; i++) { + bool is_read =3D (mode =3D=3D I3C_XFER_MODE_SDR) ? + (xfers[i].rnw =3D=3D I3C_DEV_DIR_READ) : + (xfers[i].cmd & 0x80); + + fprintf(stdout, "Success on message %d\n", i); + if (is_read) + print_rx_data(&xfers[i]); + } + + ret =3D EXIT_SUCCESS; + +err_free: + for (i =3D 0; i < nxfers; i++) + free((void *)(uintptr_t)xfers[i].data); + free(xfers); + close(file); + + return ret; +} --=20 2.55.0.1082.g2b9226bbc0-goog