From nobody Fri Sep 25 21:02:39 2026 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E0F4AA3E2 for ; Mon, 21 Sep 2026 14:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790002207; cv=none; b=buANOVySlFedZeqErmArAduv2u+XJ67D1Z/d1iBGS13yy/oYjAIPnKLvjqu0oq7Cqd2VMPeu+Foqo2EZND/ilx421n00dZhOVUVOyMFftsFKejVCBCzgLucX4sS730/9yoMFVdvtwskrWWYBUjGmRcPy4AOVJT9k/NHAKA3k9dQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790002207; c=relaxed/simple; bh=aid97Yjimc76nz+M6o0QWk1KtiDp95Qtk/akmNNnZ3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i7WO5/PYVX8LHdtM4oQS+dr9FwWCV5fKeeN9/fpsOkMFol2hrYUjK3EPgmzpYpza0CpI72uVRH2DxckO6Qnvg1+ojVxCB0o4iojXhBDLnVb09ODxemCbZW7EivvJvjGFC/5gFlIgELWEyU3pXCMGOPWi6jeo9IhENnwy886BuHA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H8PBul1g; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H8PBul1g" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49cd4ba9f68so43012545e9.1 for ; Mon, 21 Sep 2026 07:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790002204; x=1790607004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qdwj3z7uTqgFd/9Tfs5y2p+1zT+FzwY0f8o+/81CJMs=; b=H8PBul1gog+1gzpTDxIrNVKB5K54pqG6vF5ZOD7G7ooAU5DeSJEP0a4k46YMZ5t6e0 qroWpraGfT9X8CSnGRrxRpEXsZ6ITnA0ylYlaplVZG+zgsQ40tygeef7IiZXriPm34dY wfpAVnIcDy2TdqqDgVDpphaTbQH3ttQHrYegpsgusyyEygzR2/sTlJChWkvvmX8Yuc5p t/Tx4S69pKxk+4EhhMdE0camoxwmDAsfA5j9ppMaMIg9h4JRtIcr+DD3rLnJ67dvMk0W s07j0OZ1TFsfJ1emK2NCQBveJGnyQJq9H04+oVtGRiLeADAXqp+Z6f4NOtPj1XmqPRUp KPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790002204; x=1790607004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Qdwj3z7uTqgFd/9Tfs5y2p+1zT+FzwY0f8o+/81CJMs=; b=COI443vsPtc9bFaj8PYWZkBM6o1x1g+YbHhnrDtjOxrFMQV0XO/kjo018CMCQ0QjSL ZF7zw6+owtTx+H24NYQMF2Lg3z1abwlAILjfxUdC/Kg6K9dHapqX8ekV4BBvk+HR0n3s zAwljqzaI5oVOdf4kydkHwBAkQcTb41zFPGDbUd3BAXUZvrLagPCCfXElE/xC0GJipIa FsK/8zsOj5Sb6v82/IrmD8BTemT9aco+eS4gzVW7G6CHK3X+7qQTvhxjoLi3XqLdLn15 8ea1gX1NF4ebUvrIhzs+FDxZ7DwEZrJ4cuc5q+knCrHJnWD+iO99A76BN5aRWTRte7cz tX5g== X-Forwarded-Encrypted: i=1; AKwUvBwHHStsOqZvB84R38y0xdKA5++pBh87JtPZ9XKJc89AJUAR9CKovRvhNhrmS8cgPG7xl6y0p7+bNqEGeBo=@vger.kernel.org X-Gm-Message-State: AFuF++lDWNqhlsscqPvdDlBkVjOKzKUcemUhYZG4ci1DMm9vd2lDmaG+ bN6oxPl6pk6vXTHYFl6hwDzyl/ZvFIlRUR+zq0W84UcUQrjMNeVlJ2PR X-Gm-Gg: AYBFou1PPiHD+8Xnc19Wh8n6N4azd0W0lv4UtPorDYwl5l2fNwQrTGerYJTZog7/2pR CpwdoC5GzkLNnPZ/o+lPE3LdZQIg5DyyqxFdfMwpIL1pFCYWHYbEExxWVCnPva02OpdsDLhbe1W 4a+liYDEClwaizCQhx1WCcrhrcroqGsM64lE5qo9xSc1hJ4dtdFd/hOUZ+wqBtM6zZEBVnWUJ3k ZAqyLi+DNlcjo66OW871Ift3VrOejHIi5AfFlSfHZt1nbnWosSViEeHNSoO8sd7FrLz+I50IIkQ XPOy8nCnLDwoWooL4YWgO8e5/JYFtGj0H9JmAvDDjiICza2l8EqIuStYXXIR6FAf56XbngiESKa BXt5XEUo7BoL84XZY8L2kZdWn0LftWfLmOjSmz+SY2vbCmJhLBUI6W/f/sVkTIiE7qjrCMS7khy 9IKjNngiyMdEKxcOmNJd97s+sOiP1rapk/CNVE8OXcyaJ8XGdLPWa8khAv7SHHY4hKrPjaJnFIO 6T5mPAWOA== X-Received: by 2002:a05:600c:3ba0:b0:49e:73d3:78ab with SMTP id 5b1f17b1804b1-49fc55adc12mr192320725e9.0.1790002203622; Mon, 21 Sep 2026 07:50:03 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49fcd8bc15esm191595725e9.1.2026.09.21.07.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 07:50:03 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Bryan O'Donoghue" , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, Conor Dooley Subject: [PATCH v3 1/3] dt-bindings: embedded-controller: add Lenovo Yoga Slim 7x Gen 11 EC Date: Mon, 21 Sep 2026 16:49:51 +0200 Message-ID: <20260921144953.15113-2-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260921144953.15113-1-okerixx@gmail.com> References: <20260921144953.15113-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Document the Compal embedded controller found on the Lenovo Yoga Slim 7x Gen 11, a Qualcomm Snapdragon X2 Elite (glymur) laptop. It sits on I2C at address 0x70 and is distinct from the Qualcomm reference EC that the reference designs place at 0x76. Signed-off-by: Oleg Keri Acked-by: Conor Dooley --- .../lenovo,yoga-slim7x-gen11-ec.yaml | 56 +++++++++++++++++++ MAINTAINERS | 8 +++ 2 files changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/embedded-controller/l= enovo,yoga-slim7x-gen11-ec.yaml diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,y= oga-slim7x-gen11-ec.yaml b/Documentation/devicetree/bindings/embedded-contr= oller/lenovo,yoga-slim7x-gen11-ec.yaml new file mode 100644 index 000000000000..37337de86b0b --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-sli= m7x-gen11-ec.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/lenovo,yoga-slim7x-= gen11-ec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lenovo Yoga Slim 7x Gen 11 Embedded Controller + +maintainers: + - Oleg Keri + +description: + The Lenovo Yoga Slim 7x Gen 11, a Qualcomm Snapdragon X2 Elite (glymur) + laptop, has a Compal embedded controller on I2C. It reports board + thermistors, battery cell voltages and CPU fan speed, and drives the + keyboard backlight. + + This controller is not the Qualcomm reference EC that the Snapdragon + reference designs place at address 0x76; it speaks a different command + set and answers at 0x70. + +properties: + compatible: + const: lenovo,yoga-slim7x-gen11-ec + + reg: + const: 0x70 + + interrupts: + maxItems: 1 + description: + The controller pulses this line while it has events queued. + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@70 { + compatible =3D "lenovo,yoga-slim7x-gen11-ec"; + reg =3D <0x70>; + + interrupts-extended =3D <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index be096be5fff6..11d459c17caf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14966,6 +14966,14 @@ S: Maintained F: Documentation/ABI/testing/sysfs-driver-lenovo-yb9-kbdock F: drivers/platform/x86/lenovo/yb9-kbdock.c =20 +LENOVO YOGA SLIM 7X GEN 11 EMBEDDED CONTROLLER DRIVER +M: Oleg Keri +L: linux-arm-msm@vger.kernel.org +S: Maintained +F: Documentation/ABI/testing/sysfs-driver-lenovo-yoga-slim7x-gen11-ec +F: Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-slim7= x-gen11-ec.yaml +F: drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c + LETSKETCH HID TABLET DRIVER M: Hans de Goede L: linux-input@vger.kernel.org --=20 2.55.0 From nobody Fri Sep 25 21:02:39 2026 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798C51CAA92 for ; Mon, 21 Sep 2026 14:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790002210; cv=none; b=IaQh8lAys4+JU14brw2A9NiAV45fhXp3B5ZWudqyEcUv4gvwz1I4AoFpbvr29jkdlu8geKzNhoxdkc6MVT9oeDJ4g/MmgYeSCbjwATm4WHYaLax5wNz5jHlDZJSescQQYEr6l9UyhhX253g9smxRwYO+816voMbf0LByOBgY1Yk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790002210; c=relaxed/simple; bh=YrYAWuBiwUYQJaVEkCcg/YTf65ZcRDA3qH/JwxZvzLI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XqCtKD3pyUt0aeMrFpzqieALftI0TYdEinJBmRfBZPdCQnO9AbIpeiuzZRUAv5fvctkfxBk6xZLBXNBYq+qNW7CRBKmF32kFHs9VWKjnYwa9JlnNdkC0Q0S0YBBVWYW7/ogkZsMdDLPrBo5cJIhGgsMF3wDWvVDH31FFFF1VrfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=llaoTv+F; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="llaoTv+F" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e6c0fce17so15990325e9.1 for ; Mon, 21 Sep 2026 07:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790002205; x=1790607005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MNKzz2egOdx0L0dOvsQ/5J+VnXb12T5yzXbZzUnZiDc=; b=llaoTv+FVfNnkEWTtjcji87FjwCmvZ2/5PWBTl81CtpHxxjo7SALzGhIo08kaN41kA 9oVTTeXtK/pHxPMHkCoRO94qZJJ5hPWXh1fBGeadgAIWGheA6c7hKtcoiDeSXXcrsp4O rUsoLCn4Ox+SBlx1XcW4kltHJBi0fNcbjrDb+KnIxW5cQO6aSJxv7UF/HLgfctmgx9Pp JG6eKomJCZ0dOncg8Fvsy573bBilCZwpuz6gx5C1vtg9I6Qx5YPS0yi4b/mUW2vZRQ1X oegh/ol4mAWh4+9nqeF5G+61psEzrKtRP+fTj+IvVuDCDav4FeYXB2TOzq/4YTXoCD7m T1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790002205; x=1790607005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MNKzz2egOdx0L0dOvsQ/5J+VnXb12T5yzXbZzUnZiDc=; b=FRNWetZlFD8DLRWPrJ+cVZLDsYJHTTC8DlYDYHUT88604MazWEr8MIXDs8zCSefnSP HMrfB9vSCtoS1JKtlu8rmQ62cf8pyqHNMdTgf/CWk4wCzdJA9yxFWo5vxebf9jM6xCf4 F2y7293/IaPhJDpFHoe5xJHxewWDjxDNY0NbhPXfs4yEieZpRTmEGhxzWWHCTh5rhqUH GhQzc+6tbAHt8+Sfna1XefD2musNGC0SNKUOoXX/JBlxIEZElQkIKkUGxa+uB/t9mC5H 9z7WcVc7+BMl7cFC8PQlt5WjWAz6PPyn85J8ooS7NNVfNWNTe/9avfZHBf0pS27clMdp udyg== X-Forwarded-Encrypted: i=1; AKwUvBwha1gsaBJtYy4fmO5BFLhIMEsnxwaH2Hi+RXZpG5OP7mgNASMez3cuG2iICX8vP6Ijy8dymWf6BGtTBzY=@vger.kernel.org X-Gm-Message-State: AFuF++kv6iWB2Qk299EZYbcF7S3geMoRY4igOIpZHcU67A8ngkuQ7GBS N+clyiOi9hkMfBEtX/FJZzxZcRQCsG/419jGfke9IMWRHS8lRxWfLKOl X-Gm-Gg: AYBFou0i7UzwW9Wu+4w7e6tKEmntYprGFTY0RssL3irUdoH+ghjv2DqwPrvQI2SngTL 1dDBx+Q27q+dtuD0GRskiPBzXyDUbBPkRLW7ffN9MsPwx4a4WZE/Ad62gnmpXVLbgq6TsyTs2q0 0mPpg8rjHcQVO4Iyl6yXqSMzzsineelnB/XcHZsUvpqqwQ3+44Y0Ac/fYfseVudkz87kerOEMkV x3HJutwg7+sAN9i/EFqYNr/sdsI8m4pPS3tjqnfe8LjRjgXwlSNYZlfoHVZYkFfdPOVX47Ok+lI itk1q5BoYRHQuhaocwNby3MKkCBJ+WjyUJ4kLWQ7wrjO1GC0xXswI2Zc4mUjwuxOFm/EUQOAuW1 6isOVS0yaQAMI++2u451OKXwVObmbRpIhox9BFYBXjDUvyN8brgpD7qT4cy7AfcHvvZ/pc0yR0o q6o5comzy+EOzblM+dh68rgYTwxaW9TR7qCYTjvtBDypx1EygaM2CnIntr5OIa7lNSFzblXAF2+ VqS/N5VnQ== X-Received: by 2002:a05:600c:4e48:b0:49e:6bce:b0f9 with SMTP id 5b1f17b1804b1-49fc574f4d7mr146721745e9.16.1790002204627; Mon, 21 Sep 2026 07:50:04 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49fcd8bc15esm191595725e9.1.2026.09.21.07.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 07:50:04 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Bryan O'Donoghue" , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH v3 2/3] platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver Date: Mon, 21 Sep 2026 16:49:52 +0200 Message-ID: <20260921144953.15113-3-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260921144953.15113-1-okerixx@gmail.com> References: <20260921144953.15113-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Lenovo Yoga Slim 7x Gen 11 (Qualcomm glymur / Snapdragon X2 Elite) carries a Compal EF06 embedded controller on I2C at address 0x70. The platform firmware describes it as an ACPI GenericSerialBus region, but the machine boots from device tree, so nothing otherwise talks to it. Commands are exchanged with two raw I2C block transfers: a 7 byte write to register 0x02 carrying the command and up to six arguments, then a 6 byte read of register 0x01 for the result, with a short delay in between before the result register is valid. The EC offers no way to match a result to its command; the delay is the one the vendor ACPI code uses, and the one value that lives in a mailbox shared with other EC activity, the cell voltages, is validated against a signature and retried. Expose what the EC offers that the rest of the kernel does not already provide: - five board thermistors as hwmon temperature channels. These are charger, CPU voltage regulator, 5 V rail and ambient sensors, not die sensors, and read considerably cooler than tsens - the four battery cell voltages, which live in a banked mailbox shared with other EC activity; readings are validated against a signature and retried, and cached briefly so that all four channels come from one coherent sample - CPU fan speed in RPM - the keyboard backlight as an LED, off/low/high - Fn-lock as a read/write sysfs attribute, matching the ideapad-laptop interface. The EC reports Fn+Esc as an event but keeps no state of its own, so the driver owns the bit and toggles it on the key - the mic-mute and airplane-mode keys as KEY_MICMUTE and KEY_RFKILL. These reach the host only as EC events; they are not on the keyboard's HID interface and have no GPIO of their own The EC signals pending events on a dedicated line, and keeps pulsing it until they are read - so the queue must be drained completely on every interrupt, including codes this driver ignores. Leaving one behind makes the controller pulse indefinitely. Fan speed is reported but not controlled. The EC accepts a manual setpoint, however it enforces no thermal floor over it: with the fan pinned at roughly 2000 RPM under full load the SoC rose from 69 to 91 degrees in 30 seconds without the EC ever overriding. Exposing pwm1_enable or fan1_target would therefore let userspace overheat the machine, so neither is implemented. Note this is the Gen 11 machine specifically. Its EC differs from the Qualcomm reference EC that the reference designs place at address 0x76, which is not populated here, and so EC_QCOM_HAMOA does not drive it. Signed-off-by: Oleg Keri --- .../sysfs-driver-lenovo-yoga-slim7x-gen11-ec | 21 + drivers/platform/arm64/Kconfig | 23 + drivers/platform/arm64/Makefile | 1 + .../arm64/lenovo-yoga-slim7x-gen11-ec.c | 653 ++++++++++++++++++ 4 files changed, 698 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-lenovo-yoga-slim= 7x-gen11-ec create mode 100644 drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c diff --git a/Documentation/ABI/testing/sysfs-driver-lenovo-yoga-slim7x-gen1= 1-ec b/Documentation/ABI/testing/sysfs-driver-lenovo-yoga-slim7x-gen11-ec new file mode 100644 index 000000000000..c8ab554ad452 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-driver-lenovo-yoga-slim7x-gen11-ec @@ -0,0 +1,21 @@ +What: /sys/bus/i2c/devices/*/fn_lock +Date: August 2026 +KernelVersion: 7.3 +Contact: Oleg Keri +Description: + Control fn-lock mode. + + * 1 -> Switched On + * 0 -> Switched Off + + When switched on, the function keys act as F1..F12 and the + multimedia functions require the Fn modifier. + + The embedded controller reports the Fn+Esc key as an event but + keeps no state of its own, so this attribute is the state: the + driver toggles it when the key is pressed, and writing it takes + effect immediately. + + For example:: + + # echo "0" > /sys/bus/i2c/devices/9-0070/fn_lock diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig index e32e01b2a9bd..7581432e69b0 100644 --- a/drivers/platform/arm64/Kconfig +++ b/drivers/platform/arm64/Kconfig @@ -90,6 +90,29 @@ config EC_LENOVO_THINKPAD_T14S =20 Say M or Y here to include this support. =20 +config EC_LENOVO_YOGA_SLIM7X_GEN11 + tristate "Lenovo Yoga Slim 7x Gen 11 Embedded Controller driver" + depends on ARCH_QCOM || COMPILE_TEST + depends on I2C + depends on INPUT + depends on HWMON + select NEW_LEDS + select LEDS_CLASS + help + Say Y here to enable the EC driver for the (Snapdragon X2 Elite, + glymur-based) Lenovo Yoga Slim 7x Gen 11 laptop. The EC provides + thermistors, battery cell voltages and CPU fan speed as hwmon + channels, and the keyboard backlight as an LED. + + This is the Gen 11 (glymur) machine specifically. Its EC is a Compal + design at i2c address 0x70 and speaks a different protocol from the + Qualcomm reference EC that the reference designs place at 0x76, so + EC_QCOM_HAMOA does not drive it - and conversely this driver does not + cover the X1E-based Yoga Slim 7x Gen 9. + + To compile this driver as a module, choose M here: the module will + be called lenovo-yoga-slim7x-gen11-ec. + config EC_QCOM_HAMOA tristate "Embedded Controller driver for Qualcomm Hamoa/Glymur reference = devices" depends on ARCH_QCOM || COMPILE_TEST diff --git a/drivers/platform/arm64/Makefile b/drivers/platform/arm64/Makef= ile index 7681be4a46e9..605cca4d42a9 100644 --- a/drivers/platform/arm64/Makefile +++ b/drivers/platform/arm64/Makefile @@ -9,4 +9,5 @@ obj-$(CONFIG_EC_ACER_ASPIRE1) +=3D acer-aspire1-ec.o obj-$(CONFIG_EC_HUAWEI_GAOKUN) +=3D huawei-gaokun-ec.o obj-$(CONFIG_EC_LENOVO_YOGA_C630) +=3D lenovo-yoga-c630.o obj-$(CONFIG_EC_LENOVO_THINKPAD_T14S) +=3D lenovo-thinkpad-t14s.o +obj-$(CONFIG_EC_LENOVO_YOGA_SLIM7X_GEN11) +=3D lenovo-yoga-slim7x-gen11-ec= .o obj-$(CONFIG_EC_QCOM_HAMOA) +=3D qcom-hamoa-ec.o diff --git a/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c b/drivers= /platform/arm64/lenovo-yoga-slim7x-gen11-ec.c new file mode 100644 index 000000000000..c8c7928475b7 --- /dev/null +++ b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c @@ -0,0 +1,653 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define YOGA_EC_BLOCK_READ 0x01 +#define YOGA_EC_BLOCK_WRITE 0x02 +#define YOGA_EC_RESP_LEN 6 +#define YOGA_EC_REQ_LEN 7 + +#define YOGA_EC_CMD_RAM_READ 0xb0 +#define YOGA_EC_CMD_RAM_WRITE 0xb1 +#define YOGA_EC_CMD_BANK_READ 0xb4 +#define YOGA_EC_CMD_FAN 0x46 +#define YOGA_EC_FAN_GET_SPEED 0x81 + +#define YOGA_EC_CMD_EVENT 0x84 +#define YOGA_EC_EVT_MAX_DRAIN 64 +#define YOGA_EC_EVT_FN_LOCK 0x0f +#define YOGA_EC_EVT_MIC_MUTE 0x18 +#define YOGA_EC_EVT_FLIGHT_MODE 0x19 + +#define YOGA_EC_SCUK 0x1c +#define YOGA_EC_SCUK_FN_LOCK BIT(7) +#define YOGA_EC_SCUK_FN_LOCK_IND BIT(5) +#define YOGA_EC_SCUK_FN_LOCK_MASK (YOGA_EC_SCUK_FN_LOCK | YOGA_EC_SCUK_FN_= LOCK_IND) + +#define YOGA_EC_KBLT 0x03 +#define YOGA_EC_KBLT_LEVEL GENMASK(1, 0) +#define YOGA_EC_KBLT_AUTO 3 +#define YOGA_EC_KBLT_MAX 2 + +#define YOGA_EC_TEMP_FIRST 0x12 +#define YOGA_EC_NUM_TEMP 6 +#define YOGA_EC_TEMP_MAX 120 + +#define YOGA_EC_CELL_BANK 0x0b +#define YOGA_EC_CELL_SIG_LO 0x02 +#define YOGA_EC_CELL_SIG_HI 0x0c +#define YOGA_EC_CELL_FIRST 0x04 +#define YOGA_EC_NUM_CELL 4 +#define YOGA_EC_CELL_MIN_MV 2000 +#define YOGA_EC_CELL_MAX_MV 5000 +#define YOGA_EC_CELL_TRIES 10 + +#define YOGA_EC_CACHE (2 * HZ) +#define YOGA_EC_STALE (10 * HZ) + +struct yoga_ec { + struct i2c_client *client; + /* serializes all EC access */ + struct mutex lock; + unsigned long temp_present; + unsigned long cell_read_at; + u16 cell[YOGA_EC_NUM_CELL]; + bool cell_cached; + struct led_classdev kbd_led; + u8 kblt_level; + bool kblt_restore; + struct input_dev *keys; +}; + +static int yoga_ec_command(struct yoga_ec *ec, u8 cmd, u8 arg0, u8 arg1, + u8 resp[YOGA_EC_RESP_LEN]) +{ + u8 req[YOGA_EC_REQ_LEN] =3D { cmd, arg0, arg1 }; + int ret; + + ret =3D i2c_smbus_write_i2c_block_data(ec->client, YOGA_EC_BLOCK_WRITE, + sizeof(req), req); + if (ret < 0) + return ret; + + usleep_range(2000, 3000); + + ret =3D i2c_smbus_read_i2c_block_data(ec->client, YOGA_EC_BLOCK_READ, + YOGA_EC_RESP_LEN, resp); + if (ret < 0) + return ret; + if (ret !=3D YOGA_EC_RESP_LEN) + return -EIO; + + return 0; +} + +static int yoga_ec_ram_read(struct yoga_ec *ec, u8 addr, u8 *val) +{ + u8 resp[YOGA_EC_RESP_LEN]; + int ret; + + ret =3D yoga_ec_command(ec, YOGA_EC_CMD_RAM_READ, addr, 0, resp); + if (ret) + return ret; + + *val =3D resp[0]; + return 0; +} + +static int yoga_ec_bank_read(struct yoga_ec *ec, u8 bank, u8 addr, u8 *val) +{ + u8 resp[YOGA_EC_RESP_LEN]; + int ret; + + ret =3D yoga_ec_command(ec, YOGA_EC_CMD_BANK_READ, bank, addr, resp); + if (ret) + return ret; + + *val =3D resp[0]; + return 0; +} + +static int yoga_ec_ram_write(struct yoga_ec *ec, u8 addr, u8 val) +{ + u8 resp[YOGA_EC_RESP_LEN]; + + return yoga_ec_command(ec, YOGA_EC_CMD_RAM_WRITE, addr, val, resp); +} + +static int yoga_ec_fan_read(struct yoga_ec *ec, long *rpm) +{ + u8 resp[YOGA_EC_RESP_LEN]; + int ret; + + ret =3D yoga_ec_command(ec, YOGA_EC_CMD_FAN, YOGA_EC_FAN_GET_SPEED, 0, + resp); + if (ret) + return ret; + + *rpm =3D resp[0] * 100; + return 0; +} + +static int yoga_ec_refresh_cells(struct yoga_ec *ec) +{ + unsigned int try; + int ret; + + if (ec->cell_cached && + time_before(jiffies, ec->cell_read_at + YOGA_EC_CACHE)) + return 0; + + for (try =3D 0; try < YOGA_EC_CELL_TRIES; try++) { + u16 cell[YOGA_EC_NUM_CELL]; + u8 sig[3]; + unsigned int i; + bool ok =3D true; + + ret =3D yoga_ec_bank_read(ec, YOGA_EC_CELL_BANK, + YOGA_EC_CELL_SIG_LO, &sig[0]); + if (!ret) + ret =3D yoga_ec_bank_read(ec, YOGA_EC_CELL_BANK, + YOGA_EC_CELL_SIG_LO + 1, &sig[1]); + if (!ret) + ret =3D yoga_ec_bank_read(ec, YOGA_EC_CELL_BANK, + YOGA_EC_CELL_SIG_HI, &sig[2]); + if (ret) + return ret; + + if (sig[0] !=3D 0x01 || sig[1] !=3D 0x01 || sig[2] !=3D 0x03) + continue; + + for (i =3D 0; i < YOGA_EC_NUM_CELL; i++) { + u8 lsb, msb; + + ret =3D yoga_ec_bank_read(ec, YOGA_EC_CELL_BANK, + YOGA_EC_CELL_FIRST + i * 2, &lsb); + if (!ret) + ret =3D yoga_ec_bank_read(ec, YOGA_EC_CELL_BANK, + YOGA_EC_CELL_FIRST + i * 2 + 1, + &msb); + if (ret) + return ret; + + cell[i] =3D lsb | (msb << 8); + if (cell[i] < YOGA_EC_CELL_MIN_MV || + cell[i] > YOGA_EC_CELL_MAX_MV) + ok =3D false; + } + + if (!ok) + continue; + + memcpy(ec->cell, cell, sizeof(cell)); + ec->cell_cached =3D true; + ec->cell_read_at =3D jiffies; + + return 0; + } + + if (ec->cell_cached && + time_before(jiffies, ec->cell_read_at + YOGA_EC_STALE)) + return 0; + + return -EAGAIN; +} + +static umode_t yoga_ec_is_visible(const void *drvdata, + enum hwmon_sensor_types type, + u32 attr, int channel) +{ + const struct yoga_ec *ec =3D drvdata; + + switch (type) { + case hwmon_temp: + if (!(ec->temp_present & BIT(channel))) + return 0; + return 0444; + case hwmon_in: + return 0444; + case hwmon_fan: + return 0444; + default: + return 0; + } +} + +static int yoga_ec_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *val) +{ + struct yoga_ec *ec =3D dev_get_drvdata(dev); + int ret; + u8 raw; + + guard(mutex)(&ec->lock); + + switch (type) { + case hwmon_temp: + ret =3D yoga_ec_ram_read(ec, YOGA_EC_TEMP_FIRST + channel, &raw); + if (ret) + return ret; + if (!raw) + return -ENODATA; + if (raw > YOGA_EC_TEMP_MAX) + return -EIO; + *val =3D raw * 1000; + return 0; + case hwmon_in: + ret =3D yoga_ec_refresh_cells(ec); + if (ret) + return ret; + *val =3D ec->cell[channel]; + return 0; + case hwmon_fan: + return yoga_ec_fan_read(ec, val); + default: + return -EOPNOTSUPP; + } +} + +static const char * const yoga_ec_temp_labels[YOGA_EC_NUM_TEMP] =3D { + "Charger A", + "CPU VR", + "5V rail", + "Ambient", + "Charger B", + "Thermistor 6", +}; + +static const char * const yoga_ec_cell_labels[YOGA_EC_NUM_CELL] =3D { + "Cell 1", "Cell 2", "Cell 3", "Cell 4", +}; + +static int yoga_ec_read_string(struct device *dev, enum hwmon_sensor_types= type, + u32 attr, int channel, const char **str) +{ + switch (type) { + case hwmon_temp: + *str =3D yoga_ec_temp_labels[channel]; + return 0; + case hwmon_in: + *str =3D yoga_ec_cell_labels[channel]; + return 0; + case hwmon_fan: + *str =3D "CPU fan"; + return 0; + default: + return -EOPNOTSUPP; + } +} + +static enum led_brightness yoga_ec_kbd_led_get(struct led_classdev *led) +{ + struct yoga_ec *ec =3D container_of(led, struct yoga_ec, kbd_led); + u8 raw; + + guard(mutex)(&ec->lock); + + if (yoga_ec_ram_read(ec, YOGA_EC_KBLT, &raw)) + return 0; + + raw =3D FIELD_GET(YOGA_EC_KBLT_LEVEL, raw); + + if (raw =3D=3D YOGA_EC_KBLT_AUTO) + return YOGA_EC_KBLT_MAX; + + return raw; +} + +static int yoga_ec_kbd_led_level(struct yoga_ec *ec, u8 level, u8 *old) +{ + u8 raw; + int ret; + + ret =3D yoga_ec_ram_read(ec, YOGA_EC_KBLT, &raw); + if (ret) + return ret; + + if (old) + *old =3D FIELD_GET(YOGA_EC_KBLT_LEVEL, raw); + + raw &=3D ~YOGA_EC_KBLT_LEVEL; + raw |=3D FIELD_PREP(YOGA_EC_KBLT_LEVEL, level); + + return yoga_ec_ram_write(ec, YOGA_EC_KBLT, raw); +} + +static int yoga_ec_kbd_led_set(struct led_classdev *led, + enum led_brightness brightness) +{ + struct yoga_ec *ec =3D container_of(led, struct yoga_ec, kbd_led); + + guard(mutex)(&ec->lock); + + return yoga_ec_kbd_led_level(ec, brightness, NULL); +} + +static const struct hwmon_ops yoga_ec_hwmon_ops =3D { + .is_visible =3D yoga_ec_is_visible, + .read =3D yoga_ec_read, + .read_string =3D yoga_ec_read_string, +}; + +static const struct hwmon_channel_info * const yoga_ec_hwmon_info[] =3D { + HWMON_CHANNEL_INFO(in, + HWMON_I_INPUT | HWMON_I_LABEL, + HWMON_I_INPUT | HWMON_I_LABEL, + HWMON_I_INPUT | HWMON_I_LABEL, + HWMON_I_INPUT | HWMON_I_LABEL), + HWMON_CHANNEL_INFO(temp, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL), + HWMON_CHANNEL_INFO(fan, + HWMON_F_INPUT | HWMON_F_LABEL), + NULL +}; + +static const struct hwmon_chip_info yoga_ec_chip_info =3D { + .ops =3D &yoga_ec_hwmon_ops, + .info =3D yoga_ec_hwmon_info, +}; + +static int yoga_ec_fn_lock_toggle(struct yoga_ec *ec) +{ + u8 raw; + int ret; + + ret =3D yoga_ec_ram_read(ec, YOGA_EC_SCUK, &raw); + if (ret) + return ret; + + if (raw & YOGA_EC_SCUK_FN_LOCK) + raw &=3D ~YOGA_EC_SCUK_FN_LOCK_MASK; + else + raw |=3D YOGA_EC_SCUK_FN_LOCK_MASK; + + return yoga_ec_ram_write(ec, YOGA_EC_SCUK, raw); +} + +static void yoga_ec_report_key(struct yoga_ec *ec, unsigned int code) +{ + if (!ec->keys) + return; + + input_report_key(ec->keys, code, 1); + input_sync(ec->keys); + input_report_key(ec->keys, code, 0); + input_sync(ec->keys); +} + +static irqreturn_t yoga_ec_irq(int irq, void *data) +{ + struct yoga_ec *ec =3D data; + unsigned int i; + + guard(mutex)(&ec->lock); + + for (i =3D 0; i < YOGA_EC_EVT_MAX_DRAIN; i++) { + u8 resp[YOGA_EC_RESP_LEN]; + + if (yoga_ec_command(ec, YOGA_EC_CMD_EVENT, 0, 0, resp)) + break; + if (!resp[0]) + break; + + switch (resp[0]) { + case YOGA_EC_EVT_FN_LOCK: + yoga_ec_fn_lock_toggle(ec); + break; + case YOGA_EC_EVT_MIC_MUTE: + yoga_ec_report_key(ec, KEY_MICMUTE); + break; + case YOGA_EC_EVT_FLIGHT_MODE: + yoga_ec_report_key(ec, KEY_RFKILL); + break; + default: + break; + } + } + + return IRQ_HANDLED; +} + +static void yoga_ec_register_keys(struct yoga_ec *ec) +{ + struct device *dev =3D &ec->client->dev; + struct input_dev *input; + int ret; + + input =3D devm_input_allocate_device(dev); + if (!input) { + dev_warn(dev, "no memory for the hotkey device\n"); + return; + } + + input->name =3D "Lenovo Yoga Slim 7x hotkeys"; + input->phys =3D "lenovo-yoga-slim7x-gen11-ec/input0"; + input->id.bustype =3D BUS_I2C; + input_set_capability(input, EV_KEY, KEY_MICMUTE); + input_set_capability(input, EV_KEY, KEY_RFKILL); + + ret =3D input_register_device(input); + if (ret) { + dev_warn(dev, "cannot register the hotkey device: %d\n", ret); + return; + } + + ec->keys =3D input; +} + +static ssize_t fn_lock_show(struct device *dev, struct device_attribute *a= ttr, + char *buf) +{ + struct yoga_ec *ec =3D dev_get_drvdata(dev); + u8 raw; + int ret; + + scoped_guard(mutex, &ec->lock) + ret =3D yoga_ec_ram_read(ec, YOGA_EC_SCUK, &raw); + + if (ret) + return ret; + + return sysfs_emit(buf, "%u\n", !!(raw & YOGA_EC_SCUK_FN_LOCK)); +} + +static ssize_t fn_lock_store(struct device *dev, struct device_attribute *= attr, + const char *buf, size_t count) +{ + struct yoga_ec *ec =3D dev_get_drvdata(dev); + bool enable; + u8 raw; + int ret; + + ret =3D kstrtobool(buf, &enable); + if (ret) + return ret; + + guard(mutex)(&ec->lock); + + ret =3D yoga_ec_ram_read(ec, YOGA_EC_SCUK, &raw); + if (ret) + return ret; + + if (enable) + raw |=3D YOGA_EC_SCUK_FN_LOCK_MASK; + else + raw &=3D ~YOGA_EC_SCUK_FN_LOCK_MASK; + + ret =3D yoga_ec_ram_write(ec, YOGA_EC_SCUK, raw); + if (ret) + return ret; + + return count; +} +static DEVICE_ATTR_RW(fn_lock); + +static struct attribute *yoga_ec_attrs[] =3D { + &dev_attr_fn_lock.attr, + NULL +}; +ATTRIBUTE_GROUPS(yoga_ec); + +static int yoga_ec_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct device *hwmon; + struct yoga_ec *ec; + unsigned int i; + int ret; + + if (!i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_I2C_BLOCK)) + return dev_err_probe(dev, -ENODEV, + "adapter does not support SMBus block transfers\n"); + + ec =3D devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL); + if (!ec) + return -ENOMEM; + + ec->client =3D client; + i2c_set_clientdata(client, ec); + + ret =3D devm_mutex_init(dev, &ec->lock); + if (ret) + return ret; + + for (i =3D 0; i < YOGA_EC_NUM_TEMP; i++) { + u8 raw; + + ret =3D yoga_ec_ram_read(ec, YOGA_EC_TEMP_FIRST + i, &raw); + if (ret) + return dev_err_probe(dev, ret, + "failed to read thermistor %u\n", i); + + if (raw > 0 && raw <=3D YOGA_EC_TEMP_MAX) + ec->temp_present |=3D BIT(i); + } + + if (!ec->temp_present) + return dev_err_probe(dev, -ENODEV, + "no thermistor reported a usable value\n"); + + dev_dbg(dev, "thermistors present: %#lx\n", ec->temp_present); + + hwmon =3D devm_hwmon_device_register_with_info(dev, "yoga_slim7x_ec", ec, + &yoga_ec_chip_info, NULL); + if (IS_ERR(hwmon)) + return PTR_ERR(hwmon); + + ec->kbd_led.name =3D "platform::kbd_backlight"; + ec->kbd_led.max_brightness =3D YOGA_EC_KBLT_MAX; + ec->kbd_led.brightness_get =3D yoga_ec_kbd_led_get; + ec->kbd_led.brightness_set_blocking =3D yoga_ec_kbd_led_set; + + ret =3D devm_led_classdev_register(dev, &ec->kbd_led); + if (ret) + return dev_err_probe(dev, ret, + "failed to register keyboard backlight\n"); + + if (client->irq) { + yoga_ec_register_keys(ec); + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + yoga_ec_irq, IRQF_ONESHOT, + "lenovo-yoga-slim7x-gen11-ec", ec); + if (ret) + return dev_err_probe(dev, ret, "cannot request the EC interrupt\n"); + + scoped_guard(mutex, &ec->lock) { + unsigned int i; + + for (i =3D 0; i < YOGA_EC_EVT_MAX_DRAIN; i++) { + u8 resp[YOGA_EC_RESP_LEN]; + + if (yoga_ec_command(ec, YOGA_EC_CMD_EVENT, 0, 0, resp)) + break; + if (!resp[0]) + break; + } + } + } + + return 0; +} + +static int yoga_ec_suspend(struct device *dev) +{ + struct yoga_ec *ec =3D dev_get_drvdata(dev); + + guard(mutex)(&ec->lock); + ec->kblt_restore =3D !yoga_ec_kbd_led_level(ec, 0, &ec->kblt_level); + + return 0; +} + +static int yoga_ec_resume(struct device *dev) +{ + struct yoga_ec *ec =3D dev_get_drvdata(dev); + + guard(mutex)(&ec->lock); + ec->cell_cached =3D false; + + if (ec->kblt_restore) { + ec->kblt_restore =3D false; + yoga_ec_kbd_led_level(ec, ec->kblt_level, NULL); + } + + return 0; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(yoga_ec_pm_ops, yoga_ec_suspend, yoga_ec_r= esume); + +static const struct of_device_id yoga_ec_of_match[] =3D { + { .compatible =3D "lenovo,yoga-slim7x-gen11-ec" }, + { } +}; +MODULE_DEVICE_TABLE(of, yoga_ec_of_match); + +static const struct i2c_device_id yoga_ec_i2c_id[] =3D { + { "yoga-slim7x-gen11-ec" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, yoga_ec_i2c_id); + +static struct i2c_driver yoga_ec_driver =3D { + .driver =3D { + .name =3D "lenovo-yoga-slim7x-gen11-ec", + .of_match_table =3D yoga_ec_of_match, + .dev_groups =3D yoga_ec_groups, + .pm =3D pm_sleep_ptr(&yoga_ec_pm_ops), + }, + .probe =3D yoga_ec_probe, + .id_table =3D yoga_ec_i2c_id, +}; +module_i2c_driver(yoga_ec_driver); + +MODULE_AUTHOR("Oleg Keri "); +MODULE_DESCRIPTION("Lenovo Yoga Slim 7x Gen 11 embedded controller"); +MODULE_LICENSE("GPL"); --=20 2.55.0 From nobody Fri Sep 25 21:02:39 2026 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793534AAC5F for ; Mon, 21 Sep 2026 14:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790002209; cv=none; b=OPnuFpyIE0CTrNDxyntPzTt/8NxdKa2QzB+eiW1Opj6btob0O+UuN15w20VmnqJSJ+X3Di5/mwxd4BS4FkfAxd+om/nsGTN1Ka2EpFXU868mzfhh+E75L1tGFMoTztnR8svvaMK8ywchcKBOORwom/lZ5tO/NPoEul73Rc2F2Ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790002209; c=relaxed/simple; bh=gQp5P6A4HKZPmr2RXt5nnsqu1turFNqjNRfQGzceh+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bGkJMKp3NnMa9G1/snGwqUxQF9wzCZqOH8vpvbpHKRizB7+aXxeIUePH/GzSUvUEkQQdZLhLyAON4GZcjN/kD/5LIP9mH78lb+KdYz+pmo1Fucz8VBybLl6hAAAUsY14HSOBd0FC8p48RvD6XJ7jST10WC76qVyp9A8x5PfNBBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M1l6QMZl; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M1l6QMZl" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49d1fb0cf5eso22074085e9.3 for ; Mon, 21 Sep 2026 07:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790002206; x=1790607006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/eycLZYI0OnWON4y4DQc42djuKTXBLKJTdaLEQ0NYzI=; b=M1l6QMZlJJ5OBCcXf03tRRdMPH1cHn9uWdZSCVQnYfrqzEOgMctZqG7bT9gpR3rnh/ jWKVXR+egPc4mmsrnoDVGIEbdW62poaSZAijxmgZqqtNeKwsIZC70UcO9vJraAonk3up 3SRQbPINez22DWc+3ooNL9bZvUpr7kchGr595QhalcUa8uuCCuTETJXypbksWa+2rY0j t5QIooTPHYEgAYxseUhv4+Nzs6T4eJ5rzizXJ8tniK6odNhzqTNjead5ZaGFoG4B+Y4w Dr+PC0kbnn4OT0NXTConNFNP5foW3E3Z1meDHyToimIFzejow5CItn6zqNzTTzEN6rzw 8yHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790002206; x=1790607006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/eycLZYI0OnWON4y4DQc42djuKTXBLKJTdaLEQ0NYzI=; b=LokC9dZWfaOO84Y3V9fuQHlmt2/l1WOlbuJSX7yUQujH74SddzUHtZ0iEkZ3TsZqHq UI1E+gNW5W6fRAGKcgXltH46HJCn3Ew7ria+LVGfuaiCiicrTpYm8LwFULtbFuB4xpus hSILWYEAlWhxpgGHsxamENNwH8exhU2tynNveNJ+mIV9GryLgaAh3IFDFyk7lPTZ5VhH xCL7fKwoE9TBYcf0jzAdLNyrzzPTv0YVo7O9LQKEKz7tbLa/POIwUsM7puQdWs9h2AM0 JSmxaYFVT9IfshIfDontj4fcyxKQNGFxEt+C7HDTm9xACsc449uqRA18W0DuLMx8Ln2I Lfzw== X-Forwarded-Encrypted: i=1; AKwUvBxifRZac8V77YKBlwGWSlmmKVi7cbxEfmKLPeZgIr/DGPe/Bn7MHwJpQjMre6EXKtl/1KGY0E66ELagDlI=@vger.kernel.org X-Gm-Message-State: AFuF++mLD7hmseuvbVVyE03m4nFvBk8PxHjQE/0slrY4V1EP8iIih3Xp yrgKs1/dmrOA2HxHaRaZSCsbf8HNnwlR5/3SgMCOe6bsNn0oK6mhmiOw X-Gm-Gg: AYBFou3B1u5w7E301+vUD0Rjzi06a6egEKQUgWa6NKY/lGAwTrzp+RKLvjWiLJaqrfu VrwLtgwRU8fyZ6yRTK1p6EurIkis1LN1M+tCSnSSdd+5/0DS/09AHmGUgsx3uKKtlZbzZzTe5K6 NsurZ4dSL/hilq0Ot/SBTN5VlLsg2Yqe5RwvjCnVPwo8cFgUSfNTIIwuGa5+yvSXtubtFw0y9hs Ao/x4fEUu+4tww7laBGdKnK3XJLB3dmoWGGnUD8hEj5mOaejSFrIzdd8e5gh9KjFfQ4XJPYuxxn YPxwhLeo5OTc765EtZT3oddfnkZSwdXagia9DD7WH4GNgEitT2kzsB83a/2Mh7e2ZRCQAxfi68A TsrIce/Gy0hjNTXkEW/r+/lZFTxywgzJC+yPlWNOxiS84mVgkwLTF1MUqgRezlAASNch17G3Pc9 2+1pTyowhifx//mheT08Wn40jknCt4VAbrRAE7QocNk59S7WhaMFOfgPrdppN1/enwbYs65ViZ1 56mJEp3YOo= X-Received: by 2002:a05:600c:3e19:b0:49f:bd3c:bc1a with SMTP id 5b1f17b1804b1-49fc572f27fmr153111575e9.21.1790002205475; Mon, 21 Sep 2026 07:50:05 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49fcd8bc15esm191595725e9.1.2026.09.21.07.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 07:50:05 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Bryan O'Donoghue" , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH v3 3/3] arm64: dts: qcom: glymur-lenovo-yoga-slim7x: add the embedded controller Date: Mon, 21 Sep 2026 16:49:53 +0200 Message-ID: <20260921144953.15113-4-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260921144953.15113-1-okerixx@gmail.com> References: <20260921144953.15113-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Describe the Compal embedded controller on I2C at address 0x70. It provides the board thermistors, the battery cell voltages and the CPU fan speed, and drives the keyboard backlight. Its interrupt line is TLMM gpio66, falling edge, for which the file already carries a pin state. That state leaves the pin without a bias. gpio66 has no external pull and floats when the EC is not driving it, which shows up as a steady stream of spurious edges; the vendor ACPI tables describe the same pin as GpioInt(Edge, ActiveLow, Exclusive, PullUp). Enable the pull-up. Signed-off-by: Oleg Keri Reviewed-by: Konrad Dybcio --- .../boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/= arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts index 769f195c99d9..bc840fd8e458 100644 --- a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts @@ -659,7 +659,15 @@ &i2c9 { =20 status =3D "okay"; =20 - /* EC @ 0x70, irq =3D TLMM 66 */ + embedded-controller@70 { + compatible =3D "lenovo,yoga-slim7x-gen11-ec"; + reg =3D <0x70>; + + interrupts-extended =3D <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-0 =3D <&ec_int_n_default>; + pinctrl-names =3D "default"; + }; }; =20 &lpass_vamacro { @@ -990,7 +998,7 @@ reset-n-pins { ec_int_n_default: ec-int-n-state { pins =3D "gpio66"; function =3D "gpio"; - bias-disable; + bias-pull-up; }; =20 kybd_default: kybd-default-state { base-commit: 5c4d4169604b335c38bbc79bc1fc03042981fc6f --=20 2.55.0