From nobody Thu Sep 24 17:10:36 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2093E40E4; Tue, 22 Sep 2026 04:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790051130; cv=none; b=aKTxWFUoCvg6N6agUNTKP9V4h4vJvYnDwTmCPKZaWeDhlRtG3O5gY0Ne3AMSI/K3F1B+kc7gaPQfXL3aggyNRD3xl/vf1xsV5Z5rkE8NPZdgysqT/xG5iroW8TbDv/e5M8+ZDkuhl8AkxlF5dxFYKm2U6cfhgi1IbFZcVHKk9/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790051130; c=relaxed/simple; bh=rtL8raeYHXSU7iIgRCPrHdPdZ7ajpqxEZmEQdDSM0/I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=PlEswWlmBFJBVubWpYahs9n+kNdWcR7i+FUAakWchrCi1HY5ArGi6lxZZEndZNltj5hXfks9zTT4p2jJ913Cm+beDGGNOdpQ61+pdvos6d+toKSVUzQ7PcJIIeo69a8IFzo14RdB6DjJAAF93jlEFqOysTXw0bZM1PIvxItQjyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d4X0knqh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d4X0knqh" Received: by smtp.kernel.org (Postfix) with ESMTPS id CA711C2BCF6; Tue, 22 Sep 2026 04:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790051129; bh=rtL8raeYHXSU7iIgRCPrHdPdZ7ajpqxEZmEQdDSM0/I=; h=From:Date:Subject:To:Cc:Reply-To:From; b=d4X0knqh5bRYQ6P2cMU8A3Sk0hVv6kNCbHsNN/sASlTYMiP/AIKZRzSMGgQWqPjR7 o/AXhpW8A6VHIAjuf4e5Hc98wkEflb6o66ZNjENIUOssclBkrKYM9mdXDaWY/MJyQy 2TSdPEMqhPwvC3giwMtm6jIpgL7LjSJ5t+iRjUGwVyGxGF8PnPvmm0dssTEILfn3Ew i2xo/h5zqqcB9Hg1F2HXYhLQqxLFtWD43aLGY1eWKqzHXmMBcz0SK/YsaGA6oFaz1G +tWXDGOLyD4JrcctY9K2odGullsgNIuvin8USqL4deGBEarCRTXLZEXi/vSFKwo57l PuFOQAEHX337Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99BE2C982FE; Tue, 22 Sep 2026 04:25:29 +0000 (UTC) From: Quanye Yang via B4 Relay Date: Mon, 21 Sep 2026 21:25:25 -0700 Subject: [PATCH] RDMA/rtrs-clt: Don't WARN on unexpected info-response opcode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260921-rtrs-fix-rtrs-clt-info-rsp-done-v1-1-c64281ed97c0@proton.me> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yWN0QrCMAxFf2Xk2cBW64b+iuxB03SLSDuSKsLYv 1vd2z1wOWcFYxU2uDQrKL/FJKcK3aEBmm9pYpRQGVzr+vbsOtSihlE++6BnQUkxo9qCISfGI5+ CHygG8h6qZVGu73/hOu5sr/uDqfy0sG1f8/XGQIMAAAA= X-Change-ID: 20260921-rtrs-fix-rtrs-clt-info-rsp-done-3e5d47cfdc44 To: "Md. Haris Iqbal" , Jack Wang , Jason Gunthorpe , Leon Romanovsky , Danil Kipnis Cc: Jack Wang , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Farhad Alemi X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790051127; l=1693; i=quanyeyang@proton.me; s=20260801; h=from:subject:message-id; bh=1KtQGLrqV0R0BQYhjKlwQ9iV1kF2blHHJCa4XJfhFPc=; b=ztk4kocaZeI6fjK/rweVJJ/ecZOd3V+zNTHRFeettpbcrCQOCnLC3kdBa6EOTVP1Y7vILPb13 wLIczuZIP+JAxqzdXPZwYSpMY8GAzeR5Ty+WljWvBnhFKJYgqcBHGHy X-Developer-Key: i=quanyeyang@proton.me; a=ed25519; pk=9L9FrcvzMgxPaBRU6XV0EnqTgjDqVO596rQKSZ9qZoY= X-Endpoint-Received: by B4 Relay for quanyeyang@proton.me/20260801 with auth_id=963 X-Original-From: Quanye Yang Reply-To: quanyeyang@proton.me From: Quanye Yang The info-response receive is posted for a SEND. The completion opcode comes from the peer, so RDMA WRITE with Immediate is a legal WC on that WQE even though it violates the RTRS handshake. WARN_ON(wc->opcode !=3D IB_WC_RECV) treats that peer-controlled field as an internal invariant and panics with panic_on_warn. Treat a non-SEND completion as a handshake failure: log it and keep the existing CONNECTING_ERR cleanup. Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality") Reported-by: Farhad Alemi Link: https://lore.kernel.org/linux-rdma/CA+0ovCge-K+hcGHXZ4R3Ww5+cg159uxHB= eVbKeUSLBRSMT8OWA@mail.gmail.com Signed-off-by: Quanye Yang Reviewed-by: Jack Wang --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ul= p/rtrs/rtrs-clt.c index eac38b57b00d..3c23c27725a5 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -2514,7 +2514,12 @@ static void rtrs_clt_info_rsp_done(struct ib_cq *cq,= struct ib_wc *wc) ib_wc_status_msg(wc->status)); goto out; } - WARN_ON(wc->opcode !=3D IB_WC_RECV); + if (wc->opcode !=3D IB_WC_RECV) { + rtrs_err(clt_path->clt, + "Path info response has unexpected opcode %d\n", + wc->opcode); + goto out; + } =20 if (wc->byte_len < sizeof(*msg)) { rtrs_err(clt_path->clt, "Path info response is malformed: size %d\n", --- base-commit: 93f51579e7df248780214094418f205253383cc5 change-id: 20260921-rtrs-fix-rtrs-clt-info-rsp-done-3e5d47cfdc44 Best regards, -- =20 Quanye Yang