From nobody Thu Sep 24 18:43:31 2026 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D94215A85A for ; Tue, 22 Sep 2026 00:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035606; cv=none; b=Om4nq61vo/uGwEYO8lZiplVH6FmKiqxHcyecCKO7HVwo+5tOPUi2DdknUuIVcYVzFKVxMEHaC2948EcEKen/iPgZJSIXGwWdkSYkigQrGufzZrI3ATg2vYPu8gVGcW/TheDfOuc2wyTecIrYXj+xRzEB8DzS6f3D25b4dtMcLJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035606; c=relaxed/simple; bh=5k9VLU6OvtrGZi0gO1yZy16OfwqfrZmQwujeqIifWv0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WRujug1a+uvjnFPS2hWDvjARcagKnnBLPJIwTDQ4XtPy8mh+n1159HNlPWiGZFKbKajOApODQV/MN1tbMgmLDszbJsRZW4XbuLkf1WalJxQMNNEBrd4BSmym1kBDyyAqivBOwKYyZu1ZcJ00i8ty2up1wCYLPXYrKf/gWoOuv9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pbQMCghw; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pbQMCghw" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-6b1b1d128a0so218925eaf.0 for ; Mon, 21 Sep 2026 17:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790035603; x=1790640403; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=M4cUR/bgVx/Ef4Tc/Iqux+0dgmZ5BenjLrR4X+eBZEU=; b=pbQMCghwx775sfAFPnsvmRs0g6TDSRTGlRw2ADjh6A0dOLXoXIZgW9BiELmqATO17h MzV01OiR5dd9zZc00gYmfEDuDGEj/59+w0wfDSoEqWdN6nSJN902MNF1kuRKKb4g2G9o lPK9BSx8gJalKTetqlhcBYmxShB/xDxxnn0VVeA5JOP9VPZyZmgtC2/ALZ3KfXYnE71Y ESDrXXq5QRVwuN0+bBWG5ToL5WKqwfNSqYPunAw+NMTnGyyRudFvuO2TYGG28Z5FWWSQ 7dXg8lYacrAcBVfNd00a3Gx4H/aZzHwnHnhiCz5P/Lsjs/9tOka3ZxCNvfzjiydJgxut x/mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790035603; x=1790640403; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M4cUR/bgVx/Ef4Tc/Iqux+0dgmZ5BenjLrR4X+eBZEU=; b=ojk82PXKiXZ+13vQn40yZiT9TZtwJ9ULPS3SpJed4e0lwCmfKRPLPxgtBzS0N44ihf l1SlwXFRHrIblAMaCtLQ0dtd5mDomVhh/bZdoJk+JJ3FOADhFQx463bpuNU8bLEIQO0d QLM8wjRprVBViMnOJo9T6RxbOQhgiraS3VQC+dHQf/OgFHnpf8kj8/WyWgIOoUrMG9Kt LDedlxb+Y0mbdPaQC0B0wpQoaHPEN/6v7LaN13srGVH/WxgDDsX2VeyJR+yi5/c1E7GE IHJT2rAVgSxql+yqLPW3/3bmFzMN6yuNRdEzaCaW4ASlgStI4gd22eXwqCwWdyGJE9cc ymfg== X-Forwarded-Encrypted: i=1; AKwUvBzn7taHGQ6cWmEj9tMpqkCONN+cZ/CwbysEHlPgZ1blQi+hTm4a/a89b7/D1JMfZfS37hULPNXqWzwlsdY=@vger.kernel.org X-Gm-Message-State: AFuF++ktLD8xfB403m/bBMC4byfYD1Z/Xj23l4Rq3+tGIsDEIwcC8oub 3GDxGbV4HVRzihc6bsyanIqclcuv5qw1soUw0yWXKXHWka8RG3y+X12J X-Gm-Gg: AYBFou3rGTh9v5byMEKC52GP21axZFpulolvE2hkNAvodKsx6HNfgHDsTVw/Hy1ejkn XtCNEE2gAzfA+k6vZ/QemciAduAvPGaLL2O0QyCXNwRH9Nl9rTgy0xDFl/m8yR7AQZgFg1hrw0t mITAhy29a/HBjaUOinbgr9LsLSjrJnOksT+qGCVjFXWWIy0lwO2Rw/xUkc5tEim/6gdLWFtjm6H t3/E1aPhM3yDfa6iCAD7pMHF/uaE0PHowfvcv+DyTtdZCazZoIPMoft/6gEEVTMvs/kOBuP271d HpcaeTjMbDM7/bYqu7VdFYJ3rIMC8RzuuE0EQ3Ge1o8Nwg7m2Pl2mrVTSoNV41pAqxWOSMysYkY P7G32y+yrRB4Iuelk+gU/43VVZKALWrujECM7yOH4Vp40yjxa7o6rejd3ZfccKyvxA+BxL6FSUQ 0KWZHhpnYTdFKfr+mHykgDwBJNt7aGbvfSI1HwztfW3Zz96DCFM5Fs1pfXzUvcq1CxWLpFHWPcU LJOsAgV8EBHJ0MIGoLk7xdVwJUdWw50Zno5QLm/bU6QAif30dDjNgFmiCV4lAK+AH2tGlnlD2zH f1NRSyfkj8AFs90+rZCXVhz/T7ObsEuNEJuVxVGYAK3zQoKbBXkH0bFKn/kHlKfsoMMbXJTTjzk 6+MKv6NIc/vtWrz6LhSr8 X-Received: by 2002:a05:6820:179b:b0:6b1:a146:1297 with SMTP id 006d021491bc7-6d157d893ddmr1041226eaf.1.1790035603341; Mon, 21 Sep 2026 17:06:43 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-48f7280cf14sm801683fac.13.2026.09.21.17.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 17:06:42 -0700 (PDT) From: James Hilliard Date: Mon, 21 Sep 2026 18:06:30 -0600 Subject: [PATCH v9 1/5] dt-bindings: pwm: allwinner: add h616 pwm compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260921-h616-pwm-v8-v9-1-37bec6201ff5@gmail.com> References: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> In-Reply-To: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Richard Genoud , Philipp Zabel , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , John Stultz , Joao Schim , bigunclemax@gmail.com, linux-clk@vger.kernel.org, James Hilliard , Conor Dooley X-Mailer: b4 0.15.2 From: Richard Genoud The Allwinner H616 PWM block differs from the A10 and H6 blocks, but it uses the same input clocks as H6, so extend the existing Allwinner PWM binding. The block has six channels that can generate PWM waveforms. Each channel also has a bypass that turns its output into a clock suitable for consumers such as the integrated X-Powers AC200 or AC300 Ethernet PHY. Require #clock-cells for H616 because the bypass clocks are part of its provider interface, while continuing to disallow the property for the older variants. Acked-by: Conor Dooley Signed-off-by: Richard Genoud Signed-off-by: James Hilliard --- .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 33 ++++++++++++++++++= +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.= yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml index 1197858e431f..3b1819c8630c 100644 --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml @@ -14,6 +14,13 @@ properties: "#pwm-cells": const: 3 =20 + "#clock-cells": + const: 1 + description: + The cell selects the PWM channel whose hardware bypass path is expor= ted + as a clock. Its rate follows the selected shared pair source and div= ider; + the PWM period, duty-cycle and polarity logic is bypassed. + compatible: oneOf: - const: allwinner,sun4i-a10-pwm @@ -36,6 +43,7 @@ properties: - const: allwinner,sun50i-h5-pwm - const: allwinner,sun5i-a13-pwm - const: allwinner,sun50i-h6-pwm + - const: allwinner,sun50i-h616-pwm =20 reg: maxItems: 1 @@ -62,7 +70,9 @@ allOf: properties: compatible: contains: - const: allwinner,sun50i-h6-pwm + enum: + - allwinner,sun50i-h6-pwm + - allwinner,sun50i-h616-pwm =20 then: properties: @@ -83,6 +93,27 @@ allOf: clocks: maxItems: 1 =20 + - if: + properties: + compatible: + contains: + const: allwinner,sun50i-h616-pwm + + then: + properties: + clocks: + minItems: 2 + + clock-names: + minItems: 2 + + required: + - "#clock-cells" + + else: + properties: + "#clock-cells": false + required: - compatible - reg --=20 2.53.0 From nobody Thu Sep 24 18:43:31 2026 Received: from mail-oi2-f43.google.com (mail-oi2-f43.google.com [74.125.231.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB08226CFE for ; Tue, 22 Sep 2026 00:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035611; cv=none; b=CPTpfCQYJzI90gAHr71bz5IggKIgu44HiIE1XeSdx2q/g82/RtjHUPJ226cBszUVCXe9pRz7ijH8jHayFUk05gFEnkRyBKQuHdrhoMgOR41iKQz7NefL6kDwqKFqyRjRgjOpv2RQ0+MIDjtw41fWYDrbbTmtbYTIFyV2GaLJkxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035611; c=relaxed/simple; bh=NaP5go48DIg7ZP2vsh8v9L0+32c55LUSiW/3zQ6evCw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=psRB81IujV1o5rwLi2jGdG90II00u6kLj46u/5JbvDHcmJC6DS/4FA3rh/ItlD7qSPDV5xXSy7r/Y6MBpSX9fKZ0Ec/spWlzdVv0VF5hfkyij4wBOEMoe87A9cfLVex0MMidsqyI46lDqkMpKv+LUcheDpKV/sq4HAddnuqSaU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GvlA1Gv3; arc=none smtp.client-ip=74.125.231.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GvlA1Gv3" Received: by mail-oi2-f43.google.com with SMTP id 46e09a7af769-80032c08611so2204158a34.3 for ; Mon, 21 Sep 2026 17:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790035606; x=1790640406; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TmixJAuwq8ENbvDysNd8oI5Iik3FUsXX4Zkq+YJZJ3g=; b=GvlA1Gv3jE22W+wqMGvcvtzIZ9bMPHr5utZfPpAtQK6Xn4J6Scd6ZxBmTok1zsqrxc DFr1K/KjUfxXWau2kIWSQDkgP1PPP32y5PXIJ78umTOeQeVyQ5blrm9/7cKDn8fQhJK/ uoA44AV11+P2pp4AvGulPqxEzML8qIEVjBkw6X7l5sz5DgcZNb6fYqOE+gUK+2gX2jRW OqJY20lG7iXSGaA3Zeelf3gvKpZkoC93cY0SOkcy5PzgUbER9MDuGXx8cOpDGuDDjgpU pX3PuSRdCbcgmINc+lVIe0I0BTPTO+Zd27Bhf/1MlmAI2RJqTi1mGKhGLPV+ivCvtwpT G2wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790035606; x=1790640406; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TmixJAuwq8ENbvDysNd8oI5Iik3FUsXX4Zkq+YJZJ3g=; b=tIvrVwHLnC+njaT9KHoaqibwwaFDTiZ+CB+vOemOpq6fmKrHyoB2zvojPNHZG2ITNo EyPOfRBBkHLa13NvBy9nlkB3eIBfmvgB9IrvexJtVRLz3rMWUwQa9DSxRgaQhTNvSNE7 y/LEVWgI1ZXKMYIaJF/7sxaeMjxt06CcuN/DJ2MFfHG7kq6s+L1p3aPxJrm+XeWYONIE d3rCm1GOVBay+TYZIKXaTOzUgOLT+7psGHxOX5nxIiGUSNfkVnhKTWc+JiD23vt5sgwJ 44omFEkTXcA7Xex/i6ZRv+PT+jFyki2TomP2fA0suz+9GTMVZdLIR0STzkc4qtx4vV3e UuRg== X-Forwarded-Encrypted: i=1; AKwUvBxUiCjSY8xXIrJ1Gsk0zkRx7VVpKh7YTGR2W8bp4TSaGjpXJADDDLbW2fPNu4zOJNktQRjbfl9sKkeFn+A=@vger.kernel.org X-Gm-Message-State: AFuF++kO4UHKjw4a0YL95AQjNiwr7OnngUgWLI9910Q0tYS+/wJluQfj Bfg4pRO9kdiLqQwtWaW/BaSTzo5z1iC29IrTlj7+buwKqDVKPQjVkkJI X-Gm-Gg: AYBFou2/HgeOijv/UuUQqoMRhy2xwa/zwImUVvrIhvOwRL83zmBGxAZknc5ezDiKuty AF37EG03BYjsJCjNDCjXdeZfrjFkLDM/gtsqhGHVZLqJmNb0b5yAFbkWctdoZkva+A/qBfGXpDx X2SnWXExQi1Mrq+2FBaKlHQmV+/GPz1P4TSX4Gq0yRp/ifrXePwJsl2WJ+Yb94nj7tuH++wFrv/ GYlPB1AhiENdnBT6OtitP5mHrvxBIsj253+StLKPHjq15xDV5Zb5gSo30kYSjNyEfb/LxibGZrT fIGVTknh6GijY5krl2zglEA0zca/6/xd+F0j5scM6tgdkk1zXcp5HxGqzZZMXDdRd718fuECm9e 2IUkYxg7rBiURbyUeTCVl1ncSWisjqU8fzw8xNau8C0n9ak9kwHSRHUBoL070vmUjXRBf4HhHsO 0aFWgQazvYGVHfQHiz9x79YTaG1NE6Gv6UENEGslk5wdBCJHk0JvIG4W53MQq7elb7hn1CvrHwQ FPZMcdimEFmB/XZuA1Axz3nLMjLC+IosLsbXLJwcJ9MRjGXFYC3kL9FEqSPeitxVWEaxpnyfzJO zEluuTdRq8m0BccujzciwaD1T2TfSAOCF8srpWPVX/WCh+YWL5B7OlLOpTc9tmfBRur4c7CnUxa picj2CYdf5FuNeJauS/an X-Received: by 2002:a05:6820:f029:b0:6c9:80d8:a1f4 with SMTP id 006d021491bc7-6ca9cb5b1ffmr11821779eaf.49.1790035605893; Mon, 21 Sep 2026 17:06:45 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-48f7280cf14sm801683fac.13.2026.09.21.17.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 17:06:44 -0700 (PDT) From: James Hilliard Date: Mon, 21 Sep 2026 18:06:31 -0600 Subject: [PATCH v9 2/5] pwm: sun8i: Add H616 PWM support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260921-h616-pwm-v8-v9-2-37bec6201ff5@gmail.com> References: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> In-Reply-To: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Richard Genoud , Philipp Zabel , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , John Stultz , Joao Schim , bigunclemax@gmail.com, linux-clk@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 From: Richard Genoud Add waveform support for the six-channel Allwinner H616 PWM controller. Each pair of outputs shares a source mux, gate and power-of-two divider; each channel has its own prescaler and period/duty registers. Model the shared pair clocks in CCF and program the channel-local dividers directly. Protect the pair rate while a PWM is active. Also check the hardware enable bits before retuning or gating a pair, since firmware may have left an output running without a Linux consumer. Preserve such outputs until a consumer explicitly changes them; do not implement an unused-PWM sweep. Round period, duty and offset in the order required by the waveform API, including the hardware bypass path and the 65536-tick period boundary. Wait for pending period updates and quiesce the channel when changing its clock, prescaler, polarity or bypass mode. Live period updates additionally require PCLK to be faster than the PWM clock, as specified by the manual. Encode the channel register values during waveform conversion. Keep rate protection, safe quiescing and clock rollback in one preparation helper, leaving the write callback to apply the prepared values. Select candidates using one ordered comparison while retaining the bounded divider search. Pulse and coupled dead-zone modes cannot be represented by this API. Reject active unsupported modes, but clear dormant dead-zone configuration before programming an ordinary waveform. Allocate the fixed six-channel topology with the pwm_chip. Register the per-device clocks with managed helpers after deasserting reset. Acquire separate pair-clock consumer handles only while PWMs are requested, so internal clock references cannot prevent module removal. Use CCF's provider-owned handles for notifiers and rate readback, including readback of channels which have not been requested. Signed-off-by: Richard Genoud Co-developed-by: James Hilliard Signed-off-by: James Hilliard --- drivers/pwm/Kconfig | 11 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sun8i.c | 1080 +++++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 1092 insertions(+) diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 729776086879..d87d166e7836 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -748,6 +748,17 @@ config PWM_SUN4I To compile this driver as a module, choose M here: the module will be called pwm-sun4i. =20 +config PWM_SUN8I + tristate "Allwinner sun8i/sun50i PWM support" + depends on ARCH_SUNXI || COMPILE_TEST + depends on HAS_IOMEM && COMMON_CLK + help + PWM framework driver for Allwinner controllers whose channels share + paired source clocks. + + To compile this driver as a module, choose M here: the module + will be called pwm-sun8i. + config PWM_SUNPLUS tristate "Sunplus PWM support" depends on ARCH_SUNPLUS || COMPILE_TEST diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index 5630a521a7cf..9c922b1fd0b4 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -68,6 +68,7 @@ obj-$(CONFIG_PWM_STM32) +=3D pwm-stm32.o obj-$(CONFIG_PWM_STM32_LP) +=3D pwm-stm32-lp.o obj-$(CONFIG_PWM_STMPE) +=3D pwm-stmpe.o obj-$(CONFIG_PWM_SUN4I) +=3D pwm-sun4i.o +obj-$(CONFIG_PWM_SUN8I) +=3D pwm-sun8i.o obj-$(CONFIG_PWM_SUNPLUS) +=3D pwm-sunplus.o obj-$(CONFIG_PWM_TEGRA) +=3D pwm-tegra.o obj-$(CONFIG_PWM_TH1520) +=3D pwm_th1520.o diff --git a/drivers/pwm/pwm-sun8i.c b/drivers/pwm/pwm-sun8i.c new file mode 100644 index 000000000000..7e6c39815c18 --- /dev/null +++ b/drivers/pwm/pwm-sun8i.c @@ -0,0 +1,1080 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Driver for Allwinner sun8i Pulse Width Modulation Controller + * + * (C) Copyright 2025 Richard Genoud, Bootlin + * (C) Copyright 2026 James Hilliard + * + * Based on drivers/pwm/pwm-sun4i.c with Copyright: + * + * Copyright (C) 2014 Alexandre Belloni + * + * Channels are paired (0/1, 2/3, 4/5). Each pair shares a clock source and + * first prescaler (div_m), while each channel has its own second prescaler + * (div_k) and bypass path. + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define SUN8I_PWM_NPWM 6 +#define SUN8I_PWM_NPAIRS (SUN8I_PWM_NPWM / 2) + +/* PWMCC Pairs Clock Configuration Registers */ +#define SUN8I_PWM_PCCR(pair) (0x20 + ((pair) * 0x4)) +#define SUN8I_PWM_PCCR_SRC_SHIFT 7 +#define SUN8I_PWM_PCCR_SRC_MASK GENMASK(1, 0) +#define SUN8I_PWM_PCCR_GATE_BIT 4 +#define SUN8I_PWM_PCCR_GATE BIT(SUN8I_PWM_PCCR_GATE_BIT) +#define SUN8I_PWM_PCCR_BYPASS_BIT(chan) ((chan) % 2 + 5) +#define SUN8I_PWM_PCCR_DIV_M_SHIFT 0 +#define SUN8I_PWM_PCCR_DIV_M_WIDTH 4 + +/* PWM Enable Register */ +#define SUN8I_PWM_PER 0x40 +#define SUN8I_PWM_ENABLE(chan) BIT(chan) + +/* PWM Control Register */ +#define SUN8I_PWM_PCR(chan) (0x60 + (chan) * 0x20) +#define SUN8I_PWM_PCR_PRESCAL_K_MASK GENMASK(7, 0) +#define SUN8I_PWM_PCR_ACTIVE_STATE BIT(8) +#define SUN8I_PWM_PCR_MODE BIT(9) +#define SUN8I_PWM_PCR_PULSE_START BIT(10) +#define SUN8I_PWM_PCR_PERIOD_READY BIT(11) /* 0: ready, 1: busy */ +#define SUN8I_PWM_PCR_WAVEFORM_MASK (SUN8I_PWM_PCR_PRESCAL_K_MASK | \ + SUN8I_PWM_PCR_ACTIVE_STATE) + +/* PWM Period Register */ +#define SUN8I_PWM_PPR(chan) (0x64 + (chan) * 0x20) +#define SUN8I_PWM_PPR_PERIOD_MASK GENMASK(31, 16) +#define SUN8I_PWM_PPR_DUTY_MASK GENMASK(15, 0) +#define SUN8I_PWM_PPR_PERIOD_VALUE(reg) (FIELD_GET(SUN8I_PWM_PPR_PERIOD_MA= SK, reg) + 1) +#define SUN8I_PWM_PPR_DUTY_VALUE(reg) FIELD_GET(SUN8I_PWM_PPR_DUTY_MASK, r= eg) +#define SUN8I_PWM_PPR_PERIOD(prd) FIELD_PREP(SUN8I_PWM_PPR_PERIOD_MASK, (p= rd) - 1) +#define SUN8I_PWM_PPR_DUTY(dty) FIELD_PREP(SUN8I_PWM_PPR_DUTY_MASK, dty) +#define SUN8I_PWM_PPR_PERIOD_MAX (FIELD_MAX(SUN8I_PWM_PPR_PERIOD_MASK) + 1) + +/* PWM pair dead-zone control registers. */ +#define SUN8I_PWM_PDZCR(pair) (0x30 + ((pair) * 0x4)) +#define SUN8I_PWM_PDZCR_ENABLE BIT(0) + +#define SUN8I_PWM_PERIOD_READY_MARGIN_US 50 +#define SUN8I_PWM_PERIOD_READY_MIN_POLL_US 10 +#define SUN8I_PWM_PERIOD_READY_MAX_POLL_US 10000 +#define SUN8I_PWM_PERIOD_READY_POLL_COUNT 1024 + +#define SUN8I_PWM_PAIR_IDX(chan) ((chan) >> 1) + +/* + * Block diagram of the PWM clock controller: + * + * _____ ______ ________ + * OSC24M --->| | | | | | + * APB1 ----->| Mux |--->| Gate |--->| /div_m |-----> SUN8I_PWM_clock_src_= xy + * |_____| |______| |________| + * ________ + * | | + * +->| /div_k |---> SUN8I_PWM_clock_x + * | |________| + * | ______ + * | | | + * +-->| Gate |----> SUN8I_PWM_bypass_clock_x + * | |______| + * SUN8I_PWM_clock_src_xy ---+ ________ + * | | | + * +->| /div_k |---> SUN8I_PWM_clock_y + * | |________| + * | ______ + * | | | + * +-->| Gate |----> SUN8I_PWM_bypass_clock_y + * |______| + * + * NB: when the bypass is set, all the PWM logic is bypassed. + * So, the duty cycle and polarity can't be modified (we just have a clock= ). + * The bypass in PWM mode is used to achieve a 1/2 relative duty cycle wit= h the + * fastest clock. + * + */ + +/* /div_m is a power-of-two divider limited to /256. */ +static const struct clk_div_table sun8i_pwm_div_m_table[] =3D { + { .val =3D 0, .div =3D 1 }, + { .val =3D 1, .div =3D 2 }, + { .val =3D 2, .div =3D 4 }, + { .val =3D 3, .div =3D 8 }, + { .val =3D 4, .div =3D 16 }, + { .val =3D 5, .div =3D 32 }, + { .val =3D 6, .div =3D 64 }, + { .val =3D 7, .div =3D 128 }, + { .val =3D 8, .div =3D 256 }, + { /* sentinel */ } +}; + +struct sun8i_pwm_chip; + +struct sun8i_pwm_pair { + struct clk_mux mux; + struct clk_hw gate_hw; + struct clk_divider divider; + struct clk_hw *hw; + struct notifier_block rate_nb; + struct sun8i_pwm_chip *chip; + unsigned int index; +}; + +struct sun8i_pwm_channel { + /* Separate CCF consumer, held only from PWM request to free. */ + struct clk *pair_clk; + u64 pending_period_ns; + bool rate_exclusive; +}; + +struct sun8i_pwm_chip { + struct sun8i_pwm_pair pairs[SUN8I_PWM_NPAIRS]; + struct sun8i_pwm_channel channels[SUN8I_PWM_NPWM]; + struct clk *bus_clk; + void __iomem *base; + /* Protects shared registers and rate_exclusive. */ + spinlock_t lock; +}; + +struct sun8i_pwm_waveform { + u32 pcr; + u32 ppr; + u32 pair_rate; + bool enabled; + bool bypass_en; +}; + +static inline struct sun8i_pwm_chip *sun8i_pwm_from_chip(const struct pwm_= chip *chip) +{ + return pwmchip_get_drvdata(chip); +} + +static unsigned long sun8i_pwm_get_pair_rate(struct sun8i_pwm_chip *sun8i_= chip, + unsigned int idx) +{ + struct sun8i_pwm_pair *pair =3D &sun8i_chip->pairs[SUN8I_PWM_PAIR_IDX(idx= )]; + + /* Readback also runs on channels without a PWM request. */ + return clk_get_rate(pair->hw->clk); +} + +static inline u32 sun8i_pwm_readl(struct sun8i_pwm_chip *sun8i_chip, + unsigned long offset) +{ + return readl(sun8i_chip->base + offset); +} + +static inline void sun8i_pwm_writel(struct sun8i_pwm_chip *sun8i_chip, + u32 val, unsigned long offset) +{ + writel(val, sun8i_chip->base + offset); +} + +static void sun8i_pwm_set_bypass_locked(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx, bool enable) +{ + unsigned long reg_offset; + u32 val; + + lockdep_assert_held(&sun8i_chip->lock); + + reg_offset =3D SUN8I_PWM_PCCR(SUN8I_PWM_PAIR_IDX(idx)); + val =3D sun8i_pwm_readl(sun8i_chip, reg_offset); + if (enable) + val |=3D BIT(SUN8I_PWM_PCCR_BYPASS_BIT(idx)); + else + val &=3D ~BIT(SUN8I_PWM_PCCR_BYPASS_BIT(idx)); + + sun8i_pwm_writel(sun8i_chip, val, reg_offset); +} + +static void sun8i_pwm_set_enabled_locked(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx, bool enable) +{ + u32 val; + + lockdep_assert_held(&sun8i_chip->lock); + + val =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + if (enable) + val |=3D SUN8I_PWM_ENABLE(idx); + else + val &=3D ~SUN8I_PWM_ENABLE(idx); + sun8i_pwm_writel(sun8i_chip, val, SUN8I_PWM_PER); +} + +static bool +sun8i_pwm_channel_is_enabled_locked(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx) +{ + unsigned int pair =3D SUN8I_PWM_PAIR_IDX(idx); + u32 pccr, per; + + lockdep_assert_held(&sun8i_chip->lock); + + pccr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCCR(pair)); + per =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + + return (pccr & SUN8I_PWM_PCCR_GATE) && + (per & SUN8I_PWM_ENABLE(idx)); +} + +static u32 sun8i_pwm_pair_enable_mask(unsigned int pair) +{ + return GENMASK(pair * 2 + 1, pair * 2); +} + +static inline struct sun8i_pwm_pair * +sun8i_pwm_pair_from_gate_hw(struct clk_hw *hw) +{ + return container_of(hw, struct sun8i_pwm_pair, gate_hw); +} + +static int sun8i_pwm_pair_gate_enable(struct clk_hw *hw) +{ + struct sun8i_pwm_pair *pair =3D sun8i_pwm_pair_from_gate_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D pair->chip; + u32 pccr; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + pccr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCCR(pair->index)); + pccr |=3D SUN8I_PWM_PCCR_GATE; + sun8i_pwm_writel(sun8i_chip, pccr, SUN8I_PWM_PCCR(pair->index)); + + return 0; +} + +static void sun8i_pwm_pair_gate_disable(struct clk_hw *hw) +{ + struct sun8i_pwm_pair *pair =3D sun8i_pwm_pair_from_gate_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D pair->chip; + unsigned long reg =3D SUN8I_PWM_PCCR(pair->index); + u32 pccr, per; + + /* CCF counts do not include outputs awaiting firmware-state handoff. */ + guard(spinlock_irqsave)(&sun8i_chip->lock); + per =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + if (!(per & sun8i_pwm_pair_enable_mask(pair->index))) { + pccr =3D sun8i_pwm_readl(sun8i_chip, reg); + pccr &=3D ~SUN8I_PWM_PCCR_GATE; + sun8i_pwm_writel(sun8i_chip, pccr, reg); + } +} + +static int sun8i_pwm_pair_gate_is_enabled(struct clk_hw *hw) +{ + struct sun8i_pwm_pair *pair =3D sun8i_pwm_pair_from_gate_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D pair->chip; + unsigned long reg =3D SUN8I_PWM_PCCR(pair->index); + + guard(spinlock_irqsave)(&sun8i_chip->lock); + + return !!(sun8i_pwm_readl(sun8i_chip, reg) & SUN8I_PWM_PCCR_GATE); +} + +static const struct clk_ops sun8i_pwm_pair_gate_ops =3D { + .enable =3D sun8i_pwm_pair_gate_enable, + .disable =3D sun8i_pwm_pair_gate_disable, + .is_enabled =3D sun8i_pwm_pair_gate_is_enabled, +}; + +static int sun8i_pwm_pair_rate_notifier(struct notifier_block *nb, + unsigned long event, void *data) +{ + struct sun8i_pwm_pair *pair =3D + container_of(nb, struct sun8i_pwm_pair, rate_nb); + struct sun8i_pwm_chip *sun8i_chip =3D pair->chip; + bool active; + + if (event !=3D PRE_RATE_CHANGE) + return NOTIFY_DONE; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + active =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER) & + sun8i_pwm_pair_enable_mask(pair->index); + + return active ? NOTIFY_BAD : NOTIFY_OK; +} + +static void sun8i_pwm_put_rate(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx) +{ + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[idx]; + bool exclusive; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + exclusive =3D chan->rate_exclusive; + chan->rate_exclusive =3D false; + } + /* CCF takes the prepare mutex and may call back into this driver. */ + if (exclusive) + clk_rate_exclusive_put(chan->pair_clk); +} + +static int sun8i_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) +{ + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[pwm->hwpwm]; + unsigned int idx =3D pwm->hwpwm; + struct clk_hw *parent =3D sun8i_chip->pairs[SUN8I_PWM_PAIR_IDX(idx)].hw; + bool was_enabled; + int ret; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + was_enabled =3D + sun8i_pwm_channel_is_enabled_locked(sun8i_chip, idx); + } + + chan->pair_clk =3D clk_hw_get_clk(parent, NULL); + if (IS_ERR(chan->pair_clk)) { + ret =3D PTR_ERR(chan->pair_clk); + goto err_clear_clock; + } + + if (was_enabled) { + ret =3D clk_rate_exclusive_get(chan->pair_clk); + if (ret) + goto err_put_clock; + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + chan->rate_exclusive =3D true; + } + + ret =3D clk_prepare_enable(chan->pair_clk); + if (ret) { + sun8i_pwm_put_rate(sun8i_chip, idx); + goto err_put_clock; + } + + return 0; + +err_put_clock: + clk_put(chan->pair_clk); +err_clear_clock: + chan->pair_clk =3D NULL; + + return ret; +} + +static void sun8i_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) +{ + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[pwm->hwpwm]; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + sun8i_pwm_set_enabled_locked(sun8i_chip, pwm->hwpwm, false); + sun8i_pwm_set_bypass_locked(sun8i_chip, pwm->hwpwm, false); + } + + sun8i_pwm_put_rate(sun8i_chip, pwm->hwpwm); + clk_disable_unprepare(chan->pair_clk); + clk_put(chan->pair_clk); + chan->pair_clk =3D NULL; +} + +static int sun8i_pwm_read_waveform(struct pwm_chip *chip, + struct pwm_device *pwm, + void *_wfhw) +{ + struct sun8i_pwm_waveform *wfhw =3D _wfhw; + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + unsigned int pair =3D SUN8I_PWM_PAIR_IDX(pwm->hwpwm); + unsigned long pair_rate; + u32 pccr, pcr, pdzcr, per, ppr; + + pair_rate =3D sun8i_pwm_get_pair_rate(sun8i_chip, pwm->hwpwm); + if (pair_rate > U32_MAX) + return -ERANGE; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + pccr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCCR(pair)); + per =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + pcr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCR(pwm->hwpwm)); + ppr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PPR(pwm->hwpwm)); + pdzcr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PDZCR(pair)); + } + + *wfhw =3D (struct sun8i_pwm_waveform) { + .enabled =3D !!(pccr & SUN8I_PWM_PCCR_GATE) && + !!(per & SUN8I_PWM_ENABLE(pwm->hwpwm)), + .bypass_en =3D !!(pccr & + BIT(SUN8I_PWM_PCCR_BYPASS_BIT(pwm->hwpwm))), + .pcr =3D pcr & SUN8I_PWM_PCR_WAVEFORM_MASK, + .ppr =3D ppr, + .pair_rate =3D pair_rate, + }; + + /* The waveform API cannot describe coupled dead-zone or pulse mode. */ + if (wfhw->enabled && !wfhw->bypass_en && + ((pdzcr & SUN8I_PWM_PDZCR_ENABLE) || (pcr & SUN8I_PWM_PCR_MODE))) + return -EOPNOTSUPP; + + return 0; +} + +static u64 sun8i_pwm_ticks_to_ns(u32 ticks, u16 div_k, u32 pair_rate) +{ + return DIV_ROUND_UP_ULL(NSEC_PER_SEC * (u64)ticks * div_k, + pair_rate); +} + +static u64 sun8i_pwm_period_ns(const struct sun8i_pwm_waveform *wfhw) +{ + if (wfhw->bypass_en) + return DIV_ROUND_UP_ULL(NSEC_PER_SEC, wfhw->pair_rate); + + return sun8i_pwm_ticks_to_ns(SUN8I_PWM_PPR_PERIOD_VALUE(wfhw->ppr), + FIELD_GET(SUN8I_PWM_PCR_PRESCAL_K_MASK, wfhw->pcr) + 1, + wfhw->pair_rate); +} + +static void +__sun8i_pwm_round_waveform_fromhw(const struct sun8i_pwm_waveform *wfhw, + struct pwm_waveform *wf) +{ + u32 pair_rate =3D wfhw->pair_rate; + u32 period_ticks =3D SUN8I_PWM_PPR_PERIOD_VALUE(wfhw->ppr); + u32 duty_ticks =3D SUN8I_PWM_PPR_DUTY_VALUE(wfhw->ppr); + u16 div_k =3D FIELD_GET(SUN8I_PWM_PCR_PRESCAL_K_MASK, wfhw->pcr) + 1; + + wf->duty_offset_ns =3D 0; + + if (!wfhw->enabled || !pair_rate) { + wf->period_length_ns =3D 0; + wf->duty_length_ns =3D 0; + return; + } + + wf->period_length_ns =3D sun8i_pwm_period_ns(wfhw); + if (wfhw->bypass_en) { + wf->duty_length_ns =3D + DIV_ROUND_UP_ULL(NSEC_PER_SEC, + 2ULL * pair_rate); + return; + } + + duty_ticks =3D min(duty_ticks, period_ticks); + if (!(wfhw->pcr & SUN8I_PWM_PCR_ACTIVE_STATE)) { + /* Constant outputs have no edge and therefore no offset. */ + if (duty_ticks && duty_ticks < period_ticks) + wf->duty_offset_ns =3D + sun8i_pwm_ticks_to_ns(duty_ticks, div_k, pair_rate); + duty_ticks =3D period_ticks - duty_ticks; + } + wf->duty_length_ns =3D sun8i_pwm_ticks_to_ns(duty_ticks, div_k, pair_rate= ); +} + +static int sun8i_pwm_round_waveform_fromhw(struct pwm_chip *chip, + struct pwm_device *pwm, + const void *_wfhw, + struct pwm_waveform *wf) +{ + const struct sun8i_pwm_waveform *wfhw =3D _wfhw; + + __sun8i_pwm_round_waveform_fromhw(wfhw, wf); + + dev_dbg(pwmchip_parent(chip), + "pwm#%u: pair-rate=3D%u, pcr=3D%#x, ppr=3D%#x, bypass=3D%u -> %llu/%llu = [+%llu]\n", + pwm->hwpwm, wfhw->pair_rate, wfhw->pcr, wfhw->ppr, + wfhw->bypass_en, + wf->duty_length_ns, wf->period_length_ns, + wf->duty_offset_ns); + + return 0; +} + +static bool +sun8i_pwm_pair_rate_constrained(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx) +{ + unsigned int sibling =3D idx ^ 1; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + return sun8i_chip->channels[sibling].rate_exclusive || + sun8i_pwm_channel_is_enabled_locked(sun8i_chip, sibling); +} + +static int sun8i_pwm_clear_idle_deadzone(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx) +{ + unsigned int pair =3D SUN8I_PWM_PAIR_IDX(idx); + u32 pdzcr, per; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + pdzcr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PDZCR(pair)); + if (!(pdzcr & SUN8I_PWM_PDZCR_ENABLE)) + return 0; + + per =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + if (per & sun8i_pwm_pair_enable_mask(pair)) + return -EOPNOTSUPP; + + pdzcr &=3D ~SUN8I_PWM_PDZCR_ENABLE; + sun8i_pwm_writel(sun8i_chip, pdzcr, SUN8I_PWM_PDZCR(pair)); + + return 0; +} + +static u64 sun8i_pwm_max_period_ns(struct sun8i_pwm_chip *sun8i_chip, + unsigned int idx) +{ + unsigned long pair_rate; + u32 pcr; + u16 div_k; + + pair_rate =3D sun8i_pwm_get_pair_rate(sun8i_chip, idx); + if (!pair_rate || pair_rate > U32_MAX) + return 0; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + pcr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCR(idx)); + } + div_k =3D FIELD_GET(SUN8I_PWM_PCR_PRESCAL_K_MASK, pcr) + 1; + + return sun8i_pwm_ticks_to_ns(SUN8I_PWM_PPR_PERIOD_MAX, div_k, + pair_rate); +} + +static int sun8i_pwm_wait_period_ready(struct pwm_chip *chip, unsigned int= idx) +{ + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[idx]; + unsigned long poll_us; + u64 period_ns, timeout_us; + u32 val; + int ret; + + /* PPR contains the pending value, not necessarily the active period. */ + period_ns =3D chan->pending_period_ns; + if (!period_ns) + period_ns =3D sun8i_pwm_max_period_ns(sun8i_chip, idx); + timeout_us =3D DIV_ROUND_UP_ULL(period_ns, NSEC_PER_USEC) + + SUN8I_PWM_PERIOD_READY_MARGIN_US; + poll_us =3D clamp_t(u64, + DIV_ROUND_UP_ULL(timeout_us, + SUN8I_PWM_PERIOD_READY_POLL_COUNT), + SUN8I_PWM_PERIOD_READY_MIN_POLL_US, + SUN8I_PWM_PERIOD_READY_MAX_POLL_US); + + ret =3D readl_poll_timeout(sun8i_chip->base + SUN8I_PWM_PCR(idx), val, + !(val & SUN8I_PWM_PCR_PERIOD_READY), poll_us, + timeout_us); + if (!ret) + chan->pending_period_ns =3D 0; + else + dev_err_ratelimited(pwmchip_parent(chip), + "pwm#%u: update timeout after %llu us\n", + idx, timeout_us); + + return ret; +} + +/* + * Protect the rate and quiesce the output if a live update is unsafe. On + * failure restore the old clock before restarting an output we stopped. + * CCF operations must stay outside the register lock. + */ +static int sun8i_pwm_prepare_update(struct pwm_chip *chip, unsigned int id= x, + const struct sun8i_pwm_waveform *wfhw, + struct sun8i_pwm_waveform *old) +{ + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[idx]; + unsigned long rate, bus_rate; + bool had_exclusive, stop; + u32 pccr; + int ret, restore_ret; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + had_exclusive =3D chan->rate_exclusive; + + if (!had_exclusive) { + ret =3D clk_rate_exclusive_get(chan->pair_clk); + if (ret) + return ret; + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + chan->rate_exclusive =3D true; + } + + /* Sample the old rate only after excluding other rate changes. */ + rate =3D sun8i_pwm_get_pair_rate(sun8i_chip, idx); + if (!rate || rate > U32_MAX) { + ret =3D -ERANGE; + goto put_rate; + } + old->pair_rate =3D rate; + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + old->enabled =3D sun8i_pwm_channel_is_enabled_locked(sun8i_chip, idx); + pccr =3D sun8i_pwm_readl(sun8i_chip, + SUN8I_PWM_PCCR(SUN8I_PWM_PAIR_IDX(idx))); + old->bypass_en =3D !!(pccr & BIT(SUN8I_PWM_PCCR_BYPASS_BIT(idx))); + old->pcr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCR(idx)); + old->ppr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PPR(idx)); + } + + if (rate !=3D wfhw->pair_rate && + sun8i_pwm_pair_rate_constrained(sun8i_chip, idx)) { + ret =3D -EBUSY; + goto put_rate; + } + + /* Live PPR updates require unchanged configuration and a faster PCLK. */ + bus_rate =3D clk_get_rate(sun8i_chip->bus_clk); + stop =3D old->enabled && + (old->bypass_en !=3D wfhw->bypass_en || rate !=3D wfhw->pair_rate || + (!wfhw->bypass_en && + (((old->pcr ^ wfhw->pcr) & + (SUN8I_PWM_PCR_WAVEFORM_MASK | SUN8I_PWM_PCR_MODE)) || + bus_rate <=3D DIV_ROUND_UP_ULL(wfhw->pair_rate, + FIELD_GET(SUN8I_PWM_PCR_PRESCAL_K_MASK, wfhw->pcr) + 1)))); + if (stop) { + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + sun8i_pwm_set_enabled_locked(sun8i_chip, idx, false); + } + + if (rate =3D=3D wfhw->pair_rate) + return 0; + + ret =3D clk_set_rate(chan->pair_clk, wfhw->pair_rate); + if (!ret && sun8i_pwm_get_pair_rate(sun8i_chip, idx) =3D=3D wfhw->pair_ra= te) + return 0; + if (!ret) + ret =3D -EINVAL; + + if (sun8i_pwm_get_pair_rate(sun8i_chip, idx) !=3D rate) { + restore_ret =3D clk_set_rate(chan->pair_clk, rate); + if (restore_ret || sun8i_pwm_get_pair_rate(sun8i_chip, idx) !=3D rate) { + dev_err(pwmchip_parent(chip), + "pwm#%u: failed to restore pair clock rate %lu\n", + idx, rate); + goto put_rate; + } + } + if (stop) { + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + sun8i_pwm_set_enabled_locked(sun8i_chip, idx, true); + } +put_rate: + if (!had_exclusive) + sun8i_pwm_put_rate(sun8i_chip, idx); + + return ret; +} + +static int sun8i_pwm_write_waveform(struct pwm_chip *chip, + struct pwm_device *pwm, const void *_wfhw) +{ + const struct sun8i_pwm_waveform *wfhw =3D _wfhw; + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[pwm->hwpwm]; + struct sun8i_pwm_waveform old; + u64 old_ns =3D 0, new_ns; + u32 pcr; + int ret; + + if (!wfhw->enabled) { + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + sun8i_pwm_set_enabled_locked(sun8i_chip, pwm->hwpwm, false); + sun8i_pwm_set_bypass_locked(sun8i_chip, pwm->hwpwm, false); + } + sun8i_pwm_put_rate(sun8i_chip, pwm->hwpwm); + return 0; + } + + if (!wfhw->bypass_en) { + ret =3D sun8i_pwm_clear_idle_deadzone(sun8i_chip, pwm->hwpwm); + if (ret) + return ret; + ret =3D sun8i_pwm_wait_period_ready(chip, pwm->hwpwm); + if (ret) + return ret; + } + + ret =3D sun8i_pwm_prepare_update(chip, pwm->hwpwm, wfhw, &old); + if (ret) + return ret; + + if (!wfhw->bypass_en) { + /* Apply only waveform fields; never replay status or W1S bits. */ + pcr =3D old.pcr & ~(SUN8I_PWM_PCR_WAVEFORM_MASK | + SUN8I_PWM_PCR_MODE | SUN8I_PWM_PCR_PULSE_START | + SUN8I_PWM_PCR_PERIOD_READY); + sun8i_pwm_writel(sun8i_chip, pcr | wfhw->pcr, + SUN8I_PWM_PCR(pwm->hwpwm)); + + if (old.enabled && !old.bypass_en) + old_ns =3D sun8i_pwm_period_ns(&old); + new_ns =3D sun8i_pwm_period_ns(wfhw); + chan->pending_period_ns =3D max(old_ns, new_ns); + sun8i_pwm_writel(sun8i_chip, wfhw->ppr, SUN8I_PWM_PPR(pwm->hwpwm)); + } + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + sun8i_pwm_set_bypass_locked(sun8i_chip, pwm->hwpwm, wfhw->bypass_en); + sun8i_pwm_set_enabled_locked(sun8i_chip, pwm->hwpwm, true); + } + + return 0; +} + +struct sun8i_pwm_rounding { + const struct pwm_waveform *requested; + struct sun8i_pwm_waveform best; + struct pwm_waveform best_wf; + u32 current_pair_rate; + bool have_best; +}; + +static void +sun8i_pwm_choose_waveform(struct sun8i_pwm_rounding *rounding, + const struct sun8i_pwm_waveform *candidate) +{ + const struct pwm_waveform *requested =3D rounding->requested; + const struct pwm_waveform *best =3D &rounding->best_wf; + struct pwm_waveform wf; + bool better; + + __sun8i_pwm_round_waveform_fromhw(candidate, &wf); + /* A zero-duty, zero-offset cycle-mode candidate always exists. */ + if (wf.duty_length_ns > requested->duty_length_ns || + wf.duty_offset_ns > requested->duty_offset_ns) + return; + + if (!rounding->have_best) { + better =3D true; + } else if (wf.period_length_ns !=3D best->period_length_ns) { + /* Prefer the longest period below the request, else the shortest. */ + if (wf.period_length_ns > requested->period_length_ns) + better =3D wf.period_length_ns < best->period_length_ns; + else + better =3D best->period_length_ns > requested->period_length_ns || + wf.period_length_ns > best->period_length_ns; + } else if (wf.duty_length_ns !=3D best->duty_length_ns) { + better =3D wf.duty_length_ns > best->duty_length_ns; + } else if (wf.duty_offset_ns !=3D best->duty_offset_ns) { + better =3D wf.duty_offset_ns > best->duty_offset_ns; + } else { + /* Prefer the current pair rate when waveforms are equivalent. */ + better =3D candidate->pair_rate =3D=3D rounding->current_pair_rate && + rounding->best.pair_rate !=3D rounding->current_pair_rate; + } + if (!better) + return; + + rounding->best =3D *candidate; + rounding->best_wf =3D wf; + rounding->have_best =3D true; +} + +static struct sun8i_pwm_waveform +sun8i_pwm_round_cycle(const struct pwm_waveform *requested, u32 pair_rate, + u16 div_k) +{ + struct sun8i_pwm_waveform candidate =3D { + .enabled =3D true, + .pair_rate =3D pair_rate, + .pcr =3D FIELD_PREP(SUN8I_PWM_PCR_PRESCAL_K_MASK, div_k - 1), + }; + u64 denominator =3D NSEC_PER_SEC * (u64)div_k; + u64 duty_ticks, period_ticks; + u32 inactive_ticks; + + /* Floor division rounds down, except for the minimum one-tick period. */ + period_ticks =3D mul_u64_u64_div_u64(requested->period_length_ns, + pair_rate, denominator); + period_ticks =3D clamp_t(u64, period_ticks, 1, SUN8I_PWM_PPR_PERIOD_MAX); + duty_ticks =3D mul_u64_u64_div_u64(requested->duty_length_ns, + pair_rate, denominator); + duty_ticks =3D min(duty_ticks, period_ticks); + + /* + * Zero active ticks encode either constant level. For a toggling + * waveform, active-low mode places the rising edge after the inactive + * part, which is the only non-zero offset supported by the hardware. + */ + if (!duty_ticks) { + candidate.pcr |=3D SUN8I_PWM_PCR_ACTIVE_STATE; + } else if (duty_ticks =3D=3D period_ticks) { + duty_ticks =3D 0; + } else { + inactive_ticks =3D period_ticks - duty_ticks; + if (sun8i_pwm_ticks_to_ns(inactive_ticks, div_k, pair_rate) <=3D + requested->duty_offset_ns) + duty_ticks =3D inactive_ticks; + else + candidate.pcr |=3D SUN8I_PWM_PCR_ACTIVE_STATE; + } + + candidate.ppr =3D SUN8I_PWM_PPR_PERIOD(period_ticks) | + SUN8I_PWM_PPR_DUTY(duty_ticks); + + return candidate; +} + +static void +sun8i_pwm_consider_pair_rate(struct sun8i_pwm_rounding *rounding, u32 pair= _rate) +{ + struct sun8i_pwm_waveform candidate; + + for (unsigned int div_k =3D 1; div_k <=3D 256; div_k++) { + candidate =3D sun8i_pwm_round_cycle(rounding->requested, pair_rate, div_= k); + sun8i_pwm_choose_waveform(rounding, &candidate); + } + + candidate =3D (struct sun8i_pwm_waveform) { + .pair_rate =3D pair_rate, + .enabled =3D true, + .bypass_en =3D true, + }; + sun8i_pwm_choose_waveform(rounding, &candidate); +} + +static int sun8i_pwm_round_waveform_tohw(struct pwm_chip *chip, + struct pwm_device *pwm, + const struct pwm_waveform *wf, + void *_wfhw) +{ + struct sun8i_pwm_chip *sun8i_chip =3D sun8i_pwm_from_chip(chip); + struct sun8i_pwm_pair *pair =3D + &sun8i_chip->pairs[SUN8I_PWM_PAIR_IDX(pwm->hwpwm)]; + struct sun8i_pwm_waveform *wfhw =3D _wfhw; + struct sun8i_pwm_rounding rounding =3D { + .requested =3D wf, + }; + unsigned long current_rate; + + if (!wf->period_length_ns) { + *wfhw =3D (struct sun8i_pwm_waveform) { + .enabled =3D false, + }; + return 0; + } + + current_rate =3D sun8i_pwm_get_pair_rate(sun8i_chip, pwm->hwpwm); + if (!current_rate || current_rate > U32_MAX) + return -ERANGE; + rounding.current_pair_rate =3D current_rate; + + if (sun8i_pwm_pair_rate_constrained(sun8i_chip, pwm->hwpwm)) { + sun8i_pwm_consider_pair_rate(&rounding, current_rate); + } else { + for (unsigned int parent_idx =3D 0; + parent_idx < clk_hw_get_num_parents(pair->hw); + parent_idx++) { + struct clk_hw *parent; + unsigned long parent_rate; + + parent =3D clk_hw_get_parent_by_index(pair->hw, parent_idx); + if (!parent) + continue; + parent_rate =3D clk_hw_get_rate(parent); + if (!parent_rate) + continue; + + for (unsigned int i =3D 0; sun8i_pwm_div_m_table[i].div; + i++) { + u16 div_m =3D sun8i_pwm_div_m_table[i].div; + u64 pair_rate; + + pair_rate =3D DIV_ROUND_UP_ULL(parent_rate, div_m); + if (!pair_rate || pair_rate > U32_MAX) + continue; + sun8i_pwm_consider_pair_rate(&rounding, pair_rate); + } + } + } + + if (!rounding.have_best) + return -EINVAL; + *wfhw =3D rounding.best; + + dev_dbg(pwmchip_parent(chip), + "pwm#%u: %llu/%llu [+%llu] -> pair-rate=3D%u, pcr=3D%#x, ppr=3D%#x, bypa= ss=3D%u\n", + pwm->hwpwm, wf->duty_length_ns, wf->period_length_ns, + wf->duty_offset_ns, wfhw->pair_rate, wfhw->pcr, wfhw->ppr, + wfhw->bypass_en); + + return rounding.best_wf.period_length_ns > wf->period_length_ns; +} + +static const struct pwm_ops sun8i_pwm_ops =3D { + .request =3D sun8i_pwm_request, + .free =3D sun8i_pwm_free, + .sizeof_wfhw =3D sizeof(struct sun8i_pwm_waveform), + .round_waveform_tohw =3D sun8i_pwm_round_waveform_tohw, + .round_waveform_fromhw =3D sun8i_pwm_round_waveform_fromhw, + .read_waveform =3D sun8i_pwm_read_waveform, + .write_waveform =3D sun8i_pwm_write_waveform, +}; + +/* Register the shared mux, gate and /div_m clock for each channel pair. */ +static int sun8i_pwm_register_pair_clocks(struct device *dev, + struct sun8i_pwm_chip *sun8i_chip) +{ + static const struct clk_parent_data parent_data[] =3D { + { .index =3D 0 }, + { .index =3D 1 }, + }; + + for (unsigned int i =3D 0; i < SUN8I_PWM_NPAIRS; i++) { + struct sun8i_pwm_pair *pair =3D &sun8i_chip->pairs[i]; + void __iomem *reg =3D sun8i_chip->base + SUN8I_PWM_PCCR(i); + const char *name; + int ret; + + name =3D devm_kasprintf(dev, GFP_KERNEL, + "%s#pwm-clk-src%u%u", dev_name(dev), + i * 2, i * 2 + 1); + if (!name) + return -ENOMEM; + + pair->mux.reg =3D reg; + pair->mux.shift =3D SUN8I_PWM_PCCR_SRC_SHIFT; + pair->mux.mask =3D SUN8I_PWM_PCCR_SRC_MASK; + pair->mux.flags =3D CLK_MUX_ROUND_CLOSEST; + pair->mux.lock =3D &sun8i_chip->lock; + + pair->chip =3D sun8i_chip; + pair->index =3D i; + + pair->divider.reg =3D reg; + pair->divider.shift =3D SUN8I_PWM_PCCR_DIV_M_SHIFT; + pair->divider.width =3D SUN8I_PWM_PCCR_DIV_M_WIDTH; + pair->divider.table =3D sun8i_pwm_div_m_table; + pair->divider.lock =3D &sun8i_chip->lock; + + pair->hw =3D devm_clk_hw_register_composite_pdata(dev, name, + parent_data, + ARRAY_SIZE(parent_data), + &pair->mux.hw, &clk_mux_ops, + &pair->divider.hw, &clk_divider_ops, + &pair->gate_hw, &sun8i_pwm_pair_gate_ops, 0); + if (IS_ERR(pair->hw)) + return dev_err_probe(dev, PTR_ERR(pair->hw), + "Failed to register pair %u clock\n", i); + + /* Borrow CCF's handle so registration cannot pin this module. */ + pair->rate_nb.notifier_call =3D sun8i_pwm_pair_rate_notifier; + ret =3D devm_clk_notifier_register(dev, pair->hw->clk, &pair->rate_nb); + if (ret) + return dev_err_probe(dev, ret, + "Failed to protect pair %u clock rate\n", i); + } + + return 0; +} + +/* + * A disabled pair gate makes any set PER bits ineffective. Clear those st= ale + * enables before a clock consumer can turn the shared gate on and expose = an + * unrequested output. + */ +static void +sun8i_pwm_sanitize_disabled_pairs(struct sun8i_pwm_chip *sun8i_chip) +{ + u32 per; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + per =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + for (unsigned int pair =3D 0; pair < SUN8I_PWM_NPAIRS; pair++) { + unsigned int first =3D pair * 2; + u32 pccr; + + pccr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCCR(pair)); + if (pccr & SUN8I_PWM_PCCR_GATE) + continue; + + per &=3D ~sun8i_pwm_pair_enable_mask(pair); + pccr &=3D ~BIT(SUN8I_PWM_PCCR_BYPASS_BIT(first)); + pccr &=3D ~BIT(SUN8I_PWM_PCCR_BYPASS_BIT(first + 1)); + sun8i_pwm_writel(sun8i_chip, pccr, SUN8I_PWM_PCCR(pair)); + } + sun8i_pwm_writel(sun8i_chip, per, SUN8I_PWM_PER); +} + +static int sun8i_pwm_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct sun8i_pwm_chip *sun8i_chip; + struct reset_control *rst; + struct pwm_chip *chip; + int ret; + + chip =3D devm_pwmchip_alloc(dev, SUN8I_PWM_NPWM, sizeof(*sun8i_chip)); + if (IS_ERR(chip)) + return dev_err_probe(dev, PTR_ERR(chip), + "Failed to allocate pwmchip\n"); + + sun8i_chip =3D sun8i_pwm_from_chip(chip); + spin_lock_init(&sun8i_chip->lock); + sun8i_chip->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(sun8i_chip->base)) + return dev_err_probe(dev, PTR_ERR(sun8i_chip->base), + "Failed to get PWM base address\n"); + + sun8i_chip->bus_clk =3D devm_clk_get_enabled(dev, "bus"); + if (IS_ERR(sun8i_chip->bus_clk)) + return dev_err_probe(dev, PTR_ERR(sun8i_chip->bus_clk), + "Failed to get bus clock\n"); + + rst =3D devm_reset_control_get_shared_deasserted(dev, NULL); + if (IS_ERR(rst)) + return dev_err_probe(dev, PTR_ERR(rst), + "Failed to get reset control\n"); + + chip->ops =3D &sun8i_pwm_ops; + + sun8i_pwm_sanitize_disabled_pairs(sun8i_chip); + + ret =3D sun8i_pwm_register_pair_clocks(dev, sun8i_chip); + if (ret) + return ret; + + ret =3D devm_pwmchip_add(dev, chip); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to add PWM chip\n"); + + return 0; +} + +static const struct of_device_id sun8i_pwm_dt_ids[] =3D { + { + .compatible =3D "allwinner,sun50i-h616-pwm", + }, { + /* sentinel */ + } +}; +MODULE_DEVICE_TABLE(of, sun8i_pwm_dt_ids); + +static struct platform_driver sun8i_pwm_driver =3D { + .driver =3D { + .name =3D "sun8i-pwm", + .of_match_table =3D sun8i_pwm_dt_ids, + }, + .probe =3D sun8i_pwm_probe, +}; +module_platform_driver(sun8i_pwm_driver); + +MODULE_AUTHOR("Richard Genoud "); +MODULE_DESCRIPTION("Allwinner sun8i PWM driver"); +MODULE_LICENSE("GPL"); --=20 2.53.0 From nobody Thu Sep 24 18:43:31 2026 Received: from mail-oa2-f12.google.com (mail-oa2-f12.google.com [74.125.231.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B150A1FE44A for ; Tue, 22 Sep 2026 00:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035611; cv=none; b=DXJosKXGKC75fx4T+nnTZcXu+LCn3pgSW4wn4d6f7zfg0Fj21gcl4OQ7Us4NDr9mFKbddxRWX+W6UIACAhgyeNaH9i9VRful/MoLgJC+mQzoNml/0qXjVEMwpkr8QnobLaaLxiqWJBNCqm9p/tev3gDrhm1JS48OZ58qTGDlEN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035611; c=relaxed/simple; bh=AwEdnSqwNldsU46K3L8s8kozlkZ4yxHPkhkqHOBcOAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hGHZg5q2RcMCu0iN2M57ZoRcUxR0ubZKHtVAG6/BRduXcisB3at1+lB0Evxcj0KpkOjg0YVZI6S1a6s+B9olc+SgF6653ERf+FSGXoS/lNvqPUnByJkAu03JruEKmqM6JkVvM/SYewR6B0awx7j5Z0E69VoO00fDUiRRooGXGc4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FB7xVBIX; arc=none smtp.client-ip=74.125.231.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FB7xVBIX" Received: by mail-oa2-f12.google.com with SMTP id 586e51a60fabf-466ccdd76a9so3216069fac.0 for ; Mon, 21 Sep 2026 17:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790035607; x=1790640407; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1mzlKbz8Phj+ip4hm3yiFbRMiYi293gbL25g7vO3mK8=; b=FB7xVBIXXCRarQPro/vJZ9Lu3+Bg1yBKf3jxiZ9RfRifMkfAaGISg/krxrRbJtoyCs N7tnoj6JfEttAmbmKO3fzWcedpTSFjmOR+60D99nglZQRVdpvFv41wCngVZiV0BQ19Cr qKhohnLdyeVhD6TBBnJwc9SpYCYKDql34IC2KP8jYlU3e/rf6lqHk2KbGlL3Z7qUIz+J lvT77ROcHJUF8Drvl6b2nCcowokGkHZ9VsXni7SXQYbDcOm+zRmCkRktFLwVMNT58tXl sYVex8yzjdzs1zoUmQXTn3J2uMy36Jz6mZGvogOG63QrhvdfaQRtCVMxB3ZiXAoooA4q lKJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790035607; x=1790640407; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1mzlKbz8Phj+ip4hm3yiFbRMiYi293gbL25g7vO3mK8=; b=MI07mLe6jpPLwdkIdXnVuaJ1k+SnjRTIhGPAywTmuAFDQeenZqpjKhGELLLS7ng9Er dh+MAAOk7h0UPHng3kvXx/7ZJncuX6kwA008ZwiwdNNq8oyxPwmfuCIicC7/7RsBka28 rHWlU/+jXfJJapFdyedUAvCS5lKexJXxkjYgasrMTB44QpnhuvuBpGrUpRSSom1aq1bn dlkSWbSY3OossutGSAGS0XP0VyohaXr2S8yraWBmCkcIXCYkubxncywLn5e2jTOdoHKL u+AzzxQlXTir0aw7uCTbdmur7dLkGZ8AxWKKIGrdPYVpICnNpJVeKuBSpuxC1ppI3RYj ffOA== X-Forwarded-Encrypted: i=1; AKwUvBzNYwfnwcjfPaCldz6EdfgJfpI7PiYjfkNhe8Ek+xduDOqQ94HessAWNGVH1XGAiqAhRnVI7T5gTqkNlUo=@vger.kernel.org X-Gm-Message-State: AFuF++mmGlr64giKepkzPcLx46uxi1Uz+SyT476ur7j7cw3Qk+ApXUlp PU1vQJI8BfEfd+wixoMhF7YbCIRSPNYzsuRZa2WQ30/dwOglFJUfe28p X-Gm-Gg: AYBFou23Fo/eMkKRpTo8iLxPOLgq0kzaPkpMSGSQjKT+kp6E/G1lWapPdeaP0HlEEFJ JPsTP6x5MGY7SUD/91I0K637DI+RbBhEo51lYS/IMAgwbc7pL9KzeSy7Ntj3pirZAh/xch8SzzF SbdYa7QrXVbiWlcPFXNNEnGWJbFOgrNTi+k+VHDDYwSdm7DfyVqaMe9ohWqGS2gCgomOLDbq/Q4 tamDU0K/BocmFyB9qE2zBEG4I4i7ldwtT4lLmTZuAdhT278hOiELFyODPGZBC5Ly8CTc/iMj0KV KM5Lobi01GvThrDFbhiR4o5GXtKZ2/eoQXn6/heyUo4yzd/pY3TPeFw5sOIcN55g/jKkNmyoFcm ltWgItv6q3qa2coroOZcBsRv3dr025pK7WgvJrVAD42jpVPHMhCKxpWxVDf1XQLH3eU1/fQI64D SlruIvu8lfrdvCzcQZIOU9yCrqx1c6WLYaUVJoKlgiLW8FysdMGcuJqtYKhhtf1ZKPDWpiRIixs 2FM/a73KsPzWVIIBlykQ7O66bb/FiKUu6khoFsJ7nBbU0V3JrLHkeaLgWBP+7Fv4/iA0twzns1c /3yB9Nu/FH+kDauSzIiTdh8IrHEVcDVsIVCUzTgBn7OJJefnaitrFVl8o8NROwK0itapeJQKpvu HqaCADTrDtNjLa3bExFicvKF67aIurhU= X-Received: by 2002:a05:6870:14d4:b0:47f:b0ff:8383 with SMTP id 586e51a60fabf-486e4df7aa7mr12381394fac.1.1790035607564; Mon, 21 Sep 2026 17:06:47 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-48f7280cf14sm801683fac.13.2026.09.21.17.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 17:06:46 -0700 (PDT) From: James Hilliard Date: Mon, 21 Sep 2026 18:06:32 -0600 Subject: [PATCH v9 3/5] pwm: sun8i: export the bypass outputs as clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260921-h616-pwm-v8-v9-3-37bec6201ff5@gmail.com> References: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> In-Reply-To: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Richard Genoud , Philipp Zabel , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , John Stultz , Joao Schim , bigunclemax@gmail.com, linux-clk@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 From: Richard Genoud Expose each H616 PWM channel's hardware bypass as a CCF clock. Consumers such as the co-packaged AC200/AC300 PHY need a clock rather than PWM duty or polarity control. Keep the pair source protected for the complete prepared lifetime, and arbitrate ownership between PWM requests and clock prepare so both interfaces cannot drive the same output. drivers/clk/clk-pwm.c advertises a fixed frequency without reading back the rounded PWM rate. A 42 ns, 21 ns request does select 24 MHz bypass when it is available. However, with the pair constrained to 100 MHz by its sibling, the PWM rounding rules select a 40 ns, 20 ns waveform (25 MHz), while a pwm-clock configured for 24 MHz still reports 24 MHz. The direct provider instead reports the actual pair rate and makes its shared-rate protection visible to CCF. Consumers must still check the rate they receive. Use CLK_IGNORE_UNUSED to preserve unclaimed firmware bypass outputs, just as the PWM path preserves inherited waveforms. Normal consumer disable still turns the output off and releases its shared gate reference. Signed-off-by: Richard Genoud Co-developed-by: James Hilliard Signed-off-by: James Hilliard --- drivers/pwm/Kconfig | 3 +- drivers/pwm/pwm-sun8i.c | 180 ++++++++++++++++++++++++++++++++++++++++++++= +++- 2 files changed, 180 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index d87d166e7836..d3c35a11859f 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -754,7 +754,8 @@ config PWM_SUN8I depends on HAS_IOMEM && COMMON_CLK help PWM framework driver for Allwinner controllers whose channels share - paired source clocks. + paired source clocks. In addition to PWM operation, each channel's + hardware bypass path can be exported as a clock output. =20 To compile this driver as a module, choose M here: the module will be called pwm-sun8i. diff --git a/drivers/pwm/pwm-sun8i.c b/drivers/pwm/pwm-sun8i.c index 7e6c39815c18..fd81c5f5e326 100644 --- a/drivers/pwm/pwm-sun8i.c +++ b/drivers/pwm/pwm-sun8i.c @@ -113,6 +113,9 @@ * The bypass in PWM mode is used to achieve a 1/2 relative duty cycle wit= h the * fastest clock. * + * SUN8I_PWM_clock_x/y serve for the PWM purpose. + * SUN8I_PWM_bypass_clock_x/y serve for the clock-provider purpose. + * */ =20 /* /div_m is a power-of-two divider limited to /256. */ @@ -129,6 +132,12 @@ static const struct clk_div_table sun8i_pwm_div_m_tabl= e[] =3D { { /* sentinel */ } }; =20 +enum sun8i_pwm_mode { + SUN8I_PWM_MODE_NONE, + SUN8I_PWM_MODE_PWM, + SUN8I_PWM_MODE_CLK, +}; + struct sun8i_pwm_chip; =20 struct sun8i_pwm_pair { @@ -142,8 +151,12 @@ struct sun8i_pwm_pair { }; =20 struct sun8i_pwm_channel { + struct clk_hw bypass_hw; + struct sun8i_pwm_chip *chip; + unsigned int index; /* Separate CCF consumer, held only from PWM request to free. */ struct clk *pair_clk; + enum sun8i_pwm_mode mode; u64 pending_period_ns; bool rate_exclusive; }; @@ -153,7 +166,7 @@ struct sun8i_pwm_chip { struct sun8i_pwm_channel channels[SUN8I_PWM_NPWM]; struct clk *bus_clk; void __iomem *base; - /* Protects shared registers and rate_exclusive. */ + /* Protects shared registers, channel ownership and rate_exclusive. */ spinlock_t lock; }; =20 @@ -317,6 +330,101 @@ static int sun8i_pwm_pair_rate_notifier(struct notifi= er_block *nb, return active ? NOTIFY_BAD : NOTIFY_OK; } =20 +static inline struct sun8i_pwm_channel * +sun8i_pwm_channel_from_hw(struct clk_hw *hw) +{ + return container_of(hw, struct sun8i_pwm_channel, bypass_hw); +} + +static int sun8i_pwm_bypass_prepare(struct clk_hw *hw) +{ + struct sun8i_pwm_channel *chan =3D sun8i_pwm_channel_from_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D chan->chip; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + if (chan->mode !=3D SUN8I_PWM_MODE_NONE) + return -EBUSY; + + chan->mode =3D SUN8I_PWM_MODE_CLK; + return 0; +} + +static void sun8i_pwm_bypass_unprepare(struct clk_hw *hw) +{ + struct sun8i_pwm_channel *chan =3D sun8i_pwm_channel_from_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D chan->chip; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + if (chan->mode !=3D SUN8I_PWM_MODE_CLK) + return; + + chan->mode =3D SUN8I_PWM_MODE_NONE; +} + +static int sun8i_pwm_bypass_enable(struct clk_hw *hw) +{ + struct sun8i_pwm_channel *chan =3D sun8i_pwm_channel_from_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D chan->chip; + unsigned int pair =3D SUN8I_PWM_PAIR_IDX(chan->index); + u32 pccr, per; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + if (chan->mode !=3D SUN8I_PWM_MODE_CLK) + return -EBUSY; + + pccr =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCCR(pair)); + per =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + if (!(pccr & BIT(SUN8I_PWM_PCCR_BYPASS_BIT(chan->index))) || + !(per & SUN8I_PWM_ENABLE(chan->index))) { + sun8i_pwm_set_enabled_locked(sun8i_chip, chan->index, false); + sun8i_pwm_set_bypass_locked(sun8i_chip, chan->index, true); + sun8i_pwm_set_enabled_locked(sun8i_chip, chan->index, true); + } + + return 0; +} + +static void sun8i_pwm_bypass_disable(struct clk_hw *hw) +{ + struct sun8i_pwm_channel *chan =3D sun8i_pwm_channel_from_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D chan->chip; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + if (chan->mode !=3D SUN8I_PWM_MODE_CLK) + return; + + sun8i_pwm_set_enabled_locked(sun8i_chip, chan->index, false); + sun8i_pwm_set_bypass_locked(sun8i_chip, chan->index, false); +} + +static int sun8i_pwm_bypass_is_enabled(struct clk_hw *hw) +{ + struct sun8i_pwm_channel *chan =3D sun8i_pwm_channel_from_hw(hw); + struct sun8i_pwm_chip *sun8i_chip =3D chan->chip; + unsigned int pair =3D SUN8I_PWM_PAIR_IDX(chan->index); + bool enabled; + u32 val; + + guard(spinlock_irqsave)(&sun8i_chip->lock); + + val =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PCCR(pair)); + enabled =3D (val & SUN8I_PWM_PCCR_GATE) && + (val & BIT(SUN8I_PWM_PCCR_BYPASS_BIT(chan->index))); + + val =3D sun8i_pwm_readl(sun8i_chip, SUN8I_PWM_PER); + enabled =3D enabled && (val & SUN8I_PWM_ENABLE(chan->index)); + + return enabled; +} + +static const struct clk_ops sun8i_pwm_bypass_ops =3D { + .prepare =3D sun8i_pwm_bypass_prepare, + .unprepare =3D sun8i_pwm_bypass_unprepare, + .enable =3D sun8i_pwm_bypass_enable, + .disable =3D sun8i_pwm_bypass_disable, + .is_enabled =3D sun8i_pwm_bypass_is_enabled, +}; + static void sun8i_pwm_put_rate(struct sun8i_pwm_chip *sun8i_chip, unsigned int idx) { @@ -342,8 +450,12 @@ static int sun8i_pwm_request(struct pwm_chip *chip, st= ruct pwm_device *pwm) int ret; =20 scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + if (chan->mode !=3D SUN8I_PWM_MODE_NONE) + return -EBUSY; + was_enabled =3D sun8i_pwm_channel_is_enabled_locked(sun8i_chip, idx); + chan->mode =3D SUN8I_PWM_MODE_PWM; } =20 chan->pair_clk =3D clk_hw_get_clk(parent, NULL); @@ -372,6 +484,8 @@ static int sun8i_pwm_request(struct pwm_chip *chip, str= uct pwm_device *pwm) clk_put(chan->pair_clk); err_clear_clock: chan->pair_clk =3D NULL; + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + chan->mode =3D SUN8I_PWM_MODE_NONE; =20 return ret; } @@ -382,6 +496,9 @@ static void sun8i_pwm_free(struct pwm_chip *chip, struc= t pwm_device *pwm) struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[pwm->hwpwm]; =20 scoped_guard(spinlock_irqsave, &sun8i_chip->lock) { + if (chan->mode !=3D SUN8I_PWM_MODE_PWM) + return; + sun8i_pwm_set_enabled_locked(sun8i_chip, pwm->hwpwm, false); sun8i_pwm_set_bypass_locked(sun8i_chip, pwm->hwpwm, false); } @@ -390,6 +507,9 @@ static void sun8i_pwm_free(struct pwm_chip *chip, struc= t pwm_device *pwm) clk_disable_unprepare(chan->pair_clk); clk_put(chan->pair_clk); chan->pair_clk =3D NULL; + + scoped_guard(spinlock_irqsave, &sun8i_chip->lock) + chan->mode =3D SUN8I_PWM_MODE_NONE; } =20 static int sun8i_pwm_read_waveform(struct pwm_chip *chip, @@ -510,7 +630,8 @@ sun8i_pwm_pair_rate_constrained(struct sun8i_pwm_chip *= sun8i_chip, unsigned int sibling =3D idx ^ 1; =20 guard(spinlock_irqsave)(&sun8i_chip->lock); - return sun8i_chip->channels[sibling].rate_exclusive || + return sun8i_chip->channels[sibling].mode =3D=3D SUN8I_PWM_MODE_CLK || + sun8i_chip->channels[sibling].rate_exclusive || sun8i_pwm_channel_is_enabled_locked(sun8i_chip, sibling); } =20 @@ -984,6 +1105,42 @@ static int sun8i_pwm_register_pair_clocks(struct devi= ce *dev, return 0; } =20 +/* Register the bypass clock for each channel. */ +static int sun8i_pwm_register_bypass_clocks(struct device *dev, + struct sun8i_pwm_chip *sun8i_chip) +{ + for (unsigned int i =3D 0; i < SUN8I_PWM_NPWM; i++) { + struct sun8i_pwm_channel *chan =3D &sun8i_chip->channels[i]; + struct clk_hw *parent =3D sun8i_chip->pairs[SUN8I_PWM_PAIR_IDX(i)].hw; + const char *name; + int ret; + + name =3D devm_kasprintf(dev, GFP_KERNEL, "%s#pwm-bypass%u", + dev_name(dev), i); + if (!name) + return -ENOMEM; + + chan->chip =3D sun8i_chip; + chan->index =3D i; + /* + * Protect the shared rate while prepared. Preserve unclaimed + * firmware outputs through CCF's unused-clock cleanup, as for + * PWM waveforms; only a consumer may turn them off. + */ + chan->bypass_hw.init =3D + CLK_HW_INIT_HW(name, parent, &sun8i_pwm_bypass_ops, + CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE | + CLK_IGNORE_UNUSED); + + ret =3D devm_clk_hw_register(dev, &chan->bypass_hw); + if (ret) + return dev_err_probe(dev, ret, + "Failed to register bypass clock %u\n", i); + } + + return 0; +} + /* * A disabled pair gate makes any set PER bits ineffective. Clear those st= ale * enables before a clock consumer can turn the shared gate on and expose = an @@ -1012,6 +1169,17 @@ sun8i_pwm_sanitize_disabled_pairs(struct sun8i_pwm_c= hip *sun8i_chip) sun8i_pwm_writel(sun8i_chip, per, SUN8I_PWM_PER); } =20 +static struct clk_hw *sun8i_pwm_get_clk_hw(struct of_phandle_args *clkspec, + void *data) +{ + struct sun8i_pwm_chip *sun8i_chip =3D data; + + if (clkspec->args[0] >=3D SUN8I_PWM_NPWM) + return ERR_PTR(-EINVAL); + + return &sun8i_chip->channels[clkspec->args[0]].bypass_hw; +} + static int sun8i_pwm_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -1050,6 +1218,14 @@ static int sun8i_pwm_probe(struct platform_device *p= dev) if (ret) return ret; =20 + ret =3D sun8i_pwm_register_bypass_clocks(dev, sun8i_chip); + if (ret) + return ret; + + ret =3D devm_of_clk_add_hw_provider(dev, sun8i_pwm_get_clk_hw, sun8i_chip= ); + if (ret) + return dev_err_probe(dev, ret, "Failed to add HW clock provider\n"); + ret =3D devm_pwmchip_add(dev, chip); if (ret < 0) return dev_err_probe(dev, ret, "Failed to add PWM chip\n"); --=20 2.53.0 From nobody Thu Sep 24 18:43:31 2026 Received: from mail-oa2-f24.google.com (mail-oa2-f24.google.com [74.125.231.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7216421ABBB for ; Tue, 22 Sep 2026 00:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.88 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035612; cv=none; b=t0fmlgrtToHkh0/gS2gK7BtnLPU9xv7oBmIspuvyQ/vuKLi2ZOM8bgAihw7+/ChsT8viYF89Ekgo5vJpGyvCaecZUDWAb/L+FZ9QWI8CtFfe1/k8/6a35mvaHORuS0LL1C0ck6oYP57fKl/Sb9+OUzpzKqaJibQlverj8ShgWJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035612; c=relaxed/simple; bh=cxjDKZ0MA9VUms6JcpknLJlKdT7ZoJ5aaylgo7tCtYM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CBykBcYe0Xo1Fjam25wx8NAObOMyT/LkpZyuKeEXuNwAi0UY6xZETinUlaqnD/adcq5ZWa/SssDBidjusjZJhAXKAePtUYMNoP/Spm1KqpibXnKlFHzzY8cMgz+mt6DhQdY2rWqcU8Zq3YbBHX/MzqyrQ+cxJQCWcVLE8GrvWI4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3BIvN8Z; arc=none smtp.client-ip=74.125.231.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3BIvN8Z" Received: by mail-oa2-f24.google.com with SMTP id 586e51a60fabf-482620dc91bso2566538fac.2 for ; Mon, 21 Sep 2026 17:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790035609; x=1790640409; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FHj476tA2byKc8arhZaw8Ci81fHtdMiGqz0hVZIDFng=; b=K3BIvN8ZXhwBGh/bchwmAw3pbw7T2OJvYXmeHOQJFW95gOixgjGzaeTiCWez2GIcsZ dvtum3l0mGVupRLdCNCHSPk8wg4TI9HtWCIHzIILFLZ8w/CMyqty50OxoONoiWN9vilf lTifV9+xXl3DqBkFys7TgV50F1e/3Ms2fNyRT3ox8jRlss+aHSPeauxGUGY3REZB1Hr9 H1mC06G77vRUPExHtcEuHToUIrnEYocbT4PFnJH1IoR/MKBpL798GHpL8fCxqAvjqrq/ pr1JunWA0c1FsGs59Qq79knmn1kTAS822xFe57rXw1vV06YFS54Fhup+5acv4PpBQbOd 1XkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790035609; x=1790640409; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FHj476tA2byKc8arhZaw8Ci81fHtdMiGqz0hVZIDFng=; b=qcJyBuz5QhfZtucY7CQbq0KYhdT3i50JhsyKWg5GZtp6UdmmXJN4DKwdNUcXfZCVTK DfoM4xd0us2YdjKKU3kMfB4z9iVOsrHF9mg8Loz3Zc+uQRTrdgNkCMJiHqheV5aavapc Ts8dwxIvUbVleknJuay3nzflpZJgdsm5X82aIGuk2OujNWt/peYm8zS2/jqPRtsjClLi vXok4Xjchwln1IhX7PyM4LFaothGLFjuyQcZ+hRuaSJ0zQzMfGx0i3Lsp7BOLP7h20zV WMrsC+d5ImJEBo39CK8SB+N/r62bcT8g89pTDNozL3ZzL4Gta1B0/OxR7JIMRbGvhUhC c++A== X-Forwarded-Encrypted: i=1; AKwUvBz+2bNQnBsnMtBinpurfPtB6m0dDKSlgCLW31pvHgo6Kr8ieeUbbdRavcNeILcTlcfZkDkonTjezQjrfWk=@vger.kernel.org X-Gm-Message-State: AFuF++l1OY4WVswljCAnTJ3HdoFCY4E3T25X6qIzBYrRSvpL0PrE/+WN exW2ROZIvNP1+GettNviJ0vI7OZ2p1TdtPrqMDoaCj2qhL32idxp0FiS X-Gm-Gg: AYBFou09KnT1wdoxyoIHtfB9Tuplj+YkXwxC/IRl6wnCY7nZL5rP8TLFBVjkBp6i1PK kKqxyfoG/DoJp01Pu6hHhCWFHtBNIW8pTGjhk2Be0oqWgbT8Djg9wiUilbWljwZqG78ZxH+P+jD QaxSQguu0ejCrJqGWjYJ8UVH39xEtRwUljJQdQov6UNgPUeZOEXbix2VxPwGaLGrNpTclKgBN7w P7Ig94lQbVeFdhEWD3t2kj6xLFugbLzsKbmtdmoVeH3RkUXTc3E4gs6A2KD8fGIt2F5fhUHZndf HtGePQjwKditbWCQQmBOFEA13tPZuaZzWkJrZ4AmFZGWKLOXv/7bDXpfLjJkasu8ZYauDotTXzE wmibf+AfXJ7/G+csylzmIYRkg6WG8tJaWyRTa2oxlu7+urPM6DiGert0qQEsSUuTiLUp5dbGOjF +V31Sz+Ph+5YPweS3fQCJaH05vpSyojewGvZFZdHaMEbjDqw6W23EI1qYFYLoXQ38G2ljDGIdEz vMVcSBIVq4rAp3hWZK2IYU77UruFWDaZcASDEufNidoT6ngKy9c0jTXA9IxhJsgQdV9FsTBxtKm bp9reMiil4LfOkOIhcKpTSD5UmCnK0xy14xogex59t0/IBMCi66ViAE3e7zPjXKl3rKivsfaN7y w6siWUQO7nN4z37mEABoq X-Received: by 2002:a05:6870:21e4:b0:464:c314:ddc2 with SMTP id 586e51a60fabf-486e4bbce38mr12349868fac.8.1790035609185; Mon, 21 Sep 2026 17:06:49 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-48f7280cf14sm801683fac.13.2026.09.21.17.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 17:06:48 -0700 (PDT) From: James Hilliard Date: Mon, 21 Sep 2026 18:06:33 -0600 Subject: [PATCH v9 4/5] arm64: dts: allwinner: h616: add PWM controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260921-h616-pwm-v8-v9-4-37bec6201ff5@gmail.com> References: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> In-Reply-To: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Richard Genoud , Philipp Zabel , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , John Stultz , Joao Schim , bigunclemax@gmail.com, linux-clk@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 From: Richard Genoud The H616 has a PWM controller that can provide PWM signals, but also plain clocks. Add the PWM controller node and pins in the device tree. Signed-off-by: Richard Genoud Signed-off-by: James Hilliard --- arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 47 ++++++++++++++++++++++= ++++ 1 file changed, 47 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/bo= ot/dts/allwinner/sun50i-h616.dtsi index 1598e86259ab..90fe56a1d3cd 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi @@ -281,6 +281,17 @@ watchdog: watchdog@30090a0 { clocks =3D <&osc24M>; }; =20 + pwm: pwm@300a000 { + compatible =3D "allwinner,sun50i-h616-pwm"; + reg =3D <0x0300a000 0x400>; + clocks =3D <&osc24M>, <&ccu CLK_BUS_PWM>; + clock-names =3D "mod", "bus"; + resets =3D <&ccu RST_BUS_PWM>; + #pwm-cells =3D <3>; + #clock-cells =3D <1>; + status =3D "disabled"; + }; + pio: pinctrl@300b000 { compatible =3D "allwinner,sun50i-h616-pinctrl"; reg =3D <0x0300b000 0x400>; @@ -385,6 +396,42 @@ nand_rb1_pin: nand-rb1-pin { bias-pull-up; }; =20 + /omit-if-no-ref/ + pwm0_pin: pwm0-pin { + pins =3D "PD28"; + function =3D "pwm0"; + }; + + /omit-if-no-ref/ + pwm1_pin: pwm1-pin { + pins =3D "PG19"; + function =3D "pwm1"; + }; + + /omit-if-no-ref/ + pwm2_pin: pwm2-pin { + pins =3D "PH2"; + function =3D "pwm2"; + }; + + /omit-if-no-ref/ + pwm3_pin: pwm3-pin { + pins =3D "PH0"; + function =3D "pwm3"; + }; + + /omit-if-no-ref/ + pwm4_pin: pwm4-pin { + pins =3D "PI14"; + function =3D "pwm4"; + }; + + /omit-if-no-ref/ + pwm5_pin: pwm5-pin { + pins =3D "PA12"; + function =3D "pwm5"; + }; + /omit-if-no-ref/ spi0_pins: spi0-pins { pins =3D "PC0", "PC2", "PC4"; --=20 2.53.0 From nobody Thu Sep 24 18:43:31 2026 Received: from mail-oa2-f12.google.com (mail-oa2-f12.google.com [74.125.231.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EC7B20A5C4 for ; Tue, 22 Sep 2026 00:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035614; cv=none; b=JLr/lAAS368GLshmS2UiQXTQT/FJj/l5Z4xyW5cStyB5zDnXR2rFVGR1ytAoLA3CHh9bseupWnldR2AhdJ76N2tn8Dv7CGlsjPt164ZzdeeQrpKErDPsYAt49Qqy/jJPyqvlXwM9J3zZxjZRA+0kKNFY1v1xTzJ9WHVergvKu8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790035614; c=relaxed/simple; bh=OJS6mQlRWmTTimOyj6kC0TvQSBszoDm45iW9XPqV2AQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H8vR0l9LQniyc8GajDfR9CkzOS9/uh6Y2K601f0qVqmcuw0PPfbLSezOON3A57c7K9sz7JxfnwfOVX8daqQ0r5AEw2wFVliDh1d26T8NnhcU1C5Fg9qMyo/I/VYRCa+/IXrcGUpGXQZj6DrjPE8p1YP16/AK9TJmUZA76PV5L+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mELEbMC8; arc=none smtp.client-ip=74.125.231.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mELEbMC8" Received: by mail-oa2-f12.google.com with SMTP id 586e51a60fabf-466ccdd76a9so3216099fac.0 for ; Mon, 21 Sep 2026 17:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790035611; x=1790640411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xhBI/4MYKZ9FiatfUTHQXDlddZz4ARJ+4t2N8WN0Mwk=; b=mELEbMC8vP2KT2ZWY8+ENif1pwzjJPVXEwcm66ZjSyZNCkRause6ScsffBjqyHKA9z OzsVNpw7WW14B4P1CdXYyZtEe2mnPd4GGGeQdjphc4oxljynOkxVd8aZDRfCjqdjdeg9 2IkSjQkZvxFHNwk6a2/s8Ah3D8DYjrGlHyyX2+fiCWTR/PjP/fdOEcMiB2k7yj3twpDw 5YVwhHUkU6IJ6vkRFAfQtr75Fb5l6ckReIRD6JxhA8cBRe/l2jbZgQ25yl3q12IzDnAT 2OIAKly7uLHETzaRJ0zlmVGyqgD8+3CwjIi5WWPqXT8RcCr4xN6kfZb5ZViYo7BtXnDG 9Hpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790035611; x=1790640411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xhBI/4MYKZ9FiatfUTHQXDlddZz4ARJ+4t2N8WN0Mwk=; b=y1UrrpZE/+iEzyScKX5T4OrmzPsJQq05Qq4Uukr3XOPSjEcYay9QOLn1Wbp3hs1vZd d0F3yOHKPTLizdxbF39ZRqskO/hqRB7kDRdwRMGLKoAKbqsSL1Okkl4NxywLSwp4liRM s+/n8NeOQVbs55CYkTbIE5kOIqBSMpq0KiU1F2cDfbSjuQLqzLjYMhJYG5Fq9hy3DSHc b9O08vWE8Vlcb6npmKFhT1TjPg9Mbr/5xToVvToGffwqWJVI+c0gh1ps/ImhxRJmHfFi +OKyMcvqCKgIll7FfKJ1uyq4FKD7TvCUrQNW7K0YQXo/Xv+QlTHG3V00UbZdddW8k5dz YuGA== X-Forwarded-Encrypted: i=1; AKwUvBxWvUPyMCPFO5Mgz/jtNpJzJctpve4mDWRv1DoomoI2LJM3ZRqt0Vgi4UCQbnkvE1DWQC4pOKkJaR+LkXE=@vger.kernel.org X-Gm-Message-State: AFuF++kwM4CmOvIGaFX9J4k71st1FtlP1CqAEe8g9wv4jWjdlh4QhFgp FKoMlq6NMJLfSIZvDz2hxe+8GK9xPvaSvBlCBE3LksoHhSi9TEbY750a X-Gm-Gg: AYBFou0iYmDDGiP/q4qD2t0lJEAdp3UhYtXWMcomAveeDSw4Tgg8B5iZ2lIhOhK9r41 GcMLUTiaP8d4P7Qn69hhIF4dwsvgwYyh4EV7Yc9wafWKhgIQvgd1xugzN+gZVLmknOzJbqsDDpD UbXhjchyt9vgDGQe7pm4gAqr/uxtTZG2A66cqnPRIHN7V0Ji35v5IOBjmfxicckjTEaduvZy/hu yqrlaZ3Kzxd6ztD9KWqhNee7c98Tx7glaWPUnnYq9efNUFFaNGmemIA2E/otM5Rh0lUSy3+QeaM YC/KbVjGYclhpIJKYRK100A0bbn53tLuDci/qDx5hud9F5D7dFnXsF1/Dy6mNVUyQqsxIPvTZAv Kyv2ksj4LB+USeDsFyoX0GJw8uizgZ3L4v1fuRJQy+zpvlGu4EDm2gxPK2LXVsQr2hJMakl2tR6 IA1H5qKc1YVKEuWky+8agZTeg4gkMZF78oZlIR+Omqm3ban1GbAiNaokD/2arCl0hRRTYAG/svb VkUcN+cHOiA4DgcN5aDW18h+bM4kiw5yRtOZ50vijr+lNTPupOP21Ega5YlUwXl283sDd4Ijl4t rvRwyVRb3/dGs2ek4eQruKR5aFa4w1U4LGdf7PqUIatyTL/5HvnoUcfu80cCgqj8Z2ZNXVszg12 VKUw6DOW4TB+65HvemisB X-Received: by 2002:a05:6870:e24a:b0:483:d19f:334b with SMTP id 586e51a60fabf-486e6eeddb5mr12235098fac.24.1790035610897; Mon, 21 Sep 2026 17:06:50 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-48f7280cf14sm801683fac.13.2026.09.21.17.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 17:06:50 -0700 (PDT) From: James Hilliard Date: Mon, 21 Sep 2026 18:06:34 -0600 Subject: [PATCH v9 5/5] MAINTAINERS: Add entry on Allwinner sun8i/H616 PWM driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260921-h616-pwm-v8-v9-5-37bec6201ff5@gmail.com> References: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> In-Reply-To: <20260921-h616-pwm-v8-v9-0-37bec6201ff5@gmail.com> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Richard Genoud , Philipp Zabel , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , John Stultz , Joao Schim , bigunclemax@gmail.com, linux-clk@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 From: Richard Genoud Add myself as maintainer of Allwinner SUN8I PWM driver. Signed-off-by: Richard Genoud Signed-off-by: James Hilliard --- MAINTAINERS | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cc3cae2e378b..d9713b1044c2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -918,6 +918,11 @@ S: Maintained F: Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock= .yaml F: drivers/hwspinlock/sun6i_hwspinlock.c =20 +ALLWINNER SUN8I PWM DRIVER +M: Richard Genoud +S: Maintained +F: drivers/pwm/pwm-sun8i.c + ALLWINNER THERMAL DRIVER M: Vasily Khoruzhick M: Yangtao Li --=20 2.53.0