From nobody Thu Sep 24 21:19:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31DF742E428 for ; Sun, 20 Sep 2026 12:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789905860; cv=none; b=hBpxVJ0NXcZ3czNCGQZ5UR78cXXuBCxCnNNqvS+Db/K9GODXiNZ78g/EYocwyos/CltKF3MgdYeikdNog14++bqIEsIR75fFuiy65pYNqat5yGbtIOyB7FurHg2cUh9aS/rbrjMRG+gQeDnrgHdxCluks7gZusXAKsPrhHYoV+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789905860; c=relaxed/simple; bh=vuxpQQHSHpogoXgcj1g6nYIyqWnif7Aqe4zqMtU2VSg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hPmkxHRJXMNOBAjCjfgI+sxsTYSJX14f452NxSqfb5hYh1FNHzrX+VNh154XW63YaI4b4BnRR6yll5xo+yBoal1QLLYT3MJlDYRTryv86HwSB0GCmnDaKUTgYIH9hpsuNxG2zH0D8MwH7bTuOO3VLYinBgoHAj7ILDcNvFoExQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mIyOgh5I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DJ5V4qwo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mIyOgh5I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DJ5V4qwo" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68KBo5HZ3271649 for ; Sun, 20 Sep 2026 12:04:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 312B9C6n0UKKu6NJESvzkUE//S3M9JdnPEV0pkxNzjc=; b=mIyOgh5IA5WtV7T/ 92dSrsoTNguH/YzjbHn8bddUBUnFIfb6GCPXOg5ZsKfATvdemxL9cEfmIG2yp5nI 79qm/m6LXqFSg4JmwABanhuUVOSqhRGVv4f5neLrfIWgpPHL9XPUg5zj2sdwTAXj I2CfadCjsEKKd9d/DxfKbg3Scrr7MoDmK9AW6KUVnPAhv7FEzV47jIDu5EncTDch Wq5NNj858uLKI5HsUeOOy9TaXj2kXVzvYOeuYGdMbCyWOaxeBY4Z+r9I8JEG0bTX oHNUZzPLGP6fdhi4gUIGfzQQt7Cg2T8v+v5HfNFjY+cGDTObUca7fpS0H2A+UgvI 6f7ODQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gshbsb2mm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 20 Sep 2026 12:04:17 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-39de4a68f7cso3920872a91.1 for ; Sun, 20 Sep 2026 05:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789905857; x=1790510657; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=312B9C6n0UKKu6NJESvzkUE//S3M9JdnPEV0pkxNzjc=; b=DJ5V4qwoMv/ioTXuvY7HoFEcRorTm74Lr+kP3VN9+6XBTkWJMJWjq9MOBLih3dh44k QbSVV1KfPXJ9GhanBcfiyXnOW+U/kJNf+dsMZpwNULUCwVT+BKxRErx+deFHj27iDWjr yDFE6mLIln8W2iBfAm940InXwdhtKuYdHN0GeseyNAz7W44a/864f105231/nu1d/ENy USBLIkDtUFB933Q1DWOPJDkHAQlZiZ5fDbM7juoUTrveSkV6ntrS3DyHtu3jKlN+NsIV TQ2it3zgRfU+x+cVQK96ZXW46kJVb2+MAE9Lmwwv3j/ujXjJ9S1vlWpbUndn1ecqTEEC /V1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789905857; x=1790510657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=312B9C6n0UKKu6NJESvzkUE//S3M9JdnPEV0pkxNzjc=; b=l7dFzNbYqT0gY7es59P220babWChjXKg/BMJ2ZZ59lYhccEfdvGMuR/X75Z6f83pkQ Kt5NWsOCWb0MzDUDxzOcui9HlnJX+WRhcAlJF6EtVRrOgJzlE9r+Om5DXRW554cvnAYc VwpNJjJLSxVH2jJzwcW2IM6S6Z6rWJm38SWuFfHPiSy4aFH2rKEirQCUW1+cyz5ZhTB1 0vXuHa/YRhi5ovZNW1QCqym4QsLRpAVKUXiIXxeVybMi04jlNpqLlqHu5acPRR+jxAGc FHqPk7D4KoZb7XMTnUHkZJ47YeTzvbsz0frjDpIfTqqSoHpvR4vhAKVpk8KHVpjDEdgk V8LA== X-Forwarded-Encrypted: i=1; AKwUvBx1D6S2W0tzAf92jyy7vFU52ce9rwUQIySQRkIN1lAX6E4BXql7HtfR63SjzyetSh4YIAEQNiwDaOb3Fic=@vger.kernel.org X-Gm-Message-State: AFuF++mGOJ2Q3mRCKM5ZSYpAqT34TaokdcOyU6rFYlWEmOpzA+pMY12Z Qry4ujh8rnzF5xqu5Qi6yuy7XonNQQA0DiPcxwEBcuELaD21C7uSZZEO26/2UxUgIpeuHyDEZm9 K56l5ui3RulBJqR79NqnMsbcha3YGnUzCgq8a57iiM83A4aGj7dKevlQMJmUTKgUa59w= X-Gm-Gg: AYBFou2afVK1UR3HU1dVo+LE6/SXXMqBYAZe7aUtO1Oaxk/Uu6h7AFEtkoCJrTB4mJ1 ZrwG9HGttH0o0d3uxL5LSl/63FDTG65UFPXoZWE5O6MpeJuC4suXC1swkknoeWNAGPROZYZC8h5 3DKQfmx+xrQspAf/pbv2ipVE6SHoSLCWtxnaCYru1fbtuXbR8vL2A0eRxsiPw/wfa2oGl1jQB6i 4En/QobxwtVA2vU4fHMuSF25UGtvdMB/BXMJpWSecFhQwMlWgdQdTuEu/XcmKQwTTOVz9fVWxd2 Cw8X5rPuz8ojBjZuSCS9js669zwTuqytzIb+QYj0cfajlj7mMAiB0iduoQzuNhBZr2+dx1qggwU Szj4BAl1drnYBPD54YoLdTIqnVV0O6IEqHi4= X-Received: by 2002:a05:6a21:b89:b0:3dd:a197:cf30 with SMTP id adf61e73a8af0-3dda197d7f6mr6614207637.84.1789905856583; Sun, 20 Sep 2026 05:04:16 -0700 (PDT) X-Received: by 2002:a05:6a21:b89:b0:3dd:a197:cf30 with SMTP id adf61e73a8af0-3dda197d7f6mr6614165637.84.1789905855983; Sun, 20 Sep 2026 05:04:15 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-144d55aaf1csm12109622c88.3.2026.09.20.05.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 05:04:15 -0700 (PDT) From: Viken Dadhaniya Date: Sun, 20 Sep 2026 17:34:01 +0530 Subject: [PATCH v4 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260920-i2c-qcom-slave-v4-1-f7e1020f3bb4@oss.qualcomm.com> References: <20260920-i2c-qcom-slave-v4-0-f7e1020f3bb4@oss.qualcomm.com> In-Reply-To: <20260920-i2c-qcom-slave-v4-0-f7e1020f3bb4@oss.qualcomm.com> To: Mukesh Kumar Savaliya , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Viken Dadhaniya , Krzysztof Kozlowski X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1789905847; l=2790; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=vuxpQQHSHpogoXgcj1g6nYIyqWnif7Aqe4zqMtU2VSg=; b=cD/isAtcvTnIdN4rCxFt5vNkUpdNJkaupwoJvyxs8k1coPb97PAwRqJiTWapxKDPtfOgGWB9B ZtdV/dhZQi6CPEPQq+AlaJY/KgPuapgecMT7U5YHLlR1J1NLlY/h8xj X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-GUID: N9bN_vWL0T2yJjvjECrfBIcOap5Byfup X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIwMDE3NSBTYWx0ZWRfX9YwzU0z1waJO 94RDZcjDG9CD7BplO+RVX80QfoIA/fLoRbUhNH1X8EYTeTKug0FZnDCEB9aoAAZ1s9r15Ecs7CA Q5Twlf5/d09Kji5Wr7yBy7COct5Faqte79vux6wRQLdHuID42bPOr+1HlFHkBlcqtz/JlukloP4 maReYBUhWqDnsjWmT/VW85kcfXQCKgNsUNDJcqybJi+4NgtXUXpr0MKI1GRwwAojhbn0YhrYWju 1BoxTlcClmQxLDxNJw9ErzUhg4eQYvczcV88as41FfDfzGMQMZpMml3GVcSylAePgdOdB3xRh7w RytkdVzeznQY76CmvIFPnZt18GBbLwadFUUdT/KRml8wNP06n/0fKBFVuceK/1y08N6Z3poE6au NOC/KTO+MCkeo6TAQkRIS/zoH3QOcRrddPXlORehgo6qyo6nQyRXEXRDkeK78drIROVKjCl7v/f N4OfH2cEVmTc25AT5Dg== X-Proofpoint-ORIG-GUID: N9bN_vWL0T2yJjvjECrfBIcOap5Byfup X-Authority-Analysis: v=2.4 cv=bPqDs/+Z c=1 sm=1 tr=0 ts=6aafcbc1 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=64-jBHeFNbSwsrqMnDgA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIwMDE3NSBTYWx0ZWRfX8ixBY/JdYlJ3 9hHePgogAFQP9f80eWFc2z8I4lzcJj9utDDMWt+UJdfFzjJaM1j6dd4kL5aaJ0JDSEuinUbWSTp jmn03eYk9spUiSo98QsUjCq6/Oe5fR4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-20_04,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609200175 QDU1000 and related Qualcomm SoCs include a dedicated I2C target controller that operates exclusively in target mode. It is a distinct IP from the Qualcomm I2C master controllers (GENI, QUP) with a different register interface, so it requires its own binding. Document the MMIO region, interrupt, XO and AHB clocks, interconnect path, and optional pinctrl states for the controller. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Viken Dadhaniya --- .../bindings/i2c/qcom,qdu1000-i2c-target.yaml | 75 ++++++++++++++++++= ++++ 1 file changed, 75 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.= yaml b/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml new file mode 100644 index 000000000000..9a6b08f0ab0e --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/qcom,qdu1000-i2c-target.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm I2C Target Controller + +maintainers: + - Mukesh Kumar Savaliya + - Viken Dadhaniya + +description: + Dedicated hardware IP found on Qualcomm SoCs that operates exclusively + as an I2C target (slave) device on the bus. Supports FIFO (PIO) mode + for data transfer. + +properties: + compatible: + enum: + - qcom,qdu1000-i2c-target + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: XO reference clock + - description: AHB bus clock + + clock-names: + items: + - const: xo + - const: ahb + + interconnects: + maxItems: 1 + + pinctrl-0: true + pinctrl-1: true + + pinctrl-names: + minItems: 1 + items: + - const: default + - const: sleep + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - interconnects + +additionalProperties: false + +examples: + - | + #include + #include + #include + + i2c@88ca000 { + compatible =3D "qcom,qdu1000-i2c-target"; + reg =3D <0x88ca000 0x64>; + clocks =3D <&gcc GCC_SM_BUS_XO_CLK>, <&gcc GCC_SM_BUS_AHB_CLK>; + clock-names =3D "xo", "ahb"; + interrupts =3D ; + interconnects =3D <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_= SMBUS_CFG 0>; + }; +... --=20 2.34.1 From nobody Thu Sep 24 21:19:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B85431A3C for ; Sun, 20 Sep 2026 12:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789905866; cv=none; b=N3zApR3p6WyKqArU3B0/+ZRIVJIf1XZFzSVh2je53/Ig/MtVkwpNakmAfb4ZANYel0s3ge1srnoSmjmDYz4WMxTgUe8ZVkWuYMCL0DKSGwIgplnzqb8dU2ShGVChortJyYr+IYQtcnDN2JQHNs0YW8k1oHupVxfwNlurL+gsLgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789905866; c=relaxed/simple; bh=c1mTan4Ea0EV+DS8mCXLN69o80JB0zdn5kVnL5h11eY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O3tmEwk7n+4XTCDUhPPK8SB9gCUoY5xQf6Vh2p7oettl5FgyV7A9bZXTOWanbdm7ve4fkjSs77+meMjlxtTooZ2NQve7OqapUWiCqVJ5alhrFAdF5OwcXWfOgGUIW75HUhUrRX26YaMG/8dJ17cqe19/Qd8vf7FmUmho3qS1HTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OuhF5SkD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FpBSrfoM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OuhF5SkD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FpBSrfoM" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68KBo1Nk2761321 for ; Sun, 20 Sep 2026 12:04:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fU6BhwzTnynT5JNZGCEf/LE9KOSLHjwe/oBj4zfjqzI=; b=OuhF5SkDFbn0PDHb y+g6AadBhA4/R7FlsDzuAzGqTs0b7XoMv59gvYVHbilJmh19DUd8K8ZMW3JpPT5E 1rn2DixNSKVawDVTwJDG5BlWYufkJj6rLJP1H4OpjDIllUHqiarT1X5B+40gCTHp 4oXPMR3nH7HYvduVYDgd9U0FJ2jBC/QWInE6oWblaVcacYDL0cPahRUbRFC+GD22 8ZetvgOQ9QK41n1F4lveQq3z8JIdVnCKISpl51+bF/ccKMnREMr8MMmEt7qBQf5G MfRKebrviaORqmtH2OtSiNS20d4GOHIuU/w9Dxh82OeHOTGVIHAbNMq+jMkLaHjm Ybezlg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gshd631mq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 20 Sep 2026 12:04:21 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cbb92868263so1861225a12.2 for ; Sun, 20 Sep 2026 05:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789905861; x=1790510661; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fU6BhwzTnynT5JNZGCEf/LE9KOSLHjwe/oBj4zfjqzI=; b=FpBSrfoMmrYuFjZ1j3NMwUNDZ5ecOU03Jlznffmdcw5UxMc9SMnr2H2dp4o2i6Pp2z RyVSLFRuN70M/gYCgh83uIk7Ttv0jmLtHvTDLQpOixfpe36sXOaHMAK3AwJScwSgW849 TNyxqPCLBKRfSwapkNMDYBHv3btQrS9+TZWTjU8QUS0U9qGZhiSEUWKylIYSvvkStfmi 7bB4LbZTl11od4D2CjmqO8ZO1CZ9QeWNvwugrCzKjNs6F5nmaUHsPWa5B8YF/WkR1C4C +JnikaeF61WAVTo0TH00zjZ/09dciqL2F3f5VQKYzuFWrt+0Ok4cU/KXX/w6gjEaIUEV OZdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789905861; x=1790510661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fU6BhwzTnynT5JNZGCEf/LE9KOSLHjwe/oBj4zfjqzI=; b=DivP+IAoXFKO6rr9uXStWsaO8JYQnBWqSayo0XFy5XgpgcG/4Ljls9TnoypWSk6GsV JGAlpjav3dezLQPam785cKhhblXVJmYntnelk+qh07vMTWoGjVgCYVQ1CyDLFNzrc8sy Z81/hxiT3gpVDj05WWN9Ahp8hlEpVhWYEE1FCbrFDkmL2I3AcRxOcLQXHNykkZHZ/kec a05igYJDtfJMjhfS9XCRt6kFkFKqczgcJeaqLDHo+EorGZfy2M4FlwluOxuUOTNgmx0o G3oQ0K13HVH9bz4+NGw5fUsQmjFxCLr8DQ4duPAlheFUtDu71XKs80MtOJnGGgmIellW 37IA== X-Forwarded-Encrypted: i=1; AKwUvBw7QU1ZmETgZSqCgMI41qm2TL0m5BhZ+hHYJhz5BN5BHBNSdF4Xtu9vQOUBN3o2Dm78wfsbyaFGJkesZiY=@vger.kernel.org X-Gm-Message-State: AFuF++nyAlBTkTjXVjoR3hHouDKsUyOEn4O9y2N3vX4lkd1vLU9NyKgh UNxgmec5hHrscbrQBdM2RMLMMMQ/pbwUG4pzIuA+qhVlbX4qugEfHOB0ZV2l4xHrK4X+/9XsIUv IMWpCOBp46sRqA3JeNN6hzp1VceZrnEFQT2cGBiXWCTOnQGk/8dNb92JDGc95FcPpOj1rUkHrHX s= X-Gm-Gg: AYBFou1ABiMblLOLCVQjZfsIybZgZ8sxzsF0E2P1fcrZ9ja+gL6wKsDNhLgVuOCQnSh fA83fsz2BEwCIONhzaHXHVwnP8Q4xs+7vKWJfx1yb1yxpbNygS1u8iEMD2OoxrUZ1yZan84i2vz b2kJdmEMX+4SUeL44Cnenlv59bY5tRreikSaIp7sBi7SjF4a7kreRWsskv5PvRJ+YvNrTr1XAar tX7QEjMEOr/IuW3ggenPw75C2ZXJnAWW49jUWp6dKrYey+4+K0wmyMXiZDHzNtqdzLbUpvjIeIN k5LMIBVXbF0AO7VCjoTGaH27XS/ByfJ6LR3p0Vk0VrQCDBYUVXqpA78od9mm3vEqyDMyOEAcfxe TvDzHp6sdUM529ebYznWGklh+e1oqmiv4GVU= X-Received: by 2002:a05:6a20:728e:b0:3dd:85a8:cad6 with SMTP id adf61e73a8af0-3dd8c4dedd3mr12536105637.45.1789905860507; Sun, 20 Sep 2026 05:04:20 -0700 (PDT) X-Received: by 2002:a05:6a20:728e:b0:3dd:85a8:cad6 with SMTP id adf61e73a8af0-3dd8c4dedd3mr12536055637.45.1789905859991; Sun, 20 Sep 2026 05:04:19 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-144d55aaf1csm12109622c88.3.2026.09.20.05.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 05:04:19 -0700 (PDT) From: Viken Dadhaniya Date: Sun, 20 Sep 2026 17:34:02 +0530 Subject: [PATCH v4 2/2] i2c: qcom-target: Add driver for Qualcomm I2C target controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260920-i2c-qcom-slave-v4-2-f7e1020f3bb4@oss.qualcomm.com> References: <20260920-i2c-qcom-slave-v4-0-f7e1020f3bb4@oss.qualcomm.com> In-Reply-To: <20260920-i2c-qcom-slave-v4-0-f7e1020f3bb4@oss.qualcomm.com> To: Mukesh Kumar Savaliya , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Viken Dadhaniya X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1789905847; l=23932; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=c1mTan4Ea0EV+DS8mCXLN69o80JB0zdn5kVnL5h11eY=; b=PmQ+n4SDUZ8GPqs0Yl0+eWtfRm2kCW6rpF3LZBipvjC5LJGGYFQC35AP0iS4qPYM7EC9/eB7o X6GiwF+5dMSAjVoF/rfSO9xzS27zud4XklgOCXMMOBeLCsfikFFgQHi X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIwMDE3NSBTYWx0ZWRfX/V1PaS1V7eHQ gYJjFYCHIP1xZ6ysol54zENKek9yxVe9IRvkoqtGGHF0Sm3/wDaJIt+etEs+eh/IufduVHVMAOF M27ecUtBssIKWlQBoo3CMwx3+DabQehYnpMQRn7kh81Uri/dYzwIRX1qx3hyVkpfWIbKMIRrIfV 8bahkkXlGUcovrX3TkqOrGYaqPpZ6OBOdZktz67qswj1xsTM3+RQ2Yy8ftftPfayiuzL8uWGkFW 2cR7KFyOy9OJw/4fRD5XwE4w3Xd71UH5WndoOSeBCK3a+mAywa/mh5qV40IutqJHCIIX8teQaMP t+5DtWn5ZfazJ42SIihFgKVZRaTO35AyqXahBaXvJqxE6kaKEqTP206zgXNg9P4HdVkFtpRlQ35 VjqFv6xn2qVq7UVWZkysMXpAc7ERa8g2I/KJFwDZMYBKQySISDyfrc23zIQnZFWI/yUmoVz7jZW nt0Jg2iiCYKfd4YRgrA== X-Authority-Analysis: v=2.4 cv=RMQmjIi+ c=1 sm=1 tr=0 ts=6aafcbc6 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=6DcAWkpIsXMuyEkTCRsA:9 a=jV8L4PXTkMu8bHMp:21 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: cA-oZcKQ3cuajtGgyRk1kD2-_AMpXbs9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIwMDE3NSBTYWx0ZWRfX3vM3ZPofqF02 ecTXStqVd6sIycAlO63JWVPWvAkQFTzJnY+lRp+Z/ef6jYl8qRGpi686uExZYiCuN6tsXXDSOkR HNynbi4/jAzf/GR1l4VWTNNAyavzozU= X-Proofpoint-GUID: cA-oZcKQ3cuajtGgyRk1kD2-_AMpXbs9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-20_04,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609200175 QDU1000 and related Qualcomm SoCs include a dedicated I2C target controller that operates exclusively in target mode. The existing Qualcomm I2C controller drivers, GENI and QUP, are master-only and cannot serve systems where the SoC must respond as an I2C target on the bus. Register the controller with the Linux I2C slave framework through i2c_algorithm.reg_slave and i2c_algorithm.unreg_slave. This allows standard slave backends, such as slave-24c02, to be attached at runtime through i2c_slave_register(). Handle IRQ events for RX FIFO service, clock stretching during read and write phases, STOP and repeated-start conditions, and error recovery through a software reset. Enable the required AHB and XO clocks and vote for interconnect bandwidth. Restore the hardware state across system suspend and resume using regular system-sleep PM callbacks. Signed-off-by: Viken Dadhaniya --- MAINTAINERS | 9 + drivers/i2c/busses/Kconfig | 15 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-qcom-target.c | 628 +++++++++++++++++++++++++++++++= ++++ 4 files changed, 653 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 06760c45c582..07ade6c1dfdf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22670,6 +22670,15 @@ S: Maintained F: Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml F: drivers/i2c/busses/i2c-qcom-geni.c =20 +QUALCOMM I2C TARGET CONTROLLER DRIVER +M: Viken Dadhaniya +M: Mukesh Kumar Savaliya +L: linux-i2c@vger.kernel.org +L: linux-arm-msm@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml +F: drivers/i2c/busses/i2c-qcom-target.c + QUALCOMM I2C CCI DRIVER M: Loic Poulain M: Robert Foss diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index d7b89508311f..2e18238e0ae6 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -1070,6 +1070,21 @@ config I2C_QCOM_GENI This driver can also be built as a module. If so, the module will be called i2c-qcom-geni. =20 +config I2C_QCOM_TARGET + tristate "Qualcomm I2C target controller" + depends on ARCH_QCOM || COMPILE_TEST + depends on COMMON_CLK + depends on INTERCONNECT + select I2C_SLAVE + help + This driver supports I2C target mode on Qualcomm Technologies + SoCs. If you say yes to this option, support will be included + for the built-in I2C target controller on QDU1000 and other + compatible Qualcomm SoCs. + + This driver can also be built as a module. If so, the module + will be called i2c-qcom-target. + config I2C_QUP tristate "Qualcomm QUP based I2C controller" depends on ARCH_QCOM || COMPILE_TEST diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile index 3755c54b3d82..ab3070cdb144 100644 --- a/drivers/i2c/busses/Makefile +++ b/drivers/i2c/busses/Makefile @@ -101,6 +101,7 @@ obj-$(CONFIG_I2C_PXA) +=3D i2c-pxa.o obj-$(CONFIG_I2C_PXA_PCI) +=3D i2c-pxa-pci.o obj-$(CONFIG_I2C_QCOM_CCI) +=3D i2c-qcom-cci.o obj-$(CONFIG_I2C_QCOM_GENI) +=3D i2c-qcom-geni.o +obj-$(CONFIG_I2C_QCOM_TARGET) +=3D i2c-qcom-target.o obj-$(CONFIG_I2C_QUP) +=3D i2c-qup.o obj-$(CONFIG_I2C_RIIC) +=3D i2c-riic.o obj-$(CONFIG_I2C_RK3X) +=3D i2c-rk3x.o diff --git a/drivers/i2c/busses/i2c-qcom-target.c b/drivers/i2c/busses/i2c-= qcom-target.c new file mode 100644 index 000000000000..5cf4bad1b601 --- /dev/null +++ b/drivers/i2c/busses/i2c-qcom-target.c @@ -0,0 +1,628 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* Register offsets */ +#define I2C_S_DEVICE_ADDR 0x00 +#define I2C_S_IRQ_STATUS 0x08 +#define I2C_S_IRQ_CLR 0x0C +#define I2C_S_IRQ_EN 0x10 +#define I2C_S_CONFIG 0x18 +#define I2C_S_CONTROL 0x1C +#define I2C_S_FIFOS_STATUS 0x20 +#define I2C_S_TX_FIFO 0x24 +#define I2C_S_RX_FIFO 0x28 +#define I2C_S_DEBUG_REG1 0x3C +#define I2C_S_DEBUG_REG2 0x40 +#define I2C_S_SW_RESET_REG 0x4C +#define I2C_S_CLK_LOW_TIMEOUT 0x50 +#define I2C_S_CLK_RELEASE_DELAY_CNT_VAL 0x54 +#define I2C_S_SDA_HOLD_CNT_VAL 0x58 + +/* I2C_S_CONFIG register fields */ +#define I2C_S_CORE_EN BIT(0) + +/* I2C_S_CONTROL register fields */ +#define CLEAR_RX_FIFO BIT(0) +#define CLEAR_TX_FIFO BIT(1) +#define NACK BIT(2) +#define ACK_RESUME BIT(3) + +/* I2C_S_SW_RESET_REG register fields */ +#define SW_RESET BIT(0) + +/* I2C_S_FIFOS_STATUS register fields */ +#define RX_FIFO_COUNT_MASK GENMASK(31, 16) + +/* Interconnect bandwidth vote in bytes per second */ +#define APPS_PROC_TO_I2C_TARGET_VOTE 1190000 + +/** + * enum qcom_i2c_target_irq - IRQ bit positions in I2C_S_IRQ_STATUS + * @STOP_DETECTED: I2C stop condition detected on the bus + * @RX_FIFO_FULL: receive FIFO has reached capacity + * @TX_FIFO_EMPTY: transmit FIFO is empty + * @RX_DATA_AVAIL: receive data is available in the RX FIFO + * @CLOCK_LOW_TIMEOUT: SCL held low longer than the configured timeout + * @STRCH_WR: clock stretching during a write (Rx) phase + * @STRCH_RD: clock stretching during a read (Tx) phase + * @GCA_DETECTED: general call address detected (not used) + * @ERR_CONDITION: unexpected start or stop bit detected (error) + * @RESTART_DETECTED: repeated start condition detected + */ +enum qcom_i2c_target_irq { + STOP_DETECTED, + RX_FIFO_FULL, + TX_FIFO_EMPTY, + RX_DATA_AVAIL, + CLOCK_LOW_TIMEOUT, + STRCH_WR, + STRCH_RD, + GCA_DETECTED, + ERR_CONDITION, + RESTART_DETECTED, +}; + +/* + * TX_FIFO_EMPTY is excluded: this driver fills the TX FIFO one byte at a + * time in response to STRCH_RD (clock-stretch during read phase), so + * TX_FIFO_EMPTY adds no value and would double the interrupt rate. + * GCA (general call address) is unsupported. + */ +#define QCOM_I2C_TARGET_ALL_IRQ (GENMASK(RESTART_DETECTED, STOP_DETECTED) \ + & ~(BIT(GCA_DETECTED) | BIT(TX_FIFO_EMPTY))) + +/* Bit indices for the status bitmask, used with set_bit/test_bit/clear_bi= t */ +enum qcom_i2c_target_status { + READ_IN_PROGRESS, + WRITE_IN_PROGRESS, +}; + +/** + * struct qcom_i2c_target - Qualcomm I2C target controller private data + * @dev: driver model device node + * @base: base address of HW registers + * @adap: I2C adapter (slave mode) + * @ahb_clk: AHB bus clock + * @xo_clk: XO reference clock + * @icc_path: interconnect bandwidth path + * @slave: currently registered slave backend client; written only + * under disable_irq() in reg_slave()/unreg_slave() so the + * ISR sees a stable pointer for its entire execution + * @status: bitmask of enum qcom_i2c_target_status flags; must be + * unsigned long for set_bit/test_bit/clear_bit; accessed + * only from the ISR and from reg_slave()/unreg_slave() + * under disable_irq(), so no additional lock is needed + * @irq: interrupt line number + */ +struct qcom_i2c_target { + struct device *dev; + void __iomem *base; + struct i2c_adapter adap; + struct clk *ahb_clk; + struct clk *xo_clk; + struct icc_path *icc_path; + struct i2c_client *slave; + unsigned long status; + int irq; +}; + +static void qcom_i2c_target_dump_regs(struct qcom_i2c_target *target) +{ + dev_dbg(target->dev, "I2C_S_DEVICE_ADDR: 0x%x\n", + readl_relaxed(target->base + I2C_S_DEVICE_ADDR)); + dev_dbg(target->dev, "I2C_S_IRQ_STATUS: 0x%x\n", + readl_relaxed(target->base + I2C_S_IRQ_STATUS)); + dev_dbg(target->dev, "I2C_S_CONFIG: 0x%x\n", + readl_relaxed(target->base + I2C_S_CONFIG)); + dev_dbg(target->dev, "I2C_S_IRQ_EN: 0x%x\n", + readl_relaxed(target->base + I2C_S_IRQ_EN)); + dev_dbg(target->dev, "I2C_S_FIFOS_STATUS: 0x%x\n", + readl_relaxed(target->base + I2C_S_FIFOS_STATUS)); + dev_dbg(target->dev, "I2C_S_DEBUG_REG1: 0x%x\n", + readl_relaxed(target->base + I2C_S_DEBUG_REG1)); + dev_dbg(target->dev, "I2C_S_DEBUG_REG2: 0x%x\n", + readl_relaxed(target->base + I2C_S_DEBUG_REG2)); + dev_dbg(target->dev, "I2C_S_CLK_LOW_TIMEOUT: 0x%x\n", + readl_relaxed(target->base + I2C_S_CLK_LOW_TIMEOUT)); + dev_dbg(target->dev, "I2C_S_CLK_RELEASE_DELAY_CNT_VAL: 0x%x\n", + readl_relaxed(target->base + I2C_S_CLK_RELEASE_DELAY_CNT_VAL)); + dev_dbg(target->dev, "I2C_S_SDA_HOLD_CNT_VAL: 0x%x\n", + readl_relaxed(target->base + I2C_S_SDA_HOLD_CNT_VAL)); +} + +static void qcom_i2c_target_hw_init(struct qcom_i2c_target *target) +{ + dev_dbg(target->dev, "HW init: resetting FIFOs, enabling IRQs\n"); + writel(CLEAR_TX_FIFO | CLEAR_RX_FIFO, target->base + I2C_S_CONTROL); + writel(QCOM_I2C_TARGET_ALL_IRQ, target->base + I2C_S_IRQ_EN); +} + +static void qcom_i2c_target_write_requested(struct qcom_i2c_target *target) +{ + u8 val =3D 0; + + if (!test_and_set_bit(WRITE_IN_PROGRESS, &target->status)) { + dev_dbg(target->dev, "Write phase started\n"); + i2c_slave_event(target->slave, I2C_SLAVE_WRITE_REQUESTED, &val); + } +} + +static int qcom_i2c_target_drain_rx_fifo(struct qcom_i2c_target *target) +{ + unsigned int rx_count; + int ret =3D 0; + u8 val; + + while (!ret) { + rx_count =3D FIELD_GET(RX_FIFO_COUNT_MASK, + readl_relaxed(target->base + I2C_S_FIFOS_STATUS)); + if (!rx_count) + break; + + while (rx_count--) { + val =3D (u8)readl_relaxed(target->base + I2C_S_RX_FIFO); + dev_dbg(target->dev, "Data from RX FIFO: 0x%x\n", val); + ret =3D i2c_slave_event(target->slave, I2C_SLAVE_WRITE_RECEIVED, &val); + if (ret) + break; + } + } + + return ret; +} + +static void qcom_i2c_target_hw_reset(struct qcom_i2c_target *target) +{ + /* Clear error bits before SW_RESET; the reset may not be instantaneous */ + writel(BIT(ERR_CONDITION) | BIT(CLOCK_LOW_TIMEOUT), + target->base + I2C_S_IRQ_CLR); + writel(SW_RESET, target->base + I2C_S_SW_RESET_REG); + + /* + * I2C_S_SW_RESET_REG is write-only so completion cannot be polled. + * This helper is called from the hard IRQ handler, so the reset delay + * must not sleep. Use a short busy wait before reconfiguring the + * controller. + */ + udelay(20); + qcom_i2c_target_hw_init(target); + writel(target->slave->addr, target->base + I2C_S_DEVICE_ADDR); + writel(I2C_S_CORE_EN, target->base + I2C_S_CONFIG); +} + +static irqreturn_t qcom_i2c_target_handle_error(struct qcom_i2c_target *ta= rget, + u32 irq_stat) +{ + u8 val =3D 0; + + if (irq_stat & BIT(ERR_CONDITION)) + dev_err(target->dev, "Error condition: unexpected Start/Stop bits\n"); + else + dev_err(target->dev, "Clock low timeout\n"); + qcom_i2c_target_dump_regs(target); + qcom_i2c_target_hw_reset(target); + i2c_slave_event(target->slave, I2C_SLAVE_STOP, &val); + target->status =3D 0; + + return IRQ_HANDLED; +} + +static irqreturn_t qcom_i2c_target_handle_stop(struct qcom_i2c_target *tar= get, + u32 irq_stat) +{ + u8 val =3D 0; + + dev_dbg(target->dev, "Stop bit detected\n"); + /* + * Short-write corner case: WRITE_IN_PROGRESS was never set because + * no RX_DATA_AVAIL or STRCH_WR fired before STOP. Do not call + * qcom_i2c_target_write_requested() here =E2=80=94 STOP ends the transac= tion + * so setting WRITE_IN_PROGRESS now would leave a stale bit after + * target->status is cleared below. + */ + if (!test_bit(WRITE_IN_PROGRESS, &target->status)) { + unsigned int rx_count; + + rx_count =3D FIELD_GET(RX_FIFO_COUNT_MASK, + readl_relaxed(target->base + I2C_S_FIFOS_STATUS)); + if (rx_count) + i2c_slave_event(target->slave, I2C_SLAVE_WRITE_REQUESTED, + &val); + } + + qcom_i2c_target_drain_rx_fifo(target); + i2c_slave_event(target->slave, I2C_SLAVE_STOP, &val); + target->status =3D 0; + writel(CLEAR_RX_FIFO, target->base + I2C_S_CONTROL); + /* + * STOP terminates the transaction, so any other Rx or clock + * stretch bits latched in this same status read have already + * been serviced by the drain above or are now stale. Ack the + * whole word rather than just STOP_DETECTED; clearing only STOP + * would leave those bits set and immediately re-enter the + * handler, which for a co-asserted STRCH_RD would push a stale + * byte into the TX FIFO. + */ + writel(irq_stat, target->base + I2C_S_IRQ_CLR); + + return IRQ_HANDLED; +} + +static void qcom_i2c_target_handle_rx_data(struct qcom_i2c_target *target, + u32 rx_irq_bits) +{ + int ret; + + dev_dbg(target->dev, "Rx data event (rx_irq_bits=3D0x%x)\n", rx_irq_bits); + qcom_i2c_target_write_requested(target); + ret =3D qcom_i2c_target_drain_rx_fifo(target); + if (ret) + dev_dbg(target->dev, "Backend requested NACK\n"); + + writel(ret ? NACK | CLEAR_RX_FIFO : ACK_RESUME, + target->base + I2C_S_CONTROL); + writel(rx_irq_bits, target->base + I2C_S_IRQ_CLR); +} + +static void qcom_i2c_target_handle_strch_rd(struct qcom_i2c_target *target) +{ + enum i2c_slave_event event =3D I2C_SLAVE_READ_PROCESSED; + u8 val =3D 0; + + dev_dbg(target->dev, "Clock stretching during read (Tx) phase\n"); + if (!test_and_set_bit(READ_IN_PROGRESS, &target->status)) { + /* Repeated-start: master switched direction from write to read */ + clear_bit(WRITE_IN_PROGRESS, &target->status); + event =3D I2C_SLAVE_READ_REQUESTED; + } + + i2c_slave_event(target->slave, event, &val); + dev_dbg(target->dev, "Data to TX FIFO: 0x%x\n", val); + writel(val, target->base + I2C_S_TX_FIFO); + writel(ACK_RESUME, target->base + I2C_S_CONTROL); + writel(BIT(STRCH_RD), target->base + I2C_S_IRQ_CLR); +} + +static irqreturn_t qcom_i2c_target_irq(int irq, void *dev) +{ + struct qcom_i2c_target *target =3D dev; + u32 irq_stat, rx_bits; + + /* + * Dispatch priority (highest first): + * ERR_CONDITION / CLOCK_LOW_TIMEOUT =E2=80=94 hardware error, trigger= s SW reset + * STOP_DETECTED =E2=80=94 end of transaction, cle= ars all state + * RESTART_DETECTED =E2=80=94 repeated start, resets = state before + * any data phase in the same snap= shot + * STRCH_RD =E2=80=94 read-phase data supply + * RX_FIFO_FULL / RX_DATA_AVAIL / + * STRCH_WR =E2=80=94 write-phase Rx, coalesc= ed into one drain + */ + irq_stat =3D readl_relaxed(target->base + I2C_S_IRQ_STATUS); + if (!irq_stat) + return IRQ_NONE; + + dev_dbg(target->dev, "IRQ status: 0x%x\n", irq_stat); + + /* + * Load target->slave once. Both reg_slave() and unreg_slave() disable + * the IRQ before writing the pointer, so it cannot change while this + * handler runs. Sub-handlers may dereference target->slave directly. + * + * The core is enabled only in reg_slave() and disabled in unreg_slave(), + * so no bus activity is expected here. Clear and discard any stale IRQ. + */ + if (!READ_ONCE(target->slave)) { + writel(irq_stat, target->base + I2C_S_IRQ_CLR); + return IRQ_HANDLED; + } + + if (irq_stat & (BIT(ERR_CONDITION) | BIT(CLOCK_LOW_TIMEOUT))) + return qcom_i2c_target_handle_error(target, irq_stat); + + if (irq_stat & BIT(STOP_DETECTED)) + return qcom_i2c_target_handle_stop(target, irq_stat); + + if (irq_stat & BIT(RESTART_DETECTED)) { + dev_dbg(target->dev, "Repeated start bit detected\n"); + target->status =3D 0; + /* + * Keep clock stretch asserted when STRCH_RD is co-asserted so + * qcom_i2c_target_handle_strch_rd() can fill TX FIFO first. + */ + if (!(irq_stat & BIT(STRCH_RD))) + writel(ACK_RESUME, target->base + I2C_S_CONTROL); + writel(BIT(RESTART_DETECTED), target->base + I2C_S_IRQ_CLR); + } + + if (irq_stat & BIT(STRCH_RD)) + qcom_i2c_target_handle_strch_rd(target); + + /* + * Coalesce all write-phase Rx bits into a single drain+ACK. When the + * RX FIFO fills at threshold, RX_FIFO_FULL, RX_DATA_AVAIL and STRCH_WR + * can all assert in the same irq_stat snapshot. Pass the combined mask + * so ACK_RESUME is written exactly once and all bits are cleared togethe= r. + */ + rx_bits =3D irq_stat & (BIT(RX_FIFO_FULL) | BIT(RX_DATA_AVAIL) | + BIT(STRCH_WR)); + if (rx_bits) + qcom_i2c_target_handle_rx_data(target, rx_bits); + + return IRQ_HANDLED; +} + +static int qcom_i2c_target_reg_slave(struct i2c_client *slave) +{ + struct qcom_i2c_target *target =3D i2c_get_adapdata(slave->adapter); + + if (target->slave) + return -EBUSY; + + if (slave->flags & I2C_CLIENT_TEN) + return -EAFNOSUPPORT; + + disable_irq(target->irq); + WRITE_ONCE(target->slave, slave); + writel(slave->addr, target->base + I2C_S_DEVICE_ADDR); + writel(I2C_S_CORE_EN, target->base + I2C_S_CONFIG); + enable_irq(target->irq); + + return 0; +} + +static int qcom_i2c_target_unreg_slave(struct i2c_client *slave) +{ + struct qcom_i2c_target *target =3D i2c_get_adapdata(slave->adapter); + + if (!target->slave) + return -EINVAL; + + disable_irq(target->irq); + writel(0, target->base + I2C_S_CONFIG); + WRITE_ONCE(target->slave, NULL); + target->status =3D 0; + writel(0, target->base + I2C_S_DEVICE_ADDR); + enable_irq(target->irq); + + return 0; +} + +static int qcom_i2c_target_icc_init(struct qcom_i2c_target *target) +{ + int ret; + + target->icc_path =3D devm_of_icc_get(target->dev, NULL); + if (IS_ERR(target->icc_path)) + return dev_err_probe(target->dev, PTR_ERR(target->icc_path), + "failed to get ICC path\n"); + + /* + * The controller only needs interconnect bandwidth while it is + * powered. The vote is placed here and across resume with + * icc_set_bw(), and dropped with icc_set_bw(path, 0, 0) on suspend + * and remove, so the vote and unvote are always symmetric. + */ + ret =3D icc_set_bw(target->icc_path, APPS_PROC_TO_I2C_TARGET_VOTE, + APPS_PROC_TO_I2C_TARGET_VOTE); + if (ret) + return dev_err_probe(target->dev, ret, "icc_set_bw failed\n"); + + return 0; +} + +static u32 qcom_i2c_target_func(struct i2c_adapter *adap) +{ + return I2C_FUNC_SLAVE; +} + +static const struct i2c_algorithm qcom_i2c_target_algo =3D { + .reg_target =3D qcom_i2c_target_reg_slave, + .unreg_target =3D qcom_i2c_target_unreg_slave, + .functionality =3D qcom_i2c_target_func, +}; + +static int qcom_i2c_target_adap_init(struct qcom_i2c_target *target) +{ + target->adap.algo =3D &qcom_i2c_target_algo; + target->adap.dev.parent =3D target->dev; + target->adap.dev.of_node =3D target->dev->of_node; + strscpy(target->adap.name, "qcom-i2c-target", + sizeof(target->adap.name)); + i2c_set_adapdata(&target->adap, target); + + return i2c_add_adapter(&target->adap); +} + +static int qcom_i2c_target_probe(struct platform_device *pdev) +{ + struct qcom_i2c_target *target; + struct device *dev =3D &pdev->dev; + int ret; + + target =3D devm_kzalloc(dev, sizeof(*target), GFP_KERNEL); + if (!target) + return -ENOMEM; + + target->dev =3D dev; + + target->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(target->base)) + return dev_err_probe(dev, PTR_ERR(target->base), + "failed to map registers\n"); + + target->xo_clk =3D devm_clk_get(dev, "xo"); + if (IS_ERR(target->xo_clk)) + return dev_err_probe(dev, PTR_ERR(target->xo_clk), + "failed to get XO clock\n"); + + target->ahb_clk =3D devm_clk_get(dev, "ahb"); + if (IS_ERR(target->ahb_clk)) + return dev_err_probe(dev, PTR_ERR(target->ahb_clk), + "failed to get AHB clock\n"); + + ret =3D clk_prepare_enable(target->xo_clk); + if (ret) + return dev_err_probe(dev, ret, "failed to enable XO clock\n"); + + ret =3D clk_prepare_enable(target->ahb_clk); + if (ret) { + dev_err_probe(dev, ret, "failed to enable AHB clock\n"); + goto err_disable_xo; + } + + target->irq =3D platform_get_irq(pdev, 0); + if (target->irq < 0) { + ret =3D target->irq; + goto err_disable_ahb; + } + + ret =3D qcom_i2c_target_icc_init(target); + if (ret) + goto err_disable_ahb; + + ret =3D devm_request_irq(dev, target->irq, qcom_i2c_target_irq, 0, + dev_name(dev), target); + if (ret) { + dev_err_probe(dev, ret, "request_irq failed for IRQ %d\n", + target->irq); + goto err_disable_icc; + } + + qcom_i2c_target_hw_init(target); + + platform_set_drvdata(pdev, target); + + ret =3D qcom_i2c_target_adap_init(target); + if (ret) { + dev_err_probe(dev, ret, "i2c_add_adapter failed\n"); + goto err_free_irq; + } + + return 0; + +err_free_irq: + devm_free_irq(dev, target->irq, target); +err_disable_icc: + icc_set_bw(target->icc_path, 0, 0); +err_disable_ahb: + clk_disable_unprepare(target->ahb_clk); +err_disable_xo: + clk_disable_unprepare(target->xo_clk); + + return ret; +} + +static void qcom_i2c_target_remove(struct platform_device *pdev) +{ + struct qcom_i2c_target *target =3D platform_get_drvdata(pdev); + + writel(0, target->base + I2C_S_CONFIG); + i2c_del_adapter(&target->adap); + devm_free_irq(&pdev->dev, target->irq, target); + icc_set_bw(target->icc_path, 0, 0); + clk_disable_unprepare(target->xo_clk); + clk_disable_unprepare(target->ahb_clk); +} + +static int qcom_i2c_target_suspend(struct device *dev) +{ + struct qcom_i2c_target *target =3D dev_get_drvdata(dev); + int ret; + + disable_irq(target->irq); + writel(0, target->base + I2C_S_IRQ_EN); + writel(0, target->base + I2C_S_CONFIG); + + ret =3D icc_set_bw(target->icc_path, 0, 0); + if (ret) + dev_err(dev, "icc_set_bw failed on suspend: %d\n", ret); + + clk_disable_unprepare(target->xo_clk); + clk_disable_unprepare(target->ahb_clk); + + return 0; +} + +static int qcom_i2c_target_resume(struct device *dev) +{ + struct qcom_i2c_target *target =3D dev_get_drvdata(dev); + int ret; + + ret =3D clk_prepare_enable(target->ahb_clk); + if (ret) { + dev_err(dev, "failed to enable AHB clock\n"); + enable_irq(target->irq); + return ret; + } + + ret =3D clk_prepare_enable(target->xo_clk); + if (ret) { + dev_err(dev, "failed to enable XO clock\n"); + goto err_disable_ahb; + } + + ret =3D icc_set_bw(target->icc_path, APPS_PROC_TO_I2C_TARGET_VOTE, + APPS_PROC_TO_I2C_TARGET_VOTE); + if (ret) { + dev_err(dev, "icc_set_bw failed\n"); + goto err_disable_xo; + } + + qcom_i2c_target_hw_init(target); + target->status =3D 0; + if (target->slave) { + writel(target->slave->addr, target->base + I2C_S_DEVICE_ADDR); + writel(I2C_S_CORE_EN, target->base + I2C_S_CONFIG); + } + + enable_irq(target->irq); + + return 0; + +err_disable_xo: + clk_disable_unprepare(target->xo_clk); +err_disable_ahb: + clk_disable_unprepare(target->ahb_clk); + enable_irq(target->irq); + + return ret; +} + +static const struct dev_pm_ops qcom_i2c_target_pm_ops =3D { + SET_SYSTEM_SLEEP_PM_OPS(qcom_i2c_target_suspend, + qcom_i2c_target_resume) +}; + +static const struct of_device_id qcom_i2c_target_dt_match[] =3D { + { .compatible =3D "qcom,qdu1000-i2c-target" }, + {} +}; +MODULE_DEVICE_TABLE(of, qcom_i2c_target_dt_match); + +static struct platform_driver qcom_i2c_target_driver =3D { + .driver =3D { + .name =3D "qcom-i2c-target", + .pm =3D &qcom_i2c_target_pm_ops, + .of_match_table =3D qcom_i2c_target_dt_match, + }, + .probe =3D qcom_i2c_target_probe, + .remove =3D qcom_i2c_target_remove, +}; +module_platform_driver(qcom_i2c_target_driver); + +MODULE_DESCRIPTION("Qualcomm I2C target controller driver"); +MODULE_AUTHOR("Viken Dadhaniya "); +MODULE_LICENSE("GPL"); --=20 2.34.1