From nobody Thu Sep 24 21:47:06 2026 Received: from mail-yx2-f13.google.com (mail-yx2-f13.google.com [74.125.224.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CBD39CCFD for ; Sat, 19 Sep 2026 23:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789861917; cv=none; b=IlRWcEq6d4IIE/jL2hpxNyUor5ctt559h3AZ/RRojDBtMh+t2f7lefX5YYhYwUWj49Q5myZmTYfVqnWihi8tIBU6OR+oweHOO3O0tCxDOKJkFK+uiExZmPUc+Ip5VuarXDzJOUMgZD+7A75FMYW/cIpHO4y+xJ3yk9oCYu3HIi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789861917; c=relaxed/simple; bh=FqxWjOmDX/kecaW/RuI/kHrAGN9fCpwYa5Nb9b5Sa8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p0Fx6o9b0T3nTbUiNgMg9MQ4wuUtpiLg6F+h5FVLygRfZjo/flkSeC+2b2zhJniBFieJJ8lhoyvdX2CU/2PhOi2KN/Mw16jQi+Somn1akYO3psHQwHTtV81So8viGqgJ60ayDB51xPq0wYTDjFcsfg3m0VLaL31P0kYk598OObQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PRhfsCNr; arc=none smtp.client-ip=74.125.224.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PRhfsCNr" Received: by mail-yx2-f13.google.com with SMTP id 00721157ae682-85d46e4cdccso10853017b3.1 for ; Sat, 19 Sep 2026 16:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789861915; x=1790466715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9QHpm7c1V8gHiee3hWq0zuvysKzJj4/MeFKMRUANhqo=; b=PRhfsCNrlg+IYy/PZml0fSQvjfc8HepLnyYYTUiWvq6bIym6/0bHklgcqc44Yw+fPZ 6maCS24sdO2UpwB3sC2wWp50wflW7lBrUz1ZqVMttLFHv6NLBqQha2MBQSYe+LBkCC8a C6aDhwln02e/xgmbD1Zy7OkTl3w5N4zD0D1vupIS95ZKWh4+D9LgB9JpZEEeNRyg/Q+S TrIyY7bEZz2sZ/Wx+wloBOO736I1uF1JOo1hQmHpKUryn5y7KleVl3CyX4ceyY+63T2e mCAA7ApPEBUsEfSVaznaNsr1INkRZYOoPhyiAU50prTK8p+Hlqa2yEY8qPuin5GNjEI6 3Okw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789861915; x=1790466715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9QHpm7c1V8gHiee3hWq0zuvysKzJj4/MeFKMRUANhqo=; b=2qzPA4C6BWM4wm/aDU7ve7W6NmfXEICMjzTay0rqtYKcnSN8LcfSqHdGbqwSvzx3Vf y2B07XO4hFPzA/c5STa3AlnKtpxly/OvUbpaXhVxB4G7ueK65e3qfg7zdBcjPq/vCa3M TP7TtyOn/WtlwmMTRlC2C5aA3067la/ZBQ4KVgsBCycLXZANzlk2S7WMKQNRRvRObUWj Q5P+nB2ihbp8/x7uidQVLenuAGEGq7vgYeaJfJsezEoxulk6nLmnwlLo/2Ncx9FxTwGW BMlwjqztQbkGIaSrFMusFDPg8lSwZmelYUY7cgMC5JwMCpI0GXzkf/WjD35diXb6SIT/ 8qpQ== X-Forwarded-Encrypted: i=1; AKwUvBw6nvXgdSvFKP4NC+oq+Q3mhGAp4UlWT+mYjkfC7ArD742Uc/5ijop0dcivKsPKs88/m1wKyYD3Atye0OY=@vger.kernel.org X-Gm-Message-State: AFuF++mvH07g51kyzTwUmXr2Z9fj5ExVYdpmSFFsTNH/gkBCrj/6woUI VYazYPmmqEI6NllBDgc3QfEkSg0FRdoP2wNeYJivHz2TihBDhQ0qts7c X-Gm-Gg: AYBFou0+02Pyp6gcKsnv/iTea5XjI9a9l9tie6LgBcre97s03K0zO2w3I977Z+sI3HH B/hIrqfhJV8ZvsmzdBiX6gd4nk/MaAsGOg8USqcG+crxgjl5fAK7DrJq9etLYHgqyZjLqmW+NF6 MBiKH+ThD156vAFKqeCelDZ1xe6Y3l0mtsYapfXCMZNfj/MwAosGU4jN/HKJ7k9D+cFLX1HJanP AWQIaMpP8dNdHISVrkiAzdGY02u0vCrBzZYfLkDzN9L+bTDRx0zKwcWGGgmuhBUfo7V5MFoRCyf p92EWJ8LSTxJfKX7H7ApGj4vsmuAGHWml42KSBa5npHLnvewEmBbeKlaIJ8FUxwPQpyVpL+CT0G n7LVkTEHdDHdlfvTqnt+nf7FnOjpahV08MvbXr5g73qEGuLChh/3lrRC+BbDmMr1KUcfIS/NrNn TSUntUUJ+ossaFN56AejtWdfOPVF29458uo7yFwXQWNS3EQ3l52h8yRw== X-Received: by 2002:a05:690c:d86:b0:89b:689d:3a6d with SMTP id 00721157ae682-89b689d3c27mr7212887b3.36.1789861915186; Sat, 19 Sep 2026 16:51:55 -0700 (PDT) Received: from localhost ([2600:1700:5431:250::3e]) by smtp.gmail.com with ESMTPSA id 00721157ae682-89a45d8f216sm12915647b3.14.2026.09.19.16.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 16:51:54 -0700 (PDT) From: Chang Yu To: Jonathan Cameron Cc: Chang Yu , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shi Hao , Joshua Crofts , "Jose A. Perez de Azpillaga" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/2] dt-bindings: iio: light: add as7343 Date: Sat, 19 Sep 2026 16:51:44 -0700 Message-ID: <20260919235145.48273-2-marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260919235145.48273-1-marcus.yu.56@gmail.com> References: <20260919235145.48273-1-marcus.yu.56@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add binding for AMS AS7343 which is a 14-channel multi-spectral sensor with i2c address of 0x39. The GPIO pin is not described because the datasheet does not document how to use it for hardware synchronization at all. The GPIO register also has no mode-select bit to isolate the pin from the chip's internal control logic. Exposing it as a generic GPIO could result in kernel writes being overwritten by internal logic. Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14= -Channel-Multi-Spectral-Sensor.pdf Signed-off-by: Chang Yu --- Changes in v5: - Remove the GPIO pin. Changes in v4: - Fix led-max-microamp property name. Changes in v3: - Add missing include for gpio. - Expand GPIO descrption to include hardware synchronization. - Use led-max-microamp instead of led-current-microamp for the LDR pin. Changes in v2: - Add the LDR, the interrupt pin, and the GPIO pin to the bindings. - Fix node name and unit address mismatch. - Include MAINTAINERS changes. .../bindings/iio/light/ams,as7343.yaml | 63 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as7343.= yaml diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml b/= Documentation/devicetree/bindings/iio/light/ams,as7343.yaml new file mode 100644 index 000000000000..cfb15fc551bf --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/ams,as7343.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AMS AS7343 14-Channel Multi-Spectral Sensor + +maintainers: + - Chang Yu + +description: | + The AMS AS7343 is a 14-channel multi-spectral sensor with i2c address of= 0x39. + https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel= -Multi-Spectral-Sensor.pdf + +properties: + compatible: + enum: + - ams,as7343 + + reg: + description: + I2C address of the device (0x39). + maxItems: 1 + + interrupts: + description: + Open drain output active low interrupt pin. + maxItems: 1 + + vdd-supply: true + + led-max-microamp: + description: + The driver current for the external LED connected to the LDR pin. + minimum: 4000 + maximum: 258000 + multipleOf: 2000 + default: 12000 + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + multispectral-sensor@39 { + compatible =3D "ams,as7343"; + reg =3D <0x39>; + interrupts =3D <7 IRQ_TYPE_LEVEL_LOW>; + vdd-supply =3D <&vdd_regulator>; + led-max-microamp =3D <14000>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 04fa5322d9f7..8cf4e1635053 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1430,6 +1430,12 @@ S: Maintained F: Documentation/devicetree/bindings/iio/light/ams,as73211.yaml F: drivers/iio/light/as73211.c =20 +AMS AS7343 DRIVER +M: Chang Yu +L: linux-iio@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/iio/light/ams,as7343.yaml + AMT (Automatic Multicast Tunneling) M: Taehee Yoo L: netdev@vger.kernel.org --=20 2.55.0 From nobody Thu Sep 24 21:47:06 2026 Received: from mail-yx2-f12.google.com (mail-yx2-f12.google.com [74.125.224.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4123397928 for ; Sat, 19 Sep 2026 23:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789861920; cv=none; b=Rk3uLOZRchKLm8AjUsirX6PY5Mo3Zq5uAPcnVn4CSVpkks+q3/y8OqEqRsoBChoAkbfwwPJ1oZHNcQXlDPLqoBoK7uDsqZnTVjZjycJWnEdYhf/S18JiGpCn+MRZzyHHiKAgmmoX98wHq/3rONd918GjjiBo2EZTysc6hs+Grn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789861920; c=relaxed/simple; bh=VwmprKLQoCHFZc9Uo6CtHKyINghfzNry28slffOXDYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sDFmYnxhFZDsNwYqRShP/mxJoGdNr0AnAW5V0yJeOkaBXBn567SbBryxQUbVx75tn0r1WSqak4RGYrrRiHi0kZA5FLgyt3fM2IhI74T1z1VCZIlXgXzrA38hAvkMFC4uk3yCmyh+NMDqY6fD8eL8ZNOnRX6g2DI5VzFn6ixwFsA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g2yXpw5S; arc=none smtp.client-ip=74.125.224.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g2yXpw5S" Received: by mail-yx2-f12.google.com with SMTP id 00721157ae682-8716a5baf64so14882477b3.3 for ; Sat, 19 Sep 2026 16:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789861918; x=1790466718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Vc9Tu/y+vhunPEjCTcdehpXIgarJUlQzXJbLmgfdtW4=; b=g2yXpw5S+7Cbf0RNC0unDBPROT2Eq7mbUP+YEqGGBO2JDpWs0A04inV/60GwLEzW9z ROmdZC08l+kvaesfmwt7N2RAN1d0fRyEoahDi3r1wOsnKTqJj/gn7TmxX+y5ZxQxZ8bJ r8MmVnqBxx7/QrofYmxpGdnYDe/n2vSUPPP11TSXwFpNFiFwOaFIpZkAV//SIL7saNt5 7KaU4H51upNSj+lxMvTDiAOoD7OMnU5n1AZyL/6jo1DjoWnmwrepzNS06h0XeKCH+yUL VbkOHrW4C8bWZJqDJ4KwGwNIkYnDjz4ImsQAqG0a0QixOyvpTC+JvLVkdEz31tY76JdH SDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789861918; x=1790466718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Vc9Tu/y+vhunPEjCTcdehpXIgarJUlQzXJbLmgfdtW4=; b=rpfNWreTPEEE3trgzJF2uC+nd5qWDD9MG7RGqPRMRRaHqEz7OKrOGL73xwSP2crXi4 1eHUSSZwYuenMkBTnHMm94F3KEOcuXSdMbqEEC2BSoI2iIbiGPDjnnZIKVJUECvhHdIX cSiBXHjfi41XqMk0Vy0z9PYff5ievzT+tvnqAsj9t2mwcYn31t2X5mDVP6kcQaNG+kBF xBal6VZYWE7OhFQLrGLbdmy6NAkoiLF2S6nwMBxB0x7kkY6ezMrw4Slz8HYiRNyAGpQm SxMjj6jTTPkSkhMgvSg7ElrNXrsv/1LdAzW8lDH0FfkidkWPm2dUWaW73i8x6tlo1BY6 Oc8w== X-Forwarded-Encrypted: i=1; AKwUvBxz53lHWeMqWWxVQYp20/R5uMGLtbT3ONgOrlQOf6ZqKTtmzkNTJ1wvD0jnAAgtlKLziVPJc3IGGFMasx0=@vger.kernel.org X-Gm-Message-State: AFuF++kDLt89Cq/Sb2S9IFacJ/7rcZg/Pa3NO5+bfATMWkRvhoItvFXc m5cnJLM/UbX5GE5Ssr4qHVAL/kviL/j2MnNzJVaOokVW8N3LSL55EwTw X-Gm-Gg: AYBFou3MdhHYxE/R4DyDx/VN2XqKMj18X0gG2CvWoFpeV82IP/sNQ1GNbQA/ncx/uAI Zbf3wKuPZvOawwCCwqwcd9z1tb4tgFLU7nTtnGG5oasaCecpiCpKQ+QDmswgmDTW/uGHpCROC0r BWu+VGA3HDbuG+48s+sBj18m1XWY/rBejsrfBPElUhqpAGD4184/lsJ1hwlkU7z+r90enD9nSyo e4TqALIt13MbAHY1MnuHI9/Q35I5Gim+tnYqc+GhX2o2bIHDN6z2Sze5OdF2vEi9pv8pAYo1BsX EHXIXMwW+3ayr0eZIlhfyabDNWIQuDTVun8C9wvdThGouLBxI/qZmpa1QFrei/Xfp2nkcBSjGSo xctCMQjNXkEvwJD9/pGR7n9HJ0LH+htwmW3kYSSCH2JuKMxgypKoisUgZhqV3N3QenvgyY6Ne3R Dohg2ZfYjVe77DGpPH9qhMIY4GTrsME9o5l9h7Xpjr4+00PTJVvC8hfQ== X-Received: by 2002:a05:690c:91:b0:878:6473:45c9 with SMTP id 00721157ae682-8973606fff0mr19066577b3.47.1789861917823; Sat, 19 Sep 2026 16:51:57 -0700 (PDT) Received: from localhost ([2600:1700:5431:250::3e]) by smtp.gmail.com with ESMTPSA id 00721157ae682-89a485c9fdbsm12410777b3.41.2026.09.19.16.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 16:51:57 -0700 (PDT) From: Chang Yu To: Jonathan Cameron Cc: Chang Yu , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shi Hao , Joshua Crofts , "Jose A. Perez de Azpillaga" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/2] iio: light: add AS7343 multi-spectral sensor driver Date: Sat, 19 Sep 2026 16:51:45 -0700 Message-ID: <20260919235145.48273-3-marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260919235145.48273-1-marcus.yu.56@gmail.com> References: <20260919235145.48273-1-marcus.yu.56@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a driver for the AMS AS7343 14-channel multi-spectral sensor. The AS7343 is a 14-channel spectral sensor featuring 11 visible channels, 1 near-infrared channel, 1 clear channel (VIS), and 1 flicker detection channel. The driver exposes 12 spectral channels (11 visible light and 1 near-infrared) via sysfs. Runtime PM is implemented to stop measurements when the device is suspended or torn down. Power is never cut (PON=3D1 always) to preserve register values. Future patches will add configurable gain and integration time, interrupt support, buffered reads, VIS channel, and flicker detection. Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14= -Channel-Multi-Spectral-Sensor.pdf Signed-off-by: Chang Yu --- Changes in v5: - Add autosuspend support. - Start measurements before configuring runtime PM. - Add functions for computing ASTEP and ATIME. - Sort registers by addresses. Changes in v4: - Use REGCACHE_MAPLE and add volatile register table. - Use PM_RUNTIME_ACQUIRE* when resuming. - Use a static array for labels. - Various code style fixes. Changes in v3: - Hold a mutex before reading measurements. - Add pm_runtime_resume_and_get before reading measurements. - Only start measurements after suspend action has been successfully registered - Check the return value of regmap_read when verifying device ID. Changes in v2: - Adjust the default gain to x256 and integration time to 50.1ms as recommended by the datasheet. - Use read_label instead of .extend - Remove all unused scan_index related constants. - Add missing calls to pm_runtime_* methods in probe. - Fix various code style issues MAINTAINERS | 1 + drivers/iio/light/Kconfig | 11 + drivers/iio/light/Makefile | 1 + drivers/iio/light/as7343.c | 441 +++++++++++++++++++++++++++++++++++++ 4 files changed, 454 insertions(+) create mode 100644 drivers/iio/light/as7343.c diff --git a/MAINTAINERS b/MAINTAINERS index 8cf4e1635053..236102b3c28e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1435,6 +1435,7 @@ M: Chang Yu L: linux-iio@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/iio/light/ams,as7343.yaml +F: drivers/iio/light/as7343.c =20 AMT (Automatic Multicast Tunneling) M: Taehee Yoo diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index ef36824f312f..edbeeba9d873 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -149,6 +149,17 @@ config AS73211 This driver can also be built as a module. If so, the module will be called as73211. =20 +config AS7343 + tristate "AMS AS7343 14-Channel Multi-Spectral Sensor" + depends on I2C + select REGMAP_I2C + help + Say Y here to build support for the AMS AS7343 14-channel + multi-spectral sensor. + + To compile this driver as a module, choose M here: the module will + be called as7343. + config BH1745 tristate "ROHM BH1745 colour sensor" depends on I2C diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile index 64e354c49ed8..5d0d33802519 100644 --- a/drivers/iio/light/Makefile +++ b/drivers/iio/light/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_APDS9306) +=3D apds9306.o obj-$(CONFIG_APDS9960) +=3D apds9960.o obj-$(CONFIG_APDS9999) +=3D apds9999.o obj-$(CONFIG_AS73211) +=3D as73211.o +obj-$(CONFIG_AS7343) +=3D as7343.o obj-$(CONFIG_BH1745) +=3D bh1745.o obj-$(CONFIG_BH1750) +=3D bh1750.o obj-$(CONFIG_BH1780) +=3D bh1780.o diff --git a/drivers/iio/light/as7343.c b/drivers/iio/light/as7343.c new file mode 100644 index 000000000000..c079e0c6aa70 --- /dev/null +++ b/drivers/iio/light/as7343.c @@ -0,0 +1,441 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Support for AMS AS7343 14-channel multi-spectral sensor. + * (7-bit I2C slave address 0x39) + * + * Based on the work of: + * Christian Eggers (AS73211 driver) + * + * Copyright (c) 2026 Chang Yu + * + * Datasheet: + * https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Chan= nel-Multi-Spectral-Sensor.pdf + * + * TODO: + * - Support for configurable gain and integration time + * - Interrupt support + * - Add support for reading the VIS channel + * - Flicker detection + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include + +#define AS7343_ID 0x5a + +#define AS7343_ENABLE_REG 0x80 +#define AS7343_ENABLE_PON BIT(0) +#define AS7343_ENABLE_SP_EN BIT(1) + +#define AS7343_ATIME_REG 0x81 +#define AS7343_STATUS2_REG 0x90 +#define AS7343_STATUS3_REG 0x91 +#define AS7343_STATUS_REG 0x93 +#define AS7343_ASTATUS_REG 0x94 + +#define AS7343_DATA_FZ_REG 0x95 +#define AS7343_DATA_FY_REG 0x97 +#define AS7343_DATA_FXL_REG 0x99 +#define AS7343_DATA_NIR_REG 0x9b +#define AS7343_DATA_F2_REG 0xa1 +#define AS7343_DATA_F3_REG 0xa3 +#define AS7343_DATA_F4_REG 0xa5 +#define AS7343_DATA_F6_REG 0xa7 +#define AS7343_DATA_F1_REG 0xad +#define AS7343_DATA_F7_REG 0xaf +#define AS7343_DATA_F8_REG 0xb1 +#define AS7343_DATA_F5_REG 0xb3 +#define AS7343_DATA_FD_L_REG 0xb7 +#define AS7343_DATA_FD_H_REG 0xb8 + +#define AS7343_STATUS5_REG 0xbb +#define AS7343_STATUS4_REG 0xbc + +#define AS7343_CFG0_REG 0xbf +#define AS7343_CFG0_REG_BANK BIT(4) + +#define AS7343_CFG1_REG 0xc6 +#define AS7343_CFG1_AGAIN GENMASK(4, 0) +#define AS7343_CFG1_AGAIN_X0_5 0 +#define AS7343_CFG1_AGAIN_X1 1 +#define AS7343_CFG1_AGAIN_X2 2 +#define AS7343_CFG1_AGAIN_X4 3 +#define AS7343_CFG1_AGAIN_X8 4 +#define AS7343_CFG1_AGAIN_X16 5 +#define AS7343_CFG1_AGAIN_X32 6 +#define AS7343_CFG1_AGAIN_X64 7 +#define AS7343_CFG1_AGAIN_X128 8 +#define AS7343_CFG1_AGAIN_X256 9 +#define AS7343_CFG1_AGAIN_X512 10 +#define AS7343_CFG1_AGAIN_X1024 11 +#define AS7343_CFG1_AGAIN_X2048 12 + +#define AS7343_ASTEP_REG 0xd4 + +#define AS7343_CFG20_REG 0xd6 +#define AS7343_CFG20_AUTO_SMUX GENMASK(6, 5) +#define AS7343_CFG20_AUTO_SMUX_READOUT_ALL 3 /* all-channel readout */ + +#define AS7343_FD_STATUS_REG 0xe3 +#define AS7343_CONTROL_REG 0xfa +#define AS7343_FIFO_LVL_REG 0xfd +#define AS7343_FDATA_L_REG 0xfe +#define AS7343_FDATA_H_REG 0xff + +/* AS7343 channel indices. MUST match data register order above. */ +#define AS7343_CHAN_IDX_FZ 0 +#define AS7343_CHAN_IDX_FY 1 +#define AS7343_CHAN_IDX_FXL 2 +#define AS7343_CHAN_IDX_NIR 3 +#define AS7343_CHAN_IDX_F2 4 +#define AS7343_CHAN_IDX_F3 5 +#define AS7343_CHAN_IDX_F4 6 +#define AS7343_CHAN_IDX_F6 7 +#define AS7343_CHAN_IDX_F1 8 +#define AS7343_CHAN_IDX_F7 9 +#define AS7343_CHAN_IDX_F8 10 +#define AS7343_CHAN_IDX_F5 11 + +#define AS7343_CHAN(_chan) \ + { \ + .type =3D IIO_INTENSITY, \ + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), \ + .address =3D AS7343_DATA_##_chan##_REG, \ + .indexed =3D 1, \ + .channel =3D AS7343_CHAN_IDX_##_chan, \ + } + +static const struct iio_chan_spec as7343_channels[] =3D { + AS7343_CHAN(FZ), AS7343_CHAN(FY), AS7343_CHAN(FXL), AS7343_CHAN(NIR), + AS7343_CHAN(F2), AS7343_CHAN(F3), AS7343_CHAN(F4), AS7343_CHAN(F6), + AS7343_CHAN(F1), AS7343_CHAN(F7), AS7343_CHAN(F8), AS7343_CHAN(F5), +}; + +/* + * Integration time is calculated as (ATIME + 1) * ((ASTEP + 1) * 2.78us). + * ATIME must be between 0 and 255, inclusive + * ASTEP must be between 0 and 65534, inclusive + */ +static inline u8 as7343_atime_steps(unsigned int step) +{ + BUILD_BUG_ON(step < 1 || step > 256); + return step - 1; +} + +static inline u16 as7343_astep_x2780ns(unsigned int n) +{ + BUILD_BUG_ON(n < 1 || n > 65535); + return n - 1; +} + +struct as7343_data { + struct regmap *regmap; + /* Ensures reads don't stomp on each other */ + struct mutex mutex; +}; + +static int as7343_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct as7343_data *data =3D iio_priv(indio_dev); + struct regmap *map =3D data->regmap; + struct device *dev =3D regmap_get_device(map); + unsigned int unused; + __le16 result; + int ret; + + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) + return ret; + + switch (mask) { + case IIO_CHAN_INFO_RAW: { + /* Wait until integration time passes for all 3 cycles. */ + msleep(160); + + /* + * Reading ASTATUS latches all data registers to this read. + * We don't care about the returned saturation/gain status for + * now. + */ + guard(mutex)(&data->mutex); + + ret =3D regmap_read(map, AS7343_ASTATUS_REG, &unused); + if (ret) + return ret; + + ret =3D regmap_bulk_read(map, chan->address, + &result, sizeof(result)); + if (ret) + return ret; + + *val =3D le16_to_cpu(result); + return IIO_VAL_INT; + } + + default: + return -EINVAL; + } +} + +/* + * Channel names and wavelength ranges as defined in the datasheet + * (Figure 7, "AS7343 Optical Channel Summary"). Values are the + * minimum and maximum peak wavelength in nanometers. + * + * F1: 395-415 nm + * F2: 415-435 nm + * FZ: 440-460 nm + * F3: 465-485 nm + * F4: 505-525 nm + * FY: 545-565 nm + * F5: 540-560 nm + * FXL: 590-610 nm + * F6: 630-650 nm + * F7: 680-700 nm + * F8: 735-755 nm + * NIR: 845-865 nm + */ +static const char * const as7343_channel_labels[] =3D { + [AS7343_CHAN_IDX_F1] =3D "F1: 395-415 nm", + [AS7343_CHAN_IDX_F2] =3D "F2: 415-435 nm", + [AS7343_CHAN_IDX_FZ] =3D "FZ: 440-460 nm", + [AS7343_CHAN_IDX_F3] =3D "F3: 465-485 nm", + [AS7343_CHAN_IDX_F4] =3D "F4: 505-525 nm", + [AS7343_CHAN_IDX_FY] =3D "FY: 545-565 nm", + [AS7343_CHAN_IDX_F5] =3D "F5: 540-560 nm", + [AS7343_CHAN_IDX_FXL] =3D "FXL: 590-610 nm", + [AS7343_CHAN_IDX_F6] =3D "F6: 630-650 nm", + [AS7343_CHAN_IDX_F7] =3D "F7: 680-700 nm", + [AS7343_CHAN_IDX_F8] =3D "F8: 735-755 nm", + [AS7343_CHAN_IDX_NIR] =3D "NIR: 845-865 nm", +}; + +static int as7343_read_label(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, char *label) +{ + int channel =3D chan->channel; + + if (channel < 0 || channel >=3D ARRAY_SIZE(as7343_channel_labels)) + return -EINVAL; + + return sysfs_emit(label, "%s\n", as7343_channel_labels[channel]); +} + +static const struct iio_info as7343_info =3D { + .read_raw =3D as7343_read_raw, + .read_label =3D as7343_read_label, +}; + +static const struct regmap_range as7343_volatile_ranges[] =3D { + regmap_reg_range(AS7343_ENABLE_REG, AS7343_ENABLE_REG), + regmap_reg_range(AS7343_STATUS2_REG, AS7343_DATA_FD_H_REG), + regmap_reg_range(AS7343_STATUS5_REG, AS7343_STATUS4_REG), + regmap_reg_range(AS7343_FD_STATUS_REG, AS7343_FD_STATUS_REG), + regmap_reg_range(AS7343_CONTROL_REG, AS7343_CONTROL_REG), + regmap_reg_range(AS7343_FIFO_LVL_REG, AS7343_FDATA_H_REG), +}; + +static const struct regmap_access_table as7343_volatile_table =3D { + .yes_ranges =3D as7343_volatile_ranges, + .n_yes_ranges =3D ARRAY_SIZE(as7343_volatile_ranges), +}; + +static const struct regmap_config as7343_regmap_config =3D { + .name =3D "as7343", + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D AS7343_FDATA_H_REG, + .reg_format_endian =3D REGMAP_ENDIAN_LITTLE, + .val_format_endian =3D REGMAP_ENDIAN_LITTLE, + .cache_type =3D REGCACHE_MAPLE, + .volatile_table =3D &as7343_volatile_table, +}; + +static int as7343_setup_device(struct device *dev, struct as7343_data *dat= a) +{ + struct regmap *map =3D data->regmap; + unsigned int val; + __le16 step; + int ret; + + /* Power on */ + ret =3D regmap_set_bits(map, AS7343_ENABLE_REG, AS7343_ENABLE_PON); + if (ret) + return ret; + + /* Need to set REG_BANK to 1 before we can access ID */ + ret =3D regmap_update_bits(map, AS7343_CFG0_REG, AS7343_CFG0_REG_BANK, + FIELD_PREP(AS7343_CFG0_REG_BANK, 1)); + if (ret) + return ret; + + ret =3D regmap_read(map, AS7343_ID, &val); + if (ret) + return ret; + + if (val !=3D 0x81) + dev_info(dev, "Unknown device ID: %x\n", val); + + ret =3D regmap_update_bits(map, AS7343_CFG0_REG, AS7343_CFG0_REG_BANK, + FIELD_PREP(AS7343_CFG0_REG_BANK, 0)); + if (ret) + return ret; + + /* Configure the SMUX to readout all channels */ + ret =3D regmap_update_bits(map, AS7343_CFG20_REG, AS7343_CFG20_AUTO_SMUX, + FIELD_PREP(AS7343_CFG20_AUTO_SMUX, + AS7343_CFG20_AUTO_SMUX_READOUT_ALL)); + if (ret) + return ret; + + /* + * Setting a 600 * 2.78us * 30 =3D 50ms integration time as the default + * for now. + */ + step =3D cpu_to_le16(as7343_astep_x2780ns(600)); + ret =3D regmap_bulk_write(map, AS7343_ASTEP_REG, &step, sizeof(step)); + if (ret) + return ret; + + ret =3D regmap_write(map, AS7343_ATIME_REG, as7343_atime_steps(30)); + if (ret) + return ret; + + return regmap_update_bits(map, AS7343_CFG1_REG, AS7343_CFG1_AGAIN, + FIELD_PREP(AS7343_CFG1_AGAIN, + AS7343_CFG1_AGAIN_X256)); +} + +static int as7343_suspend(struct device *dev) +{ + struct iio_dev *indio_dev =3D dev_get_drvdata(dev); + struct as7343_data *data =3D iio_priv(indio_dev); + struct regmap *map =3D data->regmap; + + return regmap_clear_bits(map, AS7343_ENABLE_REG, AS7343_ENABLE_SP_EN); +} + +static int as7343_resume(struct device *dev) +{ + struct iio_dev *indio_dev =3D dev_get_drvdata(dev); + struct as7343_data *data =3D iio_priv(indio_dev); + struct regmap *map =3D data->regmap; + + return regmap_set_bits(map, AS7343_ENABLE_REG, AS7343_ENABLE_SP_EN); +} + +static void as7343_suspend_action(void *dev) +{ + as7343_suspend(dev); +} + +static int as7343_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct iio_dev *indio_dev; + struct as7343_data *data; + struct regmap *regmap; + int ret; + + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); + if (!indio_dev) + return -ENOMEM; + + i2c_set_clientdata(client, indio_dev); + + regmap =3D devm_regmap_init_i2c(client, &as7343_regmap_config); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + data =3D iio_priv(indio_dev); + data->regmap =3D regmap; + + ret =3D devm_mutex_init(dev, &data->mutex); + if (ret) + return ret; + + indio_dev->name =3D "as7343"; + indio_dev->info =3D &as7343_info; + indio_dev->channels =3D as7343_channels; + indio_dev->num_channels =3D ARRAY_SIZE(as7343_channels); + indio_dev->modes =3D INDIO_DIRECT_MODE; + + ret =3D devm_regulator_get_enable(dev, "vdd"); + if (ret) + return ret; + + ret =3D as7343_setup_device(dev, data); + if (ret) + return ret; + + /* Start measurements */ + ret =3D regmap_set_bits(regmap, AS7343_ENABLE_REG, AS7343_ENABLE_SP_EN); + if (ret) + return ret; + + pm_runtime_set_autosuspend_delay(dev, 3000); + pm_runtime_use_autosuspend(dev); + + ret =3D devm_add_action_or_reset(dev, as7343_suspend_action, dev); + if (ret) + return dev_err_probe(dev, ret, + "Failed to add suspend action\n"); + + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret) + return dev_err_probe(dev, ret, + "Failed to activate PM runtime\n"); + + return devm_iio_device_register(dev, indio_dev); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(as7343_pm_ops, + as7343_suspend, as7343_resume, NULL); + +static const struct of_device_id as7343_of_match[] =3D { + { .compatible =3D "ams,as7343" }, + { } +}; +MODULE_DEVICE_TABLE(of, as7343_of_match); + +static const struct i2c_device_id as7343_id[] =3D { + { .name =3D "as7343" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, as7343_id); + +static struct i2c_driver as7343_driver =3D { + .driver =3D { + .name =3D "as7343", + .of_match_table =3D as7343_of_match, + .pm =3D pm_ptr(&as7343_pm_ops), + }, + .probe =3D as7343_probe, + .id_table =3D as7343_id, +}; +module_i2c_driver(as7343_driver); + +MODULE_AUTHOR("Chang Yu "); +MODULE_DESCRIPTION("AS7343 14 Channel Multi-Spectral Sensor driver"); +MODULE_LICENSE("GPL"); --=20 2.55.0