From nobody Thu Sep 24 21:48:27 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833A930B53E for ; Sat, 19 Sep 2026 17:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789840170; cv=none; b=EEDWr3bot/ZjcD264WxoSKJy1dfmE9lWgejf87rfktBEdcdi27yoBYGI3fAc4DPeLN3VlhL7F6OZHd8yIOK8OyK1v77wzZOSyubsJ20jTmdBIisLYuMln706R2z7/D2e6Ff9rCkCYNObPV3W+QQBLRcaW4mFSWE/To4Xhw8hL6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789840170; c=relaxed/simple; bh=g6tsjX6Qa/+gUKGSA+7Kv+QYuIKzwo+FzO1cUxU6D7I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NvFpaXZb8jobKHVfcWO3rIH4Cvn4RtJZ/hLYMCJL/+WrX/jNEpx4opTVB8+xae3YaNd7ATre9/2sablZe3VdDZubmLs97l/Cps6XjI2uwLXlNQH6oU8/hDU1LtqQyNC/8bWhjYqnDmPzloLvwrhd39pmmEKoL7SBkLbctPDhTAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BVP5UP2a; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BVP5UP2a" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-39b9184fa80so1643161a91.2 for ; Sat, 19 Sep 2026 10:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789840169; x=1790444969; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GMcAlqV/8gbRvywKZc2/TEvRO6KQIityZ14E3909GDg=; b=BVP5UP2aW+2uHY3qAE4/6Zk6A93dSwyAhMeED0JxnSybyosnaeXzuYlEEr1dZiBVhN d0K1nol3825CTjwTo46tEIAVP3NHaDapyiIP8JviZ0vq5zFf6KZ2wT0mq8fFbPVvSjEC FXfQ+9fKZbkBw3ylxmrYLScG2IzUMMgjfXrWyQmKkfu6mND/QuUiV8b6zPs9wUb/7ypO bK87KU4ctFDjcuf94jYlrMean+x4fon2KIO+rtBhHl5X9bX5vuhBFnoUwyohGVnA+5mP NfCc1VJj0sBzPBnNsiSE6B7ZTlJcp8Zo4RaisAsmIjeOWY3N87xAU7tufhHo5UFiXXaX xpmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789840169; x=1790444969; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GMcAlqV/8gbRvywKZc2/TEvRO6KQIityZ14E3909GDg=; b=VVtTe4U9QeB+dEqjCXzFLJioXqP5L+F4Ai+BieVIqK+XroYiMBdhuSH/GF1hviPI8T iRYMBVC8eEQ+2JtdwwIwBJr5aIJ2gbIdn7uag2QV5K7T3q6TdgLrocImAVK1iN4yUGI3 XfR/XztZrsC8d4e472faPCBGce6z9Yqx6deDflVPYHS5A68JFUAtX+4MHTEp0Nci2Fy5 hr2Y8krpbM2wlLxAKl5fNj7M+1HoGPGrhtdaY2vo1kleVwRzHG9MMExb7ndqYTD0o4av diMOhXAQBwBGT3lFSoSKdbVilMx0Dg0cs4EABnW9iU2PqHwzQSbYO0IA0hBW7xYs3dCz mBMQ== X-Forwarded-Encrypted: i=1; AKwUvBymAinAXzYco8qZAgbRGmssssll9llcEeRPGprKWInizIUUvPYlqowq9p7+N/X4Z5Q5gzvI7PQsSXbVmks=@vger.kernel.org X-Gm-Message-State: AFuF++kjwMsAF+g9d0l8f88ueMvnxMpUy9Bcu+45ce8nm9401GRhEiE3 DlTqgLv8avwztJlww17xIVkEzC4Av+A4Ye91oJ94bgPFFPW2AqxZRDdm X-Gm-Gg: AYBFou1412O44XOxx0NBIWQsE21wSnjllox0TdGgckBWr4nn/BPRBLy2wjaEg4pxMAa KUqfv3gb82m0ZY0vcX6jP1QT599lPfwzjPql80bit8+GySNMv9KsOKL79iWT337gd94FMQ7ENyG Lh0QONWtAr6BuQAlsOgYlunLAZgRncZ6TXuruhZcuaX0cYkwbWBwxIdDasn2P13N6MwVps7936H MB5oiXHN1q8aGI+SS1pO9fK7OVaPDocuj+eypSlN0n/3AHn4dC5DqN45pLDu44tOku9Q9zqi2O/ oLdZZh29tU/yhMK+QKO2oLjaRus/i/NtZCaWQ4Fr3ipcZPUbdNBvGv6MwxxYZy5bjZQ3qE1XlES yPe6P50BIx9eQfEtF+9HLKxmAFDDFp37LB+ZshsLrM3LwHMuYRMdl96/YN1V7FnmcPj2LnM2uRg dyJRLQsdwU8P0CZ44wOpkGBv4jEHuoCHChTy2/Pky53h/CQYtDy8usuW7amK21O2dst7zz X-Received: by 2002:a17:90b:4c46:b0:366:3517:1aa2 with SMTP id 98e67ed59e1d1-39e54922644mr15032744a91.0.1789840168712; Sat, 19 Sep 2026 10:49:28 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e6d83e253sm2082331a91.1.2026.09.19.10.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 10:49:28 -0700 (PDT) From: Guangshuo Li To: Ram Vegesna , "James E.J. Bottomley" , "Martin K. Petersen" , Kees Cook , Guangshuo Li , Daniel Wagner , James Smart , Hannes Reinecke , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] scsi: elx: efct: fix Scsi_Host memory leaks on add failure Date: Sun, 20 Sep 2026 01:48:35 +0800 Message-ID: <20260919174835.3729156-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" efct_scsi_new_device() and efct_scsi_new_vport() allocate a Scsi_Host with scsi_host_alloc() before registering it with scsi_add_host_with_dma(). If scsi_add_host_with_dma() fails, both functions return without dropping the initial host reference returned by scsi_host_alloc(). Although scsi_add_host_with_dma() unwinds the resources acquired while adding the host, it does not release that initial reference. As a result, scsi_host_dev_release() is never reached and the Scsi_Host allocation is leaked. Call scsi_host_put() on both failure paths so the initial reference is dropped and scsi_host_dev_release() can free the host. Also clear efct->shost on the physical host failure path since it is assigned before the host is registered. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/scsi/elx/efct/efct_xport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/elx/efct/efct_xport.c b/drivers/scsi/elx/efct/efc= t_xport.c index 9dcaef6fc188..c00ad9176aee 100644 --- a/drivers/scsi/elx/efct/efct_xport.c +++ b/drivers/scsi/elx/efct/efct_xport.c @@ -416,6 +416,8 @@ efct_scsi_new_device(struct efct *efct) &efct->pci->dev); if (error) { efc_log_debug(efct, "failed scsi_add_host_with_dma\n"); + efct->shost =3D NULL; + scsi_host_put(shost); return -EIO; } =20 @@ -930,6 +932,7 @@ efct_scsi_new_vport(struct efct *efct, struct device *d= ev) error =3D scsi_add_host_with_dma(shost, dev, &efct->pci->dev); if (error) { efc_log_debug(efct, "failed scsi_add_host_with_dma\n"); + scsi_host_put(shost); return NULL; } =20 --=20 2.43.0