From nobody Thu Sep 24 22:56:43 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B4242885A for ; Fri, 18 Sep 2026 18:13:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789755218; cv=none; b=pY7SEjWuFzs10qOjTJbpT+EJTeOolklIDlRwF1fOTgl0LY92iw+9XTBhgA0ns9NWDzN/cXmBTAIhykppLLoSgPO7kt7p2ffeOrTnT88W+j5yhw1C7t3S63JnLtt3LR+CNC19aPbDHtrhNmTwb6QhGMO0gLA/b5H8+5fXmJdX2WE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789755218; c=relaxed/simple; bh=jxB51OTaF8ZQDmHlLnMOrVw7Z/Ws4WNrUhbIMMa/FPY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BwwZ0CUlT1rSknCibYfoSzGUMyuPtOMALiUOXIvz5WSl918h3N+aDenFA1iCE5RCduAVZUUXLtuY2BT5nMAjg2DdLKlDn7tB75F+oYrEyuk2JGiNGovw3wSM84ZpDxz4MkKLszfF7VJopcwYpPSfAuKd6Q7BcL042ZU/UWBy2WU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M44kfKPW; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M44kfKPW" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2db1ca06a25so7774595ad.2 for ; Fri, 18 Sep 2026 11:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789755216; x=1790360016; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=shS485b8tZfkhk79R4MyxZiHCFajwa7fKOgCDdDkLAw=; b=M44kfKPWKda/HQ54Lt3AI06EuzRL5MzqGj+Ht2X1/cHXTPkh30UTbI6D7FpYB1tsiO 244NTerQ1oOA2MYCE8fqDDQ0LPQOCjIxo6a+qEmAsD9HqJSvuY/K1AGPxhOJnFkb9PJk mCmWAe6tARA8Js0hFMIelim+afhECSapODYiiZitQF7XqbebCqvF0uBtpCscJ4rLm/EB J14zTg6cAJqkmhixjA78k7BHWMiguDofXXh7Xzsmhw5I6jLhjmu3CLf8F78b5J6aOXfl feb6JEsF3ZWS7skzm4tpoZTpXqbjr0h/Q5HkeqM2DoqbInHjdPzOI2PjCIsbvTm/sUAT 94dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789755216; x=1790360016; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=shS485b8tZfkhk79R4MyxZiHCFajwa7fKOgCDdDkLAw=; b=jQ+pAtPRaFanYHGpSF5NdPzIkX40a3PEFmNcgawRhdoUGnFFqlSTNekUDsnZpO98Se N7Fo72IjsL2WRHmXdsTi+btFINf5w+nxzxVSKZzUNgRPpPzWfAZt0FopM7MiAM0qeuGH XqhZ8wl+6uTyQxx9fqFC3EwHsJnnBsfoWYOkX9KX1yQwfBMLIpbR4oLmMuNDAZJt3Ieu r00QvdNzEL90gUjQvYRF2e7LXoKFqHDgUPoZnD7ayjd0V6ATYkiq9QoyPcZ+Xh2OrQ+o CCIIykvD4khBntXJqdv++DCSk9pAnU9ea2tSqRfBM9/2YR2E+GukRHbgWqWsYeTDxmpo ugVQ== X-Forwarded-Encrypted: i=1; AKwUvBwsxCy7DbsDR5VSUM5ltx+SMeUtfdS+YNyfDWg/ghzlcgQP0hKfnaYoKtPA8h1o/EYMhwjfOLGh2b8kqvg=@vger.kernel.org X-Gm-Message-State: AFuF++mmC5qR9sNQpZLPxQSAPHyg2ecGYHvVEGw9s8hdNpDYTfM2wTYj azPwuxzEpZ88zj53dS3cSnraZOWD6oCNgtMn3KhL6Dvus9LwgGbq34FI X-Gm-Gg: AYBFou1jBnntrk0i2R17Cub7s0+vAvugLDhxyho1qyiWlcdtj+sFe024gXaOIW1w9xE 0dZzIzoN5im5vGTRhpogv33jbyrW+0YkFAOiQQV5tiiLjVkrPvRFcSaJNkwv/8jEN92VtbtSfRn OifejCl8hHrWAjm5nlDQzwWspQKHeYCSrTFQOc1YdnXpf0salYfHJe/rIH6brjvMlB3v0/FHE5u opJSEWVMF3lZFhuwkVOiAe6OERBNKjzG4jpFD1VUXpkDZsBcO9y0MOr1r1rYWUEQlAPO97Ce6nY InagJR8X9kVMQEjabNtATBBywyhO4DvFDbxDvR7qflFvvhEY+aUShlDKvrcIuHvX7x8BsxYHxEr kyIsPGWwbO7NB+tPEbM9SqWS86pOnMRZ0F1VNcbbub3GxYr0xNjv0awot9ojn01ross/S1zevXJ BDeJb6egqYw6pky9BKOvhlxw7+lyGU/PLSKUwSdlOYXY2CsasFEUv9cQJ15kNnKp/4 X-Received: by 2002:a17:902:e751:b0:2c8:2808:3ec9 with SMTP id d9443c01a7336-2ddb1ae69b7mr68800035ad.12.1789755215937; Fri, 18 Sep 2026 11:13:35 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ddc1788bcasm662465ad.21.2026.09.18.11.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 11:13:35 -0700 (PDT) From: Guangshuo Li To: Ram Vegesna , "James E.J. Bottomley" , "Martin K. Petersen" , Sebastian Andrzej Siewior , Guangshuo Li , Thomas Gleixner , Kees Cook , Daniel Wagner , Hannes Reinecke , James Smart , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] scsi: efct: clear MWI on remove Date: Sat, 19 Sep 2026 02:13:26 +0800 Message-ID: <20260918181326.3633765-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi(). The probe failure path clears this state with pci_clear_mwi(), but the normal remove path does not perform the corresponding cleanup. pci_disable_device() only disables PCI bus mastering and does not clear the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can remain enabled after the driver is removed. Call pci_clear_mwi() in efct_pci_remove(), matching the probe error path. This issue was found by manual code inspection. Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Daniel Wagner --- drivers/scsi/elx/efct/efct_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/elx/efct/efct_driver.c b/drivers/scsi/elx/efct/ef= ct_driver.c index 07c2f453459e..720bad7b3517 100644 --- a/drivers/scsi/elx/efct/efct_driver.c +++ b/drivers/scsi/elx/efct/efct_driver.c @@ -613,6 +613,7 @@ efct_pci_remove(struct pci_dev *pdev) =20 pci_release_regions(pdev); =20 + pci_clear_mwi(pdev); pci_disable_device(pdev); } =20 --=20 2.43.0