From nobody Fri Sep 25 00:03:42 2026 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF2C43DEAB for ; Fri, 18 Sep 2026 17:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789754325; cv=none; b=SkFKw5gvQSOjw5v4UBNm/EBMeb2kaiDGCXCHUeyWL1nzodCHjathbJQCi+redPqdCbPHiNX9pkE4owtAi6Z1ph9cYgM/K8Jl7j0z7fRfxuSPQTXfSMdiT7PHglQTgaE55yKlgo0wB3KZQY7MzXhrgSEtfs3gFZahDfqRMGdOGkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789754325; c=relaxed/simple; bh=+Mg8EFKwkdqT02bF8v5cO7MWrzRs8xUgBeDxWVc0CRQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HohIn4Cv7U4hvVhR2vNR6kJBgwTrhCo7Yf/Zvyl29oMWROOpnJq/Gx5emeLp4K/4t1VUIiwtmLL/GJ2cW/z5SsESL4rPfaCw+1RWUoj5jaLFhpftQCgxT49BXVcZWaD2uWoqSO1L0OXjsGy5h+uDT+R6Ly2ot/Hyg8wId9+Vqe4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fE1F9aJm; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fE1F9aJm" Received: by mail-pj2-f43.google.com with SMTP id d9443c01a7336-2d747ee1f38so10277525ad.2 for ; Fri, 18 Sep 2026 10:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789754324; x=1790359124; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=O/ALC021jyvVUyJohqb4fsm6d/IW7/IWPNFCS11cgBw=; b=fE1F9aJmB8BeDwV5Pn8zC+aM1dgaj6b5bMxVYpPhB0FEHMdWHtCbffU748nNFm46nC k8p66fUD3uXbQxfBw0N2LEYn9LLVohpTGcdjy137d8r1F+c0dv4UBZBQW/mK2DhwEJyv e7EJ8OYZStYQ/a4A+0yQ8i85izNH7t57aWcUPyb99Cv8pszFXkJ6NSMkF4/uMot80sq0 cQHC0oDa2k8B4pEiaEV9oNQBzqZpQzc+cJ7SfqydecfxNFslaLL2UzjO/10QBKR28ePH udYrllwNAt46HSd5PWm/E+OFlpOm1VCNROeQSZ/WCgy1nq5K3mGnXp+64fSoUi3ha5yd DnVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789754324; x=1790359124; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O/ALC021jyvVUyJohqb4fsm6d/IW7/IWPNFCS11cgBw=; b=QWkVpTDQFfbz7Kvy3poW78ioijn1H77BdgLxkhNTTV1hnh+TXL1lNUslR1a3bFsCKu vHzXgV65pOZIMB8jnUaKeFZfVToSWMAGlzo+reAet2Qz8ygQPoILeBkFF3Tv+hDcx9Vo TtlsSlFNq15hrsboNXq7tkoluVewlCQ47HUYSqhOQUJVybxgVA4VqO/uEMVxFBz/fO67 Z85OYR1aJZthpseSXETnR5VxTVk7Tbb9rSA/yuecUly3wIKfZOEePaOWlJE1fULy4YsH IekWkpR9YzReTDk3H13lnkZY96k+IF9QSXAo9JkjVMWiJWybPnxDANQWqL+pCL/03K2v B9LQ== X-Forwarded-Encrypted: i=1; AKwUvBzH2sEqDx0PP3PdLWTrgCnXBqlPw0srOd/MYBk7XAOBH3io2ouz9/TMlg0ZbUhNnwkSQZjUbCn5DA6GSEM=@vger.kernel.org X-Gm-Message-State: AFuF++l+yRJJ4Q2qE1SohDMkuI27HEF9NeOxKvLar390i+PY2fgf3dg0 +ALYW5P2q/qIHLDBU7pP/vcyNDt3uPtlhuq0PwLR+sLT9sqE85OxtRLZ X-Gm-Gg: AYBFou2SrLn/ed1tZivB9Wa7n632Rz6yDnBph0AGniPV74mUbk9MifKEcxdFZSMs/Xn ZNlqyzipFgPsMJ6+RnSnyn4VsBlSV5knCE9HiMjs6HLJNmtxuo4Of9aI/w86App0UgKgYkH0jLx dD6eI+S/kh9YJd0ql3JuKe3FyY9dMkjRE9+VkaXu5N6SFFjsbCa7qUXW3QcNy4AJTncR2RRTe2Y tM+9Pmuoc66VA6WNUi9+SLENBNUMNCDqfMiRzEQKeHo3l0fePiJJnzXDNHTjE4J+u1iMUpTD7mY eD7JejxUQPnnI/jyGCuXeLw5XmoVNCrTCRfbcDnnxiYwdhcmypkBagnVDWfWAyEXHSk6t50mcc2 eHc3vH8p/Va+R7P42NqNFB+gm5+lTa2jYG5elC7X+YZ3AJ/lZ9zXDHy2mY9CjhkYI9E1g/7zMc3 9JMfiv5zAKFeaGDoMqsN6krOp/AHJEERYiioYchWexexmLJLd/C2B8xw== X-Received: by 2002:a17:902:d592:b0:2dd:c100:7cb6 with SMTP id d9443c01a7336-2ddc1007d6amr4356465ad.50.1789754323643; Fri, 18 Sep 2026 10:58:43 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ddc16b471fsm682465ad.3.2026.09.18.10.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 10:58:43 -0700 (PDT) From: Guangshuo Li To: "James E.J. Bottomley" , "Martin K. Petersen" , Thomas Bogendoerfer , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] scsi: sun3x_esp: unmap registers on remove Date: Sat, 19 Sep 2026 01:58:35 +0800 Message-ID: <20260918175835.3622269-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" esp_sun3x_probe() maps both the ESP registers and DMA registers with ioremap(). The probe failure path unmaps both regions, but the normal remove path does not perform the corresponding cleanup. As a result, both MMIO mappings remain allocated after the driver is removed. Unmap the DMA and ESP register regions before releasing the SCSI host, matching the probe error path. This issue was found by manual code inspection. Fixes: 0bb67f181834 ("[SCSI] sun3x_esp: convert to esp_scsi") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/scsi/sun3x_esp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c index 365406885b8e..101d3b0f8f2f 100644 --- a/drivers/scsi/sun3x_esp.c +++ b/drivers/scsi/sun3x_esp.c @@ -259,7 +259,8 @@ static void esp_sun3x_remove(struct platform_device *de= v) dma_free_coherent(esp->dev, 16, esp->command_block, esp->command_block_dma); - + iounmap(esp->dma_regs); + iounmap(esp->regs); scsi_host_put(esp->host); } =20 --=20 2.43.0