From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E824E0B8F; Fri, 18 Sep 2026 10:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727015; cv=fail; b=R8Nq31gn230iTcbtJhk8iI3nXMBoriBQsrAuw0orx7t1glj/Z8km5LaMv2++I8n7z1Z83lA0/9sppcCECpitOJ8rnaeM601uWPxKaXIP6EHYApp7SNVL10q+XevQPDHPgLpqoC1jDRE0GMyRnoeCuAE75KoajLrLqY4mquk7EC4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727015; c=relaxed/simple; bh=3l+N7VRjb7sCYwjUPdOx+NEFhmC5BVJCOEULINgQzmA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pv6c0eMFY0tDWoogomY6CjRkvAn3bWz3YQc8IXmVm5vJOleY2p/re2/Ql2MwzYhfqC43TyXpwhXvjshFQAiWIzRnWWeo67FXVV/+GJsRIErKlteBvSe6xKc9K9O9bIpCRamIF1Kwa5GyuxRQP0/gFkj+W+ON9nXdOpjHHijB36w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=HbFZOKuN; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=d7qeefdm; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="HbFZOKuN"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="d7qeefdm" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9d8cY1233705; Fri, 18 Sep 2026 05:23:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87 no=; b=HbFZOKuNhjIQSwByOyKAWl5EkyU3JVgrO7p8g9co5ZxUyhDUgKFWAgbdN ZuUIKg9dfA7w1Cfe3jfbA3tJh1jruW+NRNlp9EKAuPqEg5EqFqH65Hk89J+96A7G 7gdjUFlslf/Hko0QnZV2sZ2EQutvoaqcV/lgvu4uJMA2V7HOLG3Pwq/l4l8xMbPs j6Tru+s8auR0vcl/Ad5/MYKW+Y5LkR3AfZnwchFM3keMnIJ564kL90wqePiSi50E 81uG3hdQu2ad6zR5NVFeCEs/m4NIvnlSdpQKzxK6priqdLmHejPDmeCpUN4CJZW0 n3wfcQ31uGLNEfJna9tPe5Y9c9aPw== Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11011052.outbound.protection.outlook.com [40.93.194.52]) by m0384305.ppops.net (PPS) with ESMTPS id 4gs2ux07au-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:28 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gQr2lBOns8CkXj169ZI7+77oos5Yw4ujL6tzKbXaBX+aA2mE8kl2T9BSItPdzyfMuykXzh+wjbOnlIOwwUSFM0S99w9aqv76PwGKs6aTyYOOMo9RPdacOtc4Er9Tio6OCy2jZofrBgsuvsLDW9Wc9E1lGRI7T+kk8Nyng7j0rUtBW3q+Z4XjgVUZ8whRHiQNSZCPwE8qUhLIM7OtYq6E0MEK0o7lCDrPAEYYWFHWwnghQqiWjNGKu1JR2ewmxRHj9G1WC+KCB4VtfjJGuhAHn0Yg2FQeewaY9xyWiAQckJvPHj4zAfqacXy8FrGRlqK/CndlnPiLQIPuX99FoBf4zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=Ppi44EOh8IKT9G4EvXrKk9NixHgnFKUfpNYSlan5zxCCsTvQcwoagK/z2isWLhkLTG+40ImmCfaXXowxV2Gjna/06Am9om0JRYcTzDwPkTaLCN87Hi/bdzLgW7SfW/GlwL8I+ZTLjFIuMU5D8bQrPvGACUc+KK3U20LFkT/qEsP6433QiiG3zBw9lIKyIjxsjkqPtlWFz9ZdUFTN2GArL52/aN/Kl97EwWAfBwR+badq/HYLbUiasOAkWM7Zlph/wFqUuKa/xrEBYFxtxk1ws2XhaQw4LWAbZNJhcGM84zfYaOkpmZPZPgsmvJzxtkdkXwrYgI/bMHpEKnLG4xcWXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=d7qeefdm4mfbGL4zGRTFQn1Uv2lxfwkULz7SByDqpErLDtpzVzvtctvoLQkb8f8T5+QfqrX2V/i5F3DQ5v1DnDQIbkuMkFo1Q1lNFjhA1WgKqo85dUdW+MyNlk1RhW1u3AGdOHpb04O9BG+5hi+R7tNRj6CbeYCKTWfr4WwjjUk= Received: from CH0PR03CA0344.namprd03.prod.outlook.com (2603:10b6:610:11a::35) by SN7PR10MB6384.namprd10.prod.outlook.com (2603:10b6:806:26c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Fri, 18 Sep 2026 10:23:25 +0000 Received: from BL6PEPF0002256F.namprd02.prod.outlook.com (2603:10b6:610:11a:cafe::37) by CH0PR03CA0344.outlook.office365.com (2603:10b6:610:11a::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF0002256F.mail.protection.outlook.com (10.167.249.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:24 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:22:58 -0500 Received: from DLEE211.ent.ti.com (157.170.170.113) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:22:58 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:22:58 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IAMvwS599960; Fri, 18 Sep 2026 05:22:57 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Mert Seftali , Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , kernel test robot , "Dan Carpenter" , , Subject: [PATCH v5 01/15] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() Date: Fri, 18 Sep 2026 15:52:31 +0530 Message-ID: <20260918102245.2784000-2-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256F:EE_|SN7PR10MB6384:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e310508-99a7-4ad6-c471-08df156edf7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|36860700016|1800799024|82310400026|56012099006|10067099003|22082099003|18002099003|13003099007; X-Microsoft-Antispam-Message-Info: Q0Wr9a8i3/n+5Z6CVweO/riDEl5pGglvfX0tChUxk71536g05bl9UtG6/evsGCTqktIkV5R+4xVvRWWBIBi4ZajhE56kY60UfIYCIVxXjJ4Y22wRgvug5zr/+YSu23+KtDvH8K5BVMBccLPWt0v8f3aHLmM/BT6kvi/SB1QrCKY9VFYTur8r5Hz2uzD7KPSbpQG1WSWoN7myuTh5N/W8PnBgmM91PMSFjlEUybYQZ6PGyZrysvnQ4cDxTreBKk6eyCxB85ttDfYQxhJtKkqIKjIVqJB71NSbUJAxenXVMPZ3VJzclXt7Jm/Nj4akKMVAg9ng+CaEBbZSKoaAUAiCWIgCF3Xasu5u46PD81WfZyjyKMxHadRK5gexnz+NXJzLvK0SL3+QhBQHm7TMD914WQtP74UrE88ajuT2YshDlA4OolC6E9oGIXtVyWnkhrguSoATgn7tdURkhv6pl6SCu89BqwRCsd3eZbv0f08Xz22vc4EBl2AwsaJYQRUrjAXTuQ+hb2cDHwjbGdcg5vdG7B1OeAXKQquxfOG8KnDrfWrxwD8WrdLfMaI9tbebVCqQqGHzWbl16vOS6twZ6tr6uIvbRzDFqgIrYRRD8IGchJitwayFV8KqmxNl0y+tcIsV1GMgpZBhzYWxRJaGeChKAw== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(36860700016)(1800799024)(82310400026)(56012099006)(10067099003)(22082099003)(18002099003)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4BV3Xzm8jMN/xANUJaRbnI0l1e+P5lAkS/HvjxqmvHN4pWeYDGbn3pbc0BSmz2rQxOvMMdRqWNw5DgzTynzHTJuF4vGapbKLxbaNNfkmhVFlg8xr+2BuWIVSNFaGZyiBeO2JZLehOTFi07SqDQedLtFcl/G4XCmM8ChpPFfcMpoYJodSWL+Ugswfv0ZtRpPZTmMtFW+hZU4HOezBvrCFLmz0g/VZOjaVkVaZrWDxZNc/DHgCHX++9Uekg1r5ueKIyZMDLCTpgj7zLXutPqw7nLpz7zYdxNAN6CBo7BAd6hQj9NGP50Ufn5d3LFiAnIkA82Dj9Du6FbPA0v0U1iXF5YSzGRhf/wRe0epuy0mL/KkYulFg9R1f7REpR3aiPcD5XdA+ClsGUVUKBUoFzJuqs1wOe55tDrt0hlnFPtBp7+dc7ehdNW4SzZmo/6LFEMek X-Exchange-RoutingPolicyChecked: NNM/7ltLbC78eoocEEgrTi+hp0N5AqiapWOWvcQ0qfBVzdr2dJ36glahVvVCGxP6IvYYDi941Uw5bPYEDKZ/048gj/1eqx7eyDo2R0qyRYwRmrhqrIcl7trHRZbZkI3VZa8KT7AdMY2EhxFvx65YJJp5QEDK6wc3dfW7V5A7jCJk8AjRvfub2rodVYdOiHAjT8b2I1Sqp+ArYNESuUY3gEH+DP/ntB4F+27G7RxQc/mVNlhyZDf/1xUJ4QPJN2VotzfhzsOVlY3aBigpRFRj3Efu4VinoCkUBKGz+jvln66WlV7TTsOHCa4qejJXnvynzar3ksEwXFB4BLSqRvh9JA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:24.8968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e310508-99a7-4ad6-c471-08df156edf7f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6384 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX0VY2B3AXu1Sb zazRWAd9NLKV7uLFU2HkKqcUNDG5iHRf0c4QjJJsKWZmxWkvq9u5xH4Bh3OcEMvXnlrY4zomQyV jgqsjpenJ2Zy7BOfaCKUcbcKTofuNsfRhmuZ6ecNY3DmcSMEQzNiMSoc1+F/EMKHloN+6sXJDeH ZTC3zQprvJUqObH+s0PNl3Ivg23ROsW52NP1+nE4cBEyLYeysA2a5V0tUNgLSjdGekMhOIRYScp t4a4rNoLzEZ7oaTtkOZrGl+1UwmHJwCRNWFzoGh+1m4kYMpSoowKGJSoGk21LfUPby3nyjWc/5G jWNg+5BKsMl2qgW7TmCPFwuWdTKXhh2COUWORh/nzIg1P7KuonSJoDB/RCWQCwzcKeL5SqGW0+E yUzOforj5idzUMW00p7rL5vwRperRek7M4IvW/FU7+S2Td9i3heUlWEWGTvyIlGEJ+nUIDuyUDK eF159GQy1Z5a0RpxDnA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX8FPxPOLUKdT0 jQoBp/3QaabZjAzwIJJpGeX7K0X4MsolMLAEs6mhBcvGrHkfeAwUxPh/DjFoJj4cb94lz/hbOEN VgTPhfX+HDz8llEY96m7XefQmjNMvKE= X-Proofpoint-ORIG-GUID: xahzK6128Xu_4qgBvIVGZhiiGXWsGzpq X-Proofpoint-GUID: xahzK6128Xu_4qgBvIVGZhiiGXWsGzpq X-Authority-Analysis: v=2.4 cv=adH0Dhot c=1 sm=1 tr=0 ts=6aad1121 cx=c_pps a=mU7wo4rWgHT00F++7wGdfA==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=sozttTNsAAAA:8 a=HYHyqeARaHjSmq2Pe6sA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" From: Mert Seftali dthe_get_dev() fetches a device from the global device list with list_first_entry() and then checks the result for NULL. However, list_first_entry() never returns NULL: on an empty list it returns a bogus pointer computed from the list head. The NULL check is therefore dead code, and an empty list would be treated as a valid entry and moved around as if it were a real device. Use list_first_entry_or_null() so the existing NULL check works as intended and an empty list is handled gracefully. [pratham:] Add null checks on dev_data in callers of dthe_get_dev(). Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/ Signed-off-by: Mert Seftali Co-developed-by: T Pratham Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 12 ++++++++++-- drivers/crypto/ti/dthev2-common.c | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index eb5cd902dfb59..4fdd24ee91637 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -112,6 +112,9 @@ static int dthe_cipher_init_tfm(struct crypto_skcipher = *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -124,6 +127,9 @@ static int dthe_cipher_init_tfm_fallback(struct crypto_= skcipher *tfm) struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -571,10 +577,12 @@ static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); + const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - ctx->dev_data =3D dev_data; + if (!dev_data) + return -ENODEV; =20 - const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); + ctx->dev_data =3D dev_data; =20 ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index a2ad79bec105a..cc02449382673 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -40,7 +40,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) return ctx->dev_data; =20 spin_lock_bh(&dthe_dev_list.lock); - dev_data =3D list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, = list); + dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); spin_unlock_bh(&dthe_dev_list.lock); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6C5E4E0B8F; Fri, 18 Sep 2026 10:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727007; cv=fail; b=sWVOiW9RqT2uAxkGA9HtGD8Ti1Naob7O9OleKT2uYiQGAzfsleCCm6FT9ZjCBtsmkIcGXl5nSgTC7uU+cpy7trAF/F9NCRFfiEabhpkyqV42DHiZkTbdJKJQ6+bTW9xinYg/LR6dKR3W09flmwxIiJ+VK7i0UYDAoN95Oo/SU/U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727007; c=relaxed/simple; bh=jK1YlxGMKiGHZzHUizrPnjxGoWi3TQx+yaKmQrQGcxQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TR/OTdMufYswkulAeLr6gwSontAfrpJl009Gd4GUCFAjJR+KQl0qPiqliHs4djgCEAd9g7ZbZaqjah7UyiHUYNUoktVLTbHOUPMTrViogdADKEFA0Zpn1Qa7fvfA2/s2Sevj5VLB9wipYWtdLM7d8WBtvleDwaTT1fnV2QwkoXE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=jq7NlA83; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=WVKyiXRN; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="jq7NlA83"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WVKyiXRN" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9eGv93768282; Fri, 18 Sep 2026 05:23:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=aQh92ADWyfMZtk0V8bD8JKalILCu/np0gxL+lUgXL Aw=; b=jq7NlA83Ggp7JNwO99P5dVzpkV/WeZmsq5Sk+QhIhwEyQjCa2Zv/eVTCW fY8JjQ/2KnLk+ThPYUm+O8d7do/CTA5LcnuJhYgdFSCsV0yqsGRRoVWtlrHQ8fWk XWRhB5FYqROv9lpGByOL423pSXM7BxD4fsnEGfcxV1tMQsTH4EmLe+qdLMFNukDW 9OG/dynsQbpDr9GV4mWzNPX3oB2y3avnX51+PvOHvHeZsOUR7O0Ol8+EDOfYvOto gfYZ3tx1I5nPSiJuFqQVP2fyy/gI3OWTjONVCHjhJyYOUadpgv6UPX2ss4mk5hcz MEv/QWT81dwHPp4dKtGCNa+IUnEUw== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013038.outbound.protection.outlook.com [40.93.196.38]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs16cgsjr-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:21 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fNPV3zbhFLrFKneIAfihI6C2UrqbEtCAHiA07MCqtlr41MKQ0YGbqTF2sD4Q6T/Bm9SmjZr8eQm4YRQ7JgeDFIp3m5IqiUubyAIsgTIBfHcW/66S+DWW0nmbSZZwUDpa7OP1vZ2aekt9kurd8gWCqnAj00JEyrkZcBbrB2JqpX48iGGHBl9c1T4DBjyJwOyu5vKOa85JIl/O8CZsLtsiX+B7YdtrB3Qq2OyNfwRVKLcj1MoY4aTkXtN61WMR7S1w1Qx52YYsrXQxSQNGWpk90VxQxt5/TnIJ9E8SDu9clIXQqFR936SMtHcy6xWRPr/yUnfyzWC5N2DU7w8sG4mo0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQh92ADWyfMZtk0V8bD8JKalILCu/np0gxL+lUgXLAw=; b=MGfL9guXf0MmKpWbVu/FzE9QiqBYqx3O71GhOB4xdYghoVojVjgJUCMOb3Fiik4dWR0E8uEG3RMDZ8LBYQzTYmbGk2rzR23heiD25DvgoclEHCFg0w0g6GdpfaBecrWjC7oUFiU2f8yqOGgMAr4vYGqG6X7jk99ERSdb967GD33q1L1XqivhCGuN5QwluhavazGK9JZ7uTd+hSbkYDoIHbCpJvoSkBQYzHErYbAYWxTGRKnnYmxU72cIQBAUup7tZ/CP+GbKDD+aSl5TEAhI9pb04moKGg5JmeJ2mUJYrQiFxgDg70Jod31HVN1csmMQgPF0wMDPi1ZYRfojpVUhgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQh92ADWyfMZtk0V8bD8JKalILCu/np0gxL+lUgXLAw=; b=WVKyiXRN4vH4fP5EeD013W1gJ23/qLDmI/tikdcdX9oueuVfwmzVo+rJp8kSti3oEPF68K0uOz3Sx5eDPsnXQGFX9ucK79kxjj4jiUx09JQq1QhyibmPIe+gEahCetZcUK25ORlxIXdScCB270oXzCqQdVgrle4sPh6gGixZBz0= Received: from CH3P221CA0001.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1e7::11) by SA6PR10MB8111.namprd10.prod.outlook.com (2603:10b6:806:446::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.13; Fri, 18 Sep 2026 10:23:18 +0000 Received: from LV8PEPF00000060.namprd02.prod.outlook.com (2603:10b6:610:1e7:cafe::6d) by CH3P221CA0001.outlook.office365.com (2603:10b6:610:1e7::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.12 via Frontend Transport; Fri, 18 Sep 2026 10:23:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000060.mail.protection.outlook.com (10.167.245.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:17 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:01 -0500 Received: from DLEE204.ent.ti.com (157.170.170.84) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:00 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:00 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IAMxoW1534085; Fri, 18 Sep 2026 05:23:00 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 02/15] crypto: ti - Fix spinlock inconsistency in DTHEv2 Date: Fri, 18 Sep 2026 15:52:32 +0530 Message-ID: <20260918102245.2784000-3-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000060:EE_|SA6PR10MB8111:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ad6956f-532a-444e-ac00-08df156edb1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|36860700016|376014|1800799024|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: qQOMr4EZtxFZGt2UXIfWI12vG0JLnEOCvyKA2SqSp1XU1R6MluNKJnbV+Rgyqs+p+H482vQQwmMs48UO7OVfp6ypDonUeJ+Zakt+D6UyaVMHtOplIAWSQt0abKu2M5wXJtPSzaFUu1oGhxv6bhFOXes9EVRmRuJ5QpCqJ+uegO0r4MvATKJHwWpp4g3R35FnDvioPrgGlBLw2a2CbYizaw02fOAM/MBTD/QcfS0c04shJlLJOuWRiMmPPuQJVTF88cTKnuQ+z65uA2Uqyr4pcPN8W1/P44Ncx9nz97lmcbHG7W0aBpR8nu42GBfFtId9XsYbwqUtSoBGJq5Z2erZSPnVIsfSg6+EYygbyfBA38AifMKkhGk/YyqY0lbHCfrn+pHuZrmeNWIoxdKlmDiihsv0+Gb773EV2oWtLfz7W3mJ5RXSBodryAzhjZJilEA1vTiwCL4U2U0dG47CK7mZSYtV+hp0cMthiceTJH95Mrpy5AEF4mDIvSmGpXGAqcw3GpthZzNWGZisUmLWTtHB6r++mde/g1Ysj2r1eSaIEg7LxhU5bLU//G1GNH4r6cf50S//3FfV5jWnEyy3xPCuS9r9E1Xuv9asCxDo6FAL6oIjH/gI0/aBArRPKXTFsNjiZ4fdjcHqg4svgtTrX7Zu4l4eBMpq8/6fErna6kEYC93ZBT3fA/lNda2dY6ITz3rBRMW6GVnY7OwesCOkUmmcew== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(36860700016)(376014)(1800799024)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PvfmpBR2fGx3AwmN7xcC42JViLSYDWm2OP7eWSNu+fxlKaK7BUsFGFPvAJvCAZc6XHQtxtYVfL3X5PYwO6JaniXyQt823Gh3nUY97KPIm2x5/meV9JhNbhvDngxs8Qe1az1rdauWnS55K51yoiHsOI6K5ThgaCREJUBH45Ha9MrpFnGbowJV8Mdi7ux+cpxiPDwLnsH3kMlJ+W25OxAyiu2u/1fj8zXvYs9t8HN+rzzZ5DT8KE/jDdE1opaKFBLntt2LCQ8C1t7dwq484EgqbFLL1x1CHhG1ijmM7Fat2hyXsbMZ3R27EaC6WXEbo9NQfBYrmEEl90PKDyaP77Zc0SCG2Xf4ZdrchOs2mqZZHBUL11DOMrmS/FGaBIY0CdU0uraZWu8xg38ne0SXV0zW3aV+9VwXCddRtFQve36dRGXW/7zy8ZieBQdyJSaINK7D X-Exchange-RoutingPolicyChecked: VVDvKxI/QRtZgdBd4DNetwPeXoSt8URr58JUV+qyhwlZIpvQ57F0q2dVsvhJKXOYtqUttAKcsxPgS0aI9rs+g37EkWdvis8xpExDtPHtpFEjE89q8AOqVuwTrhsXwIqBwj7Kywh5XXPZARGU9f/4Yvga+pcxT5ldlc/coC+3gumfdkTahpxJhIEwu27GoEmb9Et0Bj+bh2v4jKtXJq2UWzjHo0fcjdspVXnFVCXKkL5+Bx0K8UTrZ1Dgef+aDsMb16yLsvhXugMons952QMPrDdWctYq382+1V7sZeO+pXNwae2l2UhD0BaZRw70VmJ2A1IOl391dnYAje21VCrlUA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:17.5436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad6956f-532a-444e-ac00-08df156edb1e X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000060.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR10MB8111 X-Proofpoint-GUID: _SSGtMsrqGuVJ-vLkJaO0LyKn2qxUW0_ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX3xizdHHGagq0 LexnSDZW35lVorVcoFsedqb5rGA9ij3XUOIw24hk0gv/M44LrN4xOoax+34CgaJc2FcYB6H9i+S Sp8EQXyAHHVkDnqCZ1KauYkpEt8999s= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX9mjUrDXoep8O 6GQmzt91Ozl6PFVopap0BAp5Rdbhv56clxC+oKdAtc3XKUtxAHF5lCsZVbi6Dy0rwV/oaWxxCVG S9XGDK2RAiuRHVULSVWrsPxABzsPqYgN318H/00jrQQGU8WSleur+SQ9IwgDiurrc4/B+wToLqT PsS2IKVMMuVnJSo6epDlMOpEcBsGMUQkwNEg5vn6KWkw+caZija6jT89hhJl0FmUID0Me/78M15 JlWLNwrHXpUIqpZO7MdsNZHsCwJ06DMRi31P+5dnwe6X92FV80XnbjEFKJVvlsQi+GUkO/Q8iin 0lc5oUuqmYLW4GI6/UJhMPUL6DtG4ArmHEmCESj7VnpL8WVBRa7rfIBQnmXqpkrr/vlrt50HuUS AZueP5N0OiOD3ZeEDhWnyzdNA4egZnCFLFGJyufNJ7S/u1D1DarO6a67tVh0uAgi9QSR007o6fa 3i5ZIKsfXdnzoAPFFUg== X-Authority-Analysis: v=2.4 cv=cKh1IVeN c=1 sm=1 tr=0 ts=6aad1119 cx=c_pps a=iBoLJ+TzW6OYwHE2Vh/RVw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=HiAi_RwYt-Wiez6k4EgA:9 X-Proofpoint-ORIG-GUID: _SSGtMsrqGuVJ-vLkJaO0LyKn2qxUW0_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Probe and remove functions use spin_(un)lock for acquiring the dthe_dev_list.lock. But dthe_get_dev uses the bh variant. Change spin_(un)lock to spin_(un)lock_bh to avoid potential deadlock when a softIRQ process tries to acquire the already held lock. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index cc02449382673..f760d0b256728 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -155,9 +155,9 @@ static int dthe_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, dev_data); =20 - spin_lock(&dthe_dev_list.lock); + spin_lock_bh(&dthe_dev_list.lock); list_add(&dev_data->list, &dthe_dev_list.dev_list); - spin_unlock(&dthe_dev_list.lock); + spin_unlock_bh(&dthe_dev_list.lock); =20 ret =3D dthe_dma_init(dev_data); if (ret) @@ -201,9 +201,9 @@ static void dthe_remove(struct platform_device *pdev) { struct dthe_data *dev_data =3D platform_get_drvdata(pdev); =20 - spin_lock(&dthe_dev_list.lock); + spin_lock_bh(&dthe_dev_list.lock); list_del(&dev_data->list); - spin_unlock(&dthe_dev_list.lock); + spin_unlock_bh(&dthe_dev_list.lock); =20 dthe_unregister_algs(); =20 --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D8B4BD34D; Fri, 18 Sep 2026 10:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727017; cv=fail; b=QfjYtCIkfj0jEML23kpX4o9w6GsiMhQ79i1aCx+/1VCYoLvr18z3LCvDWY42mEmoPpOxLkBlI6e/lm3CShdYiZCGx5lJ3iohxIctpTWSqtAm2erfsUyANXq6/dyhsJPkNMPsElWAkhPRkITKcqxQUGEnOLpbnTcr/0eCTTZGdCs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727017; c=relaxed/simple; bh=Z5dcs6emr229Sxd8UusQQWOmWWwMpTcSb1LfuYj4LZA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rSfRiEXi09z7/D6d6+R1qB5dSblDVkG/v7P7cgeGE0LKsyuwN6I5Va9kecRLyLAxpr/cx8K83q2j6LezMmsT/3Yv0DAxvKfzp4PqPUXZqJchfFMXXl1X15kcLOt58bDeYIS9bLntrYEhJEvmK0qCCy8IwgsKTwQ8UlsJ/f26KWg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=oG7NCFGL; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=biuYkYVc; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="oG7NCFGL"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="biuYkYVc" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9dNxR033438; Fri, 18 Sep 2026 05:23:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=v/jYL1X03j4q/EZ4dbza9jpmZgK9IlPnHEXGyjoUK ww=; b=oG7NCFGLfFaKejNwa3rVPyKlguLOdOD9sNTqNLnvahErMZdrG81rEgWBW SDoSGXXJsFkL8+oCzNH5VeVocJ7f9wHJ9srfoPjrsBvgS9RbPkA/axhg4gUejzrp NMrHtKoElOCeOy4GolISZEtpz+3c/oTcjNzr6/cAVZPKYAJe7py+2X+hgHngWKe4 GlETF7Aopz99NvXgqPeGgEanvKOFFRFVh/VXF1gkawXEpvtwYFs3FpdhW3XGFuhq mp7FBOcCGPKCJ/8cl2LR4yW+w1bEesPyEwms7IFuhU15AIs84oggCNsA3lIRy2wV EQIkKyAscM1Rv2igZKxicmsJOPwPA== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11010025.outbound.protection.outlook.com [52.101.56.25]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs0k39121-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:31 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kae8+I6FD+ZKXIiUpLMSgqYGVt/S9dregBtH6ToUocVCFQMj+2oNA+P231az2klBd8lJeTLEGHP8yWBXIAMV/TqRZwmaRVFeYzNEr1J68zQnEuYMW6UqvBRnHE14FNhMpBaiJTO6VSBW3MfV+M3aXtIlfdGBmNS22Ldugt2N0mSVXS2iT4iGDayZqng0w5bXIS2nDGar+LNu/6kd+KOV4zBC6nGPP4vv2/m1zl8OHD/hHNa3yMdlNh7l64LBjE+mjV6MpJ3NGEsTLc9zNlqdSvUcHkubiogIrMQ9gDTcnmPq5MCL3uDEqJWVBTd4nGqNt6oBT9F2dzruYu3kpi3lZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v/jYL1X03j4q/EZ4dbza9jpmZgK9IlPnHEXGyjoUKww=; b=FAn+NjkPpLxnVeShtroP/vFcgRAC+HBzoZqIi7l0n2qyL6k3tZts6b/pOW7BIxT1bdeuSTc+vY80B0CbPcuic7bmYb8WqcYIeFSZhY0p+ARHU5I9+8j6wnS0w3rHxdpCM34zwJSGcJQ0Vs29m97S+OjVPuZNZSByiWgQRhkcShpPO+Okj8N3BUoGliiW+XT+zCoUuW36nrqOR7dQAcQidqYVwUBgvK6urHI1BbxvSd40od5wzGvlovokN2CPynOf8wBUz3bWRg34ztufz0j09xZBGeEo866ys8GTWuJY4sxZmbGBaog3vkNrQc0mxXajhXMgS02stuBsmE8ejzCfSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v/jYL1X03j4q/EZ4dbza9jpmZgK9IlPnHEXGyjoUKww=; b=biuYkYVcU4tAogJuXdQsI86IVqzHvHT1S24naOgPIWyaHgbew8HfOxuM8zbbCf743Y/KXB+ljxFbb6xmifABRs5hqGkXlz+uedJqmd+vsmCB1XHH8Z07drJ1zLioDwL4JOGJrjnl8v+Mdrrxe32vuFPQIZki4aCkwJpzu8Nzf4c= Received: from CH0PR03CA0338.namprd03.prod.outlook.com (2603:10b6:610:11a::10) by CHAPR10MB997698.namprd10.prod.outlook.com (2603:10b6:610:2f7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:23:27 +0000 Received: from BL6PEPF0002256F.namprd02.prod.outlook.com (2603:10b6:610:11a:cafe::1e) by CH0PR03CA0338.outlook.office365.com (2603:10b6:610:11a::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF0002256F.mail.protection.outlook.com (10.167.249.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:27 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:03 -0500 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:03 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:03 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IAN2aJ600132; Fri, 18 Sep 2026 05:23:02 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 03/15] crypto: ti - Fix potential memory corruption on highmem pages Date: Fri, 18 Sep 2026 15:52:33 +0530 Message-ID: <20260918102245.2784000-4-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256F:EE_|CHAPR10MB997698:EE_ X-MS-Office365-Filtering-Correlation-Id: a2874b46-edbf-490b-0f9c-08df156ee103 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|23010399003|36860700016|1800799024|6133799003|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: JasIJumbZD4mkBWMhzd85GOXUV+3lB6L2SHt66UnKKlolc5TxrMk0k3BkeQFfNcPgrxHmNzClE1QZ82tRKul/x47k/oxhAs/x4zFqeKJvMNQrp1lCKTUbZpzhMs2iKmX9LYXQuMPw1o+BVQo+3VZ754yfVfgBiBJ/D5CiIH+TW8Sk3RnFoH208xi9rFeuhB+uUuPPOllpQ+eV5+PCSjuntrFYIjvsT+euvjlruNpZPPiPmWnKXBsi3jcjWbCYIPc4QNTVjFWOP4YwAjuha0dxNovZENMzrY5p44ofPd4xrxIvRk+RyIPGogr8ZGAxAtBlOYD8GFRSuPtrui/9KOBF6P39ZFerEM/KtEXmB05YH5JxDT0knbSZU+Fo7/34rU8VDq93Xd3JIHk9KKSRqOs+DH3tm7WIZz5Da5qDc6omNqJeecmjpnm/H6xWWL5V8xk9cpgVGcRJHJ5Bs7RqyUudeMzz62Dzr55i4b5ULgdQyzwhcIK4pLcnOKZgw2ADtnaaNo9D3b50YIjk3zmHN0fin6wPDXfzFU9oXUxJsFTk6sXNzcUcNJL7eT8ArpQaam4ck1jvR4zp59gGRjUjOFmVQiSBTJnsIfIsChbZFPtMz5+UyJETFBurktbXVcVyOrUNBGVrtZk2fEEIjrkHIH5mb2nLyu6dLaUXnzrYKFjH39Ya1VmFukxUYmvg0cK37LXEZPLym83UgNUasZ9yzdkEQ== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(23010399003)(36860700016)(1800799024)(6133799003)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DW2zYWfWEVGFNHd57g+oycAsAHbl95aj2Z2wKdmPR9k5j2oQpu0reWZi6Dgtul0u+mYB94q0fLLPpA6JOzjMOFU2VMBMzirL9cWuNrXgMc6uauz/lejbQS+Q2DWhoypE6fmhjEByoJ8eIDD7muxASrjZ9eZr4jCB4fqdpsH2C/61mklJok9qaa6SKoWsmTi4+m911xQlRJftlpF+lE0MhAc9Y/ujqz4aO/svtpYe0npfNmJtTDVbCUll7t48c/qHiy4bmM3qbhN7dS4YSfhNjEk2iV2QWKjULtfdLlCbNHaqg1Y2j0S5IIxzkfkzAZK+k8uH3l883Q1P6V9Vj4qH+mfkD6NuUxoLIjy5Gu6HJYn17fN0XO/IEhrJh+LXCgAfeWXxQ2Ro4z3FQj0e0pDyb00htVHT2AH3TQCm/3z9lBCLyHquxOjlw00vQxMr+bfv X-Exchange-RoutingPolicyChecked: NWDIfoZF3+oyZ3AZwUiCjBMKGjg9osCSyrJLDv2t8PxFJ6+w6SiPJaw/5x8GceRThPWPwvZ0YMMiGBueSTkKxieIbGZxwVZy/1YDAV/nDaLnPYjyxjkLUGuXkiOkkjWeOnqFZHRwLX8i0ayAgRj3tv8xQ4iVQKHR0k823NsP+V6YgNEObQf6R2PrjGI1cMbVKhdPCVpzVEbuhOQ2oIA0EfJrA8ATfK5FgUmQ2i0El2Y6c2NLXJftzoVvCbCS8RJleg6Y2I3u42jvxsxqy9vhVKZnBNPipF4o6hQeJaczLCVTfjOXK8WxAANiKgmtaX2veUgg2fRLJSV/mGtkDy0pKw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:27.4328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2874b46-edbf-490b-0f9c-08df156ee103 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CHAPR10MB997698 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX/qgD3JNUiElm iXgmSGL/9Tf+FHc7TR7ARIw9MGOEKJY1j61U62uQsv3B9cpg6OzjnZkNeRxxsxSvic6tQPHVmhA lNRXifkFbbytF2eVKsHkxJSRk6Wa0aw= X-Authority-Analysis: v=2.4 cv=K6S3jCWI c=1 sm=1 tr=0 ts=6aad1123 cx=c_pps a=I+0PaAUBL5uRonxG4DgGUw==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=IXP722aH8NCvtdUuCEcA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX3bKoeCkWXR3h ZlEEYIpQjZXS2YiMnUqA+NPB6Zix2F2E2/YoI8zL6NRGvHAdTjr3B5tAHA9FBCXa6b0qmUBjcBM 6pWE/WIYZ1uOCj2wCBYY5zeq4cOrPO8tUl+WVYXB4kbR95ZjYLdjlPF5iazcvhTsuui6hVr+WL+ 0D6nY30ts6DYuTnAve0/CF0s1CilNVNZ0Mm8r0lGG3MmDXQg9LM4nhnD7pYn2yJG3d3JL/YB6eE 8qPMNRdp1Kp+0DLDe1oZVn+nCOGDBsY7bL3m1/Cfq3wvpcjvQfM2RCeOL9bz0fhNB34Ala02uCy VFDQIIdfh6KSGRlj4vOtJu7a66GeFy8Nr3Q0IG5Tr1230ZA8QwHiTcbbn4M3xrGL6T0ZbKepPB0 ysI2Q5EH1rfOdEBz58qLmEy4iMeTSGmZa4xsMFlSiKOoDEFfR0cReWzRO3zPigvKQyTUM56qtkL lZXdAIZAq+jKlZHgKXw== X-Proofpoint-GUID: KYlBBiiBQ8QPK31lWSx5mNYhm9Uxunr4 X-Proofpoint-ORIG-GUID: KYlBBiiBQ8QPK31lWSx5mNYhm9Uxunr4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Change sg_set_buf to sg_set_page in DTHEv2 dthe_copy_sg function to avoid using sg_virt() on scatterlists. For scatterlists containing a highmem page, sg_virt() yields invalid or null adrdess, causing potential memory corruption. While we are here, also change function signature to change buflen from int to unsigned int. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index f760d0b256728..2a3f5880cebd3 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -50,7 +50,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) =20 struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen) + unsigned int buflen) { struct scatterlist *from_sg, *to_sg; int sglen; @@ -59,7 +59,7 @@ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, sglen =3D from_sg->length; if (sglen > buflen) sglen =3D buflen; - sg_set_buf(to_sg, sg_virt(from_sg), sglen); + sg_set_page(to_sg, sg_page(from_sg), sglen, from_sg->offset); from_sg =3D sg_next(from_sg); to_sg =3D sg_next(to_sg); } diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index d4a3b9c18bbc1..75d9a097650da 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -126,7 +126,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx= ); **/ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen); + unsigned int buflen); =20 int dthe_register_aes_algs(void); void dthe_unregister_aes_algs(void); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8BE3448BB5; Fri, 18 Sep 2026 10:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727041; cv=fail; b=K9kykPWKuc3/Pi7p3HOs1u6DoeG5WCpTAThP4bIQp9yKxlKVlegwBjvAr5w8eLiVh83jHMylsebT08qYJQ+UOS/fNTg59a54eLbSfqI+yAx3adwEukg4DZGm6YcK6ujHS/11XdZanM99Gj7azyCgwSGBafHKLfMdqLQpf5PypEw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727041; c=relaxed/simple; bh=S2P9kJ+e8z+mwpn+sIDz8GJO5D3GScPLrFqSFokuaSE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lb6q7MvjGYGwQCLsVc65/xw38Mgp7sfyi0jt5OGopCRgsg0BCRXLktbWCNih/Qvpz+oZ/xS7yCM3KdLfVfzIDp9gD14Dz2nwJUz3IAXu4szYRD6at6GIblGPo0RYnXFNMInO7fpWwT5BqlbzhRpRQp0DHuZ1SCmYoFVJ2PMMMMA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=PERkrlLe; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=SWcce8CG; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="PERkrlLe"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SWcce8CG" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9dBpu1233793; Fri, 18 Sep 2026 05:23:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=SA3piW2BGL/3tUuLE/A1ctAfNK9HBAJ88/AUdiIWB ic=; b=PERkrlLedBC7ZWc+lHLIHHJGa/XjdwOlyec874VoyKn3WGGa1RYRG+/Yw VTONPLVM8RrhDm/2Y82mcAMz8zU/Ww2iKqispKQBo3tVlfpfpUgfac9033BvkvkE kETgpUNykDLrb71Kc4FERvnOLPJ/7EOfM4uObFs6mzhWhktQ0KZal/IV64/yHs20 vDOF7kICiphqenb7oeHsoBrBH/Up0acxraEHBLOWGN0PtE28XmzsYWTPLV6VCo4K nZlMxPZ5dZiZNO9hPH6s5i8XUM86DNAIB36sc2va01JzgVUHxHHyVUwxawnFiqr9 Y++uXzWMfCEND9yjayKigOrcNraJA== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012008.outbound.protection.outlook.com [52.101.43.8]) by m0384305.ppops.net (PPS) with ESMTPS id 4gs2ux07d6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:56 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XL1wzgfVTB7QA5Zwt7F7OPZ0I7SHKZaqkiWrC6N5lzzBm7KV9T0YeaU2upEoDMaYBgsFL2qYGV5LM7Ct8/PF89wHYpD1qX5SKdHRCLTj868e+3i0K39eF3sCdXY/f219X0M/ZucTm1ZS0wJFVI71/Y7higit+guXTZNPrbwJHnTrYUYajpN+9Kq/OYUYbWANe0w75pIftzhBXPmYUYwIGaOfQz5t3NH98DuBJVUBoP1VYhAoGMMSjBFfkRcTho+ZBOt+r7FqIUnXx3k03Yx8Rf8gN9YL1JURcj+DvhJ4IXNxRYhdE7oB6lYUct8MgwepusE4/8FjAjhqsfH9x75J6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SA3piW2BGL/3tUuLE/A1ctAfNK9HBAJ88/AUdiIWBic=; b=PdR4ONTwsG0ijkPiT+0ESs11JfGOXggG7Lf2W+NEWm9NhV4miAm+uHiPQjZnlJN4v9a2yWTdqnU6HquCiyUSHLZc+sFF4iRJsnCskBuriXApsvT1TvJFmUhMNJFcPMeMnfrMVbKTjEwsx7I4zha3QMcrVd5VNLh4RLJWeO1Yx5g/etSzBOywF98SUyYVoeUiPe8BskyNFtwaYRkqdghJpsRgU36sAsuKxwAyvzWM6Ba33q6g5GxmYCWVpYWVj81LxEjtkxpYK0jb7sQPMVsaDJBBHaByrM04WRjkmWYPP+6e8nfwUpputhSXbhIC0bhvnikPJs+xbGLU9OsDgeD0Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SA3piW2BGL/3tUuLE/A1ctAfNK9HBAJ88/AUdiIWBic=; b=SWcce8CGzxxgJcey5QK8elHoN8YHAilU8YcrYeHt8m0N7pP6SoEBq5UlnNE1b8lo9xcR2L/fCjLU9jmozOcI6xO7TeY+9PpWGXDaC3sOPxuGD+2y3Rq9ZI96+Wl8mkLXPAvo7u+obzOSrcnICQdHSB8Nb6B0F1xysJZcbgSE7Xc= Received: from SA0PR11CA0014.namprd11.prod.outlook.com (2603:10b6:806:d3::19) by IA1PR10MB5923.namprd10.prod.outlook.com (2603:10b6:208:3d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Fri, 18 Sep 2026 10:23:50 +0000 Received: from SA2PEPF00003F67.namprd04.prod.outlook.com (2603:10b6:806:d3:cafe::17) by SA0PR11CA0014.outlook.office365.com (2603:10b6:806:d3::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by SA2PEPF00003F67.mail.protection.outlook.com (10.167.248.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:48 +0000 Received: from DFLE213.ent.ti.com (10.64.6.71) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:07 -0500 Received: from DFLE204.ent.ti.com (10.64.6.62) by DFLE213.ent.ti.com (10.64.6.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:06 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:06 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IAN55O600253; Fri, 18 Sep 2026 05:23:05 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 04/15] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal Date: Fri, 18 Sep 2026 15:52:34 +0530 Message-ID: <20260918102245.2784000-5-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F67:EE_|IA1PR10MB5923:EE_ X-MS-Office365-Filtering-Correlation-Id: a9bc46c6-746e-42cb-2589-08df156eed9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|36860700016|82310400026|1800799024|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: RqG1pkn/rjiFFuQBIxqDqTK7uK+cF+VpsL6ctxjshw3jzsubY354lYDQQcN7hEZC0Pfqo+eV67hSdq3bvxFdhjWY25aDKoeztdz0NkXTDokm2rhA635BKI2A0u1T7IGfMTzIa+HUWrdao3aYQvvyswR6M4ZlRB0AHT71HLvYgBt2/gy4iplc2UGEPYUY9XbIBr/XfIWFFHCw1V2n3tuP9WJEkk2wbRpRehGPZosvlXY2FYGAiWEl65VjWS3UZoajhdwGUvWiueQUdIf1A2v+lk9t1YM0o3rNue4Ce4msVix/HsxtHi6gU36/Hw1LIUtomseuomwVJVKx+OtVZhVNex6n7/FFEtCadkDnfirdVx1zYjaXR1sGsMLe6/DygmayCQKHSGCO7pI29ObDoA8ftmvk1gSGz1NW33FPvgk9sjB9EhjX644t1dVbBCJ/2moyDAJenBPWU5R6KS/Abglk0jnynbQi+wxGvBxhjPE9d8a7vMOlrbIRoZgyi3yCZm7CZhjDX/2OQQvJTsvmdhjkVI3wUD9gcbjEk5MUPsAho2Rz6h+7MEqy52LWQDhG1ComPcD0r5o5kq3knlmec7zc+fwt91rsIPLusk7F8JHxWRH6ebzhj6hS8by9PlELbLuvaqiBhBDTR6m3qpsGwqW7jVaOI/s6tuQW3klOmpZ+hr4HDUhoMdirDm3TusWWRHIa0Lb2j9ur7t7JzXUxSxcXkQ== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(376014)(36860700016)(82310400026)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cQlKbyxdJTXAHlNXT1hH+KL+mVwQNvUZKQEyNjf+6V6PiCaCEakmnLpfYMh2g2+BIsZccZF/Zi3F1qBwfy28b9DxMmRX7QiKxD4UCdF5NeaBsHbkC/VV/dYEQ1UC/R9c1YOu5vv6+cbDoOw6e4eyoudAgYvSxe38Wd6Htk9ZEqEEO65/8iy/LsMkv3WfKYZvOiy9lkh0zn5xd/0UBn3+ZDsWHKwAgMmrXlzWpPxX/mMxgM9GCVDSfGCwZ++tQvDRoY1JsCy/JYBZ+m5j8nJf6iNfxGnVL5MUyWP/THNaEaW9QDgxhSjNpJmq4sYYiPMR2OE4xSiPXhMa2CDNeOMdC6IGjrLgwoCO8IUHxRd8cE7A9mmEjTuLw3usI6Dn1E6cUiLdMXhzF7MfAZILHiDzifnuqZGNbNhdKAY/sf94MfFNpl6T2F1h6D8VHz+t9IME X-Exchange-RoutingPolicyChecked: M3uCIdI7Nu5A3dm7+8qOT0sx10HkdZ+GCVMBW7ZNKy3XeIVKRCyQ1OLaSuQZrIdO5trxvu9vPuuCRnbOpbiNJFGR0ouTdhzqW4EpVNUB0WjbGQk7zwYcJ+esNvi4ZgQAGF79+rKpysjK5fmRqEf6QmW/jYGcIEInnXDrqukIgn0ZQGLeO+WuRcoeGesuPQYy6bFA31P0ET9fjlcGxGExlq4PXTykcDonA7OJDZewbWvuyflHiT+snqKB3xB/HriAs2m3U1X9/W1cVz1bzy2Y7OBPDHHAt7D362uyfKWRD71+rC/pnwOJOhTOeB7dhDzlvsU2yV1f/p/Pcu8pvnw4PQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:48.6380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a9bc46c6-746e-42cb-2589-08df156eed9e X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F67.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5923 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX9JFUyBMTELaf o+7hIPZ0laZ2s2JwSmwc9S9UPPjjh7p2uFm+EjvatPzv/M4N3xAnlvjYsy1lR6ZQ2Ze3qHWWVGo Q8IpmL6Ki3tDDmMa2xBvuITJqFduaI/xpOUEsSXvOGyGXSQVL2HD41A0WsXwn+2FsZmnEt/NvQt Iz2rJj7oecolUKC/jHrHkyManDiHZdrRg6wXhM5TuXI0ZwWrIAI01ILBTOnr0+94fEvBLxs2dLU FNRL5CiEbV88dAySs0rewOE2ul3WbxcwU6U16oKAwVw2txHtXb68A8/Qst/CjuyC85pc0/p8sGa j1yXBoRjkgYc63afovz8NCn6Zs9Yg4/dlulSWxprBbj5CPX1Gtygy6AUHLDnckA0QAmDIGJY184 5mi+6k7Q8S1s6NRAGhhfBtUYjcXK2FNw6Zl4g0XAwrVF/s/u7xUn/bE4jQe2Y8xRBHmp4e8Yu4K UYEIbkFjem2XLTUdiXg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX2iD3w2sVXXUM 35dYVfIdpjJFgvJFomSbrXOXqQ8J+AmwjesmCPstwdbFyBEzpPuoiiRTgjnyAKbDj8vp07Uv7cu qJAEUbKyovPIu3g1p41DNb9jnJXR++o= X-Proofpoint-ORIG-GUID: 5t9TaTAE6JInnIy-IaiVLThjsGTlKFul X-Proofpoint-GUID: 5t9TaTAE6JInnIy-IaiVLThjsGTlKFul X-Authority-Analysis: v=2.4 cv=adH0Dhot c=1 sm=1 tr=0 ts=6aad113c cx=c_pps a=cGIxddJ9FFYnYBVvYRB3uQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=i7zdQjoT4sji5VLZqVYA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Each *_init_tfm() caches a pointer to the per-instance struct dthe_data in its transform context (ctx->dev_data), but never takes a reference on it. If there are tfms in progress when dthe_remove() is called, the devm allocated dev_data gets freed. Then ctx->dev_data will point to a memory that has been freed. Move dthe_data to req_ctx structs of algorithms, and store the device pointer in tfm_ctx. Add a refcnt to struct dthe_data, which atomically counts the number of requests enqueued in the crypto engine queue which reference the dthe_data object. A waitqueue waits on this atomic counter to get back to zero in dthe_remove() before doing the driver teardown. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 74 +++++++++++++++++++++---------- drivers/crypto/ti/dthev2-common.c | 40 ++++++++++++++--- drivers/crypto/ti/dthev2-common.h | 52 ++++++++++++++++++++-- 3 files changed, 134 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 4fdd24ee91637..6a8fbe67ef6cd 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -110,12 +110,11 @@ enum aes_ctrl_mode_masks { static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 return 0; @@ -124,20 +123,19 @@ static int dthe_cipher_init_tfm(struct crypto_skciphe= r *tfm) static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!ctx->dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; ctx->keylen =3D 0; - ctx->skcipher_fb =3D crypto_alloc_sync_skcipher(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(ctx->skcipher_fb)) { - dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", + dev_err(ctx->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx->dev); return PTR_ERR(ctx->skcipher_fb); } =20 @@ -149,6 +147,7 @@ static void dthe_cipher_exit_tfm(struct crypto_skcipher= *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 crypto_free_sync_skcipher(ctx->skcipher_fb); + dthe_put_dev(ctx->dev); } =20 static int dthe_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, uns= igned int keylen) @@ -225,7 +224,7 @@ static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *= ctx, struct dthe_aes_req_ctx *rctx, u32 *iv_in) { - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; void __iomem *aes_base_reg =3D dev_data->regs + DTHE_P_AES_BASE; u32 ctrl_val =3D 0; =20 @@ -337,8 +336,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) { struct skcipher_request *req =3D container_of(areq, struct skcipher_reque= st, base); struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(r= eq)); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); + struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int len =3D req->cryptlen; struct scatterlist *src =3D req->src; @@ -520,14 +519,17 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); + dthe_put_drvdata(dev_data); return 0; } =20 static int dthe_aes_crypt(struct skcipher_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(r= eq)); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); + struct dthe_data *dev_data; struct crypto_engine *engine; + int ret; =20 /* * If data is not a multiple of AES_BLOCK_SIZE: @@ -553,8 +555,18 @@ static int dthe_aes_crypt(struct skcipher_request *req) return 0; } =20 + dev_data =3D dthe_get_drvdata(ctx->dev); + if (!dev_data) + return -ENODEV; + + rctx->dev_data =3D dev_data; + engine =3D dev_data->engine; - return crypto_transfer_skcipher_request_to_engine(engine, req); + ret =3D crypto_transfer_skcipher_request_to_engine(engine, req); + if (ret !=3D -EINPROGRESS && ret !=3D -EBUSY) + dthe_put_drvdata(dev_data); + + return ret; } =20 static int dthe_aes_encrypt(struct skcipher_request *req) @@ -576,19 +588,18 @@ static int dthe_aes_decrypt(struct skcipher_request *= req) static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!ctx->dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; - ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(ctx->aead_fb)) { - dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", + dev_err(ctx->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx->dev); return PTR_ERR(ctx->aead_fb); } =20 @@ -600,6 +611,7 @@ static void dthe_aead_exit_tfm(struct crypto_aead *tfm) struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); =20 crypto_free_sync_aead(ctx->aead_fb); + dthe_put_dev(ctx->dev); } =20 /** @@ -711,9 +723,9 @@ static struct scatterlist *dthe_aead_prep_crypt(struct = scatterlist *sg, return crypt_sg; } =20 -static int dthe_aead_read_tag(struct dthe_tfm_ctx *ctx, u32 *tag) +static int dthe_aead_read_tag(struct dthe_aes_req_ctx *rctx, u32 *tag) { - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; void __iomem *aes_base_reg =3D dev_data->regs + DTHE_P_AES_BASE; u32 val; int ret; @@ -734,11 +746,12 @@ static int dthe_aead_read_tag(struct dthe_tfm_ctx *ct= x, u32 *tag) static int dthe_aead_enc_get_tag(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); + struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag[AES_BLOCK_WORDS]; int nents; int ret; =20 - ret =3D dthe_aead_read_tag(ctx, tag); + ret =3D dthe_aead_read_tag(rctx, tag); if (ret) return ret; =20 @@ -753,12 +766,13 @@ static int dthe_aead_enc_get_tag(struct aead_request = *req) static int dthe_aead_dec_verify_tag(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); + struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag_out[AES_BLOCK_WORDS]; u32 tag_in[AES_BLOCK_WORDS]; int nents; int ret; =20 - ret =3D dthe_aead_read_tag(ctx, tag_out); + ret =3D dthe_aead_read_tag(rctx, tag_out); if (ret) return ret; =20 @@ -859,7 +873,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) struct aead_request *req =3D container_of(areq, struct aead_request, base= ); struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int cryptlen =3D req->cryptlen; unsigned int assoclen =3D req->assoclen; @@ -1130,6 +1144,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) local_bh_disable(); crypto_finalize_aead_request(engine, req, ret); local_bh_enable(); + dthe_put_drvdata(dev_data); return 0; } =20 @@ -1137,10 +1152,11 @@ static int dthe_aead_crypt(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data; struct crypto_engine *engine; unsigned int cryptlen =3D req->cryptlen; bool is_zero_ctr =3D true; + int ret; =20 /* In decryption, last authsize bytes are the TAG */ if (!rctx->enc) @@ -1191,8 +1207,18 @@ static int dthe_aead_crypt(struct aead_request *req) (ctx->aes_mode =3D=3D DTHE_AES_CCM && !is_zero_ctr)) return dthe_aead_do_fallback(req); =20 + dev_data =3D dthe_get_drvdata(ctx->dev); + if (!dev_data) + return -ENODEV; + + rctx->dev_data =3D dev_data; + engine =3D dev_data->engine; - return crypto_transfer_aead_request_to_engine(engine, req); + ret =3D crypto_transfer_aead_request_to_engine(engine, req); + if (ret !=3D -EINPROGRESS && ret !=3D -EBUSY) + dthe_put_drvdata(dev_data); + + return ret; } =20 static int dthe_aead_encrypt(struct aead_request *req) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 2a3f5880cebd3..86aa99c28f1cd 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -32,22 +32,46 @@ static struct dthe_list dthe_dev_list =3D { .lock =3D __SPIN_LOCK_UNLOCKED(dthe_dev_list.lock), }; =20 -struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) +struct device *dthe_get_dev(void) { struct dthe_data *dev_data; - - if (ctx->dev_data) - return ctx->dev_data; + struct device *dev =3D NULL; =20 spin_lock_bh(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); - if (dev_data) + if (dev_data) { list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); + dev =3D get_device(dev_data->dev); + } + spin_unlock_bh(&dthe_dev_list.lock); + + return dev; +} + +void dthe_put_dev(struct device *dev) +{ + put_device(dev); +} + +struct dthe_data *dthe_get_drvdata(struct device *dev) +{ + struct dthe_data *dev_data; + + spin_lock_bh(&dthe_dev_list.lock); + dev_data =3D dev_get_drvdata(dev); + if (dev_data) + atomic_inc(&dev_data->req_refcnt); spin_unlock_bh(&dthe_dev_list.lock); =20 return dev_data; } =20 +void dthe_put_drvdata(struct dthe_data *dev_data) +{ + if (atomic_dec_and_test(&dev_data->req_refcnt)) + wake_up(&dev_data->drain_wq); +} + struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, unsigned int buflen) @@ -153,6 +177,9 @@ static int dthe_probe(struct platform_device *pdev) if (IS_ERR(dev_data->regs)) return PTR_ERR(dev_data->regs); =20 + atomic_set(&dev_data->req_refcnt, 0); + init_waitqueue_head(&dev_data->drain_wq); + platform_set_drvdata(pdev, dev_data); =20 spin_lock_bh(&dthe_dev_list.lock); @@ -203,10 +230,13 @@ static void dthe_remove(struct platform_device *pdev) =20 spin_lock_bh(&dthe_dev_list.lock); list_del(&dev_data->list); + platform_set_drvdata(pdev, NULL); spin_unlock_bh(&dthe_dev_list.lock); =20 dthe_unregister_algs(); =20 + wait_event(dev_data->drain_wq, !atomic_read(&dev_data->req_refcnt)); + crypto_engine_exit(dev_data->engine); =20 dma_release_channel(dev_data->dma_aes_rx); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index 75d9a097650da..a827817e8119a 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -18,12 +18,14 @@ #include #include =20 +#include #include #include #include #include #include #include +#include =20 #define DTHE_REG_SIZE 4 #define DTHE_DMA_TIMEOUT_MS 2000 @@ -53,6 +55,8 @@ enum dthe_aes_mode { * @dma_aes_rx: AES Rx DMA Channel * @dma_aes_tx: AES Tx DMA Channel * @dma_sha_tx: SHA Tx DMA Channel + * @req_refcnt: Count of requests currently using this instance. + * @drain_wq: Waited on by dthe_remove() until @req_refcnt reaches zero. */ struct dthe_data { struct device *dev; @@ -64,6 +68,9 @@ struct dthe_data { struct dma_chan *dma_aes_tx; =20 struct dma_chan *dma_sha_tx; + + atomic_t req_refcnt; + wait_queue_head_t drain_wq; }; =20 /** @@ -78,7 +85,7 @@ struct dthe_list { =20 /** * struct dthe_tfm_ctx - Transform ctx struct containing ctx for all sub-c= omponents of DTHE V2 - * @dev_data: Device data struct pointer + * @dev: Device this transform is bound to. * @keylen: AES key length * @authsize: Authentication size for modes with authentication * @key: AES key @@ -87,7 +94,7 @@ struct dthe_list { * @skcipher_fb: Fallback crypto skcipher handle for AES-XTS mode */ struct dthe_tfm_ctx { - struct dthe_data *dev_data; + struct device *dev; unsigned int keylen; unsigned int authsize; u32 key[DTHE_MAX_KEYSIZE / sizeof(u32)]; @@ -103,16 +110,55 @@ struct dthe_tfm_ctx { * @enc: flag indicating encryption or decryption operation * @padding: padding buffer for handling unaligned data * @aes_compl: Completion variable for use in manual completion in case of= DMA callback failure + * @dev_data: Device data struct pointer */ struct dthe_aes_req_ctx { int enc; u8 padding[2 * AES_BLOCK_SIZE]; struct completion aes_compl; + struct dthe_data *dev_data; }; =20 /* Struct definitions end */ =20 -struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx); +/** + * dthe_get_dev - Get the device pointer after increasing its reference co= unt + * + * Description: + * Picks a device instance and gets the associated device pointer throu= gh get_device() + * to maintain its reference count by the kernel itself. Callers must e= nsure to call + * dthe_put_dev() at exit to decrease the refcnt. + */ +struct device *dthe_get_dev(void); + +/** + * dthe_put_dev - Decrease the reference count of the device + * @dev: Device pointer to be released + * + * Description: + * Decreases the reference count of the device pointer obtained through= dthe_get_dev() + * by calling put_device(). + */ +void dthe_put_dev(struct device *dev); + +/** + * dthe_get_drvdata - Get a reference counted device driver data pointer + * @dev: Device pointer + * + * Description: + * Returns the instance's driver data if it is still bound, with @req_r= efcnt + * incremented, or NULL if it has been removed. Every req accepted for + * processing must call this and balance it with exactly one + * dthe_put_drvdata() when done. + */ +struct dthe_data *dthe_get_drvdata(struct device *dev); + +/** + * dthe_put_drvdata - Decrease the refcnt of the device driver data acquir= ed through + * dthe_get_drvdata() + * @dev_data: Driver data previously returned by dthe_get_drvdata() + */ +void dthe_put_drvdata(struct dthe_data *dev_data); =20 /** * dthe_copy_sg - Copy sg entries from src to dst --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8A704E73A9; Fri, 18 Sep 2026 10:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727048; cv=fail; b=EUFRnZpBT7kq9Q4ioXUe1NbgqjKMvuoXrVrlV/UOB6VoDHtswB+Bj5mSskkEU2aBwhxbPuXyRHCfiP2AKrtENPAptZuBcrGHQLFqrFWMSWL5M2EShzAeLKl5yq/DV9PQF42tHkA4bjUNxJM/odJeS/mrpW3xXAL5Hl3jSV1DIGo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727048; c=relaxed/simple; bh=14+lpbbjuBYbleZZptnnErmVsbsXKn0WAKM8jdF9Cmo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BTX0qWidcfLk8D7mBsZCPtzlAQ6lkzAujr7nGbsZ3S+n3tQnpIKpbPgzff9uVzu8MaBN0kczRUhi819ilMajyXLUcmRXRVNkYApO0c39GdMEdyOiGTHaXistJbvwf//3mvsthKSIt3gucQQ2lgNfmA2UtJ+Jw/1KpXsdvRruZr8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Jo8viOJw; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Tqn/z6O+; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Jo8viOJw"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Tqn/z6O+" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9eIG43768370; Fri, 18 Sep 2026 05:24:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixU u4=; b=Jo8viOJwrPjmQT7+6TFC8advQdPlFyQIf5uGFZAWs5X0qbBbi9xsmgUX7 1TZ9dFZMgMFSgwjQUkHYAjKvZsfchQhIxZyKMFRcQ5jyF3+TcOeXFU1PmKMbZm7S FKE2saTqq2nieV1cxH0nbHawrn1h/EMw3VNVcSEL+eNeYAq8lxsnBEOOJ6LuLMrt 4nohy2qGfAhT1jKInvAUH7Amtki4STqHPcF5/ovqduQ9qN3K2B/Gey0Vs/xMn7Za b1/rxVLV7uQKaRcE+pdWW8dDyQL0dDvaCZr3ecLHuizbyrrRsCxmNOEXZCA3IKC2 sID/dSmwefywUBdcWWOF+TUXu2eAg== Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11011024.outbound.protection.outlook.com [52.101.57.24]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs16cgspd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:24:02 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iOvlCJEnFDzqgs+qukY1tWGhXOHSzdQhkRbNcTQWRO809BPo7Nd9jAweGr1H8zfDmbO+V+X3EZYz5GOaX2Chmpv5Yxu350f4F76UYRRRwID/LdjnshH96IIbHg8ZjLVfPWmsnqAKpdK2alJPwoyFd4e6mMpwchBtGWtMxgYMmtaxjewNPcdOa5VhapJWpFaoL9m+fcVgpAnxA/sCMw0OGLOY8wgZxYvCGSLEGhmV5D65xa4ylIiSCZJHxmbGCL/PwViLHc6i4KlQ3ijq8M+vZDQr/UWCVoa/q/5Iu0WDp8kxurVNvYjrExNTGiE/Wc7sAwBD1KMU6LWME9Vo4bKY+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixUu4=; b=m07lsR3tWDZ/S8SpilJv89F8BrKsLdqYKqpWcstZOCSz8MbYJUz8pwF74Zu/XYZrPgT43dxhMKU1LfbggrQmqJPoUteWjnz6hIgHUqRsxZFagmgmx+nRvCsNeoJbn4VSyzp7nRUcPAJwsJ+0pzSHBBztHFYWJKfJQNPmcyjh67ojVY+UY2VZEsHe31u6TsXDHaLjjALKY18jho/tbnc7oxZQSaybDjeyoecb/fLJHNznKQErS7Q02fcHr+MaNXqeWa1+wIhq8DQNoeX6WM6XbV2DBokmSfIZzm8PZPjtPZE67yfOiYO2kW4RAXKuvGsIxT3E6x1SSE97NbU9ymch3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixUu4=; b=Tqn/z6O+SkYD8QfBnCBblxSM+4N+mNhBoTYJA3mLOneQtjOKSrhUPwDWRukKD4y2G+urNMaxzQ2z0fyqK1NkNCWAdOLf5+AYyVuqVKlzqxvlMXuW2uewUBut5CH+14Z8qgqfHZ7zj2QbQjlliWVH/+3Xm6Ez4euaVXIU5MPYPaA= Received: from CH2PR17CA0022.namprd17.prod.outlook.com (2603:10b6:610:53::32) by DS0PR10MB6975.namprd10.prod.outlook.com (2603:10b6:8:146::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:23:55 +0000 Received: from CH3PEPF00000016.namprd21.prod.outlook.com (2603:10b6:610:53:cafe::73) by CH2PR17CA0022.outlook.office365.com (2603:10b6:610:53::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:55 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH3PEPF00000016.mail.protection.outlook.com (10.167.244.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.0 via Frontend Transport; Fri, 18 Sep 2026 10:23:53 +0000 Received: from DFLE210.ent.ti.com (10.64.6.68) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:09 -0500 Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:09 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:09 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IAN7mj1534438; Fri, 18 Sep 2026 05:23:08 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , Kamlesh Gurudasani , , Subject: [PATCH v5 05/15] crypto: ti - Trim scatterlists to correct length in AES Date: Fri, 18 Sep 2026 15:52:35 +0530 Message-ID: <20260918102245.2784000-6-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000016:EE_|DS0PR10MB6975:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d78ad67-e072-4cef-7b22-08df156ef0a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|82310400026|1800799024|376014|6133799003|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: to/TldSQKInW1npcVZEoKjbifNKIYogYpfxXCJJEiOMkEAXJdb33QbRLEZqgd1yINUd1d45yN2INMp75gJF6YUK7CQ8b+C+gMXcZtVQ3WH2obhNta71CzbiTdhWWu08K+EoL8Qxf3XubBP2FQrTs/iM7HRYmJPGCnJjhiJEaUM/EWlAx1jH6bXzeF+EGuRW0PKirsIMJUT/w07ByU2prIWd0XQZC+0wzJDy9ea/kwFk4nU/SJi3Q9+AgEHCbPl6iRNJyMerqBDRGfhMoWFoSFcFpE4503qQbMBXYMiXSpn/LHxr2Z5oWlnGZ0XOMCHAh3TSUOIt7tstoFZcpAfUElushamjLX3D6ZkaxYJ3GfwXWEE3rHZyKi1GuDom9akZnZsFIYjFfJL4ZGw1rj4hYpee3JMnzcNx6TDVkDHQsUgBnk6NzuPCIr9MFu0Jw2vcGq8A/3CQ//7Eq8P548hfTv092zmOwEkiJ3IqLQY3GkXuvZIqKmtHz8U+JCKQLS2XSPXVkQy8lKxNrzOOpZEFu/db1aC/4PxWtNgiTrFukmTYh9hAJMPT5VUUQ58azehrur9v6fe5UmnXvW+lmcL/Iv7Zx/NZQf+kgWqK++w8/SDekVpUYKyGMdis7S6CQ4EkOd6SY3Jfaeq88W+eGtqubdFqOKPYIxl0PvFIffZmUmxRurx/WatVNRyv42KPIbLioyJWs/ZZolgoxTdyBzjutBQ== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(82310400026)(1800799024)(376014)(6133799003)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: p3SBCJ4tEmBwt2jnAIdNntcMuJV/1TzqlDsGo85ok235LMXalmcIoOAkthaKJ1g4fW2EfRUWIoUgEzDcAmiHWBQ8AO2cpSEUkJ4NZUlz7wWKqTtjocVqV2Mht6sevdhAdFFnnhkqrfI7LNx4LtvHe2FCRXDT1HTT1IKRDAZ9XVGjB/e+YZ3a8SvuFL9LFmAKUyeh3dR6WLjUFA3LGn/tOWitR+MpydpdLndDSYrwFJqiZByHyVeS3u48naLLE8ustB3A9lxclSGZJ97kBOwu+17l0PyyI2f1vsbu7t5CLRzACOSpsdccYrjYX5cjlugX/F+6fhhiUfuX3jxSWTzhTDKEqcrqN9BJ/WwpvfXfMHeZzi0rcZz5xMTGtqea7ofjmflBVen8kMukdSMdfR1ueIdM1eeE7PeTZX/Ez/fndZiz4gvjfEj++bnw4RJOtCv1 X-Exchange-RoutingPolicyChecked: NonM3bjtaiiKIgzOBqzO/tXj2W8eMQ7MHlztAQR0wkZhdVJFTolrClFinOyoZZS0IZaLvv4BfTdwF92dVSI6YFoRD4+t3VJvltiB4yFdZnpIPWYMeOcFDkuUOWbRbSPqy/IKU+Oi8nZeuhj4aGtP0RPlb7f3BpIta/zriODvJhro0e1QKlF9o4nzz7dkb1QpZ9wBsSmfYllpPWF/s6n82VJx/efCW6luqxgzJMd1PyKkh02wyGKXrSNUSdNpGPPp6t0fNrWHLfQHt0Wq984UszdtYdZEEq/Drmp+9CzahaJctSlq874WrvHGxijVhRYDhDoifQS/++gkSMfAFAQzRg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:53.7041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d78ad67-e072-4cef-7b22-08df156ef0a9 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000016.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6975 X-Proofpoint-GUID: E_0NtfSK4q-5EYyl72rNm-FaCF1uI0Zo X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX00E+6JRllG0q 4O5p2Hpt2xj0gOs4uH4qP5T1HCczaWZXCazwYRVCgRHYRoNtbCZZyl7V1lqI8Y1BxE04LogjcYW vwpMs+7lAv+0dADggZvpICkUhMWxJos= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX6aKH7DGFrirp N0hbvXt5jc2WeVxhW1fsUBK2l8GspvY3VGkIxoUkxx5BTaxNovsuEnI3N5d7CMkvfXSAhUeKaa+ 2vrNIB8ajIHLAVt8q+CXhXB1O1H9ceYnePq7GV4R5PjM9/IAbwBZ57tGvL4DijDZDI9run35xN3 Aw4ribByW6n0vvgmSmtYkcPJd/xZnAlcVX7JHqOvwsoxI7O/yf7w9qD/wTxpk6Zgcsnisic72fd q6jzKhnH7hEn/LCz1PUUIKgwiWqX5Dh1bBaOwTuWDMdRhbdMkdXy5jIYdc58XMZfRMteP+v604y fhcVvEhnWNAWfyt1m8vUzrqQgctK/TfKULATpjObbrXGW3z1lZ1/wSDPp9W41wtV0Bdb5BiFPlh bQ+dakvrrP1tAFyHghTdii404jStTQh8bfpf717B0Dwx4d9rMHsCQ7r7sXZAR/jM+/vNLS2vaD2 1j9wy0Hzls1nzUWHyfw== X-Authority-Analysis: v=2.4 cv=cKh1IVeN c=1 sm=1 tr=0 ts=6aad1142 cx=c_pps a=//qFBHKSfAsNB7iC0FeI3Q==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=Tpn98H0sjD_mw3BxSIoA:9 X-Proofpoint-ORIG-GUID: E_0NtfSK4q-5EYyl72rNm-FaCF1uI0Zo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" AES functions were using src and dst scatterlists directly provided by the request. This is problematic as it is not guaranteed that the input scatterlist is exactly the length reqired. This problem was seen in IPSec use case when the kernel provides the scatterlist which contains space for plaintext/ciphertext and TAG. The problem comes when the scatterlist is mapped and sent via DMA. The K3 UDMA sends/waits for the amount of data equal to the length of scatterlist mapped. So when the last mapped nent contains some extra length, the DMA keeps waiting for the extra data and eventually times out and crashes. Mitigate this by copying the nents to a local scatterlist, copying only exactly cryptlen of data. Note that this does not copy the whole data, but rather only the scatterlist mapping. So it is not as penalising on performance. Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Signed-off-by: T Pratham Reviewed-by: Kamlesh Gurudasani --- drivers/crypto/ti/dthev2-aes.c | 145 ++++++++++++++++----------------- 1 file changed, 69 insertions(+), 76 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 6a8fbe67ef6cd..be7ec62ab2513 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -108,19 +108,6 @@ enum aes_ctrl_mode_masks { #define POLL_TIMEOUT_INTERVAL HZ =20 static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) -{ - struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - - ctx->dev =3D dthe_get_dev(); - if (!dev) - return -ENODEV; - - ctx->keylen =3D 0; - - return 0; -} - -static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); @@ -154,19 +141,24 @@ static int dthe_aes_setkey(struct crypto_skcipher *tf= m, const u8 *key, unsigned { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 - if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) - return -EINVAL; - ctx->keylen =3D keylen; memcpy(ctx->key, key, keylen); =20 - return 0; + crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); + crypto_sync_skcipher_set_flags(ctx->skcipher_fb, + crypto_skcipher_get_flags(tfm) & + CRYPTO_TFM_REQ_MASK); + + return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); } =20 static int dthe_aes_ecb_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_ECB; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -176,6 +168,9 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher *= tfm, const u8 *key, unsig { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_CBC; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -184,24 +179,19 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig static int dthe_aes_ctr_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - int ret =3D dthe_aes_setkey(tfm, key, keylen); =20 - if (ret) - return ret; + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_CTR; =20 - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); - - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + return dthe_aes_setkey(tfm, key, keylen); } =20 static int dthe_aes_xts_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); + int ret; =20 if (keylen !=3D 2 * AES_KEYSIZE_128 && keylen !=3D 2 * AES_KEYSIZE_192 && @@ -209,15 +199,12 @@ static int dthe_aes_xts_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_XTS; - ctx->keylen =3D keylen / 2; - memcpy(ctx->key, key, keylen); - - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); + ret =3D dthe_aes_setkey(tfm, key, keylen); + if (ret) + return ret; =20 - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + ctx->keylen =3D keylen / 2; + return 0; } =20 static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *ctx, @@ -340,8 +327,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int len =3D req->cryptlen; + unsigned int pad_len =3D 0; struct scatterlist *src =3D req->src; struct scatterlist *dst =3D req->dst; + struct scatterlist *sg; =20 int src_nents =3D sg_nents_for_len(src, len); int dst_nents =3D sg_nents_for_len(dst, len); @@ -384,38 +373,38 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) * We need to handle the padding in the driver. */ if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { - unsigned int pad_size =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SI= ZE); - u8 *pad_buf =3D rctx->padding; - struct scatterlist *sg; - - len +=3D pad_size; + pad_len =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SIZE); + len +=3D pad_len; src_nents++; dst_nents++; + } =20 - src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); - if (!src) { - ret =3D -ENOMEM; - goto aes_ctr_src_alloc_err; - } - - sg_init_table(src, src_nents); - sg =3D dthe_copy_sg(src, req->src, req->cryptlen); - memzero_explicit(pad_buf, AES_BLOCK_SIZE); - sg_set_buf(sg, pad_buf, pad_size); + src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); + if (!src) { + ret =3D -ENOMEM; + goto aes_src_alloc_err; + } =20 - if (diff_dst) { - dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); - if (!dst) { - ret =3D -ENOMEM; - goto aes_ctr_dst_alloc_err; - } + sg_init_table(src, src_nents); + sg =3D dthe_copy_sg(src, req->src, req->cryptlen); + if (pad_len > 0) { + memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + sg_set_buf(sg, rctx->padding, pad_len); + } =20 - sg_init_table(dst, dst_nents); - sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - sg_set_buf(sg, pad_buf, pad_size); - } else { - dst =3D src; + if (diff_dst) { + dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); + if (!dst) { + ret =3D -ENOMEM; + goto aes_dst_alloc_err; } + + sg_init_table(dst, dst_nents); + sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); + if (pad_len > 0) + sg_set_buf(sg, rctx->padding, pad_len); + } else { + dst =3D src; } =20 tx_dev =3D dmaengine_get_dma_device(dev_data->dma_aes_tx); @@ -502,19 +491,19 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) dma_unmap_sg(tx_dev, src, src_nents, src_dir); =20 aes_map_src_err: - if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { + if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - if (diff_dst) - kfree(dst); -aes_ctr_dst_alloc_err: - kfree(src); -aes_ctr_src_alloc_err: - /* - * Fallback to software if ENOMEM - */ - if (ret =3D=3D -ENOMEM) - ret =3D dthe_aes_do_fallback(req); - } + if (diff_dst) + kfree(dst); + +aes_dst_alloc_err: + kfree(src); +aes_src_alloc_err: + /* + * Fallback to software if ENOMEM + */ + if (ret =3D=3D -ENOMEM) + ret =3D dthe_aes_do_fallback(req); =20 local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); @@ -1240,6 +1229,7 @@ static int dthe_aead_decrypt(struct aead_request *req) static struct skcipher_engine_alg cipher_algs[] =3D { { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ecb_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1251,7 +1241,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1262,6 +1253,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { }, /* ECB AES */ { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_cbc_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1274,7 +1266,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1284,7 +1277,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CBC AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ctr_setkey, .base.encrypt =3D dthe_aes_encrypt, @@ -1309,7 +1302,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CTR AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_xts_setkey, .base.encrypt =3D dthe_aes_encrypt, --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5AD4E3238; Fri, 18 Sep 2026 10:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727023; cv=fail; b=JJRrw0050KK+aOCJDcDEo9kKbEinIm9fRqjVlH74PdLh01oIT1hR2u4T5EaCvB2pBOiupOISVBxC1akFJFYMFp+K0RWzLgV9rFhqDDHCcDQweXOSsxKELuSPKdMqQEZdekzz+FXbciXwkh51Ori0igpUzH133DqsGdbYcLbm9Q0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727023; c=relaxed/simple; bh=xb+vL0JDbiPKN7Wt2F5InRrdoz1YYUcDoCoOu4uU4Hg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hc9LRdBHVR+N2E1fMFQNRhXhmtFxt0GsETHUnLqVkw2Oln/ZyKl1mZGk0Momc5PtAj1yvHPRijZaVd9hPikf/uLpa0c0FDwUt4bV9mNr/44o5KitPXlmv4BZa8aYLzy46ylwt3EXHv21jyiMHXdRwkK3dnFnjYty11KfWEgA9MU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=ZtOU8dJX; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=tPW37S1M; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="ZtOU8dJX"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tPW37S1M" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9dCgp033226; Fri, 18 Sep 2026 05:23:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J 8o=; b=ZtOU8dJXcMbzedWshgQ2fCjBU8SCZeZGvFYJMegTgkJVmPwnX6KBHLRao KT/VryVp2WcoBZWC4MVfW8U9occzIylt3z83mcIHRPQocvg3Vu0z5Dq9+bL5KPB+ g2YWSD0iWZnLT5JcS0cv7WkwOjgf9bzzAYaWwHbvXKMxJUA1iNZ8ia/cg8x4nk3d nq7yIslG4M/I2dkq8zaDv4kZuVexTtFTFhaDFliwgv1317E2BmWfSkPzstZGdE27 USPJGRsbFP0hMlU4zFbQC3jKeIXIl2NdTyuVCI18Bl419+ZBWQyIELCW/b2yqL+i LdGWVT8HCUgakoOuDlEQZ+q1qhfZA== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012013.outbound.protection.outlook.com [40.107.209.13]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs0k3912g-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:39 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sMEuXxCPtss6uCRVlLjNlRI0lwiN+Wr3NsO/y/we3D4+F5YT/sbeMIyMxZo3DFY6L62mUDk5G8OQMmsUNrkz9lWcwqZTP4yBOka9hpti8w2kkYB7QHfruupABd5J5QR+/7V54iY5semfAbidZ0foo8kHGdnhdhoe3WO3qxoo4ue/UfadAxKoLrJ+Inh9A12eoExINPfbB+Ew+rq4DCFj1fAXDl0+6UvtpiCAZMnWCbu8+WAq2JIVnX6aOntcCcF9asXmu36Br5z7WdGYu6dAMD86wYl7dZ8KEWhrM7HO9jLid4nEgw9cdiTACPdyXEGMNFuXLKeuiBp/5XiQkECbxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J8o=; b=GY3m4ePsxAeCFOO7riDt8V8Aa2u1nrUlmtqly5Ze1W4U2f5PS8iQcErJ7xGeJxzNDHO6zZ45/URzo5fOS5xuHkCInfumv+mz2kPiGhEjZhsrIeLA3Zdl6CV5+jwBqhrKJutKZxRem6f6kGyO/liO1UTSNnKRgYs6wPcZBf8X5Lv8sXH6G68V2n7vX/lw4bZlkJNGiNygOvxrua+Lp2+U7Sezz+unwBbI1lIUNprCtaxNzfFzmWzZ5PAa0GeOMpYVWXb5gOBAIwc0ugoMpW57+vTl4+rRmOsIfE3teeEM9w8E2Oe2zNwfplVZwYgT0zDr6M7i7rIY5iemnLMnyCl9sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J8o=; b=tPW37S1MCHKiL+u66Hm5r8I90UUwN9a26NzPm9VmXWt6J7okcn/X920mdbmdRu5ULiVG5v10KtQ4UGAQUWaIPbcVSl5enH38xAH32Cn1vGTKRzBM2NxnuBI+bQDS9ORzWEBW86EGk/0yDVMLXLoz3JuyZhJBmzB51M5io4DnwIU= Received: from BN0PR04CA0063.namprd04.prod.outlook.com (2603:10b6:408:ea::8) by CH0PR10MB4938.namprd10.prod.outlook.com (2603:10b6:610:c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:23:36 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:408:ea:cafe::a0) by BN0PR04CA0063.outlook.office365.com (2603:10b6:408:ea::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:35 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:11 -0500 Received: from DLEE204.ent.ti.com (157.170.170.84) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:11 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:11 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANAun600392; Fri, 18 Sep 2026 05:23:11 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 06/15] crypto: ti - Align buffers to cacheline for DMA Date: Fri, 18 Sep 2026 15:52:36 +0530 Message-ID: <20260918102245.2784000-7-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|CH0PR10MB4938:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dbd496b-070e-40ba-8526-08df156ee58f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|1800799024|23010399003|376014|82310400026|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: GR8GfIWfDy1PNZyt/SWhdzqeNaBeTZ8pVdKE2FdHY1yxzpz14eKLCVqoEKtGMeScVxQZtkL1dXtCaG60BT5c5gV+94mX2uHZimzNoh+NuJACA/m5Zy6D/Pi3G7abETyM5+tTAxHEnB22r+GzHvCfCCL4VTs9K5Wt+lCVMaFbhlGero6HDbMPb2Ipk8O+b0ko3+aixpDJPsV2Eg7vAGxSjnsa4VDoGG+q1+ds14IxtKKmjKyQIt6XaiCO9uc6UVvywwfGVCwUWl1mrek7afbVuyc0RWPCl9CpZjSaqepPuIsAigYCPf7tv3o/4IGptIPWcYVao87mtMJ45KhPkQcpjS3E2rHsF/a78UfaC6oStHQx06dPatSWWSUJ7/2H5N35oJ6K0LPKYwwrh4/qMj8EwwNUxDjzXphsxyj2NbKeU5n10WGXesCYxMvEBg+DSUBn/glTVhc2JZQ66k2dmVITM5rCumI4NZEQepFbtc721Dbfd2Lu7HAcbgPUwIeL09J9A2KgDApfR0u5JoyYhGtBvuaJLdwpCDp4D4NZFzen7ljgxZGgxkVKzyuxxtx95XlH+Cd/Uhyf/zbaARmFUE3TCV6jOnIKurvY//c9vl3cKsPbfBDW7QhwktlB+L9Evs2EJJHTITnwCn4yXU7wuA3trqiuZWKiqFnmn2V9Enrmn0Mry4bwIDUrL3TF5S0ERoDG X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(1800799024)(23010399003)(376014)(82310400026)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: az9UGFqzT2Ql+XrtJyGQh9GX58PR0hez7Up+yNUuwkOnWzCvFk9Ga6NqSx7cYr+jfCW8/CzrjwDhdakk7VDP2x/HaXcxvXtoS+l9vpQvRV//weP1hL7QUlS5tufmP40I0l8xqs6UuGcCgX2alX/2DU/4tj6jGWiREEsF+2XCfiZ65FOqZoDi6+fCgOSXa+uB77QKFLcboZnrI47YQspYLw5EwN/0wPB/6+KelEjCaOKEg8GmNFhi6qfb8rEdaenMH2yq9GRJM5GmPIbzvFBngA2hL6ugaEiinCM3XpmLaaoEMGOSxnSZzabwP1W/N5bLFAi1gI4OJTI7GTY9Z1i8d/bYXJFZ/GEbNtali3NdaV5Qun+eHK2ewdY8TxFPGPfqzQ0i1ecubaLKGjHiIsU80Ns0vKjgTeeIkWg/1Xe9Frr5lyE7BwVFbmdE7d8tzzUW X-Exchange-RoutingPolicyChecked: byRXBcvhhdwWAM0GWbMpXwgGLZtMm9o0IQdRxBIDGClYHoyXyzUV6R1FLjce2oFHdneq2382qhhFQHU5O2JY2/BWvQSo2rNv0nboabkrbX942GNFRjFKoj+gIqTT3SUfA0OoqVt3LQWQUEq5S5hVz0MiOnViFNkrtIjWH0FaCg9LIh7ZtG0hLwcPNJf8Q0jIziVnvZ5+fOvGfn2R3pULHAcCUpZ1dhHega12WwPCqRrdwG59AncahIOj7zWoyzmvZ8Lr53fSSlz4eYF7I6a5hzCA9B1DKNGSBZsfyqgw76wDn9Bf0qxLFMCX3BVPV+k8SgvGgemQ7dfy48RFzBwsxQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:35.0582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dbd496b-070e-40ba-8526-08df156ee58f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4938 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX0IfJ7EQdeNl1 GSFRE0ymt1A0JUXYl9OHp2QvT0/ptkGjxnnYsBD9n48gYAF5Yg4N4VYQbjH1yCf4NN2Sq9CgjUx KdU2ZmBYhIlPmuD/LCsA5Z6jupWlSnY= X-Authority-Analysis: v=2.4 cv=K6S3jCWI c=1 sm=1 tr=0 ts=6aad112b cx=c_pps a=XYUUcOYeOu1iXYjTrsocvA==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=8TpikKgA1nL99BGwQjsA:9 a=zZCYzV9kfG8A:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX2wMX0c/bfVb2 2vInhY/+UmI/x5h8NJsNrWiTO6+WMvJqna5zv8XDBnDpSYAgc8EMuOysmE/gOrkQ95YFgmjnsjt SeUDdmK17mz0SnHwiKZC+V/jyIGjhuhEtRJmCQbp+ADnp8bKnzem8K4XKd0OWoYd4X/3CX64ugw B4QPJymUwxShcrUZqZqpbsCKqmQdkbyOTrH3JkC8K/nPr9eYopg3Oz/JLMUX26lCrA2dY/jziwt cvl3HYpKihkIwyRRqbOzgrDAEr058+UtSrB1K1W3qYQ2ZK8u6GdVjMpDfI/ZlWUwXOUOIdQXaHA 5LQAEh6Kk6+TscP+uzNZtjiDPdT0kP1SU6wjMNr3HSz3eGQe8Fd4UX/QupvJDWInkMVjhVylY8o v3lYba55UG+kSk9x8SAwN3vTrrY4hgTXu1GLJV9dDBWdSm40lY4Xj+U+hlnxiVx3OHEyEJJb6sa rS0V1PsacF6cVYKmf6Q== X-Proofpoint-GUID: SAeUOh7HgEd-KihydcDgLYgTip5R6aYi X-Proofpoint-ORIG-GUID: SAeUOh7HgEd-KihydcDgLYgTip5R6aYi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Align padding buffer which are DMA mapped to cache line to avoid any potential cache coherence problem. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index a827817e8119a..cfb50255a5dce 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -114,7 +114,9 @@ struct dthe_tfm_ctx { */ struct dthe_aes_req_ctx { int enc; + __dma_from_device_group_begin(); u8 padding[2 * AES_BLOCK_SIZE]; + __dma_from_device_group_end(); struct completion aes_compl; struct dthe_data *dev_data; }; --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354BA4E532A; Fri, 18 Sep 2026 10:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727042; cv=fail; b=mB30w6iGYG/mtP5JXf32pAUQvd9EGQWwMoF9cjSZKT+chl91aGkXeMRqWVh+v68DaEC6UcbMQyhnGF5b2GUUiySXs7aT5/B63Zln5/SaiUqkYt27R8/4EdCiSpxLHHnaUYB/8NQARi1WLBG2rWsC0/MsmHIO+hWf4Xxfbksmfwg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727042; c=relaxed/simple; bh=L6sJTGbxYKzCcew0gputMowl1JIkjqKkuQGwSODlbjs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l3IqGavDcigAhq2DgBPlU6Tc5w8viYHJNxM0lmPR0rymbUR7ORUlrZ/5SKhzFFbBHKfTOW7YW6gKTq3tDuGAQleIsKcuIeHglh6/N/SanwXlb4caaHtDxNgmXWPFYGMWZFf3JhfEyOpy2f2G8qAWo8HpcMR4GEmSfGCrZPsUlzg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=JpQVrEI2; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ebctatI2; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="JpQVrEI2"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ebctatI2" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9eKiL3768408; Fri, 18 Sep 2026 05:23:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ 7A=; b=JpQVrEI2uw4szCGuuQ3oxAkxE3gQwLHGOdtAzgJCzSj+DPyIAIdT4XjnD 82K0xn6EAbGPV/8Kk7dqG9BJUQYMfq9Yik6QRe+IXcjifforVPPyY0J00iFyIl95 chq5z/vb9NbaEDQTjCu/Gg0OWE4dLa0IFPHaYI3OkkMSXD1OF1oZQLRosjWIvyCU 9ZGOs9VkVspUlLMfJuFz6gjsCZ9K9djx3Ozo9d845whxVroShFiqbXgUzXeGzwrU 6iKvZ5UmL8BjMQTq20cu7RI/ROsIiGj052yhmMLlQEZEAQMyaqekRscYXRaykDYT u/ihjdfud6aCpC3uMDvBzdrCJSW2Q== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013065.outbound.protection.outlook.com [40.107.201.65]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs16cgsny-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:57 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dYjeosKYb5SW+MvOW3kQjuXpQP60GuEFhTSbBPPuqcdLbjQwaf6+kZJH8KiUIu24xBrqKZbrXQN8zf0NfzqOlJ6BzpAkUziR4PKiv5Fv9dCBMQWeufmKCcWS/j3MRy8rIY4HBpECJDksMnbMqlx8jYwjsqf9LJXz+Xi+7dCY6p0KsYGJasvCX2IsLDovcL0tvETd+G/G50b4JoCzITYCaxsR8cT2QUXFhF26Fkrj4BMcO3Qy2Z9dtfNTzvWXNHJQFyTce40hOi33BntcOnK5xIK+2cmu0gwpZDe97L9qF8nRyQcdjzLn6s+DSYEmr5lpb0FFezuCQqjUIye6ZBdIQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ7A=; b=TTjSIZm1FWjnf2xcmORxJP74Wfotiy7tkXgJWxcS+wxeHp0vKVrTcuuMGUX2//x6LCcbMOzxs6054cISCPEARfXfqGN5Rg+6T2MYM7rnXg74WUNE5WVJRphfMhiYuP4KdfpdYMOe1CuygzNLbi8ax8IBu3VR8sdOlBj8Z2VtXOCNRqlTW2S7EcZmQjYHoOHhFMl0R10YSfERA1tqA8P/KvXZBlSbe4/9M6Pgqzq3UWHJoMDiG6I1qaX2TMr588slavO809t68DXTlJp7LU8jduI200Yd4GT2ZoUNMlXWNiNjNa6NXgWjaksb2NpPChT2EDVzQ7ptP1vnsUyLwUSx+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ7A=; b=ebctatI2OwybagQeFogwpKFVqkV0wQtfNlxBeOMcwE2yMqu29Pw94Jg4wOR7eRHgAD0I1gJypWDuINQtRLbUWP0XvWSmTzFL3J6i42iFyuKoDpWZVPf0N+E4u5BqLwu6aqKhnnW0FDEzPLam++oeIj91plC1/SdkKjbCOW7IDrc= Received: from SA0PR11CA0003.namprd11.prod.outlook.com (2603:10b6:806:d3::8) by DS0PR10MB6917.namprd10.prod.outlook.com (2603:10b6:8:134::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:23:55 +0000 Received: from SA2PEPF00003F67.namprd04.prod.outlook.com (2603:10b6:806:d3:cafe::50) by SA0PR11CA0003.outlook.office365.com (2603:10b6:806:d3::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by SA2PEPF00003F67.mail.protection.outlook.com (10.167.248.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:53 +0000 Received: from DFLE205.ent.ti.com (10.64.6.63) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:14 -0500 Received: from DFLE213.ent.ti.com (10.64.6.71) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:14 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE213.ent.ti.com (10.64.6.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:14 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANCZ91534551; Fri, 18 Sep 2026 05:23:13 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 07/15] crypto: ti - Separate padding buffer for src and dst Date: Fri, 18 Sep 2026 15:52:37 +0530 Message-ID: <20260918102245.2784000-8-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F67:EE_|DS0PR10MB6917:EE_ X-MS-Office365-Filtering-Correlation-Id: f3d823b1-8727-458c-15c4-08df156ef067 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|82310400026|36860700016|376014|18002099003|10067099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: XBrboBZWPA7kiyiD6YkmSxNTHtd9VICl+49oVkIUS68xO5O/+8/RYLSNM3VSWk16vv91JBAdC5ygSit60OZdhVYgXxYyADVms0d66oL4ULpSRmpagJFy3zpv2C2jPHNY9e7pEjutZwlO2e91rQinrgB+ttkFirZWA4m9ssJw+zVUwFoOEOoRdLQUZMM8+YoAWk9fghmtlnFbwCDnJZzrXnzzkkpaNIy9WAxDcJelOVpAmM7a36wZXnzC5M6nW5E0JBxagFZon/n6m/cJh9+axuxxwYSRvdOxr5/bziG/vo7+XHm+jqzYWJp/Qr9XeRSvTScrGIjzTra5m6UjArzS/3hGXT14s++HuDtheCNGt5Ako/HsEUgFcKn1aN+5f7MUxZX62bfsMNH+YXylmY5hrKVyeF+nWsDxd/wl+H/SEfsV4407lQxMG8j6WaWhlCoWdXq+lFY4DJEkqdDeQQqcenhOj6pCFTDZ0Jv/uaGffAn03Juzw426N/xSJZZOzw8cXO7KhLxa2gY6LRL0BZ1c9FZTDjV2f1PdUy2Rmxd9aX3ic9+FLxjDs5NKelf1sjLX59v7D5FUrytgJJW077Z4zS1ts2T9nGsaty3AvFLmtg7fwSeJ90lJmXWsxRqiuWbQuBmRY6/L99fAzHvmPgzu7eu0gcy/Rkj/gssHaUFOMQm9Ud1x3SbkRC6kD7W418hJUA/Cv2QTtiCTHj1vKDIVaw== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(82310400026)(36860700016)(376014)(18002099003)(10067099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tM770uGD3LSE3qS0rwhu4n2nt2Z48A1V3lDFLKyWCcgzNgw9F2zF/yl36oIq5RBnrBMd/Nk/1hKGbT9EvtON61nhZ/pRb61f1cJd+sks9rVbPKI+O65qwSUs0IzVTYqSWIeMXVPmlJx4KhQGzRSlkDzr+teIP8BpLTlrJBea0iw7q9Mbs4r3cjESpiwV0QQ1jQkYnFzIrgUuvLYB20CXWh9VJBLhXxV1miA2J1w+naRfWUTyVPdUDVFQ9EkvJq1j5vnPeIIZ6nx5lCSsSKkWJlWidNccirKC9uPnUFP8S1w+ToAJlrogNLnjxXa4rGKEH2zbWCL/8GD599kXBYsEDapdl4Wa5kzqqHYpJHSHrKFhfCR3KQN98lLU7+/pKAxa//lyGpgZLlah4FSxbZfrxUQobqjLBoOfHmON6eu3POU4HQgBjSGx1M77k3x6FzqE X-Exchange-RoutingPolicyChecked: 25BlGp2SgAOSdzhY0g0EqZWW1LDATEV5ev/7p4De6ODUa44m91RxPRcmZnAYZQrUGdOv4ns99uu36x5H68tpUiDZWCuG2yt5p9sQD/tZCrqhjU95uKVJMz9oPeL0gCUWf4IVDrRkWjwZiIjaXoPzv6aWFVt3eR0QICXmCWec7fJeBy3giFJ4GQ0IhQiZlTODA4vWgW7cImDwsBABqpi5pGX30k6xiGwLDqg1AEkbDnIV/o3l3IAU1KAcwis72qLzgs8Om8qMG0XCOBAR+Vc+3JZSeYluSb0FI5PAjXpSwFsxj7fjwbJsl6ra76OkSDr5Fcp0l08S4O7za4W34S+qGA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:53.3077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3d823b1-8727-458c-15c4-08df156ef067 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F67.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6917 X-Proofpoint-GUID: _Bo_69j-A-qWOhn5rbf7MOIXG039Mu-1 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfXzWxhTla3dsoz 00medh8k/vrSuFPH5wIt0MrMMVIKC2hM9/oGEBl3E5AO9cAiWnvbgX0PCexZhF9yLmmEpwDlEnd aDwLsDO2w4hLXfQQmlVvJGzGOdt8Rqg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX14O/D/wsWDmg DPGNGlRaZl6kZZ9hZZkryOEKSdizfTczAVLp95t7CP3pXM1aPvzlFBqzrgDNAI/bYvFA+QFdEBb NBPv30CV1sNUb0adIgwsMl4nCOVDIQB9Wl3QN72aDdc4tgmVyS/wdip/ysDSdnVrKPlPFmoCcgO cAbLvVfnw2qmnspvILAl7l3WPXRGpKyjUiLhIO7ijfddPaYo/RK6GqOT+VW6DsbZLskvqL7wV0M kHVcp6KXe1KUCmcbiS9a1n3cm+PXP3VaCwOk3wCqdQ2f5T6067wjoRbFJ27Mo/OoSSTRzQxfrgn FEv4mIhbmGvKK7jOuF5CmpMtGnRdHW93tqylk3dGN+Cj3PCLP4ylLEewFVi3bfEdTQAJ+sgEB9W 4Y6ik2mLAxfnAxWaEt+UP3hsfONTmDQlZly3lEm/jMYD0wG9tB/9QiGWkcRmmXFdpw3tGwN60z5 q4VatrJWvjfw1zb553A== X-Authority-Analysis: v=2.4 cv=cKh1IVeN c=1 sm=1 tr=0 ts=6aad113d cx=c_pps a=GhmtI3pHzNGJg3++3mR9yA==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=pcghVQDwmu1mgjzKNFMA:9 X-Proofpoint-ORIG-GUID: _Bo_69j-A-qWOhn5rbf7MOIXG039Mu-1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Separate the padding buffer, which is allocated in the req ctx, for src and dst scatterlist to avoid any DMA mapping issues when not doing inline operations. In such cases, the current code was mapping the same padding buffer twice which might cause issues. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 19 ++++++++++++------- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index be7ec62ab2513..aeccc235cb667 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -338,6 +338,9 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) int src_mapped_nents; int dst_mapped_nents; =20 + u8 *src_padding =3D rctx->padding; + u8 *dst_padding =3D rctx->padding + AES_BLOCK_SIZE; + bool diff_dst; enum dma_data_direction src_dir, dst_dir; =20 @@ -388,8 +391,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) sg_init_table(src, src_nents); sg =3D dthe_copy_sg(src, req->src, req->cryptlen); if (pad_len > 0) { - memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - sg_set_buf(sg, rctx->padding, pad_len); + memzero_explicit(src_padding, AES_BLOCK_SIZE); + sg_set_buf(sg, src_padding, pad_len); } =20 if (diff_dst) { @@ -401,8 +404,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) =20 sg_init_table(dst, dst_nents); sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - if (pad_len > 0) - sg_set_buf(sg, rctx->padding, pad_len); + if (pad_len > 0) { + memzero_explicit(dst_padding, AES_BLOCK_SIZE); + sg_set_buf(sg, dst_padding, pad_len); + } } else { dst =3D src; } @@ -492,7 +497,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) =20 aes_map_src_err: if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) - memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + memzero_explicit(rctx->padding, 2 * AES_BLOCK_SIZE); if (diff_dst) kfree(dst); =20 @@ -882,7 +887,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) =20 u8 *src_assoc_padbuf =3D rctx->padding; u8 *src_crypt_padbuf =3D rctx->padding + AES_BLOCK_SIZE; - u8 *dst_crypt_padbuf =3D rctx->padding + AES_BLOCK_SIZE; + u8 *dst_crypt_padbuf =3D rctx->padding + 2 * AES_BLOCK_SIZE; =20 bool diff_dst; enum dma_data_direction aad_dir, src_dir, dst_dir; @@ -1125,7 +1130,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) kfree(aad_sg); =20 aead_prep_aad_err: - memzero_explicit(rctx->padding, 2 * AES_BLOCK_SIZE); + memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE); =20 if (ret) ret =3D dthe_aead_do_fallback(req); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index cfb50255a5dce..f78420ba871e2 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -115,7 +115,7 @@ struct dthe_tfm_ctx { struct dthe_aes_req_ctx { int enc; __dma_from_device_group_begin(); - u8 padding[2 * AES_BLOCK_SIZE]; + u8 padding[3 * AES_BLOCK_SIZE]; __dma_from_device_group_end(); struct completion aes_compl; struct dthe_data *dev_data; --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FC44E3240; Fri, 18 Sep 2026 10:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727024; cv=fail; b=F9jQ7B+DvNn9I595O4Nu1emO11joaBnwfeD6jr1lrR5fK7o0LClelEGwbMmleoEbXkDi31HoOSzz8tgkKygWi1YLwIxKOFnSURW97Pggs8cHtd7uUv2IAvcBu4ab6Mxh1BZy3VIdWD362BFlvsmOVJ4ialIFIvG2VX+W5BW2/Js= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727024; c=relaxed/simple; bh=Ge9j09OItfl39sMD0+R3OKL8fXxzjj6qvomlEshNfas=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pbTNhha6rcjGIZDkz9+7ICIVkBUTsCQNivpuQLRYaKnqAhKawb0IqR5IQgeXrAQd8qcTQE8evNZ0b0WM07s1jA/caYPglMBLrziN2yiRCOdHJ8+vxu65rPglj7fToZQUvwZbj+gtbrqk2mE6hlXXsQjmCy42lH5Brj/8W0WihMQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Y77peWA0; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=M0S6g5w6; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Y77peWA0"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="M0S6g5w6" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9cRIG3870217; Fri, 18 Sep 2026 05:23:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNX uQ=; b=Y77peWA0wySxpCyjpBGM5wZB38fd6Rx3UQI2JySJwkCz83NTFKXsQy66V MEi5EUOpRCrABtVg166M0wI1UalR1x3Jao4omltLv2OMdLq9Jp105DSUNGwpw9TO vZMWELtCuj64DXolJkuNZn751BTVwwJ2uTqnQQvg4whEl+XWayxf/hrnI/HGeM7A z6jKPnTpgdCZtb/LBmOrJNss0vDOPzXpelbGdz3c3yT+xT2LKf1KRE6q8lQxMOwv JdVbbtdtdz9Z1cZoa8zwC/z3pcBJqdmjW1AhV7JUtxudVztNaOVHIKgKTNjGevuQ DGZZXdAz+zcUTa0T3ZiyJ/Zag7afA== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012021.outbound.protection.outlook.com [52.101.53.21]) by m0380145.ppops.net (PPS) with ESMTPS id 4grx6d9ymx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:40 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PAqHUiqagY4J2RHV7FWOH06wX+wYTaTb/l3QfX/3O/L7cLVkI/HR2dcqG9JgRDRTdMj/g2OfvggbYA+sS7FIbt497T10WaMZY7eaElAu2qEMIGYAQJYh2CamHRXLvAJSpOfCTjXUbKSXTl41NuvBQoswoYTc4DDqTFQWo6qCkxuHHS9b4jA3U7qUwLvrcAdRIhUi3KwF3v2I1dziLb2H6K6kLmNejZMS8ea8j+xSdJfTdQOMshiMGytdzSsuT2dj8vla8PvV+O7/eaElnkTiz6Anq6E6wCKYNR9feZW7E5enjWjfOqAj06aLpZSvyEXSMvKhHByLJ+uNYroB3fw5JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNXuQ=; b=r1e5YY03AxhOF2rm0ORhup14J7oEH6IGssEnqZ1fpZy3Ja9mortevRYry+JxBrkTr9nM0qotdqZC+6eulZMEuIzsGAtp3i4qug2Al5GGqcEuTFnC9ltUnQICumQzOyygJ5PxD2Xs3fpZgvXNBeNUmvI0JPFxIoR1aUoVF50D3z7Vi4GIc4ZO5Xu9dR7jJPKLW4lR2PyslQz2xxJCRyvIxGTMWsFamtonB1bxcVCVuy4OC7KiOqeLDF69IGT1pgikZcS5d3kPVzF3zXYihdHiiL4YT1SIUvRcERsGSv1KM8Uz/Tp0WV5OiCHvUrsRWeOBw6qoMitzxBOGLSjbaOT8yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNXuQ=; b=M0S6g5w6Eg+/lZvf1g4rgTs4UTBz26SlS1/I6ocwfV1RJA3mYWn3HGm2m8VJ9qbWDN1yD40WrqYnX1qR+Zla3EkGE6/v1TDofmpkjkszWRug5fW9hwYHbUrafzKGT/SliD6LY48LP8R6QFArXXGHakFPlem8om42/zTjBoVLxPs= Received: from BN0PR04CA0084.namprd04.prod.outlook.com (2603:10b6:408:ea::29) by IA3PR10MB8345.namprd10.prod.outlook.com (2603:10b6:208:577::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.7; Fri, 18 Sep 2026 10:23:37 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:408:ea:cafe::5b) by BN0PR04CA0084.outlook.office365.com (2603:10b6:408:ea::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:37 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:16 -0500 Received: from DLEE210.ent.ti.com (157.170.170.112) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:16 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:16 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANFNZ1534591; Fri, 18 Sep 2026 05:23:16 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 08/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES Date: Fri, 18 Sep 2026 15:52:38 +0530 Message-ID: <20260918102245.2784000-9-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|IA3PR10MB8345:EE_ X-MS-Office365-Filtering-Correlation-Id: 17e83c30-5889-4bac-50fc-08df156ee6dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|36860700016|376014|1800799024|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: oA3UNTznPrza3D7yhn0rOiPhtz5YH9/ZrNE1YuoPkvn+LO7KhKqLISxGgg/ActjRZL3CD3tG9HURXN4caCFU0vlUHvWmQ5imDMEAbR+ou0b58Isew65aTWCLNNuQXfmwWulay0jactTDpWOVzrz28i4aBKynaZt+gks/MdS3oloRKzgVJXDxzI0fj0tH8vXYeDzDPY5JBfzRZXDKLWVw0HxUs2SGBeSM+5162Ix3GYw/CGheP2IjFoQ5pa5HwnTnXun10PGr5DzmLcKz1VpYKL/RqUueguZEW6hYxPQEuZdQRxGlVy7+tVPyI+bJBnV789a7mxAKyd4KBNpW9e7TSiXpYZX5reAmpm4JRFBjYvS3+0ZpU+QKuXvyhtph4yqFJxMugZYEkeec1mveQaHZIhrzrrXUFKKmagXLEPH2OzgVxryAte0lBnihZrwii56Ebjm3+rV8bvONL0xPMtErK13get4XVdbmCFwWkaNUcsJInJiD6ANYvzcLealCoLsbrnL6NWzsWrGS6d0YQcI0/w9FzYJ4ImvKqcvEF6TVPo27WT28US5rYBpJS7gGBFwTWbnjcUN6CTX4cfBnazU1yzWBwZ/pyqlL166lfaYNI20gu3oewsut7/utcQm7VGw+1Ioucr8djB59UzgZJTkUGHcViUdPMh5kola3lg5obw0rLaRsumAXpTWTmg3rGlOdeeywrwKowOvQjo9hT7b2Hg== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(36860700016)(376014)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lR66ecYChtENkZWG9nFZkhC02vmiw8fbxoFQDTH99nfuV2q2SuRirisxSDJNx1WsKgeneQvnAtJ3hCHx09FsO7W3ActGy2CCAeee8WJ/BMYC1EbY2B6gHQGPUf925Gis3ZByEjG5mnjxemCljN3XMOnsHwhWny5Ll8zRYnrd6hi1YvCCnX+Rhl39TuMMGUvsVloeMQwDWa5gYtJEoxY/ImN2crfIrIWb8BWhSELMYpSG6yJy4z71ni+PfnQWEGIrT0DQEl8wHpaIixxw3e05/1m2dCQVLbLhmToZDPTGuGxgA9rZBrgNbsnOR2D3lamZTiZ8rp3+z5Q/QGUUVW59uHMMPkPypiepIryj1UnRSiYQMUhCAKvjFTp7JyPD1oQ3HlR6SWGs/YkDrarop0qzgkfPfTt8jnKInP2erWMqEE82EDbWHyoT3TJs2Qis/S8R X-Exchange-RoutingPolicyChecked: IvQ/XfRGMFfAfyaYqbs11NIAPuG40oajtnTbzqN9Am6xVUK1kL21J8MYTNLYT0JJQH5RGlO0Qug+Ful2yQqB1TjR6GQD5NPW6GqrsX1lZRAiNMpCuZycDsoYXluNussQaig1fuTOca73NAUuYwruh+bQKuMD50KU8Fe+P9IXNtMeUCfPuwmYYBMbzEMILxW12rxtw4I9ulMUAPdYzpn02HzxTyGi5LHzeL3ZsTmEXxNoXcsa0ksYZYOzp5YGOrrSnF4zXgkSvDKH7eQA/gE52sj1g7QlKBisviYRor+1sDdXGq613moEIuqamKvaNfqTpcDAm4IIEPzxnMwWVT3UkA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:37.2506 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17e83c30-5889-4bac-50fc-08df156ee6dc X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8345 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX/Nd7zajuXLTI h1eRsIJOTK8us3UTJWdDinYJlzLCYx5lV2bfWwlUwkUBt50YRHtEfRY7/w0hCuaySq2VeAm0lH8 baW6CkbYgZuA6vi47igwmKmY8kHwV6s= X-Authority-Analysis: v=2.4 cv=Cswq4X4D c=1 sm=1 tr=0 ts=6aad112c cx=c_pps a=oYvfaNmKcCZhiE/ts8qH8g==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=wrH6CD59uMa574BPOq8A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX/0JZmzDjj0RN gDP387FILudJMYmYOsWyjnZYJSCfgzAMdfuOcpmk4p7zI/nz9MpEA3XAMzquSDL7UDm1k+xPZed Pd+w58VuzPlC2pvz4T1Q2CCSftsAK+k4ZtvMklvAz1jgZhFUNLbE19XlkCt2SS8gCQV0aH+mliV 6ddC/AQ4Wpne04MSEz/bdoHUiMEVxza1VGLzVbAh/PimVPhFcmQ1eQ9PsVRrSU0Oi0WNbygY/cG kA0bwic8HR5TmbZQ61zvmYNzHuQButdZMADAXqhlt0F98Y3lOWwhlq6F4eQuM+Sa67shtL/+WJo XSX47LIXwUszAzYYDi6h8UFtqnDwiKip6JPeg/gasa2bbJMkeFBsewM4kpvr5KXNyZ8dYcsv0+h 1T+mDtJrz3xvA0kiAIJKWHM23+EwzzashPNclXUUJfUEg0Wb3hzV/LxnslxInlXZqtmeGWavnIT G+leUUEdjgNPyLJVWcw== X-Proofpoint-ORIG-GUID: YYhj9cOC4PR8Okkpp1-Doa0Nie2MHqqX X-Proofpoint-GUID: YYhj9cOC4PR8Okkpp1-Doa0Nie2MHqqX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AES driver. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index aeccc235cb667..bc3591ec58a1c 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -354,6 +354,11 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) u32 aes_irqenable_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_IRQENAB= LE); u32 aes_sysconfig_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_SYSCONF= IG); =20 + if (src_nents < 0 || dst_nents < 0) { + ret =3D -EINVAL; + goto aes_inval_nent_err; + } + aes_sysconfig_val |=3D DTHE_AES_SYSCONFIG_DMA_DATA_IN_OUT_EN; writel_relaxed(aes_sysconfig_val, aes_base_reg + DTHE_P_AES_SYSCONFIG); =20 @@ -510,6 +515,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (ret =3D=3D -ENOMEM) ret =3D dthe_aes_do_fallback(req); =20 +aes_inval_nent_err: local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 461404E2F0B; Fri, 18 Sep 2026 10:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727021; cv=fail; b=gDgoGTenRbAz5JPLzMR0apZD9x+A9Wf1Ug0HiAS2aYYwobqG5BRZnOkY/s4qbH1T0CqYrPZ9/wsIyjhv1129pjPE7Kr13Jp+Etfht+iGuET9XA3EXdFjtnIPh020xc5zou++W5RX1qYZBoXwRbSiStubJB+qC0LLa9XPr7Kxj6U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727021; c=relaxed/simple; bh=8AiEGfb8lJzH+XTUake6thyKV3Zd4kzDjnDYuThYIjo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lLKL+pxVI3aa7NaRXrqaTrk/8qItexqk2uLkRlLVEFZQ31/sy3HVB1MImUybskgkqv7APgc9QS6lWlvOuLRbJA+fc2PEPXVWTFwxoqFvpkYLd+iDMk9DhUOdXtA+tH5jnD5rs6BVSr7XwKod34NdmZqaUboQWcjjLg1AwyIf5vY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=njpWlSvC; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=pS1rEU7a; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="njpWlSvC"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pS1rEU7a" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9dBtF1233790; Fri, 18 Sep 2026 05:23:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT 7Q=; b=njpWlSvCiO8u3HYzch8UKBLGSzgEES9zF+ju87mINC+XYT0d9NB40c+rC 3Skyjdjuwfzit01FdtOtFbZku7/T8NqZ+GCLkTadwv85NdLLrY67jLS7n2MDa3ql 8QoFcV4MvncEM7uo9y40F3WKO+4FjC5/IWTPOw6rn8wM0Dg7vMGe6S4TF/LNaV3y bEHiwnKKXBOHCg7f4HXwDLKvIzE+JFoxp0s6hSlnLkkhvBl4yY4/yVffSe+5Sjza fHgWGvSrBZK4kZYMyKD8WUHuPhYb7VPIfcUXVOEAeDx5aIpOpQKFeax7H3B/aFBA aIo/IBlPPZhxPHjkDKEmoIBhiYhmA== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11010066.outbound.protection.outlook.com [52.101.56.66]) by m0384305.ppops.net (PPS) with ESMTPS id 4gs2ux07bd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:37 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NqzSNt/4oaeZR78bSaf/pJOzEggHpZqRPHPYFEG7QmKLitqzMudvV9vydR7cp+355URZaOmCrb3bazxn/J/MCz0y6Hb/oXngV6RW8DmCgoXussmANLA+whaiH3Y7WssGOdakoBygb3aQC++3zv50wcqqb7T0YgzXh1ryXvd0L4PBFEs+9LOx3OXds+pQpEg1ipBzxE4OPGjJ6+HSh8HMadXWjCE4pQ2bXe4J82jGMi5iFuczPSTbqJtAo9IYY58SJToUeLhr1kF44Q+WrSejT2uqaCOEBW+PDcPfNMmrRt8VY5vyIplMs3uCcLFOyYAEvoLuQoFBY5k5YY5z1hFjsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT7Q=; b=kn4xVsqrNhcTHeP+kP9GI2TkOPpx64d7h602qql0bdweCa+oBc4sACE3aRRh+uMdDnQJ3z3co+qE9PqX0M3g1CGbUnMtxwu3RVryumEPhQzKBU7xj8D6DGOEzwsois6bY/HQ2a6B2BxMMubrkfHe4W1v0+6+4EbPEkjmQZvVzoidW5xzUkrcTw2xHCmbbaw8jIt+TaEER0aD31iOeHkbZeD3tNqBv3cnJfq2+oODMa4hUJH1SWshNU0lLg5LvFIWTzR+v1AL2/twxo2ZGc7zL6I7ko/SBmY8xfk14UjTq7ulf4TMD+dKy6dFNzelGyA7+otWGeG+z4fwKlP4rUMxug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT7Q=; b=pS1rEU7apHQypmNQrX7McJXdwY4KIIOfs/lCjZelaqeDuek8Sjmh2tKoamFK1uLaTYbEexU2rILfr69RbcELOIvzDHTIQxQxu9IyE/ynx9OeX2DAt1EvNibh1nBUh1enLMm3XXsSwEQ4aOcEcf9S7gBufk/qHalXIxS2tCppCyE= Received: from BN0PR04CA0056.namprd04.prod.outlook.com (2603:10b6:408:e8::31) by IA3PR10MB8092.namprd10.prod.outlook.com (2603:10b6:208:50d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.13; Fri, 18 Sep 2026 10:23:33 +0000 Received: from LV8PEPF0000005F.namprd02.prod.outlook.com (2603:10b6:408:e8:cafe::12) by BN0PR04CA0056.outlook.office365.com (2603:10b6:408:e8::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF0000005F.mail.protection.outlook.com (10.167.245.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:33 +0000 Received: from DLEE201.ent.ti.com (157.170.170.76) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:19 -0500 Received: from DLEE207.ent.ti.com (157.170.170.95) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:19 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:19 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANH4q600519; Fri, 18 Sep 2026 05:23:18 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 09/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD Date: Fri, 18 Sep 2026 15:52:39 +0530 Message-ID: <20260918102245.2784000-10-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF0000005F:EE_|IA3PR10MB8092:EE_ X-MS-Office365-Filtering-Correlation-Id: fd0f4688-d27f-4eb2-7d5f-08df156ee4ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|1800799024|82310400026|376014|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: yqh5GQmFeHH5djnRUvYERCxk8fGXnNXMr6poUYF1RJIXxpb0iKvEhEzZtSVsC//wQrW8XrxSHUk/P6gQoF2EEa5L3zOk9dmCD/HzO+vs3oSvDIlk/dDkfWyu2QO4KN87Q6FAMGAkFCH3UcGtFEnHPKrBbhmb+8BXgVnvKwQTZBXKWmzHeR5Y1RPSfpyNKI7nifZyAXZ1ja4eeK/iT2rNSuWNtYq3aqTEuq68yh2OOrdgakCN47AHywldPoIXiILQaLP9Wor9alk8mbDIEWqWqGQ6CrziZjkSC4oSeWiFScVbyadK0o2IERAGrkuvD/ZPU0WeXmTdLMnUp0HWmoWO0ig7ED3SRke1GiCqUTaePdDlnCges2XmSe9vNwh7ry1s7xiq3p3mnszZZa0g9fpyeDsukmuEH2jDCGvIAodVbRHety0MmDHahNc6mMx3aU7becDhglOW6W+ZLzc728xLrKX3jKSw0C1SSIKoyymnvrKMlccFr9t7qkdSeu1nj0ahjXGV5uYV+VbYKNbjZ77d08vKIBnJUCJL5XaJbwQfyThWEEIyKS/9KskaLTt00Br00nz4X6118x9HIEElQ/zATtNtN5En7r+NNC5VuV2ZS11uWNGAdw7ljfYhCcPa6x37/bFRGMsEhtoYvmSXuQELiCwa4LZgWuDcbSrIRYPYu879u/j7QB6zCBmq+QSj6LjFkb3LZpXIteYF1VgIqqyt9w== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(1800799024)(82310400026)(376014)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: D8ZBpMUB2pgEiSpjFkI7ujdMA589LLYw6TiWOV25fkkJxtmOCswd4v2w7hpjDlwEQLN5wu4EzOAUKG6VqnJsLu+u7S3OM9T0WxqURHac5i83ELt92oEhmyTItic2DL+m68dbwppf9eOG7HgwrDc447vHlgBuo8VrWkradM/6zkkmcdmPEK/OCuSlPtQ2stPwpK9phAXfatqpcrwx8XiJ72LQXhbiR6kLbESROLUqJi0PMRqI4MTIt9dgMheS0k9iyhggke7Zy7x/ckkl6yRgHhNO7MBYj7eHFxqXsoE+gW0S3ud/kH92KtxwniyPDoAcI6tZsOQhPhHraeCksKd9DKqJHP1FynelcUEm+CaoHCstN5MvjfH42zHAckD/AlbJhRtgC3e9CNeCRxP4DZQWUGR2dWy70gx6C3ma9Yc8NOOJKI8GoSyuw1BfTIyaXk1W X-Exchange-RoutingPolicyChecked: 2tFdPz2N5ZwRABBUUP4/P8WbVllhrmjzSAlPGeDwcuHoacreqbTi6DFjcKYVmjcDZKeRzgzXiZta3L+UAxIRGhb4R4YG1uaqpG25Mquf6N1yszbVo2EnIiSb1J3SrNcbYPTJtOXl4iknX59FzWK4Xkur8HtFXLUvu0zYNn4l2DfTpPGi48T34GWthb20s+ovYs+C2btPR6zM19TDSIXmkdsEbK7pbUssJfZS3GQRjTI5PV1uNTejKTeXduKA/7Xm07gjbwYHLKC8mcvabnfNFvUNgmLZG02tm/5tko24d83HDlzd9QW7H6XbPftDtiyM/NjV+MTkRhDSGChIJSOLBA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:33.5675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd0f4688-d27f-4eb2-7d5f-08df156ee4ab X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF0000005F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8092 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX9h3+qiAoWdTx BwNRWP4yYlmXnFu/0PLGw1D0XI3+JCmD9aluetFXWNSgUaP+No4LVqMX1lWd/QlnXpTuyP+HRer /guB6NJ7QIsRR7exnjZLsTaxaQ1QUTI1oUuLe3bJq6/I5RTi6BLI09x0PXu2miCDxY00wlLjcbR g1qaWDYfmnDKqGzMMrY/5b7vg1vSyAZ9VfLNo/YfnGk+JSKpoC8rkcgTSTZ0GFlFxSTCwScrtt+ IPLYUp3nlD0VjFXu1SSv8g1Pt7WHeeVOmghoh7p900mC5hfDtsPwC9fsMMS2/aKpu+2XB6yloMo 79vV/m+faEn3GOmX39qSGH5wdvLBduC6PHsIeQD9aO6MAYRnhOYqcMi4P5kfOAWDdbS7cNgxeGQ OFMEyGf9Bh1aMRoDPim1nkyM03TVaif62Rcme2TSw83tgNwpTzOoq721frHBwVkXJ3qEmjXDlzm WA6+w6jg9acE/bChm1Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX8wR5tQB4aLP1 uKeLEpALGvEqof4ID3jOsu/BCuXMVUIZ0itXbGkShs7FpHWHr1D+Shz5bM+ZAbvMKxPQ40tuDcD QN8aGJA39aX3Xv5eM9g6OlmpfF5RLkM= X-Proofpoint-ORIG-GUID: Qf_yq_xxKVGCBMnWbWB2THqybwk2itHi X-Proofpoint-GUID: Qf_yq_xxKVGCBMnWbWB2THqybwk2itHi X-Authority-Analysis: v=2.4 cv=adH0Dhot c=1 sm=1 tr=0 ts=6aad1129 cx=c_pps a=gd7JxMPBqN93mtTmHvcGFw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=iMD6g9N4YQ2QoEUmFGwA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AEAD driver. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index bc3591ec58a1c..65a53fcf80467 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -641,6 +641,8 @@ static struct scatterlist *dthe_aead_prep_aad(struct sc= atterlist *sg, return NULL; =20 aad_nents =3D sg_nents_for_len(sg, assoclen); + if (aad_nents < 0) + return ERR_PTR(aad_nents); if (assoclen % AES_BLOCK_SIZE) aad_nents++; =20 @@ -697,6 +699,10 @@ static struct scatterlist *dthe_aead_prep_crypt(struct= scatterlist *sg, goto dthe_aead_prep_crypt_split_err; =20 crypt_nents =3D sg_nents_for_len(out_sg[0], cryptlen); + if (crypt_nents < 0) { + err =3D crypt_nents; + goto dthe_aead_prep_crypt_mem_err; + } if (cryptlen % AES_BLOCK_SIZE) crypt_nents++; =20 @@ -756,6 +762,8 @@ static int dthe_aead_enc_get_tag(struct aead_request *r= eq) return ret; =20 nents =3D sg_nents_for_len(req->dst, req->cryptlen + req->assoclen + ctx-= >authsize); + if (nents < 0) + return nents; =20 sg_pcopy_from_buffer(req->dst, nents, tag, ctx->authsize, req->assoclen + req->cryptlen); @@ -777,6 +785,8 @@ static int dthe_aead_dec_verify_tag(struct aead_request= *req) return ret; =20 nents =3D sg_nents_for_len(req->src, req->assoclen + req->cryptlen); + if (nents < 0) + return nents; =20 sg_pcopy_to_buffer(req->src, nents, tag_in, ctx->authsize, req->assoclen + req->cryptlen - ctx->authsize); @@ -973,6 +983,10 @@ static int dthe_aead_run(struct crypto_engine *engine,= void *areq) if (assoclen !=3D 0) { /* Map AAD for TX only */ aad_nents =3D sg_nents_for_len(aad_sg, assoclen); + if (aad_nents < 0) { + ret =3D aad_nents; + goto aead_dma_map_aad_err; + } aad_mapped_nents =3D dma_map_sg(tx_dev, aad_sg, aad_nents, aad_dir); if (aad_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map AAD for TX\n"); @@ -994,6 +1008,10 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (cryptlen !=3D 0) { /* Map ciphertext src for TX (BIDIRECTIONAL if in-place) */ src_nents =3D sg_nents_for_len(src, cryptlen); + if (src_nents < 0) { + ret =3D src_nents; + goto aead_dma_prep_aad_err; + } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); @@ -1014,6 +1032,10 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) /* Map ciphertext dst for RX (only if separate dst) */ if (diff_dst) { dst_nents =3D sg_nents_for_len(dst, cryptlen); + if (dst_nents < 0) { + ret =3D dst_nents; + goto aead_dma_prep_src_err; + } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4603D9537; Fri, 18 Sep 2026 10:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727037; cv=fail; b=lNbvQfZ372n+4aJG4Fghwp8+xrfIeJZWzW8NRmfckW9mT7r0x/KKFDTSeXY2fPqOgDdYYrWTPl4STpbF1q6zEk6elB4ncAuoHHXHzuHfYrpC+Xc7psbKnmg34p//AuxdXWGwtyqL3nQAZMC3h2BD4VCcXk+YFu97LMoIyIAkKLA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727037; c=relaxed/simple; bh=6RV17K+dOkVeshFmshHqF6sMCwCc25grQ5kOysr9CGI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aQq7NWft4qRWvyZuXb+WN7+rvdMFL3DhnmU3IaFhRblNTk7cBHm1Qt6ii47kAwK0NB1yyGbtdQ6ziiHMDtp1amg9if+5JPSdniuX5wqvjVBhnrMWmbLItTl7uiHlunI6E+BrDbk24kgLRM4rpU/nI0wDmC1j7NMeyRcBe9SxZX8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=k6v34Nhv; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=TLsrG7SH; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="k6v34Nhv"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="TLsrG7SH" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9eGvL3768282; Fri, 18 Sep 2026 05:23:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rp ss=; b=k6v34Nhv8kFP+neEKo+4/OyHH+sS4UMYwWhgqwpa7GBxashklGYnCNpG4 fi0cJEFupQ/gNNss2fvHJZb3/JVMGEiMZIdeEOvyBgSuH4GPITRcHHNJwWvZxtQl sRgXaNP/jO+WKxaA4WUgpRUgmAgAfKw+QRC5kb8UQT0vrLfVCMd4LyTiJzycbOn6 WW+PDIEDd8W9UIOIgmZUJ0v8979LVAEhXGc/VQ3IPQXKq2DHKl54uVgtbDJtRYcA 5OhYzyKNVey4L2qX/DIa/5J8uWs4sRDVEpUjcBF9l4LHKsSO7qt9UirDWHGp2ymG qnwVcmBmwMJe7wu20zPWqO5mNpEsQ== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012005.outbound.protection.outlook.com [52.101.48.5]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs16cgsnf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:52 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tdWcyfmVNFRcG1P68kwex/WvPM/bkVku8UWOFJguAPAruB2aM+9ju8fcC0mf1tAfaahDim/HmBNX60Nf2fMam5LtGx+9DVYOTc9/bGz1hQAIFKWxv3Xh4QkbtiT2NNYengDGyKKAwq9ZRzatgssIJCy7wQ/+A9BH/0cMlh+I/3AXI+WwXcicDeyBxH0LIXSal/7T4q/OzMVNx5Co1oi0Poko/0RFa708Q03AC3zRMQ14Su9uib13kVGR0Uf5IN0mMEZdKDP4j/uHBd5Z5jxy7LhXdknt6+fmCD9R+eV023sa8gSrL0bcteibe49c4Cbg2ryAnZ5uX+A/5fjEDvlcIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rpss=; b=zCPOKHGPHRuSmAwQndU7FpM7lz3h1uItupyTgRxv3Iwuz+y5qSbXVTf/eQxMx+R01kHytFof9gPhGZV6yelqJK7caDlX27MuSlGKw06SVOgiotESENyoQLZyPeY75yXwROm6hil3dhPcOgrtgpjV6EYP/0D1FAOEJmCbwd+uodI06DkrFVBZvsl8y74jMKXsifjXj0wr6Qm5jlkR6+nI+sKhIDqQwRu/eCKFU43GUToB5TQ2llGhBdq93nGficlTsG2JW4xbHbVSwYjZryqEaR2JaihC05z867bKQcqZDioaXbVH5zgRCzJLXmVh9KxpWgdtGJSWXZH7YDMNM+LPmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rpss=; b=TLsrG7SHIJkz7XVBO78Tnn7v4mn56ADA9S1QvpxioXpsJTgiiQNWpRuMP475fHrO3l7xmIpjHtt4YFBJVoe3O694C8lGlNJEkfJNuwF+j5+ynK73vQG0Mqt7Fr+cl5ovIAoemnHsr2KAP80lrs5Exk5UiG63u1N8n/B1nehnQgE= Received: from BN0PR04CA0068.namprd04.prod.outlook.com (2603:10b6:408:ea::13) by CH3PR10MB6884.namprd10.prod.outlook.com (2603:10b6:610:145::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.13; Fri, 18 Sep 2026 10:23:41 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:408:ea:cafe::1c) by BN0PR04CA0068.outlook.office365.com (2603:10b6:408:ea::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:41 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:21 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:21 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:21 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANKMH1534705; Fri, 18 Sep 2026 05:23:21 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 10/15] crypto: ti - Terminate DMA on all error paths in AES to clear descriptors Date: Fri, 18 Sep 2026 15:52:40 +0530 Message-ID: <20260918102245.2784000-11-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|CH3PR10MB6884:EE_ X-MS-Office365-Filtering-Correlation-Id: 343bf0a5-b50d-426d-098a-08df156ee98e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|23010399003|36860700016|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: F2Y9x9B/K0zDY5MfvcbZWVM56/900VOtCfzsaWpOGLULo0fy3p54hQ6rnzff31qezAEKkgSmb4aQpNKM6b5YH5WWdreVT/JZ9QIp+r2zcK8P7kbKMjOkk3JlyU0ug49GGbHd4MnsWwEp33VGVvvOnXP19Y43RGz1YSrC6BPaShrZZ8ocw2zyBmQ+6ioQaB9mJ9588+2e0IKXGGd+fRxAEc2DSf6Gi67Yh8IiztmJhk99rN4B6rEIjI9bPFFW9/wcze4KEf96g/5qWXVnatEaksLLEdYtvnXSeY8+15GyXeAskp7BU2Z65oGhE+HYQ/+aZbcLG8LINfTaBGvOp8Zv4lwRyjsFZRUKd2jP/UydYRHqeUPFryqzP09964q0EpC6s6xV5s+bVSMlYG3eV0xAykXoKRbbhvRc0VoDKMZCrh2SSoV0xW3XEKThm56wA2JosUCZ6UsCKoJ9iX/xEH+578QXITzCJuxLNxAUpIBjjd4DGwz49iWDuSvQMSjyDx5iJnI6W5v7bcSdxu3lRBo8/SbarJwEQmI8z2RFyXRfQHuKUz6A10V0QO8x+RD6GQyVJSJB0efpEYkeTM0DIiDEjDSrMWo7kg4eDtDrFpOm/Iy6AKnzZCW64yHVTtZEzPgvde0h8zxRWdL6rXgdQXrcVWjaCFOyLx7OeYuQxdUE7h1zuy4u9atLQifz9yWojVAFE9md+WJoktfhomvcqrtv5g== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(23010399003)(36860700016)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PxBbCEyFl0jHfF9jdiWkKjGhUiOPzl7PeXx43z7grxBl907MKY6GeHMangTlxF18B7J0vapWqIDyca3P2Lrt+mfPexEkBwE4JeuYIwhuoQOTm4lF4bZ6yLcilILPfenSqKF8q8pLBZJB6i8s2omH7JCRveKR90YJ+JInwFJnyHKGEVobvi2limAHKzc5VQSugnIFkAjTPy8JNtGgLmy0xRM49HuAwUIEFxhp/9qLalpuKUXQ3/tXURgjh8qYe6CAl7hHzi64nufCVk4MrmjkQMh2/FBDp+Qn/TjTcFivpOmLioJSBcpvBPViFrghYRKPw8reeM7qiOR6qINSoRYg57nJOGjO1f4cVNtRy3ltmhMQXlFnNeJ6H6VrpU0cAMuD5pYNsYLigZigStWUmMwvWyx2OeDbjcIo7Wy3aJOMHS6Ut0TxQSmRNYzhyme29eXW X-Exchange-RoutingPolicyChecked: 2e83j+k5urEQT3I2XI2WZWUT1pSCTX0RFACKYID6LmVXmyQniFKhVuXcDhaeqFdJp5XZkvzYU7hOaKweQLrgu9MBVjiQGB33NuItzSXEu/LAdeHZ652h4LYAL8wEfptnK5idsmuShxOwR4t2dzodJRA0BvL7ulq4/1ZwUvCoamoezn7ilXlaDWtLHAcx3/ULgbrTFXAxHoDQLflIHxnZzZpdDso1cPuLzFYbc2y+xAbi5XiBc/WH4xmdg8+wNz3aDcdMnp2a+WxqHs6Lf4mic7c8fFV200Cd07oHdd3b0h4fQJZQpDc9w2Fr+8nOujBqRmhVz/UGUKMePFxJkKaRkA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:41.7627 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 343bf0a5-b50d-426d-098a-08df156ee98e X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6884 X-Proofpoint-GUID: AFeEUbZ17xZ_h1dKoMmiLBzfR1b1bWzy X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX1f0rJ+7dmxNN sgrIxq9Fh0I/P3U9KxSM6SKg/6alKVKYt17/Tw715kTQXHsNOyPJ/jn6jlPYpy7bQMCE48Dh6k3 u3++lJTHekX3zMhe/KUU/Unge9EfGX0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX46MIAz6reu3h lUd+GwjmB3TPKRVXGGlGa0vawC3R0KSmghaRnfrY8PUsjlPNJY9yinwIf6ICeujhgiC4H0aQERC Yc6L74lF5SZ4ybvGzAL3rvdP+agiJDJfaInMOu0GJVPS/g71BAUJ8TwepRMxCmg8cgx2tQe2ZKx yFaQZtvSW25V6p36IUHJDFdVafNtXnQN/S2tlesdJvmSuVQUdD0sWbWI4ufDDqvMLik7KNe5xXk 909N+MF2VE14rBzyLBstbOZ6hiy5fXujgikRwDA+3a0VCiwwi6msrNq+RgSxoRocQxIxGhVj4WI m4zoBPx332jDFtDrx54lJCmsau3ofk7g6Q/LdSNpxWwVrOppWsV/57rsV9/I5oYovE5wzFF0Jgr JUE/uQywRg+vwzmUCqDl7H7Krw9fXckIByVfYYmeXFphkrMiOZqZtqSyHwUINL0l3rA5caZDNQC x/9KTQqpt5gLwxd8Gog== X-Authority-Analysis: v=2.4 cv=cKh1IVeN c=1 sm=1 tr=0 ts=6aad1138 cx=c_pps a=nMxr8a0Y/G08GAkVjTcMpQ==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=T1XiGUNGXxSxoSVzcpQA:9 X-Proofpoint-ORIG-GUID: AFeEUbZ17xZ_h1dKoMmiLBzfR1b1bWzy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" dmaengine_prep_slave_sg() allocates a DMA descriptor which is freed on either successful dmaengine_submit() or on dmaengine_terminate_sync(). The error paths after descriptor allocation was not clearing them, leaving the descriptors orphaned and leaking memory in case of failure. Add terminate calls in dthe_aes_run() to appropriately clean the DMA descriptors. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 65a53fcf80467..10073bbeca113 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -449,6 +449,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (!desc_out) { dev_err(dev_data->dev, "OUT prep_slave_sg() failed\n"); ret =3D -EINVAL; + /* terminate to free the orphaned desc_in descriptor */ + dmaengine_terminate_sync(dev_data->dma_aes_rx); goto aes_prep_err; } =20 --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 277254E4C2E; Fri, 18 Sep 2026 10:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727032; cv=fail; b=RLwS5JK+8E0VNc1WjSPOkdCZf3rFpUDflqrqfbsblU15B9mHagV/Y4eJI/eKCQ+uqeN7f3rMtGm1hiA7PpSnFsuIthgMGuAzJ4DfPamwQd49TXR2K0obNvgqFUU16ts9Xtf207svB7zCgBRnoX4svZTJ82i579khF2ePpO4f0bI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727032; c=relaxed/simple; bh=OuWkyrSAYLpUMGWtwqp0QtAQW2fMadEqcmQ2cP2XYgA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mzRL4IP80z+ozyo1bioKxa2P9lS0HJETJgA7BrdxvhqvveZT99bZh4aDmxKOhRafo2M53Qp9VQrj5Ry9bSvyTwOHvwONoSGEYabz2Wqq4ydlwmHa/MqWYB0Pn2NleiFZUvEtpMMcBshJSvFWB0/WC+qawa8W1JxUchlfcTup7B4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=EDahSSj8; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=sd9if7J9; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="EDahSSj8"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="sd9if7J9" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9dBpt1233793; Fri, 18 Sep 2026 05:23:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tE ug=; b=EDahSSj8EMhL4KaROVt7z5s/FBULZTVSa6jtwfvC3VUMLtuJqH90yKp1z nzqjGhWSPnpueIvRyQKfI81J98CT+Pu+7dzSJAE/YiQf4i/AJ4Vj5vVJUu0NiEYJ CEglxwTeLSsrBcz0C7UpXQ3OWpCL4ccyWoNdGppREdOvpAOGZqqqeH0A1bcS/E0E ZC51OLDb7TeXM7k14Hkh3VWeFNy4MDf2n/JjSrTnuaO60hzYMGf5J5kjLMYtEhcx FeXCAlHMkb+LRN/kwyZSHcmDnvHZc7S0qmu3ffben4vKZ0enfK3PIONHhiwgh/xg moAmWY2JHQgVqJYwfS7/GJ50UzMjQ== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012060.outbound.protection.outlook.com [52.101.53.60]) by m0384305.ppops.net (PPS) with ESMTPS id 4gs2ux07c5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:48 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i3M+vK79Xv9VA1BgPo4UhFEX0VdHpc4rTevQRp7VyelxR5zwTP4oNQLafbliGq95zpS2a7c+7rg6Y2p5WdtyKAG3qzMBxkNCvFQqPfiU3rgaZ+t86t9JfV9BRNMg6Cr4cP8yUgna+5mpvXp9OqgdcAZd8enrHjZKRh8Eshp9ocm/+ZaUfYY0Stmbx8FAcDTz8k38rCAwh4qJJOhwtCOwW1wSQQSfMc525aar5T7Gs+y+tYVCYotEamCQD0B3rx0YkUeO08xKuZFtqgVf4VjEcvKp6/mbJ0jTHqi6doU0eFNRrL6FG6y6FRDVCn15weeaZHRB0TTnE1OHk7U4ynQJBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tEug=; b=wd7aTuBLal1UBhGCCXPtxHtu0cvnFSIkRKIRNp+mTJH3R3qPUsWeTEP9x8/4gI7EoJQS4Cm3vRyaaf9Pb2a0u/WqU+SPYt04EbGqWx0qmjQ954JgTMb1iJJseuCIJXsvkVyKV3bkP5UypnSIXAz+NpWIeHimsl+NNhOdbn79ADTKm/7hG5K/yEgXEzAHlYp3+bdUXo5S5F2qNcPYu/xg9aQL5gVLeXPl1lEGN04bsyl9psu4l2fvNFzPz14cV31yoE1HFFYLWPOyuYu82oPktSSDXHKHC8NYuN9dD+azjrdl33hhOJ22Kszrs0s2XmNx+P/DaCL9n6bW7ZbDvQ9D1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tEug=; b=sd9if7J9dwIZ24V/YrvqeZm9cOeM2PsHO7rOmqt5wDcyqdi2WLTMRcTw1CtbA3nDeKikKRrOQSumOrySR8H4jvAZ3kFAJf2H2DksiGPNk961U90ErSif9V53i/WiUse9ZuOPCyf4izrDFybtDKBcP9mahDRNgEECY1EE9iphdxY= Received: from BN0PR04CA0084.namprd04.prod.outlook.com (2603:10b6:408:ea::29) by MW4PR10MB6418.namprd10.prod.outlook.com (2603:10b6:303:1e8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Fri, 18 Sep 2026 10:23:43 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:408:ea:cafe::67) by BN0PR04CA0084.outlook.office365.com (2603:10b6:408:ea::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 10:23:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:42 +0000 Received: from DLEE209.ent.ti.com (157.170.170.98) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:24 -0500 Received: from DLEE200.ent.ti.com (157.170.170.75) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:24 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE200.ent.ti.com (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:24 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANM6x1534760; Fri, 18 Sep 2026 05:23:23 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 11/15] crypto: ti - Terminate DMA on all error paths in AEAD to clear descriptors Date: Fri, 18 Sep 2026 15:52:41 +0530 Message-ID: <20260918102245.2784000-12-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|MW4PR10MB6418:EE_ X-MS-Office365-Filtering-Correlation-Id: 61115e70-e035-4cd5-c76a-08df156eea49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|36860700016|376014|82310400026|10067099003|22082099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: iyuTbiQ0GO7Orz1KdHoqWEnMfOKt75+gjIYFoYT5ar2a1zsvZ3hDRKo8UvVYXRjXdl1InD5eFaTGqZWst73hcCu5IL2rKK/3UigP8itSQ/uAXInSk3laC+236tQuJHpEc0MJlwOoZOXqj46nDqPsA3AHwkUoOIaZT53oVHEbmue4fwzzUQUyDMHcZ+uEjSuF7Nqpty+Lb5O0VG2N0424p2zMlkJWty1XUTGqcVp/TnxV16WQTAL/nztqopke1iqY7FQ9IGaJL0bIqQgyN46uKDNyKWIE4kOBw7sLukko7TdwQXPBktmFg4TpEX5sXtLFcllca865nP49GQ7oCSQ2k8M3GNuZULdPqJQ9ZyrEzmP7bQYrIcGGu+0lSxZAYcDKvSrzzhdhjcri4WW/e3RVByjf9+AH5FAoPpLBlCEE6J1FoW/wcKZEu1AoSQ//Qpb210nGBEyVJU/V1c4bNsl9GDCZquWkQ9WtX+1mUj6yAa87SrnZAhTq1T9d21U5BOIhzSeA6yAU/+i6cIk8A903PSB1pQRdQH/G10+t97H8xZCA1TklfgxbegJslbK2KmWtB4LUZVOFjySInlDDIVEdLao6GH/WQ+bL2KcJ91gkta0j4URV2IHEbBdxwM31DZi92/DsVdT4w1huyQ6SR1/2PAm3PElFawkp/zgDdbY0mIxCTxnT69V3s9Ia46/3PeijosWRgNLxqxkJrMcDidlY8w== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(36860700016)(376014)(82310400026)(10067099003)(22082099003)(56012099006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YmocAYeQDOoHXfuI1mBpFvFFpZrCh5dYgqkq5GgVpBliWc+OH1dSgXwVF3iqVoBWSatHh7CUlqwFB/LGoVuUSV+0Ct2EZ4DPB5kVD7/PTT1EbkmdbFS2kix4QzyieknpWfnwcZjFBxet26TNTNJpnELc0nEZULiCBY+SpPNRxqg36wkR/OsdizMfxQRPr+M1FHkqE39F9IgqOeTW0ToDashA2+N+jkUTIl+XAmHUnXM/9CdS/n5qbddU01xJzimjAZWB6rOAI8A+iU2h+lcZQJDZ+ojjpmYs3wG+RJ4+EOnzUb5yXAtKVpoXxe50NdijZXvNY+lMRN0xeybgCoBn/qnm8OT9bujEicrMawL3NuiJBLZpdFr9D5ncI5l02MK8m+XF4NT8tbAfP3dDn65ZC4KtOwiyi/CgbwRzDrSWWBMghaUBVsNQckgfp7G+ky0C X-Exchange-RoutingPolicyChecked: CHjOq8T9R+JvPngB2J6p5APr2SWeJ9v5QnrRS7Ti2K6gi4RBc1dZqsPiLX6fdrbQMhhi/DN2O3NwEEpjzKzuOjJMPFCfB7dXF4hHHEP9haT9anbWE0wZDLSWIvEzh/qS+6x0r53g4nt61qS1CLasBLU2w7uqxjAUmQr9c3UJsmUGFeJ4NPrjz6ftJhQMqBUqaKnLCoQdr3uBrzSYDRb4UOfIZH+uGE003YysUI9LFiu4RQkSO41C6AQLfA2EnRPesWrCiqOZvVw7Ax7KCCyEB15bvOdtPrUhNYhdjX1nz/heB1J7alRq8sYSCjBTX/+Ge9nvkl+R8jHuZRpvaOHIcw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:42.9967 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61115e70-e035-4cd5-c76a-08df156eea49 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6418 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX6Mz3f8QYvjq4 1vyj/Oe7zcDF/sOTJrI7XBAzq7R3t5JwxePNo2CDMh+v/6b3cKttqZi8uk6IBKVPg0rVPBQLRqd o20/wGwd76npyCirv3JmYIfqd8uttVSxlTdxU0LRaLOAdaq9bmTj8jPx7uTuYQcW1VEmxKv5Dtc TujzuQhtKHvZyGaRFM9OGgGCw4XyX79XDLlzZglb6MxYSOUgwnIusduq6X1V3J9HK8XBfQd++ET Bxx7tm3ZrHikLFtSJ7ytNflks0cLoZKeZUnwEcT9vf9Ph1UIleFC6AEq4cIXJEIDtGbwv8ulRSW 6CgYKFP4xaGEtq9TA0rP7uhl/gyMQ2qpTiRozrazk/tMWMMay4gR+ghu5TTWQQ3yF7xdRfvPLb+ X23pTi+Yu+G9lDr6H2HzPbireVmaxHHdj4ieVSHQv5DcVI3ey5R24E/NIGu5YuRmaCsKLybbqPz 1jdC3+fmCF1XQ7fVY+w== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX0PO4fk/iRPA+ FWIu1khq1IvzykE1DzYttXPSVj4DlhW+BWp+2RtVKxSJ71p1lGp2WNbnOryemhiu1cMApSyYnSn Vua8If38JWeKGBpoqgZdu3/7Wvb1gng= X-Proofpoint-ORIG-GUID: BJJwQ8NfRcQ-nlEuZoHMRUEao6T8vQgQ X-Proofpoint-GUID: BJJwQ8NfRcQ-nlEuZoHMRUEao6T8vQgQ X-Authority-Analysis: v=2.4 cv=adH0Dhot c=1 sm=1 tr=0 ts=6aad1134 cx=c_pps a=yaJUXpcFNTkE3gTvo4ZtIQ==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=noPYQ3j_lezN9luSq70A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" dmaengine_prep_slave_sg() allocates a DMA descriptor which is freed on either successful dmaengine_submit() or on dmaengine_terminate_sync(). The error paths after descriptor allocation was not clearing them, leaving the descriptors orphaned and leaking memory in case of failure. Add terminate calls in dthe_aead_run() to appropriately clean the DMA descriptors. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 10073bbeca113..a034c1c8f20ed 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -912,6 +912,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) =20 struct device *tx_dev, *rx_dev; struct dma_async_tx_descriptor *desc_in, *desc_out, *desc_aad_out; + bool cleanup_tx_chan =3D false; =20 int ret; int err; @@ -1012,13 +1013,15 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) src_nents =3D sg_nents_for_len(src, cryptlen); if (src_nents < 0) { ret =3D src_nents; - goto aead_dma_prep_aad_err; + cleanup_tx_chan =3D (assoclen !=3D 0); + goto aead_dma_map_src_err; } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); ret =3D -EINVAL; - goto aead_dma_prep_aad_err; + cleanup_tx_chan =3D (assoclen !=3D 0); + goto aead_dma_map_src_err; } =20 /* Prepare DMA descriptors for ciphertext TX */ @@ -1028,6 +1031,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (!desc_out) { dev_err(dev_data->dev, "Ciphertext TX prep_slave_sg() failed\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D (assoclen !=3D 0); goto aead_dma_prep_src_err; } =20 @@ -1036,12 +1040,14 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) dst_nents =3D sg_nents_for_len(dst, cryptlen); if (dst_nents < 0) { ret =3D dst_nents; + cleanup_tx_chan =3D true; goto aead_dma_prep_src_err; } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D true; goto aead_dma_prep_src_err; } } else { @@ -1056,6 +1062,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (!desc_in) { dev_err(dev_data->dev, "Ciphertext RX prep_slave_sg() failed\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D true; goto aead_dma_prep_dst_err; } =20 @@ -1145,6 +1152,10 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) aead_dma_prep_src_err: if (cryptlen !=3D 0) dma_unmap_sg(tx_dev, src, src_nents, src_dir); +aead_dma_map_src_err: + /* Free any descriptor prepared on dma_aes_tx but never submitted */ + if (cleanup_tx_chan) + dmaengine_terminate_sync(dev_data->dma_aes_tx); aead_dma_prep_aad_err: if (assoclen !=3D 0) dma_unmap_sg(tx_dev, aad_sg, aad_nents, aad_dir); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63F54E3EF3; Fri, 18 Sep 2026 10:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727029; cv=fail; b=jfhGuH06mMhnaQy4KI4thfDY9lYUYOYK7LtaXyxLfslNRK0sYJpuslej7zFQAM43IKif7DeZ79J+6WOQy7U9fqQL+J0lGYMWEfrTNYyK88zWJtW9QB9MdXmsLP2AsLNjd1KkpIHEV1aU//CmKsQi2cydIlz1kVo0enx8KVRC5D4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727029; c=relaxed/simple; bh=rMIHH7q1HiGvJljbcET80ADog5KoEWbz8PeiVhRv+ks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fvzALaff2bxI1qkPnbdVUGsLXoekZVD76ETZTrWii49J7lzxm8MBPS+UnVq7NRpOEkjQyBcksDFrUiiqzMSRAAwicY+1UqCjJ1/ZsP1MKfZj0QUdhC+MPIgInFsQ86zOFjlcpULF2MGUF+BYBMfesP/DnF3Pj+0pjV38QLdy8cQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=BNAsgrjK; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ZWdOU7z7; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="BNAsgrjK"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZWdOU7z7" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9cRIH3870217; Fri, 18 Sep 2026 05:23:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUr Gk=; b=BNAsgrjKOLhg8xkblT686fE2ERHAxMv7482Mbm+U5ql4Vl6jHuivg2sVR KU8wHqPAjccM35p7CpyG1bCbj+e+ja502LjOfva4eWwSGWxAyHjo3tCDgE1sAvBC Ffw/WQcGrDVjCpzSxd8kmCDjbqCRTmxcS7iDr/uL3Kw/Q1RuWkzcoMRaMqutqJi+ RY+qfky/zum1cltjwt8jppxHBQDuAfWwliqXvCNgi7n3SwMf/0AC6o9/seGurffP tqujFX2ypsX1RtZHjPgPI4f3Gj4bKVVODsIR3FY8XnueWKyYEcn0YWGPO4NLYnq6 3ypo7V36BO5ByrTBr+agET2VQUDOQ== Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11010063.outbound.protection.outlook.com [40.93.198.63]) by m0380145.ppops.net (PPS) with ESMTPS id 4grx6d9yn4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:23:44 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MPO+439+AAzI+2HwuW96vzSNy8DENaJpTFb8upNwTfC88QzKWq59DtERxvbC5YwCTFsMMLQZz/G8+xAeZ812T/uCscdHDJgjHByMPppC5Z3oM/5Z4PnfHa7GKSU5AwNUjL/l4IcGL6xjViR+YvutCdJaXmRpQLyj632sBdKvaO04CqCf9IrAb6mhu0NYiVWahQLxSSOvkVDNP8zQ0KiKnRlGNHg2zC6PT22i1ddZMfvuVm/imUzyoKBd3D9sLxyaBqiDAwvzybxYIlA5RAQn/Q2Q5v1lfQGrI4Ncv8fBZLnvoqnjqStABjegEsStRzgjd/Q2FFf/lYhCujaUL3rBtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUrGk=; b=iJTKmoXWkfYHh8QKJVultIUwyEIVsEytUXNkEMtTCEsVAS1aNLg6RjMEU3TsilEwqPwYJPKYKaB5ItpHz/qk5lvUDGev9I1G5wu9ZpUrGMjWfxGs0peDmm2yeInPYDOXNWvvcjXu3FsD6s6MJDkVgzgu9/LZa0GuF2AA4qc7K204yO3XgqIu6s8kYSedh11B7Z7b0ptJA1zjPXQhWdqtnyH3CDYXk6VDsEmFilAsd0b5WM9awKZtSlaz533Hp8N6Xdn/9IXgrQ98zMdcc530sZoQJr9TFUGBR57NxsfpmNnO/+nejDfcO+xqEU4ANq7JQz6tv9Hi7mpcXjJF5bonUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUrGk=; b=ZWdOU7z7kDZj6P5+K2XR0oveNjcjzrfHxG2vgLWyWCr5I+lFJv86ZB+oNfW82X81o+azx/7bkyCa6aY3bs4H35VP8KMGHpi19N5hle7snCgMQMBj1u9ZjY8Sc6lb4tfiO5WPtOjlqrxi1lBgqa5bddJCNtkWkigDgzZFJeKpTe0= Received: from BN9PR03CA0928.namprd03.prod.outlook.com (2603:10b6:408:107::33) by IA0PR10MB7384.namprd10.prod.outlook.com (2603:10b6:208:43d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:23:42 +0000 Received: from LV8PEPF00000059.namprd02.prod.outlook.com (2603:10b6:408:107:cafe::1e) by BN9PR03CA0928.outlook.office365.com (2603:10b6:408:107::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Fri, 18 Sep 2026 10:23:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000059.mail.protection.outlook.com (10.167.245.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:42 +0000 Received: from DLEE207.ent.ti.com (157.170.170.95) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:26 -0500 Received: from DLEE203.ent.ti.com (157.170.170.78) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:26 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE203.ent.ti.com (157.170.170.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:26 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANP721534811; Fri, 18 Sep 2026 05:23:25 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 12/15] crypto: ti - Do AEAD software fallback on only ENOMEM Date: Fri, 18 Sep 2026 15:52:42 +0530 Message-ID: <20260918102245.2784000-13-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000059:EE_|IA0PR10MB7384:EE_ X-MS-Office365-Filtering-Correlation-Id: a2a33cc9-c456-41ae-957e-08df156ee9db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|1800799024|36860700016|18002099003|56012099006|10067099003|22082099003; X-Microsoft-Antispam-Message-Info: 1/7/fxNLWadLGmthcYd0CfyNXMxo+OMZHweuEc6Gk5cm0FyQ7CrkCVgYTUpcrm543ZtPoNCAJBpCozj1LdFVzqAuoHkT9YsJfYBcU/W7ADTQLOhD0VyCa6Yuzpf7JVagJq87p9E/cJphXSXXeqOqwidtkrfW+9eqpDT67ynzxrXQLwQo8N2NU0GUtAg1Ig37rIC9RFgAgnfzrNG5icBkXa6PIlWETQmkKjhy3dX0bwgeEHcSFNatBkIQemri9Fsh+HhO5k8/Qwt4z9QNeOaEvtZmGehfF+mGxlEwSChJKbt9Wv+3gBzmAMAoFid5FGsfpHUVR0UD5kzQ6LjuEzg/xVaAQrtrmtMtxGK1afzpRO0f6v5P0vYA9ag61XiAE1dgOgCeC1FfHze65Dg+Jw6P/R9y/YJYUD1/JwQSlUo3Ou1IzwJ+a2aOy/6dOn27Av5sFQbYSyZZBJSNRbl+gZVktU0Fm0OyLMdvu9dE9IKrNkMVP3F7boGpSGuamrb1pIqf4kYJXcJBlQreTN3mtuSbqwmDk6Jt6CrTkMuCY/YfM80glI7re4UvbOdoVRaIoLSKHrCy/d28qGEbLvsCvhJP/YbbqzqPFMg2Y8kQELwbeTx/4VQsVaO+MXVC7zdVUgd7OkqtQA0r4jhyemejYVNtnZBWXGPiAKrHOCcPzgbT0TPPBMhSTXFcyqsox3bUZXXRPug4YeHt09Y4QFHMn0LDCQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(1800799024)(36860700016)(18002099003)(56012099006)(10067099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rmWNqRs8ZZwwsn5LM2SqkRQefUht44vx91QAQESb0dP5Mxq56ExotZFUsRJ9CkzS6xvaijVvMQB0QUT2acmIHdyJgoyAmk6iz6RQD/wO5tUCK972tqiE4SVUJFuLuHBBziX7eIgscno5S7kfqDdnTdWxBw51URAZFAtgoO89jQtzcKQKuZtIx0dI2YltRJevJ1JdqP615UjwNoLnRe1QEZ38P93MloWydNs95L9V9r2uznOyv9KuyyQ+U7vIbwrUTdNVt1Bv0+V74+bNoEYu5fLMJi6Y4vN/MU8LTSRx4k8qSMNASsqO1XCy8osLKrWVR0U1dzkL21Lz1F52BVQ6a+Q9qWONdSlW3xEGQ4aRgzQC3thAVfx6Ei31EZzAXQE4Or1d0YTLyf2HD0lVgNPyERqzLxg/zUPN1DEPfpnOoCAUnKoQo4j1WAl4xxTYAOSh X-Exchange-RoutingPolicyChecked: lYDukkgbPtOVhWbfkWo2/tKa/YlgK12rLuW7wsH/JYbrQjsLxdgSRzlw1d48tNwhClOisIufccrrIUtUPgfsytoYOBgJIAlVl5JJd2lGbaGgyTfOjlqzg8hURo7KN0VJqhmJ1c1Bp3YdT1fLXTH73rAnFyoG+q9CnmhzhEaK/Cu5x5h8qt9qBSe1Fz5VzetgZmWrpN5GlOh3AEjdh3Yqg+yIGC8OWPVwbK1rn13mo4wpf0sKstBkUEF2kA6UkMg7rR65DyeEg1FolX+s/gGAYrQmMh59CnMdKXCQA9/2b8kiqqxmTK7b3oke2O6SZBo9L+XEFgGOjJiNmQjlDFT8pA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:42.2809 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2a33cc9-c456-41ae-957e-08df156ee9db X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000059.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7384 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX2CusMF+uepnE ePWa7vUfXu3ZfSh0HjtaSUE7a0SI27+trkQd4BeF1UOAmFfCH6Dhx7S1mucfkvmFN19VSJk86eM wBZ7UyhSoJ0J++0pbiSY867VVxEnTOI= X-Authority-Analysis: v=2.4 cv=Cswq4X4D c=1 sm=1 tr=0 ts=6aad1130 cx=c_pps a=nBoeifw3k4y6eW1CqgP3Vw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=4oUWx8CZaJwu3DmIChQA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX219uUjLNW+En lbAyipQPfoDMzbzSC2cjdyDug8r2OG9xazb3BtVGDKLRHBXho6XyFFy5arkigohjwAi6Yz/fl/h Y/9Tq+Xso+Lq6l38vsbN7TR1V/Xxm0MbkS1fJig7NlGnJO2HsgeooIF0JjWMeBYK1sqUqC0zv4s eBqGyXYxwruJ80GAMyjmaiFS6J/JJSlsWHVXPFjmgL82bkbY/TExkKmqnq15bsBleHwD28bI/OQ pEEyy8fPfQ1NwCileRU+k7RADa6qWYpiHbb9H0ed1TTUwDp/USfNjIPgh4Dnal/GVmcfQ260LeY byA4rYTzLmcCYBCnP71G7KP9zcz06N5lncdOAZl3+6AGdIPLTvvLkXZ1jbH8P/DsXSVHvmJLfj9 4Qyx/Wfe3KzSry9XbnvTwuzhAO1n3R891k6VMspJxbt2leQr9VbygbCcLmFGLiR6eretwepp3t2 IOAbddEbzkTEts5ggPg== X-Proofpoint-ORIG-GUID: 9Hy3pqMXI8MVVsNVG2_fb3GOM13WjKLU X-Proofpoint-GUID: 9Hy3pqMXI8MVVsNVG2_fb3GOM13WjKLU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Similarly in how AES part of this driver, we are falling back to software when memory allocation fails (we get -ENOMEM), fix the AEAD part also to only do fallback when we fail only due to -ENOMEM. This is because we are doing memory allocations with GFP_ATOMIC in the beginning which might fail. Any other failure paths might have modified the data or buffers already. Doing a software fallback on them might give incorrect or corrupt results. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index a034c1c8f20ed..150ce65f613fa 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -1173,7 +1173,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) aead_prep_aad_err: memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE); =20 - if (ret) + if (ret =3D=3D -ENOMEM) ret =3D dthe_aead_do_fallback(req); =20 local_bh_disable(); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E53D4E73D4; Fri, 18 Sep 2026 10:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727054; cv=fail; b=rrLPzhO3QNpF6Ik1GOO2kQxYaq6Ca58Ipz1y77QW83TakcrFcHncPggtw3zVx1wFO6kpOPhJbESj1oFJKgBpRpe+qetAB2eyAzdr1QOLku7Te2XDce5Jf0ZD726E6g2dzJTllTyqudF0L3oVHjEJCTd1FfHUZoNd0AD5tVGMzeY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727054; c=relaxed/simple; bh=ysoPploXnsuJRmYnZ19/V+M8zWYzeuUXCUMX2vd/iFI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QG1vlPkeNyLXxfKjENZP8Vey23YEj7LKDlSdx83qTYghU3BKp3kTlMsNpPbhoKaZ18z+DbwXccCJWVWLsmw0QqbXozT7yKDZIxX1gAGIehZ47UhNQxw6mgmw+cC36CeT6FrYnB7bZ0KLZqZClTq9W7z39B5lsY2GE7iDyoegzL4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=MVvlTN3L; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Rtuwu6OT; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="MVvlTN3L"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Rtuwu6OT" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9eKiN3768408; Fri, 18 Sep 2026 05:24:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=IioPKfS4scmDQFvt8IjnJCzYXdhpHsv53wGTOOthe AI=; b=MVvlTN3Lgeg4XQZODyuPGLOsM6VWDRoIMTLHFzNx5/gdR5mwG4LW4yLHI kEK8jlHGvAgLYeGVq33MqQhbULpx3cQxU7FEnGncgrSS0NoYSCVihLZYv0iX7EYq aZ2NoVr63aOmPS35Qp33wSfpfyUbpVTn8Zw/yTdbvmoPfF+eZ/+ZGXvcZyzlrjsG 8Gwsx+ekGmOk7xdHkqg5zbecWRsIX9zLrdolVd8pfXA4qgSuBiALCeO+c6m3RmEU ECuBlaYpDFx3/N+yXqWsYs3mybVOUVTFp2Wtap4QhVlMubLPVElAphuaxSEBKkJh QMGemzF90oTZS7q/Pr5/UWdNIdRgw== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11011050.outbound.protection.outlook.com [40.107.208.50]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs16cgsq0-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:24:09 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pIhPF4mkBb43sHNPLjcalnDqisx782jR7a/8LHN2vWfiZ2NSZLUM79F1GXb7H/jS/XccBU7hHf2pVTiCWdKr2x+ZTBO5hTvOCV9eGC8Zz18hh+jmcsjZVNP40Dar39gCbi8jEecE9Hp8BIEksIa1qS7SUMQPXIryJnT7MxkxJbF6/fxQkvZnM7FuTqZbW/d1FXZ7fLYPtlb+NnED3vtpw4MIV/l6dUBXbWycPhPVikz9WLW8TmyfFnl9Rl2EUIgJXmRSfjiZ7ertdcVuA1o5DwX8mRhcVmSKrWo3hqwC6Z9lmjVAtP1xkxaLTXBY0mO/LHUk3kbOkH0GcC+CY3Uymw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IioPKfS4scmDQFvt8IjnJCzYXdhpHsv53wGTOOtheAI=; b=kXXK9YYFheKzfPE/hHiW1WuQp8an5h9iRf4fTsBzeMi+pDgxwBX5Y227vCsqf7ul5ipFtKgmV2PLz2/bUvWxSLQfR9zw4sRqgOejkysRXWiFk1s4MDLMrY8vKOoRPdDn6XnFyu+2OwZ9dQPyZF2YtSW5Y1AAMgQyHdljoAhra323fBx0P6MGcrUle278M7ntxlMKFXNfZYOoO2k+NN67Dno6mgGtLvhzvLLvW2V2fT1e1cJaf8HfIQ8u8d3oTsswKOK8nRWypxIm2kCqJjYbwILvWBId669A1MreADv0E+58gNBQX+eMA9KaCBdilRsGi2rONCLxBB0zX46LOaLO2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IioPKfS4scmDQFvt8IjnJCzYXdhpHsv53wGTOOtheAI=; b=Rtuwu6OTV/Qpj/8V3qxvtKATx4e5kGe6rjsElN3fRM2hrFlL8qJVhLxkaWxWGYmQ1sel+8XNKaQp5CMri3KnFDzEuKPflCcYHH4N1B0KXHd92H4Ktd3YyNyyWmwOUiR9eYnfMapCwQfxNXe9vMVW1/wi24oalI5AQ9F+1dVBhkA= Received: from PH7P220CA0015.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::20) by DS4PPFA0EC85B6E.namprd10.prod.outlook.com (2603:10b6:f:fc00::d3b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:24:05 +0000 Received: from SA2PEPF00003F63.namprd04.prod.outlook.com (2603:10b6:510:326:cafe::55) by PH7P220CA0015.outlook.office365.com (2603:10b6:510:326::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.12 via Frontend Transport; Fri, 18 Sep 2026 10:24:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by SA2PEPF00003F63.mail.protection.outlook.com (10.167.248.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:24:03 +0000 Received: from DFLE205.ent.ti.com (10.64.6.63) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:29 -0500 Received: from DFLE202.ent.ti.com (10.64.6.60) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:28 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:28 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANRrE600734; Fri, 18 Sep 2026 05:23:28 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 13/15] crypto: ti - Correct AEAD tag operations against dma cache invalidation Date: Fri, 18 Sep 2026 15:52:43 +0530 Message-ID: <20260918102245.2784000-14-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F63:EE_|DS4PPFA0EC85B6E:EE_ X-MS-Office365-Filtering-Correlation-Id: df5f47f3-fdfd-4e04-d5be-08df156ef6a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|36860700016|82310400026|22082099003|18002099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: P0T7jG9BWbXi2JA5ybtD05q59+hQr8RC2zES5xctpC2j1skSIzaRy3eCIbWVFKH2rZcrlgPKT0tUj0IsGgBGgB0AciAACnzPjE95fzfCSgsSwiGQnlIKylo1q/xItlkIfof3mFI1e5M7MBhwhfUe2sDdOqHrUa7JyNnYMrQpZgNgfbuXMGoiz+6jMzQIt4p1CGJztC+FUaQG4oXtf5BZiFc6hAMJTaDj3NqrB9fvI5rvmRabfQZRHeRA7azqBqfgTYhkLdvkbJYqRivTuDoDfK3PDYulvvBM9fdTdlCSl2kL3RxkyB6ON/3EjSOilGSBsWFbSPjTqnfasUCnnIvS4ZHK0q5UugjTVV++XFLVsJ0Y4/BLLPnzlDNX/zWKTllGIS2EcgfMqz9eQMpW/umjIW0rSvVVgI/Na+SskBw3B2XhzG0X9TjG232qglODls/QQ4iMelx23jvcT5ds5qibAxmqJfWgALd62oPMLSHC39/+pGbx3foh5R8WNVtwFsTPIBVkF18alP3tXLE5W2RHqUWCX4kUQ9xMVlOHnbIkbsdZ7TAsHj2SPnmvmwq9V2ACdQ0bJ4KqVrmuqatw9AoIpv6xNnOxGaPQV9VWKwDYDMkz0okFy7w6E3BJHd+hU7KNwNc4A0o5uZr0OdG0589kDoXu89ia2/Ox0WUSNSS9pCYd3ptfJfK0TbBG0MB9NEktp94d5uk2CoQwu4ZX0ilGyA== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(36860700016)(82310400026)(22082099003)(18002099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OFrsdeEZPK08kmJC47+YSY97Q/1j1tnhcNKNQSariGQuKPAm300Vg0Gj77jXA1fLYY8p18FiepOWSp9mxFWKYWyCfiYnLvJjDg0BeXMbFcaAYG1+iX/KT6gRn9ImxdBBc6/lBolLi7dbujNMQHdcKsPXR+TkAEPMT/5flRurdbQOiEoTgNNH12tbdd0QiH/SHDztT4R9B4ULWiAR+B3Yhb/9uR7N7sAGJr84owmCt5pwXKyoVKQjJp33YVEPWeZSqsfCjyzS7DTMRkxXHxjLEAL0hI7QG+zxKyo6Mvq7jLKLImmEIhHn4ywzvbAKaMnI/CpH3Ib+KseA4DDvCSNiK9gLyd+A4wBt54NLK8ShJachS88R8nemTDENAOfavrZOprZmAgvn++btKHlUcPRjJJbc83lzPxNI/twHn3rFimHiO/TrIDYPtTxJrIZCJ1YS X-Exchange-RoutingPolicyChecked: KsVdR9UV9L86Zv78XBO1UClPE8XzKtOdkxIMU7uxEUTfa6OOX57XI7reMsYpzTlulfIN6C+a/v4gjKd9DpjScKFQe7IINeunOI1i2ePovS/5669MH7/lM1nBC59+5OBbzH4XqpwoRgVhYDJMygEs7GMVgCP9tFneLkoqXb6xBF1ZQpqh7nZjHnqm8H4qXYePgHFne1f9xMmw+iGRqjs44OWRHiax79Q95Um4YoJJ5W/6GDJmcthCKhRKtCUYe+XLTjbolVWMy4KajyLat6uX3x0JrvTRUR2HKuca80kWaXYrzD63INICp9xnsTlMEMUMUoCTYaxPeG2vYPQ5JEdBdA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:24:03.8167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df5f47f3-fdfd-4e04-d5be-08df156ef6a4 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPFA0EC85B6E X-Proofpoint-GUID: NcFMqTXNathCJvAAd5ahgIG99ysNHRa3 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX8DFYDACklLTp 4XWQLwEeeWEBl/ivb7CdhPYk4uBnFp8ZTsMgaidM5XdoMA5BlqkgH697P4ZlQBxgxxjoszpE8Lh dL/yF5a7P8w67tB/4LikFOhGVUMJWhg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX6VuXPZj6bCzy ocTnBbu/Wp/L3IfHtaRehFOTcWB6g+Wb/ErppcXoly2EUMqihqIaisVQxDSe7TqLT4LvP5gkFZP UIZ9tmUC3XTxGnvJuOT6u5l73m+96akz48eHo3k24+LhY8n2MxbBkzj0rJ2s/WWIHAYObfN9pDB /zTEOe4ZGcPpbL8WdTw/CA2g9Anrh7EahdsVz8LbCTfoQh4qyBfC0tKtaFz381ZKBKVUqMdyUxu twmH0od9bswT8furq1MuaaDcYkm+QYNIUgtWTw2ev5FZnJqzSjoHqh5ZNnzTgrta6vGnsq3jUQR aH5e0r/zKvfa5ZhrE/hjwwXRCisOuLx7uAVnSi4xHtANO2hbdE5UZInImsLHlo5tWHbYXDKxQCy hpyjWtXOF79DVcuSpg8M3PBLaLxTZd147vm8fAnsY9e07lHrd459mOQiWQYwMFsRDkiA1otdaAB zNU01kG7cuvuLciJ0LA== X-Authority-Analysis: v=2.4 cv=cKh1IVeN c=1 sm=1 tr=0 ts=6aad1149 cx=c_pps a=v7DXidBSvHT+GL4JoI7fUQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=BSBB0G2mMgAadyb2BJkA:9 X-Proofpoint-ORIG-GUID: NcFMqTXNathCJvAAd5ahgIG99ysNHRa3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" There are two issues wrt tag operations (tag read/write in AEAD algorithms) pointed out by Sashiko: 1. dma_sync_sg_for_cpu() before tag operations always uses rx_dev. But dst is mapped with tx_dev in case of inline operations. This is "technically" a no-issue right now as both devices use different channels from the same dma device. But it is nice to be correct. 2. dma_unmap_sg() is being called after tag operations. But between them, there is no synchronisation step. So tag operations writing TAG into the dst scatterlist could in theory be lost in the cache invalidation done as part of unmapping scatterlists. Now, in the current code, we can correct both of these with some conditional logic and repeating the sync (this time with sync_for_device). However, it felt more elegant to move the TAG operations to occur after all the scatterlists are unmapped. This ensures all buffers are properly synced as well as avoids unnecessary repeated syncing of caches. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 150ce65f613fa..150ba73776aa9 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -913,6 +913,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) struct device *tx_dev, *rx_dev; struct dma_async_tx_descriptor *desc_in, *desc_out, *desc_aad_out; bool cleanup_tx_chan =3D false; + bool do_tag_ops =3D false; =20 int ret; int err; @@ -1136,15 +1137,11 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) ret =3D 0; } =20 - if (cryptlen !=3D 0) - dma_sync_sg_for_cpu(rx_dev, dst, dst_nents, dst_dir); - - if (rctx->enc) - err =3D dthe_aead_enc_get_tag(req); - else - err =3D dthe_aead_dec_verify_tag(req); - - ret =3D (ret) ? ret : err; + /* + * Need to read TAG registers if data is submitted, even in case + * of DMA timeout, to clear the hardware states + */ + do_tag_ops =3D true; =20 aead_dma_prep_dst_err: if (diff_dst && cryptlen !=3D 0) @@ -1160,6 +1157,16 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) if (assoclen !=3D 0) dma_unmap_sg(tx_dev, aad_sg, aad_nents, aad_dir); =20 + /* Do tag ops after scatterlist unmapping syncs caches */ + if (do_tag_ops) { + if (rctx->enc) + err =3D dthe_aead_enc_get_tag(req); + else + err =3D dthe_aead_dec_verify_tag(req); + + ret =3D (ret) ? ret : err; + } + aead_dma_map_aad_err: if (diff_dst && cryptlen !=3D 0) kfree(dst); --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A7F4BD34B; Fri, 18 Sep 2026 10:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727046; cv=fail; b=OIItZ8BpLCI/4IqB5qTP+UKx6sTuSldeWI2YhDNv29mVDiywvXTPap4cLJYdho4Vw9PCQvOl9AnCcuutqwE3he4/6Wz6Vqy5AmHwa6GRRk3o9Y4mxDnQ6AQrQJYznk5jzbVb+Z2iFaJw/pomG48Wpv1ec9NtvFjKPV4G0xtj6q8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727046; c=relaxed/simple; bh=Xj5n2GVqsJvcefGEwXsaxhsOWs63LUfndOX4wp+k6c4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CqK2b0TXcQi/lImX3uHohP+3aK+G/5qc21ezWKxtzlYcD5YNHzHGqMA99rv3x/mB9LgGnnabiSLSME5myXhe+D3vvM4EgswPieWf1r1K0Ou4H2PqPNN1mS+3xra/YNRGfzIyVLEiDiZe7VuNW1a3bEUOgJ79kCj1f17Cb/k2QTA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=KHUEORSI; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Gvq6k5/r; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="KHUEORSI"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Gvq6k5/r" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9dBtK1233790; Fri, 18 Sep 2026 05:24:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=FYCkMb8oUWMLmdB4yXRpk+rbOGGjOkqEpnuQX29Sv MM=; b=KHUEORSIqeZHkrLmP8F5CxzGjRZDG0zRvrCrl0TNcHm6YbLrFFW01UjHA FNJaznpXBiJdhCDhb6mlgqjfk3RdVAlkNagtjBGsGdzIy4mvZF0hBRACiLGEO/KH Y1zJTvDEzUut12mRw63IEilbKilr6JaS/JW7BwDbu4Qb14Od7U4eVEzd777BHsXh lsKyinT0yWIcuFSP3q/hAyANJWwzVAi9EPJOGu4pPhDm00Sz7sW01jmDHDMwVfG8 u41PiqIHq+765nrPdgVS9ejvfG+P8Wsx5+YvHAnD+iF//7yjQGHYHwk7ir/vnoKs u+tDj1OIOQ7xYvZtglYMYwMgqdyqQ== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013068.outbound.protection.outlook.com [40.93.201.68]) by m0384305.ppops.net (PPS) with ESMTPS id 4gs2ux07dn-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:24:02 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ehyCJWlZP4VdgZu8Eml3e4es4cIWaAImv3dopv3GxiBj2FIt3tyKdqtao4llMcA8brB6K6FmM/dbohYe9JecBPIjcCsFfOC2kEHmoZQNTe59ldTcv4r2jmkm3VWQqasalTHw+zn91qC6ch25bbFEKQR6h2VE+Uos9wmYiKIPWB/sMuvblpimiuY5bkBss+uN1PAzJicSbcaVVeUO6/8hPkI1bwlm37HSjucHFcnMJVz2+2SX9DiPi87TsrIMo1Dsla6ezVpuHZvObIu2LG3vc4Jt7ZD+OAy5Oism/seQXqWDR0Rxi4SQY48ooKNY9G5+kixooK7cFc4XrjK4Jc9nKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FYCkMb8oUWMLmdB4yXRpk+rbOGGjOkqEpnuQX29SvMM=; b=cy0W5a5L06FOsaQvQkEUkf6T6dVLo3EpGyStfZdhkOP0+JBGQ8vzxXbbVJ0vzQaG7235FpkTbJsdzoHkEGffz3YYUakPTBm4ZMgaPVL8h3QjHx+PWXSrJ77YwA94ZhQveOpgOZy+DydPv+dIKjDRM7tbyUAlkOSVt3DsPaNYEs5Oy3a0t1rjqLoatN/6f1nO/OWXEX41bOU2rrIbNy5Si4vbK14BBbPwBtboWqjkQY3hFwfItC7X/knDGxt6YAlt1xiu17CA5/4CWOE6YJoFUskUSlWlffvGdyX+j5h9+B+CUGNjGil6i1EenTuBjtWlu9RpH3ZGs11eZTE0zk+55Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FYCkMb8oUWMLmdB4yXRpk+rbOGGjOkqEpnuQX29SvMM=; b=Gvq6k5/rMngTyqcaCURQDOBJY5LMHfG/paKtaS9V4yKharVWEuCJqHjsyfe5WpdRbUwKq+11+1TrMoRQSNPA+y4vGVvlFEq147J3lB+qEqZfWPbaxMDIt8Bbc6wipuxwToMM+hvU/1AB/cvs0Kv+kCYwYQVeyKKtbUFMETKgKGk= Received: from BN1PR13CA0019.namprd13.prod.outlook.com (2603:10b6:408:e2::24) by DS0PR10MB8152.namprd10.prod.outlook.com (2603:10b6:8:1fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Fri, 18 Sep 2026 10:23:59 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:408:e2:cafe::48) by BN1PR13CA0019.outlook.office365.com (2603:10b6:408:e2::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.451.9 via Frontend Transport; Fri, 18 Sep 2026 10:23:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:23:59 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:31 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:31 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:30 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANTbV600779; Fri, 18 Sep 2026 05:23:30 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 14/15] crypto: ti - Change lengths in AES to u64 to avoid potential overflows Date: Fri, 18 Sep 2026 15:52:44 +0530 Message-ID: <20260918102245.2784000-15-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|DS0PR10MB8152:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ec06f7f-2555-4454-5f6a-08df156ef3d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|82310400026|36860700016|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: lKCqRAGFY5CcP/21HOC6dl3zF/GGbozRs6NdGHU6bsBJKUwpKM0sn+879KJqS1QvFHEvLUK5KrcFA8sxZwT/64NwTuGZoh8XknJ2+r2nzgkoo8TnlYgzkCkhx1XQujAhlMXwBXtEG3wH6i8gAdBKnM04QtSRKYs+pbGRpoaLiu2gr6xYMyYxInPdqh2K8KtjoEICv1OlQZQUdkZh3xufpOulsLX19P4Yyhp5cC945a4dbYfwVCDQxoyVRYcfUmC6ZeE0VkWsDWg59IJxPXpBfZNMybXqVTlaPWJDXCKNIZ4vsMWQiRZg1oU6G9RtoevsD6YolWA8nQxJE1P7Doubp0Pginn38bTbO3t0pgpKlEfoGNtnrA5B6lVUFIrkS8feudwiz+ePWqMO69EpD9tmaXyryt42BGhmAsw0Q38RhDftNuLiYv0TauoZllpAdefUERdvPoq05WMzkEc3VwQf7Fc1Xn7R9cSwjkkFugyjWmiZ3cW5M2o/BRCeiaA1vUgPpgEzFDffXxPZfDNoQ8Xt7eqqrafKry6Um+lvXYTbXmJ5DPhKQs2CzA34poHgfBWGGzDMtau79cC+CFF/zN9U+91GG+1LkDa5FbjxHzSvzFp4xIZl3OFXYGFJqP7BXLiu9PJNYSrTDgbYlMNnY1yXRQEpGDfMztdjWjtvt3HQ7S+6Lz2pTa6Qf+2aVX7BI14tCfAPWk0ZebpC+7XoNGNRLg== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(82310400026)(36860700016)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QJNHiKrx6GzO2Dgp7KjxYzL0rkJ9g38DJF4QtEi1OS3eF7VBjVsgcU6Cp5ywS0A0t0ZqAcPKjIlIyr70es4DFYUsmE6nGSTK2Wh/0ifQrNxAKKyUgUS70GJJcwYkJyMvPIJwSRMlUpOOi51ZMTWYVkZ1gGe2M43IbXWxyd5+l79qbKuuCEgNchX+IW8hU/MbF9Mxg8pMaXyITvaMYHV9FVL4Dni086zx05Gq51q5SI5yC8OgUWcU7awfoMRep1mJDqwpR3vn0K8t1SzQgFG+Ov8ksAqOqKli0H5kSVsBWuyzmJ3R06l8uwOX5pIT/SfIgGM1YFOVImgG71nbcyp0uj9AA5cVaUqy4V5JJNUEINC46wC3DnZ+fqAWUXh7IiGyYxKN0BDO80+V9c+F/HlPLJStRweStURc59P4WUZXP63Tb52j8hYNxYIPGCa34k8c X-Exchange-RoutingPolicyChecked: CUrehhgL0lbB9DZEGErXngDorMcCjPlOTQSAlaqGVUUyZZIUxfTPiY5zqPa1Ltv2NZeAHOheAIjCg/AzHuCUXrabr5hUSg4XQOmKgrag9iaX43pKUyVEv8FspZogzeoFnG6suEvGNIqDB52nwGZZdml9iQlX7ELjOWtsdw1gL4csY6xioA6tWVMMOpD2VI53YrxbOGFPl2is2vKITMT1h3NGcEkWnyGeoJp3dGqFGn6uN1tlQeCirb5R6/g0HABk/bOr2CFzaoXoNiBppTY03rHWBFY0KAV1Avx7wAhuqfvXvzel/WUwreweIP71bxXsL5J2+F5I4+FbNlg4h+JYDA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:23:59.0431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ec06f7f-2555-4454-5f6a-08df156ef3d9 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8152 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX74VcJ8OUzUeT eZHv0PbfszF6MZlveMtmrH81aVssxWjYkALF9sWvxCXw3lOsWUgmlR6faQLSMP4A1Ms3WGXxXVR N7Qgx46PXpdlhEkvZU4OBiUX7aL6O8VaJyYESpcY7Tps0ucgceu9swBTJ2HSOb+27+OB9QMpQ+I C4gmjdapjcvFWWMFYH+B94+HYUNhWjH6YUvNAZ+8ev35EhkEwNfBk9haq1p8ZsJf1aqpcpiv4BB rR7l0jrlQNFYJlXRG+LPSzhQyvjpZfJcrdpEgovkX8gM8ClstGprKuhsz88rVt7YHbH7W+Fbp2I G90I+UtY8ztSUb7SJHDwFTkkuUJosyq+fEpP9j6p4kDFbXCVQh3971l85pN6WTENPEzyG8jqp2g TqmbMduKrkDojN1Bk7gf+83raw+mCPXjoj//KCYVY46zHmPCkxtgpT7nQD4cSxM1tHtoboHAAal AWVbayPJ41RvlCSyhhQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfXxT4dLxEwTLBq MJOEMndizUOkkre+7CyCfFAbrS1eZlRYsE9qJvpz1QQOUQs/IsBoGhQ8UkneO32i90SCaop796/ xkOOe+VW5xSDPdf/A2pcTV74AkFMijw= X-Proofpoint-ORIG-GUID: H_KzZibGTw7FKfGtcrCKAegTIPHpBQeb X-Proofpoint-GUID: H_KzZibGTw7FKfGtcrCKAegTIPHpBQeb X-Authority-Analysis: v=2.4 cv=adH0Dhot c=1 sm=1 tr=0 ts=6aad1142 cx=c_pps a=THEAVZb93WkyejmpPpFvRg==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=sQKIhDeqCqRtbGPzpkwA:9 a=zZCYzV9kfG8A:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Change cryptlen from unsigned int to u64 to avoid overflow when added in padding length calculation. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 150ba73776aa9..9b982ca4a7730 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -326,8 +326,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); struct dthe_data *dev_data =3D rctx->dev_data; =20 - unsigned int len =3D req->cryptlen; - unsigned int pad_len =3D 0; + u64 len =3D req->cryptlen; + u64 pad_len =3D 0; struct scatterlist *src =3D req->src; struct scatterlist *dst =3D req->dst; struct scatterlist *sg; --=20 2.34.1 From nobody Fri Sep 25 00:40:51 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2F664E9C26; Fri, 18 Sep 2026 10:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727060; cv=fail; b=ba7quAmK4UNMWvQZsNSV21NtWVmMGPrE3L7usZCiyf5fUUWndUf9Me5Uy9fOzzlSlVBMik6i/Au2c3nuxIh3sQlJWVlz3JcfZ+PEH5hKoSCF4pQ7yO5pXYQEXEsEA3Kzklp+2b9telH/MTF0TD1LjDth5ChWTOCCuullB1bNwQ0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789727060; c=relaxed/simple; bh=MmcuVvXYaMjero/AwfUHOm7TRDKEXBVAlucY5yNCKhc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rXbBKikm2+nckecjyoeOUmy7cdcGFEVV+rB+jaNnyJLCJGNNy0taNd099gTpFSHsRlPS4N1D8Nn9NuJxe7IgdD/Qm0efmKCAQL5yxbc7N/eA1hrCsGvJpRGPMdsgzpNUUTclhIQQGxCUwBaY3WHzMtWdyCs+7GM2CAeDg2+I78Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=mTkR5O1h; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=L9yQaHRc; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="mTkR5O1h"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="L9yQaHRc" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68I9d91s1233779; Fri, 18 Sep 2026 05:24:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=PqnJREAsaDSaK59bXYGlEMRqdohLFwctOvTZ9KWYh A0=; b=mTkR5O1hMesHaOydy6oBhv7fVTJWgn2AWLIxVj5W6xg45Tt21HPqegz3U mp00rXuu9ClFvJmuCm9N4q3hcyw0uwQq6YpOFeCK43Y9f6iAQZcBKhg4XD23tcah d/FgHBNuMIJuTUpeQ7MX9TtFhKPKiPhdc4Nhk6VsycggpZaYYM5v8Gkr7oOvNQnf QUD1eYfDFLK2MLrGbkx0LxhfsF5PLoiQfD+AhMBb7rkfQysoacgv7d+VKcItjATk ktwpPCZSlAFQ9NQkRBOfIEQk6EoBcwtdgJ2OxmBVpK6IxsLJP7mcGDcR55TUGMuL UYqOb6LkMmd0c9nGotgWyRanWdM1Q== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012025.outbound.protection.outlook.com [52.101.53.25]) by m0384305.ppops.net (PPS) with ESMTPS id 4gs2ux07ew-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 05:24:16 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uyIfMJTu2c9652bsfTtGMYhaOE/krbWFx4Ayl0XwyLT0xMHR/6xbTo9v1uv9wmZe5jBOb/IMFdt+rfk1u1oS/C4OeaVpe5P9cCVX71LUghCSOH648t5EqrCuCApv+7zHUJAylDiRCtvIL/RhtYqWBH9lW1R1rablA7cWp4579Bzix/veaE4fMWSCn4makN8zKn8I+nCn/kNCvnxv47SnSSNkbgN8HTdSki+CTP+F2s8nkMrWBdEMHyllFbT1qGQ9/3dTo2E515oDpk8GoEr+FKgDOhvvKMdqAc7eE8d7FP7mEJBaj92yYMTiMloQXKl5Odbi7fyUhpiLbuTEwn+hDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqnJREAsaDSaK59bXYGlEMRqdohLFwctOvTZ9KWYhA0=; b=YcrS1qnG8RVbl2lNmONQvvT7Nw+10prayP5a8yFhpI/337W+upqXMNHv7YUnQ325Wllk+A+H95lF6u0mfGXWygAhuAzxGwWktNFkM20U6Tx48Vgqas14CbHM1QYxnl59D071eukrY9tf77rt+FgA4VOJ335F5WfpyCYL6Voqlam4iyUacOFcia5plHyF0JRu4nXGx44ZIsd5R2FxFa8vfjdZn/BT1H/ATcg5m1KVCNkLp0gin+Ppx4gIQu29YnGrqD1MmfnhohNyljB9bezhGtWiQaV5/ZkX6PzgSDKPr/0rM7vk6RKyyQiDqaHv1Z7keork/mtDgsELBLK2ZxeYAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PqnJREAsaDSaK59bXYGlEMRqdohLFwctOvTZ9KWYhA0=; b=L9yQaHRcGWXaZcXoiK3KjsUt9/dZlWLoAhjPh9wj8e9Nr51ubnvpW5Dx584Z7PhRYhoIAcBp7Ym7Dbdv7/ga76f7Df0rq6fjH2c3dxnaoIRwyQHV5hopdCD2tQGf5LF+shyi2kAX+GdEGdixFtlB6DX4t8OngDriqxj6ADEMMWY= Received: from SA0PR11CA0011.namprd11.prod.outlook.com (2603:10b6:806:d3::16) by SJ0PR10MB7690.namprd10.prod.outlook.com (2603:10b6:a03:51a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.5; Fri, 18 Sep 2026 10:24:12 +0000 Received: from SA2PEPF00003F67.namprd04.prod.outlook.com (2603:10b6:806:d3:cafe::63) by SA0PR11CA0011.outlook.office365.com (2603:10b6:806:d3::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.12 via Frontend Transport; Fri, 18 Sep 2026 10:24:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by SA2PEPF00003F67.mail.protection.outlook.com (10.167.248.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 10:24:10 +0000 Received: from DFLE210.ent.ti.com (10.64.6.68) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:33 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 05:23:33 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 05:23:33 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68IANWOi1534932; Fri, 18 Sep 2026 05:23:32 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v5 15/15] crypto: ti - Change lengths in AEAD to u64 to avoid potential overflows Date: Fri, 18 Sep 2026 15:52:45 +0530 Message-ID: <20260918102245.2784000-16-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260918102245.2784000-1-t-pratham@ti.com> References: <20260918102245.2784000-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F67:EE_|SJ0PR10MB7690:EE_ X-MS-Office365-Filtering-Correlation-Id: cfbfb855-1215-4b9b-c7e1-08df156efaa6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|23010399003|1800799024|376014|56012099006|22082099003|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: wWXc+21+aNOn2CrFpubB0jsSQ8ckZqoQMrLfCMHCMFKvDLtssMkUgN8zychI4rwykFFjds/XftiQujwK9Pk6RATpNB8hP5TD8FIDbyJdAbIYPBQ1jOKRgiHEJjjI1J1jirvY2ZcVtNjYS+mfDF3dq44x8+IN49GX5JGXSa4/MbtAjl65AAUn2KSiOhhdNCZtvAgtqUlmtPqGEvgNtOPMPuQJ3ntFkeHT2frBxa3aHUyr6vuUe/yCb3m4/uAeBxV+KjTBytbN89rZuh1Mxvmk6uX4s5dvrbz9zb4qCeeaZ7Sjaef0Gt5pBnHLlHgmUdz6Y9wV1axe2y4AXudGBq7rs6c1yKAby+7dDGpEa1D+JC+eWAvFU9OApKXKEamqlMw9adxJWR69fCQMNw0Xx9f7YGORyM0lURr09nPUT80BOuBetJYYQ0Jtu1uOXZwuEzQsI53lGH0oDNYZM14B6a7irKbVY4QAhpPEGRnu3PNBH2Ra/NfCc7X057QQN4OYgkgTizaZQFXrSodiAhjdf5LyR3qNnBGtw0v2foHDpDRC50xzKXvhlq0v4ZECMY+zeH+tNq04emUSLE9qPaSdObBTX6gufoZldJYOrbR+VARtvXE1/kRoHfJ/yH4fVGMvw9O0FvDjTnCA8lJwRIg6DUlqIIB/EMImRwGEqPiLt/THVQMiEQXf4DyfrJUiTAtSic+9OR1fyLzuJ+68zS5vdTE0fA== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(23010399003)(1800799024)(376014)(56012099006)(22082099003)(18002099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: C7ge+P6J9cw8iVZD0LyJVHdn22SMtslsg7FcOVDVxz3AvienD+6oxedZ+fiHDDGbogLcG1umOZZJmttrKFdEbA00WChuScLI2C+P2vjZjCsJfpmAAIaXWLXf1wZOV5vXHjPzKLkciV5Z839qppPewP8p793ufrL0OiwhsmDVZdldtjn/qH+6wMt216zxaaW/4eOPIGPHbHbYPwyfraqbEn6wt5joiqCNmc9rbYEEYt58FyYEVLccoo/rOmhiVikxDqutoyu8HGpmu732bbbENglNVetTUQ9Z83pTK7ej6v2kxh+hhiT/+wrL9VO/QVVQZt7uDvnKy6CxmGNdpAaOniwaoNy7RhpdQPycDJquWkHsO3uboqfMQsazTzikspD8sH/7CThmmv9JWqpz4TYlFJQ2M7hIg7IeavV018eMj0ZITxWnwsxG/a9kEJ1Z14fJ X-Exchange-RoutingPolicyChecked: KpwX7I3rJ5w1VnMJuBXdSLff0lJ8uiAnMhPDqEiLvVBOq6O7xPSJppG9Y23Jv2qWMdmxGT29lAFrqNbFrACsVcWuy4Z15oyBA8E6C1aN+FBbqlicDsW2AGNmU70tJ9YXeQ3NhTv4J49OIlU/11nz/XGZ8D8DNOjomFD1Iq2YwmtZEna/DXW2MTzwjcSGzSxcFB0Wd2EP4ScseIDbqFjU337tA1KMs6sUmu2QegpkLEgtwOr2p0XtRwgwz5ZW/DnJd0+1b3D6W2KGY0U4a+zTulY2yZFwLYC+wprqHG7xX4twLRd7QBJnkg02cERJ241LDaYNm74PDhNfwwXOSL63Pg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 10:24:10.5027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cfbfb855-1215-4b9b-c7e1-08df156efaa6 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F67.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB7690 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfX0sPRZ/1rORij FuU5M11+c0B5KMBuchobE0G1lVbwnUY1JJfEWn8e0TbOkkDBdn/fllC2pW9OIvlEU5/08xEeLv4 A/tUAQJYGf248bPmbtL6kzhlb/kjwt6INlU07vx3gqyIX32yZGkvFgfl6nXTwKzGbTFJ6pvUAQ0 D4XGl3Px0OlbT3aMO8uow6/OUcuJW8KD70tOptqNLhmmOVzzNl9KY7osoyl7aRf4JX5PHzJKbqy iDPzjOnxpBby6OQy5xoY6JBKrTZHdRHtZxKMmjjFGqcng4APolUlYlOQ/BmaTJi43cnqem9KMaq JegthX1dZ+2g2miBfvbSUNiULF+TOMJEYbMpblOYAONaU/tTvC2apIpZel8u5W7gH5hTEdFdBMe csaE4TJP0JklWXaWDt9ID9MenDtF+hD3ST37DXN11h0nXhytdCpeHwIhSzP/VeWgujsiSRdO1UT 9bicuns1IyvozgWuGHA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0NCBTYWx0ZWRfXzqcddPKdI7AS 9V/0LUuISQkpUleY1X9McTb1G0utJ00guTvTdFywOSDY5w5hgcbtBbwC6LcURt+5sMpTZtxk8Gk munKGk163hr9NEWmLgY9l3fMYE9NOR4= X-Proofpoint-ORIG-GUID: HmImAOYihCkcQTRFmBhReust9lNt8lk6 X-Proofpoint-GUID: HmImAOYihCkcQTRFmBhReust9lNt8lk6 X-Authority-Analysis: v=2.4 cv=adH0Dhot c=1 sm=1 tr=0 ts=6aad1150 cx=c_pps a=DkeX3LL2/Oc4yJO52xFMkw==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=W2mYDkbPwZfAYNH1kz8A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180144 Content-Type: text/plain; charset="utf-8" Change assoclen, cryptlen, authsize from unsigned int to u64 to avoid overflow when they are added (in TAG offset and padding length calculation) Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 9b982ca4a7730..ca87aacc39c5d 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -756,6 +756,9 @@ static int dthe_aead_enc_get_tag(struct aead_request *r= eq) struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag[AES_BLOCK_WORDS]; + u64 assoclen =3D req->assoclen; + u64 cryptlen =3D req->cryptlen; + u64 authsize =3D ctx->authsize; int nents; int ret; =20 @@ -763,12 +766,12 @@ static int dthe_aead_enc_get_tag(struct aead_request = *req) if (ret) return ret; =20 - nents =3D sg_nents_for_len(req->dst, req->cryptlen + req->assoclen + ctx-= >authsize); + nents =3D sg_nents_for_len(req->dst, cryptlen + assoclen + authsize); if (nents < 0) return nents; =20 - sg_pcopy_from_buffer(req->dst, nents, tag, ctx->authsize, - req->assoclen + req->cryptlen); + sg_pcopy_from_buffer(req->dst, nents, tag, authsize, + assoclen + cryptlen); =20 return 0; } @@ -779,6 +782,9 @@ static int dthe_aead_dec_verify_tag(struct aead_request= *req) struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag_out[AES_BLOCK_WORDS]; u32 tag_in[AES_BLOCK_WORDS]; + u64 assoclen =3D req->assoclen; + u64 cryptlen =3D req->cryptlen; + u64 authsize =3D ctx->authsize; int nents; int ret; =20 @@ -786,14 +792,14 @@ static int dthe_aead_dec_verify_tag(struct aead_reque= st *req) if (ret) return ret; =20 - nents =3D sg_nents_for_len(req->src, req->assoclen + req->cryptlen); + nents =3D sg_nents_for_len(req->src, assoclen + cryptlen); if (nents < 0) return nents; =20 - sg_pcopy_to_buffer(req->src, nents, tag_in, ctx->authsize, - req->assoclen + req->cryptlen - ctx->authsize); + sg_pcopy_to_buffer(req->src, nents, tag_in, authsize, + assoclen + cryptlen - authsize); =20 - if (crypto_memneq(tag_in, tag_out, ctx->authsize)) + if (crypto_memneq(tag_in, tag_out, authsize)) return -EBADMSG; else return 0; @@ -887,10 +893,10 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); struct dthe_data *dev_data =3D rctx->dev_data; =20 - unsigned int cryptlen =3D req->cryptlen; - unsigned int assoclen =3D req->assoclen; - unsigned int authsize =3D ctx->authsize; - unsigned int unpadded_cryptlen; + u64 cryptlen =3D req->cryptlen; + u64 assoclen =3D req->assoclen; + u64 authsize =3D ctx->authsize; + u64 unpadded_cryptlen; struct scatterlist *src =3D NULL; struct scatterlist *dst =3D NULL; struct scatterlist *aad_sg =3D NULL; --=20 2.34.1