From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 470B13D75BE for ; Fri, 18 Sep 2026 03:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700504; cv=none; b=gi6sHYyR//BAbtc2a79Mz7qAgZ9qz+gpuYZnO1Km/mFIiYgkkA21LeOB0L83y1HI6CYfZ/u6df0PSd+2clki3Eb2N/UbZjQAl9UhX1E3F06fyjcRD2ka6gdeyeoLSLyxUTBk8Nn2ncWonbap4F7XMDPQuuwPsLA6G6BMpdT9gYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700504; c=relaxed/simple; bh=mFz63k23aaQYRmdN+ViRxXvGx6v8cMKKcpGHaF7j7H8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i/1204LwzG2y2/3yajl+CNfnhAFhKcAfVm+0HhqRz6PDBlgQe/XpRpiE2ey1wQhmnke9CrGFwuTCQiSGqeU5MvFA7arCwaVOWUGJkku8RBghd6SRGN5zMO3bdlxEhHZFW7MaS4PRQJIyStsQOtrLjSNHlYH/cieSTy+sm53OsgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OeIpFAc1; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OeIpFAc1" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccb652d7so259845a91.0 for ; Thu, 17 Sep 2026 20:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700498; x=1790305298; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zNwi0hswB7nBQJuSOnrDkFTvC7EtUxGnPwE8AGU2RxA=; b=OeIpFAc1U/ra27Exf6LWJ5N67oECYjJdiKpQKitxlSM++mufXAQJ0MkwwCaWPqdJTj Xclg8BL4QrziW3pKGCy8z4EzFNEOPI8LiSOtXiVfLbUlB+nNX8w9jNH3k0k2gwr14oiK 8XvZsO0REwvOmT5UgjCdhmemZpY6P9FxzO7eZM9NLCVWAw5aHrn9ofKPuLqCGuBlYa5P fylTF45xVzYv3i+hz+V2IB6lQNVfg03XM0s7Vmps3To73XR5tHEtmNHfXZNu5p6WQMSL D4iBxCZr6NGjtdrgAdZZZKx3oYKPPVLdO/c9TXGUaqxc4JluBBSTEZfUdv9tdyoHfMuz HB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700498; x=1790305298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zNwi0hswB7nBQJuSOnrDkFTvC7EtUxGnPwE8AGU2RxA=; b=0sfE22OKKdatmBgy0TptBeLIfxZ3fVYLT71hE/HKkOmvNmdzcw07xbdH4GtTk1z9y5 NhHRlx3qybn8CpkGfqLWUZmNmxLA8jl9PkdnltAxdwJVtDMGNOmYfpFSLnSGjMQU1GUH pjWJdnY0a5AEYHzbGJD8vf3RBLhOKFuONwOSap6lVVaPHwTXhF0Rtn5KJl1InMxIMQJc 6imPhKhX71GgjYsSU9WvmY4h5JlioyHZaGWNde692wxQIhsePBYzsrHMcIayWIX3fGIn 3zUc66wGCg/bSwQCPJM6hrjddLTpqQNLGCRQn+/x07ePMKAGrfExFRpolNcGoKKGHfPr ra0Q== X-Forwarded-Encrypted: i=1; AKwUvByrmMVAxrdaJueacfqM8Q4dv4s0eVMT5ugr3kWlbCHV+vpZvmmnmH5uw94bz1hIrtm36TnvI4Tx177jZS4=@vger.kernel.org X-Gm-Message-State: AFuF++k6nKwHw9r9KOKjE6JE9CZk633nCcfrEO+HM3kMMdv/X95a+SMI /IDbQpvegBC7Z1Zeea4ton/EXCEM9HNVJmw0GhFRTjzgV8fi9zOZM0fK X-Gm-Gg: AYBFou1aP8HAJhPjqJUFDrvgTNBlHvx823qW8y7HnuoHjrl4rxUoQdLfP64C77EROgb gH73DOEQNP7dMFnlOMkeeZkgZaU9F72ehb5XyOJbioiqCrt4ATppXGPtnHFLqPHVUTb1AZTLNge /T66bcMdgsswd4kWDT2o31r7y3Oqubuhxvvn2dkIqPa97uXmW/5R7wGnN3GkeG5jlY8CvGPUMMp LaGzx8yXD9vZH9csmsCFzkZsj3jt9i+f+MIfY+aRswI52sXLeQ1+R6vu9FWF2AmcNoCDk0rn+QI fyoLcLCFpyEbCryEdCC47vsKq3kV6UJdpEax1mBEigxcglM2N9dY5kO3CSkyTueBK60jJDwwawH 2jpaSiVuSG6FdqcfQ1NRltUDzhQxzRikyhZqwdcJO9OFt0pbO7nuXsMB/8nWMudz9KHy1qLhhXX mtqorfPO+JD+gdas7OFY9WlEng87zeRQcSOdXAcXAII66ndOKu+pPwNUAwFYyFFx124DCXO7WrH w313ixzZ8C0dhma9vjdO6G2w4NR20opazTot8PU7U5QUMTOO/SKZ4F57QZ/jOA= X-Received: by 2002:a17:90a:38c4:b0:39e:5c75:acbb with SMTP id 98e67ed59e1d1-39e5c75c196mr202652a91.11.1789700497914; Thu, 17 Sep 2026 20:01:37 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:37 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu , Conor Dooley Subject: [PATCH v7 1/7] dt-bindings: display: verisilicon,dc: add support for nuvoton,ma35d1-dcu Date: Fri, 18 Sep 2026 11:01:19 +0800 Message-ID: <20260918030125.315978-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the Nuvoton MA35D1 DCUltraLite (nuvoton,ma35d1-dcu) to the binding. The DCUltraLite uses only four clocks (core, axi, ahb, pix0) and one reset (core), with a single output port. The MA35D1 clock controller gates the core, AXI and AHB clocks with a single bit, but each remains a distinct clock line feeding the IP with its own rate constraints, so all four must still be listed individually in the devicetree; core, axi and ahb happen to share the same clock phandle. Move the clocks/clock-names minItems to 4 and resets/reset-names minItems to 1 at the top level, since that is the lowest count any supported variant needs. Add an allOf/if block that tightens the constraint back up to the fixed 5-clock/3-reset topology required by the existing thead,th1520-dc8200 compatible, and another one that caps the new nuvoton,ma35d1-dcu compatible at the 4-clock/1-reset count it actually wires up. Restrict the same nuvoton,ma35d1-dcu if block to a single port@0, since the DCUltraLite only has one output port. Signed-off-by: Joey Lu Acked-by: Conor Dooley --- .../bindings/display/verisilicon,dc.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml = b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml index 919a900122012..e1e6a3a953646 100644 --- a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml @@ -17,6 +17,7 @@ properties: items: - enum: - thead,th1520-dc8200 + - nuvoton,ma35d1-dcu - const: verisilicon,dc # DC IPs have discoverable ID/revision regis= ters =20 reg: @@ -26,6 +27,7 @@ properties: maxItems: 1 =20 clocks: + minItems: 4 items: - description: DC Core clock - description: DMA AXI bus clock @@ -34,6 +36,7 @@ properties: - description: Pixel clock of output 1 =20 clock-names: + minItems: 4 items: - const: core - const: axi @@ -42,12 +45,14 @@ properties: - const: pix1 =20 resets: + minItems: 1 items: - description: DC Core reset - description: DMA AXI bus reset - description: Configuration AHB bus reset =20 reset-names: + minItems: 1 items: - const: core - const: axi @@ -79,6 +84,52 @@ required: - reset-names - ports =20 +allOf: + - if: + properties: + compatible: + contains: + const: thead,th1520-dc8200 + then: + properties: + clocks: + minItems: 5 + + clock-names: + minItems: 5 + + resets: + minItems: 3 + + reset-names: + minItems: 3 + + - if: + properties: + compatible: + contains: + const: nuvoton,ma35d1-dcu + then: + properties: + clocks: + maxItems: 4 + + clock-names: + maxItems: 4 + + resets: + maxItems: 1 + + reset-names: + maxItems: 1 + + ports: + properties: + port@1: false + + required: + - port@0 + additionalProperties: false =20 examples: --=20 2.43.0 From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E7553B14C2 for ; Fri, 18 Sep 2026 03:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700507; cv=none; b=nCbB5y0cGES94rl5JW+r4I9WT1Msw1vi5J3eIDP+s2UpPrumKr+f8U9lL7LabAPkb5z8dtbJSmUHYWCJ1w9mwlJju0LWLndZFl2fkpzaNxiXiZgVxXQY65gYiMvTrchrw2OHp7+qYXh7d/WBLkFY6rdL4x5rZdiv7tP5DETbwhk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700507; c=relaxed/simple; bh=tt2RAWD+bHSPy7yGLlzDmpcso5w9hUHauQQE1wwIZqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y8L4liThnDh5v636dU/90QyEKw697IFAk5Ucaa+InX/SpLIOMuBnMdbTZVzy/niRzLBFeE4Buz1WoUi86K8v35BNWJdAhii7JgfGXt7+yOS4hmwPaTG9B2gbPD24Y9K2wWo1HIgyat6u2WvAQVgL4ugaVi1WlqrxPs5qvWHy100= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RW2i19bb; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RW2i19bb" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccd5cf02so192628a91.3 for ; Thu, 17 Sep 2026 20:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700501; x=1790305301; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d1MvCbfjotTiPMU9xzuQx8OmetQMTdloo3vQR2iBJfs=; b=RW2i19bbc3XA3SyMJNQ2sF6TOlcsS81n22E0HIixpBmbrMYqb9YGSUwcberJjDW43d IIj20C19M9GYzr5Rn8p6e/cgjZHHfBTW+H7jO9KPwFeK9wG1LeiSUzDaXnyKyiIFflDf eCPA2kCpLB/H3+Ip0rYlyub8nxNgOqwM5uhF/0XjTYJ77T+xRpY3XyzEfreQFevc3AaH 90o2L5+609wdXfIJa+50Fun6Xg6pm2G/EoyfDOytNA9XNfjFJbtc/n7a5yBjsN+tliiC pvgK30lpl35Lypkzn/CAsNWr1AeMAzFekPrRmTL+Vmc010+61mvIMlCskyfetrjTfLnk jlpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700501; x=1790305301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=d1MvCbfjotTiPMU9xzuQx8OmetQMTdloo3vQR2iBJfs=; b=pHI4GsmLPvyxSHBTQW8DvdBKjwb5hIQPel4pE5WgJPrM4q4BMSqzCrYsHdNjURbxCU 8ftzbwhUz0IiFzuyy1ViKI4EGYPLdpLximlJKgrBz7OVk9eQvme/6hMqCYKTvMVQ7Q77 pkhM7Freo7OwX4kvrwV5Ak1n2lfYTF9A71wVM29s8VFOFAVK9/Wnhh83X2oqkoosDL2r lepwSc39AWwuCi9bMMVIpXUyTa9zv70u8e/slOwVPfMXL91TFWGiopXaQWU+qKdmRXbh qt6QiR0o2mlt8eBvqq1k5mUmYXQR2h0TzLCsq5kM2l81LvWP3ue5ho8gq48jobgSp5P3 qR4Q== X-Forwarded-Encrypted: i=1; AKwUvBx3VObkMIHt11/GqJ/JW0TfbNYA+V6Om6KFq9Jvd8Em6XEXb1N2Mn7w3uxMuTuC6mV+x9X86Owxz8ETxYU=@vger.kernel.org X-Gm-Message-State: AFuF++k8ALmcrbcHIQdemqyjAApXE+NPm91n5MRIb86wNBZ3sBsvcFIF pMuBRjhnwEsPjtmtlInnGgWb3bQzRhB5Je6QaIzrAovtQEoR5JolyYJZ X-Gm-Gg: AYBFou3ZicEUHY0AdPA7sC46PTi0pk0roADG8fi/6Qff7/rkhU4Hm8tU7bB+5cvnzA4 geqoaQqrC8IHl/KocE9C8Lp20Rm2n4kn5k5wDRryrXn6BlxXIrYXeDJ8SFPj6LoXPimiDkoyaOq mIsjX1RfeMiss/iq+M/XBV9RNgjkuJ5i8ClDifQsvYu8c+PO1lnPGU9BJt0+Cxy+5SKtHeyE+6R b/icQPmWUJHitLLU2FDNeJbS2C7mRhthhhgVSiApqeyf1daFUYK4PNlhnPIuQfsPe+RiQ/dMxOG YvJsO1Lpf0rNGuwjY9ZdOtPtszMW7xwzii49C5Acd5ey7+Uar5eJowNGapDpg2zpLTYKwH5rtLz N5ltGhUnjGgQih2rrweYOYkw8/bh1Aa6exlkfC7GC1SR/NN+/MMd4cdSqefx4BMir27jsrfANiI 48apL7onUwUK1E8mRbvEMn0w9ezufRAl0oH1L5qktyKBfTinyfeUyJH8Rtzp5Qx81GNCLuwjZVF LKLsNE3KY1+ogGbkTeEnVVFV9NtiCRUoU7OF7HJpX+p9N3N/xaAtqYsc3GjY/E= X-Received: by 2002:a17:90b:17c1:b0:398:e86b:ce14 with SMTP id 98e67ed59e1d1-39e54e3f526mr2301890a91.20.1789700501279; Thu, 17 Sep 2026 20:01:41 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:40 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v7 2/7] drm/verisilicon: add register-level macros for DC8000 Date: Fri, 18 Sep 2026 11:01:20 +0800 Message-ID: <20260918030125.315978-3-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add register-level constants needed by the forthcoming DC8000 (DCUltraLite) hardware ops: VSDC_DISP_IRQ_VSYNC(n) in vs_crtc_regs.h: bit mask for per-output VSYNC interrupt bits in DISP_IRQ_STA (0x147C) / DISP_IRQ_EN (0x1480), which are the IRQ registers used by DCUltraLite in place of the DC8200 TOP_IRQ_ACK / TOP_IRQ_EN registers. VSDC_FB_CONFIG_ENABLE (bit 0), VSDC_FB_CONFIG_VALID (bit 3) and VSDC_FB_CONFIG_RESET (bit 4) in vs_primary_plane_regs.h: control bits in the FB_CONFIG register used by DCUltraLite for framebuffer enable and per-frame commit handshake. No behaviour change for existing DC8200 platforms. Signed-off-by: Joey Lu Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/verisilicon/vs_crtc_regs.h | 1 + drivers/gpu/drm/verisilicon/vs_primary_plane_regs.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/verisilicon/vs_crtc_regs.h b/drivers/gpu/drm/v= erisilicon/vs_crtc_regs.h index c7930e817635c..d4da22b08cd5c 100644 --- a/drivers/gpu/drm/verisilicon/vs_crtc_regs.h +++ b/drivers/gpu/drm/verisilicon/vs_crtc_regs.h @@ -54,6 +54,7 @@ #define VSDC_DISP_GAMMA_DATA(n) (0x1460 + 0x4 * (n)) =20 #define VSDC_DISP_IRQ_STA 0x147C +#define VSDC_DISP_IRQ_VSYNC(n) BIT(n) =20 #define VSDC_DISP_IRQ_EN 0x1480 =20 diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane_regs.h b/drivers/= gpu/drm/verisilicon/vs_primary_plane_regs.h index cbb125c46b390..67d4b00f294e2 100644 --- a/drivers/gpu/drm/verisilicon/vs_primary_plane_regs.h +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane_regs.h @@ -16,6 +16,9 @@ #define VSDC_FB_STRIDE(n) (0x1408 + 0x4 * (n)) =20 #define VSDC_FB_CONFIG(n) (0x1518 + 0x4 * (n)) +#define VSDC_FB_CONFIG_ENABLE BIT(0) +#define VSDC_FB_CONFIG_VALID BIT(3) +#define VSDC_FB_CONFIG_RESET BIT(4) #define VSDC_FB_CONFIG_CLEAR_EN BIT(8) #define VSDC_FB_CONFIG_ROT_MASK GENMASK(13, 11) #define VSDC_FB_CONFIG_ROT(v) ((v) << 11) --=20 2.43.0 From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pj2-f42.google.com (mail-pj2-f42.google.com [74.125.227.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9207A3DD86B for ; Fri, 18 Sep 2026 03:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700511; cv=none; b=azIhAqpl/SprKU0WaZBuQlhEgJUpdMYR6OBUuay6MVJ+zhWszXRmjVm/GKI1WOH1rG+dCTtj9LfrQroFzUDpoqRqtGMUQM45yXJpBgsu6OzKxZHXKkL3XQp/LYRaLO9JMCSwckTx2Pl7zfIlAOVAHKYGIlpjfdIY0CnP5DUklEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700511; c=relaxed/simple; bh=J/dUq0ZxwAILz+QfgSgSdKH0LgoUZTnLIXqcMTlvon8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c8t+gBlCfmOiHlJUFge8Dh1fINlwiAq/HJXMede/qOx7mNQcYp2h7NSSJnhq6/q80t5GJQyNE7nw0M9dWkGvzBT2WIqf7qAHs3jWK0XVt3Xu9uEvcxY9V1uRpYdxyvJAAk5h5rhjwzjtaX4NQjhgQ/Be6CCmB1J6Cf7wLAQwbAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Di7epC1x; arc=none smtp.client-ip=74.125.227.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Di7epC1x" Received: by mail-pj2-f42.google.com with SMTP id 98e67ed59e1d1-396ccd5cf02so192650a91.3 for ; Thu, 17 Sep 2026 20:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700505; x=1790305305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mmYsInXqGxHOa3AXxpWGJMylYYFqoNEUetbo5r6zMXk=; b=Di7epC1xZcwhT/C5WMvUhR/n2JI4qTzn/AgLNFsiQEEE/muLkXawDUOLi7yHIEQeZB pBCvv35iVI7F/4uNDW7GBN1OyMPX+UUpBE3kXrubqMO9HzcWsZn48eCGG07FXOM5+jCI DaR4utpLR3gqd5uDU0kVTHdHpDOPcJ7HgL8hUPzG2lQJc7mACbkI4D8OQmTmvXCMxlg2 ERnHDA4BOgkRJZ6DmkllPH1U82IpkfWwm4xXGpIXrBPUri9OJaYAXMGi01D27V+7JwQA bm+wjuk9b+A42IwxIba+1DSL9pSC6oIgpDmahUKvT4pQTi77d61hPHRTTYHvw97kHFcU KFjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700505; x=1790305305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mmYsInXqGxHOa3AXxpWGJMylYYFqoNEUetbo5r6zMXk=; b=NionJ3/WX4XSpVhb35SG8akEMtMNx3P796FFZ08tvXzX/dFTG5pNIgl1kcrJLm/Cwk HvtUTNvYA4cZERyeIMgai5QgmORy70wEalL1U96er11F+Cyo/m30anVEU44+MQDg2hd5 TzMvltUAKywPvSGKM3KNuT46wqSntw47Bzk/LcZjmDH5gtBEkvQXC9dKv+YmRrUIGaSK AnFEcICGy/nfkDJLJbkR4H9CF3apuyMF6MJ+PfJ531K8Ej3sqsF0jnOy+BHRxDiiT6w4 HuZi9koVK4WWlZWF3FJc3qpAYEp7qGX0zfAibtulWSvYqyqzBKBurNmG1Yo85gdpDoD+ RQKQ== X-Forwarded-Encrypted: i=1; AKwUvBweEeHKv5U3SShw1stDCNPdlzjsqUXAdUFEXTZOQXHCtHmO3WSRa+NKUReacrTsdqJF0LKQ3EEW0skwoOw=@vger.kernel.org X-Gm-Message-State: AFuF++lpaWXCtMPs1vDyTsk/A3tfYJ43Ogke7q3G2LXWpLJp4mXx0hne LhQL6Y8Sh8TQZA8liFZ4v59KcLFCtqXSQgxjxYQYRTCRZL291l9MeaJT X-Gm-Gg: AYBFou0qk01BZ/t8uAoRZvqXsQuqNqrthGLqTwkA3jz+pQyRIT+Ffv+7RRBugchqXix YdzSOP/iH4Qf39HeSLlVVD42fBdB5dbKDAwNK1j5BeL4m2/9jyAh/rDTcF7zHRtT5DuZXsV72HJ cMk929InKvrPfRBqbWcmhRuliU24E5Qqvp8yEqN6DnhO3fyDDrQAvBUM7ZgZ4j4ckRJzdXaHZWa /hSTKSgcNtGhe/z2IZdXUcL9nJlhpxeIO77DMbWCfpQ0eSmkcEwQLP11a1QqvYdsQX84f+eG3P+ x/n7O2XYPjq2WPgZoMSm++mvlF33tzuEvCrBD0TvnoJ3Tt+Yf41NPOxIYGbLTIIeaGKC3/tVq0j uRPUThoXLgtfu2a54UyrvYuSnGLw29V7tTO17Wmyro3HE/VWChwGHnUVB7Bx3LQoLOpjQ+ba+J0 0WB4IoaQydwQ2Du8/HX+p0SzeMuvb8ZYHpgaES1gHWmq5sF2qxpVuBiYDOEJEQEBxYboHVZEwCR dt1Km1PJplhTd4pJNjWWLY+tjufa5wVVmOK5IX29RrRr27WAOEu83elFMIK0rQ= X-Received: by 2002:a17:90b:56c5:b0:395:5f43:4ec4 with SMTP id 98e67ed59e1d1-39e549787b4mr2933774a91.0.1789700504690; Thu, 17 Sep 2026 20:01:44 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:44 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v7 3/7] drm/verisilicon: introduce per-variant hardware ops table Date: Fri, 18 Sep 2026 11:01:21 +0800 Message-ID: <20260918030125.315978-4-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The DC8200 and DCUltraLite share a broadly similar register layout but differ in how the bridge, CRTC, primary plane and IRQ paths are driven. Introduce a vs_dc_funcs vtable so each variant can supply its own implementation without scattering conditionals across multiple files. Add a generation field to struct vs_chip_identity to distinguish variants. Extract the DC8200-specific hardware ops into vs_dc8200.c and add unified IRQ bit definitions so implementations can translate hardware-specific bits to a common set. Update the shared code to dispatch through dc->funcs. No behaviour change for existing DC8200 platforms. Signed-off-by: Joey Lu Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/verisilicon/Makefile | 2 +- drivers/gpu/drm/verisilicon/vs_bridge.c | 20 +-- drivers/gpu/drm/verisilicon/vs_crtc.c | 38 +++++- drivers/gpu/drm/verisilicon/vs_dc.c | 6 +- drivers/gpu/drm/verisilicon/vs_dc.h | 32 +++++ drivers/gpu/drm/verisilicon/vs_dc8200.c | 121 ++++++++++++++++++ drivers/gpu/drm/verisilicon/vs_drm.c | 5 +- drivers/gpu/drm/verisilicon/vs_drm.h | 8 ++ drivers/gpu/drm/verisilicon/vs_hwdb.c | 4 + drivers/gpu/drm/verisilicon/vs_hwdb.h | 6 + .../gpu/drm/verisilicon/vs_primary_plane.c | 32 +---- 11 files changed, 220 insertions(+), 54 deletions(-) create mode 100644 drivers/gpu/drm/verisilicon/vs_dc8200.c diff --git a/drivers/gpu/drm/verisilicon/Makefile b/drivers/gpu/drm/verisil= icon/Makefile index 426f4bcaa834d..9d4cd16452fa1 100644 --- a/drivers/gpu/drm/verisilicon/Makefile +++ b/drivers/gpu/drm/verisilicon/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only =20 -verisilicon-dc-objs :=3D vs_bridge.o vs_crtc.o vs_dc.o vs_drm.o vs_hwdb.o \ +verisilicon-dc-objs :=3D vs_bridge.o vs_crtc.o vs_dc.o vs_dc8200.o vs_drm.= o vs_hwdb.o \ vs_plane.o vs_primary_plane.o vs_cursor_plane.o =20 obj-$(CONFIG_DRM_VERISILICON_DC) +=3D verisilicon-dc.o diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.c b/drivers/gpu/drm/veri= silicon/vs_bridge.c index dc7c85b07fe32..3fbc8d57f8a1e 100644 --- a/drivers/gpu/drm/verisilicon/vs_bridge.c +++ b/drivers/gpu/drm/verisilicon/vs_bridge.c @@ -162,15 +162,8 @@ static void vs_bridge_enable_common(struct vs_crtc *cr= tc, VSDC_DISP_PANEL_CONFIG_DE_EN | VSDC_DISP_PANEL_CONFIG_DAT_EN | VSDC_DISP_PANEL_CONFIG_CLK_EN); - regmap_set_bits(dc->regs, VSDC_DISP_PANEL_CONFIG(output), - VSDC_DISP_PANEL_CONFIG_RUNNING); - regmap_clear_bits(dc->regs, VSDC_DISP_PANEL_START, - VSDC_DISP_PANEL_START_MULTI_DISP_SYNC); - regmap_set_bits(dc->regs, VSDC_DISP_PANEL_START, - VSDC_DISP_PANEL_START_RUNNING(output)); - - regmap_set_bits(dc->regs, VSDC_DISP_PANEL_CONFIG_EX(crtc->id), - VSDC_DISP_PANEL_CONFIG_EX_COMMIT); + + dc->funcs->panel_enable_ex(dc, output); } =20 static void vs_bridge_atomic_enable_dpi(struct drm_bridge *bridge, @@ -228,14 +221,7 @@ static void vs_bridge_atomic_disable(struct drm_bridge= *bridge, struct vs_dc *dc =3D crtc->dc; unsigned int output =3D crtc->id; =20 - regmap_clear_bits(dc->regs, VSDC_DISP_PANEL_START, - VSDC_DISP_PANEL_START_MULTI_DISP_SYNC | - VSDC_DISP_PANEL_START_RUNNING(output)); - regmap_clear_bits(dc->regs, VSDC_DISP_PANEL_CONFIG(output), - VSDC_DISP_PANEL_CONFIG_RUNNING); - - regmap_set_bits(dc->regs, VSDC_DISP_PANEL_CONFIG_EX(crtc->id), - VSDC_DISP_PANEL_CONFIG_EX_COMMIT); + dc->funcs->panel_disable_ex(dc, output); } =20 static const struct drm_bridge_funcs vs_dpi_bridge_funcs =3D { diff --git a/drivers/gpu/drm/verisilicon/vs_crtc.c b/drivers/gpu/drm/verisi= licon/vs_crtc.c index c24c1588cbe69..6033662dd9221 100644 --- a/drivers/gpu/drm/verisilicon/vs_crtc.c +++ b/drivers/gpu/drm/verisilicon/vs_crtc.c @@ -16,10 +16,33 @@ #include "vs_crtc_regs.h" #include "vs_crtc.h" #include "vs_dc.h" -#include "vs_dc_top_regs.h" #include "vs_drm.h" #include "vs_plane.h" =20 +static void vs_crtc_atomic_begin(struct drm_crtc *crtc, + struct drm_atomic_commit *state) +{ + struct vs_crtc *vcrtc =3D drm_crtc_to_vs_crtc(crtc); + struct vs_dc *dc =3D vcrtc->dc; + unsigned int output =3D vcrtc->id; + + if (dc->funcs->crtc_begin) + dc->funcs->crtc_begin(dc, output); +} + +static void vs_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_atomic_commit *state) +{ + struct vs_crtc *vcrtc =3D drm_crtc_to_vs_crtc(crtc); + struct vs_dc *dc =3D vcrtc->dc; + unsigned int output =3D vcrtc->id; + + if (dc->funcs->crtc_flush) + dc->funcs->crtc_flush(dc, output); + + drm_crtc_vblank_atomic_flush(crtc, state); +} + static void vs_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_atomic_commit *state) { @@ -30,6 +53,9 @@ static void vs_crtc_atomic_disable(struct drm_crtc *crtc, drm_crtc_vblank_off(crtc); =20 clk_disable_unprepare(dc->pix_clk[output]); + + if (dc->funcs->crtc_disable_ex) + dc->funcs->crtc_disable_ex(dc, output); } =20 static void vs_crtc_atomic_enable(struct drm_crtc *crtc, @@ -42,6 +68,9 @@ static void vs_crtc_atomic_enable(struct drm_crtc *crtc, drm_WARN_ON(&dc->drm_dev->base, clk_prepare_enable(dc->pix_clk[output])); =20 + if (dc->funcs->crtc_enable_ex) + dc->funcs->crtc_enable_ex(dc, output); + drm_crtc_vblank_on(crtc); } =20 @@ -119,7 +148,8 @@ static bool vs_crtc_mode_fixup(struct drm_crtc *crtc, } =20 static const struct drm_crtc_helper_funcs vs_crtc_helper_funcs =3D { - .atomic_flush =3D drm_crtc_vblank_atomic_flush, + .atomic_begin =3D vs_crtc_atomic_begin, + .atomic_flush =3D vs_crtc_atomic_flush, .atomic_enable =3D vs_crtc_atomic_enable, .atomic_disable =3D vs_crtc_atomic_disable, .mode_set_nofb =3D vs_crtc_mode_set_nofb, @@ -132,7 +162,7 @@ static int vs_crtc_enable_vblank(struct drm_crtc *crtc) struct vs_crtc *vcrtc =3D drm_crtc_to_vs_crtc(crtc); struct vs_dc *dc =3D vcrtc->dc; =20 - regmap_set_bits(dc->regs, VSDC_TOP_IRQ_EN, VSDC_TOP_IRQ_VSYNC(vcrtc->id)); + dc->funcs->enable_vblank(dc, vcrtc->id); =20 return 0; } @@ -142,7 +172,7 @@ static void vs_crtc_disable_vblank(struct drm_crtc *crt= c) struct vs_crtc *vcrtc =3D drm_crtc_to_vs_crtc(crtc); struct vs_dc *dc =3D vcrtc->dc; =20 - regmap_clear_bits(dc->regs, VSDC_TOP_IRQ_EN, VSDC_TOP_IRQ_VSYNC(vcrtc->id= )); + dc->funcs->disable_vblank(dc, vcrtc->id); } =20 static const struct drm_crtc_funcs vs_crtc_funcs =3D { diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisili= con/vs_dc.c index dad9967bc10b8..9729b693d360e 100644 --- a/drivers/gpu/drm/verisilicon/vs_dc.c +++ b/drivers/gpu/drm/verisilicon/vs_dc.c @@ -8,9 +8,7 @@ #include #include =20 -#include "vs_crtc.h" #include "vs_dc.h" -#include "vs_dc_top_regs.h" #include "vs_drm.h" #include "vs_hwdb.h" =20 @@ -33,7 +31,7 @@ static irqreturn_t vs_dc_irq_handler(int irq, void *priva= te) struct vs_dc *dc =3D private; u32 irqs; =20 - regmap_read(dc->regs, VSDC_TOP_IRQ_ACK, &irqs); + irqs =3D dc->funcs->irq_ack(dc); =20 vs_drm_handle_irq(dc, irqs); =20 @@ -136,6 +134,8 @@ static int vs_dc_probe(struct platform_device *pdev) dev_info(dev, "Found DC%x rev %x customer %x\n", dc->identity.model, dc->identity.revision, dc->identity.customer_id); =20 + dc->funcs =3D &vs_dc8200_funcs; + if (port_count > dc->identity.display_count) { dev_err(dev, "too many downstream ports than HW capability\n"); ret =3D -EINVAL; diff --git a/drivers/gpu/drm/verisilicon/vs_dc.h b/drivers/gpu/drm/verisili= con/vs_dc.h index ed1016f18758e..825f5dd6bf174 100644 --- a/drivers/gpu/drm/verisilicon/vs_dc.h +++ b/drivers/gpu/drm/verisilicon/vs_dc.h @@ -14,6 +14,7 @@ #include =20 #include +#include =20 #include "vs_hwdb.h" =20 @@ -22,6 +23,34 @@ =20 struct vs_drm_dev; struct vs_crtc; +struct vs_dc; + +struct vs_dc_funcs { + /* Bridge: atomic_enable, atomic_disable */ + void (*panel_enable_ex)(struct vs_dc *dc, unsigned int output); + void (*panel_disable_ex)(struct vs_dc *dc, unsigned int output); + + /* CRTC: atomic_begin, atomic_flush */ + void (*crtc_begin)(struct vs_dc *dc, unsigned int output); + void (*crtc_flush)(struct vs_dc *dc, unsigned int output); + + /* CRTC: atomic_enable, atomic_disable */ + void (*crtc_enable_ex)(struct vs_dc *dc, unsigned int output); + void (*crtc_disable_ex)(struct vs_dc *dc, unsigned int output); + + /* CRTC: enable_vblank, disable_vblank */ + void (*enable_vblank)(struct vs_dc *dc, unsigned int output); + void (*disable_vblank)(struct vs_dc *dc, unsigned int output); + + /* Primary plane: atomic_enable, atomic_disable, atomic_update */ + void (*primary_plane_enable_ex)(struct vs_dc *dc, unsigned int output); + void (*primary_plane_disable_ex)(struct vs_dc *dc, unsigned int output); + void (*primary_plane_update_ex)(struct vs_dc *dc, unsigned int output, + struct drm_plane_state *state); + + /* IRQ acknowledge */ + u32 (*irq_ack)(struct vs_dc *dc); +}; =20 struct vs_dc { struct regmap *regs; @@ -33,6 +62,9 @@ struct vs_dc { =20 struct vs_drm_dev *drm_dev; struct vs_chip_identity identity; + const struct vs_dc_funcs *funcs; }; =20 +extern const struct vs_dc_funcs vs_dc8200_funcs; + #endif /* _VS_DC_H_ */ diff --git a/drivers/gpu/drm/verisilicon/vs_dc8200.c b/drivers/gpu/drm/veri= silicon/vs_dc8200.c new file mode 100644 index 0000000000000..f72da10295e1b --- /dev/null +++ b/drivers/gpu/drm/verisilicon/vs_dc8200.c @@ -0,0 +1,121 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2025 Icenowy Zheng + */ + +#include + +#include + +#include "vs_bridge_regs.h" +#include "vs_dc.h" +#include "vs_dc_top_regs.h" +#include "vs_drm.h" +#include "vs_plane.h" +#include "vs_primary_plane_regs.h" + +static void vs_dc8200_panel_enable_ex(struct vs_dc *dc, unsigned int outpu= t) +{ + regmap_set_bits(dc->regs, VSDC_DISP_PANEL_CONFIG(output), + VSDC_DISP_PANEL_CONFIG_RUNNING); + regmap_clear_bits(dc->regs, VSDC_DISP_PANEL_START, + VSDC_DISP_PANEL_START_MULTI_DISP_SYNC); + regmap_set_bits(dc->regs, VSDC_DISP_PANEL_START, + VSDC_DISP_PANEL_START_RUNNING(output)); + + regmap_set_bits(dc->regs, VSDC_DISP_PANEL_CONFIG_EX(output), + VSDC_DISP_PANEL_CONFIG_EX_COMMIT); +} + +static void vs_dc8200_panel_disable_ex(struct vs_dc *dc, unsigned int outp= ut) +{ + regmap_clear_bits(dc->regs, VSDC_DISP_PANEL_CONFIG(output), + VSDC_DISP_PANEL_CONFIG_RUNNING); + regmap_clear_bits(dc->regs, VSDC_DISP_PANEL_START, + VSDC_DISP_PANEL_START_MULTI_DISP_SYNC | + VSDC_DISP_PANEL_START_RUNNING(output)); + + regmap_set_bits(dc->regs, VSDC_DISP_PANEL_CONFIG_EX(output), + VSDC_DISP_PANEL_CONFIG_EX_COMMIT); +} + +static void vs_dc8200_enable_vblank(struct vs_dc *dc, unsigned int output) +{ + regmap_set_bits(dc->regs, VSDC_TOP_IRQ_EN, + VSDC_TOP_IRQ_VSYNC(output)); +} + +static void vs_dc8200_disable_vblank(struct vs_dc *dc, unsigned int output) +{ + regmap_clear_bits(dc->regs, VSDC_TOP_IRQ_EN, + VSDC_TOP_IRQ_VSYNC(output)); +} + +static void vs_dc8200_plane_commit(struct vs_dc *dc, unsigned int output) +{ + regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), + VSDC_FB_CONFIG_EX_COMMIT); +} + +static void vs_dc8200_primary_plane_enable_ex(struct vs_dc *dc, unsigned i= nt output) +{ + regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), + VSDC_FB_CONFIG_EX_FB_EN); + regmap_update_bits(dc->regs, VSDC_FB_CONFIG_EX(output), + VSDC_FB_CONFIG_EX_DISPLAY_ID_MASK, + VSDC_FB_CONFIG_EX_DISPLAY_ID(output)); + + vs_dc8200_plane_commit(dc, output); +} + +static void vs_dc8200_primary_plane_disable_ex(struct vs_dc *dc, unsigned = int output) +{ + regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), + VSDC_FB_CONFIG_EX_FB_EN); + + vs_dc8200_plane_commit(dc, output); +} + +static void vs_dc8200_primary_plane_update_ex(struct vs_dc *dc, unsigned i= nt output, + struct drm_plane_state *state) +{ + regmap_write(dc->regs, VSDC_FB_TOP_LEFT(output), + VSDC_MAKE_PLANE_POS(state->crtc_x, state->crtc_y)); + regmap_write(dc->regs, VSDC_FB_BOTTOM_RIGHT(output), + VSDC_MAKE_PLANE_POS(state->crtc_x + state->crtc_w, + state->crtc_y + state->crtc_h)); + regmap_write(dc->regs, VSDC_FB_BLEND_CONFIG(output), + VSDC_FB_BLEND_CONFIG_BLEND_DISABLE); + + vs_dc8200_plane_commit(dc, output); +} + +static u32 vs_dc8200_irq_ack(struct vs_dc *dc) +{ + u32 hw_irqs, unified =3D 0, known =3D 0; + unsigned int i; + + regmap_read(dc->regs, VSDC_TOP_IRQ_ACK, &hw_irqs); + + for (i =3D 0; i < VSDC_MAX_OUTPUTS; i++) { + known |=3D VSDC_TOP_IRQ_VSYNC(i); + if (hw_irqs & VSDC_TOP_IRQ_VSYNC(i)) + unified |=3D VSDC_IRQ_VSYNC(i); + } + + drm_WARN_ONCE(&dc->drm_dev->base, hw_irqs & ~known, + "Unknown hardware IRQ bits: %#x\n", hw_irqs & ~known); + + return unified; +} + +const struct vs_dc_funcs vs_dc8200_funcs =3D { + .panel_enable_ex =3D vs_dc8200_panel_enable_ex, + .panel_disable_ex =3D vs_dc8200_panel_disable_ex, + .enable_vblank =3D vs_dc8200_enable_vblank, + .disable_vblank =3D vs_dc8200_disable_vblank, + .primary_plane_enable_ex =3D vs_dc8200_primary_plane_enable_ex, + .primary_plane_disable_ex =3D vs_dc8200_primary_plane_disable_ex, + .primary_plane_update_ex =3D vs_dc8200_primary_plane_update_ex, + .irq_ack =3D vs_dc8200_irq_ack, +}; diff --git a/drivers/gpu/drm/verisilicon/vs_drm.c b/drivers/gpu/drm/verisil= icon/vs_drm.c index fd259d53f49f1..24e9d0b008f31 100644 --- a/drivers/gpu/drm/verisilicon/vs_drm.c +++ b/drivers/gpu/drm/verisilicon/vs_drm.c @@ -25,7 +25,6 @@ #include "vs_bridge.h" #include "vs_crtc.h" #include "vs_dc.h" -#include "vs_dc_top_regs.h" #include "vs_drm.h" =20 #define DRIVER_NAME "verisilicon" @@ -168,8 +167,8 @@ void vs_drm_handle_irq(struct vs_dc *dc, u32 irqs) unsigned int i; =20 for (i =3D 0; i < dc->identity.display_count; i++) { - if (irqs & VSDC_TOP_IRQ_VSYNC(i)) { - irqs &=3D ~VSDC_TOP_IRQ_VSYNC(i); + if (irqs & VSDC_IRQ_VSYNC(i)) { + irqs &=3D ~VSDC_IRQ_VSYNC(i); if (dc->drm_dev->crtcs[i]) drm_crtc_handle_vblank(&dc->drm_dev->crtcs[i]->base); } diff --git a/drivers/gpu/drm/verisilicon/vs_drm.h b/drivers/gpu/drm/verisil= icon/vs_drm.h index 606338206a427..6a89c20879df7 100644 --- a/drivers/gpu/drm/verisilicon/vs_drm.h +++ b/drivers/gpu/drm/verisilicon/vs_drm.h @@ -6,6 +6,7 @@ #ifndef _VS_DRM_H_ #define _VS_DRM_H_ =20 +#include #include #include =20 @@ -13,6 +14,13 @@ =20 struct vs_dc; =20 +/* + * DC variants use different interrupt registers with diverging bit + * assignments; each irq_ack() implementation must translate its + * hardware-specific bits into these definitions. + */ +#define VSDC_IRQ_VSYNC(n) BIT(n) + struct vs_drm_dev { struct drm_device base; =20 diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.c b/drivers/gpu/drm/verisi= licon/vs_hwdb.c index 2a0f7c59afa3a..91524d16f7785 100644 --- a/drivers/gpu/drm/verisilicon/vs_hwdb.c +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.c @@ -94,6 +94,7 @@ static struct vs_chip_identity vs_chip_identities[] =3D { .revision =3D 0x5720, .customer_id =3D ~0U, =20 + .generation =3D VSDC_GEN_DC8200, .display_count =3D 2, .max_cursor_size =3D 64, .formats =3D &vs_formats_no_yuv444, @@ -103,6 +104,7 @@ static struct vs_chip_identity vs_chip_identities[] =3D= { .revision =3D 0x5721, .customer_id =3D 0x30B, =20 + .generation =3D VSDC_GEN_DC8200, .display_count =3D 2, .max_cursor_size =3D 64, .formats =3D &vs_formats_no_yuv444, @@ -112,6 +114,7 @@ static struct vs_chip_identity vs_chip_identities[] =3D= { .revision =3D 0x5720, .customer_id =3D 0x310, =20 + .generation =3D VSDC_GEN_DC8200, .display_count =3D 2, .max_cursor_size =3D 64, .formats =3D &vs_formats_with_yuv444, @@ -121,6 +124,7 @@ static struct vs_chip_identity vs_chip_identities[] =3D= { .revision =3D 0x5720, .customer_id =3D 0x311, =20 + .generation =3D VSDC_GEN_DC8200, .display_count =3D 2, .max_cursor_size =3D 64, .formats =3D &vs_formats_no_yuv444, diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.h b/drivers/gpu/drm/verisi= licon/vs_hwdb.h index 2065ecb730437..a15c8b5656044 100644 --- a/drivers/gpu/drm/verisilicon/vs_hwdb.h +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.h @@ -9,6 +9,11 @@ #include #include =20 +enum vs_dc_generation { + VSDC_GEN_DC8000, + VSDC_GEN_DC8200, +}; + struct vs_formats { const u32 *array; unsigned int num; @@ -19,6 +24,7 @@ struct vs_chip_identity { u32 revision; u32 customer_id; =20 + enum vs_dc_generation generation; u32 display_count; /* * The hardware only supports square cursor planes, so this field diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c b/drivers/gpu/d= rm/verisilicon/vs_primary_plane.c index 20a820f1ef302..0d7c6f424079b 100644 --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c @@ -54,12 +54,6 @@ static int vs_primary_plane_atomic_check(struct drm_plan= e *plane, return 0; } =20 -static void vs_primary_plane_commit(struct vs_dc *dc, unsigned int output) -{ - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), - VSDC_FB_CONFIG_EX_COMMIT); -} - static void vs_primary_plane_atomic_enable(struct drm_plane *plane, struct drm_atomic_commit *atomic_state) { @@ -70,13 +64,8 @@ static void vs_primary_plane_atomic_enable(struct drm_pl= ane *plane, unsigned int output =3D vcrtc->id; struct vs_dc *dc =3D vcrtc->dc; =20 - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), - VSDC_FB_CONFIG_EX_FB_EN); - regmap_update_bits(dc->regs, VSDC_FB_CONFIG_EX(output), - VSDC_FB_CONFIG_EX_DISPLAY_ID_MASK, - VSDC_FB_CONFIG_EX_DISPLAY_ID(output)); - - vs_primary_plane_commit(dc, output); + if (dc->funcs->primary_plane_enable_ex) + dc->funcs->primary_plane_enable_ex(dc, output); } =20 static void vs_primary_plane_atomic_disable(struct drm_plane *plane, @@ -89,10 +78,8 @@ static void vs_primary_plane_atomic_disable(struct drm_p= lane *plane, unsigned int output =3D vcrtc->id; struct vs_dc *dc =3D vcrtc->dc; =20 - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), - VSDC_FB_CONFIG_EX_FB_EN); - - vs_primary_plane_commit(dc, output); + if (dc->funcs->primary_plane_disable_ex) + dc->funcs->primary_plane_disable_ex(dc, output); } =20 static void vs_primary_plane_atomic_update(struct drm_plane *plane, @@ -138,18 +125,11 @@ static void vs_primary_plane_atomic_update(struct drm= _plane *plane, regmap_write(dc->regs, VSDC_FB_STRIDE(output), fb->pitches[0]); =20 - regmap_write(dc->regs, VSDC_FB_TOP_LEFT(output), - VSDC_MAKE_PLANE_POS(state->crtc_x, state->crtc_y)); - regmap_write(dc->regs, VSDC_FB_BOTTOM_RIGHT(output), - VSDC_MAKE_PLANE_POS(state->crtc_x + state->crtc_w, - state->crtc_y + state->crtc_h)); regmap_write(dc->regs, VSDC_FB_SIZE(output), VSDC_MAKE_PLANE_SIZE(state->crtc_w, state->crtc_h)); =20 - regmap_write(dc->regs, VSDC_FB_BLEND_CONFIG(output), - VSDC_FB_BLEND_CONFIG_BLEND_DISABLE); - - vs_primary_plane_commit(dc, output); + if (dc->funcs->primary_plane_update_ex) + dc->funcs->primary_plane_update_ex(dc, output, state); } =20 static const struct drm_plane_helper_funcs vs_primary_plane_helper_funcs = =3D { --=20 2.43.0 From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pj2-f32.google.com (mail-pj2-f32.google.com [74.125.227.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A9E3C1D5E for ; Fri, 18 Sep 2026 03:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.160 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700513; cv=none; b=eTZwXxQSnaYpuuR/d0K1dC8ubNWtFebhS/RwY/ciPYVah5Z0RCJfIXpRK1E0APZDfbrSYzIxbVmP8uIkKsm0KiwBqnXSDGCzCi0lCum86oMOiBlT4NTrxhvm68eahneoFsrgEYO1wVBaiFygCNsUmf3nzRY5IoQy2yJiIc7KRe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700513; c=relaxed/simple; bh=TOT2KHfl2DUHhJTWzsm37Dsjh4xTuhAz0zDPlGY/foU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JZlaxfrlworuykGRP8oPhAuwDMeSEpvI8R1Kte0c/kH54f/37EP/foO6nHZpclJDIO6c1QyZAfwAcULz4bB3lcAGcbUoK8bHg54ZKnRp6AhHwvb3/d/HdNXxj00EPBpKmkJx0S/m+guRgLqtr4eC5FC9xRMv4qeJ88gmciLZ1xM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sNw7f4Iy; arc=none smtp.client-ip=74.125.227.160 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sNw7f4Iy" Received: by mail-pj2-f32.google.com with SMTP id d9443c01a7336-2d747f05ffdso1809775ad.1 for ; Thu, 17 Sep 2026 20:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700508; x=1790305308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=toYt9rYplhPBNw8uYg7TjR1uc/+s1ghvN6xnP+MGyco=; b=sNw7f4IyXME6yLcOY2shpas2cRDyc8Smcl0ICezCYTOX074TvUb+bGMqHBf3lZdWG9 CHqO4TyBBCSwFaKKIzApbug5R29+VJREUsTGXBDeD+hFgi3tz9J1Yc77s+XNbioTDPik q5pdGS6dhwtEZomsnGitzYmobepgr4l3FoEHgM+2BiWkwGaUSsVMTGYlL77W6WObKZxy klavGEXxorTP+CwVFswkSiECQB1zhB5ZlLQ1d3fV3GnIqbflrxLiZmF9FPvutR2GGrrT 8FA0dysKx4+MziKZ45poG1OVhXRVqHxHurjE0QzdLNnFj8BzX9buZR0F7MiwmYn1z0hD nX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700508; x=1790305308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=toYt9rYplhPBNw8uYg7TjR1uc/+s1ghvN6xnP+MGyco=; b=0CrwPiYo12MxPTo4U/XoQTK1edeKGMwbFIaj48tAITSsklAVf2gsfax2RP/wdpOxbf p1v8slFm9VZNk11Zkn4wGkKcGivjr6QwC9l9IGF2K9MnIQY8s+2gnAlXwim44ZEUKjtI EOhh91EhcvuiqyGe+4WyGFGMaqasZkaVdMzHwNPDAFqVRa0tBromT8TqFshJPJhv+ugN +0ezMjN6X7WhDlekjFnnZyiIcOKCDxQh4eBQrAynBW8tRCZ5z/3WPdJGjgllOadjtnX8 lGof0npbPy1o9EQEkngwWNE+kvkOH2883KruNdNdYxvPvq+7vggH8XjgHeVdjGIGWeRO dOsQ== X-Forwarded-Encrypted: i=1; AKwUvBwEeut9dH5Yeil8++NFwKxxIIfuFGbCjI0I0n46/s0j0S7362mgqFIe6Iod5k4VthjT4oAWkcxnbZ8wUMs=@vger.kernel.org X-Gm-Message-State: AFuF++knnfBk7H3pEtgh81S5rW3hVoxtQaHQxkSoxNeNCcDxx4nLYJ+f XLzBARSwzw7oFGHbes08rk5NHV8yD6F/iaN2Mfkil7Q4hHQA93rp+AmS X-Gm-Gg: AYBFou01Nqn9op+DH5Z/rKZzYcZUWYLhxn4+2OYbrweedJGv10s/Cx+RNdaxIplPECt gop3EIuo3/XMjNPc73gtBFLly0ZxCkwtzJiPdFdnqJuKXZ5bTfAEeHMY+qGWY4HU/TUezb6LF69 1wNEJlaTVb61qa9qwK2fvIlXGOs+qRRvK7tEIOYBdPyqgpjHETOseZvaIOMq4Nsbcl60tZ/6Yam a3mbrxk41OdGorE0zKREYTrMBctSntFFu1+L1npg8JMAATHYzwovrvU3Fh0hD7BH8GFb5SnPtBR YBFMkMNE1WvyorkpB1B4o3vvImoyL4os1HKji2+0GamcMjQPwz8N7zeM7G5UdQGEJNsEhi4DnR4 yNUhwxhq0PQ3IkJCWUkjccIStMOAOcTs/PEawRlzlJ9FYel4OO9KWXHnrU7NUK8iCyJhcntZGJz 8RRHaz4xwYx8+8f7NXF8i7r8S/H6/uZxypW4E9xdri3WmkXD+74Eq/fjZ+rEOJN1sXU2zLJL96i pBC1fTa1dDJ2gixhFqvuNsv+Bi8J8mufkQ7vsevzwNKmeewk+DNnivYYxelGsg= X-Received: by 2002:a17:90b:52cf:b0:398:9c39:520f with SMTP id 98e67ed59e1d1-39e54bd0941mr2537352a91.15.1789700508027; Thu, 17 Sep 2026 20:01:48 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:47 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v7 4/7] drm/verisilicon: add DC8000 (DCUltraLite) display controller support Date: Fri, 18 Sep 2026 11:01:22 +0800 Message-ID: <20260918030125.315978-5-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Verisilicon DC IP family also ships in a DCUltraLite (DC8000 generation) configuration that lacks the DC8200's CONFIG_EX staging registers and PANEL_START sync register, and exposes its VSYNC interrupt through a differently laid out status/enable register pair. Add a vs_dc_funcs implementation for the DC8000 generation in vs_dc8000.c: framebuffer updates are latched directly through FB_CONFIG's enable/reset/valid bits instead of a staging commit, panel output starts as soon as PANEL_CONFIG.RUNNING is set with no separate sync register to arm, and the VSYNC interrupt is acknowledged through DISP_IRQ_STA/DISP_IRQ_EN. Select this vtable in the probe path based on the chip identity's generation field. Signed-off-by: Joey Lu Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/verisilicon/Makefile | 2 +- drivers/gpu/drm/verisilicon/vs_dc.c | 5 +- drivers/gpu/drm/verisilicon/vs_dc.h | 1 + drivers/gpu/drm/verisilicon/vs_dc8000.c | 92 +++++++++++++++++++++++++ 4 files changed, 98 insertions(+), 2 deletions(-) create mode 100644 drivers/gpu/drm/verisilicon/vs_dc8000.c diff --git a/drivers/gpu/drm/verisilicon/Makefile b/drivers/gpu/drm/verisil= icon/Makefile index 9d4cd16452fa1..d2fd8e4dff242 100644 --- a/drivers/gpu/drm/verisilicon/Makefile +++ b/drivers/gpu/drm/verisilicon/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only =20 -verisilicon-dc-objs :=3D vs_bridge.o vs_crtc.o vs_dc.o vs_dc8200.o vs_drm.= o vs_hwdb.o \ +verisilicon-dc-objs :=3D vs_bridge.o vs_crtc.o vs_dc.o vs_dc8200.o vs_dc80= 00.o vs_drm.o vs_hwdb.o \ vs_plane.o vs_primary_plane.o vs_cursor_plane.o =20 obj-$(CONFIG_DRM_VERISILICON_DC) +=3D verisilicon-dc.o diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisili= con/vs_dc.c index 9729b693d360e..3e9e2c0264f5d 100644 --- a/drivers/gpu/drm/verisilicon/vs_dc.c +++ b/drivers/gpu/drm/verisilicon/vs_dc.c @@ -134,7 +134,10 @@ static int vs_dc_probe(struct platform_device *pdev) dev_info(dev, "Found DC%x rev %x customer %x\n", dc->identity.model, dc->identity.revision, dc->identity.customer_id); =20 - dc->funcs =3D &vs_dc8200_funcs; + if (dc->identity.generation =3D=3D VSDC_GEN_DC8200) + dc->funcs =3D &vs_dc8200_funcs; + else + dc->funcs =3D &vs_dc8000_funcs; =20 if (port_count > dc->identity.display_count) { dev_err(dev, "too many downstream ports than HW capability\n"); diff --git a/drivers/gpu/drm/verisilicon/vs_dc.h b/drivers/gpu/drm/verisili= con/vs_dc.h index 825f5dd6bf174..ac96ad7011994 100644 --- a/drivers/gpu/drm/verisilicon/vs_dc.h +++ b/drivers/gpu/drm/verisilicon/vs_dc.h @@ -66,5 +66,6 @@ struct vs_dc { }; =20 extern const struct vs_dc_funcs vs_dc8200_funcs; +extern const struct vs_dc_funcs vs_dc8000_funcs; =20 #endif /* _VS_DC_H_ */ diff --git a/drivers/gpu/drm/verisilicon/vs_dc8000.c b/drivers/gpu/drm/veri= silicon/vs_dc8000.c new file mode 100644 index 0000000000000..df7bd5bdd7f2a --- /dev/null +++ b/drivers/gpu/drm/verisilicon/vs_dc8000.c @@ -0,0 +1,92 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2026 Joey Lu + */ + +#include + +#include + +#include "vs_crtc_regs.h" +#include "vs_dc.h" +#include "vs_drm.h" +#include "vs_primary_plane_regs.h" + +static void vs_dc8000_panel_enable_ex(struct vs_dc *dc, unsigned int outpu= t) +{ + regmap_set_bits(dc->regs, VSDC_FB_CONFIG(output), + VSDC_FB_CONFIG_RESET); +} + +static void vs_dc8000_panel_disable_ex(struct vs_dc *dc, unsigned int outp= ut) +{ + regmap_clear_bits(dc->regs, VSDC_FB_CONFIG(output), + VSDC_FB_CONFIG_RESET); +} + +static void vs_dc8000_crtc_begin(struct vs_dc *dc, unsigned int output) +{ + regmap_set_bits(dc->regs, VSDC_FB_CONFIG(output), + VSDC_FB_CONFIG_VALID); +} + +static void vs_dc8000_crtc_flush(struct vs_dc *dc, unsigned int output) +{ + regmap_clear_bits(dc->regs, VSDC_FB_CONFIG(output), + VSDC_FB_CONFIG_VALID); +} + +static void vs_dc8000_crtc_enable_ex(struct vs_dc *dc, unsigned int output) +{ + regmap_set_bits(dc->regs, VSDC_FB_CONFIG(output), + VSDC_FB_CONFIG_ENABLE); +} + +static void vs_dc8000_crtc_disable_ex(struct vs_dc *dc, unsigned int outpu= t) +{ + regmap_clear_bits(dc->regs, VSDC_FB_CONFIG(output), + VSDC_FB_CONFIG_ENABLE); +} + +static void vs_dc8000_enable_vblank(struct vs_dc *dc, unsigned int output) +{ + regmap_set_bits(dc->regs, VSDC_DISP_IRQ_EN, + VSDC_DISP_IRQ_VSYNC(output)); +} + +static void vs_dc8000_disable_vblank(struct vs_dc *dc, unsigned int output) +{ + regmap_clear_bits(dc->regs, VSDC_DISP_IRQ_EN, + VSDC_DISP_IRQ_VSYNC(output)); +} + +static u32 vs_dc8000_irq_ack(struct vs_dc *dc) +{ + u32 hw_irqs, unified =3D 0, known =3D 0; + unsigned int i; + + regmap_read(dc->regs, VSDC_DISP_IRQ_STA, &hw_irqs); + + for (i =3D 0; i < VSDC_MAX_OUTPUTS; i++) { + known |=3D VSDC_DISP_IRQ_VSYNC(i); + if (hw_irqs & VSDC_DISP_IRQ_VSYNC(i)) + unified |=3D VSDC_IRQ_VSYNC(i); + } + + drm_WARN_ONCE(&dc->drm_dev->base, hw_irqs & ~known, + "Unknown hardware IRQ bits: %#x\n", hw_irqs & ~known); + + return unified; +} + +const struct vs_dc_funcs vs_dc8000_funcs =3D { + .panel_enable_ex =3D vs_dc8000_panel_enable_ex, + .panel_disable_ex =3D vs_dc8000_panel_disable_ex, + .crtc_begin =3D vs_dc8000_crtc_begin, + .crtc_flush =3D vs_dc8000_crtc_flush, + .crtc_enable_ex =3D vs_dc8000_crtc_enable_ex, + .crtc_disable_ex =3D vs_dc8000_crtc_disable_ex, + .enable_vblank =3D vs_dc8000_enable_vblank, + .disable_vblank =3D vs_dc8000_disable_vblank, + .irq_ack =3D vs_dc8000_irq_ack, +}; --=20 2.43.0 From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D1BF3E315C for ; Fri, 18 Sep 2026 03:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700518; cv=none; b=sIbPPSYpqvLebJ+dNPDzm/4utV0auJRzZf7yi7gY63RLD1zv6BknPpgQLi3/VtzNlwULGhxVMfoIkNP5yDr5e94VsLDtGFyNlCYI8vZ8VnPpufo9WNbDy+pe0BRRGxq/2+q9AG+rYbidOW5GdK08Sg/jcvwXyOR7nJeB6OyGEg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700518; c=relaxed/simple; bh=HlGrFMsRs0IybKeXdKiG9q5NJ5arwAx2J4jsvINPDaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PtDvTjZP8Jwg/mQhPnqfTkbv/s/hyuEy2rmz7FRfK3K24AdKy/qnnsgKpqGRn42bocVFzyeyRISRg9tmlPCgLr/4oWzTjS6C4+VLcwqtQZ6kW5luF9aFaqO6gqNe7gsfJOHyG0bQ99B2OyBnUp5e1oEz11QBYJPuv+R5L5t1VMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DRkiIS+1; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DRkiIS+1" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2db710396ffso11323635ad.1 for ; Thu, 17 Sep 2026 20:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700511; x=1790305311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QPg1uLKI5p/H7J2E4b3w0DPqeVInWxkk5y+GYwVR13I=; b=DRkiIS+1AA1E2XXOJGwHEWECM9r16Zcs/SY7sOH7qpRyMQgZn9wowaUdo6Z4v2jRVB 8ClCAeoZX1X23Iva2i6zy00DeEXVXFz3JyCnCUShTbbjEEg8p3nBPlOMdO4KL8de0oCJ vswx3kNwfUuLRhsoY8S9hYhD/BS3v02JLxdoBuklZbutVFGJtKMpIXUT8vax6VeFH7CV IXW/2B8JVjXqs5RTTHTwc4O2xOa9y+sruLg9nZDW16m35EWZjvLtPJw8rkXPi/DcK2CX xZcJCz8m4NV9OWgfo1Z67O55FLEc5q7jGRJIS/B6dwAmzJXWIaHEMmI3tQ74YX5T0/Kw Pg+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700511; x=1790305311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QPg1uLKI5p/H7J2E4b3w0DPqeVInWxkk5y+GYwVR13I=; b=loyiBYTAwsNfsKa21Q/Vv7wvl0Rf7J7HZnTYgbIBCtIm50pYF6YHrVXiaEryuBw+pC vdxp2R7N8owoL2hTOsXOKWqokTbwoZHveW59zKJBoOoEo2RIcNHtVscqP70Xf8bH6MuR KWvxkmO//0jqBhA20Fo2hVRA4I4guCguNuUdoPH2yaW0Co0S6LHXyg4Zdc3vzYrF/+x5 9F+a8euS3RgkoF6WAbRKvlEHdtmyE256/q6E519ap4CwTmc4EEc/jJUlO/AczGJigy3b ZEc25vWWk07VN/RDoME0NOcpEc76ovTsThK6Y+kjsQx4t5ZWTbJrxxHz93N3wh/uytk/ n9ow== X-Forwarded-Encrypted: i=1; AKwUvByBW56nznxOrN5tKUXh+yZNywFhGDJ9YjJ0ftzAkPoYgz/HIQF4X+CbHvfJ7NM76L8TWtQ4dtKbWboS8a4=@vger.kernel.org X-Gm-Message-State: AFuF++nK8EqJ7EjMHOlmb/pKGK23gFs2x7zOUKMWsRpk2zID1zh0DGm7 Fk2g6GvJIC9kkxSeA4+8Pt4fRuu24HqubSkQ5AGG4620ZQzl3Ft5Jbg0 X-Gm-Gg: AYBFou28UucuCVawk13fFo29MG2rWadGhApPbFJUj4iSWGjjFa3TuC6RwGE1Yd6QIOF 4er/DCuyoD7BqUNgUydN8QvqTVYfuZ7PrXaHkhZ10d/Rg9ep+GnQTL2chFBzohaV8vU3uOEqA5w 9rxhnCUDQGaWqJlxQALgv3/iFNgAgPS2FPt3pY1FBZWadaI169GNYKojUtjYT0Fztd1dHMK35ZC CyUSSKhky04xfdSoL1MPzJf9DE/fOrDtHqP+JF/JdgYNEvGjF3lKpd+0LEf3QDZJKI7V0dBBsVo F6xmP4c4tCKzREFCq8zfvvMGaMuNQFB4OJ90B0Npu+RGeu6OW3J+Y49NymOQJWSBUBu3PHPA7xT uIank4G2/bDsyIfG4B2R7p165RJT0NLndB7IB1gAAAbB4MWlf4k/F6QWyafTn4/Xrnh1Y/IZnCL 8azNwIMizTExT+RLBAyB8AYsdqjVN1aXDGW1Vvm5QqL5p8rO+vmqD7kFKUKQhC8D4LKicasmDWQ VdwjPuQtsbRkA+oDNqsWDSWKcKJRVvXpbX7/zpl9P1wcZa+J7+gmvN4LHIjvwK2f7uzsupO1g== X-Received: by 2002:a17:90b:3f0d:b0:39e:2c5c:a689 with SMTP id 98e67ed59e1d1-39e361ab7dbmr7741778a91.30.1789700511242; Thu, 17 Sep 2026 20:01:51 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:50 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v7 5/7] drm/verisilicon: add DCUltraLite chip identity to HWDB Date: Fri, 18 Sep 2026 11:01:23 +0800 Message-ID: <20260918030125.315978-6-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Nuvoton MA35D1 chip contains a DCUltraLite display controller with model number 0x0 (sic, the model name contains no number either), revision 0x5560 and customer ID 0x305. It has a similar register map with DC8000, only one display output and only 32x32 cursor supported. Signed-off-by: Joey Lu Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/verisilicon/vs_hwdb.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.c b/drivers/gpu/drm/verisi= licon/vs_hwdb.c index 91524d16f7785..7d630a667a3f0 100644 --- a/drivers/gpu/drm/verisilicon/vs_hwdb.c +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.c @@ -129,6 +129,16 @@ static struct vs_chip_identity vs_chip_identities[] = =3D { .max_cursor_size =3D 64, .formats =3D &vs_formats_no_yuv444, }, + { + .model =3D 0x0, /* DCUltraLite */ + .revision =3D 0x5560, + .customer_id =3D 0x305, + + .generation =3D VSDC_GEN_DC8000, + .display_count =3D 1, + .max_cursor_size =3D 32, + .formats =3D &vs_formats_no_yuv444, + }, }; =20 int vs_fill_chip_identity(struct regmap *regs, --=20 2.43.0 From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45B4D3D8907 for ; Fri, 18 Sep 2026 03:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700521; cv=none; b=Nm7VUZoFGd1jX26+VbDLiy17LW5atXHdzewJGcX/MNLoUay9/s1d1qaw/LtUjXORGSnwQxsZseDaR+NuarfqiorpdMMC4uS2QSKv+iraPWMTQbDkEAhJa4zKsIQjVr1RCOSiCUdCn6+V3sfBI1fvjDSe5ptMB+fYSRliHOA4YFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700521; c=relaxed/simple; bh=ozasnFIBA+8rSKDPSKbh/3Fbquovn2x4fV8LNqAL7Kg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LkbOdJiM8usrlZKakh0BlylT7hJWXEjQgrIUqzvm7phUlC6IxnG/tQrERFpECbeH3QqvhiZu0CmV1PxL3/aq4GAYmMxHxZaggyo51dbk5eEy+IEjAH/QpBkIC7iH0+D5HPofNmUEWF+Qi+ew/gSQQ+pdXbdAXxvUWxRX2i7l2kk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I+PQoGRV; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I+PQoGRV" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2d91c22d27dso1461295ad.1 for ; Thu, 17 Sep 2026 20:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700515; x=1790305315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0r+H74wyT2+5oikV/msCZxyt9ampGlRBgpuDqDj2ToI=; b=I+PQoGRV1Br3ZLg8K13kEe7VKD07jxw1ByTISEUsh82Mrqyx7hJx21kFQpl91BRPPv 0OZIoI9Tn1Do1DSM2uKGzgcHrTBF2UWIKZs6n8GsDK+gpeaaOj7anQ4jNX7ks4T7vDNN Re7fv0YP1yZczHs2WEKjSX8+5R1UFWu2NMnS+P/thhwE98/yFivCglW5Cm9vCoclK/z/ etedSCC4/Qjwovlf17SwFRf8kLqkk4BNG+rX1f3UaGWjd9AiVzw79YKgqzwZhOcVJGpG HO9k6oXUq7xlXrESlY7tBkxI7HN4Aml0By9zGdjt0WPser8kqPhOix54oueJ0NcKCDzr tyOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700515; x=1790305315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0r+H74wyT2+5oikV/msCZxyt9ampGlRBgpuDqDj2ToI=; b=jZG/DhbFo6+mYKuy9PrRQv0jbmqmwYlUlCKkcIKi11sd2phNP7XeAM8WiISAJjAiHt wTTTr2MHG+gDh/zce0PNxrLVQ8UyKD8bp/kUM3Dme2xVakJUEl9Uihc3GJBNdfEggvkS Vr0Kwp0e691b9v0FaTMvWQh1c+hSnexKwcePF1NG7TpYr6FQqJpx66yz5N/fb5xMRIr5 +FB4Q1mB9Sz0LQGt3WLggF8S85pfacHJ4FksU2qsgnKlDkra+eGd4CIIdeD8XpHfkrAS naKhc4xkj3nznzVWP4x4UK1qMjHBbEA/NG2pLGNYdTspqAPnXHXfnkrui/XbtjiHmtPd yK7A== X-Forwarded-Encrypted: i=1; AKwUvBxbQr4ONwO88X8XJ3zxN37uUo6xMSMunyltLtz3KqRRqR+7EC3Qpn6UXD7NbsmYAkV5o+5d2ACU4sGawWQ=@vger.kernel.org X-Gm-Message-State: AFuF++miimWYx4GHbL4BgwmFRRrmMOY7jDQBNBauOxZq2mibraI/KJ9A qR5TkaBR06TKFnnNN2ljNsg1tNW6lQzKrHXMdp7G/k8D0026SU3TU2Jl X-Gm-Gg: AYBFou3n3kkAjHGZDmHvjChyUKn8Q8AHBSHsbjLEE0apqXWYGp7R3aWV/oW4W8o1pLq 7Wqhd8byby3U222z0m7yP0EuyqN8KU0bKNZeHmiZFzvuYLJ2coqkPNzqGeWgNAjyrFtYsjb1hPL 2JYrWzDW0HyP3tJRBW37L30yc5S4cpQFOm2pmEJbOOhzH2frWWSNzAzVOyUqeBF7nhIELOe6YG/ 742yEgaxQd23rnDJzJy5IekHn+GxePem2SSOZxFImwF56VR+QE7WGsfwJ9gjmd3DE0tC8T5hOID JKjSDJ5aTr1d/YFEicttzFbS52IbFe7FA2j1NA40yx4GZ6avsvZr0V/V3bBpCRR6e06RLs7xppI m1w/2wPwJ0GE+bH027y4fJDc3irCYh+Esd/WnqBSI/K26T2G39wEXHR7/LI+RVhj7yaR6FRpEUh CK0YpOqUpaeDhROvbUvnqgotLUASZHVdqxq6BjUs2Mi7ZePze8G2AiVrjIFgyuuFfqJ83Ch7LJB zHc73YgrU1gyr4oocvYsvULRsKQ1TvkyRDpf9rsc3rR7ELfqiaHy8sHFWoQlj0= X-Received: by 2002:a17:90b:4b87:b0:39e:345b:3323 with SMTP id 98e67ed59e1d1-39e54fb121dmr2271373a91.22.1789700514999; Thu, 17 Sep 2026 20:01:54 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:54 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v7 6/7] drm/verisilicon: extend Kconfig to support ARCH_MA35 platforms Date: Fri, 18 Sep 2026 11:01:24 +0800 Message-ID: <20260918030125.315978-7-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add ARCH_MA35 to the platform dependencies to allow the driver to be built for Nuvoton MA35D1. Signed-off-by: Joey Lu Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/verisilicon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/verisilicon/Kconfig b/drivers/gpu/drm/verisili= con/Kconfig index 7cce86ec8603c..295d246eb4b40 100644 --- a/drivers/gpu/drm/verisilicon/Kconfig +++ b/drivers/gpu/drm/verisilicon/Kconfig @@ -2,7 +2,7 @@ config DRM_VERISILICON_DC tristate "DRM Support for Verisilicon DC-series display controllers" depends on DRM && COMMON_CLK - depends on RISCV || COMPILE_TEST + depends on RISCV || ARCH_MA35 || COMPILE_TEST select DRM_BRIDGE_CONNECTOR select DRM_CLIENT_SELECTION select DRM_DISPLAY_HELPER --=20 2.43.0 From nobody Fri Sep 25 00:40:13 2026 Received: from mail-pz2-f30.google.com (mail-pz2-f30.google.com [74.125.228.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F48B3BD64D for ; Fri, 18 Sep 2026 03:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.30 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700524; cv=none; b=Amvl6q/hAGrup4fKZOh1eUlvfDeFmYM0kdhHBE3oIZxXs3Kg0l9Y0fd2n13pJMnr84UJcZq8XO14QNwqHG8oHEDOK4Tn0wLdGIIXn+pT5VVlWHLRzl2KpRI6giqc/woEPJfG8BIn/mpAeInOlOGnivempmifNuGWBqVBTLTQIxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700524; c=relaxed/simple; bh=2fOXWQ+D606ZEtKoesxi3yPFiMCtrfZbrG+MPby33tU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u49WaQBg0esooieolNbxIeSF9SrPQA5NCfnw57IOaun+EblfUkN6g25+AZwGXFP3X5M+cYPhXUiLYuq5IQGl54F2MuDCGKxM7DikByG0h3Wf0mjoGMLVxaXZ0QO/3U8u4kyb1naecfdeNzt+F/NTgtJs4EuNWsX/2Xisj8Xy4d0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JsKRVJnd; arc=none smtp.client-ip=74.125.228.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JsKRVJnd" Received: by mail-pz2-f30.google.com with SMTP id 41be03b00d2f7-cc1cea50dc0so68853a12.2 for ; Thu, 17 Sep 2026 20:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789700518; x=1790305318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f70EL2u57AlsQGuy6taCWBcjNOQfxHMXhBaDu9pSD1s=; b=JsKRVJndOYWb2b+t2ClORDriyvRVT4cWddvK9hMcag6logGlpJEFu5AKTR37yKinZo WWpOa/deBeB/nqKQSM12VL8XHgRlKu8jvA4ugBKwoNKKcEPVz/MfmNGKiBnPDpSQ9R9H iO7NaAYUxIJjjxl3ISTL73nENkwZY8AZF58nVBO43lxyhTgxpHeGEBM8ilv0eFZQvGA7 yfFGGUzFV1HYOUmzwUW4Gqb3FU99SY+r16kNto6awkiv74K29qIaFyLb728rbxaB/HDe 4nMEd0Zaz20tcJvEYruah+FQWNSyaHKVNtJJNkkGdHmDcdv/VGbovwCy4oXApRdZrbJk AXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700518; x=1790305318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=f70EL2u57AlsQGuy6taCWBcjNOQfxHMXhBaDu9pSD1s=; b=S2iicdQG6gLQKraQ2vMSsUdYvU0vczQBQvM+u8hLM1xxs77PAxqH/mWxszc1gQwozn Emu0LsWVH06Mpjs5f5Z3qsDpcMd3Iqpqrgv3Tluf+sWWMFZKuuO9p7p3f8/SLJ0oTyjS CaLO87f9RoVUD9ALS2WCiVVomglhg4UUw1bwL+hgVzq7l0zeiSwkdWwqbZuP0Q8abKjv U7hyStFgKyoqz9IjXO/HxVXI4Ob8Z7RUac5cLi4Q4+m/coUUadW6dHC0T4TODyHwydZM gGqqB8BBGJNRaARDDZS+E/NGpIQTyknW76QVT2Oty1BQOt2LumkaIoEfwCreQpcbsg5G 7W9g== X-Forwarded-Encrypted: i=1; AKwUvByayXmAyqLbUgv9pVly3zo3ASL+JcIYjfhaihjmyskMNRlLNNVtUZ3APWXXlNUcd6w0x2JJK0OXIP3QNQA=@vger.kernel.org X-Gm-Message-State: AFuF++m4v0V7JBKJquCCrqUZ6nideXS4r9NHDd1WtkF26HtcoQClCS9f 2pBe7gLxmEXZG3ndXRIGk8Jw5EKWWc9neIf9Hc9PCZm9ezGSKbPUt7A4 X-Gm-Gg: AYBFou0Njm7kjMwMTl5inP17on7pGhIer/TrNH0vhJmhr5cWV3T2YXU3MbVmiirVEuv a+VRQO7YatMCRgA+z+VIPOd7vxuu5QWZiJOugs2X8036E4j/qvGos6ozPoie97k7JRpvL11wSQ/ TAo8SRajsafWOZtsXVRsxh9LOEgck0gXAsZK5DR69e21awc22iS2b8fG4exMfkja0nxuFLc4GzA 0C+SmmIcZtpCjptOL1bHa3gG5zOVDALplzZt5uVcUeTekvymkybyPmqn5i4MDgQWTZcGA3hOqGD 2KF2+weDCHVCS8nfyHkjB4YL0Qag7Sx2rzBkOKUcQbGSNBQ5j9fEZLXiBuG5m/T5j2xsymYBYH4 J2/5yGSd98AsP1sxGthFHf2N5IYWALPPmshrR9a/ThotlwfMn+H0GwxytWDkGTloaL09lmGKjAr 8EBMSb/6UIB3I0XHK1+QGW42F6o+NTlO3pf0fREtIMNHKoW14xGz2Tk27kskEDV0BInrGxNAgTJ XfXaes+Jj2uUiicRq7IYSfxSW5j5u0jAJlPr1xNzey7fWWjoI7oGzRnIL+/gRc= X-Received: by 2002:a17:90b:1644:b0:39e:2ea1:e2a9 with SMTP id 98e67ed59e1d1-39e54d8b0ecmr2306119a91.8.1789700518239; Thu, 17 Sep 2026 20:01:58 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e362e9402sm7969141a91.15.2026.09.17.20.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 20:01:57 -0700 (PDT) From: Joey Lu To: zhengxingda@iscas.ac.cn, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v7 7/7] drm/verisilicon: fix DC8200 primary plane disable clearing FB_EN Date: Fri, 18 Sep 2026 11:01:25 +0800 Message-ID: <20260918030125.315978-8-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918030125.315978-1-a0987203069@gmail.com> References: <20260918030125.315978-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vs_dc8200_primary_plane_disable_ex() calls regmap_set_bits() on VSDC_FB_CONFIG_EX_FB_EN instead of regmap_clear_bits(), so disabling the primary plane on DC8200-family hardware actually leaves the framebuffer enable bit instead of clearing it. This bug predates this series: it was carried over unchanged from vs_primary_plane_atomic_disable() when patch "drm/verisilicon: introduce per-variant hardware ops table" split the DC8200-specific implementation out into vs_dc8200.c. Fixes: dbf21777caa8 ("drm: verisilicon: add a driver for Verisilicon displa= y controllers") Signed-off-by: Joey Lu --- drivers/gpu/drm/verisilicon/vs_dc8200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/verisilicon/vs_dc8200.c b/drivers/gpu/drm/veri= silicon/vs_dc8200.c index f72da10295e1b..25b5906a1c5fc 100644 --- a/drivers/gpu/drm/verisilicon/vs_dc8200.c +++ b/drivers/gpu/drm/verisilicon/vs_dc8200.c @@ -70,8 +70,8 @@ static void vs_dc8200_primary_plane_enable_ex(struct vs_d= c *dc, unsigned int out =20 static void vs_dc8200_primary_plane_disable_ex(struct vs_dc *dc, unsigned = int output) { - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), - VSDC_FB_CONFIG_EX_FB_EN); + regmap_clear_bits(dc->regs, VSDC_FB_CONFIG_EX(output), + VSDC_FB_CONFIG_EX_FB_EN); =20 vs_dc8200_plane_commit(dc, output); } --=20 2.43.0