From nobody Fri Sep 25 01:20:33 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041674FC357; Thu, 17 Sep 2026 16:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789662496; cv=none; b=cSh1xKGLwhx6CRZzOYMMyvFqRrYr60QCSsqByoFPOAUpCrMO+K5OAucxtotm6UUoJ4on/ouFIMKR8S9Er2u4c8zr0aM22qr90eKHxZHseeHmWopnfPQHJMYb6Xq3KvvhBh7Mw9BHjYWo3TINcLhy2mlOaWjFAblRIvgvhvPNytI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789662496; c=relaxed/simple; bh=nNDgGkNsyak3INLqSjs87bT3wW9AIDdeVwjR5S+jSeU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=l44NhnK9+mpLK5tWVLYHZQdiUPzDnDXmS4dvoFxIn/TLjr/aIFwD1TOxDKOqHToEpbmwR+Wq16miHLXmKtp88a5Yp+N/efgj0KX809L6skbX9CUNeygosGXO5wAMtd1YtxosVYXleTD3k1XEOffsKiSpcnQp4I/N97T8kbO+9lg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAAHcz0XFaxqzXiECA--.47228S2; Fri, 18 Sep 2026 00:28:07 +0800 (CST) From: Wentao Liang To: amarkuze@redhat.com Cc: ceph-devel@vger.kernel.org, idryomov@gmail.com, jlayton@kernel.org, linux-kernel@vger.kernel.org, slava@dubeyko.com, xiubli@redhat.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] ceph: Fix mds session leak in __open_export_target_session() Date: Thu, 17 Sep 2026 16:28:07 +0000 Message-Id: <20260917162807.2162279-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAHcz0XFaxqzXiECA--.47228S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Wr1rurWkZFy5tr4rCr18AFb_yoWktrX_Cw 4Iqr1kWr15CrZ5Ca17Z3sIqrs2vas7Wr4fXr47Kr4IyFWrJFyDAr15Wa9Yyw1xuFWFgryr ZrnI93srKrn7ZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbs8Fc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280 aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r4UJwAS0I0E0xvYzxvE52 x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWU twAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI4 8JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0E wIxGrwCF04k20xvE74AGY7Cv6cx26r48ZrWUJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7VUbo5l5UUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwMNA2qr9thIAgAAsv Content-Type: text/plain; charset="utf-8" __open_export_target_session() holds a reference on the target session, either from __ceph_lookup_mds_session() or from register_session(), which the caller is expected to drop. When __open_session() fails, the helper returns ERR_PTR(ret) without dropping that reference, leaking one session reference on every open failure. Drop the session reference before returning the error. Fixes: b682c6d41bc2 ("ceph: switch to WARN_ON_ONCE in encode_supported_feat= ures()") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- fs/ceph/mds_client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index ed17e0023705..9d63152f95d4 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -1750,8 +1750,10 @@ __open_export_target_session(struct ceph_mds_client = *mdsc, int target) if (session->s_state =3D=3D CEPH_MDS_SESSION_NEW || session->s_state =3D=3D CEPH_MDS_SESSION_CLOSING) { ret =3D __open_session(mdsc, session); - if (ret) + if (ret) { + ceph_put_mds_session(session); return ERR_PTR(ret); + } } =20 return session; --=20 2.34.1