From nobody Fri Sep 25 02:06:41 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CEA14ABBBF; Thu, 17 Sep 2026 15:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789659361; cv=none; b=nuD2IZpgI3U/Q1INcXvRZT43JZw2laupcUKaGHolXoUoHf0IUVC9Mf/n8AWshv4Ppf+Yu7MBRv1JVTRPNCIjdBISjMn3S7Adfe5KT8fSJtNyolynwv4/Aznou8DyCuve1zjoLY2a3uzKLTTOL0b73Djt1TTLXztk1kREv/zMc3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789659361; c=relaxed/simple; bh=faQk4oBM6ipFIE7kPqu4vhA30jcr+003meSTLglZNaA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hfUDqqyaqi+u2aLHFJ3VQ+pPB93fl6xe2xjiDsNcLb0Re17uSMCGEYw+heZQceUFL76AZ8uHvoCX65jMSyGTZYue5yKRYYWYH7dKAEhZBUjX0PwRyFFvQF34NaNR+/n2sjIYh6vTuQvySSHICIADFjuh878feyMaisgLdZVO0Jk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAAHcz3WCKxqlauDCA--.46402S2; Thu, 17 Sep 2026 23:35:50 +0800 (CST) From: Wentao Liang To: conor.dooley@microchip.com Cc: daire.mcnamara@microchip.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] soc: microchip: mpfs: Fix flash leak in mpfs_sys_controller_probe() Date: Thu, 17 Sep 2026 15:35:50 +0000 Message-Id: <20260917153550.2160672-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAHcz3WCKxqlauDCA--.46402S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr1ftryUtF47JFWUGw15Arb_yoW8ZFWUpF 4UJrW7tF18KF45JF10kw18GF1fZFnFqw1kWws7Gw17A34fW3srZFy3A3yrWFy8JryIgr15 Cr45Ja1xJFsrAFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBFb7Iv0xC_KF4lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Cr1j6rxdMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VAI37AI020EjII2zVCS5cI20VAGYxC7MxkF 7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIEY20_Gr43Wr 1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr1j6F4UJwCI42IY6I8E87Iv6x kF7I0E14v26rxl6s0DYxBIdaVFxhVjvjDU0xZFpf9x07UMq2NUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBggNA2qr888yaQAAsm Content-Type: text/plain; charset="utf-8" of_get_mtd_device_by_node() returns an MTD device reference that the caller has to drop with put_mtd_device(). The probe error paths return without releasing it, and the reference stored in sys_controller->flash is never dropped when the controller is destroyed either. Release the flash on the probe error paths and in mpfs_sys_controller_delete(), so the reference is always put. Fixes: 742aa6c563d2 ("soc: microchip: mpfs: enable access to the system con= troller's flash") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/soc/microchip/mpfs-sys-controller.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/micr= ochip/mpfs-sys-controller.c index 92d1142a59e6..ad57b09e5807 100644 --- a/drivers/soc/microchip/mpfs-sys-controller.c +++ b/drivers/soc/microchip/mpfs-sys-controller.c @@ -98,6 +98,8 @@ static void mpfs_sys_controller_delete(struct kref *kref) struct mpfs_sys_controller *sys_controller =3D container_of(kref, struct mpfs_sys_controller, consumers); =20 + if (sys_controller->flash) + put_mtd_device(sys_controller->flash); mbox_free_channel(sys_controller->chan); kfree(sys_controller); } @@ -159,7 +161,8 @@ static int mpfs_sys_controller_probe(struct platform_de= vice *pdev) of_data =3D (struct mpfs_syscon_config *) device_get_match_data(dev); if (!of_data) { dev_err(dev, "Error getting match data\n"); - return -EINVAL; + ret =3D -EINVAL; + goto out_free; } =20 for (i =3D 0; i < of_data->nb_subdevs; i++) { @@ -174,6 +177,10 @@ static int mpfs_sys_controller_probe(struct platform_d= evice *pdev) return 0; =20 out_free: + if (!IS_ERR_OR_NULL(sys_controller->flash)) + put_mtd_device(sys_controller->flash); + if (!IS_ERR_OR_NULL(sys_controller->chan)) + mbox_free_channel(sys_controller->chan); kfree(sys_controller); return ret; } --=20 2.34.1