From nobody Fri Sep 25 02:09:26 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B2FE4D487C; Thu, 17 Sep 2026 15:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789659206; cv=none; b=NR4DwBUEXd+8fWY6GHcSFwiplTUjWenvSWgz5e/x1Mhji6af+PN3r7Y0SoCm0d2zaa0IgmBEl09yMET2MX4xjhnRXM7Eu3YrhISs1fWIHY3FYjUlJucUROzW08W7uLkEmzjzqc7GS5hEDfDZQ3MukgW5rn5pT+fuxMpYGKKzuAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789659206; c=relaxed/simple; bh=CdgRycZL3CvfqlhLX/AjZSwJtu40UTHd89J+mO8n5wU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=f8flPXKh2Q6zdqzPjHLsDBwXGDGM29v7WpzXWqpqOrCuygYaFmeTE2PQFKS+erLZ/YvKV/cRw8rSB/PEcrNNl6ohx9PFOFoc98sLN6uQO9w84JjHTIguIqsdvLfRNjYsfT+0VWhxMxxWEcPDRyFrEZZq8g5Xsq1O9cyOgqEULpY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowABHtD45CKxqAp+DCA--.5832S2; Thu, 17 Sep 2026 23:33:13 +0800 (CST) From: Wentao Liang To: angelogioacchino.delregno@collabora.com Cc: khilman@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, roger.lu@mediatek.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] soc: mediatek: mtk-svs: Fix device leak in svs_add_device_link() Date: Thu, 17 Sep 2026 15:33:13 +0000 Message-Id: <20260917153313.2160581-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABHtD45CKxqAp+DCA--.5832S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Zw1ktr15Wr1rKw4rXr1UZFb_yoW8JFWDpF WDKayqyryYqr129a17Ar1UZF15uayIk3s5Cr4rXwn7Zwn5Jr43XrWaqa4Fqw10yFWkGa13 JryqyrWxCw4xAr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBFb7Iv0xC_tr1lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Cr1j6rxdMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VAI37AI020EjII2zVCS5cI20VAGYxC7MxkF 7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIEY20_Gr43Wr 1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr1j6F4UJwCI42IY6I8E87Iv6x kF7I0E14v26rxl6s0DYxBIdaVFxhVjvjDU0xZFpf9x07UC38nUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgINA2qr888vQgABsb Content-Type: text/plain; charset="utf-8" svs_get_subsys_device() returns a reference to the supplier device that the caller must drop. svs_add_device_link() returns the reference to its callers on success, but the device_link_add() failure path and the probe deferral path return an error pointer without putting the device, so the reference is leaked. Drop the reference on both error paths. Fixes: 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/soc/mediatek/mtk-svs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 99edecb204f2..dd9643026c66 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2155,11 +2155,14 @@ static struct device *svs_add_device_link(struct sv= s_platform *svsp, DL_FLAG_AUTOREMOVE_CONSUMER); if (!sup_link) { dev_err(svsp->dev, "sup_link is NULL\n"); + put_device(dev); return ERR_PTR(-EINVAL); } =20 - if (sup_link->supplier->links.status !=3D DL_DEV_DRIVER_BOUND) + if (sup_link->supplier->links.status !=3D DL_DEV_DRIVER_BOUND) { + put_device(dev); return ERR_PTR(-EPROBE_DEFER); + } =20 return dev; } --=20 2.34.1