From nobody Fri Sep 25 02:09:40 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31FED53B60A; Thu, 17 Sep 2026 13:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789652232; cv=none; b=luKaxeKwbC1HS/l1/UOpauD98MZ0WxlLW/7ODwnY197KevpTGD3mt1Kd+cB0efcy9E1PVdjRHrzOmFc1RQ9/Mb6efpL9LLL6qjUNdJj9z43RLP7O7kSVuP6DJzxLcUH8UPRniOxh1VVCmVVPbVUqd0i1kWBohaFoJsUSb3/VAHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789652232; c=relaxed/simple; bh=kzfuAR9U+pp9ItRk4Kst4IliakV6UbEKC7jwdR+tLWc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mea7JTKPm6Zw909DJ9iNiHguyXZIqcRTcS78apztpero3in5YJoNzZSf81hcudcsKJXNC0N7eyD8OvhECRCwerjPO4vX5ZSyGu5A8N4V/6JtjSCuTjlOh5FPfTRdyt8uc55m0VN9/6BXy9dt9quIkKsAZKXhgY1cZeULYfI0Uu8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowACXAj3z7KtqxZmBCA--.3798S2; Thu, 17 Sep 2026 21:36:51 +0800 (CST) From: Wentao Liang To: alcooperx@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com, kishon@kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, vkoul@kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] phy: usb: Fix USB 3.0 clock reference leak in brcm_usb_phy_dvr_init() Date: Thu, 17 Sep 2026 13:36:51 +0000 Message-Id: <20260917133651.2153617-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACXAj3z7KtqxZmBCA--.3798S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KFW3XF17uFyxCFy3GFW7urg_yoW8XFyxpa nrKF4jyrn7C3y0kw4rXw1UZF1Yyw1IkasxKrW8Kw1F93W3Z347Z3WFvr1Svr1UCrW8Wws5 JrZ3Aas7GF1DCrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPqb7Iv0xC_Kw4lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Cr1j6rxdMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VAI37AI020EjII2zVCS5cI20VAGYxC7M4II rI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMx AIw28IcVCjz48v1sIEY20_Gr43Wr1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAq x4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r 43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF 7I0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI 0_Gr1j6F4UJwCI42IY6I8E87Iv6xkF7I0E14v26rxl6s0DYxBIdaVFxhVjvjDU0xZFpf9x 07bbXocUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgENA2qrq3bL7AABsz Content-Type: text/plain; charset="utf-8" brcm_usb_phy_dvr_init() obtains usb_30_clk with of_clk_get_by_name(), which takes a reference on the clock, but returns without calling clk_put() when clk_prepare_enable() fails, when the suspend clock request is deferred, or when devm_request_irq() fails. The clock is only handed to the driver on the success path, so nothing releases the reference on these paths. Drop it from the err_put_clks label, and clear usb_30_clk on the -EPROBE_DEFER path where it holds an error pointer rather than a reference. Fixes: 49859e55e364 ("phy: usb: phy-brcm-usb: Add Broadcom STB USB phy driv= er") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/phy/broadcom/phy-brcm-usb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy= -brcm-usb.c index 8ef8aa025789..d411512b1036 100644 --- a/drivers/phy/broadcom/phy-brcm-usb.c +++ b/drivers/phy/broadcom/phy-brcm-usb.c @@ -443,6 +443,7 @@ static int brcm_usb_phy_dvr_init(struct platform_device= *pdev, priv->usb_30_clk =3D of_clk_get_by_name(dn, "sw_usb3"); if (IS_ERR(priv->usb_30_clk)) { if (PTR_ERR(priv->usb_30_clk) =3D=3D -EPROBE_DEFER) { + priv->usb_30_clk =3D NULL; err =3D -EPROBE_DEFER; goto err_put_clks; } @@ -483,6 +484,7 @@ static int brcm_usb_phy_dvr_init(struct platform_device= *pdev, return 0; =20 err_put_clks: + clk_put(priv->usb_30_clk); clk_put(priv->usb_20_clk); return err; } --=20 2.34.1