From nobody Fri Sep 25 02:06:14 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540EE51990B; Thu, 17 Sep 2026 13:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789651366; cv=none; b=hMIwydQRt31PuzCZ/sWfGky07+bXVjJXz+9jO1jNhnZOSq19TlW2SGdDN2zqEd3SPl53JyUcaNDO0ZJxtMdnZZtVzbRJzis4i4bAwEsbqIxYeba44WU0kd3ycYQ7dPdlnwTUoz1CxgXZpdPk/njO1ShQ9d8o4ZQrvAjXE2AZRiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789651366; c=relaxed/simple; bh=IBSDO95QIb0nKVfM7awcFJXWl9SG1MvQhRpOppYdxCQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=KsRz7qwBbWyJOO3Dnqx/2X6MKPWv5mP18XB5CN68j6+Qqv2jm1w+Oh9P6rVknhp9x8VmgyEh3dgS97DQCaUVLszHil7KMHqOWWqRoSmyKd7Fd7PjjPa4fgOvElfzO/LTAjGx11aWhYw6JoHgFAwz1ranJQ3vHDRE7NcoVg3tNKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAC3Hzqb6atq9l6BCA--.3721S2; Thu, 17 Sep 2026 21:22:35 +0800 (CST) From: Wentao Liang To: Liviu.Dudau@arm.com Cc: bhelgaas@google.com, kwilczynski@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, robh@kernel.org, tinamdar@apm.com, toan@os.amperecomputing.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] PCI: xgene: Fix device node reference leak in xgene_pcie_probe() Date: Thu, 17 Sep 2026 13:22:35 +0000 Message-Id: <20260917132235.2153154-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAC3Hzqb6atq9l6BCA--.3721S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tr1DCFyrXF47uFWkCrW5trb_yoW8XrykpF WDWryF9r18tr4rWF4Iy3W5Z3Z0kFZay3yUGwsrC3WxZrnxGw1UXry2vFyqqF13KrW8Xry7 JF4DtF1xAF45J37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPSb7Iv0xC_KF4lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Cr1j6rxdMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VAI37AI020EjII2zVCS5cI20VAGYxC7M4II rI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMx AIw28IcVCjz48v1sIEY20_Gr43Wr1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAq x4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r 43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF 7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV W8Jr0_Cr1UMIIF0xvEx4A2jsIEc7CjxVAFwI0_GcCE3sUvcSsGvfC2KfnxnUUI43ZEXa7I U1zVbDUUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAQNA2qrrJq8KQAAsk Content-Type: text/plain; charset="utf-8" xgene_pcie_probe() takes a reference to the port's device node with of_node_get(), but returns directly from the error paths of xgene_pcie_map_reg(), xgene_pcie_init_port(), xgene_pcie_setup() and pci_host_probe(), leaking that reference on each of them. Add an err_put_node label that drops the reference before returning. Fixes: 5f6b6ccdbe1c ("PCI: xgene: Add APM X-Gene PCIe driver") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/pci/controller/pci-xgene.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pc= i-xgene.c index b95afa35201d..6b00ec60ede6 100644 --- a/drivers/pci/controller/pci-xgene.c +++ b/drivers/pci/controller/pci-xgene.c @@ -633,20 +633,28 @@ static int xgene_pcie_probe(struct platform_device *p= dev) =20 ret =3D xgene_pcie_map_reg(port, pdev); if (ret) - return ret; + goto err_put_node; =20 ret =3D xgene_pcie_init_port(port); if (ret) - return ret; + goto err_put_node; =20 ret =3D xgene_pcie_setup(port); if (ret) - return ret; + goto err_put_node; =20 bridge->sysdata =3D port; bridge->ops =3D &xgene_pcie_ops; =20 - return pci_host_probe(bridge); + ret =3D pci_host_probe(bridge); + if (ret) + goto err_put_node; + + return 0; + +err_put_node: + of_node_put(port->node); + return ret; } =20 static const struct of_device_id xgene_pcie_match_table[] =3D { --=20 2.34.1