From nobody Fri Sep 25 02:44:19 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56CDB4FB9C0; Thu, 17 Sep 2026 12:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648531; cv=none; b=gYUXnucffPoOE+ch+LAQ0hEETdbcEn/hAJEtapzUgj1ZSQNhkOhSCmOnggt33aOdoU/9pj4c2VZ4LjaVkP8dLpbESu7oAfZZVWCQlfyN0Qq6irRaHxxo0vD2jEsRs0jceCZs/+Ql/iQYTIHmOfHtxKLZokc1LQVm88kc8O86FWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648531; c=relaxed/simple; bh=CpT81OJak+6beIWmjpWgL1zezlF9ucCemaOhdOMeCfk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bbKwr/eLjoJi93bCSgYWalRF30+exgfg8HTtEVp8SRuHrTyxb++x2x0U84yfuC/h9BeVe7fD7iLsnj8ynXuINmzaWd474fHj8S43mFpcpxagCVgW/ci4S7Lf3KLYMF5VU5zgR1RlTukloEEWoI9YvE8R65TsLsFnM/Kujhl3nAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAA3oDqC3qtqBZ6ACA--.2681S2; Thu, 17 Sep 2026 20:35:14 +0800 (CST) From: Wentao Liang To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com, srini@kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] nvmem: layouts: onie-tlv: Fix np reference leak in onie_tlv_add_cells() Date: Thu, 17 Sep 2026 12:35:14 +0000 Message-Id: <20260917123514.2151346-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAA3oDqC3qtqBZ6ACA--.2681S2 X-Coremail-Antispam: 1UD129KBjvdXoW7WryrAryUtFyxAr4xJw43Wrg_yoWDJFc_W3 Wv9r9rXF18CFsFyrnIkr1fZr97tan3WFs7AFs2qFn3Aw43ZF15Awn5Zwn5Jw1UurWfKFZ3 Crn3AFyFvry7GjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfAYjsxI4VWDJwAYFVCjjxCrM7CY07I20VC2zVCF04k26cxKx2IY s7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4 kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_ Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv67AKxVW8Jr0_Cr1UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VAI37AI020EjII2zVCS5cI20VAGYxC7MxkF 7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIEY20_Gr43Wr 1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8Jr0_Cr1UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_GcCE3sUvcSsGvfC2KfnxnUUI43ZEXa7IU8xMa5UUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRMNA2qrq02hpgABs1 Content-Type: text/plain; charset="utf-8" of_get_child_by_name() returns a node with an elevated reference count. nvmem_add_one_cell() only takes ownership of that reference on success, so the caller must drop it when the call fails. Add the missing of_node_put() before returning so that cell.np is not leaked. Fixes: d3c0d12f6474 ("nvmem: layouts: onie-tlv: Add new layout driver") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/nvmem/layouts/onie-tlv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/layouts/onie-tlv.c b/drivers/nvmem/layouts/onie-= tlv.c index 0967a32319a2..3d77680f089b 100644 --- a/drivers/nvmem/layouts/onie-tlv.c +++ b/drivers/nvmem/layouts/onie-tlv.c @@ -128,6 +128,7 @@ static int onie_tlv_add_cells(struct device *dev, struc= t nvmem_device *nvmem, =20 ret =3D nvmem_add_one_cell(nvmem, &cell); if (ret) { + of_node_put(cell.np); of_node_put(layout); return ret; } --=20 2.34.1