From nobody Fri Sep 25 02:44:30 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576B64DBD8E; Thu, 17 Sep 2026 12:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789647823; cv=none; b=bFaYXJQ8vHRzW4g22Kxkv5/DoU/9EyblaA7Ikq9XYtKxbwexOdaYA/EdjYnzFr5ClxD4LJUwRlOgvoRzOi/THY33qEpun9OmOPq9tHrQvlI8g4Htpg2BG4P44C3ljCSryX/xZHx9ti96+oFDq/qk8Y53V4SjvCRvdUU7H35QAiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789647823; c=relaxed/simple; bh=xrUZu1m96kP0bWF1ZLqIWrd6JC3s7r6LqZXt+qHPkAM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LuzEDuKGzCQm6rDVV8UNGvGlCyDqX6EZz3s5voKd554cHgXYpsCDQ7i8sgEpXkba35MyNUjz97AQyQ5l/KKNd8oy6QqqFvy7C6zUYxd7inmy0v4ZxnfjCItP1nLmNP7EDU4FPXjLhourZUqVza/cW3lcAtekQiwQb8FVmqB7dQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowACHuEK926tqOG+ACA--.2682S2; Thu, 17 Sep 2026 20:23:26 +0800 (CST) From: Wentao Liang To: kvalo@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, tony@atomide.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] wifi: wlcore: Fix runtime PM leak in wlcore_remove() Date: Thu, 17 Sep 2026 12:23:25 +0000 Message-Id: <20260917122325.2150910-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACHuEK926tqOG+ACA--.2682S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Xw13Aw15WrW7Jr1kKFy3Jwb_yoW8JF4Upa 15XayjkryDGanrtw4UJ3Wv9FyFvayFyFZxWr4fCa4fZr4rJry5Jw15Zas0vFyYyrZYkFWU Zr1jqr13JF98A3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBFb7Iv0xC_KF4lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0E0s8F02x267IIx4CEVc8vx2IErcIFxwCY 1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6cx26r48Zr WUJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr1j6F4UJwCI42IY6I8E87Iv6x kF7I0E14v26rxl6s0DYxBIdaVFxhVjvjDU0xZFpf9x07j0GQhUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwYNA2qrrRmNlwAAsg Content-Type: text/plain; charset="utf-8" pm_runtime_get_sync() keeps the runtime PM usage counter elevated even when it returns an error, so the reference taken at the beginning of wlcore_remove() has to be dropped on every exit path. When the device was not initialized the function returned early without doing so, leaking the reference. Release it with pm_runtime_put_noidle() as done on the other early error paths of this driver. Fixes: fa2648a34e73f ("wlcore: Add support for runtime PM") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/net/wireless/ti/wlcore/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/t= i/wlcore/main.c index 1c340a4a0930..770059f3f992 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -6810,8 +6810,10 @@ void wlcore_remove(struct platform_device *pdev) =20 if (pdev_data->family && pdev_data->family->nvs_name) wait_for_completion(&wl->nvs_loading_complete); - if (!wl->initialized) + if (!wl->initialized) { + pm_runtime_put_noidle(wl->dev); return; + } =20 if (wl->wakeirq >=3D 0) { dev_pm_clear_wake_irq(wl->dev); --=20 2.34.1