From nobody Fri Sep 25 02:44:11 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7384D4AC156; Thu, 17 Sep 2026 12:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789646485; cv=none; b=DFiwRCRFuqngZZq26Tm8HvJnTWmQGzzI92sUA/rwQvBQbt0Rq0noYjD4r7cOdllHiCiEHSZjp3hsgFHrM+y7PQJ8Maj260Gfua2BmIuNHtD0o1kye1MVodprkbhAJEa6G07pSDNSTUVuzgRnDhwCzhB/e9yop51Mhgbz4SIISxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789646485; c=relaxed/simple; bh=/OgrwaO4oeIrHRdnl244GMwf3s9rHjn2oa/z5GK3FR0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=PHfox0ycsP4H6Kz9otby23fVg7Nq1WuzyZkScn8aWr+ZUEHTs7ruoL/vjktDArodqgU8H7ya3hUcSTVwoE7+cm4YP4rdb1QZkjXkZ8wlgARcQYy4g1s6A/zHZN6TortO3B0zrWbWQ6BRgU5x/+zLiO6Z6DXYO9DQhd/nbX+dEA0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAC36EKI1qtqwxWACA--.2297S2; Thu, 17 Sep 2026 20:01:12 +0800 (CST) From: Wentao Liang To: ath10k@lists.infradead.org Cc: jjohnson@kernel.org, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, quic_wgong@quicinc.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] wifi: ath10k: Fix skb leak when hl TX submission fails Date: Thu, 17 Sep 2026 12:01:12 +0000 Message-Id: <20260917120112.2150211-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAC36EKI1qtqwxWACA--.2297S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Gr43tFW5tr4xCrW3Ww18AFb_yoWkJFg_Kr 1F93Z3Zry8G3ZFkr1UAF48Aw12kFyvqF95Wr4Sqry8XrW7JrWDCr9Yvwn8WrnrGrWxZF1Y kFnrXa4Ut3yqgjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSxYjsxI4VWkCwAYFVCjjxCrM7CY07I20VC2zVCF04k26cxKx2IY s7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4 kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_ Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0E0s8F02x267IIx4CEVc8vx2IErcIFxwCY 1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6cx26r48Zr WUJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4UJVWxJr1lIxAIcVC2z280aV CY1x0267AKxVW0oVCq3bIYCTnIWIevJa73UjIFyTuYvjxU2G-eUUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgQNA2qrq3aHOAAAsv Content-Type: text/plain; charset="utf-8" ath10k_htt_tx_hl() takes an extra reference on the msdu with skb_get(), which is normally dropped by ath10k_htt_htc_tx_complete(). When ath10k_htc_send_hl() fails it does not free the skb and no completion runs, so that reference is never released. Drop the reference on the error path. Fixes: c8334512f3dd ("ath10k: add htt TX bundle for sdio") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireles= s/ath/ath10k/htt_tx.c index d6f1d85ba871..24617d610297 100644 --- a/drivers/net/wireless/ath/ath10k/htt_tx.c +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c @@ -1377,6 +1377,8 @@ static int ath10k_htt_tx_hl(struct ath10k_htt *htt, e= num ath10k_hw_txrx_mode txm tx_desc->peerid =3D __cpu_to_le32(HTT_INVALID_PEERID); =20 res =3D ath10k_htc_send_hl(&htt->ar->htc, htt->eid, msdu); + if (res) + dev_kfree_skb_any(msdu); =20 out: return res; --=20 2.34.1