From nobody Fri Sep 25 02:43:34 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71904495526; Thu, 17 Sep 2026 10:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789639656; cv=none; b=G+VHq7U0XWO4kB2FIXkhU29zT9+8Ha/q/fnzBGibqQDa7/UhSkM34Tiv+Ftqt0tcRkkthCp+tQbn+v3NrNZKAm7KA3wRKk75WgmWXTU2JHZoXLYFVxqEdmJHjhb11iJ0ss6hXhgMNeO/zk16xJvwST4ePqaEWk+qaXuV1Uu9szo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789639656; c=relaxed/simple; bh=AeOsnyrO5WmB70Fc90ZRgGrgHk0I4u99uZ3HenVA3Ck=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gye4Q9P1DUDsp+I4BqKlRF2n6H6/r/Mphwjh7mJ817M8OVP4nDGmkpJUSKtOuDie1VM50DWuYrgDXn1m8Lanrt6S/KFPQQ7BbBrPRWusrgDMut1o0kNIGEMloh/73Nd6qQ9T24ah18F3ESrk4O1OTXhvtmv61622cAnR8zkqsUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowACHuELZu6tqD0t+CA--.353S2; Thu, 17 Sep 2026 18:07:21 +0800 (CST) From: Wentao Liang To: angelogioacchino.delregno@collabora.com Cc: hverkuil@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, mchehab@kernel.org, moudy.ho@mediatek.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] media: platform: mtk-mdp3: Fix device reference leak in mdp_comp_init() Date: Thu, 17 Sep 2026 10:07:21 +0000 Message-Id: <20260917100721.2146044-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACHuELZu6tqD0t+CA--.353S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uw4xCFyUCr15tr15tw1xGrg_yoW8tw1fpF WUKay5ArW8WFsFgF4Yy3WDu3W5Aw1S9ayUWr1xtw1Iy3ZxWrWUGFy0v3WqvrZ5AF9aya43 J3W8tryxuayUZaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPvb7Iv0xC_Kw4lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxV W0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0E0s8F02x267IIx4CEVc8vx2IErcIFxwAC I402YVCY1x02628vn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrw CF04k20xvE74AGY7Cv6cx26r48ZrWUJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E 5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtV W8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY 1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14 v26r4UJVWxJr1lIxAIcVC2z280aVCY1x0267AKxVW0oVCq3bIYCTnIWIevJa73UjIFyTuY vjxUqdHjUUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgkNA2qrq3ZB1gAAsK Content-Type: text/plain; charset="utf-8" mdp_comp_init() takes a reference to the component platform device with of_find_device_by_node(), but the error path taken when the clock array cannot be allocated and the one taken for a component without a GCE EOF event return without dropping it. The caller frees the mdp_comp in those cases, so the reference is leaked. Release the reference on both error paths. Fixes: c4320f9721fd ("media: platform: mtk-mdp3: dynamically allocate compo= nent clocks") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- .../media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers= /media/platform/mediatek/mdp3/mtk-mdp3-comp.c index 7fcb2fbdd64e..acb2758a7b42 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c @@ -1730,6 +1730,7 @@ static int mdp_comp_init(struct mdp_dev *mdp, struct = device_node *node, struct device *dev =3D &mdp->pdev->dev; struct platform_device *pdev_c; int clk_ofst; + int ret; int i; s32 event; =20 @@ -1756,8 +1757,10 @@ static int mdp_comp_init(struct mdp_dev *mdp, struct= device_node *node, comp->clk_num =3D mdp->mdp_data->comp_data[id].info.clk_num; comp->clks =3D devm_kzalloc(dev, sizeof(struct clk *) * comp->clk_num, GFP_KERNEL); - if (!comp->clks) - return -ENOMEM; + if (!comp->clks) { + ret =3D -ENOMEM; + goto err_put_device; + } =20 clk_ofst =3D mdp->mdp_data->comp_data[id].info.clk_ofst; =20 @@ -1782,7 +1785,8 @@ static int mdp_comp_init(struct mdp_dev *mdp, struct = device_node *node, if (of_property_read_u32_index(node, "mediatek,gce-events", MDP_GCE_EVENT_EOF, &event)) { dev_err(dev, "Component id %d has no EOF\n", id); - return -EINVAL; + ret =3D -EINVAL; + goto err_put_device; } } else { event =3D MDP_GCE_NO_EVENT; @@ -1791,6 +1795,10 @@ static int mdp_comp_init(struct mdp_dev *mdp, struct= device_node *node, comp->gce_event[MDP_GCE_EVENT_EOF] =3D event; =20 return 0; + +err_put_device: + put_device(&pdev_c->dev); + return ret; } =20 static void mdp_comp_deinit(struct mdp_comp *comp) --=20 2.34.1